[PATCH 3/3] staging: cxt1e1: remove set a value to static variable

2014-05-08 Thread Daeseok Youn
cleanup checkpatch.pl error: ERROR: do not initialise statics to 0 or NULL Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/musycc.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/cxt1e1/musycc.c b/drivers/staging/cxt1e1/musycc.c index 89f905

[PATCH 2/3] Staging: cxt1e1: Fix line length over 80 characters in musycc.c

2014-05-08 Thread Daeseok Youn
clean up checkpatch.pl warning WARNING: Line length over 80 characters Signed-off-by: Daeseok Youn --- drivers/staging/cxt1e1/musycc.c | 29 +++-- 1 files changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/staging/cxt1e1/musycc.c b/drivers/staging/cxt1e1/

Re: [PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify errorhandleandremovesmatch warnings"

2014-05-08 Thread micky
Hi Ulf On 05/08/2014 04:22 PM, Ulf Hansson wrote: On 8 May 2014 09:55, Lee Jones wrote: It seems Chris is too busy to responding, so would you help to pick this patch for 3.15 fix. H... that's pretty bad timing. I've literally just sent the pull-request containing the MFD/MMC fixup branc

Re: [patch v2] Documentation/email-clients.txt: add a section about git

2014-05-08 Thread Namhyung Kim
Hi Dan, On Thu, 8 May 2014 11:44:12 +0300, Dan Carpenter wrote: > These days most people use git to send patches so I have added a section > about that. > > Signed-off-by: Dan Carpenter > --- > v2: Fixed changelog > > diff --git a/Documentation/email-clients.txt b/Documentation/email-clients.txt

[PATCH net-next, v3] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-08 Thread Haiyang Zhang
This change ensures the driver can be built successfully without the CONFIG_SYSFS flag. MS-TFS: 182270 Signed-off-by: Haiyang Zhang Reviewed-by: K. Y. Srinivasan --- drivers/net/hyperv/netvsc_drv.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/net/hyperv/n

RE: [PATCH net-next,v2] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-08 Thread Haiyang Zhang
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, May 8, 2014 4:45 PM > To: Haiyang Zhang > Cc: net...@vger.kernel.org; KY Srinivasan; o...@aepfle.de; > jasow...@redhat.com; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.org > Su

Re: [PATCH net-next,v2] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-08 Thread David Miller
From: Haiyang Zhang Date: Thu, 8 May 2014 13:41:33 -0700 > +static inline void netvsc_record_rx_queue(struct sk_buff *skb, > + struct hv_netvsc_packet *packet, > + struct net_device *ndev) > +{ > +#ifdef CONFIG_SYSFS > +

RE: [PATCH net-next, v2] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-08 Thread Haiyang Zhang
> -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Thursday, May 8, 2014 4:04 PM > To: Haiyang Zhang > Cc: da...@davemloft.net; net...@vger.kernel.org; o...@aepfle.de; > jasow...@redhat.com; driverdev-devel@linuxdriverproject.org; linux- > ker...@vger.kernel.org > Subjec

Re: [PATCH net-next, v2] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-08 Thread Greg KH
On Thu, May 08, 2014 at 01:41:33PM -0700, Haiyang Zhang wrote: > This change ensures the driver can be built successfully without the > CONFIG_SYSFS flag. > MS-TFS: 182270 > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan > --- > drivers/net/hyperv/hyperv_net.h | 28 +

RE: [PATCH net-next] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-08 Thread Haiyang Zhang
> -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Thursday, May 8, 2014 3:07 PM > To: Haiyang Zhang > Cc: da...@davemloft.net; net...@vger.kernel.org; o...@aepfle.de; > jasow...@redhat.com; driverdev-devel@linuxdriverproject.org; linux- > ker...@vger.kernel.org > Subjec

[PATCH net-next, v2] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-08 Thread Haiyang Zhang
This change ensures the driver can be built successfully without the CONFIG_SYSFS flag. MS-TFS: 182270 Signed-off-by: Haiyang Zhang Reviewed-by: K. Y. Srinivasan --- drivers/net/hyperv/hyperv_net.h | 28 drivers/net/hyperv/netvsc_drv.c | 13 +++-- dr

Re: [PATCH net-next] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-08 Thread Greg KH
On Thu, May 08, 2014 at 03:13:19PM +, Haiyang Zhang wrote: > > > > -Original Message- > > From: Greg KH [mailto:g...@kroah.com] > > Sent: Thursday, May 8, 2014 5:13 AM > > To: Haiyang Zhang > > Cc: da...@davemloft.net; net...@vger.kernel.org; o...@aepfle.de; > > jasow...@redhat.com; d

RE: [PATCH net-next] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-08 Thread Haiyang Zhang
> -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Thursday, May 8, 2014 5:13 AM > To: Haiyang Zhang > Cc: da...@davemloft.net; net...@vger.kernel.org; o...@aepfle.de; > jasow...@redhat.com; driverdev-devel@linuxdriverproject.org; linux- > ker...@vger.kernel.org > Subjec

Re: [PATCH] staging: winbond: use dev_err() instead of printk()

2014-05-08 Thread Dan Carpenter
On Thu, May 08, 2014 at 01:38:33PM +0200, Martin Kepplinger wrote: > For obvious error messages, use dev_err() in order to provide userspace > with more useful information and use the common kernel coding style. > > Signed-off-by: Martin Kepplinger > --- > this applies to v3.15-rc4 > Do these k

[PATCH] staging: winbond: use dev_err() instead of printk()

2014-05-08 Thread Martin Kepplinger
For obvious error messages, use dev_err() in order to provide userspace with more useful information and use the common kernel coding style. Signed-off-by: Martin Kepplinger --- this applies to v3.15-rc4 greetings from Linuxdays Vienna, Austria drivers/staging/winbond/wb35tx.c |6 +++--- 1

Re: [PATCH v2] staging: lirc: Fix sparse warnings

2014-05-08 Thread Dan Carpenter
On Thu, May 08, 2014 at 02:13:17PM +0300, Tuomas Tynkkynen wrote: > Fix sparse warnings by adding __user and __iomem annotations where > necessary and removing certain unnecessary casts. While at it, > also use u32 in place of __u32. > > Signed-off-by: Tuomas Tynkkynen Thanks. Reviewed-by: Dan

[PATCH v2] staging: lirc: Fix sparse warnings

2014-05-08 Thread Tuomas Tynkkynen
Fix sparse warnings by adding __user and __iomem annotations where necessary and removing certain unnecessary casts. While at it, also use u32 in place of __u32. Signed-off-by: Tuomas Tynkkynen --- Compile tested only. v2 changes: - introduce variable 'uptr' instead of open-coding (__u32 *)a

Re: [PATCH] staging: lirc: Fix sparse warnings

2014-05-08 Thread Dan Carpenter
On Thu, May 08, 2014 at 01:30:28PM +0300, Dan Carpenter wrote: > On Thu, May 08, 2014 at 01:11:48PM +0300, Tuomas Tynkkynen wrote: > > Fix sparse warnings by adding __user and __iomem annotations where > > necessary and removing certain unnecessary casts. > > > > Signed-off-by: Tuomas Tynkkynen >

Re: [PATCH] staging: lirc: Fix sparse warnings

2014-05-08 Thread Dan Carpenter
On Thu, May 08, 2014 at 01:11:48PM +0300, Tuomas Tynkkynen wrote: > Fix sparse warnings by adding __user and __iomem annotations where > necessary and removing certain unnecessary casts. > > Signed-off-by: Tuomas Tynkkynen This patch adds spaces between the cast and the variable. There shouldn'

[PATCH] staging: lirc: Fix sparse warnings

2014-05-08 Thread Tuomas Tynkkynen
Fix sparse warnings by adding __user and __iomem annotations where necessary and removing certain unnecessary casts. Signed-off-by: Tuomas Tynkkynen --- Compile tested only. drivers/staging/media/lirc/lirc_bt829.c|6 +++--- drivers/staging/media/lirc/lirc_parallel.c | 17 +-

Re: [patch v2] Documentation/email-clients.txt: add a section about git

2014-05-08 Thread Hillf Danton
On Thu, May 8, 2014 at 5:05 PM, Julian Andres Klode wrote: > On Thu, May 08, 2014 at 11:44:12AM +0300, Dan Carpenter wrote: >> +as raw text including all the headers. Run `cat raw_email.txt | git am` > > `cat raw_email.txt | git am` seems a bit pointless. Why not simply > `git am raw_email.txt`?

Re: [PATCH] Staging: gdm72xx Fix minor coding style problems

2014-05-08 Thread Joe Perches
On Thu, 2014-05-08 at 11:53 +0530, Adithya K wrote: > This is patch for fixing of minor coding style problems. [] > diff --git a/drivers/staging/gdm72xx/gdm_qos.c > b/drivers/staging/gdm72xx/gdm_qos.c [] > @@ -229,6 +229,7 @@ static u32 extract_qos_list(struct nic *nic, struct > list_head *head)

Re: [PATCH net-next] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-08 Thread Greg KH
On Wed, May 07, 2014 at 03:45:04PM -0700, Haiyang Zhang wrote: > This change ensures the driver can be built successfully without the > CONFIG_SYSFS flag. > MS-TFS: 182270 > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan > --- > drivers/net/hyperv/hyperv_net.h |2 ++ > dri

Re: [patch v2] Documentation/email-clients.txt: add a section about git

2014-05-08 Thread Julian Andres Klode
On Thu, May 08, 2014 at 11:44:12AM +0300, Dan Carpenter wrote: > +as raw text including all the headers. Run `cat raw_email.txt | git am` `cat raw_email.txt | git am` seems a bit pointless. Why not simply `git am raw_email.txt`? `git am < raw_email.txt` does the same too and avoids the useless ca

[patch v2] Documentation/email-clients.txt: add a section about git

2014-05-08 Thread Dan Carpenter
These days most people use git to send patches so I have added a section about that. Signed-off-by: Dan Carpenter --- v2: Fixed changelog diff --git a/Documentation/email-clients.txt b/Documentation/email-clients.txt index 4e30eba..9004a5fd 100644 --- a/Documentation/email-clients.txt +++ b/Docu

Re: [PATCH v2] mmc: rtsx: fix possible linking error if built-in

2014-05-08 Thread Ulf Hansson
On 8 May 2014 10:27, Arnd Bergmann wrote: > rtsx_usb_sdmmc module uses the LED classdev if available, but the code > failed to consider the situation that it is built-in and the LED classdev is a > module, leading to following linking error: > >LD init/built-in.o > drivers/built-in.o: In

Re: [PATCH] mmc: rtsx: usb backend needs LED support

2014-05-08 Thread Ulf Hansson
>>> >>> From: Roger Tseng >>> Date: Wed, 30 Apr 2014 11:11:25 +0800 >>> Subject: [PATCH] mmc: rtsx: fix possible linking error if built-in >>> >>> rtsx_usb_sdmmc module uses the LED classdev if available, but the code >>> failed >>> to consider the situation that it is built-in and the LED classde

Re: [PATCH] mmc: rtsx: usb backend needs LED support

2014-05-08 Thread Lee Jones
> >>From: Roger Tseng > >>Date: Wed, 30 Apr 2014 11:11:25 +0800 > >>Subject: [PATCH] mmc: rtsx: fix possible linking error if built-in > >> > >>rtsx_usb_sdmmc module uses the LED classdev if available, but the code > >>failed > >>to consider the situation that it is built-in and the LED classdev i

[PATCH v2] mmc: rtsx: fix possible linking error if built-in

2014-05-08 Thread Arnd Bergmann
rtsx_usb_sdmmc module uses the LED classdev if available, but the code failed to consider the situation that it is built-in and the LED classdev is a module, leading to following linking error: LD init/built-in.o drivers/built-in.o: In function `rtsx_usb_sdmmc_drv_remove': rtsx_usb_sdmmc.c

Re: [PATCH] mmc: rtsx: usb backend needs LED support

2014-05-08 Thread Arnd Bergmann
On Thursday 08 May 2014 16:08:15 Roger wrote: > > Would this patch be merged into linux-next or Lee's mfd.git > ib-mfd-mmc-memstick-3.16 branch? It should get merged into whatever tree holds the existing patches, yes > By the way, should I resend my version? Actually I found another issue with

Re: [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req"

2014-05-08 Thread Lee Jones
> >> This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d. > >> > >> commit did use > >> mutex_unlock() in tasklet, but mutex_unlock() can't used in > >> tasklet(atomic context). The driver need use mutex to avoid concurrency, > >> so we can't use tasklet here, the patch need to be removed

Re: [PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify error handleandremove smatch warnings"

2014-05-08 Thread Ulf Hansson
On 8 May 2014 09:55, Lee Jones wrote: >> It seems Chris is too busy to responding, so would you help to pick >> this patch for 3.15 fix. > > H... that's pretty bad timing. I've literally just sent the > pull-request containing the MFD/MMC fixup branch to Linus. I guess > Ulf will have to do

Re: [PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify error handleandremove smatch warnings"

2014-05-08 Thread Lee Jones
> It seems Chris is too busy to responding, so would you help to pick > this patch for 3.15 fix. H... that's pretty bad timing. I've literally just sent the pull-request containing the MFD/MMC fixup branch to Linus. I guess Ulf will have to do it. > >>>From: Micky Ching > >>> > >>>This reve

Re: [PATCH] mmc: rtsx: usb backend needs LED support

2014-05-08 Thread Roger
On 04/30/2014 04:19 PM, Ulf Hansson wrote: On 30 April 2014 05:34, Roger wrote: On 04/29/2014 08:46 PM, Arnd Bergmann wrote: On Tuesday 29 April 2014 13:05:15 Ulf Hansson wrote: On 29 April 2014 11:45, Arnd Bergmann wrote: drivers/built-in.o: In function `rtsx_usb_sdmmc_drv_remove': :(

Re: [PATCH] Staging: gdm72xx Fix minor coding style problems

2014-05-08 Thread Dan Carpenter
On Wed, May 07, 2014 at 11:40:50PM -0700, Joe Perches wrote: > On Thu, 2014-05-08 at 11:53 +0530, Adithya K wrote: > > This is patch for fixing of minor coding style problems. > [] > > diff --git a/drivers/staging/gdm72xx/gdm_qos.c > > b/drivers/staging/gdm72xx/gdm_qos.c > [] > > @@ -229,6 +229,7

Re: [PATCH] Staging: gdm72xx Fix minor coding style problems

2014-05-08 Thread Dan Carpenter
On Thu, May 08, 2014 at 11:53:57AM +0530, Adithya K wrote: > This is patch for fixing of minor coding style problems. > > Signed-off-by: Adithya K > --- > drivers/staging/gdm72xx/gdm_qos.c |3 ++- > drivers/staging/gdm72xx/gdm_sdio.c |1 + > drivers/staging/gdm72xx/gdm_usb.c |2