Re: [PATCH net-next,v3] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-11 Thread David Miller
From: Haiyang Zhang Date: Thu, 8 May 2014 15:14:10 -0700 > This change ensures the driver can be built successfully without the > CONFIG_SYSFS flag. > MS-TFS: 182270 > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan Applied, thanks.

[PATCH] staging/lustre: fix sparse warnings in o2iblnd_cb.c

2014-05-11 Thread Zi Shen Lim
This patch fixes the following sparse warnings: drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:44:1: warning: symbol 'kiblnd_tx_done' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:102:10: warning: symbol 'kiblnd_get_idle_tx' was not declare

Re: [patch] [media] Staging: dt3155v4l: set error code on failure

2014-05-11 Thread Jingoo Han
On Friday, May 09, 2014 8:55 PM, Dan Carpenter wrote: > > We should be returning -ENOMEM here instead of success. > > Signed-off-by: Dan Carpenter It looks good. video_device_alloc() calls kzalloc(); thus, when video_device_alloc() returns NULL, '-ENOMEM' should be returned. Reviewed-by: Jingo

RE: [PATCH net-next,v2] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-11 Thread Haiyang Zhang
> > From: Ben Hutchings > Sent: Sunday, May 11, 2014 9:07 AM > To: Haiyang Zhang > I think most other drivers have a 1-1 mapping between hardware RX queues > and the RX queue indices reported to Linux. It appears that in this > case sub_channel_index is th

[PATCH] staging: xillybus: Use devm_ API on probe and remove

2014-05-11 Thread Eli Billauer
Suggested-by: Baruch Siach Signed-off-by: Eli Billauer --- drivers/staging/xillybus/xillybus.h |1 - drivers/staging/xillybus/xillybus_core.c |2 +- drivers/staging/xillybus/xillybus_of.c | 47 - drivers/staging/xillybus/xillybus_pcie.c | 65 ---

[PATCH v2 2/2] Fix lines with more than 80 chars in staging/octeon-usb/octeon-hcd.c

2014-05-11 Thread Paul Davies C
Some lines with more than 80 characters are converted in to multiple lines. Signed-off-by: Paul Davies C --- drivers/staging/octeon-usb/octeon-hcd.c | 89 +++ 1 file changed, 66 insertions(+), 23 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/

[PATCH v2 0/2] drivers: staging: octeon-usb: Fix coding style

2014-05-11 Thread Paul Davies C
Fix some coding style issues in drivers/staging/octeon-usb/octeon-hcd.c. Paul Davies C (2): Add blank line after all declarations in staging/octeon-usb/octeon-hcd.c Fix lines with more than 80 chars in staging/octeon-usb/octeon-hcd.c drivers/staging/octeon-usb/octeon-hcd.c | 108 +++

[PATCH v2 1/2] Add blank line after all declarations in staging/octeon-usb/octeon-hcd.c

2014-05-11 Thread Paul Davies C
Add blank lines after each declarations in drivers/staging/octeon-usb/octeon-hcd.c. Signed-off-by: Paul Davies C --- drivers/staging/octeon-usb/octeon-hcd.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/driv

Re: [PATCH net-next,v2] Add support for netvsc build without CONFIG_SYSFS flag

2014-05-11 Thread Ben Hutchings
On Thu, 2014-05-08 at 20:50 +, Haiyang Zhang wrote: > > > -Original Message- > > From: David Miller [mailto:da...@davemloft.net] > > Sent: Thursday, May 8, 2014 4:45 PM > > To: Haiyang Zhang > > Cc: net...@vger.kernel.org; KY Srinivasan; o...@aepfle.de; > > jasow...@redhat.com; linux-k

Re: [PATCH] [resend] net: get rid of SET_ETHTOOL_OPS

2014-05-11 Thread Wilfried Klaebe
Am Sun, May 11, 2014 at 01:13:47PM +0530 schrieb Anish Khurana: > SET_ETHTOOL_OPS is equivalent to : > #define SET_ETHTOOL_OPS(netdev,ops) \ > ( (netdev)->ethtool_ops = (ops) ) > > how it makes difference removing this code and replacing with the > code mentioned ? It doesn't change anything

Re: [PATCH 2/3] Enclose complex macro with parantheses in staging/octeon-usb/octeon-hcd.c

2014-05-11 Thread Paul Davies C
On Sunday 11 May 2014 04:25 PM, Aaro Koskinen wrote: Hi, On Sun, May 11, 2014 at 01:38:22PM +0530, Paul Davies C wrote: Complex macro is enlosed with parantheses. This patch breaks compilation. I'll send patches to remove the whole macro. A. I hope everything else is ok with you. I will drop

[PATCH 2/2] staging: octeon-usb: use generic prefetch

2014-05-11 Thread Aaro Koskinen
Use generic prefetch. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index 2489a34..65169f9 100644 --

[PATCH 1/2] staging: octeon-usb: delete redudant prefetches

2014-05-11 Thread Aaro Koskinen
cvmx_usb_pipe fits into a cache-line so additional prefetches are not really helping anything. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeo

Re: [PATCH 2/3] Enclose complex macro with parantheses in staging/octeon-usb/octeon-hcd.c

2014-05-11 Thread Aaro Koskinen
Hi, On Sun, May 11, 2014 at 01:38:22PM +0530, Paul Davies C wrote: > Complex macro is enlosed with parantheses. This patch breaks compilation. I'll send patches to remove the whole macro. A. ___ devel mailing list de...@linuxdriverproject.org http://dr

[PATCH 2/3] Enclose complex macro with parantheses in staging/octeon-usb/octeon-hcd.c

2014-05-11 Thread Paul Davies C
Complex macro is enlosed with parantheses. Signed-off-by: Paul Davies C --- drivers/staging/octeon-usb/octeon-hcd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index a65d6f8..d03095a 100

[PATCH 3/3] Fix lines with more than 80 chars in staging/octeon-usb/octeon-hcd.c

2014-05-11 Thread Paul Davies C
Lines with more than 80 characters are converted in to multiple lines. Signed-off-by: Paul Davies C --- drivers/staging/octeon-usb/octeon-hcd.c | 89 +++ 1 file changed, 66 insertions(+), 23 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drive

[PATCH 1/3] Add blank line after all declarations in staging/octeon-usb/octeon-hcd.c

2014-05-11 Thread Paul Davies C
Blank lines are added after each declaration in the file. Signed-off-by: Paul Davies C --- drivers/staging/octeon-usb/octeon-hcd.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octe

[PATCH 0/3] Fix coding style of staging/octeon-usb/octeon-hcd.c

2014-05-11 Thread Paul Davies C
This patch fixes some coding styles issues with staging/octeon-usb/octeon-hcd.c. Paul Davies C (3): Add blank line after all declarations in staging/octeon-usb/octeon-hcd.c Enclose complex macro with paranthese in staging/octeon-usb/octeon-hcd.c Fix lines with more than 80 chars in s