Re: [PATCH] Staging: rtl8192u: r819xU_firmware_img.c Fixed checkpatch.pl ERRORs

On Sat, May 24, 2014 at 10:44:12PM -0700, Chaitanya Hazarey wrote: Fixed a lot of errors of the type ERROR: space required after that ',' (ctx:VxV) Add a tab at the start of the line as well. regards, dan carpenter ___ devel mailing list

[PATCH] msi3103: Use time_before_eq()

To be future-proof and for better readability the time comparisons are modified to use time_before_eq() instead of plain, error-prone math. Signed-off-by: Manuel Schölling manuel.schoell...@gmx.de --- drivers/staging/media/msi3101/sdr-msi3101.c | 28 +-- 1 file changed,

[PATCH] rtl8188eu: use time_before/time_after and change type of ips_deny_time

To be future-proof and for better readability the time comparisons are modified to use time_before/_after() instead of plain, error-prone math. To suppress compiler warnings the type of ips_deny_time was changed. Signed-off-by: Manuel Schölling manuel.schoell...@gmx.de ---

[PATCH] gdm72xx: use time_before()

To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling manuel.schoell...@gmx.de --- drivers/staging/gdm72xx/gdm_usb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] Staging: rtl8192u: r819xU_firmware_img.c Fixed checkpatch.pl ERRORs

Fixed a lot of errors of the type ERROR: space required after that ',' (ctx:VxV) Added tabs at the beginning of line. Signed-off-by: Chaitanya Hazarey c...@24.io --- drivers/staging/rtl8192u/r819xU_firmware_img.c | 1042 1 file changed, 521 insertions(+), 521

Re: [PATCH] Staging: Silicom: bpctl_mod.c bypass.c: Fixed a lot of checkpatch.pl warnings

On Fri, May 23, 2014 at 10:25:28PM -0700, Chaitanya Hazarey wrote: Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: WARNING: Missing a blank line after declarations Thanks Greg K-H and Dan for the patience. Hope it works this time,

[PATCH] dgnc: Use time_after_eq()

To be future-proof and for better readability the time comparisons are modified to use time_after_eq() instead of plain, error-prone math. Signed-off-by: Manuel Schölling manuel.schoell...@gmx.de --- drivers/staging/dgnc/dgnc_neo.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [PATCH 3/8 V2] drivers/staging: Remove useless return variables

On Sat, May 24, 2014 at 01:06:48PM +0200, Peter Senna Tschudin wrote: This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The

Re: [PATCH] staging: gdm72xx: use time_before()

On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote: To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling manuel.schoell...@gmx.de ---

Re: [PATCH] staging: gdm72xx: use time_before()

On So, 2014-05-25 at 11:14 -0700, Greg KH wrote: On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote: To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by: Manuel Schölling

Re: [PATCH] Staging: Silicom: bpctl_mod.c bypass.c: Fixed a lot of checkpatch.pl warnings

Sorry Greg, this is taking so long, will make this against your tree and send it out. Thanks for looking into this, Chaitanya On Sun, May 25, 2014 at 11:03 AM, Greg KH gre...@linuxfoundation.org wrote: On Fri, May 23, 2014 at 10:25:28PM -0700, Chaitanya Hazarey wrote: Added a blank line after

Re: [PATCH] staging: gdm72xx: use time_before()

On Sun, May 25, 2014 at 08:24:33PM +0200, Manuel Schoelling wrote: On So, 2014-05-25 at 11:14 -0700, Greg KH wrote: On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote: To be future-proof and for better readability the time comparisons are modified to use time_before()

Re: [PATCH] staging: gdm72xx: use time_before()

On So, 2014-05-25 at 11:33 -0700, Greg KH wrote: On Sun, May 25, 2014 at 08:24:33PM +0200, Manuel Schoelling wrote: On So, 2014-05-25 at 11:14 -0700, Greg KH wrote: On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote: To be future-proof and for better readability the time

[PATCH] Staging: Silicom: bpctl_mod.c bypass.c: Fixed a lot of checkpatch.pl warnings

Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: WARNING: Missing a blank line after declarations Lets see if this works now, this patch is prepared against Greg's staging tree. Signed-off-by: Chaitanya Hazarey c...@24.io ---

[PATCH 09/48] staging: rtl8723au: Remove unused struct hostapd_priv

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/drv_types.h | 4 drivers/staging/rtl8723au/include/rtw_mlme.h | 10 -- 2 files changed, 14 deletions(-) diff --git

[PATCH 07/48] staging: rtl8723au: Remove unused enum SCAN_RESULT_TYPE

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/rtw_mlme.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8723au/include/rtw_mlme.h b/drivers/staging/rtl8723au/include/rtw_mlme.h

[PATCH 33/48] staging: rtl8723au: rtw_pwrctrl.c: Remove an unnecessary COEXIST #ifdef

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_pwrctrl.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_pwrctrl.c

[PATCH 31/48] staging: rtl8723au: Rename BT_LpsLeave() rtl8723a_BT_lps_leave()

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_cmd.c | 8 ++-- drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 7 +-- drivers/staging/rtl8723au/include/rtl8723a_bt_intf.h | 2 ++ 3

[PATCH 02/48] staging: rtl8723au: Use ieee80211.h defines for IV/ICV len values

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 4 ++-- drivers/staging/rtl8723au/core/rtw_recv.c | 12 ++-- drivers/staging/rtl8723au/core/rtw_xmit.c | 12 ++-- 3 files

[PATCH 36/48] staging: rtl8723au: rtw_mlme_ext.c: Sanitize calls to alloc_mgtxmitframe23a()

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[PATCH 41/48] staging: rtl8723au: rtl8732au_hal_init.c: Use rtl8723au_BT_coexist() to pick firmware image

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c

[PATCH 10/48] staging: rtl8723au: Do not call netdev_open23a() from cfg80211_rtw_change_iface()

From: Jes Sorensen jes.soren...@redhat.com Calling open on the device when changing the interface type is wrong. Let the stack call open at the right time. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 9 - 1 file changed, 9

[PATCH 11/48] staging: rtl8723au: ioctl_cfg80211.c: Use ether_addr_copy()

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 25 --- 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c

[PATCH 24/48] staging: rtl8723au: Convert BT_IsBtDisabled() into rtl8723a_BT_enabled()

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/hal_com.c| 11 --- .../staging/rtl8723au/hal/rtl8723a_bt-coexist.c| 22 +++--- .../rtl8723au/include/rtl8723a_bt-coexist.h

[PATCH 39/48] staging: rtl8723au: Rename HALBT_InitHwConfig() rtl8723a_BT_init_hwconfig()

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +- drivers/staging/rtl8723au/hal/usb_halinit.c | 4 ++-- drivers/staging/rtl8723au/include/rtl8723a_bt-coexist.h | 2 --

[PATCH 22/48] staging: rtl8723au: PS_RDY_CHECK() return bools in 'bool'

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_pwrctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/core/rtw_pwrctrl.c

[PATCH 21/48] staging: rtl8723au: _rtw_pwr_wakeup23a(): Do not mix _FAIL/false as return value

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_pwrctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/core/rtw_pwrctrl.c

[PATCH 30/48] staging: rtl8723au: Rename BTDM_ForDhcp() to rtl8723a_BT_specialpacket_notify()

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_cmd.c | 8 ++-- drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 7 +-- drivers/staging/rtl8723au/include/rtl8723a_bt_intf.h | 4 +++- 3

[PATCH 35/48] staging: rtl8723au: rtw_mlme_ext.c: Remove CONFIG_8723AU_BT_COEXIST #ifdefs

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 24 +--- 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[PATCH 12/48] staging: rtl8723au: ioctl_cfg80211.c: Use ether_addr_equal()

From: Jes Sorensen jes.soren...@redhat.com ... and in one case use is_zero_ether_addr() Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 25 +++ 1 file changed, 12 insertions(+), 13 deletions(-) diff --git

[PATCH 18/48] staging: rtl8723au: rtw_wdev_alloc(): Don't register wiphy before kmalloc() completed

From: Jes Sorensen jes.soren...@redhat.com There is no point starting to register the wiphy and then having to unregister it again if the followon kmalloc() fails. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 22

[PATCH 25/48] staging: rtl8723au: Introduce rtl8723a_BT_coexist() - and use it!

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- .../staging/rtl8723au/hal/rtl8723a_bt-coexist.c| 39 +- .../staging/rtl8723au/include/rtl8723a_bt_intf.h | 5 +++ 2 files changed, 20 insertions(+), 24 deletions(-) diff

[PATCH 38/48] staging: rtl8723au: Move rtl8723a_dual_antenna_detection() to rtl8723a_bt-coexist.c

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- .../staging/rtl8723au/hal/rtl8723a_bt-coexist.c| 46 drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 49 --

[PATCH 00/48] staging-next: rtl8723au: More fixes and removal of dead code

From: Jes Sorensen jes.soren...@redhat.com Hi Greg, Please find attached another round of cleanups, removal of dead code, and tidying up most of the #ifdef CONFIG_8723AU_BT_COEXIST mess. Notably patch 10 fixes an OOPS case if a user tries to add a monitor interface - monitor mode still doesn't

[PATCH 40/48] staging: rtl8723au: usb_halinit.c: Remove no-op HAL_INIT_PROFILE_TAG()

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/usb_halinit.c | 58 - 1 file changed, 16 insertions(+), 42 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c

[PATCH 19/48] staging: rtl8723au: Remove unused prototype rtw_cfg80211_issue_p2p_provision_request23a()

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/ioctl_cfg80211.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723au/include/ioctl_cfg80211.h

[PATCH 46/48] staging: rtl8723au: Rename BTDM_FwC2hBtInfo8723A() to rtl8723a_fw_c2h_BT_info()

From: Jes Sorensen jes.soren...@redhat.com In addition get rid of some pointless code obfuscating wrappers Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 9 ++--- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 5

[PATCH 03/48] staging: rtl8723au: rtw_xmit.c: Use ether_addr_copy()

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_xmit.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c

[PATCH 14/48] staging: rtl8723au: _cfg80211_rtw_mgmt_tx() clean up checking function return values

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c

[PATCH 48/48] staging: rtl8723au: _InitQueueReservedPage(): Remove pointless brackets

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/usb_halinit.c | 40 + 1 file changed, 18 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c

[PATCH 01/48] staging: rtl8723au: ieee80211.h: Remove some unused #defines

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/ieee80211.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8723au/include/ieee80211.h

[PATCH 44/48] staging: rtl8723au: Rename HALBT_InitBTVars8723A() rtl8723a_BT_init_hal_vars()

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 5 ++--- drivers/staging/rtl8723au/include/rtl8723a_bt-coexist.h | 3 ---

[PATCH 28/48] staging: rtl8723au: Rename BT_WifiScanNotify() rtl8723a_BT_wifiscan_notify()

From: Jes Sorensen jes.soren...@redhat.com Providing a dummy wrapper also allows removing some more CONFIG_8723AU_BT_COEXIST clutter Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_cmd.c| 7 ++-

[PATCH 15/48] staging: rtl8723au: Get rid of unused struct rtw_wdev_invit_info

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/ioctl_cfg80211.h | 19 --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 1 - 2 files changed, 20 deletions(-) diff --git

[PATCH 42/48] staging: rtl8723au: Rename BT_WifiAssociateNotify() rtl8723a_BT_wifiassociate_notify()

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 6 ++ drivers/staging/rtl8723au/include/rtl8723a_bt-coexist.h | 2 --

[PATCH 34/48] staging: rtl8723au: rtw_pwrctrl.c: Eliminate CONFIG_8723AU_BT_COEXIST #ifdefs

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_pwrctrl.c | 9 +++-- drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +- drivers/staging/rtl8723au/include/rtl8723a_bt_intf.h | 2 ++ 3 files

[PATCH 29/48] staging: rtl8723au: Rename BT_WifiMediaStatusNotify() rtl8723a_BT_mediastatus_notify()

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_cmd.c| 12 +++- drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 8 ++--

[PATCH 08/48] staging: rtl8723au: rtw_mlme.h: Remove a bunch of unused structs

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/rtw_mlme.h | 63 1 file changed, 63 deletions(-) diff --git a/drivers/staging/rtl8723au/include/rtw_mlme.h

[PATCH 17/48] staging: rtl8723au: Remove some pointless cfg80211_* wrapper macros

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/ioctl_cfg80211.h | 19 --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 15 --- 2 files changed, 8 insertions(+), 26

[PATCH 32/48] staging: rtl8723au: rtw_cmd.c: Remove last #ifdef CONFIG_8723AU_BT_COEXIST usage

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_cmd.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c

[PATCH 05/48] staging: rtl8723au: Make check_fwstate() return bool

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/rtw_mlme.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/include/rtw_mlme.h

[PATCH 04/48] staging: rtl8723au: Don't explicitly check check_fwstate() == true

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_cmd.c | 12 +- drivers/staging/rtl8723au/core/rtw_ioctl_set.c | 24 +--- drivers/staging/rtl8723au/core/rtw_led.c | 31

[PATCH 06/48] staging: rtl8723au: Don't check check_fwstate() == false

From: Jes Sorensen jes.soren...@redhat.com In addition, remove a followon check for false just after having checked for true. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c | 3 +-- drivers/staging/rtl8723au/core/rtw_led.c | 17

[PATCH 13/48] staging: rtl8723au: Delete unused rtw_cfg80211_set_mgnt_wpsp2pie()

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/ioctl_cfg80211.h | 3 - drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 166 - 2 files changed, 169 deletions(-) diff --git

[PATCH 37/48] staging: rtl8723au: odm.c: Rename BTDM_DisableEDCATurbo() to rtl8723a_BT_disable_EDCA_turbo()

From: Jes Sorensen jes.soren...@redhat.com Make it return bool since it only returns true/false, and get rid of Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/odm.c | 4 +--- drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 4

[PATCH 26/48] staging: rtl8723au: Remove some CONFIG_8723AU_BT_COEXIST clutter

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_cmd.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_cmd.c

[PATCH 45/48] staging: rtl8723au: rtl8723a_bt-coexist.c: Remove unnecessary #ifdef CONFIG_8723AU_BT_COEXIST

From: Jes Sorensen jes.soren...@redhat.com This file is only compiled if CONFIG_8723AU_BT_COEXIST=y Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH 47/48] staging: rtl8723au: Remove unused struct btdata_info

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/rtl8723a_bt-coexist.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723au/include/rtl8723a_bt-coexist.h

[PATCH 23/48] staging: rtl8723au: Create rtl8723au_bt_intf.h

From: Jes Sorensen jes.soren...@redhat.com Use this header for declaring functions that are currently #ifdef'ed out in the general code. Start by moving BTDM_1Ant8723A() there and renaming it appropriately. Signed-off-by: Jes Sorensen jes.soren...@redhat.com ---

[PATCH 20/48] staging: rtl8723au: bInternalAutoSuspend is always false

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_pwrctrl.c| 13 ++--- drivers/staging/rtl8723au/include/rtw_pwrctrl.h | 1 - drivers/staging/rtl8723au/os_dep/os_intfs.c | 4

[PATCH 16/48] staging: rtl8723au: struct rtw_wdev_priv: Remove some never 'true' variables

From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/ioctl_cfg80211.h | 3 --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 7 --- 2 files changed, 10 deletions(-) diff --git

[PATCH linux-next] imx-drm: imx-tve: remove unused variable

Commit f9b0e251dfbf 'drm: make mode_valid callback optional' left variable ret unused; remove it. This fixes the following compilation warning: drivers/staging/imx-drm/imx-tve.c: In function ‘imx_tve_connector_mode_valid’: drivers/staging/imx-drm/imx-tve.c:252:6: warning: unused variable

Re: [PATCH linux-next] imx-drm: imx-tve: remove unused variable

On Sun, May 25, 2014 at 11:54:14PM +0200, Vincent Stehlé wrote: Commit f9b0e251dfbf 'drm: make mode_valid callback optional' left variable ret unused; remove it. This fixes the following compilation warning: drivers/staging/imx-drm/imx-tve.c: In function ‘imx_tve_connector_mode_valid’:

Re: [PATCH] Staging: Silicom: bpctl_mod.c bypass.c: Fixed a lot of checkpatch.pl warnings

On Sun, May 25, 2014 at 11:59:08AM -0700, Chaitanya Hazarey wrote: Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: WARNING: Missing a blank line after declarations Lets see if this works now, this patch is prepared against Greg's

Re: [PATCH 00/48] staging-next: rtl8723au: More fixes and removal of dead code

On Sun, May 25, 2014 at 10:43:00PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Hi Greg, Please find attached another round of cleanups, removal of dead code, and tidying up most of the #ifdef CONFIG_8723AU_BT_COEXIST mess. Notably patch 10 fixes an

[PATCH v3] staging: lustre: lnet: klnds: Fix coding style in socklnd.c

Remove prohibited space between function name and open parenthesis to meet kernel coding style. Also fix indenting due to changes to keep readability. -since v2: None. This is the resend of v2 as v2 failed to apply Signed-off-by: Masaru Nomura massa.nom...@gmail.com ---

Re: [PATCH] Staging: Silicom: bpctl_mod.c bypass.c: Fixed a lot of checkpatch.pl warnings

Since you're redoing this one anyway, please use a more specific subject like: [PATCH] Staging: Silicom: bpctl_mod.c bypass.c: add blank lines regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH v3] staging: lustre: lnet: klnds: Fix coding style in socklnd.c

On Sun, May 25, 2014 at 11:24:12PM +0100, Masaru Nomura wrote: Remove prohibited space between function name and open parenthesis to meet kernel coding style. Also fix indenting due to changes to keep readability. -since v2: None. This is the resend of v2 as v2 failed to apply This should

Re: [PATCH linux-next] imx-drm: imx-tve: remove unused variable

Hi all, On Sun, 25 May 2014 15:12:35 -0700 Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Sun, May 25, 2014 at 11:54:14PM +0200, Vincent Stehlé wrote: Commit f9b0e251dfbf 'drm: make mode_valid callback optional' left variable ret unused; remove it. This fixes the following

Re: [PATCH v3] staging: lustre: lnet: klnds: Fix coding style in socklnd.c

On Sun, May 25, 2014 at 11:50:03PM +0100, Masaru Nomura wrote: 2014-05-25 23:37 GMT+01:00 Greg KH gre...@linuxfoundation.org: On Sun, May 25, 2014 at 11:24:12PM +0100, Masaru Nomura wrote: Remove prohibited space between function name and open parenthesis to meet kernel

Re: [PATCH v3] staging: lustre: lnet: klnds: Fix coding style in socklnd.c

What _branch_ of that git tree did you make it against? I did my work against commit 4b660a7f5c8099d88d1a43d8ae138965112592c7 Thank you, Masaru ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] Staging: Silicom: bpctl_mod.c bypass.c: Fixed a lot of checkpatch.pl warnings

OK sure, will do Dan. Greg, the patch has some issues, I did sync to your staging-next branch and am having issues applying it. Will send an update when i am able to do it. Thanks, Chaitanya On Sun, May 25, 2014 at 3:30 PM, Dan Carpenter dan.carpen...@oracle.com wrote: Since you're redoing

Re: [PATCH v3] staging: lustre: lnet: klnds: Fix coding style in socklnd.c

On Mon, May 26, 2014 at 12:57:39AM +0100, Masaru Nomura wrote: What _branch_ of that git tree did you make it against? I did my work against commit 4b660a7f5c8099d88d1a43d8ae138965112592c7 That is a commit, not a branch. Please work against the staging-next branch, not master. master

[PATCH] Staging: Silicom: bpctl_mod.c bypass.c: Adding blank lines

Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: WARNING: Missing a blank line after declarations The reason why it was not applying clean against Greg's tree was that bpctl_mod.c had changed in the functions which are a part of this

Re: [PATCH] Staging: Silicom: bpctl_mod.c bypass.c: Adding blank lines

On Sun, May 25, 2014 at 05:36:58PM -0700, Chaitanya Hazarey wrote: Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: Always wrap your lines at 72 columns, like git asks you to when you type in the commit message. WARNING: Missing a

Re: [PATCH] Staging: Silicom: bpctl_mod.c bypass.c: Adding blank lines

On its way. Chaitanya On Sun, May 25, 2014 at 5:51 PM, Greg KH gre...@linuxfoundation.org wrote: On Sun, May 25, 2014 at 05:36:58PM -0700, Chaitanya Hazarey wrote: Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: Always wrap your

[PATCH] Staging: Silicom: bpctl_mod.c bypass.c: Adding blank lines

Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: WARNING: Missing a blank line after declarations Signed-off-by: Chaitanya Hazarey c...@24.io --- drivers/staging/silicom/bpctl_mod.c| 88 +++-

Re: [PATCH] Staging: Silicom: bpctl_mod.c bypass.c: Adding blank lines

On Sun, 2014-05-25 at 21:58 -0700, Chaitanya Hazarey wrote: Added a blank line after declarations in many places to fix the following warning issued by checkpatch.pl: Unrelated trivial note: diff --git a/drivers/staging/silicom/bpctl_mod.c b/drivers/staging/silicom/bpctl_mod.c @@ -2802,6