When dgap_tty_init() and dgap_tty_register_ports() are failed,
these are needed to free some memory properly.
It can be handled by calling dgap_tty_uninit() and dgap_cleanup_board().
But tty's ports are not registered yet when these function are failed,
so it need to switch with boolean value
Hi Kevin,
I suggest reading the file Documentation/SubmittingPatches for general
guidance as how to submit patches.
+#define MAJOR_NUM 100
+#define MAJOR_MIN 0
Fixed device numbers need to be allocated from dev...@lanana.org
(currently managed by Alan Cox). However,
On 26 May 2014 23:03, Greg KH gre...@linuxfoundation.org wrote:
On Mon, May 26, 2014 at 02:28:44PM +0530, Sachin Kamat wrote:
'ret' is not used in the function. Remove it.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/imx-drm/imx-tve.c |1 -
1 file changed, 1
On Tue, May 27, 2014 at 09:58:18AM +0900, Heesub Shin wrote:
Hello Carpenter,
On 05/26/2014 07:36 PM, Dan Carpenter wrote:
On Mon, May 26, 2014 at 07:04:53PM +0900, Heesub Shin wrote:
@@ -124,7 +122,6 @@ static struct page_info *alloc_largest_available(struct
ion_system_heap *heap,
version.h inclusion is not needed as detected by versioncheck.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8723au/include/osdep_service.h |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/include/osdep_service.h
version.h inclusion is not needed as detected by versioncheck.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8723au/os_dep/os_intfs.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/os_dep/os_intfs.c
version.h inclusion is not needed as detected by versioncheck.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8192ee/wifi.h |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192ee/wifi.h b/drivers/staging/rtl8192ee/wifi.h
index 9cb0811..96fa261
version.h inclusion is not needed as detected by versioncheck.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c
Fixes the followign build error:
drivers/staging/rtl8192ee/btcoexist/halbtc8723b1ant.c:1387:6: error: called
object is not a function or function pointer
([BTCoex], Wifi non connected-idle + BT Busy!!\n));
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
The brd-nasync = 0; was wrong, yes, but my main complaint was that
you are writing complicated error handling. This v2 patch makes the
error handling even more complicated. If dgap_tty_init() fails it
should free the things it allocates itself, instead of the caller
handling errors for it.
It's
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
This series is based on latest staging-next and is compile tested.
---
drivers/staging/rtl8821ae/base.c | 46 +-
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/cam.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae/cam.c
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/debug.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8821ae/debug.c
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/compat.h | 57
1 file changed, 57 deletions(-)
diff --git
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/core.c | 156 +-
1 file changed, 2 insertions(+), 154 deletions(-)
diff --git
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/rtl8821ae/trx.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rtl8821ae/trx.h
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/ps.c | 26 --
1 file changed, 26 deletions(-)
diff --git a/drivers/staging/rtl8821ae/ps.c
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/efuse.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae/efuse.c
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/regd.c | 52 --
1 file changed, 52 deletions(-)
diff --git
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/rc.c | 18 --
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/rtl8821ae/rc.c
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/pci.h |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8821ae/pci.h
The code should be for the current kernel version. Remove
conditional version based code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/staging/rtl8821ae/stats.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8821ae/stats.c
On Mon, May 26, 2014 at 09:12:52AM +1000, Stephen Rothwell wrote:
Hi all,
On Sun, 25 May 2014 15:12:35 -0700 Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Sun, May 25, 2014 at 11:54:14PM +0200, Vincent Stehlé wrote:
Commit f9b0e251dfbf 'drm: make mode_valid callback
The `in_request_module` member of `struct comedi_device` is only ever
set to `false`, so remove the code that checks for it being `true` and
remove the member.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
For staging-next.
---
drivers/staging/comedi/comedi_fops.c | 26
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/hal/usb_ops_linux.c |6 --
drivers/staging/rtl8188eu/include/usb_ops.h |1 -
2 files changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/usb_ops_linux.c
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/os_dep/xmit_linux.c |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/xmit_linux.c
b/drivers/staging/rtl8188eu/os_dep/xmit_linux.c
index 6089bae..9172380 100644
---
Assign RTL8188E to padapter-chip_type directly instead of calling
chip_by_usb_id() function to do same.
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c |5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
index c1195a0..6fb8caa 100644
---
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 21 -
1 file changed, 21 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
b/drivers/staging/rtl8188eu/core/rtw_wlan_util.c
index
rtw_usb_if1_init() initializes pbuddy_padapter variable which is not
being used.
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c |8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git
rtw_usb_if1_init() assign NULL to pbuddy_padapter variable which is not
being used.
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c |7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index fbf967d..1e62713 100644
---
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/include/osdep_service.h |5 -
drivers/staging/rtl8188eu/os_dep/os_intfs.c |4 ++--
drivers/staging/rtl8188eu/os_dep/usb_intf.c |4 ++--
3 files changed, 4 insertions(+), 9 deletions(-)
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/include/osdep_service.h |5 -
drivers/staging/rtl8188eu/os_dep/os_intfs.c |2 +-
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/include/osdep_service.h |5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h
b/drivers/staging/rtl8188eu/include/osdep_service.h
index 9d32bb2..b500991
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/include/osdep_service.h |5 -
drivers/staging/rtl8188eu/os_dep/os_intfs.c |2 +-
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h
Signed-off-by: navin patidar navin.pati...@gmail.com
---
drivers/staging/rtl8188eu/include/osdep_service.h | 39 -
1 file changed, 39 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/osdep_service.h
b/drivers/staging/rtl8188eu/include/osdep_service.h
index
This commit refactors the iwctl_giwaplist() function so that the sparse
warning the frame size of 1292 bytes is larger than 1024 bytes
[-Wframe-larger-than=] is no more.
The root cause of this warning were two arrays allocated on the stack
and this commit changes this - these arrays are now
On 2014-05-24 23:24, Chase Southwood wrote:
This board supports an interrupt that can be generated by an AND/OR
combination of 16 of the input channels.
Create a separate subdevice to handle this interrupt.
In doing this, this patch moves the apci1564_di_config() operation from
the digital
Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate the
cmd-convert_arg for the convert_src TRIG_TIMER. Pass the local variable
to i8253_cascade_ns_to_timer() instead of the cmd argument. This value
is modified by that function to return the actual time (in nanoseconds)
that the
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
For aesthetics, rename the local variable 'tmp' to 'arg'.
Also, change the 'err' variable to the correct type.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
Tidy up the local varaibles in the function.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate the
arguments for the TRIG_TIMER command sources. Pass the local variable to
i8253_cascade_ns_to_timer() instead of the cmd argument. This value
is modified by that function to return the actual time (in nanoseconds)
that the timer
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the
scan_begin_src and convert_src are both TRIG_TIMER.
All the arguments are unsigned int, change the local
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
The minimum test is not needed, this was already validated in Step 3.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate
the cmd-convert_arg for the convert_src TRIG_TIMER. Pass the local
variable to i8253_cascade_ns_to_timer() instead of the cmd argument.
This value is modified by that function to return the actual time
(in nanoseconds) that the
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
The minimum test is not needed, this was already validated in Step 3.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the
scan_begin_src and convert_src are both TRIG_TIMER.
All the arguments are unsigned int, change the local
Use the comedi_fc helper, cfc_check_trigger_arg_is(), to validate the
cmd-scan_begin_arg for the scan_begin_src TRIG_TIMER. Pass the local
variable to dt2k_ns_to_timer() instead of the cmd argument. This value
is modified by that function to return the actual time (in nanoseconds)
that the timer
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
For aesthetics, rename the local variable 'tmp' to 'arg'.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the
scan_begin_src and convert_src are both TRIG_TIMER.
All the arguments are unsigned int, change the local
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger argument when the source is TRIG_TIMER.
All the arguments are unsigned int, change the local variable to an
unsigned int and rename it for aesthetic reasons.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Use the comedi_fc helper cfc_check_trigger_arg_is() to validate the
trigger arguments when the source is TRIG_TIMER.
Use cfc_check_trigger_arg_min() to vaidate the scan_begin_arg when the
scan_begin_src and convert_src are both TRIG_TIMER.
All the arguments are unsigned int, change the local
We try to free two pages when only one has been allocated.
Cleanup path is unlikely, so I haven't found any trace that would fit,
but I hope that free_pages_prepare() does catch it.
Cc: sta...@vger.kernel.org
Signed-off-by: Radim Krčmář rkrc...@redhat.com
---
Cc'd stable because the worst-case
Use the comedi_fc helpers to validate the timer arguments.
This is a repost of a series that Ian Abbott has already reviewed. I have
udated his sign off on all the patches.
H Hartley Sweeten (23):
staging: comedi: adl_pci9111: use comedi_fc helpers to validate timer args
staging: comedi:
Use the local variable to access the comedi_cmd as a pointer in
pci230_handle_ai() instead of getting to it from the comedi_async
pointer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
This member of the private data can be determined from the cmd-stop_src.
Do that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/usbdux.c | 6 ++
1
This member of the private data is just a copy of the channels from
the cmd-chanlist. Remove the member and just use the cmd-chanlist
directly.
Remove the unneeded 'len' local variable in usbdux_ao_isoc_irq().
This is just the cmd-chanlist_len.
Signed-off-by: H Hartley Sweeten
The cmd-chanlist_len will always be = 1 in this function. Remove the
unnecessary checks.
Use the comedi_fc helper function to get the 'bytes_per_scan'.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Use the 'cmd' pointer to access the chanlist instead of getting to it
using the comedi_subdevice pointer.
Remove the unneeded 'n' local variable, this is just the cmd-chanlist_len.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Use a local variable to access the comedi_cmd as a pointer instead
of getting to from the comedi_subdevice pointer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The calculation for the total number of bytes in the DMA transfer
is incorrect. Fix it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 4 +---
1 file
This member of the private data can be determined from the cmd-stop_src.
Do that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/usbduxsigma.c | 6 ++
Use the local variable to access the comedi_cmd as a pointer instead
of getting to it from the comedi_async pointer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
This member of the private data can be determined from the cmd-stop_src.
Do that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/usbduxsigma.c | 6 ++
This member of the private data can be determined from the cmd-stop_src.
Do that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/usbdux.c | 6 ++
1
This series continues the cleanup of the comedi driver async command support.
H Hartley Sweeten (38):
staging: comedi: usbdux: remove 'ai_continuous' from private data
staging: comedi: usbdux: remove 'ao_continuous' from private data
staging: comedi: usbduxfast: remove 'ai_continuous' from
Use the local variable to access the comedi_cmd as a pointer instead
of getting to it from the comedi_subdevice pointer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The (*do_cmdtest) validates that the 'stop_arg' is = 1 for a 'stop_src'
of TRIG_COUNT and the 'scan_end_arg' is validated to be the 'chanlist_len'
which will always be = 1. Remove the unreachable error code for an
'ai_sample_count 1'.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
THe comedi core ensures that the chanlist will be valid for any async operation
other than Step 1 of the (*do_cmdtest) to get the trigger source masks.
Remove the unnecessary checks.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Use a local variable to access the comedi_cmd as a pointer instead
of getting to from the comedi_async pointer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Tidy up the local variables so that the comedi_cmd is accessed as a pointer
instead of getting to it from the comedi_subdevice pointer.
Remove the local variable 'len' and use the cmd-chanlist_len directly.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
Use a local variable to access the comedi_cmd as a pointer instead
of getting to from the comedi_async pointer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use a local variable to access the comedi_cmd as a pointer instead
of getting to from the comedi_subdevice pointer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use the comedi_fc helper function to get the 'bytes_per_scan'.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/amplc_pci230.c | 4 +---
1 file changed, 1
Factor the fifo half-full handling out of the interrupt function to reduce
the indent level of the code.
Tidy up the factored out code.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
This member of the private data can be determined from the
cmd-stop_src. Do that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/das800.c | 19
Use the local variable to access the comedi_cmd as a pointer instead
of getting to it from the comedi_subdevice pointer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use a local variable to access the comedi_cmd as a pointer instead
of getting to from the comedi_async pointer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
This member of the private data can be determined from the cmd-stop_src.
Do that instead.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/usbduxfast.c | 6 ++
1
The caller already has the comedi_subdevice and comedi_cmd pointers. Pass
those variables to the helper function.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use the comedi_fc helper to get the number of bytes per scan.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 2 +-
1 file changed, 1 insertion(+), 1
Use the comedi_fc helper to get the number of bytes per scan.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/das16.c | 3 +--
1 file changed, 1 insertion(+), 2
Use the comedi_fc helper to get the number of bytes per scan.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl812.c | 9 +++--
1 file changed, 3
Use a local variable to access the comedi_cmd as a pointer instead
of getting to from the comedi_async pointer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use the comedi_fc helper to get the number of bytes per scan.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 2 +-
1 file changed, 1 insertion(+), 1
This member of the private data can be determined from the cmd-stop_src.
Do that instead and remove the member.
Refactor pcmmio_handle_dio_intr() to remove an indent level.
For aesthetics, change the switch in pcmmio_cmd() to an if/else.
Signed-off-by: H Hartley Sweeten
Use a local variable to access the comedi_cmd as a pointer instead
of getting to from the comedi_subdevice pointer.
Remove the unnecessary local variables used for the cmd-chanlist_len.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
This member of the private data is just a copy of the channels from
the cmd-chanlist. Remove the member and just use the cmd-chanlist
directly.
Remove the unneeded 'len' local variable in usbduxsigma_ao_urb_complete().
This is just the cmd-chanlist_len.
Signed-off-by: H Hartley Sweeten
Hey there,
Thanks for looking into this,
Will be sending out the modified version soon.
Thanks,
Chaitanya
On Mon, May 26, 2014 at 11:56 PM, DaeSeok Youn daeseok.y...@gmail.com wrote:
Hi,
2014-05-27 14:43 GMT+09:00 Chaitanya Hazarey c...@24.io:
Fixed the following:
ERROR: do not use C99
On 05/27/2014 12:27 PM, Jim Davis wrote:
Building with the attached random configuration file,
A problem with the build when PCI is not selected was reported yesterday. I
think this build error is caused by MAC80211 not being selected. The fix for
both problems was merged as commit
On Mon, May 26 2014 at 03:04:58 AM, Heesub Shin heesub.s...@samsung.com wrote:
ION system heap uses a temporary list holding meta data on pages
allocated to build scatter/gather table. Now that the pages are compound
pages, we do not need to introduce a new data type redundantly.
On Mon, May 26 2014 at 03:04:59 AM, Heesub Shin heesub.s...@samsung.com wrote:
Not that the pages returned from the pool are compound pages, we do not
need to pass the order information to free_buffer_page().
s/Not/Now/
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
1 - 100 of 122 matches
Mail list logo