On 3 June 2014 03:06, Greg Kroah-Hartman wrote:
> On Mon, Jun 02, 2014 at 06:36:22PM +0200, Philipp Zabel wrote:
>> Am Mittwoch, den 28.05.2014, 14:13 -0700 schrieb Greg Kroah-Hartman:
>> > On Mon, May 26, 2014 at 04:19:39PM +0200, Philipp Zabel wrote:
>> > > The i.MX Image Processing Unit (IPU) c
On moving the function into the driver proper, also check the device is
asserting the shared interrupt line.
This patch also fixes the interrupt handling for the digital input
change-of-state interrupts.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
Hartley,
I know t
The addi_private struct defined in addi-data/addi_common.h is very bloated
and contains many fields which addi_apci_1564 does not require. In the
interest of eventually removing this driver's dependency on
addi_common.h, we can create a private data struct specifically for
addi_apci_1564 containin
This board supports an interrupt that can be generated by an AND/OR
combination of 16 of the input channels.
Create a separate subdevice to handle this interrupt.
The apci1564_di_config() function is used to configure which
inputs are used to generate the interrupt. Currently this function
is bro
The global variables ui_InterruptStatus_1564 and ui_InterruptData are both
set but never used. Just remove them from the driver.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 7 +--
1 file changed, 1 ins
This member of the private data struct is only set at one location in the
entire driver, and then never even used for anything. Let's just remove
its use.
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeeten
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 5 ---
This patchset introduces a new private data struct for this driver, adds
all of the code required to support Change-of-State interrupts for the
digital input subdevice, and finally fixes
apci1564_interrupt() to service this type of interrupt correctly.
CHANGES FROM v1:
*leave the send_sig() calls
Hello!
On Jun 3, 2014, at 9:22 PM, David Rientjes wrote:
>
> @@ -5849,21 +5850,32 @@ int lowmem_reserve_ratio_sysctl_handler(ctl_table
> *table, int write,
> int percpu_pagelist_fraction_sysctl_handler(ctl_table *table, int write,
> void __user *buffer, size_t *length, loff_t *ppos)
> {
>
From: Stephen Hemminger
Date: Tue, 3 Jun 2014 08:38:15 -0700
> The uuid structure could be managed as a const in several places.
>
> Signed-off-by: Stephen Hemminger
Applied, thanks.
___
devel mailing list
de...@linuxdriverproject.org
http://driverde
On Tue, Jun 03, 2014 at 03:24:20PM -0600, Shuah Khan wrote:
> On 06/01/2014 01:01 AM, Eli Billauer wrote:
> I see the value of this interface in unmap case, this type of wrapper
> can release dma buffers, drivers neglected to release leaving dangling
> buffers.
>
> However, driver writers should g
There is a risk that the variables will be used without being initialized.
Has also improved error handling, after an email proposal from Dan Carpenter.
Signed-off-by: Rickard Strandqvist
---
drivers/staging/tidspbridge/pmgr/dspapi.c | 64 ++---
1 file changed, 31 inser
On Tue, Jun 03, 2014 at 11:41:21PM +0200, jes.soren...@redhat.com wrote:
> From: Jes Sorensen
>
> Greg,
>
> One of the patches in my last set had a bad bug which made the driver
> mask out the bits used to determine the correct location of the 40MHz
> channel location.
>
> This one needs to go
Hi
I send in a new patch now, hope I interpreted you correctly how you
wanted the changes.
Worth mention is that in mgrwrap_enum_node_info() unless you wanted to remove
"if (size < sizeof(struct dsp_ndbprops))" then size will always be the
same as sizeof(struct dsp_ndbprops)
Best regards
Rick
An array u8IPv6FlowLable[] is defined as 3 in cntrl_SignalingInterface.h.
But in CmHosts.c, the kernel accessed to clsRule.u8IPv6FlowLable[5].
Signed-off-by: Masanari Iida
---
drivers/staging/bcm/cntrl_SignalingInterface.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
On Tue, Jun 3, 2014 at 2:42 PM, Greg KH wrote:
> So keep working on things,
> these aren't lost, I'll get to them in a few weeks.
>
Ok will do,
Chaitanya
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailma
From: Jes Sorensen
Greg,
One of the patches in my last set had a bad bug which made the driver
mask out the bits used to determine the correct location of the 40MHz
channel location.
This one needs to go on top.
Thanks,
Jes
Jes Sorensen (1):
staging: rtl8723au: rtw_update_ht_cap23a(): Use c
From: Jes Sorensen
commit 2dc5e6e90892d7247fbe8c25714dba3c0ba744e8
Author: Jes Sorensen
Date: Tue May 27 13:43:12 2014 +0200
staging: rtl8723au: Eliminate struct HT_info_element
Yet another duplicate version of struct ieee80211_ht_operation
Signed-off-by: Jes Sorensen
introduc
On Tue, Jun 03, 2014 at 02:34:55PM -0700, Chaitanya Hazarey wrote:
> On Tue, Jun 3, 2014 at 11:36 AM, Dan Carpenter
> wrote:
> > It always feels much better after the dead code is gone.
>
> So patches are still good ? No change required for my side, right ? I
> just need to wait for Greg's needl
On 06/01/2014 01:01 AM, Eli Billauer wrote:
dmam_map_single() and dmam_unmap_single() are the managed counterparts
for the respective dma_* functions.
Note that dmam_map_single() returns a status value rather than the DMA handle.
The DMA handle is passed to the caller through a pointer in the ar
On Tue, Jun 3, 2014 at 11:36 AM, Dan Carpenter wrote:
> It always feels much better after the dead code is gone.
So patches are still good ? No change required for my side, right ? I
just need to wait for Greg's needle to come to this point and pick
them up.
Best,
Chaitanya
Done as task 10 of the eudyptula challenge.
Signed-off-by: Nicolas Koch
---
drivers/staging/octeon/ethernet-mem.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-mem.c
b/drivers/staging/octeon/ethernet-mem.c
index bf666b0..964da8
On Tue, Jun 03, 2014 at 09:21:18PM +0200, Nicolas Koch wrote:
> Done as task 10 of the eudyptula challenge.
>
There is no subject prefix. The subject should be:
[patch] Staging: octeon: minor style cleanups
Otherwise the patch is ok.
regards,
dan carpenter
___
Done as task 10 of the eudyptula challenge.
Signed-off-by: Nicolas Koch
---
drivers/staging/octeon/ethernet-mem.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-mem.c
b/drivers/staging/octeon/ethernet-mem.c
index bf666b0..964da8
On Tue, Jun 03, 2014 at 10:12:23AM +0200, Geert Uytterhoeven wrote:
> What do other people think?
In staging we just automatically delete commented code. It's in the git
log if you need it. It always feels much better after the dead code is
gone.
regards,
dan carpenter
> -Original Message-
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Tuesday, June 3, 2014 8:38 AM
> To: KY Srinivasan; Haiyang Zhang
> Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org;
> net...@vger.kernel.org
> Subject: [PATCH net-next] hyper-v: make
On Tue, Jun 03, 2014 at 09:43:35AM -0500, Ken Cox wrote:
> The unisys drivers now properly check to make sure they are running
> on the s-Par platform before they will initialize. This was fixed in
> commit fcd0157ece so it is safe to allow the unisys drivers to be built.
>
> This has been tested
The uuid structure could be managed as a const in several places.
Signed-off-by: Stephen Hemminger
---
Patch against net-next because that is where most recent
hyper-v related changes are.
--- a/drivers/hv/channel_mgmt.c 2014-02-12 08:21:54.627887619 -0800
+++ b/drivers/hv/channel_mgmt.c 2014-
The unisys drivers now properly check to make sure they are running
on the s-Par platform before they will initialize. This was fixed in
commit fcd0157ece so it is safe to allow the unisys drivers to be built.
This has been tested in the same qemu environment that originally
produced the panic an
tdev->dev has been freed in device_destroy(), it's not right to
use dev_set_drvdata() after that;
Signed-off-by: Yi Zhang
---
drivers/staging/android/timed_output.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/android/timed_output.c
b/drivers/staging/android/timed_outpu
This is a patch to the dgnc_driver.c file that fixes the following
error:
ERROR: open brace '{' following function declarations go on
the next line
Signed-off-by: Vincent Heuken
---
drivers/staging/dgnc/dgnc_driver.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/s
On 2014-06-02 21:48, Wolfgang Ocker wrote:
Fix a style issue reported by checkpatch.pl for the Eudyptula challenge
Signed-off-by: Wolfgang Ocker
---
drivers/staging/comedi/comedi_fops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops
Hi Chaitanya,
On Mon, Jun 2, 2014 at 6:11 PM, Chaitanya Hazarey wrote:
> To address the error -
>
> ERROR: do not use C99 // comments
>
> Removed all C99 comments.
IMHO, blindly converting C99 comments is a good idea...
> --- a/drivers/staging/rtl8192u/r8192U_wx.c
> +++ b/drivers/staging/rtl819
Pass "brd" to dgap_after_config_loaded() instead of passing
"dgap_numboards" and looking up brd again.
Signed-off-by: Daeseok Youn
---
V2: replace "dgap_board[board]->" with "brd->".
drivers/staging/dgap/dgap.c | 18 +-
1 files changed, 9 insertions(+), 9 deletions(-)
diff --
2014-06-03 16:22 GMT+09:00 Dan Carpenter :
> On Tue, Jun 03, 2014 at 03:27:28PM +0900, Daeseok Youn wrote:
>> -static int dgap_after_config_loaded(int board)
>> +static int dgap_after_config_loaded(struct board_t *brd)
>> {
>> + int board = brd->boardnum;
>> +
>
> We don't need to use "board"
These all look great except for 2/4.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Jun 03, 2014 at 03:27:28PM +0900, Daeseok Youn wrote:
> -static int dgap_after_config_loaded(int board)
> +static int dgap_after_config_loaded(struct board_t *brd)
> {
> + int board = brd->boardnum;
> +
We don't need to use "board" in this function. We can replaced
"dgap_board[board]
36 matches
Mail list logo
