Thanks. This is much nicer to review when they are all folded together
like this.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Jun 04, 2014 at 07:45:45PM +0200, Remi Pommarel wrote:
This removes stack arrays of variable length and use kmalloc() instead, thus
removing the sparse warnings Variable length array is used.
Signed-off-by: Remi Pommarel r...@triplefau.lt
---
drivers/staging/rtl8821ae/efuse.c | 38
The current BGR666 is not consistent with the other color mapings like BGR24.
BGR666 should be in the same byte order than BGR24.
Signed-off-by: Denis Carikli de...@eukrea.com
Acked-by: Philipp Zabel p.za...@pengutronix.de
---
ChangeLog v10-v13:
- Rebased
ChangeLog v9-v10:
- Rebased.
- Added
Signed-off-by: Denis Carikli de...@eukrea.com
---
ChangeLog 12-v13:
- No changes
ChangeLog 11-v12:
- Improved the define names to match the hardware:
ENABLE_POL is not a clock signal but instead an enable signal.
ChangeLog v9-v10:
- New patch which was splitted out from:
staging: imx-drm: Use
That new macro is needed by the imx_drm staging driver
for supporting the QVGA display of the eukrea-cpuimx51 board.
Signed-off-by: Denis Carikli de...@eukrea.com
Acked-by: Mauro Carvalho Chehab m.che...@samsung.com
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com
Acked-by: Philipp
Signed-off-by: Denis Carikli de...@eukrea.com
Acked-by: Philipp Zabel p.za...@pengutronix.de
---
ChangeLog v9-v13:
- Rebased
ChangeLog v8-v9:
- Rebased.
- Added Philipp Zabel's ack.
- Shortened the patch title.
ChangeLog v8-v9:
- Removed the Cc. They are now set in git-send-email directly.
-
The imx-drm driver can't use the de-active and
pixelclk-active display-timings properties yet.
Instead the data-enable and the pixel data clock
polarity are hardcoded in the imx-drm driver.
So theses properties are now set to keep
the same behaviour when imx-drm will start
using them.
The previous hardware behaviour was kept if the
flags are not set.
Signed-off-by: Denis Carikli de...@eukrea.com
---
ChangeLog v12-v13:
- This patch doesn't need the DRM_MODE_FLAG_POL_*_PRESERVE flags anymore.
- code cleanup to improve readability:
- ENABLE_POL_PRESERVE is now gone
- Less
Signed-off-by: Denis Carikli de...@eukrea.com
---
ChangeLog v12-v13:
- Added a note explaining why the size is zero in
the eukrea_mbimxsd51_dvi(s)vga structs.
ChangeLog v11-v12:
- Rebased: It now uses the new DRM_MODE_FLAG_POL_DE flags defines names
ChangeLog v10-v11:
- New patch.
---
On Mon, Jun 9, 2014 at 5:09 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
Right, so the problem isn't at the HDMI level, but at the DI level... so
that's where we need to debug what's being setup. I left some debugging
in ipu-di.c - could you try enabling that please?
Booting
On Tue, Jun 10, 2014 at 9:58 AM, Fabio Estevam feste...@gmail.com wrote:
On Mon, Jun 9, 2014 at 5:09 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
Right, so the problem isn't at the HDMI level, but at the DI level... so
that's where we need to debug what's being setup. I left
On Tue, Jun 10, 2014 at 04:13:06PM +0100, Russell King - ARM Linux wrote:
where 'M' is the IPU DI clock muxer. However, we're currently setting
this up as:
LM --+ LDB serial
`- /7 -+ LDB DI clock
IPM --- /N IM --- IPU DI clock
and hoping that the LDB
Replaced 'printk' with 'netdev_info' and 'netdev_err' wherever necessary.
Also fixed the coding issue cooresponding to line gap after the declarations.
Signed-off-by: Raghavendra ar...@cdac.in
---
drivers/staging/rtl8192e/dot11d.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
On Tue, Jun 10, 2014 at 05:14:21PM +0100, Russell King - ARM Linux wrote:
On Tue, Jun 10, 2014 at 04:13:06PM +0100, Russell King - ARM Linux wrote:
where 'M' is the IPU DI clock muxer. However, we're currently setting
this up as:
LM --+ LDB serial
`- /7
On Tue, Jun 10, 2014 at 10:33:51PM +0530, Raghavendra wrote:
Replaced 'printk' with 'netdev_info' and 'netdev_err' wherever necessary.
Also fixed the coding issue cooresponding to line gap after the declarations.
Please don't do multiple things in the same patch, a single patch should
only do 1
On Tue, Jun 10, 2014 at 2:04 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
This diagram is drawn from the code in clk-imx6.c, and it does not
agree with what is in the SoC manuals - this is the representation
redrawn from the manuals:
The difference is, there is no clock
This makes sure a format string cannot leak into the work queue name nor
the printk buffer.
Signed-off-by: Kees Cook keesc...@chromium.org
---
drivers/staging/rtl8192ee/base.c |2 +-
drivers/staging/rtl8192ee/btcoexist/halbtcoutsrc.h |2 +-
2 files changed, 2
This patch fixes line lengths in the
drivers/staging/bcm/InterfaceMisc.c
file.
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/InterfaceMisc.c | 98 +
1 file changed, 67 insertions(+), 31 deletions(-)
diff --git
On Mon, Jun 9, 2014 at 7:29 AM, Fabio Estevam feste...@gmail.com wrote:
On Mon, Jun 9, 2014 at 11:06 AM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
Please check the status in /sys/class/drm/card0-HDMI-A-1/status. This
should report the current state of the hotplug detection.
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/InterfaceInit.c | 43 +++--
1 file changed, 17 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceInit.c
b/drivers/staging/bcm/InterfaceInit.c
index e334ca7..19e0f17
This patch outsources a chunk of code which is for selecting an
alternate setting for highspeed modem into a new function.
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/InterfaceInit.c | 207 +++-
1 file changed, 112 insertions(+), 95
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/InterfaceInit.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceInit.c
b/drivers/staging/bcm/InterfaceInit.c
index 7c04c73..d61a688 100644
---
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/InterfaceInit.c | 47 ++---
1 file changed, 18 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceInit.c
b/drivers/staging/bcm/InterfaceInit.c
index a1fa3d5..ea19436
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/InterfaceInit.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceInit.c
b/drivers/staging/bcm/InterfaceInit.c
index d61a688..539f830 100644
---
Hi,
I did some cleanup patches on the
drivers/staging/bcm/InterfaceInit.c
file. I hope you like them.
The cleanup contains:
* Line shortenings
* Merging of multi-line statements which fit in one line
* Replacing member-accessing with variables
* Outsourcing a code junk
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/InterfaceInit.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceInit.c
b/drivers/staging/bcm/InterfaceInit.c
index 539f830..ab4c65a 100644
---
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/InterfaceInit.c | 53 +++--
1 file changed, 27 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceInit.c
b/drivers/staging/bcm/InterfaceInit.c
index ab4c65a..e334ca7
Hi Tim,
On Tue, Jun 10, 2014 at 3:54 PM, Tim Harvey thar...@gateworks.com wrote:
Fabio,
I'm following along with this thread as I see the same thing you do on
our Ventana boards that support both LVDS and HDMI: without
hot-plugging the HDMI connector I get not HDMI out simply by having
the
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/DDRInit.c | 176 --
1 file changed, 134 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
index 4c7f518..cfaa2c1 100644
---
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/DDRInit.c | 31 +--
1 file changed, 21 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
index 423bfd9..4564f40 100644
---
This patch moves the doubled if block inside the retval-checking one
level up.
As the if-else-block it was in is now a one-statement if-else block,
I removed the braces from it.
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/DDRInit.c | 16 +---
1 file
Hi,
These are some patches for the
drivers/staging/bcm/DDRInit.c
file.
The patchset contains:
* Indention/Whitespace fixes
* Line length fixes
* Simplifying of logic
Please notice: I'm not able to test these patches, as I do not have the
appropriate hardware. I compiled them,
This patch fixes some indentation errors, where multi-line statements
where not indented.
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/DDRInit.c | 56 +--
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git
There is a strange return 0 in line6_probe() before any initialization of
the module is done. It can lead to NULL pointer dereference in other functions.
The patch proposes to return -ENODEV in this case.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Alexey
Hi
True!
Sorry :-(
But then one would either operate strcpy outright.
Or use strlcpy then the code would be:
/* strlcpy() handles not include \0 */
len = strlcpy(busid, buf + 4, BUSID_SIZE);
/* busid needs to include \0 termination */
if (!(len BUSID_SIZE))
return
On Monday, June 09, 2014 10:48 PM, Dan Carpenter wrote:
On Mon, Jun 09, 2014 at 09:24:35PM -0400, Marcos A. Di Pietro wrote:
Fixes warning static analysis warning raised by sparse in
drivers/staging/comedi/drivers/ni_stc.h
warning: shift too big (4294967295) for type int
This warning
From: Raghavendra ar...@cdac.in
Fixed coding style issues
Signed-off-by: A Raghavendra Rao ar...@cdac.in
---
drivers/staging/rtl8192e/dot11d.c |9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/dot11d.c
b/drivers/staging/rtl8192e/dot11d.c
some times i get confused by one patch should do only one thing
policy, for example this patch removes
many other things along _rtw_read_mem().
But you are also right it's much easier to review when they are all
folded together.
I'm glad, i did it right this time. :)
regards,
navin patidar
On
On Wed, Jun 11, 2014 at 09:25:47AM +0530, A Raghavendra Rao wrote:
From: Raghavendra ar...@cdac.in
Fixed coding style issues
Which specific coding style issue? Be exact please.
And don't try to fix more than one type of coding style issue at a
time...
Signed-off-by: A Raghavendra Rao
39 matches
Mail list logo
