Re: [PATCH 07/76] staging: rtl8723au: rtw_get_bcn_info23a(): Use cfg80211_* to obtain crypto info

2014-06-18 Thread Jes Sorensen
Greg KH gre...@linuxfoundation.org writes: On Mon, Jun 09, 2014 at 03:15:59PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 29

Re: [PATCH 07/76] staging: rtl8723au: rtw_get_bcn_info23a(): Use cfg80211_* to obtain crypto info

2014-06-18 Thread Greg KH
On Wed, Jun 18, 2014 at 09:05:09AM +0200, Jes Sorensen wrote: Greg KH gre...@linuxfoundation.org writes: On Mon, Jun 09, 2014 at 03:15:59PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com ---

Re: [PATCH 07/76] staging: rtl8723au: rtw_get_bcn_info23a(): Use cfg80211_* to obtain crypto info

2014-06-18 Thread Greg KH
On Wed, Jun 18, 2014 at 12:15:46AM -0700, Greg KH wrote: On Wed, Jun 18, 2014 at 09:05:09AM +0200, Jes Sorensen wrote: Greg KH gre...@linuxfoundation.org writes: On Mon, Jun 09, 2014 at 03:15:59PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com

Re: [PATCH 07/76] staging: rtl8723au: rtw_get_bcn_info23a(): Use cfg80211_* to obtain crypto info

2014-06-18 Thread Jes Sorensen
Greg KH gre...@linuxfoundation.org writes: On Wed, Jun 18, 2014 at 12:15:46AM -0700, Greg KH wrote: On Wed, Jun 18, 2014 at 09:05:09AM +0200, Jes Sorensen wrote: Greg KH gre...@linuxfoundation.org writes: On Mon, Jun 09, 2014 at 03:15:59PM +0200, jes.soren...@redhat.com wrote: From: Jes

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-18 Thread Ulf Hansson
On 18 June 2014 03:17, micky micky_ch...@realsil.com.cn wrote: On 06/17/2014 03:45 PM, Ulf Hansson wrote: On 17 June 2014 03:04, micky micky_ch...@realsil.com.cn wrote: On 06/16/2014 08:40 PM, Ulf Hansson wrote: On 16 June 2014 11:09, micky micky_ch...@realsil.com.cn wrote: On 06/16/2014

Re: [PATCH 1/2] mfd: rtsx: add dma transfer function

2014-06-18 Thread Lee Jones
On Mon, 16 Jun 2014, Ulf Hansson wrote: On 16 June 2014 14:20, Lee Jones lee.jo...@linaro.org wrote: From: Micky Ching micky_ch...@realsil.com.cn rtsx driver using a single function for transfer data, dma map/unmap are placed in one fix function. We need map/unmap dma in different

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-18 Thread micky
On 06/18/2014 03:39 PM, Ulf Hansson wrote: On 18 June 2014 03:17, micky micky_ch...@realsil.com.cn wrote: On 06/17/2014 03:45 PM, Ulf Hansson wrote: On 17 June 2014 03:04, micky micky_ch...@realsil.com.cn wrote: On 06/16/2014 08:40 PM, Ulf Hansson wrote: On 16 June 2014 11:09, micky

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-18 Thread Ulf Hansson
On 18 June 2014 12:08, micky micky_ch...@realsil.com.cn wrote: On 06/18/2014 03:39 PM, Ulf Hansson wrote: On 18 June 2014 03:17, micky micky_ch...@realsil.com.cn wrote: On 06/17/2014 03:45 PM, Ulf Hansson wrote: On 17 June 2014 03:04, micky micky_ch...@realsil.com.cn wrote: On 06/16/2014

Anybody working on ced1401?

2014-06-18 Thread Kristina Martšenko
Hi Alois, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving ced1401 out of staging in over a year. Are there any plans to clean it up and move it out soon? Because otherwise we're going to have to delete the driver, as we don't

Anybody working on crystalhd?

2014-06-18 Thread Kristina Martšenko
Hi Naren, Jarod, Scott, Manu, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving crystalhd out of staging in over a year. Are there any plans to clean it up and move it out soon? Because otherwise we're going to have to delete the

Anybody working on frontier?

2014-06-18 Thread Kristina Martšenko
Hi David, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving frontier out of staging in over a year. Are there any plans to clean it up and move it out soon? Because otherwise we're going to have to delete the driver, as we don't

Anybody working on keucr?

2014-06-18 Thread Kristina Martšenko
Hi Al, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving keucr out of staging in over a year. Are there any plans to clean it up and move it out soon? Because otherwise we're going to have to delete the driver, as we don't want

Anybody working on netlogic?

2014-06-18 Thread Kristina Martšenko
Hi Ganesan and Jayachandran, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving netlogic out of staging in over a year. Are there any plans to clean it up and move it out soon? Because otherwise we're going to have to delete the

[PATCH] staging: xillybus: Consolidate return statements in xilly_probe()

2014-06-18 Thread Tobias Klauser
No need for two return statements, just call xillybus_do_cleanup() in case of an error before returning. Signed-off-by: Tobias Klauser tklau...@distanz.ch --- drivers/staging/xillybus/xillybus_pcie.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

Re: [PATCH] staging: xillybus: Consolidate return statements in xilly_probe()

2014-06-18 Thread Eli Billauer
Hello, Thanks for the patch. However in the patch I'm trying to push, xillybus_do_cleanup() is eliminated completely from the code (with no success so far, because it depends on inserting a patch that adds a devres version of dma_map_single). See https://lkml.org/lkml/2014/6/1/10 So your

Re: [PATCH] staging: xillybus: Consolidate return statements in xilly_probe()

2014-06-18 Thread Tobias Klauser
Hi Eli On 2014-06-18 at 14:30:35 +0200, Eli Billauer eli.billa...@gmail.com wrote: Hello, Thanks for the patch. However in the patch I'm trying to push, xillybus_do_cleanup() is eliminated completely from the code (with no success so far, because it depends on inserting a patch that adds a

[PATCH] staging: Remove useless default N lines

2014-06-18 Thread Paul Bolle
Two Kconfig entries default to (uppercase) N. It was clearly intended to use default n. But since (lowercase) n is the default anyway, these lines might as well be removed. Reported-by: Martin Walch walch.mar...@web.de Signed-off-by: Paul Bolle pebo...@tiscali.nl --- Tested with make

Re: [PATCH] staging: xillybus: Consolidate return statements in xilly_probe()

2014-06-18 Thread Dan Carpenter
On Wed, Jun 18, 2014 at 02:10:21PM +0200, Tobias Klauser wrote: No need for two return statements, just call xillybus_do_cleanup() in case of an error before returning. Signed-off-by: Tobias Klauser tklau...@distanz.ch --- drivers/staging/xillybus/xillybus_pcie.c |7 ++- 1 file

[PATCH] Checks for Null return of skb_alloc in function fw_download_code

2014-06-18 Thread Nicholas Krause
Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index

Re: [PATCH] Checks for Null return of skb_alloc in function fw_download_code

2014-06-18 Thread Greg KH
On Wed, Jun 18, 2014 at 01:53:00PM -0400, Nicholas Krause wrote: Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH] Staging: rtl8192e prohibit deferencing of NULL pointer

2014-06-18 Thread Andreas Platschek
If ieee == NULL we jump to rx_dropped. Therefore we have to check again, if ieee != NULL before we use it. Signed-off-by: Andreas Platschek platsc...@ict.tuwien.ac.at --- drivers/staging/rtl8192e/rtllib_rx.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] Staging: rtl8192e prohibit deferencing of NULL pointer

2014-06-18 Thread Valentina Manea
On Wed, Jun 18, 2014 at 11:16 AM, Andreas Platschek platsc...@ict.tuwien.ac.at wrote: rx_dropped: -ieee-stats.rx_dropped++; +if (ieee != NULL) { +ieee-stats.rx_dropped++; +} return 0; Style nit: don't use braces around a single statement. Tina

Re: Anybody working on crystalhd?

2014-06-18 Thread Jarod Wilson
There was significant work done out-of-tree, and I believe possibly posted, but never accepted, and some work has continued there, I believe, but I've not had the time or energy to work on that code in a few years myself. I'd say just drop it, most people that care about video acceleration

[PATCH v2] Staging: rtl8192e prohibit deferencing of NULL pointer

2014-06-18 Thread Andreas Platschek
v2: removed braces from if statement If ieee == NULL we jump to rx_dropped. Therefore we have to check again, if ieee == NULL before we use it. Signed-off-by: Andreas Platschek platsc...@ict.tuwien.ac.at --- drivers/staging/rtl8192e/rtllib_rx.c |3 ++- 1 file changed, 2 insertions(+), 1

Re: [PATCH] Staging: rtl8192e prohibit deferencing of NULL pointer

2014-06-18 Thread Dan Carpenter
On Wed, Jun 18, 2014 at 06:16:09PM +, Andreas Platschek wrote: If ieee == NULL we jump to rx_dropped. Therefore we have to check again, if ieee != NULL before we use it. Take a look at the caller as well. It doesn't check ieee for NULL so probably this can never be NULL. How would that

[PATCH v2] Staging: rtl8192e prohibit deferencing of NULL pointer

2014-06-18 Thread Andreas Platschek
v2: removed braces from if statement If ieee == NULL we jump to rx_dropped. Therefore we have to check again, if ieee == NULL before we use it. Signed-off-by: Andreas Platschek platsc...@ict.tuwien.ac.at --- drivers/staging/rtl8192e/rtllib_rx.c |3 ++- 1 file changed, 2 insertions(+), 1

Re: [PATCH 00/12] staging-next: rtl8723au: More fixes and duplicate defines

2014-06-18 Thread Greg KH
On Sat, May 31, 2014 at 06:05:07PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Hi Greg, A smaller set of patches this time. It's mainly cleanups, removal of yet more locally duplicated structs, and some endian fixes. Note the endian fixes shouldn't

Re: [PATCH 1/1] staging: rtl8723au: rtw_update_ht_cap23a(): Use correct mask when determining 40MHz channel location

2014-06-18 Thread Greg KH
On Tue, Jun 03, 2014 at 11:41:22PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com commit 2dc5e6e90892d7247fbe8c25714dba3c0ba744e8 That commit is in your tree, not Linus's :) I'll edit it with the proper number now...

Re: [PATCH 1/1] staging: rtl8723au: rtw_update_ht_cap23a(): Use correct mask when determining 40MHz channel location

2014-06-18 Thread Jes Sorensen
Greg KH gre...@linuxfoundation.org writes: On Tue, Jun 03, 2014 at 11:41:22PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com commit 2dc5e6e90892d7247fbe8c25714dba3c0ba744e8 That commit is in your tree, not Linus's :) I'll edit it with the proper number

Re: [PATCH 00/12] staging-next: rtl8723au: More fixes and duplicate defines

2014-06-18 Thread Jes Sorensen
Greg KH gre...@linuxfoundation.org writes: On Sat, May 31, 2014 at 06:05:07PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Hi Greg, A smaller set of patches this time. It's mainly cleanups, removal of yet more locally duplicated structs, and some endian

Re: [PATCH] Checks for Null return of skb_alloc in function fw_download_code

2014-06-18 Thread Nick Krause
So sorry Greg, I pulled the git in this morning for kernel-3.16-r2 ,I will resend the patch from the clean tree. I will also fix the tabs.' Sorry :( Nick On Wed, Jun 18, 2014 at 2:14 PM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Jun 18, 2014 at 01:53:00PM -0400, Nicholas Krause wrote:

Re: [PATCH 00/76] staging-next: rtl8723au: More fixes for 3.16

2014-06-18 Thread Greg KH
On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Greg, Thanks for pushing my other changes to Linus. This set goes on top of the set I sent you on 2014/05/31 and the fix from 2014/06/03. If you prefer I go back and submit

Re: [PATCH 00/76] staging-next: rtl8723au: More fixes for 3.16

2014-06-18 Thread Jes Sorensen
Greg KH gre...@linuxfoundation.org writes: On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Greg, Thanks for pushing my other changes to Linus. This set goes on top of the set I sent you on 2014/05/31 and the fix from

[PATCH] Fixes no Null check of dev_skb_alloc in fw_download_code

2014-06-18 Thread Nicholas Krause
Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..1a90546

Re: [PATCH 00/12] staging-next: rtl8723au: More fixes and duplicate defines

2014-06-18 Thread Greg KH
On Wed, Jun 18, 2014 at 10:24:56PM +0200, Jes Sorensen wrote: Greg KH gre...@linuxfoundation.org writes: On Sat, May 31, 2014 at 06:05:07PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Hi Greg, A smaller set of patches this time. It's mainly

Re: [PATCH 2/2 v2] staging: comedi: ni_daq_700: add AI range and input mode switching

2014-06-18 Thread Greg Kroah-Hartman
On Thu, May 29, 2014 at 04:47:00PM +, Hartley Sweeten wrote: On Thursday, May 29, 2014 5:29 AM, Ian Abbott wrote: From: Fred Brooks frederick.bro...@microchip.com Add support for switching the input range and the single-ended/ differential input mode for the AI subdevice. We needed

Re: [PATCH 1/6] staging: comedi: addi_apci_1564: remove send_sig() use

2014-06-18 Thread Greg KH
On Thu, May 29, 2014 at 11:41:53PM -0500, Chase Southwood wrote: The addi-data drivers use send_sig() to let the user know when an interrupt has occurred. The standard way to do this in the comedi subsystem is to have a subdevice that supports asynchronous commands and use comedi_event() to

Re: [PATCH v2 1/5] staging: comedi: addi_apci_1564: remove use of devpriv-b_OutputMemoryStatus

2014-06-18 Thread Greg KH
On Tue, Jun 03, 2014 at 09:33:37PM -0500, Chase Southwood wrote: This member of the private data struct is only set at one location in the entire driver, and then never even used for anything. Let's just remove its use. Signed-off-by: Chase Southwood chase.southw...@gmail.com Reviewed-by:

Re: [PATCH] staging: comedi: describe members involved when reading/writing buffer

2014-06-18 Thread Greg Kroah-Hartman
On Thu, Jun 05, 2014 at 01:11:26PM +0100, Ian Abbott wrote: Signed-off-by: Ian Abbott abbo...@mev.co.uk --- I was originally going to put it in comedidev.h but as that gets passed through the compiler more often, I thought it would be better in comedi_buf.c. Stripping out comments is fast,

Re: [PATCH] Fixes no Null check of dev_skb_alloc in fw_download_code

2014-06-18 Thread Greg KH
On Wed, Jun 18, 2014 at 05:26:18PM -0400, Nicholas Krause wrote: Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 1 file changed, 4 insertions(+) Some more meta-comments. Your subject: should give people a clue as to where

[PATCH] Fixes no Null check of dev_skb_alloc in fw_download_code

2014-06-18 Thread Nicholas Krause
Signed-off-by: Nicholas Krause xerofo...@gmail.com --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..1a90546

Re: [PATCH V2] Staging:tidspbridge Fix minor checkpatch.pl warning.

2014-06-18 Thread Greg KH
On Sun, Jun 08, 2014 at 02:26:20PM +0530, Adithya Krishnamurthy wrote: From: Adithya Krishnamurthy linux.challen...@gmail.com Fixed checkpatch WARNING: Missing a blank line after declarations Signed-off-by: Adithya Krishnamurthy linux.challen...@gmail.com ---

Re: [PATCH] staging: keucr: fix Missing blank line after declarations

2014-06-18 Thread Greg KH
On Sat, Jun 14, 2014 at 09:39:53PM +0200, Benedict Boerger wrote: fix two Missing blank line after declarations issue reported by checkpatch.pl Done to complete an eudyptula task. Signed-off-by: Benedict Boerger benedict.boer...@cs.tu-dortmund.de --- drivers/staging/keucr/usb.c | 2 ++

[PATCHv2]staging:rtl8192e:check return value of dev_skb_alloc

2014-06-18 Thread Nicholas Krause
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 11e915e..fde17ff 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c @@ -62,12 +62,15 @@ static bool

Re: [PATCH] staging: lustre: Use %ld to format long

2014-06-18 Thread Greg Kroah-Hartman
On Mon, Jun 16, 2014 at 08:59:45AM +0200, Geert Uytterhoeven wrote: Hi Greg, On Wed, Jun 11, 2014 at 7:00 PM, Geert Uytterhoeven ge...@linux-m68k.org wrote: drivers/staging/lustre/lustre/llite/rw26.c: In function ‘ll_direct_IO_26’: drivers/staging/lustre/lustre/llite/rw26.c:388: warning:

Re: [PATCH] staging: lustre: obdclass: linux-sysctl.c: fix pointer coding style issue

2014-06-18 Thread Greg KH
On Thu, Jun 12, 2014 at 07:27:12PM +0400, Andrey Skvortsov wrote: Signed-off-by: Andrey Skvortsov andrej.skvort...@gmail.com --- drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c |8 This patch does not apply to my tree for one chunk. Can you please refresh it against

[PATCH 1/1] [media] v4l: omap4iss: configuration using uninitialized variable

2014-06-18 Thread Heinrich Schuchardt
Variable reg is not initialized. Random values are written to OMAP4 ISS registers if !ctx-eof_enabled. Signed-off-by: Heinrich Schuchardt xypron.g...@gmx.de --- drivers/staging/media/omap4iss/iss_csi2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCHv2]staging:rtl8192e:check return value of dev_skb_alloc

2014-06-18 Thread Greg KH
On Wed, Jun 18, 2014 at 06:23:00PM -0400, Nicholas Krause wrote: diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 11e915e..fde17ff 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +++

[PATCH 1/2] Fixes no Null check of dev_skb_alloc in fw_download_code

2014-06-18 Thread Nicholas Krause
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..1a90546 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c @@ -61,6 +61,10 @@ static bool

[PATCHv4]staging:rtl8192e: check return value of dev_skb_alloc

2014-06-18 Thread Nicholas Krause
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..1a90546 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c @@ -61,6 +61,10 @@ static bool

Re: [PATCHv4]staging:rtl8192e: check return value of dev_skb_alloc

2014-06-18 Thread Greg KH
On Wed, Jun 18, 2014 at 07:10:30PM -0400, Nicholas Krause wrote: diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c index 1a95d1f..1a90546 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c +++

Re: Anybody working on crystalhd?

2014-06-18 Thread Greg KH
On Thu, Jun 19, 2014 at 12:07:38AM +, Naren (Narendra) Sankar wrote: We have EOL this part and have not been selling it for a while and there has been no new customer interest in a long time. So I am also ok with this moving off the kernel and being dropped. Great, thanks for the quick

Re: [PATCH 2/2] mmc: rtsx: add support for async request

2014-06-18 Thread micky
On 06/18/2014 07:03 PM, Ulf Hansson wrote: On 18 June 2014 12:08, micky micky_ch...@realsil.com.cn wrote: On 06/18/2014 03:39 PM, Ulf Hansson wrote: On 18 June 2014 03:17, micky micky_ch...@realsil.com.cn wrote: On 06/17/2014 03:45 PM, Ulf Hansson wrote: On 17 June 2014 03:04, micky

Re: [PATCH] staging: rtl8192e: check return value of dev_skb_alloc

2014-06-18 Thread Greg KH
On Wed, Jun 18, 2014 at 10:24:41PM -0400, Nicholas Krause wrote: Checks if dev_skb_alloc returns Null in function, fw_download_code. If the return value of dev_skb_alloc is NULL return false and exit this function. Signed-off-by: Nicholas Krause xerofo...@gmail.com ---

Re: [PATCH] staging: rtl8192e: check return value of dev_skb_alloc

2014-06-18 Thread Joe Perches
On Wed, 2014-06-18 at 22:24 -0400, Nicholas Krause wrote: Checks if dev_skb_alloc returns Null in function, fw_download_code. If the return value of dev_skb_alloc is NULL return false and exit this function. Hello Nicholas. If you're going to try add these checks, please look at the code a

Re: [PATCH] staging: ced1401: fix sparse warning for ced1401

2014-06-18 Thread Greg KH
On Sat, Jun 14, 2014 at 02:04:38PM +0900, Seunghun Lee wrote: This patch fixes below warning. drivers/staging/ced1401/ced_ioc.c:703:30: warning: incorrect type in assignment (different address spaces) drivers/staging/ced1401/ced_ioc.c:703:30:expected void *[usertype] lpvBuff

Re: [PATCH] staging: rtl8192e: check return value of dev_skb_alloc

2014-06-18 Thread Dan Carpenter
On Wed, Jun 18, 2014 at 10:24:41PM -0400, Nicholas Krause wrote: Checks if dev_skb_alloc returns Null in function, fw_download_code. If the return value of dev_skb_alloc is NULL return false and exit this function. Signed-off-by: Nicholas Krause xerofo...@gmail.com ---