Re: Anybody working on line6?

On Tue, Jun 24, 2014 at 4:23 AM, Kristina Martšenko wrote: > I'm helping Greg do a bit of cleanup in the staging tree. I noticed that > nobody seems to have worked towards moving line6 out of staging in over > a year. Are there any plans to clean it up and move it out soon? Because > otherwise we'

Re: [PATCH 4/4] Staging: bcm: hostmibs.c: Shortened lines

On Mon, 23 Jun 2014 21:50:47 +0200 Matthias Beyer wrote: > Signed-off-by: Matthias Beyer > --- > drivers/staging/bcm/hostmibs.c | 39 ++- > 1 file changed, 26 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/bcm/hostmibs.c b/drivers/staging/bcm/

Re: [PATCH 2/4] Staging: bcm: Outsourced copying of classifier table

On Mon, 23 Jun 2014 21:50:45 +0200 Matthias Beyer wrote: > Signed-off-by: Matthias Beyer > --- > drivers/staging/bcm/hostmibs.c | 26 +- > 1 file changed, 17 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/bcm/hostmibs.c b/drivers/staging/bcm/hostmibs.c > i

Re: [PATCH 1/4] Staging: bcm: replaced member accessing with variable for readability

On Mon, 23 Jun 2014 21:50:44 +0200 Matthias Beyer wrote: > Signed-off-by: Matthias Beyer > --- > drivers/staging/bcm/hostmibs.c | 23 --- > 1 file changed, 12 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/bcm/hostmibs.c b/drivers/staging/bcm/hostmibs.c > ind

RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Monday, June 23, 2014 4:10 PM > To: Haiyang Zhang > Cc: o...@aepfle.de; g...@kroah.com; net...@vger.kernel.org; > jasow...@redhat.com; driverdev-devel@linuxdriverproject.org; linux- > ker...@vger.kernel.org > S

Re: [PATCH 00/22] Add and use pci_zalloc_consistent

Hi Joe, On Tue, Jun 24, 2014 at 5:13 AM, Joe Perches wrote: > On Mon, 2014-06-23 at 10:25 -0700, Luis R. Rodriguez wrote: >> On Mon, Jun 23, 2014 at 06:41:28AM -0700, Joe Perches wrote: >> > Adding the helper reduces object code size as well as overall >> > source size line count. >> > >> > It's

Re: Anybody working on dgrp or serqt_usb2?

On 24/06/14 01:08, Bill Pemberton wrote: > On 06/23/2014 04:26 PM, Kristina Martšenko wrote: >> Hi Bill, >> >> I'm helping Greg do a bit of cleanup in the staging tree. I noticed that >> nobody seems to have worked towards moving dgrp or serqt_usb2 out of >> staging in over a year. Are there any pl

Re: Fwd: Re: Anybody working on rtl8712?

On 21/06/14 21:24, Larry Finger wrote: > On 06/21/2014 12:52 PM, Christian Lamparter wrote: >> I think there's a reason why the development takes so long >> (The RTL8192S* chips have been around since 2008, 2009) >> and why we all have better things to do and write harsh >> responses. As far as I c

Re: Fwd: Re: Anybody working on rtl8712?

On 21/06/14 20:52, Christian Lamparter wrote: > On Saturday, June 21, 2014 06:45:07 PM Kristina Martšenko wrote: >> On 20/06/14 23:52, Christian Lamparter wrote: >>> rtl8192su development is chugging along. It just doesn't take place on >>> driverdev list. The driver reached "feature parity" with r

Re: Anybody working on dgrp or serqt_usb2?

On 06/23/2014 04:26 PM, Kristina Martšenko wrote: Hi Bill, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving dgrp or serqt_usb2 out of staging in over a year. Are there any plans to clean these drivers up and move them out soon? B

Re: [PATCH 00/22] Add and use pci_zalloc_consistent

From: Joe Perches Date: Mon, 23 Jun 2014 06:41:28 -0700 > Adding the helper reduces object code size as well as overall > source size line count. > > It's also consistent with all the various zalloc mechanisms > in the kernel. > > Done with a simple cocci script and some typing. For networking

Re: Anybody working on gdm72xx?

On 23/06/14 23:41, Ben Chan wrote: > Hi Kristina and Greg, > > I can help migrate the gdm72xx driver from staging to mainline. I > believe the issues in TODO have been addressed. That's great, thanks! > Is there a migration process that I should follow? I don't think there's anything special yo

Re: [PATCH 6/6] Staging: bcm: Lines shortened in download_ddr_settings()

On Mon, Jun 23, 2014 at 11:42:33AM +0200, Matthias Beyer wrote: > Signed-off-by: Matthias Beyer As with the previous line-wrapping patch, this doesn't seem like a net improvement; the lines seem far more readable un-wrapped. > drivers/staging/bcm/DDRInit.c | 31 +-- >

Re: [PATCH 4/6] Staging: bcm: Fixed indention for inner if-block

On Mon, Jun 23, 2014 at 11:42:31AM +0200, Matthias Beyer wrote: > The inner if-statement was aligned just like the outer one. Why? > > This indention was introduced by > > f34c488c3894968e8cdbdc3b1ed617d78315cace > > which is a indention-fix patch itself. That's why I'm curious about it. >

Re: [PATCH 3/6] Staging: bcm: Lines shortened in ddr_init()

On Mon, Jun 23, 2014 at 11:42:30AM +0200, Matthias Beyer wrote: > Signed-off-by: Matthias Beyer Honestly, none of these seem like improvements. Checkpatch's line-width warnings rarely result in improved code. (Its "maximum indentation level" warnings, which prompt people to refactor functions,

Re: [PATCH 2/6] Staging: bcm: Indentation fixes

On Mon, Jun 23, 2014 at 11:42:29AM +0200, Matthias Beyer wrote: > This patch fixes some indentation errors, where multi-line statements > where not indented. > > Signed-off-by: Matthias Beyer This patch also fixes some whitespace issues, such as a lack of space before '/', which should probably

Re: [PATCH 1/6] Staging: bcm: Misc whitespace fixes

On Mon, Jun 23, 2014 at 11:42:28AM +0200, Matthias Beyer wrote: > Signed-off-by: Matthias Beyer Reviewed-by: Josh Triplett > drivers/staging/bcm/DDRInit.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DD

Anybody working on sep?

Hi Mark, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving sep out of staging in over a year. Are there any plans to clean it up and move it out soon? Because otherwise we're going to have to delete the driver, as we don't want stag

Anybody working on dgrp or serqt_usb2?

Hi Bill, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving dgrp or serqt_usb2 out of staging in over a year. Are there any plans to clean these drivers up and move them out soon? Because otherwise we're going to have to delete them,

Anybody working on phison?

Hi Evan, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving phison out of staging in over a year. Are there any plans to clean it up and move it out soon? Because otherwise we're going to have to delete the driver, as we don't want s

Anybody working on line6?

Hi Markus, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving line6 out of staging in over a year. Are there any plans to clean it up and move it out soon? Because otherwise we're going to have to delete the driver, as we don't want

Anybody working on silicom?

Hi Daniel, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving silicom out of staging in over a year. Are there any plans to clean it up and move it out soon? Because otherwise we're going to have to delete the driver, as we don't wan

Anybody working on quickstart?

Hi Angelo, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving quickstart out of staging in over a year. Are there any plans to clean it up and move it out soon? Because otherwise we're going to have to delete the driver, as we don't

Anybody working on gdm72xx?

Hi Sage, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving gdm72xx out of staging in over a year. Are there any plans to clean it up and move it out soon? Because otherwise we're going to have to delete the driver, as we don't want

Anybody working on cxt1e1?

Hi Bob, I'm helping Greg do a bit of cleanup in the staging tree. I noticed that nobody seems to have worked towards moving cxt1e1 out of staging in over a year. Are there any plans to clean it up and move it out soon? Because otherwise we're going to have to delete the driver, as we don't want st

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

From: Greg KH Date: Mon, 23 Jun 2014 12:29:11 -0400 > Given that this change will fail on all future distro releases, and > almost all of the community distros today, I don't see how this is > acceptable at all. Nor would it be any better if you switch to a > systemd command line script as well.

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

From: Haiyang Zhang Date: Mon, 23 Jun 2014 16:09:59 + > So, what's the equivalent or similar command to "network restart" on SLES12? > Could > you update the command line for the usermodehelper when porting this patch to > SLES > 12? No, you are not going to keep the usermodehelper invocat

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

From: Olaf Hering Date: Mon, 23 Jun 2014 15:17:23 +0200 > On Mon, Jun 23, Haiyang Zhang wrote: > >> > I think its reasonable to expect guest config changes on this new kind >> > of host. Would a link-down/link-up event work? I'm sure it will, there >> > is enough code floating around in the gues

[PATCH 4/4] Staging: bcm: hostmibs.c: Shortened lines

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/hostmibs.c | 39 ++- 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/drivers/staging/bcm/hostmibs.c b/drivers/staging/bcm/hostmibs.c index 63bfb04..9ffd25b 100644 --- a/drivers/staging/bcm/ho

[PATCH 2/4] Staging: bcm: Outsourced copying of classifier table

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/hostmibs.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/drivers/staging/bcm/hostmibs.c b/drivers/staging/bcm/hostmibs.c index af3493c..13c1430 100644 --- a/drivers/staging/bcm/hostmibs.c +++ b

[PATCH 1/4] Staging: bcm: replaced member accessing with variable for readability

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/hostmibs.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/staging/bcm/hostmibs.c b/drivers/staging/bcm/hostmibs.c index 42d9004..af3493c 100644 --- a/drivers/staging/bcm/hostmibs.c +++ b/d

[PATCH 3/4] Staging: bcm: Outsourced SF table copying

This commit includes renaming of variables which got outsourced into an own function to fit the kernel styleguide. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/hostmibs.c | 70 +++--- 1 file changed, 39 insertions(+), 31 deletions(-) diff --git a/dri

[PATCH 0/4] stagign/bcm/hostmibs.c cleanup patches

Hi, this patchset contains cleanup patches for the drivers/staging/bcm/hostmibs.c file, containing fixes for: * Line length * member accessing replaced with variables * outsourced code chunks in own functions Please note: As I do not have the approrpiate Hardware, I'm not able

[PATCH 12/15] Staging: bcm: led_control.c: Replaced doubled if-check by logical OR in one check

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index 8a59115..ae49a59 100644 --- a/drivers/staging/bcm/led_control.c +++ b/dr

[PATCH 13/15] Staging: bcm: led_control.c: Replaced member accessing by variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index ae49a59..4077972 100644 --- a/drivers/staging/bcm/led_co

[PATCH 3/4] Staging: bcm: Replaced member accssing with variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/HandleControlPacket.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/staging/bcm/HandleControlPacket.c b/drivers/staging/bcm/HandleControlPacket.c index 45d18de..6552b15 100644 --- a/drivers/st

[PATCH 0/4] drivers/staging/bcm/HandleControlPacket.c cleanup patches

Hi, this patchset contains cleanup patches for the drivers/staging/bcm/HandleControlPacket.c file. Please note: As I do not have the appropriate hardware, I cannot test these patches. I compiled them at least. Kind regards, Matthias Beyer Matthias Beyer (4): Staging: bcm: line length fi

[PATCH 4/4] Staging: bcm: Added missing blank line after declarations

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/HandleControlPacket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/bcm/HandleControlPacket.c b/drivers/staging/bcm/HandleControlPacket.c index 6552b15..5455221 100644 --- a/drivers/staging/bcm/HandleControlPacket.c +++

[PATCH 1/4] Staging: bcm: line length fixed

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/HandleControlPacket.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/bcm/HandleControlPacket.c b/drivers/staging/bcm/HandleControlPacket.c index 495fe3d..467b0cf 100644 --- a/drivers/staging/bcm/HandleCo

[PATCH 2/4] Staging: bcm: Whitespace for indentation fixed

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/HandleControlPacket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm/HandleControlPacket.c b/drivers/staging/bcm/HandleControlPacket.c index 467b0cf..45d18de 100644 --- a/drivers/staging/bcm/HandleCont

[PATCH 11/15] Staging: bcm: led_control.c: Replaced time selecting ifelse with ternary operator

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index a387c6a..8a59115 100644 --- a/drivers/staging/bcm/led_control.c +++ b/drivers/

[PATCH 10/15] Staging: bcm: led_control.c: More variable names refactored

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index c0509ae..a387c6a 100644 --- a/drivers/staging/bcm/led

[PATCH v4 8/8] Staging: bcm: Line length cleanup

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 276825f..bef13a6 100644 --- a/drivers/staging/bcm/I

[PATCH v4 7/8] Staging: bcm: Shortened some lines in select_alternate_setting_for_highspeed_modem()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 47 ++--- 1 file changed, 18 insertions(+), 29 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 9f9045d..276825f 100644 --- a/drivers/

[PATCH v4 6/8] Staging: bcm: Outsourced selecting of alternate setting

This patch outsources a chunk of code which is for selecting an alternate setting for highspeed modem into a new function. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 207 +++- 1 file changed, 112 insertions(+), 95 deletions(-) diff --

[PATCH v4 4/8] Staging: bcm: Replaced member accessing with variable in InterfaceAdapterInit()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 53 +++-- 1 file changed, 27 insertions(+), 26 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index e1a3e6d..2f540d6 100644 --- a/drivers/

[PATCH v4 5/8] Staging: bcm: Merged some lines which got shorter by the latest patch

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 43 +++-- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 2f540d6..bda33c8 100644 --- a/drivers/

[PATCH v4 1/8] Staging: bcm: Shortened some lines

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index 7c04c73..d61a688 100644 --- a/drivers/staging/bcm/InterfaceInit.c +++ b/

[PATCH v4 3/8] Staging: bcm: Replaced member accessing with variable in device_run()

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index dd7b4a5..e1a3e6d 100644 --- a/drivers/staging/bcm/Interf

[PATCH v4 2/8] Staging: bcm: replaced member accessing by variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/InterfaceInit.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/bcm/InterfaceInit.c b/drivers/staging/bcm/InterfaceInit.c index d61a688..dd7b4a5 100644 --- a/drivers/staging/bcm/Interface

[PATCH v4 0/8] [RESEND] Cleanup patches for staging driver

Hi, this is a resend of my patchset for the drivers/staging/bcm/InterfaceInit.c file. I rebased them onto the lastes 'staging-next' from greg k-hs repository and verified they are not in the branch already. Please notice: I cannot test the patches as I do not have the appropriate hardware.

[PATCH 14/15] Staging: bcm: led_control.c: Replaced member accessing by variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index 4077972..8e6bb6b 100644 --- a/drivers/staging/bcm/led_control.c +++ b

[PATCH 15/15] Staging: bcm: led_control.c: Replaced nested ifs with logical AND concatenation

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index 8e6bb6b..8353677 100644 --- a/drivers/staging/bcm/led_control.c ++

[PATCH 09/15] Staging: bcm: led_control.c: Refactored line lengths

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index 4cf4212..c0509ae 100644 --- a/drivers/staging/bcm/led

[PATCH 06/15] Staging: bcm: led_control.c: Outsourced code chunk

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 159 ++ 1 file changed, 93 insertions(+), 66 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index 085493a..5060bad 100644 --- a/drivers/stag

[PATCH 03/15] Staging: bcm: led_control.{c,h}: Fixed macro

This patch fixes the TURN_{ON,OFF}_LED() macros by adding the adapter as parameter. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 39 +++ drivers/staging/bcm/led_control.h | 16 2 files changed, 31 insertions(+), 24 del

[PATCH 05/15] Staging: bcm: led_control.c: Replaced member accessing

This patch replaces member accessing with a variable in BcmGetGPIOPinInfo(). Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_

[PATCH 00/15] staging/bcm/led_control.c cleanup patches

Hi, these patchset contains cleanup patches for the drivers/staging/bcm/led_control.c file. The patchset contains: * Whitespace / Indentation fixes * Removing dead code * Shortened lines / code * Outsourcing code chunks Please note: As I do not have the appropriate Hardwar

[PATCH 02/15] Staging: bcm: led_control.c: Outsourced adapter driver state handling

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 325 -- 1 file changed, 171 insertions(+), 154 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index fd73dbd..3b3775b 100644 --- a/drivers/st

[PATCH 08/15] Staging: bcm: led_control.c: Removed dead code

This patch removes the never-entered else-block inside blink_in_normal_bandwidth(). The condition of the preceding if statement is always true. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 98 +++ 1 file changed, 37 insertions(+), 61 d

[PATCH 07/15] Staging: bcm: led_control.c: Refactored variable name

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index 5060bad..9808f53 100644 --- a/drivers/staging/bcm/led_control.c +++ b

[PATCH 04/15] Staging: bcm: led_control.c: Simplified nested if conditions

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 40 +++ 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index 612e61e..f528a45 100644 --- a/drivers/stag

[PATCH 01/15] Staging: bcm: led_control.c: Indentation/Whitespace/Line length cleanup

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/led_control.c | 138 ++ 1 file changed, 79 insertions(+), 59 deletions(-) diff --git a/drivers/staging/bcm/led_control.c b/drivers/staging/bcm/led_control.c index eee4f47..fd73dbd 100644 --- a/drivers/stag

Re: [PATCH 00/22] Add and use pci_zalloc_consistent

On Mon, 2014-06-23 at 10:25 -0700, Luis R. Rodriguez wrote: > On Mon, Jun 23, 2014 at 06:41:28AM -0700, Joe Perches wrote: > > Adding the helper reduces object code size as well as overall > > source size line count. > > > > It's also consistent with all the various zalloc mechanisms > > in the ke

RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

> -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Monday, June 23, 2014 12:29 PM > To: Haiyang Zhang > Cc: Olaf Hering; net...@vger.kernel.org; jasow...@redhat.com; driverdev- > de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; > da...@davemloft.net > Subject:

RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Monday, June 23, 2014 12:27 PM > To: Haiyang Zhang > Cc: Greg KH; net...@vger.kernel.org; jasow...@redhat.com; driverdev- > de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; > da...@davemloft.net > Subject:

RE: [PATCH 29/29] staging: comedi: dt282x: automatically handle D/A data format

On Monday, June 23, 2014 8:10 AM, Ian Abbott wrote: > On 2014-06-20 21:13, H Hartley Sweeten wrote: >> The DT2821 series board have jumpers that set the output range for >> the two Analog Output channels. The range_table for the Analog Output >> subdevice provides all possible ranges to the user. W

Re: [PATCH 00/22] Add and use pci_zalloc_consistent

On Mon, Jun 23, 2014 at 06:41:28AM -0700, Joe Perches wrote: > Adding the helper reduces object code size as well as overall > source size line count. > > It's also consistent with all the various zalloc mechanisms > in the kernel. > > Done with a simple cocci script and some typing. Awesome, an

RE: [PATCH 5/8] staging: comedi: adv_pci1710: fix pci1720 bipolar data writes

On Monday, June 23, 2014 4:57 AM, Ian Abbott wrote: > On 2014-06-20 20:01, H Hartley Sweeten wrote: >> On the PCI-1720 board, bipolar analog output ranges use two's >> complement data. Use comedi_offset_munge() to munge the comedi >> offset binary values before writing them to the hardware. > > Whi

Re: [PATCH 09/16] staging: comedi: ni_stc.h: the boardinfo 'name' should be first

On 2014-06-23 17:36, Ian Abbott wrote: On 2014-06-20 19:10, H Hartley Sweeten wrote: The comedi core expects the first member of the boardinfo to be a 'const char *' to the board name. The comedi_recognize() function uses this to locate the correct boardinfo when doing a legacy (*attach) to a co

Re: [PATCH 09/16] staging: comedi: ni_stc.h: the boardinfo 'name' should be first

On 2014-06-20 19:10, H Hartley Sweeten wrote: The comedi core expects the first member of the boardinfo to be a 'const char *' to the board name. The comedi_recognize() function uses this to locate the correct boardinfo when doing a legacy (*attach) to a comedi driver. It doesn't matter in this

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

On Mon, Jun 23, 2014 at 04:09:59PM +, Haiyang Zhang wrote: > > > > -Original Message- > > From: Olaf Hering [mailto:o...@aepfle.de] > > Sent: Monday, June 23, 2014 9:17 AM > > To: Haiyang Zhang > > Cc: Greg KH; net...@vger.kernel.org; jasow...@redhat.com; driverdev- > > de...@linuxdri

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

On Mon, Jun 23, Haiyang Zhang wrote: > I have tried some possibilities, like IF_OPER_DORMANT then IF_OPER_UP with > netdev_state_change() etc. but not able to trigger DHCP review. I will look > at this > further... Is there a link down/up event anyway? If the interface is configured to "on hotp

RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Monday, June 23, 2014 9:17 AM > To: Haiyang Zhang > Cc: Greg KH; net...@vger.kernel.org; jasow...@redhat.com; driverdev- > de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; > da...@davemloft.net > Subject:

Re: [PATCH v3 0/8] Cleanup patches for bcm staging driver

On Mon, Jun 23, 2014 at 11:45:26AM +0200, Matthias Beyer wrote: > Hi, > > these patches are still not applied, am I right? You should have gotten an email if they went into my tree. If not, yes, please rebase and resend after checking my tree to verify they are not already there (same for your o

Re: [PATCH 22/22] vme: bridges: Use pci_zalloc_consistent

On Mon, Jun 23, 2014 at 06:41:50AM -0700, Joe Perches wrote: > Remove the now unnecessary memset too. > > Signed-off-by: Joe Perches > --- > drivers/vme/bridges/vme_ca91cx42.c | 6 ++ > drivers/vme/bridges/vme_tsi148.c | 6 ++ > 2 files changed, 4 insertions(+), 8 deletions(-) Acked-b

Re: [PATCH 20/22] staging: Use pci_zalloc_consistent

On Mon, Jun 23, 2014 at 06:41:48AM -0700, Joe Perches wrote: > Remove the now unnecessary memset too. > > Signed-off-by: Joe Perches > --- > drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 15 --- > drivers/staging/rtl8192ee/pci.c | 37 + > drivers/sta

Re: [PATCH 06/17] staging: comedi: ni_65xx: remove 'invert_outputs' from boardinfo

On 2014-06-20 19:52, H Hartley Sweeten wrote: Im not sure what was intended with this boardinfo. It appears to be trying to handle the sink/source output type of the boards supported by the driver. But, some of the boardinfo does not match the actual hardware descriptions in the manual. The manu

Re: [PATCH] Staging: unisys Remove BROKEN from Kconfig to allow compilation

On Mon, Jun 23, 2014 at 09:12:32AM -0500, Ken Cox wrote: > > On 06/17/2014 05:49 PM, Greg KH wrote: > >On Tue, Jun 03, 2014 at 09:43:35AM -0500, Ken Cox wrote: > >>The unisys drivers now properly check to make sure they are running > >>on the s-Par platform before they will initialize. This was f

Re: [PATCH 29/29] staging: comedi: dt282x: automatically handle D/A data format

On 2014-06-20 21:13, H Hartley Sweeten wrote: The DT2821 series board have jumpers that set the output range for the two Analog Output channels. The range_table for the Analog Output subdevice provides all possible ranges to the user. When a unipolar range is selected the board expects the data t

Re: XVME 6300 with TSI148 bridge on 64 bit Debian (Linux 3.2.57) vme_user issue

Hi All, Thanks for your reply. I have been away the last few weeks. Dan, I am using 64 bit Debian 3.2.57. So I am not using the latest kernel. Would this be a problem? Martyn, I don't have a bus analyzer. I believe I have understood a few more things about my setup, but I still manage to han

Re: [PATCH] Staging: unisys Remove BROKEN from Kconfig to allow compilation

On 06/17/2014 05:49 PM, Greg KH wrote: On Tue, Jun 03, 2014 at 09:43:35AM -0500, Ken Cox wrote: The unisys drivers now properly check to make sure they are running on the s-Par platform before they will initialize. This was fixed in commit fcd0157ece so it is safe to allow the unisys drivers t

[PATCH 20/22] staging: Use pci_zalloc_consistent

Remove the now unnecessary memset too. Signed-off-by: Joe Perches --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 15 --- drivers/staging/rtl8192ee/pci.c | 37 + drivers/staging/rtl8821ae/pci.c | 36 + drivers/s

[PATCH 00/22] Add and use pci_zalloc_consistent

Adding the helper reduces object code size as well as overall source size line count. It's also consistent with all the various zalloc mechanisms in the kernel. Done with a simple cocci script and some typing. Joe Perches (22): pci-dma-compat: Add pci_zalloc_consistent helper atm: Use pci_za

[PATCH 22/22] vme: bridges: Use pci_zalloc_consistent

Remove the now unnecessary memset too. Signed-off-by: Joe Perches --- drivers/vme/bridges/vme_ca91cx42.c | 6 ++ drivers/vme/bridges/vme_tsi148.c | 6 ++ 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/vme/bridges/vme_ca91cx42.c b/drivers/vme/bridges/vme_ca91cx4

Re: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

On Mon, Jun 23, Haiyang Zhang wrote: > > I think its reasonable to expect guest config changes on this new kind > > of host. Would a link-down/link-up event work? I'm sure it will, there > > is enough code floating around in the guests which handles cable unplug. > > Do you mean netif_carrier_off

RE: [PATCH net-next] hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event

> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Monday, June 23, 2014 4:03 AM > To: Haiyang Zhang > Cc: Greg KH; net...@vger.kernel.org; jasow...@redhat.com; driverdev- > de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; > da...@davemloft.net > Subject:

Re: [PATCH 00/18] staging: comedi: s626: remove struct s626_enc_info

On 2014-06-20 21:28, H Hartley Sweeten wrote: The struct s626_enc_info is used in this driver to defined the callbacks and other data needed to handle each encoder "channel". These "channel" numbers are the same as the comedi_subdevice channels. The channels specific stuff can easily be handled

Re: [PATCH 2/8] staging: comedi: adv_pci1710: remove the 'range_codes_*' static arrays

On 2014-06-20 20:01, H Hartley Sweeten wrote: These static arrays are used to program the range regiser with the correct values to select the analog input range. The values in the arrays are incrememntal for the bipolar and unipolar ranges and have bit 4 set when the range is unipolar. Modify th

[PATCH] Staging: slicoss: fixed frivolous else statement warnings in slicoss.c

This is a patch for the slicoss.c file that fixes four instances of the following warning: WARNING: else is not generally useful after a break or return Signed-off-by: Vincent Heuken --- drivers/staging/slicoss/slicoss.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions

Re: [PATCH 5/8] staging: comedi: adv_pci1710: fix pci1720 bipolar data writes

On 2014-06-20 20:01, H Hartley Sweeten wrote: On the PCI-1720 board, bipolar analog output ranges use two's complement data. Use comedi_offset_munge() to munge the comedi offset binary values before writing them to the hardware. Which manual are you looking at? According to Table 4.7 in the P

Re: [PATCH] staging: goldfish: fix direct copy_to_user() from __iomem

On Sun, 2014-06-22 at 03:29 -0400, James A Shackleford wrote: > This patch allocates a few pages and performs an ioread8_rep() from the bus > address, which are then copied to userspace. This fixes the sparse warning: > > drivers/staging/goldfish/goldfish_audio.c:136:43: warning: incorrect type i

Re: [PATCH 0/4] staging: comedi: remove unnecessary COMEDI_MITE dependancies

On 2014-06-20 19:25, H Hartley Sweeten wrote: The mite module provides the DMA interface for the PCI MITE ASIC used on many National Instruments (NI) DAQ boards. Many of the comedi NI drivers do not support DMA and only depend on the mite driver in order to initialze the MITE ASIC. Add the code

Re: [PATCH v3 0/5] staging: comedi: addi_apci_1564: fix Change-of-State interrupt functionality

On 2014-06-21 23:23, Chase Southwood wrote: This patchset introduces a new private data struct for this driver, adds all of the code required to support Change-of-State interrupts for the digital input subdevice, and finally fixes apci1564_interrupt() to service this type of interrupt correctly.

Re: [PATCH v2] staging: comedi: introduce comedi_buf_n_bytes_ready()

On 2014-06-20 18:58, H Hartley Sweeten wrote: Introduce an inline helper to return the number of bytes that are ready to read from the comedi_async buffer. Use the helper in the comedi drivers that currently do the calculation as part of the (*poll) operation. Also, use the helper in comedi_fops

Re: [PATCH] staging: comedi: ke_counter: expose clock source options to user space

On 2014-06-20 18:39, H Hartley Sweeten wrote: As pointed out by Ian Abbott, the INSN_CONFIG_SET_CLOCK_SRC options should be exposed in the user header comedi.h. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/comedi.h | 11 ++

Re: [PATCH v4 0/2] Staging: bcm: InterfaceMisc. file cleanup

Hi, these patches are not applied yet, right? Should I (rebase and) resend them? On 11-06-2014 10:46:09, Matthias Beyer wrote: > Hi, > > I fixed what Dan suggested. > > Kind regards, > Matthias Beyer > > Matthias Beyer (2): > Staging: bcm: Shortened lines > Staging: bcm: InterfaceMisc.c:

Re: [PATCH v3 0/8] Cleanup patches for bcm staging driver

Hi, these patches are still not applied, am I right? Should I (rebase and) resend them? On 12-06-2014 14:13:16, Matthias Beyer wrote: > Hi, > > hopefully, this is the last version of the patchset. > > I fixed up my `sed` error and test compiled the module. > > Please notice: I cannot test the

[PATCH 2/6] Staging: bcm: Indentation fixes

This patch fixes some indentation errors, where multi-line statements where not indented. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 56 +-- 1 file changed, 28 insertions(+), 28 deletions(-) diff --git a/drivers/staging/bcm/DDRInit.

[PATCH 5/6] Staging: bcm: Moved doubled if-block

This patch moves the doubled if block inside the retval-checking one level up. As the if-else-block it was in is now a one-statement if-else block, I removed the braces from it. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/DDRInit.c | 16 +--- 1 file changed, 5 insertions(+

  1   2   >