On 07/12/2014 06:48 PM, K. Y. Srinivasan wrote:
Set cmd_per_lun to reflect value supported by the Host.
In this version of the patch I have addressed comments from
Christoph Hellwig h...@infradead.org
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
Cc: sta...@vger.kernel.org
---
On 07/12/2014 06:48 PM, K. Y. Srinivasan wrote:
Based on the negotiated VMBUS protocol version, we adjust the size of the
storage
protocol messages. The two sizes we currently handle are pre-win8 and post-win8.
In WS2012 R2, we are negotiating higher VMBUS protocol version than the win8
On 07/12/2014 06:48 PM, K. Y. Srinivasan wrote:
Going forward it is possible that some of the commands that are not currently
implemented will be implemented on future Windows hosts. Even if they are not
implemented, we are told the host will corrrectly handle unsupported
commands (by returning
On 07/12/2014 06:48 PM, K. Y. Srinivasan wrote:
On Azure, we have seen instances of unbounded I/O latencies. To deal with
this issue, implement handler that can reset the timeout. Note that the
host gaurantees that it will respond to each command that has been issued.
Signed-off-by: K. Y.
On 07/12/2014 06:48 PM, K. Y. Srinivasan wrote:
On some Windows hosts on FC SANs, TEST_UNIT_READY can return SRB_STATUS_ERROR.
Correctly handle this. Note that there is sufficient sense information to
support scsi error handling even in this case.
In this version of the patch I have addressed
On 07/12/2014 06:48 PM, K. Y. Srinivasan wrote:
Correctly set SRB flags for all valid I/O directions. Some IHV drivers on the
Windows host require this. The host validates the command and SRB flags
prior to passing the command down to native driver stack.
Signed-off-by: K. Y. Srinivasan
Hi,
Thanks for this.
And since I looked at the part in Codingstyle that deals with if-else, I
found another few mistakes regarding braces around a single statement.
The rules say, it turns out, that if one of the clauses in an if-else is
longer than one statement, both clauses should be
On Sun, Jul 13, 2014 at 12:22:02PM -0700, Greg Kroah-Hartman wrote:
On Sun, Jul 13, 2014 at 04:25:06PM +0200, Lars-Peter Clausen wrote:
On 07/13/2014 04:03 PM, Richard Weinberger wrote:
Am 13.07.2014 15:56, schrieb Lars-Peter Clausen:
On 07/13/2014 03:40 PM, Richard Weinberger wrote:
Am
On 13/07/2014 18:46, Greg KH wrote:
On Fri, Jun 27, 2014 at 05:11:45PM +0200, Luca Ellero wrote:
Hi Greg,
On 27/06/2014 16:55, Greg KH wrote:
On Fri, Jun 27, 2014 at 03:04:43PM +0200, Luca Ellero wrote:
Il 26/06/2014 21:23, Greg KH ha scritto:
On Thu, Jun 26, 2014 at 09:36:17AM +0200, Alois
On Mon, Jul 14, 2014 at 08:15:17AM +0200, Hannes Reinecke wrote:
Limiting max_lun to 255 will make the driver to _not_ respond to LUNs higher
than that; ie Well-known LUN won't work here.
Also the SCSI stack will be using REPORT LUNS anyway since you're
advertising SPC-2 compliance. So your
Am 13.07.2014 22:17, schrieb Greg Kroah-Hartman:
On Sun, Jul 13, 2014 at 09:33:38PM +0200, Richard Weinberger wrote:
Maybe we could add COMPILE_TEST to the version string too?
Just to detect such kernels fast in user bug reports...
What kind of bug report are you going to get?
User manages
On Sun, Jul 13, 2014 at 08:25:13PM -0300, Lucas Tanure wrote:
Kernel coding style. Remove useless else statement after return.
Changes from v1 and v2: Fix warning for mixed declarations and code.
Declaration of struct binder_transaction *next made outside of while,
and initialized with NULL.
On 07/14/2014 10:31 AM, Richard Weinberger wrote:
Am 13.07.2014 22:17, schrieb Greg Kroah-Hartman:
On Sun, Jul 13, 2014 at 09:33:38PM +0200, Richard Weinberger wrote:
Maybe we could add COMPILE_TEST to the version string too?
Just to detect such kernels fast in user bug reports...
What kind
On Mon, Jul 14, 2014 at 09:40:39AM +0300, Eli Billauer wrote:
Hi,
Thanks for this.
And since I looked at the part in Codingstyle that deals with
if-else, I found another few mistakes regarding braces around a
single statement. The rules say, it turns out, that if one of the
clauses in an
Am 14.07.2014 10:48, schrieb Lars-Peter Clausen:
On 07/14/2014 10:31 AM, Richard Weinberger wrote:
Am 13.07.2014 22:17, schrieb Greg Kroah-Hartman:
On Sun, Jul 13, 2014 at 09:33:38PM +0200, Richard Weinberger wrote:
Maybe we could add COMPILE_TEST to the version string too?
Just to detect
On 07/14/2014 10:30 AM, Christoph Hellwig wrote:
On Mon, Jul 14, 2014 at 08:15:17AM +0200, Hannes Reinecke wrote:
Limiting max_lun to 255 will make the driver to _not_ respond to LUNs higher
than that; ie Well-known LUN won't work here.
Also the SCSI stack will be using REPORT LUNS anyway since
On Sun, Jul 13, 2014 at 12:36:47PM -0700, Greg KH wrote:
On Sun, Jul 13, 2014 at 09:11:18PM +0200, Peter Senna Tschudin wrote:
This patch cleanup coding style issues reported by checkpatch.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
On 07/14/2014 11:00 AM, Christoph Hellwig wrote:
On Mon, Jul 14, 2014 at 10:57:53AM +0200, Hannes Reinecke wrote:
Okay, that's fine by me.
Should I take this as a reviewed-by tag?
Yes, please do.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries Storage
h...@suse.de
On Mon, Jul 14, 2014 at 10:57:53AM +0200, Hannes Reinecke wrote:
Okay, that's fine by me.
Should I take this as a reviewed-by tag?
___
devel mailing list
de...@linuxdriverproject.org
On 2014-07-12 23:42, Chase Southwood wrote:
This driver no longer depends on anything in addi_common.h, save for a
few headers that it was including indirectly. Remove the include of
addi_common.h and add the includes of linux/interrupt.h
and linux/sched.h directly.
Signed-off-by: Chase
在 2014年7月14日，下午4:57，Richard Weinberger rich...@nod.at 写道：
Am 14.07.2014 10:48, schrieb Lars-Peter Clausen:
On 07/14/2014 10:31 AM, Richard Weinberger wrote:
Am 13.07.2014 22:17, schrieb Greg Kroah-Hartman:
On Sun, Jul 13, 2014 at 09:33:38PM +0200, Richard Weinberger wrote:
Maybe we could
On 2014-07-14 10:15, Ian Abbott wrote:
On 2014-07-12 23:42, Chase Southwood wrote:
This driver no longer depends on anything in addi_common.h, save for a
few headers that it was including indirectly. Remove the include of
addi_common.h and add the includes of linux/interrupt.h
and
This is a patch to the cam.c file that fix a coding style error (do not use C99
// comments)
Signed-off-by: Joerg C. Meyer jo...@meyer.homedns.org
---
drivers/staging/rtl8821ae/cam.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
On 14/07/14 11:28, Luca Ellero wrote:
On 13/07/2014 18:46, Greg KH wrote:
On Fri, Jun 27, 2014 at 05:11:45PM +0200, Luca Ellero wrote:
Hi Greg,
On 27/06/2014 16:55, Greg KH wrote:
On Fri, Jun 27, 2014 at 03:04:43PM +0200, Luca Ellero wrote:
Il 26/06/2014 21:23, Greg KH ha scritto:
On Thu,
Some of architectures have already defined 'die' as macro, so can not
use it as declaration or definition in other modules, or it will cause
compiling issue.
So use more precise name 'force_die' (like 'wrap_bulk') instead of. And
the related error (with allmodconfig under score):
CC [M]
For drivers/staging/lustre/lustre/include/lustre_sec.h:391:
- staging tree: use '\t ' between 'die' and '('.
- linux-next tree: use ' ' between 'die' and '('.
So the patch made under linux-next tree, can not apply to staging-next
or staging tree.
Thanks.
On 07/14/2014 07:59 PM, Chen
On Mon, Jul 14, 2014 at 10:59:32AM +0200, Peter Senna Tschudin wrote:
On Sun, Jul 13, 2014 at 12:36:47PM -0700, Greg KH wrote:
On Sun, Jul 13, 2014 at 09:11:18PM +0200, Peter Senna Tschudin wrote:
This patch cleanup coding style issues reported by checkpatch.
Tested by compilation
On Mon, Jul 14, 2014 at 11:42:33AM +0200, Joerg C. Meyer wrote:
This is a patch to the cam.c file that fix a coding style error (do not use
C99 // comments)
Signed-off-by: Joerg C. Meyer jo...@meyer.homedns.org
Minor nit, you need a blank line between these two lines...
---
On Mon, Jul 14, 2014 at 2:58 PM, Greg KH gre...@linuxfoundation.org wrote:
On Mon, Jul 14, 2014 at 10:59:32AM +0200, Peter Senna Tschudin wrote:
On Sun, Jul 13, 2014 at 12:36:47PM -0700, Greg KH wrote:
On Sun, Jul 13, 2014 at 09:11:18PM +0200, Peter Senna Tschudin wrote:
This patch cleanup
Since you're going to redo this patch anyway, I may as well give you
the normal feedback for these kinds of patches.
From 69cd87aca39730c0578592d1296b738f7f223f29 Mon Sep 17 00:00:00 2001
From: Peter Senna Tschudin peter.se...@gmail.com
Date: Mon, 14 Jul 2014 10:28:42 +0200
Subject: [PATCH
This is a patch to the cam.c file that removes some obsolete C99 style comments
Signed-off-by: Joerg C. Meyer jo...@meyer.homedns.org
---
drivers/staging/rtl8821ae/cam.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8821ae/cam.c b/drivers/staging/rtl8821ae/cam.c
On Mon, Jul 14, 2014 at 04:09:26PM +0200, Joerg C. Meyer wrote:
This is a patch to the cam.c file that removes some obsolete C99 style
comments
Signed-off-by: Joerg C. Meyer jo...@meyer.homedns.org
4 copies of the same patch?
Anyway, this text doesn't match what the patch actually does
This is a patch to the cam.c file that removes some unneeded lines of
commented-out code
Signed-off-by: Joerg C. Meyer jo...@meyer.homedns.org
---
drivers/staging/rtl8821ae/cam.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/rtl8821ae/cam.c
On 07/11/2014 08:09 PM, Greg KH wrote:
[snip]
+ if (!vbuf)
+ return -ENOMEM;
+
+ str_pos += scnprintf(vbuf + str_pos, len - str_pos,
+Virtual PCI Bus devices\n);
Why the leading ' '?
It's the formatting the original author chose to output the
On 07/08/2014 03:39 PM, Josef Gajdusek wrote:
[...]
diff --git a/drivers/staging/iio/magnetometer/Kconfig
b/drivers/staging/iio/magnetometer/Kconfig
index ad88d61..28c2612 100644
--- a/drivers/staging/iio/magnetometer/Kconfig
+++ b/drivers/staging/iio/magnetometer/Kconfig
@@ -5,15 +5,23 @@ menu
Hello Larry Finger,
The patch 5adef66acf73: staging: r8188eu: Add files for new driver -
part 19 from Aug 21, 2013, leads to the following static checker
warning:
drivers/staging/rtl8188eu/os_dep/rtw_android.c:262
rtw_android_priv_cmd()
error: snprintf() is printing too much.
note
I'm not trying to push my changes over the rules. I'm trying to
understand the problem, to avoid creating similar noise in the future.
/note
Now I understand that the problem with the series of 4 patches is that
the subject is the same on the 4 patches. Having the same subject in 4
patches
On Mon, Jul 14, 2014 at 07:01:37PM +0200, Peter Senna Tschudin wrote:
note
I'm not trying to push my changes over the rules. I'm trying to
understand the problem, to avoid creating similar noise in the future.
/note
Now I understand that the problem with the series of 4 patches is that
the
On Mon, Jul 14, 2014 at 07:01:37PM +0200, Peter Senna Tschudin wrote:
note
I'm not trying to push my changes over the rules. I'm trying to
understand the problem, to avoid creating similar noise in the future.
/note
Now I understand that the problem with the series of 4 patches is that
the
This patch fixes checkpatch.pl warning. Add blank line after
declaration.
Signed-off-by: Rahul Bedarkar rahulbedarka...@gmail.com
---
drivers/staging/octeon/ethernet-xaui.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/octeon/ethernet-xaui.c
On Tuesday, July 08, 2014 4:37 PM, Greg KH wrote:
On Thu, Jun 26, 2014 at 12:05:07PM -0700, H Hartley Sweeten wrote:
According to the register programming manual, the filter interval
register is 32-bit. Fix the writes to this register.
Signed-off-by: H Hartley Sweeten
Hi all,
I have updated my Linux Kernel to the latest. I am on Debian 64bit
3.15.5. I issue the following Kernel command line, and the vme_user
module seems to load correctly, however the vme bus is neither mounted
on /dev nor /proc.
I was earlier using a 3.2 debian 32bit and managed to mount
The mite.h header is included only to pickup the MITE_IODWBSR and WENAB defines
needed to set the data window (PCI BAR 1) when initializing the PCI MITE ASIC
on the National Instruments boards supported by this driver.
Remove the include of mite.h by adding the two defines locally in this driver.
The mite module provides the DMA interface for the PCI MITE ASIC used on
many National Instruments (NI) DAQ boards. Many of the comedi NI drivers
do not support DMA and only depend on the mite driver in order to initialze
the MITE ASIC.
Add the code to initialization of the MITE ASIC to these
The mite module provides the DMA interface for the PCI MITE ASIC used on
many National Instruments DAQ boards. This driver does not use DMA and only
depends on the mite module to initialize the MITE ASIC.
Handle the initialization localy and remove the unnecessary dependancies.
Signed-off-by: H
The mite module provides the DMA interface for the PCI MITE ASIC used on
many National Instruments DAQ boards. This driver does not use DMA and only
depends on the mite module to initialize the MITE ASIC.
Handle the initialization localy and remove the unnecessary dependancies.
Signed-off-by: H
The mite module provides the DMA interface for the PCI MITE ASIC used on
many National Instruments DAQ boards. This driver does not use DMA and only
depends on the mite module to initialize the MITE ASIC.
Handle the initialization localy and remove the unnecessary dependancies.
Signed-off-by: H
For aesthetics, add some whitespace to the comedi_driver declaration.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_65xx.c | 8
1 file
For aesthetics, tidy up the whitespace of this function declarations to
follow the form in the rest of the driver.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
This series cleans up the comedi ni_65xx driver.
v2: drop the patch that removed the 'invert_outputs' from the boardinfo
reorder the series a bit to handle the 'invert_outputs' correctly
Depends on:
[PATCH 0/4] staging: comedi: remove unnecessary COMEDI_MITE dependancies
H Hartley
During the attach of this driver, the digital output ports are all
initialized to a known state. Some of the boards supported by this
driver have output ports that are inverted from the comedi view of
the output state. For these boards the values written to the ports
needs to be inverted.
Some of the boards supported by this driver have output ports that are
inverted from the comedi view of the output state. For these boards the
read values from the output ports needs to be inverted before being
modified and inverted again before being written back in the (*insn_bits)
operation.
Rename the CamelCase defines used for the non-recurring registers.
Define all the non-recurring registers and bits.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
For aesthetics, factor the code that disables the input filters out of
ni_65xx_auto_attach().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_65xx.c | 31
Subdevice 3 is used in this driver to provide edge detection of the input
channels.
Move the reset/disable of the interrupts and the request_irq() so that
when subdevice 3 is setup we can conditionally hookup the async command
support only if the irq is available.
Also, remove the noise when the
Update the MODULE_DESCRIPTION to better describe the driver.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_65xx.c | 2 +-
1 file changed, 1
Refactor this function to follow the standard (*insn_config) form.
Add a sanity check of the number of data parameters (insn-n). Currently
the core does not check INSN_CONFIG_CHANGE_NOTIFY.
Fix the writes to the rise/fall edge enable registers. The macro expects
a port value not the port offset
Clean up the multi-line comments at the beginning of the file so they
follow the kernel CodingStyle.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Reviewed-by: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
This patch fixes a checkpatch warning by replacing printk by pr_warn.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Cahnges from V3:
- Splitted the patches by change type
drivers/staging/vt6656/main_usb.c | 2 +-
1 file changed, 1 insertion(+), 1
This patch cleans up the following checkpatch issues:
- tabs instead of spaces on the beginning of a line
- use correct /* */ comment style
- put { and } on the correct places
- line over 80 chars
- indentation style for multi-line calls / comments
- space after semicolon ,
- new line after
This patch removes uneeded typedefs reported by chackpatch and removes
one enum. The removed enum from card.h:
typedef enum _CARD_PHY_TYPE {
PHY_TYPE_AUTO = 0,
PHY_TYPE_11B,
PHY_TYPE_11G,
PHY_TYPE_11A
} CARD_PHY_TYPE, *PCARD_PHY_TYPE;
The following typedefs were removed, but
Use tabs instead of spaces in a set of statements and fix lines
over 80 chars. Reported by checkpatch.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Cahnges from V3:
- Splitted the patches by change type
drivers/staging/vt6656/main_usb.c | 44
This patch cleanup a checkpatch warning by removing double parentheses
from if condition. Additionally it fixes a line over 80 chars.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Cahnges from V3:
- Splitted the patches by change type
This patch remove uneeded return statements reported by checkpatch
and fixes the indentation of a multi-line call.
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin peter.se...@gmail.com
---
Cahnges from V3:
- Splitted the patches by change type
drivers/staging/vt6656/card.c
This member of the private data can be determined by checking the
cmd-stop_src. Do that instead and remove the member.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
For aesthetics, add some whitespace to the Digital I/O subdevice init.
Only hook up the async command support if we have an irq.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
The comedi core expects (*insn_read) functions to return insn-n
data smaples. Fix this function to work like the core expects.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
Comedi (*insn_write) functions are expected to write insn-n values to
the hardware. Fix this function to work like the core expects.
Also, use the comedi_offset_munge() helper to convert the comedi unsigned
values into the two's complement values that the hardware needs.
Signed-off-by: H Hartley
Comedi (*insn_write) functions are expected to write insn-n values
to the hardware. Fix this function to work like the core expects.
Also, don't rely on the return value of ni_ao_comfig_chanlist() to
determine if the values need converted to two's complement before
writing to the hardware. Use
The comedi_krange includes a flags member that currently identifies the
'units' of the range (RF_UNIT) and if the range is from an internal or
external source (RF_EXTERNAL).
Introduce some helper functions to check if a given range is from an
external source.
Signed-off-by: H Hartley Sweeten
The init/reset of the hardware is a bit scattered in this function. For
aesthetics, move the init of the clock dividers so it happens early and
tidy up the code a bit.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
For aesthetics, add some whitespace to the subdevice init.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_mio_common.c | 16
1 file changed, 8
Use the bytes_per_sample() helper instead of 'sizeof(short)' to clarify
the length calculation.
Use comedi_offset_munge() to handle the unsigned to two's complement
munge of the data for bipolar ranges.
Tidy up the local variables.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
The ni_mio_common.c file is included by a number of National Instruments
drivers to provide the common driver support. This series does some
more cleanup to get the file closer to being changed into a module instead
of including it in the drivers.
H Hartley Sweeten (28):
staging: comedi:
For aesthetics, add some whitespace to the subdevice init.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_mio_common.c | 16
1 file changed, 8
This member of the boardinfo for the NI MIO drivers is used to indicate if
the ranges for the analog output subdevice (ao_range_table in the boardinfo)
includes any unipolar ranges. If it's not set, the ao_range_table only has
bipolar ranges.
The 'ao_unipolar' flag is checked when munging the ao
For aesthetics, add some whitespace to the Analog Input subdevice init.
The callers of ni_E_init() do the request_irq() and set dev-irq if the
interrupt is available. Only hook up the async command support if we
have the irq.
Also, remove the '#ifdef PCIDMA' here. The ni_pcimio driver is the
All of the board supported by this driver have at least 8 Digital I/O
channels. A couple of the PCI boards in ni_pcimio have 32 channels.
For aesthetics, change this member of the boardinfo into a bit-field
flag, 'has_32dio_chan', and use that when initializing the DIO subdevice
to set the number
For aesthetics, add some whitespace to the Analog Output subdevice init.
Also, remove the '#ifdef PCIDMA' here and only hook up the async command
support if we have an irq and the board either has a fifo or DMA is
supported.
The ni_pcimio driver is the only place PCIDMA is defined. That driver
For aesthetics, add some whitespace to the subdevice init and
tidy it up a bit.
Remove the need for the extra local variable.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
So of the boards supported by this driver do not have analog inputs and
some don't have analog outputs. Move the calls that reset these subdevices
during the (*attach) by ni_E_init() so they only happen if the subdevices
are present.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
For aesthetics, add some whitespace to the subdevice init.
Refactor the code so that the common parts of the subdevice are initialized
in one place.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
Currently the PCI6xxx boards use a different (*insn_write) function
for the analog output subdevice. Most of the code is identical to the
(*insn_write) used by all the other board types.
For aesthetics, merge the two (*insn_write) functions and handle the
'is_6xxx' differences in the common code.
The board-reg_type if checked quite often in the ni_mio_common.c code to
handle differences in the PCI devices supported by the ni_pcimio driver.
Simplify the code a bit by adding some 'is_{board type}' bit-field flags
to the private data.
Signed-off-by: H Hartley Sweeten
For aesthetics, add some whitespace to the subdevice init and
tidy it up a bit.
Unfortunately we can't get rid of the '#ifdef PCIDMA' here yet due
to other ifdefery in this file. For now just add the correct test
so that the async command support is not hooked up unless we have
an IRQ and DMA.
Currently ni_m_series_ao_config_chanlist() gets the boardinfo pointer in
order to get the number of analog output channels. Get this from the
comedi_subdevice instead.
The ni_old_ao_config_chanlist() function also gets the boardinfo pointer
to get the analog output resolution, 'aobits', in order
Convert the inline MITE_* functions, used to calculate the mite channel
register offsets, into simple macros.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/mite.h
The comedi subdevice (*cancel) function can only be called by the core if the
subdevice supports async commands. Move the initialization of this callback
to it is only set if async commands are enabled.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
For aesthetics, change the 'aobits' in the boardinfo to 'ao_maxdata'
to remove the need for the calculation of the subdevice 'maxdata'.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
For aesthetics, change the 'adbits' in the boardinfo to 'ai_maxdata'
to remove the need for the calculation of the subdevice 'maxdata'.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
For aesthetics, use the subdevice 'maxdata' instead of the board 'adbits'.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_mio_common.c | 16 ++--
1
Hi,
This patch got accepted ?
Thanks
--
Lucas Tanure
+55 (19) 988176559
On Sun, Jul 13, 2014 at 9:31 PM, Lucas Tanure tan...@linux.com wrote:
Kernel coding style. Remove useless else statement after return.
Changes from v1 and v2: Fix warning for mixed declarations and code.
Declaration of
On Fri, Jul 11, 2014 at 03:25:11PM +, Haiyang Zhang wrote:
-Original Message-
From: Sitsofe Wheeler [mailto:sits...@gmail.com]
Sent: Friday, July 11, 2014 1:53 AM
To: Haiyang Zhang
Cc: KY Srinivasan; David S. Miller; de...@linuxdriverproject.org; linux-
-Original Message-
From: Sitsofe Wheeler [mailto:sits...@gmail.com]
Sent: Monday, July 14, 2014 5:31 PM
To: Haiyang Zhang
Cc: KY Srinivasan; David S. Miller; de...@linuxdriverproject.org; linux-
ker...@vger.kernel.org; net...@vger.kernel.org
Subject: Re: [BISECTED][REGRESSION]
This board has 8 digital output and 8 digital input channels. For convienence
all 16 channels are packed into one DIO subdevice. Add a comment to clarify
this.
Tidy up the 'mask' check used when updating the digital outputs.
For aesthetics, rename the digital output and digital input registers.
Tidy up this driver a bit and add support for async commands using the
Analog Input subdevice.
H Hartley Sweeten (15):
staging: comedi: ni_daq_700: remove unnecessary enable and flush of ADC
staging: comedi: ni_daq_700: use 8253.h helpers for timer operations
staging: comedi: ni_daq_700:
The ADC conversions are enabled and the FIFO is flushed by daq700_ai_config()
when the driver is initially attached. There is no reason to repeat the ADC
enable and flush the FIFO before each sample read in the (*insn_read).
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian
For aesthetics, add some white space to the subdevice init and tidy
it up a bit.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_daq_700.c | 20
This board has 8 digital output and 8 digital input channels. The direction
of these channels is not configurable. For convienence all 16 channels are
packed into one DIO subdevice.
The (*insn_config) for this subdevice currently uses the comedi core provided
comedi_dio_insn_config() function to
Clarify the timer operations by using the helper functions in 8253.h.
For aesthetics, factor the ai start conversion code out of daq700_ai_rinsn().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gr...@linuxfoundation.org
---
1 - 100 of 130 matches
Mail list logo
