Re: [PATCH] staging: unisys: fix visorchipset sysfs attribute functions

2014-07-26 Thread Dan Carpenter
On Fri, Jul 25, 2014 at 10:08:06PM +0400, Denis Kirjanov wrote: On 7/25/14, Benjamin Romer benjamin.ro...@unisys.com wrote: This patch cleans up the style, error handling, and string handling in the sysfs functions recently added to visorchipset: Split your changes and send one logical

Re: [PATCH] Staging: unisys: Fix code style

2014-07-26 Thread Greg KH
On Fri, Jul 25, 2014 at 03:37:41PM +0530, Arjun AK wrote: From 8e7748dd81cf63c62dbef8f102e97da1d4d5d90a Mon Sep 17 00:00:00 2001 From: Arjun AK arjunak...@gmail.com Date: Fri, 25 Jul 2014 15:09:11 +0530 Subject: [PATCH] Staging: unisys: Fix code style Why is all of this here in this message?

Re: [PATCH] staging: vt6655: fix direct dereferencing of user pointer

2014-07-26 Thread Guillaume CLÉMENT
Hi Malcolm, On Sat, Jul 26, 2014 at 12:09:49AM +0100, Malcolm Priestley wrote: Hi Guillaume On 25/07/14 13:47, Guillaume Clement wrote: Sparse reported that the data from tagSCmdRequest is given by userspace, so it should be tagged as such. extra is not in user space All right. This is

Re: [PATCH] staging: vt6655: fix direct dereferencing of user pointer

2014-07-26 Thread Guillaume CLÉMENT
On Sat, Jul 26, 2014 at 10:24:30AM +0200, Guillaume CLÉMENT wrote: Hi Malcolm, On Sat, Jul 26, 2014 at 12:09:49AM +0100, Malcolm Priestley wrote: Hi Guillaume On 25/07/14 13:47, Guillaume Clement wrote: Sparse reported that the data from tagSCmdRequest is given by userspace, so it

Re: Anybody working on sep?

2014-07-26 Thread Alan Cox
On Fri, 2014-07-25 at 21:54 -0700, Greg KH wrote: On Fri, Jul 25, 2014 at 10:54:47PM +0100, Alan Cox wrote: On Fri, 2014-07-25 at 20:17 +0300, Kristina Martšenko wrote: On 23/06/14 23:32, Kristina Martšenko wrote: Hi Mark, I'm helping Greg do a bit of cleanup in the staging

Re: [PATCH] staging: vt6655: fix direct dereferencing of user pointer

2014-07-26 Thread Malcolm Priestley
On 26/07/14 10:18, Guillaume CLÉMENT wrote: On Sat, Jul 26, 2014 at 10:24:30AM +0200, Guillaume CLÉMENT wrote: Hi Malcolm, On Sat, Jul 26, 2014 at 12:09:49AM +0100, Malcolm Priestley wrote: Hi Guillaume On 25/07/14 13:47, Guillaume Clement wrote: Sparse reported that the data from

RE: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-26 Thread KY Srinivasan
-Original Message- From: James Bottomley [mailto:jbottom...@parallels.com] Sent: Friday, July 25, 2014 10:10 AM To: KY Srinivasan Cc: linux-ker...@vger.kernel.org; h...@infradead.org; sits...@gmail.com; de...@linuxdriverproject.org; a...@canonical.com; martin.peter...@oracle.com;

RE: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-26 Thread KY Srinivasan
-Original Message- From: Martin K. Petersen [mailto:martin.peter...@oracle.com] Sent: Friday, July 25, 2014 9:57 AM To: KY Srinivasan Cc: Martin K. Petersen; Sitsofe Wheeler; Christoph Hellwig; gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;

[PATCH] staging: unisys: include: uisutils.h: Cleaning up missing null-terminate in conjunction with strncpy

2014-07-26 Thread Rickard Strandqvist
Replacing strncpy with strlcpy to avoid strings that lacks null terminate. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/staging/unisys/include/uisutils.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH] staging: usbip: stub_main.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-07-26 Thread Rickard Strandqvist
Replacing strncpy with strlcpy to avoid strings that lacks null terminate. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/staging/usbip/stub_main.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git

Re: Anybody working on sep?

2014-07-26 Thread Greg KH
On Sat, Jul 26, 2014 at 10:55:11AM +0100, Alan Cox wrote: On Fri, 2014-07-25 at 21:54 -0700, Greg KH wrote: On Fri, Jul 25, 2014 at 10:54:47PM +0100, Alan Cox wrote: On Fri, 2014-07-25 at 20:17 +0300, Kristina Martšenko wrote: On 23/06/14 23:32, Kristina Martšenko wrote: Hi Mark,

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-26 Thread Martin K. Petersen
KY == KY Srinivasan k...@microsoft.com writes: The LBP VPD page flags UNMAP as being supported. Do you actually support UNMAP to DSM TRIM SCSI-ATA translation? KY I have been told by the Windows folks that this is done. I am trying KY to get additional details. Great! I'd just like to have a

RE: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-26 Thread KY Srinivasan
-Original Message- From: Martin K. Petersen [mailto:martin.peter...@oracle.com] Sent: Saturday, July 26, 2014 9:55 AM To: KY Srinivasan Cc: Martin K. Petersen; Sitsofe Wheeler; Christoph Hellwig; gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-26 Thread Martin K. Petersen
KY == KY Srinivasan k...@microsoft.com writes: Great! I'd just like to have a reasonable level of confidence in what's happening down the stack before I entertain turning something on that's not being properly advertised. KY As I look at the output of inquiry between Linux on Hyper-V and KY

[PATCH] wlan-ng:prism2sta: Changes reporting format to meet checkpatch.pl

2014-07-26 Thread torresariass
From: Santiago Torres torresari...@gmail.com [linux-next]: Make the format strings for netdev_err shorter so they can fit under the 80 column width requirement. To achieve this, the result= was stripped down to an implicit version (i.e. result=%d to (%d)). This allows the whole string to fit

Re: [PATCH] wlan-ng:prism2sta: Changes reporting format to meet checkpatch.pl

2014-07-26 Thread Greg Kroah-Hartman
On Sat, Jul 26, 2014 at 04:09:24PM -0400, torresari...@gmail.com wrote: From: Santiago Torres torresari...@gmail.com [linux-next]: Make the format strings for netdev_err shorter so they can fit under the 80 column width requirement. We do not have that requirement for strings at all, so no

[PATCH] staging: ced1401: userspace: use1401.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-07-26 Thread Rickard Strandqvist
Replacing strncpy with strlcpy to avoid strings that lacks null terminate. And replacing strncat with strlcat because of incorrect use. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/staging/ced1401/userspace/use1401.c | 12 ++-- 1 file changed, 6

RE: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

2014-07-26 Thread KY Srinivasan
-Original Message- From: Martin K. Petersen [mailto:martin.peter...@oracle.com] Sent: Saturday, July 26, 2014 12:25 PM To: KY Srinivasan Cc: Martin K. Petersen; Sitsofe Wheeler; Christoph Hellwig; gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;