On Mon, 2014-07-28 at 20:11 -0300, Murilo Opsfelder Araujo wrote:
This patch makes checkpatch.pl script happy by fixing the following
warning:
WARNING: else is not generally useful after a break or return
Signed-off-by: Murilo Opsfelder Araujo mopsfel...@gmail.com
---
On 2014-07-28 at 09:58:12 +0200, Anil Belur ask...@gmail.com wrote:
From: Anil Belur ask...@gmail.com
- private_ioctl() the internally calls copy_{to,from}_user() and does
not use '__user' while refrencing user space pointers.
- this patch passes __user annotation as a cast, when the
On Mon, Jul 28, 2014 at 06:48:20PM +0200, Matthias Beyer wrote:
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/IPv6Protocol.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/bcm/IPv6Protocol.c
On 2014-07-28 18:26, H Hartley Sweeten wrote:
Convert this enum into defines and rename all the CamelCase symbols.
For aesthetics, move the new defines so they are associated with the
register define.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
On Mon, Jul 28, 2014 at 09:22:36AM -0400, Benjamin Romer wrote:
@@ -1736,53 +1748,36 @@ parahotplug_process_message(CONTROLVM_MESSAGE *inmsg)
}
}
-/*
- * Gets called when the udev script writes to
- * /proc/visorchipset/parahotplug. Expects input in the form of id
- * active
On Tue, Jul 29, 2014 at 10:05:38AM +0200, Tobias Klauser wrote:
On 2014-07-28 at 09:58:12 +0200, Anil Belur ask...@gmail.com wrote:
From: Anil Belur ask...@gmail.com
- private_ioctl() the internally calls copy_{to,from}_user() and does
not use '__user' while refrencing user space
This is a patch to the r8180_93cx6.c file that fixes
commenting style warning
---
drivers/staging/rtl8192u/r8180_93cx6.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8180_93cx6.c
b/drivers/staging/rtl8192u/r8180_93cx6.c
index
This is a patch to the r8180_93cx6.h file that fixes
long lines along with some additional warning.
---
drivers/staging/rtl8192u/r8180_93cx6.h | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8180_93cx6.h
Setting the stride can only be done on inactive channels, while
the buffer base address can also be updated for running channels
using the hardware double buffering feature.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/staging/imx-drm/ipuv3-plane.c | 3 +--
1 file changed, 1
This allows to update the buffer base address while the DMA
channel is running. It is needed to flip the frame buffer of
an active plane.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/staging/imx-drm/ipuv3-plane.c | 14 +++---
1 file changed, 11 insertions(+), 3
While the DMA channel is running, it is not allowed to change anything
but the inactive (double) buffer base address, so resizing a plane or
changing to a frame buffer with different pixel format is not possible.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
For the overlay plane scanning out a framebuffer with an alpha component,
enable the DP local alpha feature on the partial plane.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/staging/imx-drm/ipuv3-plane.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
On 2014-07-28 18:26, H Hartley Sweeten wrote:
Fix the CamelCase issues by replacing the enums used for the register
bits with simple defines/macros and renaming the symbols.
Remove some unnecessary BUG() checks and tidy up some of the functions
in ni_tiocmd.
H Hartley Sweeten (19):
staging:
This is a patch to the r8190_rtl8256.c file that fixes
checkpatch reported space coding style issues.
---
drivers/staging/rtl8192u/r8190_rtl8256.c | 167 +++
1 file changed, 80 insertions(+), 87 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c
This is a patch to the r8190_rtl8256.c file that fixes
checkpatch reported space coding style issues.
Signed-off-by: Sanjeev Sharmasanjeev_sha...@mentor.com
---
drivers/staging/rtl8192u/r8190_rtl8256.c | 169 +++
1 file changed, 79 insertions(+), 90 deletions(-)
From: Thierry Reding tred...@nvidia.com
The mfd_add_devices() function takes a struct resource * as fifth
argument, but the nvec driver passes in a void __iomem *. The driver
gets away with it because none of the subdevices ever directly access
the registers.
Since subdevices never need to
Fix checkpatch issues: CHECK: Blank lines aren't necessary before a
close brace '}'.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci230.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c
Tidy up the amplc_pci230 driver a bit. There are more changes to come
after this. The only one of these that should alter the object code is
patch 06, which replaces a udelay() call with usleep_range().
01) staging: comedi: amplc_pci230: reformat a load of comments
02) staging: comedi:
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci230.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c
b/drivers/staging/comedi/drivers/amplc_pci230.c
index cb86d04..c6c3c4a 100644
---
Fix checkpatch issues CHECK: Logical continuations should be on the
previous line.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci230.c | 33 +--
1 file changed, 16 insertions(+), 17 deletions(-)
diff --git
Since anything non-zero is logically true, don't bother doing
not-equal comparisons with zero.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci230.c | 75 +--
1 file changed, 36 insertions(+), 39 deletions(-)
diff --git
The macro constants `PCI230_DAC_SETTLE`, `PCI230_ADC_SETTLE` and
`PCI230_MUX_SETTLE` are never used. Just remove them.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci230.c | 13 -
1 file changed, 13 deletions(-)
diff --git
Fix checkpatch issue: CHECK: usleep_range is preferred over udelay; see
Documentation/timers/timers-howto.txt. I picked 100 us as a reasonable
upper bound, but it's not that critical.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci230.c | 2 +-
1 file
If an expression involving a binary operator needs to be split across
two lines, put the split after the operator.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci230.c | 86 +--
1 file changed, 43 insertions(+), 43 deletions(-)
Fix checkpatch issue: CHECK: Alignment should match open parenthesis.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci230.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c
A few lines in `pci230_ai_check_chanlist()` are indented one level too
much, so remove the excess indentation.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci230.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
Several macros are defined for bit-field values within hardware
registers. They are defined as left-shifted values. Add some
whitespace around the left-shift operator.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci230.c | 128 +-
The macro `PCI230_ADC_CONV` is never used. Just remove it. (At one
time, the value was written to the `PCI230_ADCSWTRIG` register to
trigger a conversion, but any value would do, and the driver no longer
uses that register to trigger conversions anyway.)
Signed-off-by: Ian Abbott
The `PCI230_TEST_BIT()` macro is never used. Remove it.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci230.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c
Remove the address-of operator when the operand is a function.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci230.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c
Reformat a load of comments to fit in with the preferred coding style,
including the copyright and driver description comments at the top of
the file.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci230.c | 837 +++---
1 file changed,
The members of the elements of `pci230_boards[]` that are not explicitly
named in their initializers will be initialized to 0 automatically, so
there is no need to initialize them to 0 explicitly.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci230.c | 6
Remove some pairs of parentheses that don't really improve readability.
Also, reduce the amount of leading whitespace in a few places.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci230.c | 78 +--
1 file changed, 37 insertions(+),
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci230.c | 151 ++
1 file changed, 58 insertions(+), 93 deletions(-)
diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c
b/drivers/staging/comedi/drivers/amplc_pci230.c
index
Align the member comments a bit better in the declaration of `struct
pci230_private`. Also remove the heading comment as it is just a
boilerplate comedi comment.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci230.c | 45 ++-
1
Add a bit of whitespace to the initializer of `pci230_boards[]` for
aesthetic reasons.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci230.c | 76 ++-
1 file changed, 39 insertions(+), 37 deletions(-)
diff --git
This patch removes the unneccessary blocks inside the case statements
and fixes the indentation of their content.
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/IPv6Protocol.c | 88 +-
1 file changed, 40 insertions(+), 48
Removes whitespace before semicolons and add blank line after
declaration.
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/IPv6Protocol.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/bcm/IPv6Protocol.c
This patch simplifies
if (a) {
x = false;
} else {
if (b) {
x = false;
}
}
to
if (a || b) {
x = false;
}
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/IPv6Protocol.c | 7 ++-
1 file changed, 2
Hi,
these are my patches for the
drivers/staging/bcm/IPv6Protocol.c
file. The suggested changes are included. I rebased onto latest HEAD of greg KHs
staging-next branch.
Please note: I'm not able to test these patches as I do not have the
appropriate hardware, I compiled them at least.
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/IPv6Protocol.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/bcm/IPv6Protocol.c
b/drivers/staging/bcm/IPv6Protocol.c
index 5bcdaf9..deb67b1 100644
---
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/IPv6Protocol.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/bcm/IPv6Protocol.c
b/drivers/staging/bcm/IPv6Protocol.c
index deb67b1..8a35c1f 100644
---
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/IPv6Protocol.c | 93 --
1 file changed, 60 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/bcm/IPv6Protocol.c
b/drivers/staging/bcm/IPv6Protocol.c
index 01ad11f..27f3f41
Looks good, thanks.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
This patch removes comment related to the delete code.
CC: Lidza Louina lidza.lou...@gmail.com
CC: Mark Hounschell ma...@compro.net
Signed-off-by: Seunghun Lee way...@gmail.com
---
drivers/staging/dgnc/dgnc_cls.c |3 ---
1 file changed, 3 deletions(-)
diff --git
On Tue, Jul 29, 2014 at 08:15:38AM -0500, Romer, Benjamin M wrote:
On Tue, 2014-07-29 at 12:13 +0300, Dan Carpenter wrote:
This is the same bug I mentioned ealier in a different patch.
Yes, I know that - my intent was to get this patch in to move the entry,
then fix the error in the
On Tue, 2014-07-29 at 16:58 +0300, Dan Carpenter wrote:
This is broken code which clearly hasn't been tested. Wat???
Oh, I think I see what you mean. When I said tested, I meant that the
entries appear in sysfs instead of proc, not that they pass data
anywhere or work with s-Par correctly. I
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 115 +++---
1 file changed, 57 insertions(+), 58 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 817d115..c4a75a8 100644
---
This patch replaces the do-while(0); loop which is used for breaking if
a check fails by using the `continue` statement. This saves one
indentation level.
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 95 +++
1
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 0eb78a8..769adb7 100644
--- a/drivers/staging/bcm/Qos.c
+++
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index d01470f..e59abe4 100644
--- a/drivers/staging/bcm/Qos.c
Hi,
these are my patches for the
drivers/staging/bcm/Qos.c
file.
Please review them. If you want, I can squash the Line length / Whitespace
cleanup patches into one big patch, but I guess it is better this way, also for
reviewing them.
Please note, as always: As I do not have the
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 31 ---
1 file changed, 16 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index c4a75a8..d01470f 100644
---
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 769adb7..817d115 100644
--- a/drivers/staging/bcm/Qos.c
+++
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 2cc87b5..9455c25 100644
--- a/drivers/staging/bcm/Qos.c
+++
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 9895252..ee50481 100644
--- a/drivers/staging/bcm/Qos.c
+++
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 24 +++-
1 file changed, 19 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 2176d28..9895252 100644
--- a/drivers/staging/bcm/Qos.c
+++
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 22 ++
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index f3cef86..9465817 100644
--- a/drivers/staging/bcm/Qos.c
+++
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 40 +---
1 file changed, 33 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index ee50481..f5f85d7 100644
---
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 13cfd06..d4c9a09 100644
--- a/drivers/staging/bcm/Qos.c
+++ b/drivers/staging/bcm/Qos.c
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 80c5c65..13cfd06 100644
--- a/drivers/staging/bcm/Qos.c
+++
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 193 +++---
1 file changed, 148 insertions(+), 45 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 1608ba4f..2176d28 100644
---
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 53 +--
1 file changed, 42 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index f5f85d7..3ab287e 100644
---
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 51 +--
1 file changed, 40 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index b277ae6..f8eb3fe 100644
---
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index f8eb3fe..80c5c65 100644
--- a/drivers/staging/bcm/Qos.c
+++ b/drivers/staging/bcm/Qos.c
@@ -396,6
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 47 +++
1 file changed, 35 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 3ab287e..b277ae6 100644
---
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 9455c25..f3cef86 100644
--- a/drivers/staging/bcm/Qos.c
+++
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 891f690..0f733f9 100644
--- a/drivers/staging/bcm/Qos.c
+++
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 9465817..b24ee8a 100644
--- a/drivers/staging/bcm/Qos.c
+++
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 4bba0a9..1608ba4f 100644
--- a/drivers/staging/bcm/Qos.c
+++
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 23 +++
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 0f733f9..589bd42 100644
--- a/drivers/staging/bcm/Qos.c
+++
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 50 +++
1 file changed, 37 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 747790d..4bba0a9 100644
---
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 86 ++-
1 file changed, 41 insertions(+), 45 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index d4c9a09..b3ac614 100644
---
This patch adds new a new directory parahotplug to the visorchipset sysfs
directory, and two new attributes, deviceenabled, and devicedisabled, into the
new directory, to add s-Par parahotplug support.
The parahotplug interface is used to deal with SR-IOV recovery situations on
s-Par guest
Remove the parahotplug proc code entirely in preparation for replacement with
sysfs entries. Since visorchipset_proc_read_writeonly() is orphaned by the
removal, it is removed as well.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
v6: the patch was split into remove and rewrite
Don't resend (this could be fixed in a follow on patch, or whatever).
It would be nicer to just return false directly. The label could be
renamed to found:.
Don't worry that returning messes up the debugging, just delete the
debug output because it is nonsense anyway.
regards,
dan carpenter
Signed-off-by: Matthias Beyer m...@beyermatthias.de
---
drivers/staging/bcm/Qos.c | 96 ---
1 file changed, 75 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index 589bd42..747790d 100644
---
These patches fix typos in the name of a type referenced in a sizeof
command. These problems are not caught by the compiler, because they have
no impact on execution - the size of a pointer is independent of the size
of the pointed value.
The semantic patch that finds these problems is shown
From: Julia Lawall julia.law...@lip6.fr
Correct typo in the name of the type given to sizeof. Because it is the
size of a pointer that is wanted, the typo has no impact on compilation or
execution.
This problem was found using Coccinelle (http://coccinelle.lip6.fr/). The
semantic patch used
Your patches are ok so far. We can't ack the future patches until we
see them but it sounds reasonable.
I guess send them bit by bit so you don't feel bad if we ask you to redo
them.
On Tue, Jul 29, 2014 at 05:08:42PM +0200, Matthias Beyer wrote:
* remove developer debug BCM_DEBUG() macros
On Tuesday, July 29, 2014 2:22 AM, Ian Abbott wrote:
On 2014-07-29 10:07, Ian Abbott wrote:
On 2014-07-28 18:26, H Hartley Sweeten wrote:
Convert this enum into defines and rename all the CamelCase symbols.
For aesthetics, move the new defines so they are associated with the
register define.
On 2014-07-29 17:04, Hartley Sweeten wrote:
On Tuesday, July 29, 2014 2:22 AM, Ian Abbott wrote:
I see the original function was inline as well, so maybe that should be
a separate patch to remove the inlines.
As you noted, the original was inline. I plan on removing these.
I renamed the
-Original Message-
From: James Bottomley [mailto:jbottom...@parallels.com]
Sent: Monday, July 28, 2014 1:03 PM
To: KY Srinivasan
Cc: linux-ker...@vger.kernel.org; h...@infradead.org; sits...@gmail.com;
de...@linuxdriverproject.org; a...@canonical.com;
martin.peter...@oracle.com;
From: Fernando Apesteguia fernando.apesteg...@gmail.com
Add static to the definition of the pci device table.
Signed-off-by: Fernando Apesteguia fernando.apesteg...@gmail.com
---
drivers/staging/vt6655/device_main.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Delete the S8 type from commontypes.h since it wasn't being used.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/commontypes.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/include/commontypes.h
This patch switches all use of the U16 typedef to use the kernel's u16 type
instead.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
.../include/channels/controlframework.h| 18
.../include/channels/controlvmchannel.h| 24
This patch switches all use of the S64 typedef to use the kernel's s64 type
instead.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/commontypes.h | 2 --
drivers/staging/unisys/include/uisutils.h| 4 ++--
drivers/staging/unisys/visorchipset/file.c
This patch switches all use of the S16 typedef to use the kernel's s16 type
instead.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/common-spar/include/channels/diagchannel.h | 2 +-
drivers/staging/unisys/include/commontypes.h | 1 -
2
Delete the S32 type from commontypes.h since it wasn't being used.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/include/commontypes.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/include/commontypes.h
The include/commontypes.h file defines many types locally when the kernel's
existing types should have been used instead. This patch series converts all of
the U8 through U64 and S8 through S64 types, and removes the extraneous type
definition.
Benjamin Romer (8):
staging: unisys: remove U8
This patch switches all use of the U8 typedef to use the kernel's u8 type
instead.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
.../unisys/common-spar/include/channels/channel.h | 54 +-
.../include/channels/controlframework.h| 4 +-
This patch switches all use of the U64 typedef to use the kernel's u64 type
instead.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
.../unisys/common-spar/include/channels/channel.h | 42 ++---
.../include/channels/controlframework.h| 2 +-
This patch switches all use of the U32 typedef to use the kernel's u32 type
instead.
Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com
---
drivers/staging/unisys/channels/channel.c | 8 +-
drivers/staging/unisys/channels/chanstub.c | 4 +-
KY == KY Srinivasan k...@microsoft.com writes:
KY We will fix this bug in the next release of Windows; we are also
KY looking at backporting the fix to prior versions of Windows.
Excellent. Thanks for looking into this!
--
Martin K. Petersen Oracle Linux Engineering
Am Dienstag 29 Juli 2014, 13:16:14 schrieb Thierry Reding:
From: Thierry Reding tred...@nvidia.com
The mfd_add_devices() function takes a struct resource * as fifth
argument, but the nvec driver passes in a void __iomem *. The driver
gets away with it because none of the subdevices ever
Use the comedi_device parameter that is passed to this function to find
the dev-iobase so it does not have to be included in each call.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
For aesthetics, pass the comedi_device to mite_setup() and mite_setup2()
so that the dev-class_dev can be used in the dev_{level} message to make
the messages have consistancy with the other comedi drivers.
Remove the extra dev_warn() noise in the drivers when mite_setup() fails.
Rename the
Use the new 'mmio' member in the comedi_device for the ioremap'ed
base address.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/mf6x4.c | 47
Use the new 'mmio' member in the comedi_device for the ioremap'ed
base address of PCI bar 3.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 41
Use the new 'mmio' member in the comedi_device for the ioremap'ed
base address.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/gsc_hpdi.c | 44
1 - 100 of 128 matches
Mail list logo
