Signed-off-by: Eli Billauer eli.billa...@gmail.com
---
MAINTAINERS | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index f040e7f..95bcdee 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8789,12 +8789,6 @@ M: Arnaud Patard
On Mon, Sep 08, 2014 at 09:09:14PM +0200, Nitin Kuppelur wrote:
Hi Aaro,
Thanks for review. I will correct the commit log length and resend the patch.
About the __cvmx_usb_perform_complete():
Here return statement has associated label. Due to which it will add
compilation warning. So I am
On 2014-09-08 at 21:02:49 +0200, Adrian Nicoara anico...@uwaterloo.ca wrote:
Cleanup checkpatch.pl warnings.
Please state which warning this is fixing. Same goes for patches 1-3.
Signed-off-by: Adrian Nicoara anico...@uwaterloo.ca
---
Somehow I missed the comment Tobias made on the line
On Mon, Sep 08, 2014 at 03:02:49PM -0400, Adrian Nicoara wrote:
Cleanup checkpatch.pl warnings.
Signed-off-by: Adrian Nicoara anico...@uwaterloo.ca
---
Somehow I missed the comment Tobias made on the line indentation. I fixed the
patch, and added here as a reply - the previous patch
On Tue, Sep 09, 2014 at 09:39:37AM +0200, Domagoj Trsan wrote:
This patch fix various coding style issues.
Tested by compilation only.
Break the patch up into one type of fix per patch. Say which thing you
are fixing in the changelog. style is too vague.
[patch 1] long lines
[patch 2] add
On 2014-09-09 00:18, H Hartley Sweeten wrote:
In order for DMA to work we also need an interrupt. Refactor the code
so that the DMA allocation is only done if the interrupt is available.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
The `comedi_board` inline function takes a single parameter of type
`struct comedi_device *` and merely returns the value of the `board_ptr`
member therein. This is somewhat superfluous as the member can be
accessed directly.
Replace all uses of `comedi_board(dev)` with `dev-board_ptr`.
Note,
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/addi-data/addi_eeprom.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/addi_apci_3xxx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/addi_apci_1516.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/addi-data/addi_common.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/adl_pci9118.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/adv_pci_dio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/adv_pci1710.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/cb_pcidas.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
.../staging/comedi/drivers/amplc_dio200_common.c | 30 +++---
1 file changed, 15 insertions(+), 15 deletions(-)
diff
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/amplc_pci224.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/aio_aio12_8.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das1800.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08_isa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/me4000.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das6402.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 66 ++--
1 file changed, 33 insertions(+), 33 deletions(-)
diff
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/ni_at_ao.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/ni_660x.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/ni_labpc_isadma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/ni_at_a2150.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das08.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/ni_atmio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/ni_65xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/das16.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/ni_mio_common.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/dt3000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/dt2801.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/ni_atmio16d.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/dt282x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/pcl724.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/pcl726.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/pcmad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/ni_labpc_common.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/pcl812.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/pcl818.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/pcl711.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/pcl816.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/pcl730.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/ni_pcimio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/rti800.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/pcmuio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/vmk80xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
The `comedi_board(dev)` inline function calls just return
`dev-board_ptr`. Expand the inline function calls.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/drivers/rtd520.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On 2014-09-08 20:34, Hartley Sweeten wrote:
On Monday, September 08, 2014 12:15 PM, Greg Kroah-Hartman wrote:
On Tue, Aug 19, 2014 at 12:32:36PM +0100, Ian Abbott wrote:
Commit 4f9c63fe5333b27ab23ed399830c7977f6970744 (staging: comedi:
amplc_pci230: refactor iobase addresses) removed some
fixed sparse warning : context imbalance in 'resume_device'
unexpected unlock
this patch will generate warning from checkpatch for
lines over 80 character , but since those are user-visible strings
so it was not modified.
Signed-off-by: Sudip Mukherjee
Copy the channel type into a temporary buffer so that code will work
for architectures that don't support MMIO. This now works in same way
as other tests in same function.
Signed-off-by: Luke Hart luke.h...@birchleys.eu
---
drivers/staging/unisys/common-spar/include/channels/channel.h | 9
Am Montag, den 08.09.2014, 12:50 -0700 schrieb Greg Kroah-Hartman:
On Tue, Jul 29, 2014 at 11:57:06AM +0200, Philipp Zabel wrote:
For the overlay plane scanning out a framebuffer with an alpha component,
enable the DP local alpha feature on the partial plane.
Signed-off-by: Philipp Zabel
While the DMA channel is running, it is not allowed to change anything
but the inactive (double) buffer base address, so resizing a plane or
changing to a frame buffer with different pixel format is not possible.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
For the overlay plane scanning out a framebuffer with an alpha component,
enable the DP local alpha feature on the partial plane.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/staging/imx-drm/ipuv3-plane.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
Setting the stride can only be done on inactive channels, while
the buffer base address can also be updated for running channels
using the hardware double buffering feature.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
drivers/staging/imx-drm/ipuv3-plane.c | 3 +--
1 file changed, 1
On Sun, Sep 07, 2014 at 06:18:34PM +0200, Julia Lawall wrote:
diff --git a/drivers/staging/lustre/lustre/obdclass/obd_config.c
b/drivers/staging/lustre/lustre/obdclass/obd_config.c
index f41695d..8a9752f 100644
--- a/drivers/staging/lustre/lustre/obdclass/obd_config.c
+++
On Tue, 9 Sep 2014, Dan Carpenter wrote:
On Sun, Sep 07, 2014 at 06:18:34PM +0200, Julia Lawall wrote:
diff --git a/drivers/staging/lustre/lustre/obdclass/obd_config.c
b/drivers/staging/lustre/lustre/obdclass/obd_config.c
index f41695d..8a9752f 100644
---
Hello!
On Sep 9, 2014, at 8:54 AM, Dan Carpenter wrote:
460 #define OBD_CHECK_DT_OP(obd, op, err) \
461 do {\
462 if (!OBT(obd) || !OBP((obd), op)) { \
463 if
From: Julia Lawall julia.law...@lip6.fr
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// smpl
@@
identifier lbl;
identifier rc;
constant c;
@@
- GOTO(lbl,\(rc\|c\));
+ goto lbl;
@@
identifier lbl;
expression rc;
@@
- GOTO(lbl,rc);
+ rc;
+ goto lbl;
//
From: Hugues Morisset morisset.hug...@gmail.com
fix coding style issues including:
* Better alignement of some structures
* Fonction pointer with wrong style
* Remove enums declarations
* A missing empty line
Hugues Morisset (3):
staging: lustre: fix coding style on long lines and a
From: Hugues Morisset morisset.hug...@gmail.com
Signed-off-by: Hugues Morisset morisset.hug...@gmail.com
---
drivers/staging/lustre/lustre/include/obd.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/obd.h
From: Hugues Morisset morisset.hug...@gmail.com
Signed-off-by: Hugues Morisset morisset.hug...@gmail.com
---
drivers/staging/lustre/lustre/include/obd.h | 10 +++---
drivers/staging/lustre/lustre/lmv/lmv_obd.c | 2 +-
drivers/staging/lustre/lustre/lmv/lproc_lmv.c | 6 +++---
3 files
On Tue, Sep 09, 2014 at 04:36:25PM +0200, Hugues Morisset wrote:
From: Hugues Morisset morisset.hug...@gmail.com
This is fine, but next time leave this line out. We get the information
from your email address unless you are forwarding patches on behalf of
someone else.
regards,
dan carpenter
On Mon, Sep 08, 2014 at 12:09:49PM -0700, Greg Kroah-Hartman wrote:
On Mon, Sep 08, 2014 at 12:08:59PM -0700, Greg Kroah-Hartman wrote:
On Mon, Sep 01, 2014 at 06:07:12PM +0100, Russell King - ARM Linux wrote:
Greg,
Here's two oops fixes for imx-drm, which I've had queued up for a
On Tuesday, September 09, 2014 3:08 AM, Ian Abbott wrote:
On 2014-09-09 00:18, H Hartley Sweeten wrote:
In order for DMA to work we also need an interrupt. Refactor the code
so that the DMA allocation is only done if the interrupt is available.
Signed-off-by: H Hartley Sweeten
On Tuesday, September 09, 2014 3:26 AM, Ian Abbott wrote:
The `comedi_board` inline function takes a single parameter of type
`struct comedi_device *` and merely returns the value of the `board_ptr`
member therein. This is somewhat superfluous as the member can be
accessed directly.
This is a patch to the octeon-hcd.c file that
removes dummy label i.e. label followed by return of
void function
Signed-off-by: Nitin Kuppelur nitinkuppe...@gmail.com
---
drivers/staging/octeon-usb/octeon-hcd.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git
Signed-off-by: Domagoj Trsan domagoj.tr...@gmail.com
---
drivers/staging/speakup/i18n.h | 28 +---
drivers/staging/speakup/main.c | 3 ++-
2 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/speakup/i18n.h b/drivers/staging/speakup/i18n.h
Signed-off-by: Domagoj Trsan domagoj.tr...@gmail.com
---
drivers/staging/speakup/keyhelp.c| 4
drivers/staging/speakup/kobjects.c | 1 +
drivers/staging/speakup/main.c | 41 +++-
drivers/staging/speakup/serialio.c | 2 ++
Signed-off-by: Domagoj Trsan domagoj.tr...@gmail.com
---
drivers/staging/speakup/buffers.c | 1 -
drivers/staging/speakup/main.c| 1 -
drivers/staging/speakup/varhandlers.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/staging/speakup/buffers.c
Signed-off-by: Domagoj Trsan domagoj.tr...@gmail.com
---
drivers/staging/speakup/keyhelp.c | 3 ++-
drivers/staging/speakup/spk_types.h | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/speakup/keyhelp.c
b/drivers/staging/speakup/keyhelp.c
index
On Tue, Sep 09, 2014 at 05:22:19PM +0200, Nitin Kuppelur wrote:
This is a patch to the octeon-hcd.c file that
removes dummy label i.e. label followed by return of
void function
Signed-off-by: Nitin Kuppelur nitinkuppe...@gmail.com
---
drivers/staging/octeon-usb/octeon-hcd.c | 5 +
1
On 09/08, Bill Pemberton wrote:
On 09/08/2014 04:17 PM, Greg KH wrote:
On Sat, Aug 30, 2014 at 04:35:56PM -0400, wf...@worldbroken.com wrote:
From: Bill Pemberton wf...@worldbroken.com
The jsm driver (drivers/tty/serial/jsm) already supports the Digi Neo
cards that dgnc (staging) supports.
This function modifies the analog input acquistion programming after the first
DMA cycle to continue a mode4 acqusition. Part of this programs timer 0 based
on the hardware address of the next buffer. When double buffering is not used
for DMA the next buffer is always the first, and only, buffer.
For aesthetics, merge these two helper functions and add a parameter,
'enable', to determine if the external trigger is being added (enabled)
or deleted (disabled).
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
For aesthetics, move the master/target abort detection from the DMA handler to
the
main interrupt handler. This allows removing the unused 'int_amcc' parameter
from
the DMA and non-DMA handlers.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc:
The comment states that paramoid checks are broken. They also would only
work for 12-bit analog input samples.
Instead of fixing the paranoid checking just remove it to simplify the
driver a bit.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc:
In order for DMA to work we also need an interrupt. Refactor the code
so that the DMA allocation is only done if the interrupt is available.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Rename this function so it has namespace associated with the driver.
Also, this function always succeeds. Change the return type to void
and remove the unnecessary error handling by the callers.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc:
The legacy (*attach) currently allows the user to pass a mask of error
conditions
to ignore when running async commands. Remove this support so that the async
command is always terminated if the hardware reports an error.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian
Start cleaning up the async command support in this comedi driver.
This is a repost of the series. I missed the first patch last time.
H Hartley Sweeten (30):
staging: comedi: adl_pci9118: factor out DMA alloc/free
staging: comedi: adl_pci9118: DMA requires an interrupt
staging: comedi:
The async command can operation in 4 modes in this driver.
Modes 1 and 4 use timers 1 and 2 as a cascaded timer to trigger each conversion.
Mode 1 begins the acquisitions immediately (scan_begin_src == TRIG_FOLLOW) and
Mode 4 begins after an external trigger (scan_begin_src == TRIG_EXT). Both
The (*do_cmdtest) validates the scan_begin_src as TRIG_FOLLOW, TRIG_TIMER,
or TRIG_EXT. Remove the invalid check for TRIG_INT in the (*do_cmd).
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The DMA and non-DMA both check the analog input status value to detect
hardware errors. For aesthetics, move the this detection into the main
interrupt handler. This allows removing the unused 'int_adstat' parameter
from the DMA and non-DMA handlers. In addition, the 'int_daq' parameter
is also
This member of the private data is set but never used. Just remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci9118.c | 3 ---
1 file changed, 3
The pci9118_ai_docmd_dma() function enables the DMA bit in the ai control
register for all acquisition modes. For aesthetics, move the enable of
this bit into the (*do_cmd).
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Each of the error detections currently do a cfc_handle_events() and exits
the interrupt handler if the error is detected. The DMA and non-DMA handlers
also to a cfc_handle_events().
For aesthetics, use goto to exit the interrupt handler if an error is detected
and move the cfc_handle_events()
The async command can start immediately (TRIG_NOW), from an internal
trigger (TRIG_INT), or from an external trigger (TRIG_EXT). Currently
the start of the command is scattered in the DMA and non-DMA helper
functions.
Consolidate the start of the async command at the end of the (*do_cmd)
For aesthetics, wrap the DMA buffer information in a struct.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci9118.c | 96 ++--
1 file
Hardware errors will now always terminate an async command. For aesthetics,
absorb pci9118_decode_error_status() into the interrupt handler and use
the register map defines to remove the magic numbers. Refactor the code
to set the appropriate comedi event bits and handle the event.
Remove the
The 'source' passed to pci9118_exttrg_{add,del}() is always EXTTRG_AI.
Remove the parameter and unnecessary sanity checking. Also, since there
is only one vaild exttrg source, remove the unnecessary 'exttrg_users'
member from the private data.
The pci9118_exttrg_{add,del}() functions always
This member of the private data is only used in some #if 0'ed code. Remove
it along with the unused code.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
This driver currently supports both the (*auto_attach) and legacy (*attach)
mechanisms. The (*auto_attach) always tries to use the interrupt and DMA to
support async commands with the analog input subdevice. The legacy (*attach)
only enables them depending on a user option that is passed to the
The 'rot' and 'usedma' parameters are not used in this function. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci9118.c | 15 +--
1
This function is called by the analog input (*insn_read) and (*do_cmd)
operations. The pci9118_set_chanlist() function is also called by those
operations. Setting the range and aref logically belongs with setting
the chanlist. To clarify the code, absorb pci9118_ai_set_range_aref()
into
Currently the pci9118_ai_docmd_dma() or pci9118_ai_docmd_sampl() helper
is called by the (*do_cmd) to do the final setup for the command. Most
of this invloves setting various bits in 'ai_ctrl' and 'int_ctrl' to
setup the acquisition based on the 'ai_do' mode. Most of this is the
same for the DMA
For aesthetics, change the type of this member to avoid the casts when
allocating
and freeing the DMA buffers. This does introduce a cast in move_block_from_dma()
but that cast is cleaner.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Introduce a helper function to start the async command.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci9118.c | 43
1 file
1 - 100 of 142 matches
Mail list logo