On Thu, Sep 11, 2014 at 10:42:49AM +0300, Dan Carpenter wrote:
On Thu, Sep 11, 2014 at 03:17:52PM +0800, micky_ch...@realsil.com.cn wrote:
+ err = pci_read_config_byte(pcr-pci, addr, val);
+ if (err)
+ return err;
Some of these check for if (err) and some check for if (err
On 09/12/2014 04:36 PM, Dan Carpenter wrote:
You've updated them all to be if (err 0) how is that different from
if (err)? What I'm saying is that could you reply to the question?
I guess I normally prefer if (err) over if (err 0) but I don't
know if it makes a difference here?
Hi Dan,
The last parameter of `__get_free_pages()` is log2 (the 'order') of the
number of pages to be allocated. This driver seems to think it is the
linear number of pages, so `pci9118_alloc_dma()` first tries to allocate
16 pages, but only uses 4 of them, setting the buffer size to PAGE_SIZE
multiplied
adl_pci9118 allocates more pages of DMA buffer than it uses, may
allocate half a double-buffer it does not use because it's the wrong
half that it managed to allocate (unlikely), and relies on virt_to_bus()
to treat generic kernel memory from get_free_pages() as coherent DMA
memory. Correct the
`pci9118_alloc_dma()` tries to allocate two DMA buffers but may allocate
a single buffer or none at all. If it fails to allocate the first
buffer, it still tries to allocate the second buffer, even though it
won't be used. Change it to not bother trying to allocate the second
buffer if the first
Use `dma_alloc_coherent()` to allocate the DMA buffers instead of
using `__get_free_pages()` to allocate and `virt_to_bus()` to get the
hardware address. The coherent buffers are fairly small - at most 4
pages (although there are two of them). Use of `virt_to_bus()` is
discouraged.
All calls to the inline function `comedi_board()` in comedidev.h have
been removed, so remove the function.
Signed-off-by: Ian Abbott abbo...@mev.co.uk
---
drivers/staging/comedi/comedidev.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/comedi/comedidev.h
On 2014-09-12 00:07, H Hartley Sweeten wrote:
The comedi async commands should stop if an error/overflow happens or when
the end-of-acquisition for the command is detected. Some of the drivers
do this correctly but many don't.
The cfc_handle_events() function automatically detects the events
Copy the channel type into a temporary buffer so that code will work
for architectures that don't support MMIO. This now works in same way
as other tests in same function.
Signed-off-by: Luke Hart luke.h...@birchleys.eu
---
drivers/staging/unisys/common-spar/include/channels/channel.h | 10
On 11/09/2014 22:53, Greg KH wrote:
On Mon, Sep 08, 2014 at 03:27:35PM +0100, Luke Hart wrote:
Copy the channel type into a temporary buffer so that code will work
for architectures that don't support MMIO. This now works in same way
as other tests in same function.
Signed-off-by: Luke Hart
Use `dma_alloc_coherent()` to allocate the DMA buffers instead of
using `__get_free_pages()` to allocate and `virt_to_bus()` to get the
hardware address. The coherent buffers are fairly small - at most 4
pages (although there are two of them). Use of `virt_to_bus()` is
discouraged.
Note:
`apci3120_auto_attach()` first sets `devpriv-us_UseDma` to 1, then sets
it back to 0 if it fails to allocate the DMA buffer. Since `*devpriv`
is initially zeroed out by `comedi_alloc_devpriv()`, change it to only
set `devpriv-us_UseDma` to 1 if the allocation succeeds. Also, don't
bother
`apci3120_auto_attach()` tries to allocate two DMA buffers but may
allocate a single buffer or none at all. If it fails to allocate the
first buffer, it still tries to allocate the second buffer, even though
it won't be used. Change it to not bother trying to allocate the second
buffer if the
The last parameter of `__get_free_pages()` is log2 (the 'order') of the
number of pages to be allocated. This driver seems to think it is the
linear number of pages, so `apci3120_auto_attach()` first tries to allocate
16 pages, but only uses 4 of them, setting the buffer size to PAGE_SIZE
addi_apci_3120 allocates more pages of DMA buffer than it uses, may
allocate half a double-buffer it does not use because it's the wrong
half that it managed to allocate (unlikely), and relies on virt_to_bus()
to treat generic kernel memory from get_free_pages() as coherent DMA
memory. Correct
fixed sparse warning : context imbalance in 'destroy_device'
unexpected unlock
this patch will generate warning from checkpatch for
lines over 80 character , but since those are user-visible strings
so it was not modified.
Signed-off-by: Sudip Mukherjee
- add line after declaration
Signed-off-by: Sorin Facaoaru w...@sorin.cc
---
drivers/staging/octeon/ethernet-tx.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/staging/octeon/ethernet-tx.c
b/drivers/staging/octeon/ethernet-tx.c
index 4e54d85..b7a7854 100644
---
This patch fixes the following sparse warnings:
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c:284:51: warning:
cast removes address space of expression
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c:284:39: warning:
incorrect type in assignment (different address
How do I make this stick suck less? I was sitting in the same room as my
AP when I ran the scan. My atheros card picks up 2 strong APs plus my
own, and 4-7 others of varying strengths.
Not even a directional antenna lists more networks.
3.15.9
[I] sys-kernel/linux-firmware
Installed
On Fri, Sep 12, 2014 at 11:45:44PM +1000, Artemiy Volkov wrote:
--- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c
+++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c
@@ -281,7 +281,8 @@ ksocknal_recv_iov (ksock_conn_t *conn)
if (nob (int)iov-iov_len) {
This patch Convert pr_warning to pr_warn.
Signed-off-by: Masanari Iida standby2...@gmail.com
---
drivers/staging/emxx_udc/emxx_udc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emxx_udc/emxx_udc.c
index
On Fri, 12 Sep 2014, Dan Carpenter wrote:
On Fri, Sep 12, 2014 at 11:45:44PM +1000, Artemiy Volkov wrote:
--- a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c
+++ b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c
@@ -281,7 +281,8 @@ ksocknal_recv_iov (ksock_conn_t *conn)
This patch fixes the following sparse warnings:
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c:284:51: warning:
cast removes address space of expression
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c:284:39: warning:
incorrect type in assignment (different address
On Fri, Sep 12, 2014 at 09:25:01AM -0700, Jim Davis wrote:
Building with the attached random configuration file,
ERROR: obd_memory
[drivers/staging/lustre/lustre/obdclass/obdclass.ko] undefined!
make[1]: *** [__modpost] Error 1
You are bit slower than the 0-day bot, the proper developers
On Fri, Sep 12, 2014 at 09:47:56AM -0400, Weedy wrote:
How do I make this stick suck less? I was sitting in the same room as my
AP when I ran the scan. My atheros card picks up 2 strong APs plus my
own, and 4-7 others of varying strengths.
Not even a directional antenna lists more networks.
Signed-off-by: Vincenzo Scotti vin...@gmail.com
Reported-by: kbuild test robot fengguang...@intel.com
---
drivers/staging/emxx_udc/emxx_udc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emxx_udc/emxx_udc.c
index
Sudip Mukherjee sudipm.mukher...@gmail.com wrote:
fixed sparse warning : context imbalance in 'destroy_device'
unexpected unlock
this patch will generate warning from checkpatch for
lines over 80 character , but since those are user-visible strings
so it was not
From 9d5063797464f03b87a9b157eed94c25ef22b1c5 Mon Sep 17 00:00:00 2001
From: Fabien Malfoy fabien.mal...@laposte.net
Date: Sat, 13 Sep 2014 00:22:54 +0200
Subject: [PATCH] Fix a coding style problem
Several pointer declaration syntax have been fixed to match the coding
style.
Signed-off-by:
On Mon, Jun 30, 2014 at 10:39:33AM +0200, Laurent Navet wrote:
I'm helping Greg do a bit of cleanup in the staging tree. I noticed
that
nobody seems to have worked towards moving line6 out of staging in over
a year. Are there any plans to clean it up and move it out soon?
Because
img alt=www.Alibaba.com
src=http://img.alibaba.com/images/eng/style/logo/logo_email.gif;
border=0 vspace=6 width=175 height=32
table cellpadding=0 cellspacing=4 align=center
bgcolor=#99 border=0 width=560tbodytr
td bgcolor=#ff
table cellpadding=0 cellspacing=0 border=0 width=100%
tbody
30 matches
Mail list logo
