These look good to me.
Reviewed-by: Dan Carpenter dan.carpe...@oracle.com
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sun, Oct 19, 2014 at 03:27:00PM +0200, Konrad Zapalowicz wrote:
On 10/19, Chen Weixiang wrote:
-u8 ConnectionMsg[] =
{0x00,0x44,0x10,0x20,0x80,0x00,0x00,0x00,0x00,0x00,0x03,0x00,0x00,0x00,0x93,0x64,
-
Having documentation would help reviewers.
Here is some documentation I found online.
http://www.phonesdevelopers.com/1793504/
But it seems like it was originally written in another language and auto
translated to English.
I don't see who is going to maintain this, if no one has time to even
As a follow-up to commit 6cab7a37f5c04 (staging: comedi: (regression)
channel list must be set for COMEDI_CMD ioctl), Hartley Sweeten pointed
out another couple of bugs stemming from commit 6cab7a37f5c04 (staging:
comedi: comedi_fops: introduce __comedi_get_user_chanlist()).
Firstly,
On Thursday 16 October 2014 14:47:41 Greg Kroah-Hartman wrote:
From: Greg Kroah-Hartman gre...@linuxfoundation.org
The Android binder code has been stable for many years now. No matter
what comes in the future, we are going to have to support this API, so
might as well move it to the real
According to ADDI-DATA, this board was discontinued last year and they
feel that no further development is needed for this driver. Remove the
driver from comedi to help with the addi-data cleanup.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc:
Now that the timer 'channels' are handled correctly in the subdevice functions,
fix the number of timer channels. The APCI-1564 has 4 timers.
Also, remove the unnecessary initialzation of the subdevice 'len_chanlist'. That
member is only used by subdevices that support async commands.
These defines don't add any significant clarity to the driver. Remove them.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c | 12
This driver currently passes the timer channel in a manner that violates
the comedi API. Fix the timer subdevice so that the timers channels are
correctly used from the insn-chanspec.
Fix the I/O access for the boards registers. Currently the iobase used to
access the counters and the main board
Move the bit defines for the APCI1564_DO_INT_CTRL/STATUS_REG from the included
source file to the main driver source file.
For aesthetics, rename the bit defines so they have namespace associated
with the register defines. Also, remove the unnecessary 'disable' defines
and convert the 'enable'
Move the defines for the APCI1564_DI_IRQ_REG from the included source file
to the main driver source file.
For aesthetics, rename the bit defines so they have namespace associated
with the register define. Also, remove the unnecessary 'disable' define
and convert the 'enable' define to a
Move the defines for the register map from the included source file to
the main driver source file.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c
This driver currently passes the timer channel as the data[5] element to the
timer (*insn_config) function. This is stored in the private data and use in
the timer (*insn_read) and (*insn_write) functions to read/write the timer.
This is just wrong, comedi passes the channel number in the
For aesthetics, rename this member to simply 'amcc'.
Change the type to match the type returned by pci_resource_start().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
According to the I/O map information from ADDI-DATA, the counters are accessed
using the base address found in PCI BAR 2 not the one in PCI BAR 1.
Add a new member to the private data for this base address and fix all the
counter I/O.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
According to the I/O map information from ADDI-DATA, the board registers are
accessed using the base address found in PCI BAR 1 not the one in PCI BAR 0.
The PCI BAR 1 address is stored in dev-iobase during the attach. Use that
instead of devpriv-amcc_iobase (PCI BAR 0).
Signed-off-by: H Hartley
On Wed, 15 Oct 2014, Thomas Shao wrote:
And again you forgot to cc John Stultz on this
Export do_adjtimex function for hyper-v Time Synchronization component
Signed-off-by: Thomas Shao huis...@microsoft.com
---
kernel/time/timekeeping.c |1 +
1 files changed, 1 insertions(+), 0
This member of the private data is not used by the driver. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi_apci_3120.c | 2 --
1 file changed, 2
An interrupt is required for DMA to work.
Factor out the DMA buffer allocation from the (*auto_attach) and only
allocate the buffers if the interrupt is available.
For aesthetics, also factor the DMA buffer free from the (*detach).
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
For aesthetics, wrap the DMA buffer information in a struct.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
.../comedi/drivers/addi-data/hwdrv_apci3120.c | 85 +-
More cleanup of the addi_apci_3120 driver.
These apply after:
[PATCH 00/34] staging: comedi: addi-data: remove common code bloat
H Hartley Sweeten (22):
staging: comedi: addi_apci_3120: DMA requires an interrupt
staging: comedi: addi_apci_3120: introduce struct apci3120_dmabuf
staging:
The AMCC registers are accessed using the base address devpriv-i_IobaseAmcc
not devpriv-i_IobaseAddon. Fix a couple writes in apci3120_interrupt_dma()
that are using the wrong base address.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
This member of the private data holds the start address of PCI BAR 2 that is
used to access the AMCC Add-On registers.
Rename this CamelCase member and fix its type.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
For aesthetics, add some white space to the digital input subdevice
initialization.
Remove the subdev_flags SDF_GROUND and SDF_COMMON. These only apply to
analog subdevices.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
For aesthetics, add some white space to the analog input subdevice
initialization.
The async command support in this driver is pretty messed up. I'm not
really sure if it actually works yet. Luckly this driver was not
setting the SDF_CMD_READ subdev_flag so the command support was not
actually
The analog outputs of the APCI-3120 have a 14-bit bipolar range and use straight
binary values (0x = -10V to 0x3fff = +10V) to set the outputs. This driver
tries to fake a unipolar range by munging the comedi data values to only output
0V to +10V signals (0x to 0x1fff values are munged to
For aesthetics, add some white space to the analog output subdevice
initialization.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/addi_apci_3120.c | 18
The DA_READY bit (0x0001) in the status register needs to be set before the
analog outputs can be updated.
Use comedi_timeout() to prevent a deadlock condition while waiting for the
DA_READY bit to get set.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
The struct str_AnalogReadInformation is not used in this driver.
Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
.../staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 17
It appears that this subdevice is actually broken. The subdevice functions
all violate the comedi API and, it they did work, it appears they would
break the analog input async commands.
For now just tidy up the subdevice init.
Add the SDF_READABLE subdev_flag, this subdevice provides an
The analog input (*cancel) stops the async command. There is not reason to also
call the board reset function.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The board registers are accessed using the bse address devpriv-iobase not
devpriv-i_IobaseAmcc. Fix a read in apci3120_interrupt() that is using the
wrong base address.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
This member of the private data holds the start address of PCI BAR 0 that is
used to access the AMCC registers.
Rename this CamelCase member and fix its type.
Remove an unnecessary local variable, 'ui_Tmp', in apci3120_cyclic_ai() and
tidy up the rest of the local variable declarations.
Move the apci3120_reset() call in the (*auto_attach) to ensure that the board
is reset before hooking up the interrupt.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The apci3120_reset() function is called at the end of the (*auto_attach) and
with the (*detach) is called to unload the driver. Part of this function
resets all the analog output channels to 0V.
There are two problems with this.
1) Only the APCI-3120 has analog outputs, the APCI-3001 does not.
2)
The comedi core calls all the subdevice (*cancel) functions before it does
the driver (*detach). There is no reason to call the board reset function
in the (*detach).
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Use the comedi_subdevice 'readback' member and the core provided (*insn_read)
function to provide radback of the analog output channels.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The comedi core expects (*insn_write) functions to write insn-n values and
return the number of values written or an errno. This function currently
returns insn-n but it only writes a single data value.
Fix the function to work like the core expects.
There are two registers used to update the
This member of the private data holds the start address of PCI BAR 1 that is
used to access the board registers. The start address is also stored in the
comedi_device 'iobase' member. Use that instead and remove the private data
member.
Remove some unnecessary casts when reading the board
For aesthetics, add some white space to the digital output subdevice
initialization.
Remove the subdev_flags SDF_GROUND and SDF_COMMON. These only apply to
analog subdevices. Also remove the unnecessary SDF_READABLE subdev_flag.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc:
On Mon, 20 Oct 2014, Thomas Gleixner wrote:
On Wed, 15 Oct 2014, Thomas Shao wrote:
And again you forgot to cc John Stultz on this
Export do_adjtimex function for hyper-v Time Synchronization component
Aside of that, we really want to see the use case for this and how you
addressed
Introduce a generic method to read samples from the async buffer.
The size of each sample is detected automatically using the bytes_per_sample()
helper. The unsigned long long is used to avoid any possible integer overflow
when calculating the 'nbytes' for all the requested samples. This value is
This function is only called by comedi_buf_read_samples(). Absorb it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/comedi_buf.c | 27 ++-
1 file
Use the new generic method to read the analog output samples from the async
buffer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/amplc_pci224.c | 7 +++
1
Currently there are 3 exported methods to read sample data from the async
buffer.
1) cfc_read_array_from_buffer() - a wrapper around
comedi_read_array_from_buffer()
2) comedi_read_array_from_buffer() - reads multiple samples
3) comedi_buf_get() - reads a single sample
In addition there
This inline function is no longer used. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/comedi_fc.h | 7 ---
1 file changed, 7 deletions(-)
diff
A number of drivers currently use comedi_buf_get() to read single samples
from the the async buffer. This works but the drivers have to handle the
COMEDI_CB_BLOCK and COMEDI_CB_EOS events. Converting those drivers to use
comedi_buf_read_samples() moves the handling of those events into the core.
Introduce a helper function to read the analog output samples from the
async buffer.
This fixes a bug in load_ao_dma_buffer(). That function was decrementing
the 'ao_count' by the number of bytes, not the number of samples, that
were read from the async buffer.
Use comedi_buf_read_samples() to
This function is no longer used. Remove it.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/comedi_buf.c | 14 --
drivers/staging/comedi/comedidev.h | 1 -
2
This parameter is always passed as '0'. Remove the unnecessary parameter.
This allows removing the unnecessary check of the write_ptr overflow.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Introduce a helper function to read the analog output samples from the
async buffer and prep the DMA.
Use comedi_buf_read_samples() to read the analog output samples from
the async buffer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
This function is only used internally. Remove the export.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/comedi_buf.c | 6 +++---
drivers/staging/comedi/comedidev.h | 3
This parameter is always passed as '0'. Remove the unnecessary parameter.
This allows removing the unnecessary check of the read_ptr overflow.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use comedi_buf_read_samples() to get the single samples from the async
buffer. The number of samples in the buffer was validated by the callers
so the error checking can be removed. In addition, the core will set the
COMEDI_CB_BLOCK event so it can also be removed.
Signed-off-by: H Hartley
This function is only used internally. Remove the export.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/comedi_buf.c | 17 +++--
Use comedi_buf_read_samples() to read the analog output samples from
the async buffer. That function will set the COMEDI_CB_BLOCK event
when samples are read from the async buffer. In addition, the core
will also handle the end-of-scan detection and set the COMEDI_CB_EOS
event.
Signed-off-by: H
Introduce a helper function to load the analog output FIFO.
This fixes a bug in cb_pcidas_ao_inttrig(). That function was writing
'num_bytes' data values to the FIFO instead of 'num_points'. This results
in twice the number of data values getting written to the FIFO.
Use
Use comedi_buf_read_samples() to read the analog output samples from
the async buffer. That function will set the COMEDI_CB_BLOCK event
when samples are read from the async buffer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
This function is only used internally. Remove the export.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/comedi_buf.c | 6 +++---
drivers/staging/comedi/comedidev.h | 3
Use comedi_buf_read_samples() to read the analog output samples from
the async buffer. That function will set the COMEDI_CB_BLOCK event
when samples are read from the async buffer.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
A macro doing some arithmetic to calculate a register offset, did not
contain an argument to the macro in parentheses, potentially leading to
unexpected results when using that macro with arithmetic expressions as
argument.
Signed-off-by: Soren Brinkmann soren.brinkm...@xilinx.com
---
On Monday, October 20, 2014 7:11 AM, Ian Abbott wrote:
As a follow-up to commit 6cab7a37f5c04 (staging: comedi: (regression)
channel list must be set for COMEDI_CMD ioctl), Hartley Sweeten pointed
out another couple of bugs stemming from commit 6cab7a37f5c04 (staging:
comedi: comedi_fops:
Reported by: coverity (CID 142963)
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_65xx.c | 3 ---
1 file changed, 3 deletions(-)
diff --git
Reported by: coverity (CID 142962)
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_6527.c | 3 ---
1 file changed, 3 deletions(-)
diff --git
Reported by: coverity (CID 142967)
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_mio_common.c | 3 ---
1 file changed, 3 deletions(-)
diff --git
On Mon, Oct 20, 2014 at 2:20 AM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Mon, Oct 20, 2014 at 06:05:47AM +0800, Greg Kroah-Hartman wrote:
On Fri, Oct 17, 2014 at 12:26:01PM +0300, Dan Carpenter wrote:
The code isn't very beautiful and there are lots of details wrong like
the error
Adds loadable module support for Skein256, Skein512, and Skein1024
NOTE: skein1024_generic does not load, sending patch for feedback!
I don't understand why skein256_generic and skein512_generic load no
problem but skein1024_generic gives ERROR: Invalid argument from
modprobe.
Signed-off-by: Eric
-Original Message-
From: Thomas Gleixner [mailto:t...@linutronix.de]
Sent: Tuesday, October 21, 2014 2:28 AM
To: Thomas Shao
Cc: gre...@linuxfoundation.org; LKML; de...@linuxdriverproject.org;
o...@aepfle.de; a...@canonical.com; jasow...@redhat.com; KY Srinivasan;
John Stultz
-Original Message-
From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-
ow...@vger.kernel.org] On Behalf Of Thomas Gleixner
Sent: Tuesday, October 21, 2014 2:41 AM
To: Thomas Shao
Cc: gre...@linuxfoundation.org; LKML; de...@linuxdriverproject.org;
o...@aepfle.de;
On Mon, Oct 20, 2014 at 8:18 PM, Thomas Shao huis...@microsoft.com wrote:
-Original Message-
From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-
ow...@vger.kernel.org] On Behalf Of Thomas Gleixner
Sent: Tuesday, October 21, 2014 2:41 AM
To: Thomas Shao
Cc:
-Original Message-
From: John Stultz [mailto:john.stu...@linaro.org]
Sent: Tuesday, October 21, 2014 11:24 AM
To: Thomas Shao
Cc: Thomas Gleixner; gre...@linuxfoundation.org; LKML;
de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
jasow...@redhat.com; KY
Register with kernel poweroff handler instead of setting pm_power_off
directly. Register with default priority since we don't know any better.
Cc: Julian Andres Klode j...@jak-linux.org
Cc: Marc Dietrich marvi...@gmx.de
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Acked-by: Greg
On Tue, Oct 14, 2014 at 09:06:37PM -0400, Martin K. Petersen wrote:
Sitsofe == Sitsofe Wheeler sits...@gmail.com writes:
Sitsofe A previous patch attempted to add a quirk to workaround this
Sitsofe but the quirk was only enabled after the features had been
Sitsofe scanned for, wouldn't work
On Tue, Oct 14, 2014 at 09:08:28PM -0400, Martin K. Petersen wrote:
Sitsofe == Sitsofe Wheeler sits...@gmail.com writes:
Sitsofe Microsoft Hyper-V virtual disks currently only claim SPC-2
Sitsofe compliance causing the kernel skip checks for features such as
Sitsofe thin provisioning even
On Tue, Oct 21, 2014 at 03:18:58AM +, Thomas Shao wrote:
In some situation, the user is not able to enable guest VM to sync with
external
time source, like NTP. But the host is still synced with a trusted time
source.
In this case, host-guest time synchronization is useful.
It's
On Sun, Oct 12, 2014 at 01:21:01AM +, KY Srinivasan wrote:
-Original Message-
From: Jeff Leung [mailto:jle...@v10networks.ca]
Sent: Saturday, October 11, 2014 1:22 PM
On the current release of Windows (windows 10), we are advertising
SPC3 compliance.
We are ok with
-Original Message-
From: Jeff Epler [mailto:jep...@unpythonic.net]
Sent: Tuesday, October 21, 2014 12:02 PM
To: Thomas Shao
Cc: Thomas Gleixner; gre...@linuxfoundation.org; LKML;
de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
jasow...@redhat.com; KY Srinivasan;
Is it OK to replace a scsi_level of SCSI-2 with SCSI_SPC_3? Additionally is
it also OK to force
SCSI_SPC_3 on Hyper-V 2008?
I would patch the driver accordingly to force the SPC-3 flag.
For a Win2k8 host, I don't know what the side effects are, so it's safe to say
it's not a good idea to
This patch forces SPC-3 for Hyper-V disks on the VMBus. As Windows 10's
virtual SAS bus is SPC-3 compliant and there are no negative side effects
on forcing SPC-3 compliance for Win8 hosts, this patch enables SPC-3
compliance by forcing it on for hosts with versions later than Win8.
Forcing SPC-3
79 matches
Mail list logo
