Re: [PATCH 04/10] staging: unisys: fix all logical continuation virthba

On Mon, Oct 27, 2014 at 05:14:02PM -0400, Erik Arfvidson wrote: This patch fixes all logical continuations issues in virthba.c Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/virthba/virthba.c | 42 1 file changed, 21

Re: [PATCH] staging: skein: skein_api.c: removed space before ','

On Mon, Oct 27, 2014 at 11:17:02PM +0100, Mikael Svantesson wrote: Signed-off-by: Mikael Svantesson mik...@distopic.net The patch is corrupt (and in a totally weird way as well). Please read the first paragraph for Documentation/email-clients.txt. regards, dan carpenter

Re: [patch] Documentation/SubmittingPatches: Reported-by tags and permission

On Fri, 14 Feb 2014 12:30:01 +0300 Dan Carpenter dan.carpen...@oracle.com wrote: -If this patch fixes a problem reported by somebody else, consider adding a -Reported-by: tag to credit the reporter for their contribution. Please -note that this tag should not be added without the reporter's

[PATCH] staging: comedi: comedi_test: fix timer lock-up

Commit 240512474424 (staging: comedi: comedi_test: use comedi_handle_events()) resulted in the timer routine `waveform_ai_interrupt()` calling `comedi_handle_events()` instead of `comedi_events()`. That had the advantage of automatically stopping the acquisition on

[PATCH] staging: unisys: fix macro spacing in uisutils.h

Add some space between the macros in uisutils.h for readability. Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/include/uisutils.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/unisys/include/uisutils.h

Re: [patch] Documentation/SubmittingPatches: Reported-by tags and permission

On Tue, Oct 28, 2014 at 09:04:51AM -0400, Jonathan Corbet wrote: On Fri, 14 Feb 2014 12:30:01 +0300 Dan Carpenter dan.carpen...@oracle.com wrote: -If this patch fixes a problem reported by somebody else, consider adding a -Reported-by: tag to credit the reporter for their contribution.

[PATCH] staging: comedi: widen subdevice number argument in ioctl handlers

For the `COMEDI_LOCK`, `COMEDI_UNLOCK`, `COMEDI_CANCEL`, and `COMEDI_POLL` ioctls the third argument is a comedi subdevice number. This is passed as an `unsigned long`, but when it is passed down to the ioctl command-specific handler functions `do_lock_ioctl()`, `do_unlock_ioctl()`,

Re: [patch] Documentation/SubmittingPatches: Reported-by tags and permission

On Tue, 28 Oct 2014 12:58:27 -0400 Jason Cooper ja...@lakedaemon.net wrote: At the risk of upsetting the apple cart, I'd prefer we downplay anything that walks down the path of gamification (by focusing on credit). As best anyone has ever explained it to me, the Acked-by, Reviewed-by, etc

[PATCH] Staging: dgnc: fix macro coding style issue in digi.h

This is a patch to the digi.h file that fixes up the following error found by the checkpatch tool. ERROR: Macros with complex values should be enclosed in parentheses Signed-off-by: Cheng-Yi He chengyihetai...@gmail.com --- drivers/staging/dgnc/digi.h | 60

[PATCH RESEND v2 0/2] Staging: rts5208: rtsx_reset_chip style clean up

Clean up the code in rtsx_reset_chip function defining two new helper functions rtsx_reset_aspm and rtsx_enable_pcie_intr. Specifically, the following checkpatch warnings are corrected: * PARENTHESIS_ALIGNMENT at rows 295, 313 This patch is inspired by the following post on LKML regarding another

[PATCH RESEND v2 1/2] Staging: rts5208: helper function to manage aspm during reset

Define the helper function rtsx_reset_aspm to shorten the rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings. Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com Reviewed-by: Dan Carpenter dan.carpe...@oracle.com --- drivers/staging/rts5208/rtsx_chip.c | 70

[PATCH RESEND v2 2/2] Staging: rts5208: helper function to enable interrupts during reset

Define the helper function rtsx_enable_pcie_intr to shorten the rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings. Signed-off-by: Fabio Falzoi fabio.falzo...@gmail.com Reviewed-by: Dan Carpenter dan.carpe...@oracle.com --- drivers/staging/rts5208/rtsx_chip.c | 95

[PATCH] staging: lustre: Fix coding style. Switch and case at the same indent.

Fix a style issue reported by checkpatch.pl for the Eudyptula challenge. Signed-off-by: Evaldas Palaima evaldas.pala...@gmail.com --- drivers/staging/lustre/lustre/libcfs/fail.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

Re: [PATCH] staging: skein: skein_api.c: removed space before ','

On 2014-10-28 07:50, Dan Carpenter wrote: On Mon, Oct 27, 2014 at 11:17:02PM +0100, Mikael Svantesson wrote: Signed-off-by: Mikael Svantesson mik...@distopic.net The patch is corrupt (and in a totally weird way as well). Please read the first paragraph for Documentation/email-clients.txt.

[PATCH 04/10] staging: unisys: fix all logical continuation virthba

This patch fixes all logical continuations issues in virthba.c v2: fixed spacing around bitwise operator suggested by dan carpenter Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/virthba/virthba.c | 44 1 file changed, 22

[PATCH 05/10] staging: unisys: added spinlock comments visorchannel_funcs

This patch adds comment documentation to visorchannel_tag struct Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

[PATCH 03/10] staging: unisys: virthba fix all alingment issues

this patch fixes all aligment issues in virthba.c Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/virthba/virthba.c | 82 1 file changed, 42 insertions(+), 40 deletions(-) diff --git a/drivers/staging/unisys/virthba/virthba.c

[PATCH 07/10] staging: unisys: fixed logical continuation visorchannel_funcs

this patch fixes a logical continuation check in visorchannel Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 10/10] staging: unisys: fixed braces check in visorchannel_funcs

this patch adds braces to an else statement to remove check in checkpatch.pl for visorchannel_funcs.c Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 09/10] staging: unisys: remove unnecessary blank line in visorchannel_funcs

this patch removes unnecessary blank line in visorchannel_funcs Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/unisys/visorchannel/visorchannel_funcs.c

[PATCH 08/10] staging: unisys: fixed aligment in visorchannel_funcs

this patch fixes aligment for visorchanne_funcs Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 02/10] staging: unisys: virthba fix all spaces after cast

This patch fixes all spaces after cast for virthba Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/virthba/virthba.c | 130 +++ 1 file changed, 65 insertions(+), 65 deletions(-) diff --git a/drivers/staging/unisys/virthba/virthba.c

[PATCH 06/10] staging: unisys: remove all unnecessary space after cast visorchannel_funcs

This patch removes all unnecessary spaces after cast for visorchannel_funcs Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- .../unisys/visorchannel/visorchannel_funcs.c | 25 +++--- 1 file changed, 13 insertions(+), 12 deletions(-) diff --git

[PATCH 01/10] staging: unisys: fix blank lines virthba

This patch removes unnecessary blanks lines and adds necessary blank lines in virthba. Signed-off-by: Erik Arfvidson erik.arfvid...@unisys.com --- drivers/staging/unisys/virthba/virthba.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

[PATCH v2 1/1] staging: skein: Removes skein_debug include

Removes skein_debug.h include since skein_debug.h is nonexistent. Removes unneeded debug empty macro defines and their uses. Signed-off-by: Eric Rost eric.r...@mybabylon.net --- drivers/staging/skein/skein_base.c | 18 -- drivers/staging/skein/skein_base.h | 17

Re: [PATCH 04/10] staging: unisys: fix all logical continuation virthba

On Tue, Oct 28, 2014 at 06:42:40PM -0400, Erik Arfvidson wrote: This patch fixes all logical continuations issues in virthba.c v2: fixed spacing around bitwise operator suggested by dan carpenter I said was ok with this stuff to be fixed in a later patch. It slows you down to redo everything

Re: [PATCH 1/3] staging: ion: shrink page-pool by page unit

2014-10-28 오전 9:36에 Gioh Kim 이(가) 쓴 글: This patch shrink page-pool by page unit. Shrinker usually get the pool size with the pool-scanner and pass the size to the pool-counter to shrink entire pool. But the pool-scanner is working in block unit. and pool-counter page unit. So it is

[PATCH 00/02] staging:lustre:lnet:selftest: fix sparse warnings

Patch fix simple sparse warnings: make functions static and remove unused code. I'm doing only little testing: module was loaded properly, output of lst without real server is the same as before. Anton Saraev (2): staging:lustre:lnet:selftest: fix sparse warnings staging:lustre:lnet:selftest:

[PATCH 01/02] staging:lustre:lnet:selftest: fix sparse warnings

Fix sparse warnings: symbol X was not declared. Should it be static? Some functions used only in files where they are declared. They can be static. Signed-off-by: Anton Saraev antonysar...@gmail.com --- drivers/staging/lustre/lnet/selftest/conctl.c| 34

[PATCH 02/02] staging:lustre:lnet:selftest: remove unused function

Function lnet_selftest_structure_assertion is never used and can be removed. Signed-off-by: Anton Saraev antonysar...@gmail.com --- drivers/staging/lustre/lnet/selftest/module.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/lustre/lnet/selftest/module.c

[RFC] stating: ion: use hot page first in pool

Hello, I found that ion insert freed-page at the tail of list and extract at the head. I think it is good for cache to use the most recently used page but these pages in pool are not cached memory. So I'm not sure using hot page is better or not in this case. What do you think about using hot

Re: [PATCH v2] staging: skein: skein_api.c: removed space before ','

On Tue, Oct 28, 2014 at 09:07:00PM +0100, Mikael Svantesson wrote: Signed-off-by: Mikael Svantesson mik...@distopic.net still the same problem. ERROR: patch seems to be corrupt (line wrapped?) --- drivers/staging/skein/skein_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCHv2 0/3] staging: ion: enable pool shrinking in page unit

Hello, Current pool shrinking is not page unit, block unit. But shrinker returns the pool size in page unit, so it is confused. And there is no way to control pool size and shrink pool directly. I have 3 patches like followings. 1. Patch 1/3: make pool be shrinked by page unit This patch

[PATCHv2 3/3] staging: ion: debugfs to shrink pool

This patch enables debugfs files /sys/kernel/debug/ion/heaps/system_shrink ,which was commented out, to shrink pool or get pool size Reading the file returns pool size and writing occurs to shrink pool. Signed-off-by: Gioh Kim gioh@lge.com --- drivers/staging/android/ion/ion.c |

[PATCHv2 1/3] staging: ion: shrink page-pool by page unit

This patch shrink page-pool by page unit. Shrinker usually get the pool size with the pool-scanner and pass the size to the pool-counter to shrink entire pool. But the pool-scanner is working in block unit. and pool-counter page unit. So it is confused. Change-Id: