CFS_HOP() is a terrible macro. It chops the struct member name in half
so that it's not possible to use tools like grep or to search for how
a function pointer is used.
I removed a couple calls to:
LASSERT(CFS_HOP(hs, put_locked) != NULL);
because they isn't a need for them. Anyway der
From: Micky Ching
To enable/disable ASPM we should find LINK CONTROL register
in PCI config space. All old chip use 0x80 address, but new
chip may use another address, so we using pci_find_capability()
to get LINK CONTROL address.
rtsx_gops.c was removed, we consider to put some common operation
From: Micky Ching
PETXCFG is defined at 0xFF03, the old 0xFE49 not used any more.
Signed-off-by: Micky Ching
Acked-by: Lee Jones
---
drivers/mfd/rts5227.c| 6 ++
drivers/mfd/rts5249.c| 6 ++
include/linux/mfd/rtsx_pci.h | 2 +-
3 files changed, 5 insertions(+), 9 delet
From: Micky Ching
Re-format coding-style, using uniform SPC after "#define" keyword
instead of mixing using TAB and SPC.
Signed-off-by: Micky Ching
Acked-by: Lee Jones
---
include/linux/mfd/rtsx_pci.h | 254 +--
1 file changed, 127 insertions(+), 127 de
From: Micky Ching
add support for new chip rts525A.
Signed-off-by: Micky Ching
---
drivers/mfd/rts5249.c| 104 ++-
drivers/mfd/rtsx_pcr.c | 13 --
drivers/mfd/rtsx_pcr.h | 1 +
include/linux/mfd/rtsx_pci.h | 15 +++
4 file
From: Micky Ching
add support for new chip rts524A.
Signed-off-by: Micky Ching
---
drivers/mfd/rts5249.c| 186 ---
drivers/mfd/rtsx_pcr.c | 25 +-
drivers/mfd/rtsx_pcr.h | 7 ++
include/linux/mfd/rtsx_pci.h | 125 ++
From: Micky Ching
resend:
- add lee jones ack for some patch.
v2:
- remove debug info when access failed.
- using macro list for phy register init.
- rename function for multi chip prefix with rtsx_base_
- save pcie_cap offset when init chip, not calling pci_find_capacity()
every time.
- add pc
From: Micky Ching
update card drive settings, This setting can be used for rts5249
rts524A and rts525A.
Signed-off-by: Micky Ching
Acked-by: Lee Jones
---
drivers/mfd/rts5249.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/mfd/rts5249.c b/drivers/mfd
From: Micky Ching
pcr_dbg is a wrapper of dev_dbg, which can save some code,
and help to enable/disable debug message static.
Signed-off-by: Micky Ching
Acked-by: Lee Jones
---
drivers/mfd/rtl8411.c | 11 +--
drivers/mfd/rts5209.c | 4 ++--
drivers/mfd/rts5227.c | 4 ++--
drivers
From: Micky Ching
It is more readable to place register address and values define
togather. The values define add two leading space indicate belong
to the register address defined above.
Signed-off-by: Micky Ching
Acked-by: Lee Jones
---
include/linux/mfd/rtsx_pci.h | 836 +++-
From: Micky Ching
update phy register value and using direct value instead of macros.
It is much easier to debug using constant value than a lot of macros.
We usually need compare the value directly to check the configure.
Signed-off-by: Micky Ching
---
drivers/mfd/rts5249.c| 55 +
Have you reworked all of these patches?
If not, why haven't my Acks been carried forward?
Please [RESEND] with the Acks applied.
> From: Micky Ching
>
> v2:
> - remove debug info when access failed.
> - using macro list for phy register init.
> - rename function for multi chip prefix with rtsx
From: Micky Ching
add support for new chip rts524A.
Signed-off-by: Micky Ching
---
drivers/mfd/rts5249.c| 186 ---
drivers/mfd/rtsx_pcr.c | 25 +-
drivers/mfd/rtsx_pcr.h | 7 ++
include/linux/mfd/rtsx_pci.h | 125 ++
From: Micky Ching
pcr_dbg is a wrapper of dev_dbg, which can save some code,
and help to enable/disable debug message static.
Signed-off-by: Micky Ching
---
drivers/mfd/rtl8411.c | 11 +--
drivers/mfd/rts5209.c | 4 ++--
drivers/mfd/rts5227.c | 4 ++--
drivers/mfd/rts5229.c | 4
From: Micky Ching
v2:
- remove debug info when access failed.
- using macro list for phy register init.
- rename function for multi chip prefix with rtsx_base_
- save pcie_cap offset when init chip, not calling pci_find_capacity()
every time.
- add pcr->ops: write_phy/read_phy for special chip.
From: Micky Ching
update card drive settings, This setting can be used for rts5249
rts524A and rts525A.
Signed-off-by: Micky Ching
---
drivers/mfd/rts5249.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/mfd/rts5249.c b/drivers/mfd/rts5249.c
index 225a
From: Micky Ching
To enable/disable ASPM we should find LINK CONTROL register
in PCI config space. All old chip use 0x80 address, but new
chip may use another address, so we using pci_find_capability()
to get LINK CONTROL address.
rtsx_gops.c was removed, we consider to put some common operation
From: Micky Ching
It is more readable to place register address and values define
togather. The values define add two leading space indicate belong
to the register address defined above.
Signed-off-by: Micky Ching
---
include/linux/mfd/rtsx_pci.h | 836 +++--
From: Micky Ching
add support for new chip rts525A.
Signed-off-by: Micky Ching
---
drivers/mfd/rts5249.c| 104 ++-
drivers/mfd/rtsx_pcr.c | 13 --
drivers/mfd/rtsx_pcr.h | 1 +
include/linux/mfd/rtsx_pci.h | 15 +++
4 file
From: Micky Ching
update phy register value and using direct value instead of macros.
It is much easier to debug using constant value than a lot of macros.
We usually need compare the value directly to check the configure.
Signed-off-by: Micky Ching
---
drivers/mfd/rts5249.c| 55 +
From: Micky Ching
PETXCFG is defined at 0xFF03, the old 0xFE49 not used any more.
Signed-off-by: Micky Ching
---
drivers/mfd/rts5227.c| 6 ++
drivers/mfd/rts5249.c| 6 ++
include/linux/mfd/rtsx_pci.h | 2 +-
3 files changed, 5 insertions(+), 9 deletions(-)
diff --git a
From: Micky Ching
Re-format coding-style, using uniform SPC after "#define" keyword
instead of mixing using TAB and SPC.
Signed-off-by: Micky Ching
---
include/linux/mfd/rtsx_pci.h | 254 +--
1 file changed, 127 insertions(+), 127 deletions(-)
diff --gi
mp_query_drv_var() was only being used by
oid_rt_pro_query_dr_variable_hdl() but after commit
mp_query_drv_var() became
unused. so it is safe to remove it.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/rtl8712/rtl871x_mp_ioctl.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/dri
On Wed, Jan 21, 2015 at 06:53:31PM +0300, Dan Carpenter wrote:
> Generally "delete code" patches are easy to review. But sometimes you
> have to change formatting and remove variables and curly braces.
>
> $ grep LOG drivers/staging/unisys/ -R | wc -l
> 415
>
> There isn't a firm rule on way a p
RE: RELEASE/TRANSFER NOTICE OF YOUR APPROVED FUNDS ($800,000.00USD)
COMPENSATION FUND FROM UNITED NATION, WORLD BANK,EUROPEAN UNION AND
AFRICA UNION. YOU ARE TO CONTACT THE FUNDS TRANSFER MANAGER MR ERIC MOORE
FOR MORE INFORMATION'S ON HOW YOU CAN RECEIVED YOUR FUND AND FORWARD TO
HIM YOUR
FULL DET
the title should be 5208.
On 01/19/2015 03:25 PM, Nicholas Mc Guire wrote:
> This is only an API consolidation and should make things more readable
>
> Signed-off-by: Nicholas Mc Guire
> ---
>
> Converting milliseconds to jiffies by val * HZ / 1000 is technically
> not wrong but msecs_to_jiffies(
The data[0] parameter to (*insn_config) functions is the "configuration
instruction"
that should be handled. These are defined by the enum configuration_ids in
comedi.h.
This driver is currently checking the data[0] value to be INSN_CONFIG_RESET or
GPCT_RESET in order to reset a counter channel.
Tidy up this (*insn_config) function to follow the normal format in
comedi drivers.
INSN_CONFIG_RESET instructions do not have any extra parameters (insn->n is
always 1) so the for loop used to write the packet doesn't make any sense.
Remove it and just write the single packet.
Signed-off-by: H H
A couple cleanup patches for the vmk80xx driver.
H Hartley Sweeten (2):
staging: comedi: vmk80xx: GPCT_RESET is not an (*insn_config) instruction
staging: comedi: vmk80xx: tidy up vmk80xx_cnt_insn_config()
drivers/staging/comedi/drivers/vmk80xx.c | 46 ++--
1 file
The labpc_free_dma_chan() function validates the private data. Remove the
unnecessary validation in labpc_datach().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
d
Use the DIV_ROUND_CLOSEST macro to clarify the (((x) + ((divisor) / 2)) /
(divisor))
calculations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc_common.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --
The ni_labpc_common module is used by the ni_labpc, ni_labpc_pci, and
ni_labpc_cs
drivers to provide the common code support. Those drivers currently all call
comedi_alloc_devpriv() to allocate the private data before calling the common
attach function.
For aesthetics, move the private data alloc
For aesthetics, use the helper functions to check the min/max divisor values.
Remove the const int local variables and open code the values.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc_common.c | 25
This driver includes a number of unnecessary headers. Remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc_cs.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi/drive
A couple misc patches for the ni_labpc drivers.
H Hartley Sweeten (6):
staging: comedi: ni_labpc_common: move comedi_alloc_devpriv() to common code
staging: comedi: ni_labpc_cs: remove unnecessary includes
staging: comedi: ni_labpc: remove unnecessary private data validation
staging: comed
Use the DIV_ROUND_UP macro to clarify the (((n) + (d) - 1) / (d)) calculations.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc_common.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/stagin
bsd and sysv use different typedefs for unsigned types.
These are in types.h but not in checkpatch, so add them
to checkpatch's ability to know types.
This can avoid false positives for code like:
void foo(void)
{
int x;
uint y;
[...];
}
where checkpatch incorrectly emi
Hi Jason,
> On Jan 21, 2015, at 22:27 , Jason Gunthorpe
> wrote:
>
> On Wed, Jan 21, 2015 at 06:33:12PM +0200, Pantelis Antoniou wrote:
>> Hi Alan,
>>
>>> On Jan 21, 2015, at 18:01 , One Thousand Gnomes
>>> wrote:
>>>
>>> On Thu, 15 Jan 2015 22:54:46 +0200
>>> Pantelis Antoniou wrote:
>>>
On Wed, Jan 21, 2015 at 06:33:12PM +0200, Pantelis Antoniou wrote:
> Hi Alan,
>
> > On Jan 21, 2015, at 18:01 , One Thousand Gnomes
> > wrote:
> >
> > On Thu, 15 Jan 2015 22:54:46 +0200
> > Pantelis Antoniou wrote:
> >
> >> Hi Alan,
> >>
> >>> On Jan 15, 2015, at 22:45 , One Thousand Gnomes
On 20/01/15 09:27, Asaf Vertz wrote:
> Fixed the following warnings (reported by cppcheck):
> [drivers/staging/iio/light/tsl2x7x_core.c:1150]: (warning) %d in format
> string (no. 1)
> requires 'int' but the argument type is 'unsigned int'.
> [drivers/staging/iio/light/tsl2x7x_core.c:1150]: (warni
We need to destroy hv_vmbus_con on module shutdown, otherwise the following
crash is sometimes observed:
[ 76.569845] hv_vmbus: Hyper-V Host Build:9600-6.3-17-0.17039; Vmbus
version:3.0
[ 82.598859] BUG: unable to handle kernel paging request at a0003480
[ 82.599287] IP: [] 0xff
It is possible (since 93e5bd06a953: "Drivers: hv: Make the vmbus driver
unloadable") to unload hv_vmbus driver if no other devices are connected.
1aec169673d7: "x86: Hyperv: Cleanup the irq mess" fixed doulble interrupt
gate setup. However, if we try to unload hv_vmbus and then load it back
crashes
On driver shutdown device_obj is being freed twice:
1) In vmbus_free_channels()
2) vmbus_device_release() (which is being triggered by device_unregister() in
vmbus_device_unregister().
This double kfree leads to the following sporadic crash on driver unload:
[ 23.469876] general protection fa
In case we do request_resource() in vmbus_acpi_add() we need to tear it down
to be able to load the driver again. Otherwise the following crash in oberved
when hv_vmbus unload/load sequence is performed on Generation2 instance:
[ 38.165701] BUG: unable to handle kernel paging request at
On Sat, Jan 17, 2015 at 03:29:01PM -0800, Greg KH wrote:
> On Sat, Dec 13, 2014 at 03:58:46PM +0100, Loïc Pefferkorn wrote:
> > > >>> Don't hide "implementation of locks" in functions like this, it only
> > > >>> causes problems. This code has layers of layers of layers of
> > > >>> abstractions d
On Wed, 2015-01-21 at 04:03 -0500, Devendra Naga wrote:
> The 1st patch (replace kthread_create..) replace the
> kthread_create and wake_up_process with a call to
> kthread_run.
>
> The 2nd patch changes the library API uisthread_start
> and uisthread_stop to use the kthread API.
>
> The 3rd patc
On 21/01/15 16:36, Hartley Sweeten wrote:
On Wednesday, January 21, 2015 4:00 AM, Ian Abbott wrote:
On 20/01/15 19:00, H Hartley Sweeten wrote:
Modify the sample data returned by the async command to include the current
state of the digital inputs. Otherwise the command needs to be canceled in
On Wed, 2015-01-21 at 16:41 +0200, Lin Kassem wrote:
> This patch fixes the following checkpatch.pl warning:
> fix Missing a blank line after declarations
False positives. Unnecessary changes.
> diff --git a/drivers/staging/rtl8712/drv_types.h
> b/drivers/staging/rtl8712/drv_types.h
[]
> @@ -12
On Wednesday, January 21, 2015 4:00 AM, Ian Abbott wrote:
> On 20/01/15 19:00, H Hartley Sweeten wrote:
>> Modify the sample data returned by the async command to include the current
>> state of the digital inputs. Otherwise the command needs to be canceled in
>> order for the user to do an (*insn_
Hi Alan,
> On Jan 21, 2015, at 18:01 , One Thousand Gnomes
> wrote:
>
> On Thu, 15 Jan 2015 22:54:46 +0200
> Pantelis Antoniou wrote:
>
>> Hi Alan,
>>
>>> On Jan 15, 2015, at 22:45 , One Thousand Gnomes
>>> wrote:
>>>
>>> On Thu, 15 Jan 2015 11:47:26 -0700
>>> Jason Gunthorpe wrote:
On Thu, 15 Jan 2015 22:54:46 +0200
Pantelis Antoniou wrote:
> Hi Alan,
>
> > On Jan 15, 2015, at 22:45 , One Thousand Gnomes
> > wrote:
> >
> > On Thu, 15 Jan 2015 11:47:26 -0700
> > Jason Gunthorpe wrote:
> >> It is a novel idea, my concern would be that embedding the FPGA in the
> >> DT ma
On Wed, 2015-01-21 at 18:44 +0200, Lin Kassem wrote:
> This patch fixes the following checkpatch.pl warning:
> fix Prefer ether_addr_copy() over memcpy()
> if the Ethernet addresses are __aligned(2)
>
> Pahole showed that the 2 structs are aligned to u16
[]
> diff --git a/drivers/staging/vt6656/r
Generally "delete code" patches are easy to review. But sometimes you
have to change formatting and remove variables and curly braces.
$ grep LOG drivers/staging/unisys/ -R | wc -l
415
There isn't a firm rule on way a patch is just too big and annoying to
review. Probably break it up into:
[pa
Kindly open the attachment and contact him for your bank darft. Contact Person
: Dr.Jim Ovia.
Bank Name : Zenith Bank Plc
Email: zenithbank-ng-...@cd2.com
Personal Phone: +234-814-820-2663
DRAFT.rtf
Description: RTF file
___
devel mailing list
de...@
This patch fixes the following checkpatch.pl warning:
fix Prefer ether_addr_copy() over memcpy()
if the Ethernet addresses are __aligned(2)
Pahole showed that the 2 structs are aligned to u16
struct ieee80211_hdr {
__le16 frame_control;/* 0 2 */
On Fri, 2015-01-09 at 17:40 -0800, Greg KH wrote:
> On Fri, Dec 05, 2014 at 05:09:30PM -0500, Benjamin Romer wrote:
> > Get rid of LOGWRN() and all related macros, and call pr_warn() directly
> > instead.
>
> Side note, are you setting pr_fmt() properly so that everything is
> "unified" with thes
On 2015-01-21 at 23:56:06 +0100, Ahmad Hassan wrote:
> Removed ERR macro since it is not used anymore in the emxx_udc.c file.
>
> Signed-off-by: Ahmad Hassan
> ---
> drivers/staging/emxx_udc/emxx_udc.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.h
On 14 January 2015 at 04:09, wrote:
> From: Micky Ching
>
> Add check before sending request can make request return faster.
> - finish request if no card exist
> This can make request finish faster, especial for some sdio card,
> when card removed, there still a lot of command pending,
>
Ahmad,
On Wed, Jan 21, 2015 at 01:55:11PM -0900, Ahmad Hassan wrote:
[...]
> if (udc == NULL) {
> - ERR("%s udc == NULL\n", __func__);
> + dev_err(udc->dev,"%s udc == NULL\n", __func__);
^
Always check your patches with checkpatch.pl before
This patch fixes the following checkpatch.pl warning:
fix Missing a blank line after declarations
Signed-off-by: Lin Kassem
---
drivers/staging/rtl8712/drv_types.h |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/rtl8712/drv_types.h
b/drivers/staging/rtl8712/drv_types.h
On 20/01/15 21:52, H Hartley Sweeten wrote:
Following is the initial cleanup of the comedi adv_pci1710 driver.
H Hartley Sweeten (28):
staging: comedi: adv_pci1710: change boardinfo 'n_counter' to 'has_counter'
staging: comedi: adv_pci1710: simplify digital input and output boardinfo
st
Removed ERR macro since it is not used anymore in the emxx_udc.c file.
Signed-off-by: Ahmad Hassan
---
drivers/staging/emxx_udc/emxx_udc.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.h
b/drivers/staging/emxx_udc/emxx_udc.h
index ee1b80d..0758cd5 100644
-
Replaced all occurences of ERR with dev_err.
The device passed to dev_err is udc->dev.
Signed-off-by: Ahmad Hassan
---
drivers/staging/emxx_udc/emxx_udc.c | 80 ++---
1 file changed, 40 insertions(+), 40 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc
This patch set removes the macro ERR from emxx_udc.h and accordingly
emxx_udc.c occurrences of ERR changes to dev_err
Ahmad Hassan (2):
staging: emxx_udc: Replace ERR by dev_err
staging: emxx_udc: remove macro ERR
drivers/staging/emxx_udc/emxx_udc.c | 80 ++---
On 20/01/15 19:05, H Hartley Sweeten wrote:
Following are a couple random comedi cleanup patches that I have had
hanging around.
H Hartley Sweeten (6):
staging: comedi: comedidev.h: remove unused "minor bits" information
staging: comedi: comedidev.h: remove unused "polling" function protot
This patch fixes the following checkpatch.pl warning:
fix Prefer ether_addr_copy() over memcpy()
if the Ethernet addresses are __aligned(2)
Pahole showed that the 2 structs are aligned to u16
struct vnt_mic_hdr {
u8 id; /* 0 1 */
Add missing static keyword to function reset().
This was detected by the kbuild test robot.
Signed-off-by: Noralf Trønnes
---
drivers/staging/fbtft/fb_agm1264k-fl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_agm1264k-fl.c
b/drivers/staging/fbtft
On 20/01/15 19:01, H Hartley Sweeten wrote:
This driver is a mess. It violates the comedi API so much that I doubt
anything actually works.
Drop the addi-data/hwdrv_apci1500.c file and rewrite the subdevice support
functions.
This board has 16 digital inputs (subdevice 0) and 16 digital outputs
On 20/01/15 19:00, H Hartley Sweeten wrote:
Modify the sample data returned by the async command to include the current
state of the digital inputs. Otherwise the command needs to be canceled in
order for the user to do an (*insn_bits) operation to check the digital
inputs.
Signed-off-by: H Hart
On Wed, Jan 21, 2015 at 12:46:59PM +0200, menna_tarek wrote:
> This patch fixes the following checkpatch.pl warning:
> WARNING: line over 80 characters
>
> Signed-off-by: menna_tarek
These are supposed to be your actual name that you use to sign legal
documents with correct capitalization etc.
This patch fixes the following checkpatch.pl warning:
WARNING: line over 80 characters
Signed-off-by: menna_tarek
---
drivers/staging/dgnc/dgnc_tty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index f81a37
This patch fixes the following checkpatch.pl error:
fix that open brace { should be on the previous line
Signed-off-by: MariamMohamedFawzy
---
drivers/staging/vt6655/card.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6
The code does the checks on should_stop variable in the kernel
threads. The uisthread_stop function sets the should_stop and calls
KILL (eventually kill_pid) to stop the thread.
The checking of should_stop variable can be replaced to a call to
kthread_should_stop function and the setting of the sh
kthread_run calls kthread_create and if the thread is created
it then calls wake_up_process on the corresponding returned
task struct. So the code can be simplified by calling just
kthread_run.
Cc: Ken Cox
Cc: Benjamin Romer
Signed-off-by: Devendra Naga
---
drivers/staging/unisys/uislib/uisthr
convert the users of should_stop into using kthread_should_stop API.
Cc: Ken Cox
Cc: Benjamin Romer
Signed-off-by: Devendra Naga
---
drivers/staging/unisys/uislib/uislib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/uislib/uislib.c
b/drivers/
The 1st patch (replace kthread_create..) replace the
kthread_create and wake_up_process with a call to
kthread_run.
The 2nd patch changes the library API uisthread_start
and uisthread_stop to use the kthread API.
The 3rd patch and 4th patch checks on kthread_should_stop
instead of checking should
convert the users of should_stop variable into kthread_should_stop() API.
Cc: Ken Cox
Cc: Benjamin Romer
Signed-off-by: Devendra Naga
---
drivers/staging/unisys/virthba/virthba.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/virthba/virthba.c
b
remove the should_stop variable and KILL API as they are
no longer required
Cc: Ken Cox
Cc: Benjamin Romer
Signed-off-by: Devendra Naga
---
drivers/staging/unisys/include/uisthread.h | 1 -
drivers/staging/unisys/uislib/uisthread.c | 2 --
2 files changed, 3 deletions(-)
diff --git a/drivers
Oops, I have forgotten the RFC before the patches from 1 to 5 also i
have missed two email addresses (i have added them now). I will resend
the whole series again with RFC tag before each PATCH and also proper
cc's.
Sorry
On Wed, Jan 21, 2015 at 3:55 AM, Devendra Naga wrote:
> The 1st patch (rep
remove the should_stop variable and KILL API as they are
no longer required
Cc: Ken Cox
Cc: Benjamin Romer
Signed-off-by: Devendra Naga
---
drivers/staging/unisys/include/uisthread.h | 1 -
drivers/staging/unisys/uislib/uisthread.c | 2 --
2 files changed, 3 deletions(-)
diff --git a/drivers
convert the users of should_stop into using kthread_should_stop API.
Cc: Ken Cox
Cc: Benjamin Romer
Signed-off-by: Devendra Naga
---
drivers/staging/unisys/uislib/uislib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/uislib/uislib.c
b/drivers/
The 1st patch (replace kthread_create..) replace the
kthread_create and wake_up_process with a call to
kthread_run.
The 2nd patch changes the library API uisthread_start
and uisthread_stop to use the kthread API.
The 3rd patch and 4th patch checks on kthread_should_stop
instead of checking should
The code does the checks on should_stop variable in the kernel
threads. The uisthread_stop function sets the should_stop and calls
KILL (eventually kill_pid) to stop the thread.
The checking of should_stop variable can be replaced to a call to
kthread_should_stop function and the setting of the sh
kthread_run calls kthread_create and if the thread is created
it then calls wake_up_process on the corresponding returned
task struct. So the code can be simplified by calling just
kthread_run.
Cc: Ken Cox
Cc: Benjamin Romer
Signed-off-by: Devendra Naga
---
drivers/staging/unisys/uislib/uisthr
convert the users of should_stop variable into kthread_should_stop() API.
Cc: Ken Cox
Cc: Benjamin Romer
Signed-off-by: Devendra Naga
---
drivers/staging/unisys/virthba/virthba.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/virthba/virthba.c
b
85 matches
Mail list logo
