On Fri, Jan 30, 2015 at 11:15:36PM -0500, Derrick Greenspan wrote:
> + }
> + struct vnt_cts *buf = &head->cts_g;
This declaration adds a GCC warning.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.li
This patch fixes the checkpatch.pl warning:
WARNING: else is not generally useful after a break or return
559: FILE: drivers/staging/vt6656/rxtx.c:559:
return vnt_rxtx_datahead_g_fb(tx_context, &buf->data_head);
} else {
Signed-off-by: Derrick Greenspan
---
Changes in v2:
- Hopefully fixed whit
This patch fixes the checkpatch.pl warning:
WARNING: else is not generally useful after a break or return
559: FILE: drivers/staging/vt6656/rxtx.c:559:
return vnt_rxtx_datahead_g_fb(tx_context, &buf->data_head);
} else {
Signed-off-by: Derrick Greenspan
---
drivers/staging/vt6656/rxtx.c | 3 +--
On Fri, Jan 30, 2015 at 10:43:19PM -0500, Derrick Greenspan wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: else is not generally useful after a break or return
> 559: FILE: drivers/staging/vt6656/rxtx.c:559:
> return vnt_rxtx_datahead_g_fb(tx_context, &buf->data_head);
> } else
This patch modifies the seq_printf statements in
drivers/staging/lustre/lustre/osc/lproc_osc.c file.
It changes it to seq_puts and seq_putc wherever applicable.
Signed-off-by: Heba Aamer
---
v2: changing %% to %
drivers/staging/lustre/lustre/osc/lproc_osc.c | 20 ++--
1 file c
From: Oleg Drokin
lustre_update.h containts various server-side structures that are
not really relevant for the client.
Also remove the only user of this file that does not actually need it.
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/lustre_update.h | 189 ---
The following changes since commit ec6f34e5b552fb0a52e6aae1a5afbbb1605cc6cc:
Linux 3.19-rc5 (2015-01-18 18:02:20 +1200)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-3.19-rc7
for you to fetch changes up to 41c9e95d641
On Fri, 2015-01-30 at 08:09 -0500, valdis.kletni...@vt.edu wrote:
> On Fri, 30 Jan 2015 16:00:02 +0300, Dan Carpenter said:
>
> > > > - if (ir == NULL) {
> > > > - dev_err(ir->l.dev, "close: no private_data attached to
> > > > the file
> !\n");
> > >
commit be4aa8157c981a8bb9
This function is an awkward helper for nbu2ss_drv_ep_init(). Most of
its logic is devoted to determining if the current endpoint is ep0,
something the caller can easily do in a single line. And there is not
a lot going on beyond that.
Move this logic up into nbu2ss_drv_ep_init(). The result is
On Fri, Jan 30, 2015 at 5:30 PM, Chris Rorvick wrote:
> +
> + ep->ep.maxpacket = (i == 0 ? EP0_PACKETSIZE : EP0_PACKETSIZE);
> +
Damn. I looked this over twice before sending this and still only
noticed this stupid typo after sending it. Will send a v2 shortly.
Sorry for the nois
This function is an awkward helper for nbu2ss_drv_ep_init(). Most of
its logic is devoted to determining if the current endpoint is ep0,
something the caller can easily do in a single line. And there is not
a lot going on beyond that.
Move this logic up into nbu2ss_drv_ep_init(). The result is
On Fri, Jan 30, 2015 at 11:35 AM, Rickard Strandqvist
wrote:
> 2015-01-30 15:20 GMT+01:00 Dan Carpenter :
>> Yes. Please send that as a patch which can be applied.
>>
>> regards,
>> dan carpenter
>>
>
>
> Hi
>
> Okay, I'll do it this weekend.
> Or do you do it Chris?
I'll send out a patch removi
On Fri, Jan 30, 2015 at 12:25:53PM -0800, Greg Kroah-Hartman wrote:
> On Fri, Jan 30, 2015 at 11:18:31PM +0300, Dan Carpenter wrote:
> > Richard, asked some questions out of band.
> >
> > I like these patches where they can remove the whole line. I don't like
> > them where they leave stray, unne
On Fri, Jan 30, 2015 at 11:18:31PM +0300, Dan Carpenter wrote:
> Richard, asked some questions out of band.
>
> I like these patches where they can remove the whole line. I don't like
> them where they leave stray, unneeded function calls. Or if we know
> that we need the function calls then I l
Richard, asked some questions out of band.
I like these patches where they can remove the whole line. I don't like
them where they leave stray, unneeded function calls. Or if we know
that we need the function calls then I like those.
Also when it comes to the point where we move this code out o
2015-01-30 15:20 GMT+01:00 Dan Carpenter :
> Yes. Please send that as a patch which can be applied.
>
> regards,
> dan carpenter
>
Hi
Okay, I'll do it this weekend.
Or do you do it Chris?
Kind regards
Rickard Strandqvist
___
devel mailing list
de...@
Dexuan Cui writes:
>> -Original Message-
>> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
>> Sent: Thursday, January 29, 2015 21:31 PM
>> To: Dexuan Cui
>> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev-
>> de...@linuxdriverproject.org; o...@aepfle.de; a...@
2015-01-30 14:09 GMT+01:00 :
> On Fri, 30 Jan 2015 16:00:02 +0300, Dan Carpenter said:
>
>> > > - if (ir == NULL) {
>> > > - dev_err(ir->l.dev, "close: no private_data attached to the file
> !\n");
>> >
>> > Yes, the dev_err() call is an obvious thinko.
>> >
>> > However, I'm not sure whet
On Friday, January 30, 2015 2:57 AM, Ian Abbott wrote:
> "comedidev.h" includes PCMCIA-specific stuff that gets included by all
> comedi drivers including non-PCMCIA ones. Separate it out into its own
> header "comedi_pcmcia.h". Make the new header include
> , and "comedidev.h" so that comedi PC
2015-01-30 13:59 GMT+01:00 Peter Hurley :
> On 01/30/2015 07:39 AM, Dan Carpenter wrote:
>> Btw, if you have the smatch cross function database set up then you can
>> figure out this sort of thing by using:
>>
>> $ smdb.py virtpci_driver_attr_store
>>
>> It says that:
>>
>> fs/sysfs/file.c |
> -Original Message-
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Friday, January 30, 2015 5:25 AM
> > + if (ret != 0) {
> > + if (section_index != NETVSC_INVALID_INDEX)
> > + netvsc_free_send_slot(net_device, section_index);
>
> What if ret is -E
Use power_supply_put() to decrement the power supply's device reference
counter.
Signed-off-by: Krzysztof Kozlowski
Reviewed-by: Bartlomiej Zolnierkiewicz
Reviewed-by: Sebastian Reichel
---
arch/arm/mach-pxa/raumfeld.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch
Replace direct usage of put_device() with new API: power_supply_put().
Signed-off-by: Krzysztof Kozlowski
Acked-by: Pavel Machek
Reviewed-by: Bartlomiej Zolnierkiewicz
Reviewed-by: Sebastian Reichel
---
arch/x86/platform/olpc/olpc-xo15-sci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deleti
Use power_supply_put() to decrement the power supply's device reference
counter.
Signed-off-by: Krzysztof Kozlowski
Acked-by: Pavel Machek
Acked-by: Linus Walleij
Acked-by: Lee Jones
Reviewed-by: Bartlomiej Zolnierkiewicz
Reviewed-by: Sebastian Reichel
---
drivers/mfd/ab8500-sysctrl.c | 2 +
Use power_supply_put() to decrement the power supply's device reference
counter (increased by power_supply_get_by_name() or
power_supply_get_by_phandle()).
Signed-off-by: Krzysztof Kozlowski
Acked-by: Pavel Machek
Reviewed-by: Bartlomiej Zolnierkiewicz
Reviewed-by: Sebastian Reichel
---
drive
Replace direct usage of put_device() with new API: power_supply_put().
Signed-off-by: Krzysztof Kozlowski
Acked-by: Pavel Machek
Reviewed-by: Bartlomiej Zolnierkiewicz
Reviewed-by: Sebastian Reichel
---
arch/x86/platform/olpc/olpc-xo1-sci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletio
Increment the power_supply.use_cnt usage counter on:
- power_supply_get_by_phandle()
- power_supply_get_by_name()
and decrement it on power_supply_put() call.
This helps tracking of valid usage of power supply instance by
consumers. The usage counter itself also allows safe calling of
power_supp
Use power_supply_put() to decrement the power supply's device reference
counter.
Signed-off-by: Krzysztof Kozlowski
Acked-by: Pavel Machek
Reviewed-by: Bartlomiej Zolnierkiewicz
Reviewed-by: Sebastian Reichel
---
drivers/power/88pm860x_charger.c | 11 +--
1 file changed, 9 insertions(
Use power_supply_put() to decrement the power supply's device reference
counter.
Signed-off-by: Krzysztof Kozlowski
Acked-by: Pavel Machek
Reviewed-by: Bartlomiej Zolnierkiewicz
Reviewed-by: Sebastian Reichel
---
drivers/power/charger-manager.c | 70 +++--
Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
- get_property -> power_supply_get_property
Signed-off-by: Krzysztof Kozlowski
Acked-by: Jonghwa Lee
Acked-by: P
The power_supply_get_by_phandle() and power_supply_get_by_name() use
function class_find_device() for obtaining the reference to power
supply. Each use of class_find_device() increases the power supply's
device reference counter.
However the reference counter was not decreased by users of this API
Add simple wrappers for accessing power supply's function attributes:
- get_property -> power_supply_get_property
- set_property -> power_supply_set_property
- property_is_writeable -> power_supply_property_is_writeable
- external_power_changed -> power_supply_external_power_changed
This API a
Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
- get_property -> power_supply_get_property
- set_property -> power_supply_set_property
Signed-off-by: Krzysztof
Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
- get_property -> power_supply_get_property
Signed-off-by: Krzysztof Kozlowski
Acked-by: Jonghwa Lee
Acked-by: P
Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
- get_property -> power_supply_get_property
Signed-off-by: Krzysztof Kozlowski
Acked-by: Jonghwa Lee
Acked-by: P
Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
- get_property -> power_supply_get_property
- set_property -> power_supply_set_property
- property_is_writeable -
Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
- get_property -> power_supply_get_property
Signed-off-by: Krzysztof Kozlowski
Acked-by: Jonghwa Lee
Acked-by: P
Replace direct calls to power supply function attributes with wrappers.
Wrappers provide safe access in case of unregistering the power
supply (e.g. by removing the driver). Replace:
- get_property -> power_supply_get_property
Signed-off-by: Krzysztof Kozlowski
Acked-by: Jonghwa Lee
Acked-by: P
Add new structure 'power_supply_config' for holding run-time
initialization data like of_node, supplies and private driver data.
The power_supply_register() function is changed so all power supply
drivers need updating.
When registering the power supply this new 'power_supply_config' should be
us
Allow drivers to store private data inside power_supply structure for
later usage in power supply operations.
Usage of driver private data is necessary to access driver's state
container object from power supply calls (like get_property()) if struct
'power_supply' is a stored there as a pointer, f
Hi,
The patchset changes power supply API and drivers implementing
power supply class.
TLDR for driver and subsystem maintainers
=
Two patches of patchset change power_supply_register() function so in
the same time they touch all drivers. I am kindly askin
Yes. Please send that as a patch which can be applied.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
The more I look at these, the more I don't like these patches. The
original code looks like:
foo = inb();
There is a 90% chance that we should just delete the whole line, but the
problem is that deleting the whole line is risky because sometimes
reading from the hardware has side effects
On 30/01/15 12:10, Dan Carpenter wrote:
On Fri, Jan 30, 2015 at 10:29:44AM +, Ian Abbott wrote:
@@ -285,7 +284,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
ul_Command1 = ((ul_Command1 & 0xF9FDul) |
On Fri, 30 Jan 2015 16:00:02 +0300, Dan Carpenter said:
> > > - if (ir == NULL) {
> > > - dev_err(ir->l.dev, "close: no private_data attached to the file
!\n");
> >
> > Yes, the dev_err() call is an obvious thinko.
> >
> > However, I'm not sure whether removing it entirely is right either.
On 01/30/2015 07:39 AM, Dan Carpenter wrote:
> Btw, if you have the smatch cross function database set up then you can
> figure out this sort of thing by using:
>
> $ smdb.py virtpci_driver_attr_store
>
> It says that:
>
> fs/sysfs/file.c | sysfs_kf_write | (struct sysfs_ops)->store |
On Thu, Jan 29, 2015 at 05:12:40PM -0500, valdis.kletni...@vt.edu wrote:
> On Thu, 29 Jan 2015 19:48:08 +0100, Rickard Strandqvist said:
> > Fix a possible null pointer dereference, there is
> > otherwise a risk of a possible null pointer dereference.
> >
> > This was found using a static code anal
Run your patches through checkpatch.pl.
On Thu, Jan 29, 2015 at 07:50:26PM +0100, Rickard Strandqvist wrote:
> - if (dprivate != NULL)
> + if (dprivate != NULL) {
This is a double negative. Just say "if (dprivate) {". Actually just
reverse the test and remove the bogus printk. Say:
On Fri, Jan 30, 2015 at 10:29:44AM +, Ian Abbott wrote:
> >@@ -285,7 +284,7 @@ static irqreturn_t apci3501_interrupt(int irq, void *d)
> > ul_Command1 = inl(dev->iobase + APCI3501_TIMER_CTRL_REG);
> > ul_Command1 = ((ul_Command1 & 0xF9FDul) | 1 << 1);
> > outl(ul_Command1, dev->
Ian Abbott wrote:
On 29/01/15 22:50, Rickard Strandqvist wrote:
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
dr
On 29/01/15 22:50, Rickard Strandqvist wrote:
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/
On 29/01/15 22:43, Rickard Strandqvist wrote:
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/
On 29/01/15 22:40, Rickard Strandqvist wrote:
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/
On 29/01/15 22:34, Rickard Strandqvist wrote:
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/
On 29/01/15 22:30, Rickard Strandqvist wrote:
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/
On Fri, Jan 30, 2015 at 4:34 AM, Haiyang Zhang
wrote:
The existing code frees the skb in EAGAIN case, in which the skb will
be
retried from upper layer and used again.
Also, the existing code doesn't free send buffer slot in error case,
because
there is no completion message for unsent pac
On 29/01/15 22:25, Rickard Strandqvist wrote:
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/
On 29/01/15 22:15, Rickard Strandqvist wrote:
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/
Move the PCMCIA-specific stuff out of "comedidev.h" into
"comedi_pcmcia.h". Comedi PCMCIA drivers now include "comedi_pcmcia.h"
instead of "comedidev.h", which now gets pulled in indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedi_pcmcia.h | 28 ++--
Include the new "../comedi_pcmcia.h" header instead of
, , and
"../comedidev.h". isn't needed and the others will
now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git
Include the new "../comedi_pcmcia.h" header instead of
, , and
"../comedidev.h". isn't needed and the others will
now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/d
Include the new "../comedi_pcmcia.h" header instead of
, and "../comedidev.h", which will now
get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/ni_mio_cs.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers
Include the new "../comedi_pcmcia.h" header instead of
, and "../comedidev.h", which will now
get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/cb_das16_cs.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/driver
Include the new "../comedi_pcmcia.h" header instead of
, and "../comedidev.h", which will now
get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/das08_cs.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/d
"comedidev.h" includes PCMCIA-specific stuff that gets included by all
comedi drivers including non-PCMCIA ones. Separate it out into its own
header "comedi_pcmcia.h". Make the new header include
, and "comedidev.h" so that comedi PCMCIA
drivers do not need to include them explicitly.
01) stagi
Add a new header that Comedi PCMCIA drivers can include instead of
"comedidev.h". Currently, it just pulls in ,
and "comedidev.h", but the plan is to migrate the
PCMCIA-specific stuff from "comedidev.h" here.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedi_pcmcia.h | 31 +++
Include the new "../comedi_pcmcia.h" header instead of
, , and
"../comedidev.h". isn't needed and the others will
now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/ni_labpc_cs.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/dr
Include the new "comedi_pcmcia.h" header instead of ,
and "comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedi_pcmcia.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/comedi_pcmcia.c
b
Include the new "../comedi_pcmcia.h" header instead of
, and "../comedidev.h", which will now
get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/ni_daq_700.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers
69 matches
Mail list logo
