On Mon, Feb 2, 2015 at 12:35 PM, Dexuan Cui wrote:
Before the line vmbus_open() returns, srv->util_cb can be already
running
and the variables, like util_fw_version, are needed by the
srv->util_cb.
So we have to make sure the variables are initialized before the
vmbus_open().
CC: "K. Y.
On Tue, Feb 3, 2015 at 11:40 AM, KY Srinivasan
wrote:
-Original Message-
From: Jason Wang [mailto:jasow...@redhat.com]
Sent: Monday, February 2, 2015 7:38 PM
To: KY Srinivasan
Cc: Dexuan Cui; gre...@linuxfoundation.org;
linux-ker...@vger.kernel.org;
driverdev-devel@linuxdri
> -Original Message-
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Monday, February 2, 2015 7:38 PM
> To: KY Srinivasan
> Cc: Dexuan Cui; gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> driverdev-devel@linuxdriverproject.org; o...@aepfle.de;
> a...@canonical.com; vku
On Tue, Feb 3, 2015 at 11:30 AM, KY Srinivasan
wrote:
-Original Message-
From: Jason Wang [mailto:jasow...@redhat.com]
Sent: Monday, February 2, 2015 7:09 PM
To: Dexuan Cui
Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
driverdev-
de...@linuxdriverproject.org
> -Original Message-
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Monday, February 2, 2015 7:09 PM
> To: Dexuan Cui
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev-
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; KY
> Srinivasan; vk
On Mon, Feb 2, 2015 at 6:09 PM, Dexuan Cui wrote:
-Original Message-
From: Jason Wang [mailto:jasow...@redhat.com]
Sent: Monday, February 2, 2015 17:36 PM
To: Dexuan Cui
Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
driverdev-
de...@linuxdriverproject.org; o...@
On Feb 2, 2015, at 3:51 PM, Greg Kroah-Hartman wrote:
> On Mon, Feb 02, 2015 at 03:25:58PM -0500, Oleg Drokin wrote:
>>> What is this code supposed to be protecting from? And -1? That should
>>> never be a return value…
>>
>> Why is -1 a bad return value if all callsites check for that as an
>>
On 01/28/2015 03:07 PM, Clemens Ladisch wrote:
> The driver was using the vendor ID 0xd00d1e from the FireWire core.
> However, this ID was not registered, and invalid.
>
> Instead, use the vendor/version IDs that now are officially assigned to
> firewire-serial:
> https://ieee1394.wiki.kernel.org
On Mon, Feb 02, 2015 at 03:25:58PM -0500, Oleg Drokin wrote:
> Hello!
>
> On Feb 2, 2015, at 10:44 AM, Greg Kroah-Hartman wrote:
>
> > On Mon, Feb 02, 2015 at 04:02:31PM +0300, Dan Carpenter wrote:
> >> On Sun, Feb 01, 2015 at 09:52:05PM -0500, gr...@linuxhacker.ru wrote:
> >>> From: Dmitry Eremi
Hello!
On Feb 2, 2015, at 10:44 AM, Greg Kroah-Hartman wrote:
> On Mon, Feb 02, 2015 at 04:02:31PM +0300, Dan Carpenter wrote:
>> On Sun, Feb 01, 2015 at 09:52:05PM -0500, gr...@linuxhacker.ru wrote:
>>> From: Dmitry Eremin
>>>
>>> Expression if (size != (ssize_t)size) is always false.
>>> Ther
osc_init() is marked as the module_init function in osc_request.c
and is never used anywhere else. Hence, it can (and should) be
declared static.
sparse also complained about this with the following warning, which
is fixed by this patch.
andreas@workbox:~/linux-next$ make C=1 M=drivers/staging/lu
On 02.02.2015 15:16, Al Viro wrote:
> On Mon, Feb 02, 2015 at 02:36:43PM +0100, Andreas Ruprecht wrote:
>> When running sparse on the osc/ subdirectory, it shows the
>> following warning:
>>
>> andreas@workbox:~/linux-next$ make C=1 M=drivers/staging/lustre/lustre/osc/
>> [...]
>> drivers/staging/l
Instead of declaring a new type, define a new struct.
Signed-off-by: Ricardo Ribalda Delgado
---
v2: Suggested by Joe Perches
Replace unnecessary casting.
drivers/staging/unisys/visorutil/procobjecttree.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers
On Mon, 2015-02-02 at 19:26 +0100, Ricardo Ribalda Delgado wrote:
> Instead of declaring a new type, define a new struct.
[]
> diff --git a/drivers/staging/unisys/visorutil/procobjecttree.c
> b/drivers/staging/unisys/visorutil/procobjecttree.c
[]
> @@ -340,7 +341,9 @@ EXPORT_SYMBOL_GPL(visor_proc_
Fix minor code stype problems found by checkpatch.pl
Ricardo Ribalda Delgado (2):
staging/unisys/visorutil/procobjecttree: Code Style
staging/unisys/visorutil/procobjecttree: Replace typedef
drivers/staging/unisys/visorutil/procobjecttree.c | 23 +--
1 file changed, 13 in
Instead of declaring a new type, define a new struct.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/staging/unisys/visorutil/procobjecttree.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys/visorutil/procobjecttree.c
b/drivers/stagin
Lines should not be over 80 characters
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/staging/unisys/visorutil/procobjecttree.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/unisys/visorutil/procobjecttree.c
b/drivers/staging/unisys/visorutil
On Sat, Jan 31, 2015 at 05:24:42PM +0530, varsharamt wrote:
The task was to fix a warning which was shown while compiling a driver
called NVEC. I wrote a brief description about how to enable support for
a nVidya complaint embedded controller.
Please note that NVIDIA is spelled/capitalized as
On Thu, Jan 29, 2015 at 07:59:12PM +0100, Rickard Strandqvist wrote:
> Fix a possible null pointer dereference, there is
> otherwise a risk of a possible null pointer dereference.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist
> ---
On Thu, Jan 29, 2015 at 07:46:10PM +0100, Rickard Strandqvist wrote:
> Fix a possible null pointer dereference, there is
> otherwise a risk of a possible null pointer dereference.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist
> ---
On Mon, Feb 02, 2015 at 04:02:31PM +0300, Dan Carpenter wrote:
> On Sun, Feb 01, 2015 at 09:52:05PM -0500, gr...@linuxhacker.ru wrote:
> > From: Dmitry Eremin
> >
> > Expression if (size != (ssize_t)size) is always false.
> > Therefore no bounds check errors detected.
>
> The original code actua
On Mon, Feb 02, 2015 at 02:36:43PM +0100, Andreas Ruprecht wrote:
> When running sparse on the osc/ subdirectory, it shows the
> following warning:
>
> andreas@workbox:~/linux-next$ make C=1 M=drivers/staging/lustre/lustre/osc/
> [...]
> drivers/staging/lustre/lustre/osc/osc_request.c:3335:12: war
When running sparse on the osc/ subdirectory, it shows the
following warning:
andreas@workbox:~/linux-next$ make C=1 M=drivers/staging/lustre/lustre/osc/
[...]
drivers/staging/lustre/lustre/osc/osc_request.c:3335:12: warning:
symbol 'osc_init' was not declared. Should it be static?
[...]
As this
On 01/28/2015 11:47 PM, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
FYI: I've dropped this patch since the vino driver will
On Sun, Feb 01, 2015 at 09:52:05PM -0500, gr...@linuxhacker.ru wrote:
> From: Dmitry Eremin
>
> Expression if (size != (ssize_t)size) is always false.
> Therefore no bounds check errors detected.
The original code actually worked as designed. The integer overflow
could only happen on 32 bit sys
From: Markus Elfring
Date: Mon, 2 Feb 2015 13:20:23 +0100
The video_unregister_device() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
This is a note to let you know that I have just added a patch titled
x86, hyperv: Mark the Hyper-V clocksource as being continuous
to the linux-3.16.y-queue branch of the 3.16.y-ckt extended stable tree
which can be found at:
http://kernel.ubuntu.com/git?p=ubuntu/linux.git;a=shortlog;h=re
On 31/01/15 13:44, Rickard Strandqvist wrote:
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/
On 31/01/15 13:39, Rickard Strandqvist wrote:
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/comedi/
> -Original Message-
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Monday, February 2, 2015 17:41 PM
> To: Dexuan Cui
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev-
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; KY
> Srinivasan; vku
> -Original Message-
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Monday, February 2, 2015 17:36 PM
> To: Dexuan Cui
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev-
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; KY
> Srinivasan; vku
On Mon, Feb 2, 2015 at 12:37 PM, Dexuan Cui wrote:
Without this patch, the state is put to CHANNEL_OPENING_STATE, and
when
the driver is loaded next time, vmbus_open() will fail immediately
due to
newchannel->state != CHANNEL_OPEN_STATE.
CC: "K. Y. Srinivasan"
Signed-off-by: Dexuan Cui
--
On Mon, Feb 2, 2015 at 12:36 PM, Dexuan Cui wrote:
I got HV_STATUS_INVALID_CONNECTION_ID on Hyper-V 2008 R2 when keeping
running
"rmmod hv_netvsc; modprobe hv_netvsc; rmmod hv_utils; modprobe
hv_utils"
in a Linux guest. Looks the host has some kind of throttling
mechanism if
some kinds of h
On Mon, Feb 2, 2015 at 12:35 PM, Dexuan Cui wrote:
Before the line vmbus_open() returns, srv->util_cb can be already
running
and the variables, like util_fw_version, are needed by the
srv->util_cb.
A questions is why we do this for util only? Can callbacks of other
devices be called before
Am Freitag, 30. Januar 2015, 15:47:38 schrieb Krzysztof Kozlowski:
> Hi,
>
> The patchset changes power supply API and drivers implementing
> power supply class.
>
>
> TLDR for driver and subsystem maintainers
> =
> Two patches of patchset change power_sup
> do you have reviewed this patchset?
Yes, but ...
a) You only sent it 7 working days ago -- give me a chance
b) We are already at -rc7, so I have stopped accepting patches
c) I currently have my head buried under a tonne of my own work
... so please don't nag -- you're beginning to sound like m
36 matches
Mail list logo
