Re: [PATCH] Staging: lustre: api-ni.c: adding tabs because lines were too long.

2015-04-03 Thread Dan Carpenter
Fix your from header so it has your name. On Thu, Apr 02, 2015 at 04:57:52PM +0200, vcaba...@clipper.ens.fr wrote: From 654380760bfc5b35ed3d3d4a7d3eb126fe747959 Mon Sep 17 00:00:00 2001 From: Vivien Cabannes vcaba...@clipper.ens.fr Date: Thu, 2 Apr 2015 16:32:15 +0200 Subject: [PATCH]

Re: [PATCH] Staging: lustre: o2iblnd.c: Finished cleaning code style

2015-04-03 Thread Dan Carpenter
On Thu, Apr 02, 2015 at 07:52:07PM +0200, Guillaume Matheron wrote: I fixed lines over 80 characters and unnecessary returns Signed-off-by: Guillaume Matheron guillaume.mathe...@ens.fr --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 53 +- 1 file changed, 31

Re: [PATCH V2 2/3] staging: android: ion_test: unregister the misc device

2015-04-03 Thread Greg KH
On Thu, Apr 02, 2015 at 09:36:06PM +0700, Phong Tran wrote: Add the remove() method for deregister from misc device when it's unloaded. Signed-off-by: Phong Tran tranmanph...@gmail.com --- drivers/staging/android/ion/ion_test.c | 12 1 file changed, 12 insertions(+) diff

Re: [PATCH/RFC 5/6] staging: board: Add support for devices with complex dependencies

2015-04-03 Thread Dan Carpenter
On Fri, Apr 03, 2015 at 02:42:02PM +0200, Geert Uytterhoeven wrote: +int __init board_staging_register_clock(const struct board_staging_clk *bsc) +{ + struct clk *clk; + int error; + + pr_debug(Registering clock %s for con_id %s dev_id %s\n, bsc-clk, + bsc-con_id,

Re: [PATCH] drivers: staging: speakup: fix sparse warning: expression using sizeof bool

2015-04-03 Thread Greg Kroah-Hartman
On Fri, Mar 27, 2015 at 09:29:43PM +0100, Witos wrote: Changed bool to u8. Signed-off-by: Piotr Witoslawski pwi...@gmail.com Your From: email line and signed-off-by: line names do not match, so I can't take this patch :( Please fix up and resend. --- drivers/staging/speakup/fakekey.c | 2

Re: [PATCH] drivers: staging: speakup: fix sparse warning: expression using sizeof bool

2015-04-03 Thread Greg Kroah-Hartman
On Fri, Mar 27, 2015 at 09:36:07PM +0100, Witos wrote: Changed bool to u8 to get rid of sparse warning. Signed-off-by: Piotr Witoslawski pwi...@gmail.com --- drivers/staging/speakup/fakekey.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH/RFC 3/6] staging: board: Add support for translating hwirq to virq numbers

2015-04-03 Thread Geert Uytterhoeven
As of commit 9a1091ef0017c40a (irqchip: gic: Support hierarchy irq domain.), GIC IRQ numbers are virtual, breaking hardcoded hardware IRQ numbers in platform device resources. Add support for translating hardware IRQ numbers to virtual IRQ numbers, and fixing up platform device resources with

[PATCH/RFC 6/6] staging: board: armadillo800eva: Board staging for sh_mobile_lcdc_fb

2015-04-03 Thread Geert Uytterhoeven
Add staging board support for the r8a7740-based armadillo800eva board and add platform devices to allow in-tree continuous development of the drivers on the armadillo800eva board. When DT bindings are ready for theses drivers then the platform devices in the armadillo800eva staging board code can

[PATCH/RFC 0/6] staging: board: armadillo800eva: Board staging for sh_mobile_lcdc_fb

2015-04-03 Thread Geert Uytterhoeven
Hi all, This RFC patch series adds board staging support for r8a7740/armadillo. For now this supports only the frame buffer device for the on-board LCD. The goal is to complete the move to ARM multiplatform kernels for all shmobile platforms, and drop the existing board files

[PATCH/RFC 5/6] staging: board: Add support for devices with complex dependencies

2015-04-03 Thread Geert Uytterhoeven
Add support for easy registering of one ore more platform devices that may: - need clocks that are described in DT, - need pin control configuration, - rely on a configured GPIO, - be part of a PM Domain. All these dependencies are optional. Signed-off-by: Geert Uytterhoeven

Re: [PATCH] staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev_dev

2015-04-03 Thread Dan Carpenter
@@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev) IEEE_SOFTMAC_TX_QUEUE)) || ((!ieee-softmac_data_hard_start_xmit (ieee-softmac_features IEEE_SOFTMAC_TX_QUEUE { - printk(KERN_WARNING %s: No xmit handler.\n,

Re: [PATCH] staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev_dev

2015-04-03 Thread Greg KH
On Fri, Apr 03, 2015 at 11:49:57AM -0400, Nicholas Krause wrote: On April 3, 2015 5:19:55 AM EDT, Dan Carpenter dan.carpen...@oracle.com wrote: @@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb, struct net_device *dev) IEEE_SOFTMAC_TX_QUEUE)) ||

Re: [PATCH/RFC 5/6] staging: board: Add support for devices with complex dependencies

2015-04-03 Thread Russell King - ARM Linux
On Fri, Apr 03, 2015 at 03:57:27PM +0300, Dan Carpenter wrote: On Fri, Apr 03, 2015 at 02:42:02PM +0200, Geert Uytterhoeven wrote: +int __init board_staging_register_clock(const struct board_staging_clk *bsc) +{ + struct clk *clk; + int error; + + pr_debug(Registering clock

Re: [PATCH] staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev_dev

2015-04-03 Thread Greg KH
On Fri, Apr 03, 2015 at 02:05:11PM -0400, Nicholas Krause wrote: On April 3, 2015 1:05:59 PM EDT, Greg KH gre...@linuxfoundation.org wrote: On Fri, Apr 03, 2015 at 11:49:57AM -0400, Nicholas Krause wrote: On April 3, 2015 5:19:55 AM EDT, Dan Carpenter dan.carpen...@oracle.com wrote:

[PATCH] Staging: rtl8188eu: Remove zero testing pointer typed value

2015-04-03 Thread Amitoj Kaur Chawla
Removes variable comparison with 0 by using !. Done using following coccinelle script. @ disable is_zero,isnt_zero @ expression *E; expression E1,f; @@ E = f(...) ... ( - E == 0 + !E | - E != 0 + E | - 0 == E + !E | - 0 != E + E ) ... ?E = E1 @ disable is_zero,isnt_zero @ expression *E; @@ (

Re: [PATCH] Staging: rtl8188eu: Remove zero testing pointer typed value

2015-04-03 Thread Dan Carpenter
On Fri, Apr 03, 2015 at 10:12:11PM +0530, Amitoj Kaur Chawla wrote: Removes variable comparison with 0 by using !. Sometimes testing for zero makes sense. When you write code, you are telling a story. If you are talking about zero as a number then it can make sense. If it's zero as a boolean

Re: [PATCH/RFC 5/6] staging: board: Add support for devices with complex dependencies

2015-04-03 Thread Russell King - ARM Linux
On Fri, Apr 03, 2015 at 03:27:40PM +0200, Geert Uytterhoeven wrote: On Fri, Apr 3, 2015 at 2:57 PM, Dan Carpenter dan.carpen...@oracle.com wrote: + error = clk_register_clkdev(clk, bsc-con_id, bsc-dev_id); + if (error) + pr_err(Failed to register clock %s (%d)\n,

Re: [PATCH] staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev_dev

2015-04-03 Thread Nicholas Krause
On April 3, 2015 1:05:59 PM EDT, Greg KH gre...@linuxfoundation.org wrote: On Fri, Apr 03, 2015 at 11:49:57AM -0400, Nicholas Krause wrote: On April 3, 2015 5:19:55 AM EDT, Dan Carpenter dan.carpen...@oracle.com wrote: @@ -582,7 +582,7 @@ int rtllib_xmit_inter(struct sk_buff *skb,

Re: [PATCH/RFC 0/6] staging: board: armadillo800eva: Board staging for sh_mobile_lcdc_fb

2015-04-03 Thread Laurent Pinchart
Hello Geert, Thank you for the patches. On Friday 03 April 2015 14:41:57 Geert Uytterhoeven wrote: Hi all, This RFC patch series adds board staging support for r8a7740/armadillo. For now this supports only the frame buffer device for the on-board LCD. I've started adding DT support

Re: [PATCH] Staging: rtl8188eu: Remove zero testing pointer typed value

2015-04-03 Thread Joe Perches
On Fri, 2015-04-03 at 19:51 +0300, Dan Carpenter wrote: On Fri, Apr 03, 2015 at 10:12:11PM +0530, Amitoj Kaur Chawla wrote: Removes variable comparison with 0 by using !. Sometimes testing for zero makes sense. When you write code, you are telling a story. If you are talking about zero

Re: [PATCH] Staging: rtl8188eu: Remove zero testing pointer typed value

2015-04-03 Thread Amitoj Kaur Chawla
On Fri, Apr 3, 2015 at 10:21 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Fri, Apr 03, 2015 at 10:12:11PM +0530, Amitoj Kaur Chawla wrote: Removes variable comparison with 0 by using !. Sometimes testing for zero makes sense. When you write code, you are telling a story. If you

Re: [PATCH] staging: lustre: replace kzalloc with copy_from_user with memdup_user

2015-04-03 Thread Drokin, Oleg
Hello! On Apr 2, 2015, at 6:18 AM, Julia Lawall wrote: Julia, I wonder if you happen to have a bunch of other patches to get rid of the rest of OBD_ALLOC and OBD_FREE stuff by any chance? I can generate them again, but I wasn't clear on what was wanted. I would really prefer something

Re: [PATCH] Staging: rtl8188eu: Remove zero testing pointer typed value

2015-04-03 Thread Dan Carpenter
On Fri, Apr 03, 2015 at 10:01:10AM -0700, Joe Perches wrote: On Fri, 2015-04-03 at 19:51 +0300, Dan Carpenter wrote: Also strcmp() and similar should always be done as == 0, 0 or != 0 because that is the idiom: Less true. When testing for equality, !strcmp is very common. There are

Re: [PATCH/RFC 0/6] staging: board: armadillo800eva: Board staging for sh_mobile_lcdc_fb

2015-04-03 Thread Geert Uytterhoeven
Hi Laurent, On Fri, Apr 3, 2015 at 6:24 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: On Friday 03 April 2015 14:41:57 Geert Uytterhoeven wrote: This RFC patch series adds board staging support for r8a7740/armadillo. For now this supports only the frame buffer device for the

Re: [PATCH] staging:rtl8192e: Change printk statements in rtllib_tx.c to use netdev_dev

2015-04-03 Thread Nicholas Krause
On April 3, 2015 2:30:01 PM EDT, Greg KH gre...@linuxfoundation.org wrote: On Fri, Apr 03, 2015 at 02:05:11PM -0400, Nicholas Krause wrote: On April 3, 2015 1:05:59 PM EDT, Greg KH gre...@linuxfoundation.org wrote: On Fri, Apr 03, 2015 at 11:49:57AM -0400, Nicholas Krause wrote: On

[PATCH] staging: fbtft: 80 characters per line in fb_ili9163.c

2015-04-03 Thread Andreas Theodosiou
This is a patch to the fb_ili9163.c file that inserts a line break in line #92 to make the line fit into the 80 character limit. Signed-off-by: Andreas Theodosiou andreas...@gmail.com --- drivers/staging/fbtft/fb_ili9163.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] staging: fbtft: 80 characters per line in fb_ili9163.c

2015-04-03 Thread Giedrius Statkevičius
On Sat, 4 Apr 2015, Andreas Theodosiou wrote: This is a patch to the fb_ili9163.c file that inserts a line break in line #92 to make the line fit into the 80 character limit. Signed-off-by: Andreas Theodosiou andreas...@gmail.com --- drivers/staging/fbtft/fb_ili9163.c | 3 ++- 1 file

Re: [PATCH] staging: fbtft: 80 characters per line in fb_ili9163.c

2015-04-03 Thread Joe Perches
On Sat, 2015-04-04 at 03:23 +0300, Andreas Theodosiou wrote: This is a patch to the fb_ili9163.c file that inserts a line break in line #92 to make the line fit into the 80 character limit. [] diff --git a/drivers/staging/fbtft/fb_ili9163.c b/drivers/staging/fbtft/fb_ili9163.c [] @@ -89,7

[PATCH V3 0/2] Fix some issues of staging ion test driver

2015-04-03 Thread Phong Tran
Hi Greg, I resend 2 patches (1) add the remove() platform driver callback to deregister the misc device (2) unregister platform device when driver is unloaded Changes from v2: Remove the extra space of patch (1) Changes from v1: Imporve the coding style Phong Tran (2):

Re: [PATCH/RFC 5/6] staging: board: Add support for devices with complex dependencies

2015-04-03 Thread Geert Uytterhoeven
On Fri, Apr 3, 2015 at 2:57 PM, Dan Carpenter dan.carpen...@oracle.com wrote: + error = clk_register_clkdev(clk, bsc-con_id, bsc-dev_id); + if (error) + pr_err(Failed to register clock %s (%d)\n, bsc-clk, error); + return error; Missing curly braces. Also

Re: [PATCH] Staging: rtl8188eu: Replaced kzalloc and memcpy combination with kmemdup

2015-04-03 Thread gre...@linuxfoundation.org
On Mon, Mar 30, 2015 at 03:11:25PM +, Dhere, Chaitanya (C.) wrote: This change was detected with the help of coccinelle tool. It performs the same function as kzalloc amd memcpy. Signed-off-by: Chaitanya Dhere cvija...@visteon.com Your From: line and this line don't match :( ---

[PATCH V3 2/2] staging: android: ion_test: unregister the platform device

2015-04-03 Thread Phong Tran
The driver has to unregister from platform device when it's unloaded Signed-off-by: Phong Tran tranmanph...@gmail.com --- drivers/staging/android/ion/ion_test.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_test.c

[PATCH V3 1/2] staging: android: ion_test: unregister the misc device

2015-04-03 Thread Phong Tran
Add the remove() method for deregister from misc device when it's unloaded. Signed-off-by: Phong Tran tranmanph...@gmail.com --- drivers/staging/android/ion/ion_test.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/staging/android/ion/ion_test.c