[RFC PATCH 06/11] MIPS: OCTEON: rename __cvmx_helper_npi/rgmii_probe

2015-05-01 Thread Aaro Koskinen
Rename __cvmx_helper_npi/rgmii_probe to __cvmx_helper_npi/rgmii_enumerate as only latter are used. Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- arch/mips/cavium-octeon/executive/cvmx-helper.c | 12 ++-- arch/mips/include/asm/octeon/cvmx-helper-npi.h | 7 +++

[PATCH 8/20] staging: lustre: llite: statahead: remove unneeded null test before free

2015-05-01 Thread Julia Lawall
Kfree can cope with a null argument, so drop null tests. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression ptr; @@ - if (ptr != NULL) kfree(ptr); // /smpl Signed-off-by: Julia Lawall julia.law...@lip6.fr ---

Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree

2015-05-01 Thread Greg Kroah-Hartman
On Fri, May 01, 2015 at 08:18:56PM +, Simmons, James A. wrote: From: Julia Lawall julia.law...@lip6.fr Replace OBD_ALLOC, OBD_ALLOC_WAIT, OBD_ALLOC_PTR, and OBD_ALLOC_PTR_WAIT by kalloc/kcalloc, and OBD_FREE and OBD_FREE_PTR by kfree. Nak: James Simmons jsimm...@infradead.org

Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree

2015-05-01 Thread Drokin, Oleg
On May 1, 2015, at 4:18 PM, Simmons, James A. wrote: Yes the LARGE functions do the switching. I was expecting also patches to remove the OBD_ALLOC_LARGE functions as well which is not the case here. I do have one question still. The macro __OBD_MALLOC_VERBOSE allowed the ability to

Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree

2015-05-01 Thread Greg Kroah-Hartman
On Fri, May 01, 2015 at 08:36:05PM +, Simmons, James A. wrote: We are hopefully going to get rid of OBD_ALLOC_LARGE() as well, though. It's simple enough to write a function: void *obd_zalloc(size_t size) { if (size 4 * PAGE_CACHE_SIZE) return vzalloc(size);

Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree

2015-05-01 Thread Drokin, Oleg
Hello! On May 1, 2015, at 1:48 PM, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr Replace OBD_ALLOC, OBD_ALLOC_WAIT, OBD_ALLOC_PTR, and OBD_ALLOC_PTR_WAIT by kalloc/kcalloc, and OBD_FREE and OBD_FREE_PTR by kfree. Nak: James Simmons jsimm...@infradead.org A simple replace

Re: [PATCH 8/11] staging: lustre: obdclass: Use kzalloc and kfree

2015-05-01 Thread walter harms
hi Julia, your patch seems fine. I tried to understand the code and it seems that much of it can be simplified by using already available functions. I have added some comments but i am not sure what to make of it. re, wh Am 01.05.2015 17:51, schrieb Julia Lawall: From: Julia Lawall

Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree

2015-05-01 Thread Greg Kroah-Hartman
On Fri, May 01, 2015 at 05:38:49PM +, Simmons, James A. wrote: From: Julia Lawall julia.law...@lip6.fr Replace OBD_ALLOC, OBD_ALLOC_WAIT, OBD_ALLOC_PTR, and OBD_ALLOC_PTR_WAIT by kalloc/kcalloc, and OBD_FREE and OBD_FREE_PTR by kfree. Nak: James Simmons jsimm...@infradead.org A

Re: [PATCH 8/11] staging: lustre: obdclass: Use kzalloc and kfree

2015-05-01 Thread Julia Lawall
On Fri, 1 May 2015, walter harms wrote: hi Julia, your patch seems fine. I tried to understand the code and it seems that much of it can be simplified by using already available functions. I have added some comments but i am not sure what to make of it. Thanks for the review. Comments

Re: [PATCH] staging: i2o: Remove unwanted semicolon

2015-05-01 Thread Alan Cox
Possibly but that ought to go via staging and really is one for the SCSI folks to call. The dpt_i2o was a bit more common than i2o proper. But if the staging i2o core is removed, doesn't that mean that this driver will stop working? It uses code in uapi i2o.h, which I'm guessing is

Re: [PATCH] staging: i2o: Remove unwanted semicolon

2015-05-01 Thread gre...@linuxfoundation.org
On Thu, Apr 30, 2015 at 11:25:48PM +0100, One Thousand Gnomes wrote: On Thu, 30 Apr 2015 16:14:06 +0200 gre...@linuxfoundation.org gre...@linuxfoundation.org wrote: On Thu, Apr 23, 2015 at 04:09:28PM +0100, Alan Cox wrote: On Thu, 2015-04-23 at 13:43 +, Gujulan Elango, Hari Prasath

Re: [PATCH] staging: i2o: Remove unwanted semicolon

2015-05-01 Thread Dan Carpenter
On Fri, May 01, 2015 at 10:18:14AM +0300, Dan Carpenter wrote: On Thu, Apr 30, 2015 at 10:05:00PM +0530, hari prasath wrote: Greg I am not sure if this needs to go into next release. I send this patch as checkpatch was complaining about it. May be the owners of this driver can only

Re: [PATCH] staging: rtl8192e: fix wrong assignment

2015-05-01 Thread Dan Carpenter
The subject says fix but this does not fix a run time bug, it just silences a warning. It's still the correct thing according to Larry so that's good. On Thu, Apr 30, 2015 at 12:06:28PM +, Gujulan Elango, Hari Prasath (H.) wrote: This patch addresses a spatch warning on assigning a

Re: [PATCH] staging: i2o: Remove unwanted semicolon

2015-05-01 Thread Alan Cox
On Fri, 2015-05-01 at 09:41 +0200, gre...@linuxfoundation.org wrote: On Thu, Apr 30, 2015 at 11:25:48PM +0100, One Thousand Gnomes wrote: On Thu, 30 Apr 2015 16:14:06 +0200 gre...@linuxfoundation.org gre...@linuxfoundation.org wrote: On Thu, Apr 23, 2015 at 04:09:28PM +0100, Alan Cox

Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree

2015-05-01 Thread Drokin, Oleg
On May 1, 2015, at 4:58 PM, Greg Kroah-Hartman wrote: On Fri, May 01, 2015 at 08:52:37PM +, Drokin, Oleg wrote: On May 1, 2015, at 4:49 PM, Greg Kroah-Hartman wrote: On Fri, May 01, 2015 at 08:36:05PM +, Simmons, James A. wrote: We are hopefully going to get rid of

Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree

2015-05-01 Thread Greg Kroah-Hartman
On Fri, May 01, 2015 at 08:52:37PM +, Drokin, Oleg wrote: On May 1, 2015, at 4:49 PM, Greg Kroah-Hartman wrote: On Fri, May 01, 2015 at 08:36:05PM +, Simmons, James A. wrote: We are hopefully going to get rid of OBD_ALLOC_LARGE() as well, though. It's simple enough to write a

Re: [RFC PATCH 00/11] MIPS: OCTEON: move all octeon-ethernet code to staging

2015-05-01 Thread Greg Kroah-Hartman
On Fri, May 01, 2015 at 10:37:02PM +0300, Aaro Koskinen wrote: Hi, In order to octeon-ethernet staging work to proceed, we should have all the code in the same tree (staging). Currently, most of the driver code actually lives in the MIPS tree in the cvmx helper or OS abstraction routines

Re: [HPDD-discuss] [PATCH 2/11] Staging: lustre: fld: Use kzalloc and kfree

2015-05-01 Thread Drokin, Oleg
On May 1, 2015, at 4:49 PM, Greg Kroah-Hartman wrote: On Fri, May 01, 2015 at 08:36:05PM +, Simmons, James A. wrote: We are hopefully going to get rid of OBD_ALLOC_LARGE() as well, though. It's simple enough to write a function: void *obd_zalloc(size_t size) { if (size 4 *

[PATCH] staging: rtl8192u: don't redefine container_of()

2015-05-01 Thread Marti Bolivar
This file already includes linux/kernel.h. Signed-off-by: Marti Bolivar mbolivarmul...@gmail.com --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h

[PATCH 013/107] staging: comedi: ni_stc.h: tidy up NI_M_PLL_STATUS_REG bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and convert the enum into defines. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 2

[PATCH 012/107] staging: comedi: ni_stc.h: tidy up NI_M_PLL_CTRL_REG bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and convert the enum into defines. Use the BIT() macro to define the bits. Convert the inline functions MSeries_PLL_Divisor_Bits() and MSeries_PLL_Multiplier_Bits() to macros. The helper function ni_mseries_get_pll_parameters() always returns valid values for the 'divisor'

[PATCH 048/107] staging: comedi: ni_stc.h: remove unreachable code in RTSI_Output_Bit()

2015-05-01 Thread H Hartley Sweeten
All the callers of this function check the 'channel' number with num_configurable_rtsi_channels(). This check can never occure. Remove it. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 026/107] staging: comedi: ni_stc.h: tidy up NI_M_INTC_ENA_REG bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and convert enums into defines. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 2 +-

[PATCH 020/107] staging: comedi: ni_stc.h: tidy up NI_M_CDIO_DMA_SEL_REG bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and convert enums into macros to set the bits in this register. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 17

[PATCH 028/107] staging: comedi: ni_mio_common: remove disabled GPCT functions

2015-05-01 Thread H Hartley Sweeten
The GPCT (general purpose counter timer) is handled by the ni_tio and ni_tiocmd modules. Remove the old disabled code in this file. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 017/107] staging: comedi: ni_stc.h: tidy up NI_M_CAL_PWM_REG bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and convert the inline helper functions that set the bits in this register to macros. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 000/107] staging: comedi: tidy up ni_stc.h

2015-05-01 Thread H Hartley Sweeten
The ni_stc.h header contains the DAQ-STC and board specific register information used by ni_mio_common.c to provide the guts for the National Instruments MIO drivers ni_atmio, ni_mio_cs, and ni_pcimio. Those drivers all currently include the ni_mio_common.c file. This header is a bit of a mess...

[PATCH 014/107] staging: comedi: ni_stc.h: tidy up NI_M_AI_CFG_BYPASS_FIFO_REG bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and convert the enum into defines. Use the BIT() macro to define the bits. Convert the inline helper functions into macros. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 003/107] staging: comedi: ni_mio_common: refactor gpct to stc register handling

2015-05-01 Thread H Hartley Sweeten
The NI General Purpose Counter Timer (gpct) registers are mapped to the STC registers with a big switch statement. Create a lookup table to handle the mapping ot the registers. This is easier to maintain. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott

[PATCH 004/107] staging: comedi: ni_mio_common: open code the M-Series GPCT register offsets

2015-05-01 Thread H Hartley Sweeten
Remove the enum m_series_register_offsets values that are only used in the lookup tables for the GPCT to STC register mapping and just open code the values. Having the extra level of indirection does not add any additional clarity and it gets rid of some of the CamelCase symbols. Signed-off-by: H

[PATCH 002/107] staging: comedi: ni_mio_common: open code the M-Series regmap offsets

2015-05-01 Thread H Hartley Sweeten
Remove the enum m_series_register_offsets values that are only used in the lookup tables for the STC to M-Series register mapping and just open code the values. Having the extra level of indirection does not add any additional clarity and it gets rid of some of the CamelCase symbols. Some of the

[PATCH 008/107] staging: comedi: ni_stc.h: simplify MSeries_AI_Config_Bank_Bits()

2015-05-01 Thread H Hartley Sweeten
Simplify this helper function by using a bit-shift to set the high banks select bit. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_stc.h | 6 +- 1 file

[PATCH 005/107] staging: comedi: ni_mio_common: simplify ni_m_series_set_pfi_routing()

2015-05-01 Thread H Hartley Sweeten
This function is overly complex due to the M_Offset_PFI_Output_Select() helper using a 1 based index for the registers and the private data using a 0 based index for the cached values. Modify the M_Offset_PFI_Output_Select() helper to use a 0 based index and remove the sanity check which can

[PATCH 055/107] staging: comedi: ni_stc.h: tidy up AI_DIV_Load_A_Register

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 2 +- drivers/staging/comedi/drivers/ni_stc.h| 4 ++-- 2 files

[PATCH 043/107] staging: comedi: ni_stc.h: tidy up AO_Mode_2_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and convert the enum into defines. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 28

[PATCH 025/107] staging: comedi: ni_stc.h: tidy up NI_M_CDO_MODE_REG bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and convert enums into defines. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 11

[PATCH 007/107] staging: comedi: ni_stc.h: reg_type is not needed by MSeries_AI_Config_Bank_Bits()

2015-05-01 Thread H Hartley Sweeten
This helper function sets the bits in the M_Offset_AI_Config_FIFO_Data register to select the correct bank to configure a given analog output channel. The NI M Series boards are defined by the boardinfo to have 16, 32, or 80 channels. Only 2 of the M Series boards have 80 channels, those boards

[PATCH 030/107] staging: comedi: ni_stc.h: tidy up Interrupt_B_Ack_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 28

[PATCH 016/107] staging: comedi: ni_stc.h: tidy up NI_M_AO_REF_ATTENUATION_REG bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and convert the enum into defines. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 4

[PATCH 009/107] staging: comedi: ni_stc.h: rename M_Offset_* symbols

2015-05-01 Thread H Hartley Sweeten
Renamme these CamelCase symbols. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 129 -

[PATCH 010/107] staging: comedi: ni_stc.h: tidy up NI_M_AI_CFG_FIFO_DATA_REG bits

2015-05-01 Thread H Hartley Sweeten
Rename all the CamelCase and convert the enum and helper functions into defines. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 029/107] staging: comedi: ni_stc.h: tidy up Interrupt_A_Ack_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 37 --

[PATCH 027/107] staging: comedi: ni_stc.h: tidy up NI_M_INTC_STATUS_REG bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and convert enums into defines. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_stc.h | 5 + 1

[PATCH 018/107] staging: comedi: ni_stc.h: tidy up NI_M_PFI_OUT_SEL_REG bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and convert the inline helper functions that set/get the bits in this register to macros. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 023/107] staging: comedi: ni_stc.h: tidy up NI_M_CDI_MODE_REG bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and convert enums into defines. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_stc.h | 27

[PATCH 006/107] staging: comedi: ni_stc.h: tidy up M_Offset_* values

2015-05-01 Thread H Hartley Sweeten
For aesthetics, define the M_Offset_* values instead of using an enum. Convert the inline helpers used to get some of the M-Series register offsets into macros. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman

[PATCH 031/107] staging: comedi: ni_stc.h: tidy up AI_Command_2_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 22 ++--

[PATCH 033/107] staging: comedi: ni_stc.h: tidy up G_Command_Register

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and define the G0 and G1 registers to add clarity to the mio_regmap tables. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 8

[PATCH 022/107] staging: comedi: ni_stc.h: tidy up NI_M_CDIO_CMD_REG bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and convert enums into defines. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 23

[PATCH 077/107] staging: comedi: ni_stc.h: tidy up DIO_Parallel_Input_Register

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 7 +++ drivers/staging/comedi/drivers/ni_stc.h| 2 +- 2 files

[PATCH 050/107] staging: comedi: ni_stc.h: tidy up Interrupt_Control_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 15 ---

[PATCH 015/107] staging: comedi: ni_stc.h: tidy up NI_M_AO_CFG_BANK_REG bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and convert the enum into defines. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 16

[PATCH 036/107] staging: comedi: ni_stc.h: tidy up DIO_Output_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 28 ++

[PATCH 067/107] staging: comedi: ni_stc.h: tidy up RTSI_Trig_[AB]_Output_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Convert the inline helper functions to macros and use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 040/107] staging: comedi: ni_stc.h: tidy up AI_*_Load_[AB]_Registers

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 22 +++--- drivers/staging/comedi/drivers/ni_stc.h|

[PATCH 045/107] staging: comedi: ni_stc.h: tidy up Clock_and_FOUT_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and convert the enum and inline function into defines. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 019/107] staging: comedi: ni_stc.h: tidy up NI_M_PFI_FILTER_REG bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and convert the inline helper functions that set the bits in this register to macros. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 037/107] staging: comedi: ni_stc.h: tidy up DIO_Control_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 46 +-

[PATCH 032/107] staging: comedi: ni_stc.h: tidy up AO_Command_2_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 14 +--

[PATCH 052/107] staging: comedi: ni_stc.h: tidy up Analog_Trigger_Etc_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 7 +++

[PATCH 056/107] staging: comedi: ni_stc.h: tidy up AO_Start_Select_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 6 +++---

[PATCH 035/107] staging: comedi: ni_stc.h: tidy up AO_Command_1_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 38 +++---

[PATCH 054/107] staging: comedi: ni_stc.h: tidy up AI_Trigger_Select_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Tidy up ni_ai_cmd() by using a local var to set the common bits and programming the register in the common code path. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg

[PATCH 038/107] staging: comedi: ni_stc.h: tidy up AI_Mode_1_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 29 +++---

[PATCH 041/107] staging: comedi: ni_stc.h: tidy up G_{Mode, Load, Input}*_Register

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and define he G0 and G1 registers to add clarity to the mio_regmap tables. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 32

[PATCH 021/107] staging: comedi: ni_stc.h: tidy up NI_M_CDIO_STATUS_REG bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and convert enums into defines. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 7

[PATCH 046/107] staging: comedi: ni_mio_common: use 'reg' in ni_set_bitfield()

2015-05-01 Thread H Hartley Sweeten
Use the passed 'reg' parameter to write to the STC registers instead of duplicating the case symbol. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c

[PATCH 062/107] staging: comedi: ni_stc.h: tidy up Second_IRQ_A_Enable_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. The bit defines are identical to NISTC_INTA_ENA_REG. Reuse them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 6 +++---

[PATCH 051/107] staging: comedi: ni_stc.h: tidy up AI_Output_Control_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Tidy up the programming of this register un ni_ai_reset() by using a local variable to set the common bits then writing the register in the common code path. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott

[PATCH 039/107] staging: comedi: ni_stc.h: tidy up AI_Mode_2_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 43 --

[PATCH 070/107] staging: comedi: ni_stc.h: tidy up AO_Output_Control_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Convert the inline helper function into a macro and use the BIT() marco to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 064/107] staging: comedi: ni_stc.h: tidy up Second_IRQ_B_Enable_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. The bit defines are identical to NISTC_INTB_ENA_REG. Reuse them. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 6 +++---

[PATCH 060/107] staging: comedi: ni_stc.h: tidy up Joint_Reset_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 26 --

[PATCH 072/107] staging: comedi: ni_stc.h: tidy up AI_Status_1_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() marco to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 65 +-

[PATCH 049/107] staging: comedi: ni_stc.h: tidy up RTSI_Trig_Direction_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and convert the enum and inline function into defines. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 076/107] staging: comedi: ni_stc.h: tidy up AO_Status_2_Register

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 4 ++-- drivers/staging/comedi/drivers/ni_stc.h| 2 +- 2 files

[PATCH 058/107] staging: comedi: ni_stc.h: tidy up G_Autoincrement_Register

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase and define the G0 and G1 registers to add clarity to the mio_regmap tables. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 8

[PATCH 057/107] staging: comedi: ni_stc.h: tidy up AO_Trigger_Select_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Tidy up the ni_ao_cmd() by using a local var to mask/set the bits then programming the register in the common code path. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg

[PATCH 082/107] staging: comedi: ni_stc.h: tidy up DIO_Serial_Input_Register

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 4 ++-- drivers/staging/comedi/drivers/ni_stc.h| 3 ++- 2 files

[PATCH 074/107] staging: comedi: ni_stc.h: tidy up G_Status_Register

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 4 ++-- drivers/staging/comedi/drivers/ni_stc.h| 3 ++- 2 files

[PATCH 053/107] staging: comedi: ni_stc.h: tidy up AI_START_STOP_Select_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 61 +-

[PATCH 047/107] staging: comedi: ni_stc.h: tidy up IO_Bidirection_Pin_Register

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 10 +- drivers/staging/comedi/drivers/ni_stc.h| 3 ++- 2

[PATCH 001/107] staging: comedi: ni_mio_common: refactor m-series stc register handling

2015-05-01 Thread H Hartley Sweeten
For M-Series boards (devpriv-is_m_series), the STC registers need to be remapped. This is currently handled with some big switch statements to convert the STC register offset to the M-Series offset. Some of the registers also need special handling due to differences in the register size on the

[PATCH 061/107] staging: comedi: ni_stc.h: tidy up Interrupt_A_Enable_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 29 ++--

[PATCH 071/107] staging: comedi: ni_stc.h: tidy up AI_Mode_3_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() marco to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 29 +++---

[PATCH 042/107] staging: comedi: ni_stc.h: tidy up AO_Mode_1_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 35 +-

[PATCH 066/107] staging: comedi: ni_stc.h: tidy up AO_Personal_Register and bits

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Use the BIT() macro to define the bits. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 29 ++--

[PATCH 084/107] staging: comedi: ni_stc.h: tidy up AI_*_Save_Registers

2015-05-01 Thread H Hartley Sweeten
Rename the CamelCase. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/staging/comedi/drivers/ni_mio_common.c | 4 ++-- drivers/staging/comedi/drivers/ni_stc.h| 4 ++-- 2 files

<    1   2