You should have CC'd Mark on these. Use ./scripts/get_maintainer.pl
regards,
dan carpenter
On Thu, Jun 18, 2015 at 01:27:28PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Hari Prasath Gujulan Elango hguju...@visteon.com
The memory allocated in dgnc_tty_register() for two objects
On Thu, Jun 18, 2015 at 03:50:59PM +0200, Peter Karlsson wrote:
Fix checkpatch warnings about lines over 80 characters.
Signed-off-by: Peter Karlsson pe...@zapto.se
---
drivers/staging/ft1000/ft1000-usb/ft1000_hw.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
On Mon, Jun 22, 2015 at 04:58:41PM +0530, Sunil Shahu wrote:
else statement after if is unnecessary, hence removed.
Signed-off-by: Sunil Shahu shsh...@gmail.com
---
drivers/staging/rtl8712/rtl871x_security.c | 35
++
1 file changed, 16 insertions(+), 19
On Thu, Jun 18, 2015 at 12:56:54PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch modifies few debug prints from pr_err() to pr_info() as they
fall under that category.
They should be dbg or removed.
regards,
dan
This patch fixes the following sparse warning:
drivers/staging/comedi/comedi_compat32.c:205:16: warning: cast removes
address space of expression
Signed-off-by: Geliang Tang geliangt...@163.com
---
Changes in v3:
- fix the 80 character line limit.
Changes in v2:
- compat_ptr() is
On Mon, Jun 22, 2015 at 10:43:38AM +0100, Ian Abbott wrote:
Now it removes the call to compat_ptr(), so it won't work. Your first patch
was better, apart from exceeding the 80 character line limit.
Thank you. I revised the patch again.
Geliang Tang (1):
staging: comedi: fix cast warning in
On Thu, Jun 18, 2015 at 03:50:58PM +0200, Peter Karlsson wrote:
@@ -180,7 +180,8 @@ static u16 get_handshake(struct ft1000_usb *ft1000dev,
u16 expected_value)
}
status = ft1000_read_dpram16(ft1000dev,
-
On 22/06/15 16:33, Geliang Tang wrote:
This patch fixes the following sparse warning:
drivers/staging/comedi/comedi_compat32.c:205:16: warning: cast removes
address space of expression
Signed-off-by: Geliang Tang geliangt...@163.com
---
Changes in v3:
- fix the 80 character line limit.
On Thu, Jun 18, 2015 at 02:00:18PM +0530, Sudip Mukherjee wrote:
On Thu, Jun 18, 2015 at 08:31:59AM +0200, Jakub Sitnicki wrote:
--- a/drivers/staging/rtl8188eu/hal/odm.c
+++ b/drivers/staging/rtl8188eu/hal/odm.c
@@ -1170,13 +1170,10 @@ void odm_RSSIMonitorCheckCE(struct odm_dm_struct
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Monday, June 22, 2015 7:14 AM
To: Jake Oshins
Cc: gre...@linuxfoundation.org; KY Srinivasan; linux-
ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
a...@canonical.com;
Remove commented codes.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_wfi_netdevice.c | 21 -
1 file changed, 21 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.c
b/drivers/staging/wilc1000/wilc_wfi_netdevice.c
Remove variable that is defined but never used.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_wfi_netdevice.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.c
b/drivers/staging/wilc1000/wilc_wfi_netdevice.c
Remove multiple blank lines.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_wfi_netdevice.c | 19 ---
1 file changed, 19 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.c
b/drivers/staging/wilc1000/wilc_wfi_netdevice.c
Remove if statement that has no any codes.
Signed-off-by: Chaehyun Lim chaehyun@gmail.com
---
drivers/staging/wilc1000/wilc_wfi_netdevice.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_wfi_netdevice.c
b/drivers/staging/wilc1000/wilc_wfi_netdevice.c
On Mon, 2015-06-22 at 22:12 +0300, Giedrius Statkevičius wrote:
Convert a Microsoft compiler specific directive #pragma pack(1) to a
GCC equivalent __attribute__ ((__packed__)). Also, by doing this we save
ourselves from trouble if any other struct definitions are added after
the #pragma
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch removes a couple of ununsed variable.The lines in which these
variables are assigned are also removed as they are not necessary.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch removes ununsed variable 'ret'.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000/wilc_wlan.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch the removes the redundant assignement of the variable ret as
its being overwritren before being used anywhere.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000/wilc_wlan.c | 2 +-
1
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch removes a unused variable timeout and the associated code.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000/linux_wlan.c | 2 --
1 file changed, 2 deletions(-)
diff --git
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch removes ununsed if..else... code blocks. Its actually some
dead code.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000/coreconfigurator.c | 22 --
1 file changed, 22
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch removes a unused variable 'u16RespLen' that is assigned a
value that is never used. The line that does the assignment is also
removed.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch removes a ununsed variable msg_len and its associated code.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000/wilc_wlan_cfg.c | 6 --
1 file changed, 6 deletions(-)
diff --git
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch removes the ununsed variable 'priv' at multiple instances and
all its associated code where its assigned a value.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch addresses the checkpatch warning advising the usage of the
BIT macro for Bit shift operation.
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000/wilc_wlan_if.h | 4 ++--
1 file changed, 2
From: Abdul Hussain hab...@visteon.com
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Signed-off-by: Abdul Hussain hab...@visteon.com
---
drivers/staging/comedi/drivers/dac02.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff
From: Abdul Hussain hab...@visteon.com
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Signed-off-by: Abdul Hussain hab...@visteon.com
---
drivers/staging/comedi/drivers/ni_daq_dio24.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
From: Abdul Hussain hab...@visteon.com
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Signed-off-by: Abdul Hussain hab...@visteon.com
---
drivers/staging/comedi/drivers/s626.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff
From: Abdul Hussain hab...@visteon.com
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Signed-off-by: Abdul Hussain hab...@visteon.com
---
drivers/staging/comedi/drivers/daqboard2000.c | 8 ++--
1 file changed, 2 insertions(+), 6
From: Abdul Hussain hab...@visteon.com
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Signed-off-by: Abdul Hussain hab...@visteon.com
---
drivers/staging/comedi/drivers/fl512.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff
From: Abdul Hussain hab...@visteon.com
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Signed-off-by: Abdul Hussain hab...@visteon.com
---
drivers/staging/comedi/drivers/dmm32at.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff
On Friday 19 June 2015 07:38 PM, Sudip Mukherjee wrote:
On Fri, Jun 19, 2015 at 06:00:06AM +, Abdul, Hussain (H.) wrote:
From: Abdul Hussain hab...@visteon.com
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Signed-off-by: Abdul Hussain
fixes checkpatch.pl WARNING: quoted string split across lines
+MODULE_AUTHOR(David A. Schleef d...@schleef.org,
+ Frank Mori Hess fmh...@users.sourceforge.net);
Modules with multiple authors have a MODULE_AUTHOR line for each one.
Signed-off-by: Luis de Bethencourt
On Mon, Jun 22, 2015 at 10:37:43AM +0100, Ian Abbott wrote:
On 21/06/15 11:01, Santosh wrote:
This patch fixes the checkpatch.pl warning:
WARNING: ENOSYS means 'invalid syscall nr' and nothing else
Regards,
Santosh Pai
0001-staging-Comedi-comedi_fops-Fixed-the-return-error-co.patch
On Sat, Jun 20, 2015 at 12:06:16PM -0700, Joseph Kogut wrote:
Kernel coding style dictates that pointer declarations
have the asterisk next to the data name.
Signed-off-by: Joseph Kogut joseph.ko...@gmail.com
---
drivers/staging/i2o/iop.c | 6 +++---
1 file changed, 3 insertions(+), 3
Umm.. you have to fix more than one error if there's more than one
error on or very near the same line you are already fixing, else
checkpatch.pl complains that your patch has errors. Not to mention
Greg KH has never complained:
else statement after if is unnecessary, hence removed.
Signed-off-by: Sunil Shahu shsh...@gmail.com
---
drivers/staging/rtl8712/rtl871x_security.c | 35 ++
1 file changed, 16 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_security.c
On Tue, Jun 16, 2015 at 06:06:43AM -0700, Greg KH wrote:
This shows you are doing something really wrong here, why not just fix
the function type to be a real pointer to a real structure?
You are right, of course.
Or even better, just remove the parameter as I don't think they are
even used.
On 21/06/15 11:01, Santosh wrote:
This patch fixes the checkpatch.pl warning:
WARNING: ENOSYS means 'invalid syscall nr' and nothing else
Regards,
Santosh Pai
0001-staging-Comedi-comedi_fops-Fixed-the-return-error-co.patch
Greg doesn't usually take patches in attachments.
From
On Sat, Jun 20, 2015 at 03:56:08PM -0500, Greg Donald wrote:
Fix checkpatch.pl space required before the open parenthesis '(' errors
Signed-off-by: Greg Donald gdon...@gmail.com
---
.../staging/rtl8192u/ieee80211/rtl819x_HTProc.c| 97
++
1 file changed, 44
On Sun, Jun 21, 2015 at 01:29:50PM +0200, Peter Karlsson wrote:
Fixed alignment to 8 bytes per line.
Signed-off-by: Peter Karlsson pe...@zapto.se
---
drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git
On 20/06/15 21:14, Luis de Bethencourt wrote:
fixes checkpatch.pl WARNING: quoted string split across lines
+MODULE_AUTHOR(David A. Schleef d...@schleef.org,
+ Frank Mori Hess fmh...@users.sourceforge.net);
total: 0 errors, 1 warnings, 114 lines checked
Modules with multiple
On 22/06/15 07:10, Abdul, Hussain (H.) wrote:
This patch simplify a trivial if-return sequence. Possibly combine with
a preceding function call.
Abdul Hussain (6):
staging: comedi: dmm32at: Simplify a trivial if-return sequence
staging: comedi: fl512: Simplify a trivial if-return
This silences the warning but really the warnings indicate real bugs
which need to be fixed. Silencing these warnings makes the bugs harder
to find so it is a step in the wrong direction.
Change SendConfigPkt() so that drvHandler is a pointer.
regards,
dan carpenter
Signed-off-by: zack.chang zector1...@gmail.com
---
drivers/staging/android/ion/ion_chunk_heap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/android/ion/ion_chunk_heap.c
b/drivers/staging/android/ion/ion_chunk_heap.c
index 5474615..0813163 100644
---
On 20/06/15 15:38, Geliang Tang wrote:
This patch fixes the following sparse warning:
drivers/staging/comedi/comedi_compat32.c:205:16: warning: cast removes
address space of expression
Signed-off-by: Geliang Tang geliangt...@163.com
---
Changes in v2:
- compat_ptr() is substituted by
On 06/22, zack.chang wrote:
Nice, however there is to little information in the commit message of
wha exactly has been fixed. I assume it is 'line over 80 chars', right?
and this information shoule be wrien there.
thanks
- konrad
Signed-off-by: zack.chang zector1...@gmail.com
---
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch removes unused variables as reported by cppcheck
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/sm750fb/ddk750_chip.c | 3 +--
drivers/staging/sm750fb/ddk750_mode.c | 3 +--
Convert a Microsoft compiler specific directive #pragma pack(1) to a
GCC equivalent __attribute__ ((__packed__)). Also, by doing this we save
ourselves from trouble if any other struct definitions are added after
the #pragma because it will be applied to all of the definitions
following it.
--- a/drivers/staging/comedi/drivers/daqboard2000.c
+++ b/drivers/staging/comedi/drivers/daqboard2000.c
@@ -713,12 +713,8 @@ static int daqboard2000_auto_attach(struct comedi_device
*dev,
return result;
s = dev-subdevices[2];
- result = subdev_8255_init(dev, s,
On Fri, Jun 19, 2015 at 05:50:50PM -0700, Juston Li wrote:
void sii164ClearInterrupt(void)
{
-unsigned char detectReg;
+ unsigned char detectReg;
-/* Clear the MDI interrupt */
-detectReg = i2cReadReg(SII164_I2C_ADDRESS, SII164_DETECT);
-
On Mon, Jun 22, 2015 at 10:46 AM, Dan Carpenter
dan.carpen...@oracle.com wrote:
On Fri, Jun 19, 2015 at 05:50:50PM -0700, Juston Li wrote:
void sii164ClearInterrupt(void)
{
-unsigned char detectReg;
+ unsigned char detectReg;
-/* Clear the MDI interrupt */
-detectReg =
On Mon, Jun 22, 2015 at 05:27:03PM +, Simmons, James A. wrote:
Is this change a hard requirement? Currently the lustre code standard in our
development tree is the opposite policy.
Please follow the kernel coding style rules.
___
devel mailing
Joglekar, Tejas (T.) tjogl...@visteon.com writes:
From: Joglekar Tejas tjogl...@visteon.com
This patch removes the trailing whitespace error given
by checkpatch.pl
Signed-off-by: Joglekar Tejas tjogl...@visteon.com
---
drivers/staging/rtl8723au/hal/odm.c | 2 +-
1 file changed, 1
On Mon, Jun 22, 2015 at 07:06:49PM +0530, Sudip Mukherjee wrote:
On Mon, Jun 22, 2015 at 03:02:37PM +0200, Peter Karlsson wrote:
On 2015-06-22 06:29, Sudip Mukherjee wrote:
which tree have you been using?
Greg will have three staging tree, use staging-testing
I have used linux-next
On Mon, Jun 22, 2015 at 12:46:26PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
On Mon, Jun 22, 2015 at 06:12:11PM +0530, Sudip Mukherjee wrote:
On Mon, Jun 22, 2015 at 07:05:04AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Hari Prasath Gujulan Elango hguju...@visteon.com
On Mon, Jun 22, 2015 at 07:05:04AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch removes ununsed variable 'ret'.
ret or len? :)
regards
sudip
___
devel mailing list
On Mon, Jun 22, 2015 at 06:12:11PM +0530, Sudip Mukherjee wrote:
On Mon, Jun 22, 2015 at 07:05:04AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch removes ununsed variable 'ret'.
ret or len? :)
regards
sudip
On Mon, Jun 22, 2015 at 03:02:37PM +0200, Peter Karlsson wrote:
On 2015-06-22 06:29, Sudip Mukherjee wrote:
which tree have you been using?
Greg will have three staging tree, use staging-testing
I have used linux-next tree :/
well, I am now confused why linux-next is not having this
From: Hari Prasath Gujulan Elango hguju...@visteon.com
This patch removes ununsed variable 'len'
Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com
---
drivers/staging/wilc1000/wilc_wlan.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
Fix coding style error by placing spaces around '=' as suggested by
checkpatch.pl script.
Signed-off-by: Sunil Shahu shsh...@gmail.com
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wilc1000/host_interface.c
Small bug fixes and cleanups. Please re-indent
pci_devices_present_work() especially.
On Wed, Jun 17, 2015 at 05:14:58PM +, ja...@microsoft.com wrote:
From: Jake Oshins ja...@microsoft.com
This patch supplies a new driver, hv_pcifront, which exposes new root PCI
buses. When a Hyper-V
61 matches
Mail list logo
