Re: [PATCH] Alternate rtl8192cu driver.

2015-07-08 Thread Dan Carpenter
On Wed, Jul 08, 2015 at 12:10:15PM +0200, P. Varet wrote: On 08/07/15 11:14, Dan Carpenter wrote: This is a useless kind of statement because the bug is so jumbled up. I know! Honestly, I did not really understand the question in the first place, seeing as the bug is still open. I'm sure

[PATCH 33/37] usb: isp1760: udc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/isp1760/isp1760-udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/isp1760/isp1760-udc.c b/drivers/usb/isp1760/isp1760-udc.c index

[PATCH 31/37] usb: gadget: s3c2410_udc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/s3c2410_udc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/usb/gadget/udc/s3c2410_udc.c b/drivers/usb/gadget/udc/s3c2410_udc.c

[PATCH 30/37] usb: gadget: s3c-hsudc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/s3c-hsudc.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/usb/gadget/udc/s3c-hsudc.c b/drivers/usb/gadget/udc/s3c-hsudc.c index

[PATCH 29/37] usb: gadget: r8a66597-udc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/r8a66597-udc.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/usb/gadget/udc/r8a66597-udc.c b/drivers/usb/gadget/udc/r8a66597-udc.c

[PATCH 28/37] usb: gadget: pxa27x_udc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/pxa27x_udc.h | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/drivers/usb/gadget/udc/pxa27x_udc.h

[PATCH] Staging: ozwpan: ozusbsvc1.c: Fix missing blank line after declarations

2015-07-08 Thread Johannes Postma
This patch fixes a missing line after declarations issue. Signed-off-by: Johannes Postma jgmpos...@gmail.com --- drivers/staging/ozwpan/ozusbsvc1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/ozwpan/ozusbsvc1.c b/drivers/staging/ozwpan/ozusbsvc1.c index 301fee8..b6cfecb

[PATCH 23/37] usb: gadget: net2272: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/net2272.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c index

[PATCH 26/37] usb: gadget: pch_ud: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/pch_udc.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/pch_udc.c

[PATCH 27/37] usb: gadget: pxa25x_udc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/pxa25x_udc.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/usb/gadget/udc/pxa25x_udc.c

[PATCH 22/37] usb: gadget: mv_udc_core: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/mv_udc_core.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/gadget/udc/mv_udc_core.c b/drivers/usb/gadget/udc/mv_udc_core.c index

[PATCH 20/37] usb: gadget: m66592-udc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/m66592-udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/m66592-udc.c b/drivers/usb/gadget/udc/m66592-udc.c index

[PATCH 19/37] usb: gadget: lpc32xx_udc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/lpc32xx_udc.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/usb/gadget/udc/lpc32xx_udc.c

[PATCH 24/37] usb: gadget: net2280: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/net2280.c | 50 ++-- 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/drivers/usb/gadget/udc/net2280.c

[PATCH 21/37] usb: gadget: mv_u3d_core: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/mv_u3d_core.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/gadget/udc/mv_u3d_core.c b/drivers/usb/gadget/udc/mv_u3d_core.c index

[PATCH 25/37] usb: gadget: omap_udc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/omap_udc.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/usb/gadget/udc/omap_udc.c b/drivers/usb/gadget/udc/omap_udc.c

[PATCH 34/37] usb: musb: gadget: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/musb/musb_gadget.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c index

[PATCH 36/37] usb: gadget: atmel_usba_udc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/atmel_usba_udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c

[PATCH 37/37] usb: gadget: epautoconf: add endpoint capabilities flags verification

2015-07-08 Thread Robert Baldyga
Introduce endpoint matching mechanism basing on endpoint capabilities flags. We check if endpoint supports transfer type and direction requested in ep descriptor. Since we have this new endpoint matching mechanism there is no need to have old code guessing endpoint capabilities basing on its name,

[PATCH 35/37] usb: renesas: gadget: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/renesas_usbhs/mod_gadget.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/usb/renesas_usbhs/mod_gadget.c b/drivers/usb/renesas_usbhs/mod_gadget.c

Re: [PATCH v2 1/5] usb: gadget: ffs: call functionfs_unbind() if _ffs_func_bind() fails

2015-07-08 Thread Sergei Shtylyov
Hello. On 7/8/2015 12:05 PM, Robert Baldyga wrote: Function ffs_do_functionfs_bind() calls functionfs_bind() which allocates usb request and increments refcounts. These things needs to be cleaned up by if further steps of initialization fail by calling functionfs_unbind(). Signed-off-by:

[PATCH 01/37] usb: gadget: encapsulate endpoint claiming mechanism

2015-07-08 Thread Robert Baldyga
So far it was necessary for usb functions to set ep-driver_data in endpoint obtained from autoconfig to non-null value, to indicate that endpoint is claimed by function (in autoconfig it was checked if endpoint has set this field to non-null value, and if it has, it was assumed that it is

[PATCH 00/37] usb: gadget: rework ep matching and claiming mechanism

2015-07-08 Thread Robert Baldyga
Hello, This patch series reworks endpoint matching and claiming mechanism in epautoconf. The patch (1) introduces new safer endpoint claiming method, basing on new 'claimed' flag. It was discussed here [1]. I proposed this solution over year ago and it was accepted, but apparently I forgot to

[PATCH 04/37] staging: emxx_udc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Fixed typo in epc-nulk to epc-bulk. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/staging/emxx_udc/emxx_udc.c | 60 ++--- 1 file changed, 29 insertions(+), 31 deletions(-) diff --git

[PATCH 03/37] usb: gadget: add endpoint capabilities helper macros

2015-07-08 Thread Robert Baldyga
Add macros useful while initializing array of endpoint capabilities structures. These macros makes structure initialization more compact to decrease number of code lines and increase readability of code. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- include/linux/usb/gadget.h | 20

[PATCH 09/37] usb: gadget: at91_udc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/at91_udc.c | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/drivers/usb/gadget/udc/at91_udc.c

[PATCH 08/37] usb: gadget: amd5536udc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/amd5536udc.c | 57 ++--- 1 file changed, 47 insertions(+), 10 deletions(-) diff --git a/drivers/usb/gadget/udc/amd5536udc.c

[PATCH 06/37] usb: dwc2: gadget: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/dwc2/gadget.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c index 4d47b7c..8771b66 100644 ---

[PATCH 05/37] usb: chipidea: udc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/chipidea/udc.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 764f668..eff7cfb 100644

[PATCH 07/37] usb: dwc3: gadget: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/dwc3/gadget.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 333a7c0..8d1f768 100644 ---

Re: Clarification for the use of additional fields in the message body

2015-07-08 Thread Julian Calaby
Hi Markus, On Wed, Jul 8, 2015 at 7:28 PM, SF Markus Elfring elfr...@users.sourceforge.net wrote: If it's harmless, then no, but in this case, people are questioning why you're adding it as it adds no value Some Git software developers care to keep the information complete for the author

[PATCH 15/37] usb: gadget: fsl_udc_core: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/fsl_udc_core.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c

[PATCH 17/37] usb: gadget: goku_udc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/goku_udc.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/usb/gadget/udc/goku_udc.c b/drivers/usb/gadget/udc/goku_udc.c index

[PATCH 16/37] usb: gadget: fusb300_udc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/fusb300_udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/fusb300_udc.c b/drivers/usb/gadget/udc/fusb300_udc.c

[PATCH 12/37] usb: gadget: dummy-hcd: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/dummy_hcd.c | 65 +- 1 file changed, 50 insertions(+), 15 deletions(-) diff --git a/drivers/usb/gadget/udc/dummy_hcd.c

[PATCH 14/37] usb: gadget: fsl_qe_udc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/fsl_qe_udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c b/drivers/usb/gadget/udc/fsl_qe_udc.c index

[PATCH 02/37] usb: gadget: add endpoint capabilities flags

2015-07-08 Thread Robert Baldyga
Introduce struct usb_ep_caps which contains information about capabilities of usb endpoints - supported transfer types and directions. This structure should be filled by UDC driver for each of its endpoints, and will be used in epautoconf in new ep matching mechanism which will replace ugly

[PATCH 11/37] usb: gadget: bdc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/bdc/bdc_ep.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/usb/gadget/udc/bdc/bdc_ep.c b/drivers/usb/gadget/udc/bdc/bdc_ep.c index

[PATCH 10/37] usb: gadget: bcm63xx_udc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/bcm63xx_udc.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/udc/bcm63xx_udc.c

[PATCH 13/37] usb: gadget: fotg210-udc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/fotg210-udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/fotg210-udc.c b/drivers/usb/gadget/udc/fotg210-udc.c

[PATCH 18/37] usb: gadget: gr_udc: add ep capabilities support

2015-07-08 Thread Robert Baldyga
Convert endpoint configuration to new capabilities model. Signed-off-by: Robert Baldyga r.bald...@samsung.com --- drivers/usb/gadget/udc/gr_udc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c index

[PATCH v2 4/5] staging: emxx_udc: add missing usb_ep_set_maxpacket_limit()

2015-07-08 Thread Robert Baldyga
Since maxpacket_limit was introduced all UDC drivers should use usb_ep_set_maxpacket_limit() function instead of setting maxpacket value manually. ep.maxpacket_limit contains actual maximum maxpacket value supported by hardware which is needed by epautoconf. Signed-off-by: Robert Baldyga

[PATCH v2 5/5] usb: gadget: atmel_usba_udc: add missing ret value check

2015-07-08 Thread Robert Baldyga
Add missing return value check. In case of error print debug message and return error code. Signed-off-by: Robert Baldyga r.bald...@samsung.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- drivers/usb/gadget/udc/atmel_usba_udc.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [PATCH 18/20] staging/lustre/libcfs: get rid of debugfs/lnet/debug_mb

2015-07-08 Thread Dan Carpenter
On Mon, Jul 06, 2015 at 12:48:56PM -0400, gr...@linuxhacker.ru wrote: +static int libcfs_param_debug_mb_set(const char *val, + const struct kernel_param *kp) +{ + int rc; + unsigned num; + + rc = kstrtouint(val, 0, num); + if (rc == -EINVAL)

Re: [PATCH] Alternate rtl8192cu driver.

2015-07-08 Thread Dan Carpenter
Also it would really help if you could test this on a 32 bit system. If we knew this is 32 vs 64 bit bug that would help. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 1/5] usb: gadget: ffs: call functionfs_unbind() if _ffs_func_bind() fails

2015-07-08 Thread Dan Carpenter
On Tue, Jul 07, 2015 at 06:00:27PM +0200, Robert Baldyga wrote: Decrement is done in ffs_func_unbind() which is not called in this error path. Oh. Duh. I got functionfs_unbind() and ffs_func_unbind() mixed up. Sorry. regards, dan carpenter ___

Re: [PATCH 5/5] usb: gadget: atmel_usba_udc: add missing ret value check

2015-07-08 Thread Nicolas Ferre
Le 07/07/2015 16:02, Robert Baldyga a écrit : Add missing return value check. In case of error print debug message and return error code. Signed-off-by: Robert Baldyga r.bald...@samsung.com Yes, it's indeed missing: Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Thanks, bye. ---

Re: [PATCH 15/20] staging/lustre/libcfs: get rid of debugfs/lnet/console_backoff

2015-07-08 Thread Dan Carpenter
On Mon, Jul 06, 2015 at 12:48:53PM -0400, gr...@linuxhacker.ru wrote: +static int param_set_uint_minmax(const char *val, + const struct kernel_param *kp, + unsigned int min, unsigned int max) +{ + unsigned int num; + int ret;

Re: staging: wilc1000: One function call less in mac_ioctl() after error detection

2015-07-08 Thread SF Markus Elfring
The kfree() function was called in two cases by the mac_ioctl() function during error handling even if the passed variable did not contain a pointer for a valid data item. * This implementation detail could be improved by the introduction of another jump label. * Drop an unnecessary

Re: Clarification for the use of additional fields in the message body

2015-07-08 Thread SF Markus Elfring
If it's harmless, then no, but in this case, people are questioning why you're adding it as it adds no value Some Git software developers care to keep the information complete for the author commit. to anyone and makes it look like you don't know what you're doing. I specify message field

Re: [RESEND] mfd: rtsx: add support for rts522A

2015-07-08 Thread Lee Jones
On Wed, 08 Jul 2015, 敬锐 wrote: On 07/07/2015 07:46 PM, Lee Jones wrote: On Mon, 29 Jun 2015, micky_ch...@realsil.com.cn wrote: From: Micky Ching micky_ch...@realsil.com.cn rts522a(rts5227s) is derived from rts5227, and mainly same with rts5227. Add it to file mfd/rts5227.c to

Re: [PATCH 15/20] staging/lustre/libcfs: get rid of debugfs/lnet/console_backoff

2015-07-08 Thread Dan Carpenter
Of course, this is not a critical flaw. Don't resend. Fix it later if you want. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 1/5] usb: gadget: ffs: call functionfs_unbind() if _ffs_func_bind() fails

2015-07-08 Thread Robert Baldyga
Function ffs_do_functionfs_bind() calls functionfs_bind() which allocates usb request and increments refcounts. These things needs to be cleaned up by if further steps of initialization fail by calling functionfs_unbind(). Signed-off-by: Robert Baldyga r.bald...@samsung.com ---

[PATCH v2 3/5] usb: isp1760: udc: add missing usb_ep_set_maxpacket_limit()

2015-07-08 Thread Robert Baldyga
Since maxpacket_limit was introduced all UDC drivers should use usb_ep_set_maxpacket_limit() function instead of setting maxpacket value manually. ep.maxpacket_limit contains actual maximum maxpacket value supported by hardware which is needed by epautoconf. Signed-off-by: Robert Baldyga

Re: [PATCH] Alternate rtl8192cu driver.

2015-07-08 Thread Dan Carpenter
On Tue, Jul 07, 2015 at 11:37:55PM +0200, P. Varet wrote: On 07/07/15 11:54, Dan Carpenter wrote: https://bugzilla.kernel.org/show_bug.cgi?id=57171 This bug is a confusing mix of issues and it seems to be fixed. Just use network manager. Hi Dan! Thank you for your reply! I gave it

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

2015-07-08 Thread Martyn Welch
On 06/07/15 18:24, Dmitry Kalinkin wrote: Some functionality was dropped as it was not good practice (such as receiving VME interrupts in user space, it's not really doable if the slave card is Release On Register Access rather than Release on Acknowledge), Didn't know about RORA. I wonder

Re: [PATCH v2 5/5] usb: gadget: atmel_usba_udc: add missing ret value check

2015-07-08 Thread Michal Nazarewicz
On Wed, Jul 08 2015, Robert Baldyga wrote: Add missing return value check. In case of error print debug message and return error code. Signed-off-by: Robert Baldyga r.bald...@samsung.com Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Acked-by: Michal Nazarewicz min...@mina86.com ---

Re: [PATCH v2 4/5] staging: emxx_udc: add missing usb_ep_set_maxpacket_limit()

2015-07-08 Thread Michal Nazarewicz
On Wed, Jul 08 2015, Robert Baldyga wrote: Since maxpacket_limit was introduced all UDC drivers should use usb_ep_set_maxpacket_limit() function instead of setting maxpacket value manually. ep.maxpacket_limit contains actual maximum maxpacket value supported by hardware which is needed by

[PATCH] staging: lustre: remove dead code

2015-07-08 Thread Gujulan Elango, Hari Prasath (H.)
From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch removes commented code. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/lustre/lustre/osc/osc_cache.c | 6 -- 1 file changed, 6 deletions(-) diff --git

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

2015-07-08 Thread Martyn Welch
On 07/07/15 08:08, Alessio Igor Bogani wrote: I would be glad to try it if the maintainer is willing to receive this type of changes. Such requirements have come up in the past. I'd welcome such support being contributed to the kernel. My view has been that such an API could be built on top

Re: [PATCH v2 2/5] usb: gadget: midi: avoid redundant f_midi_set_alt() call

2015-07-08 Thread Michal Nazarewicz
On Wed, Jul 08 2015, Robert Baldyga wrote: Function midi registers two interfaces with single set_alt() function which means that f_midi_set_alt() is called twice when configuration is set. That means that endpoint initialization and ep request allocation is done two times. To avoid this

Re: [PATCH 15/20] staging/lustre/libcfs: get rid of debugfs/lnet/console_backoff

2015-07-08 Thread Oleg Drokin
On Jul 8, 2015, at 4:28 AM, Dan Carpenter wrote: On Mon, Jul 06, 2015 at 12:48:53PM -0400, gr...@linuxhacker.ru wrote: +static int param_set_uint_minmax(const char *val, + const struct kernel_param *kp, + unsigned int min, unsigned int

Re: [PATCH v2 1/5] usb: gadget: ffs: call functionfs_unbind() if _ffs_func_bind() fails

2015-07-08 Thread Michal Nazarewicz
On Wed, Jul 08 2015, Robert Baldyga wrote: Function ffs_do_functionfs_bind() calls functionfs_bind() which allocates usb request and increments refcounts. These things needs to be cleaned up by if further steps of initialization fail by calling functionfs_unbind(). Signed-off-by: Robert

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

2015-07-08 Thread Martyn Welch
On 07/07/15 13:51, Alessio Igor Bogani wrote: Current VME stack links windows not to the boards, but to device drivers. Driver could potentially minimise window usage within it’s scope (any sort of window reusing, like mapping whole A16 once to be used with all boards), but this won’t work

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

2015-07-08 Thread Martyn Welch
On 07/07/15 11:52, Dmitry Kalinkin wrote: The API I had in mind would have only vme_master_read and vme_master_write that would take absolute addresses (not relative to any window). These variants of access functions would then try to reuse any window that is already able to serve the request

Re: [PATCH v2 3/5] usb: isp1760: udc: add missing usb_ep_set_maxpacket_limit()

2015-07-08 Thread Michal Nazarewicz
On Wed, Jul 08 2015, Robert Baldyga wrote: Since maxpacket_limit was introduced all UDC drivers should use usb_ep_set_maxpacket_limit() function instead of setting maxpacket value manually. ep.maxpacket_limit contains actual maximum maxpacket value supported by hardware which is needed by

Re: Clarification for the use of additional fields in the message body

2015-07-08 Thread SF Markus Elfring
Is there truly no way to simplify that process? I see some software development possibilities which could improve the communication with high volume mailing lists. You should be sending the patches directly with SMTP using git-send-email, This tool is also fine for the publishing of a lot of

[PATCH] vme: lower alignment requirement in pci bridge drivers

2015-07-08 Thread Dmitry Kalinkin
Universe II allows PCI address grannularity of 4K or 64K depending on the window id. tsi148 only supports 64K. Existing driver implementations are validating window size against this grannularity and then use that very size as alignment parameter to pci_bus_alloc_resource. This constraint is

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

2015-07-08 Thread Dmitry Kalinkin
On 08 Jul 2015, at 16:57, Martyn Welch martyn.we...@ge.com wrote: On 07/07/15 11:52, Dmitry Kalinkin wrote: The API I had in mind would have only vme_master_read and vme_master_write that would take absolute addresses (not relative to any window). These variants of access functions

Re: Clarification for the use of additional fields in the message body

2015-07-08 Thread SF Markus Elfring
Note also that some maintainers have work flow that deliberately smash the date (i.e., because they are using a system such as guilt), so if you are depending on the submitted timestamp, it's going to break on you. Thanks for your hint. I am just trying to offer the possibility for the reuse

Re: [PATCHv3 08/16] staging: vme_user: provide DMA functionality

2015-07-08 Thread Dmitry Kalinkin
On 08 Jul 2015, at 16:41, Martyn Welch martyn.we...@ge.com wrote: On 07/07/15 13:51, Alessio Igor Bogani wrote: Current VME stack links windows not to the boards, but to device drivers. Driver could potentially minimise window usage within it’s scope (any sort of window reusing, like

Generic VME UIO driver

2015-07-08 Thread Dmitry Kalinkin
On 08 Jul 2015, at 16:22, Martyn Welch martyn.we...@ge.com wrote: On 06/07/15 18:24, Dmitry Kalinkin wrote: Some functionality was dropped as it was not good practice (such as receiving VME interrupts in user space, it's not really doable if the slave card is Release On Register Access

Re: Clarification for the use of additional fields in the message body

2015-07-08 Thread Theodore Ts'o
On Wed, Jul 08, 2015 at 09:05:53PM +1000, Julian Calaby wrote: If multiple people are submitting identical changes, then the one that is applied is the one the maintainer sees first, which will most likely be determined by which one hit their inbox / list first. Nobody is going to look at

interested in growing sales?

2015-07-08 Thread Roy
Hey, We can help you to grow business fast. We provide target email marketing services and can generate you more business and leads. We are looking for long term cooperation which can increase your business sales 2-4 times than now. Please reply back so i can go over options for you. Thanks,

Re: [PATCH v2] staging: lustre: make ptlrpc_init static

2015-07-08 Thread Matt Mooney
fix sparse warning in lustre/ptlrpc/ptlrpc_module.c:54:12: warning: symbol 'ptlrpc_init' was not declared. Should it be static? The __init macro is moved before the function name to match standard usage. Signed-off-by: Matt Mooney m...@muteddisk.com ---

Re: Clarification for the use of additional fields in the message body

2015-07-08 Thread Julian Calaby
Hi Markus, On Wed, Jul 8, 2015 at 5:09 PM, SF Markus Elfring elfr...@users.sourceforge.net wrote: There's a file in the documentation directory of the kernel tree describing submitting patches and email client setup. Read them both, I read this information several times. do what they say

Re: [PATCH] defines modified to match the 80-char rule

2015-07-08 Thread Joe Perches
On Mon, 2015-07-06 at 14:16 +0200, Krzysztof Hałasa wrote: Joe Perches j...@perches.com writes: So, could we have the localized readability when it makes sense, and the default rules when nothing else applies? Then the question becomes how local. The answer seems easy to me: as much

Re: [PATCH] Alternate rtl8192cu driver.

2015-07-08 Thread Greg KH
On Wed, Jul 08, 2015 at 12:10:15PM +0200, P. Varet wrote: And Greg KH wrote: That's as supported as anything is with Linux :) Kind of dispiriting... but so it goes. Why? That's better than you will get from any other operating system, where you don't have access to the developers who

Re: Clarification for the use of additional fields in the message body

2015-07-08 Thread SF Markus Elfring
There's a file in the documentation directory of the kernel tree describing submitting patches and email client setup. Read them both, I read this information several times. do what they say without anything extra. Do you see any special consequences if a bit of extra functionality is

Re: [PATCH] STAGING SUBSYSTEM rtl8188eu driver : Fixed 80 character length warning in rtw_ap.c

2015-07-08 Thread Sudip Mukherjee
On Tue, Jul 07, 2015 at 09:27:58PM -0400, Sreenath Madasu wrote: When the checkpatch.pl script was run, it showed lines with length more than 80 characters in rtw_ap.c file. Fixed line number 382 by breaking it up into two lines within 80 characters. Greg told you to fix the subject, its still

[PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue

2015-07-08 Thread rcodin
From: Ronit Halder ronit@gmail.com Fixed a coding style issue. Signed-off-by: Ronit Halder ronit@gmail.com --- drivers/staging/android/ion/ion.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index

Re: [PATCH net-next,v2] hv_netvsc: Add support to set MTU reservation from guest side

2015-07-08 Thread David Miller
From: Haiyang Zhang haiya...@microsoft.com Date: Mon, 6 Jul 2015 14:11:37 -0700 When packet encapsulation is in use, the MTU needs to be reduced for headroom reservation. The existing code takes the updated MTU value only from the host side. But vSwitch extensions, such as Open vSwitch,

[PATCH v3] staging: rtl8188eu: core: Fixed 80 character length warning

2015-07-08 Thread Sreenath Madasu
When the checkpatch.pl script was run, it showed lines with length more than 80 characters in rtw_ap.c file. Fixed line number 382 by breaking it up into two lines within 80 characters. Signed-off-by: Sreenath Madasu sreenath.mad...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_ap.c | 3 ++-

Re: Clarification for the use of additional fields in the message body

2015-07-08 Thread Julian Calaby
Hi Markus, On Wed, Jul 8, 2015 at 11:46 PM, SF Markus Elfring elfr...@users.sourceforge.net wrote: Is there truly no way to simplify that process? I see some software development possibilities which could improve the communication with high volume mailing lists. You shouldn't need any

Re: [PATCH 28/37] usb: gadget: pxa27x_udc: add ep capabilities support

2015-07-08 Thread Robert Jarzmik
Robert Baldyga r.bald...@samsung.com writes: Convert endpoint configuration to new capabilities model. The commit message is very short to judge the patch's correctness. I'll side up with Felipe's opinion. If it's fine by him, so it is by me. Cheers. -- Robert

Re: [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue

2015-07-08 Thread Sudip Mukherjee
On Thu, Jul 09, 2015 at 08:20:57AM +0530, rcodin wrote: From: Ronit Halder ronit@gmail.com You do not need a From: here. Please fix your gitconfig file and git send-email will give your name correctly in the email header. regards sudip ___ devel

Re: [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue

2015-07-08 Thread Ronit Halder
On Thu, 2015-07-09 at 11:05 +0530, Sudip Mukherjee wrote: On Thu, Jul 09, 2015 at 08:20:57AM +0530, rcodin wrote: From: Ronit Halder ronit@gmail.com You do not need a From: here. Please fix your gitconfig file and git send-email will give your name correctly in the email header.