[PATCH] Fix script/checkpatch.pl coding style issus.

2015-07-09 Thread Incarnation P. Lee
--- drivers/staging/lustre/lustre/obdclass/cl_page.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c b/drivers/staging/lustre/lustre/obdclass/cl_page.c index a7f3032..428c6b2 100644 ---

[PATCH] Fix script/checkpatch.pl coding style issus.

2015-07-09 Thread Incarnation P. Lee
--- drivers/staging/lustre/lustre/obdclass/cl_page.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c b/drivers/staging/lustre/lustre/obdclass/cl_page.c index a7f3032..428c6b2 100644 ---

Re: Clarification for the use of additional fields in the message body

2015-07-09 Thread Theodore Ts'o
On Wed, Jul 08, 2015 at 05:27:38PM +0200, SF Markus Elfring wrote: Note also that some maintainers have work flow that deliberately smash the date (i.e., because they are using a system such as guilt), so if you are depending on the submitted timestamp, it's going to break on you.

[PATCH 13/13] staging: unisys: Allow visorbus to autoload

2015-07-09 Thread Benjamin Romer
From: David Kershner david.kersh...@unisys.com We inadvertently remove the MODULE_DEVICE_TABLE line for visorbus, this patch adds it back in. Signed-off-by: David Kershner david.kersh...@unisys.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com ---

[PATCH 08/13] staging: unisys: visornic: correctly clean up device on removal

2015-07-09 Thread Benjamin Romer
From: Tim Sell timothy.s...@unisys.com visornic_remove() is called to logically detach the visornic driver from a visorbus-supplied device, which can happen either just prior to a visorbus-supplied device disappearing, or as a result of an rmmod of visornic. Prior to this patch, logic was

[PATCH 11/13] staging: unisys: visornic: use preferred interface for setting netdev's parent

2015-07-09 Thread Benjamin Romer
From: Tim Sell timothy.s...@unisys.com Just switch this line so it uses the correct function call. Signed-off-by: Tim Sell timothy.s...@unisys.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/visornic/visornic_main.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH 06/13] staging: unisys: add error messages to visornic

2015-07-09 Thread Benjamin Romer
From: Tim Sell timothy.s...@unisys.com Add error message to genuine rare error paths, and debug messages to enable relatively non-verbose tracing of code paths You can enable debug messages by including this on the kernel command line: visornic.dyndbg=+p or by this from the command line:

[PATCH 10/13] staging: unisys: visornic: delay start of worker thread until netdev created

2015-07-09 Thread Benjamin Romer
From: Tim Sell timothy.s...@unisys.com This only makes sense, since the worker thread depends upon the netdev existing. Signed-off-by: Tim Sell timothy.s...@unisys.com Signed-off-by: Benjamin Romer benjamin.ro...@unisys.com --- drivers/staging/unisys/visornic/visornic_main.c | 15

[PATCH 05/13] staging: unisys: neglect to NULL rcvbuf pointer

2015-07-09 Thread Benjamin Romer
From: Tim Sell timothy.s...@unisys.com Neglect to NULL rcvbuf pointer array could result in faults later This problem would exhibit itself as a fault when when attempting to stop any visornic device (i.e., in visornic_disable_with_timeout() or visornic_serverdown_complete()) that had never been

[PATCH 00/13] staging: unisys: visorbus and visornic fixes

2015-07-09 Thread Benjamin Romer
This patch set contains fixes for visorbus and visornic, and adds appropriate error messages to the visornic driver. David Kershner (1): staging: unisys: Allow visorbus to autoload Tim Sell (12): staging: unisys: respond to msgs post device_create staging: unisys: prevent faults processing

[PATCH 01/13] staging: unisys: respond to msgs post device_create

2015-07-09 Thread Benjamin Romer
From: Tim Sell timothy.s...@unisys.com Fix problem that prevents us from responding to any device message after device_create. By neglecting to NULL out pending_msg_hdr after the device_create response, we were effectively preventing any subsequent messages to the device from working, because

[PATCH] staging: unisys: Fix broken build when ARCH=um

2015-07-09 Thread Benjamin Romer
From: Ken Cox j...@redhat.com When building with ARCH=um you get the following error: arch/x86/include/asm/cpufeature.h:252:42: error: 'REQUIRED_MASK0' undeclared The Unisys drivers should not be compiled for UML, so this patch addresses that by adding a dependency to kconfig for !UML.

[PATCH 12/13] staging: unisys: visornic: prevent erroneous kfree of devdata pointer

2015-07-09 Thread Benjamin Romer
From: Tim Sell timothy.s...@unisys.com A struct visornic_devdata for each visornic device is actually allocated as part of alloc_etherdev(), here in visornic_probe(): netdev = alloc_etherdev(sizeof(struct visornic_devdata)); But code in devdata_release() was treating devdata as a pointer

[PATCH 04/13] staging: unisys: prevent faults in visornic_pause

2015-07-09 Thread Benjamin Romer
From: Tim Sell timothy.s...@unisys.com Prevent faults in visornic_pause, visornic_resume(), and visornic_remove() Prior to this patch, any call to visornic_pause(), visornic_resume(), or visornic_remove() would fault, due to dev_set_drvdata() never having been called to stash our struct

[PATCH 03/13] staging: unisys: visornic: correct visornic_pause

2015-07-09 Thread Benjamin Romer
From: Tim Sell timothy.s...@unisys.com Correct visornic_pause() to indicate completion asynchronously rather than in-line Previously, visornic_pause() (called to stop the device due to IOVM service partition recovery) was calling the passed complete_func() in-line, rather than delaying the

[PATCH 02/13] staging: unisys: prevent faults processing messages

2015-07-09 Thread Benjamin Romer
From: Tim Sell timothy.s...@unisys.com Prevent faults processing messages for devices that no driver has yet registered to handle. Previously, code of the form: drv = to_visor_driver(dev-device.driver); if (!drv) goto away; was not having the desired intent, because

[PATCH 07/13] staging: unisys: visornic: correct obvious double-allocation of workqueues

2015-07-09 Thread Benjamin Romer
From: Tim Sell timothy.s...@unisys.com Looks like an errant patch fitting caused us to redundantly allocate the workqueues at both the beginning and end of visornic_init(). This was corrected by removing the allocations at the beginning. Signed-off-by: Tim Sell timothy.s...@unisys.com

[PATCH 09/13] staging: unisys: visornic: don't destroy global workqueues until devs destroyed

2015-07-09 Thread Benjamin Romer
From: Tim Sell timothy.s...@unisys.com visornic_cleanup() was previously incorrectly destroying its global workqueues prior to cleaning up the devices which used them. This patch corrects the order of these operations. Signed-off-by: Tim Sell timothy.s...@unisys.com Signed-off-by: Benjamin

Re: [PATCH] Staging: sm750fb: ddk750_dvi.h: Fix brace coding style issue

2015-07-09 Thread Sudip Mukherjee
On Thu, Jul 09, 2015 at 02:45:22PM +0200, anders.fridl...@gmail.com wrote: From: Anders Fridlund anders.fridl...@gmail.com same comment that I gave to your another patch. No need to mention this From: here. Please fix your .gitconfig so that git send-email will put your name in the email From:

[PATCH 4/5] staging: wilc1000: SendConfigPkt(): replace integer with void pointer

2015-07-09 Thread Johnny Kim
This patch replaces a integer argument of SendConfigPkt function with void type pointer and fix code that the function is called. Because tstrWILC_WFIDrv structure is defined after SendConfigPkt function is defined, the function can not refer to the structure type. So this patch change the

[PATCH 5/5] staging: wilc1000: change variable of limited 32bit size to pointer

2015-07-09 Thread Johnny Kim
gu8FlushedJoinReqDrvHandler variable is be using to save structure pointer. But because that is restricted to 32bit and has needless casting, the varibale should be changed to pointer of same type. Signed-off-by: Johnny Kim johnny@atmel.com --- drivers/staging/wilc1000/host_interface.c | 16

Re: [PATCH] staging:lustre: fix space required after that ', ' error in cl_page.c

2015-07-09 Thread Sudip Mukherjee
On Thu, Jul 09, 2015 at 11:02:09AM +0200, anders.fridl...@gmail.com wrote: From: Anders Fridlund anders.fridl...@gmail.com No need to mention this From: here. Please fix your .gitconfig so that git send-email will put your name in the email From: header. regards sudip

Re: [PATCH] staging: style fix for octeon/ethernet-tx.c

2015-07-09 Thread Sudip Mukherjee
On Thu, Jul 09, 2015 at 08:46:04PM -0400, Jacob Kiefer wrote: From: Jacob Kiefer jt...@cornell.edu No need to mention this From: as it will come from the email header. Style fix for octeon/ethernet-tx.c Please mention which style you have fixed. regards sudip

[PATCH] staging: style fix for octeon/ethernet-tx.c

2015-07-09 Thread Jacob Kiefer
Broke line with greater than 80 characters into two lines and improved logical operator readability in hardware checksum if statement. Signed-off-by: Jacob Kiefer jt...@cornell.edu --- drivers/staging/octeon/ethernet-tx.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff

[PATCH 1/3] staging: wilc1000: wilc_wlan_cfg_commit(): replace integer with pointer

2015-07-09 Thread Johnny Kim
A argument of wilc_wlan_cfg_commit() is address of structure. But because the size is restricted to 32bit, it is not correct for 64bit machine. So, this changes the interger value to obvious structure pointer. Signed-off-by: Johnny Kim johnny@atmel.com ---

[PATCH 2/3] staging: wilc1000: wilc_wlan_cfg_get(): replace integer with void pointer

2015-07-09 Thread Johnny Kim
Last argument of wilc_wlan_cfg_get function is actually structure's address. This should be changed to be compatible with 64bit machine. Because wilc_wlan_cfg_get function is mapped by function pointer later, wilc_wlan_oup_t.wlan_cfg_get should be changed together. tstrWILC_WFIDrv structure is

[PATCH 0/3] staging: wilc1000: rework integer value for x64

2015-07-09 Thread Johnny Kim
Hello Greg. This driver convert pointer address to integer value and use it as function argument. because the value has a limited 32bit size, current driver happen many issues on x64 machine. I have split it up enough sensibliy to allow review. If this patches are accepted, I will update more

[PATCH 3/3] staging: wilc1000: wilc_wlan_cfg_set(): replace integer with void pointer

2015-07-09 Thread Johnny Kim
Last argument of wilc_wlan_cfg_set function is actually structure's address. This should be changed to be compatible with 64bit machine. Because wilc_wlan_cfg_set function is mapped by function pointer later, wilc_wlan_oup_t.wlan_cfg_set should be changed together. tstrWILC_WFIDrv structure is

[PATCH] staging: style fix for octeon/ethernet-tx.c

2015-07-09 Thread Jacob Kiefer
From: Jacob Kiefer jt...@cornell.edu Style fix for octeon/ethernet-tx.c Signed-off-by: Jacob Kiefer jt...@cornell.edu --- drivers/staging/octeon/ethernet-tx.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/octeon/ethernet-tx.c

[PATCH v2] Staging: android: ion: fixed a blank line after declarations coding style issue

2015-07-09 Thread Ronit Halder
Fixed a coding style issue. Signed-off-by: Ronit Halder ronit@gmail.com --- drivers/staging/android/ion/ion.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 6f48112..e44f5e6 100644 ---

Re: [PATCH v2] Staging: android: ion: fixed a blank line after declarations coding style issue

2015-07-09 Thread Sudip Mukherjee
On Thu, Jul 09, 2015 at 11:39:11AM +0530, Ronit Halder wrote: Fixed a coding style issue. Signed-off-by: Ronit Halder ronit@gmail.com Greg has commented in your v1 that it is a false positive. See that: #define DEFINE_DMA_BUF_EXPORT_INFO(a) \ struct dma_buf_export_info a = {

Re: [PATCH] Staging: android: ion: fixed a blank line after declarations coding style issue

2015-07-09 Thread Greg KH
On Thu, Jul 09, 2015 at 08:20:57AM +0530, rcodin wrote: From: Ronit Halder ronit@gmail.com Fixed a coding style issue. Signed-off-by: Ronit Halder ronit@gmail.com --- drivers/staging/android/ion/ion.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH] staging: xgifb: prefer using the BIT macro

2015-07-09 Thread Gujulan Elango, Hari Prasath (H.)
From: Hari Prasath Gujulan Elango hguju...@visteon.com This patch uses the BIT macro for bit shift operation. Signed-off-by: Hari Prasath Gujulan Elango hguju...@visteon.com --- drivers/staging/xgifb/XGI_main_26.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] staging:lustre: fix space required after that ', ' error in cl_page.c

2015-07-09 Thread anders . fridlund
From: Anders Fridlund anders.fridl...@gmail.com This is a patch to the cl_page.c file that fixes a space required after that ',' error found by the checkpatch.pl tool. Signed-off-by: Anders Fridlund anders.fridl...@gmail.com --- drivers/staging/lustre/lustre/obdclass/cl_page.c | 2 +- 1 file

[PATCH] Staging: sm750fb: ddk750_dvi.h: Fix brace coding style issue

2015-07-09 Thread anders . fridlund
From: Anders Fridlund anders.fridl...@gmail.com This is a patch to the ddk750_dvi.h file that fixes up a brace error found by the checkpatch.pl tool Signed-off-by: Anders Fridlund anders.fridl...@gmail.com --- drivers/staging/sm750fb/ddk750_dvi.h | 3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH] Fix script/checkpatch.pl coding style issus.

2015-07-09 Thread Greg KH
On Thu, Jul 09, 2015 at 12:57:56AM +0800, Incarnation P. Lee wrote: --- drivers/staging/lustre/lustre/obdclass/cl_page.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/cl_page.c