[PATCH] staging: wlan-ng: prism2fw: coding style: Fixed too long lines.

This is a patch to the prism2fw.c file that fixes too long lines. Signed-off-by: Marcos Canán --- drivers/staging/wlan-ng/prism2fw.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2fw.c

Re: [PATCH RESEND 01/16] staging: rtl8188eu: rtw_mlme_ext.c: reorder the report functions

On 09/15/2015 11:43 AM, Luca Ceresoli wrote: Dear Larry, Larry Finger wrote: BTW, if a do a change not related to checkpatch warnings, say I remove unneeded typecasts, and the change has impact on long lines which are still long after the change, should I also wrap code to fit 80 chars _in

Re: [PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches

On 2015년 09월 15일 22:46, Greg KH wrote: On Tue, Sep 15, 2015 at 05:26:35PM +0900, Tony Cho wrote: On 2015년 09월 15일 16:13, Sudip Mukherjee wrote: On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote: From: Glen Lee g_num_total_switches is never used so just delete

[PATCH v2 01/10] staging: wilc1000: remove PANDA_BOARD

This patch removes one of the platform dependencies, PANDA_BOARD from the driver codes. The device tree will provide the platform dependencies in the future commits. Signed-off-by: Tony Cho Signed-off-by: Glen Lee ---

[PATCH v2 03/10] staging: wilc1000: remove unnecessary define FIVE_GHZ_BAND

From: Glen Lee wilc1000 driver does not support five Ghz band. Remove FIVE_GHZ_BAND and it's related code. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 6 -- 1 file changed, 6

[PATCH v2 09/10] staging: wilc1000: coreconfigurator.h: remove unused defines

From: Glen Lee The define MAX_PACKET_BUFF_SIZE and STATUS_MSG_LEN is not used in the driver. Delete two defines. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.h | 3 --- 1 file

[PATCH v2 10/10] staging: wilc1000: remove unused variable g_flushing_in_progress

From: Glen Lee g_flushing_in_progress is never used so just delete it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v2 04/10] staging: wilc1000: remove unused defines

From: Glen Lee This patch removes follwing unused defines. MAX_CFG_PKTLEN MSG_HEADER_LEN QUERY_MSG_TYPE WRITE_MSG_TYPE RESP_MSG_TYPE WRITE_RESP_SUCCESS INVALID MAC_ADDR_LEN Signed-off-by: Glen Lee Signed-off-by: Tony Cho ---

[PATCH v2 06/10] staging: wilc1000: delete unused global variables.

From: Glen Lee gstrConfigPktInfo, SemHandleSendPkt and SemHandlePktResp are never used in the drivers. So just delete the variables and it's related code. Signed-off-by: Glen Lee Signed-off-by: Tony Cho ---

[PATCH v2 05/10] staging: wilc1000: remove unnecessary extern function declaration

From: Glen Lee Function NetworkInfoReceived, GnrlAsyncInfoReceived and host_int_ScanCompleteReceived are declared in the header file already. Just removes the declaration and comments. Signed-off-by: Glen Lee Signed-off-by: Tony Cho

[PATCH v2 07/10] staging: wilc1000: remove unused variables

From: Glen Lee Variable g_num_total_switches is never used so just remove it. gastrWIDs is also not used because g_num_total_switches is deleted. Remove gastrWIDs also. Signed-off-by: Glen Lee Signed-off-by: Tony Cho ---

[PATCH v2 08/10] staging: wilc1000: delete function declaration SendRawPacket

From: Glen Lee SendRawpacket is declared but not implemented. It is not used also. So just delete it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.h | 1 - 1 file changed, 1

Re: [PATCH] staging: wlan-ng: prism2fw: coding style: Fixed too long lines.

On Tue, Sep 15, 2015 at 08:09:54PM -0300, Marcos Canán wrote: > This is a patch to the prism2fw.c file that fixes > too long lines. > > Signed-off-by: Marcos Canán > --- This will not apply because of cfa6954ced97 ("staging: wlan-ng: fix long line"). Which tree you have used?

Re: [PATCH] staging: wilc1000: Removed curly braces

On Tue, Sep 15, 2015 at 07:24:00PM +0530, Aparna Karuthodi wrote: > Removed the curly braces of a single statement if block to remove a > coding style warning detected by checkpatch. > The warning is given below: > WARNING: braces {} are not necessary for single statement blocks > >

Re: [PATCH 17/19] staging/lustre: Remove IS_SERVER and all users

On Tue, Sep 15, 2015 at 08:30:41PM -0400, gr...@linuxhacker.ru wrote: > From: Oleg Drokin > > Since the client can never be server, this is all dead code. > > Signed-off-by: Oleg Drokin > --- OOPS.. build fails with error: error: ‘lsi’ undeclared

RE: [PATCH v2 00/12] New paravirtual PCI front-end for Hyper-V VMs

> -Original Message- > From: Marc Zyngier [mailto:marc.zyng...@arm.com] > Sent: Tuesday, September 15, 2015 2:57 AM > To: Jake Oshins ; gre...@linuxfoundation.org; KY > Srinivasan ; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org;

Re: [PATCH 2/2] staging: wilc1000: remove RX_BH_TYPE

Hi Greg, If it's already in your tree and can be applied alone, no problem to me. I will later send remaining series of it. Thanks, Tony. On 2015년 09월 15일 22:31, Greg KH wrote: On Tue, Sep 15, 2015 at 10:17:41AM +0900, Tony Cho wrote: Hi Greg, I am sorry but please ignore this patch in

RE: [PATCH v2 06/12] drivers:hv: Export do_hypercall()

> > --- > > @@ -91,7 +91,7 @@ static int query_hypervisor_info(void) > > /* > > * do_hypercall- Invoke the specified hypercall > > */ > > -static u64 do_hypercall(u64 control, void *input, void *output) > > +u64 do_hypercall(u64 control, void *input, void *output) > > do_hypercall() is not

[PATCH 0/5] Drivers: hv: Miscellaneous fixes

The Copy-VMFile cmdlet on the host may fail because the guest fcopy driver state machine gets out of sync. This happens because the ->state and ->context variables are accessed by the main thread and from interrupt context. If an interrupt happens between fcopy_respond_to_host and hv_poll_channel

[PATCH 0/3] Drivers: hv: vmbus: Support PCI Express pass-through driver

The patch set for supporting PCI Express pass through on Hyper-V has been posted and is currently under review. These vmbus patches are needed for the PCI Express pass through driver. Since these need to go through Greg's tree, I am posting these separately here. Jake Oshins (3): drivers:hv:

[PATCH 1/3] drivers:hv: Export a function that maps Linux CPU num onto Hyper-V proc num

From: Jake Oshins This patch exposes the mapping between Linux CPU number and Hyper-V virtual processor number. This is necessary because the hypervisor needs to know which virtual processors to target when making a mapping in the Interrupt Redirection Table in the I/O MMU.

[PATCH 2/3] drivers:hv: Export the API to invoke a hypercall on Hyper-V

From: Jake Oshins This patch exposes the function that hv_vmbus.ko uses to make hypercalls. This is necessary for retargeting an interrupt when it is given a new affinity. Since we are exporting this API, rename the API as it will be visible outside the hv.c file.

[PATCH 3/3] drivers:hv: Define the channel type for Hyper-V PCI Express pass-through

From: Jake Oshins This defines the channel type for PCI front-ends in Hyper-V VMs. Signed-off-by: Jake Oshins Signed-off-by: K. Y. Srinivasan --- include/linux/hyperv.h | 11 +++ 1 files changed, 11 insertions(+), 0

[PATCH v2 00/10] resend all of wilc1000 patches

This series of patches are being resent becasue it seems that we are out of sync with Greg. In this series, I squashed two commits seperately issued for removing variable, g_num_total_switches which is not used anymore to avoid more confusions. Glen Lee (9): staging: wilc1000: remove useless

[PATCH v2 02/10] staging: wilc1000: remove useless define PHY_802_11n

From: Glen Lee The define PHY_802_11n is useless because wilc1000 support 802.11n as always. Remove PHY_802_11n and it related code. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 5

[PATCH 5/5] hv: vss: use wrappers to propagate state

From: Olaf Hering The "state" is used by several threads of execution. Propagate the state to make changes visible. Also propagate context change in vss_on_msg. Signed-off-by: Olaf Hering Signed-off-by: K. Y. Srinivasan ---

[PATCH 1/5] Drivers: hv: vmbus: fix init_vp_index() for reloading hv_netvsc

From: Dexuan Cui This fixes the recent commit 3b71107d73b16074afa7658f3f0fcf837aabfe24: Drivers: hv: vmbus: Further improve CPU affiliation logic Without the fix, reloading hv_netvsc hangs the guest. Signed-off-by: Dexuan Cui Signed-off-by: K. Y.

[PATCH 2/5] hv: add helpers to handle hv_util device state

From: Olaf Hering The callbacks in kvp, vss and fcopy code are called both from the main thread as well as from interrupt context. If a state change is done by the main thread it is not immediately seen by the interrupt. As a result the state machine gets out of sync. Force

[PATCH 4/5] hv: kvp: use wrappers to propaigate state

From: Olaf Hering The "state" is used by several threads of execution. Propagate the state to make changes visible. Also propagate context change in kvp_on_msg. Signed-off-by: Olaf Hering Signed-off-by: K. Y. Srinivasan ---

[PATCH 16/19] staging/lustre: remove obd_memory stats counter

From: Oleg Drokin Now that we no longer track allocated memory, remove obd_memory statistics counter and all references to it everywhere Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/obd_support.h| 7 ---

[PATCH 07/19] staging/lustre: Remove references to OBD_ALLOC/FREE* in comments

From: Oleg Drokin Since everything is now supposed to use regular kernel alloc and free functions. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_lib.h | 2 +- drivers/staging/lustre/lustre/include/lustre_net.h | 2 +-

[PATCH 14/19] staging/lustre: Remove memory allocation fault injection framework

From: Oleg Drokin Lustre memory allocation wrappers also included a fault injection framework that's totally redundant, since in-kernel offering is actually superior to what we had. So let's remove it. Signed-off-by: Oleg Drokin ---

[PATCH 19/19] staging/lustre: Remove server defines from lustre_disk.h

From: Oleg Drokin Take initial stab at removing server-disk related defines that client does not need. Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/include/lustre_disk.h| 137 -

[PATCH 15/19] staging/lustre: Remove lustre used memory tracking framework

From: Oleg Drokin Lustre memory allocation framework has a feature to track amount of allocated memory, but since it's not being used consistently anymore and is on the way out in general, just remove it. Signed-off-by: Oleg Drokin ---

[PATCH 05/19] staging/lustre/llite: Get rid of OBD_ALLOC/FREE_PTR

From: Oleg Drokin The remaining users in ll_open_cleanup and obd_mod_alloc are converted to regular kzalloc/kfree. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/obd.h | 4 ++--

[PATCH 10/19] staging/lustre/ptlrpc: Replace OBD_FREE_PTR with kfree

From: Oleg Drokin Part of effort of getting rid of custom Lustre alloc/free macros Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrpc/ptlrpc_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 02/19] staging/lustre: Remove unused OBD_VMALLOC

From: Oleg Drokin These macros are not used anymore, so let's remove them, also __OBD_VMALLOC_VEROBSE and OBD_CPT_VMALLOC Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/include/obd_support.h| 29 -- 1 file changed,

[PATCH 08/19] staging/lustre/fld: Replace OBD_ALLOC_GFP with kzalloc

From: Oleg Drokin Part of effort to get rid of custom Lustre allocation macros. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/fld/fld_cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 00/19] Lustre cleanups

From: Oleg Drokin This bunch of patches removes significant chunks of Lustre specific allocators which is possible thanks to prior patches from Julia Lawall. Also removed are some server-only bits of code that make no sense to retain in a client. Please consider. Oleg

[PATCH 17/19] staging/lustre: Remove IS_SERVER and all users

From: Oleg Drokin Since the client can never be server, this is all dead code. Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/include/lustre_disk.h| 2 - drivers/staging/lustre/lustre/mgc/mgc_request.c| 37 ++

[PATCH 11/19] staging/lustre: Replace last users of OBD_ALLOC/FREE_LARGE

From: Oleg Drokin OBD_ALLOC_LARGE is now replaced with libcfs_kvzalloc and OBD_FREE_LARGE is now replaced with kvfree. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_lib.h | 2 +-

[PATCH 06/19] staging/lustre/obdclass: replace OBD_ALLOC_GFP with kzalloc

From: Oleg Drokin Part of getting rid of custom Lustre allocation macros. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/obdclass/cl_page.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 12/19] staging/lustre: Remove stray bit of userland utils code

From: Oleg Drokin The UTILS are userland and I see it's causing confusion with things being already converted to kmalloc, so just remove it. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/obd_support.h | 18 --

[PATCH 13/19] staging/lustre: Remove unused OBD_ALLOC* and OBD_FREE macros

From: Oleg Drokin This removes now unused OBD_ALLOC, OBD_ALLOC_GFP, OBD_ALLOC_PTR, OBD_ALLOC_LARGE and supporting infrastructure. Also OBD_FREE, OBD_FREE_PTR, OBD_FREE_LARGE and supporting infrastructure. Signed-off-by: Oleg Drokin ---

[PATCH 01/19] staging/lustre: Remove OBD_CPT_ALLOC_LARGE

From: Oleg Drokin Remove OBD_CPT_ALLOC_LARGE define and convert the only user to libcfs_kvzalloc_cpt. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/obd_support.h | 5 - drivers/staging/lustre/lustre/ptlrpc/service.c

[PATCH 09/19] staging/lustre: Convert lustre_cfg_new/free to use kzalloc/kfree

From: Oleg Drokin Part of effort of getting rid of custom Lustre allocation macros Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_cfg.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 03/19] staging/lustre: Remove unused OBD_CPT_ALLOC* macros

From: Oleg Drokin OBD_CPT_ALLOC and friends are no longer used, so remove them. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/obd_support.h | 9 - 1 file changed, 9 deletions(-) diff --git

Re: [PATCH 01/13] staging: wilc1000: replace WILC_ERRORREPORT with return

On Tue, Sep 15, 2015 at 10:27:04AM +0300, Mike Rapoport wrote: > On Tue, Sep 15, 2015 at 10:47:57AM +0530, Sudip Mukherjee wrote: > > On Mon, Sep 14, 2015 at 10:00:43PM +0300, Mike Rapoport wrote: > > > In cases where WILC_ERRORREPORT does not require cleanup actions, but > > > causes immediate

[patch] staging: wilc1000: off by one in get_handler_from_id()

The > should be >= here or we read beyond the end of the array. Fixes: d42ab0838d04 ('staging: wilc1000: use id value as argument') Signed-off-by: Dan Carpenter diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index

Re: [PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches

On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote: > From: Glen Lee > > g_num_total_switches is never used so just delete it. > > Signed-off-by: Glen Lee > Signed-off-by: Tony Cho > --- you only deleted from the .h file but it

Re: [PATCH 0/7] remove wilc_errorsupport.h from the wilc driver

On 2015년 09월 15일 15:27, Sudip Mukherjee wrote: On Tue, Sep 15, 2015 at 11:53:34AM +0900, Tony Cho wrote: This patch aims to remove the wilc_errorsupport.h which is unnecessary in the wilc driver. This patch replaces the error types defined by wilc driver with kernel generic error types and

Re: [PATCH 2/4] staging: wilc1000: delete function declaration SendRawPacket

On Tue, Sep 15, 2015 at 02:33:55PM +0900, Tony Cho wrote: > From: Glen Lee > > SendRawpacket is declared but not implemented. It is not used also. > So just delete it. > > Signed-off-by: Glen Lee > Signed-off-by: Tony Cho > --- Still

Re: [PATCH 01/13] staging: wilc1000: replace WILC_ERRORREPORT with return

On Tue, Sep 15, 2015 at 10:47:57AM +0530, Sudip Mukherjee wrote: > On Mon, Sep 14, 2015 at 10:00:43PM +0300, Mike Rapoport wrote: > > In cases where WILC_ERRORREPORT does not require cleanup actions, but > > causes immediate return from the function it can be replaced with return > > statement. >

[PATCH 2/2] Staging: wilc1000: fix NULL comparison style

Fixed NULL comparison style as suggested by checkpatch.pl with --strict option. Signed-off-by: Ronit halder --- drivers/staging/wilc1000/coreconfigurator.c | 2 +- drivers/staging/wilc1000/linux_wlan.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff

[PATCH v2 00/11] staging: wilc1000: remove WILC_CATCH and friends

Hi, These patches replace usage of WILC_ERRORREPORT, WILC_ERRORCHECK, WILC_NULLCHECK and WILC_CATCH by plain code that either returns the error value or sets the error code and uses goto to jump to error handling code. v2: - rearrange patches so that they will not introduce compile warnings

[PATCH v2 10/11] staging: wilc1000: host_interface: refactor error handling

Use error value assignment and goto instead of WILC_ERRORREPORT and WILC_CATCH. Signed-off-by: Mike Rapoport --- drivers/staging/wilc1000/host_interface.c | 93 +-- 1 file changed, 52 insertions(+), 41 deletions(-) diff --git

[PATCH v2 04/11] staging: wilc1000: wilc_mq_send: refactor allocation errors handling

In case the first allocation fails, we can return directly, and if the second allocation fails we can goto to the end of the function where we free the memory and return error. Signed-off-by: Mike Rapoport --- drivers/staging/wilc1000/wilc_msgqueue.c | 21

[PATCH v2 02/11] staging: wilc1000: reduce WILC_{ERRORREPORT, CATCH} usage

In cases when WILC_ERRORREPORT is immidiately followed by WILC_CATCH, no goto is actually performed and therefore WILC_ERRORREPORT may be replaced with either printout or assignment of the error value, and WILC_CATCH may be completely removed. Signed-off-by: Mike Rapoport

[PATCH v2 06/11] staging: wilc1000: remove usage of WILC_ERRORCHECK

The WILC_ERRORCHECK macro is replaced with printout or direct call to return statement, together with removal of several WILC_CATCH accompaniyng WILC_ERRORCHECK. Signed-off-by: Mike Rapoport --- drivers/staging/wilc1000/host_interface.c | 6 ++

[PATCH v2 09/11] staging: wilc1000: hif_ger_cfg: refactor error handling

Check whether the driver is initialized before getting the semaphore thus eliminating the need for WILC_ERRORREPORT and WILC_CATCH constructs and s32Error variable. Signed-off-by: Mike Rapoport --- drivers/staging/wilc1000/host_interface.c | 13 + 1 file

Re: [PATCH] staging/rtl8192u: remove unused function

Le 14/09/15 à 14:25, Raphaël Beamonte a écrit : > Not sure the commit message is really clear. Something like this seems > more clean to me: > "Remove unused function N_DBPSOfRate. This function was only > used by function ComputeTxTime that was removed in a previous > commit." Indeed, is more

Re: [PATCH v2 00/12] New paravirtual PCI front-end for Hyper-V VMs

On 14/09/15 18:59, Jake Oshins wrote: >> -Original Message- >> From: Marc Zyngier [mailto:marc.zyng...@arm.com] >> Sent: Monday, September 14, 2015 8:01 AM >> To: Jake Oshins ; gre...@linuxfoundation.org; KY >> Srinivasan ;

[PATCH] Staging: most: aim-network: Replace pr_info with netdev_info

Use netdev_* family of macros when there is reference to a network device. dev->name is removed as netdev_info will print the device name Signed-off-by: Shraddha Barke --- drivers/staging/most/aim-network/networking.c | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH v2 01/11] staging: wilc1000: replace WILC_ERRORREPORT with return

In cases where WILC_ERRORREPORT does not require cleanup actions, but causes immediate return from the function it can be replaced with return statement. Signed-off-by: Mike Rapoport --- drivers/staging/wilc1000/coreconfigurator.c | 3 +-

[PATCH v2 05/11] staging: wilc1000: replace WILC_NULLCHECK with return

WILC_NULLPTR can be replaced with test for NULL pointer and return of WILC_NULL_PTR. Signed-off-by: Mike Rapoport --- drivers/staging/wilc1000/host_interface.c | 8 +++ drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 26 +++ 2 files

[PATCH v2 08/11] staging: wilc1000: Handle_Scan: refactor error handling

In case SendConfigPkt fails, the error handling code performs deletion of timer, calls Handle_ScanDone and falls through freeing of allocated memory which is common for both success and error paths. The deletion of timer and invocation of Handle_ScanDone can be performed in 'then' clause of check

[PATCH v2 11/11] staging: wilc1000: wilc_errorsupport: remove unused macros

The macros WILC_IS_ERR, WILC_ERRORCHECK, WILC_ERRORREPORT, WILC_NULLCHECK and WILC_CATCH are not used and may be removed. Signed-off-by: Mike Rapoport --- drivers/staging/wilc1000/wilc_errorsupport.h | 27 --- 1 file changed, 27 deletions(-)

[PATCH v2 07/11] staging: wilc1000: Handle_CfgParam: refactor error handling

Use plain goto instead of WILC_ERRORREPORT Signed-off-by: Mike Rapoport --- drivers/staging/wilc1000/host_interface.c | 42 +++ 1 file changed, 20 insertions(+), 22 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c

Re: [PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches

On 2015년 09월 15일 16:13, Sudip Mukherjee wrote: On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote: From: Glen Lee g_num_total_switches is never used so just delete it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho ---

[PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

This patch fixes the warning generated by sparse "Using plain integer as NULL pointer" by using NULL instead of zero. Signed-off-by: Ronit halder --- v2: added a new patch in this patch series to fix the NULL comparison style drivers/staging/wilc1000/coreconfigurator.c |

[PATCH] staging/rtl8192u: remove unused function

Remove unused function N_DBPSOfRate. This function was only used by function ComputeTxTime that was removed in the previous commit 742728f97a99 ("staging: rtl8192u: remove unused function.") Signed-off-by: Nicolas Joseph ---

Re: [patch] staging: wilc1000: off by one in get_handler_from_id()

Hello Dan. On 2015년 09월 15일 15:54, Dan Carpenter wrote: The > should be >= here or we read beyond the end of the array. You are right. :) Thanks a lot. Johnny. Fixes: d42ab0838d04 ('staging: wilc1000: use id value as argument') Signed-off-by: Dan Carpenter diff

Re: [PATCH RESEND 01/16] staging: rtl8188eu: rtw_mlme_ext.c: reorder the report functions

Dear Larry, Larry Finger wrote: On 09/14/2015 05:34 PM, Luca Ceresoli wrote: Dear Larry, All, Luca Ceresoli wrote: Dear Larry, thanks for your review. Larry Finger wrote: On 08/28/2015 03:45 PM, Luca Ceresoli wrote: Some of the report_*() functions are internal and will be declared

[PATCH 1/6] staging: rtl8723au: Simplify eeprom content checking

From: Jes Sorensen This eliminates the ugly Hal_EEValueCheck() function Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 42 ++- 1 file changed, 11 insertions(+), 31 deletions(-) diff

[PATCH 6/6] staging: rtl8723au: Clean up getPowerBase()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c

[PATCH 2/6] staging: rtl8723au: Eliminate dummy ccxPowerIndexCheck()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c

[PATCH 4/6] staging: rtl8723au: Tidy up SetTxPowerLevel8723A()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c | 27 +++-- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c

[PATCH 0/6] staging: rtl8723au: Clean ups

From: Jes Sorensen Hi, Reading through some of the rate setup code, I was forced to clean up some of the components to be able to read it properly. Cheers, Jes Jes Sorensen (6): staging: rtl8723au: Simplify eeprom content checking staging: rtl8723au: Eliminate

[PATCH 5/6] staging: rtl8723au: TurboScanOff is always true

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c | 32 + 1 file changed, 11 insertions(+), 21 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c

[PATCH 3/6] staging: rtl8723au: Fold getTxPowerIndex() into PHY_SetTxPowerLevel8723A()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c | 46 ++--- 1 file changed, 19 insertions(+), 27 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_phycfg.c

Re: [PATCH v2 01/11] staging: wilc1000: replace WILC_ERRORREPORT with return

On Tue, Sep 15, 2015 at 06:57:37AM -0700, Greg Kroah-Hartman wrote: > On Tue, Sep 15, 2015 at 01:07:06PM +0300, Mike Rapoport wrote: > > if ((pstrNetworkInfo == NULL) > > || (pstrWFIDrv->strWILC_UsrScanReq.pfUserScanResult == > > NULL)) { > > -

[PATCH] staging: fsl-mc: up-rev version of MC interface code

The DPAA2 management complex has a versioned binary interface that has to be kept in sync with the DPAA2 drivers. This patch uprevs the APIs that build MC commands and parse results. This uprev is needed to support object interrupts. MC binary interface changes -overall version from 6.0 to 8.0

[PATCH] IB/hfi1: fix sdma_descq_cnt parameter parsing

The boolean tests should have been or-ed. Reported-by: David Binderman Reviewed-by: Jubin John Signed-off-by: Mike Marciniszyn --- drivers/staging/rdma/hfi1/sdma.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[patch] IB/hfi1: fix copy_to/from_user() error handling

copy_to/from_user() returns the number of bytes which we were not able to copy. It doesn't return an error code. Also a couple places had a printk() on error and I removed that because people can take advantage of it to fill /var/log/messages with spam. Signed-off-by: Dan Carpenter

[PATCH] staging: rtl8192e: fix memory leak

If the size of the firmware is not as expected then we are jumping to the error path but we missed releasing the firmware. Signed-off-by: Sudip Mukherjee --- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 2/7] staging: wilc1000: remove definition WILC_NULLCHECK

On Tue, Sep 15, 2015 at 11:53:36AM +0900, Tony Cho wrote: > From: Leo Kim > > This patch removes the definition WILC_NULLCHECK which is not used anymore. No, it is used, you just remove all usages of it in this patch as well :) Also, your fixes are not correct, you are not

Re: [PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches

On Tue, Sep 15, 2015 at 05:26:35PM +0900, Tony Cho wrote: > > > On 2015년 09월 15일 16:13, Sudip Mukherjee wrote: > >On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote: > >>From: Glen Lee > >> > >>g_num_total_switches is never used so just delete it. > >> >

Re: [PATCH v2 1/2] Staging: wilc1000: Use NULL instead of zero

On Tue, Sep 15, 2015 at 03:04:58PM +0530, Ronit Halder wrote: > This patch fixes the warning generated by sparse > "Using plain integer as NULL pointer" by using NULL > instead of zero. > > Signed-off-by: Ronit halder > --- > > v2: added a new patch in this patch series to

RE: [PATCH 11/39] hfi1: drop null test before destroy functions

> Subject: [PATCH 11/39] hfi1: drop null test before destroy functions > > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ expression x; @@ > -if (x != NULL) >

Re: [PATCH v2 01/11] staging: wilc1000: replace WILC_ERRORREPORT with return

On Tue, Sep 15, 2015 at 01:07:06PM +0300, Mike Rapoport wrote: > In cases where WILC_ERRORREPORT does not require cleanup actions, but > causes immediate return from the function it can be replaced with return > statement. > > Signed-off-by: Mike Rapoport > --- >

RE: [patch] IB/hfi1: fix copy_to/from_user() error handling

> Subject: [patch] IB/hfi1: fix copy_to/from_user() error handling > > copy_to/from_user() returns the number of bytes which we were not able to > copy. It doesn't return an error code. > > Also a couple places had a printk() on error and I removed that because > people can take advantage of it

Re: [PATCH 1/4] staging: wilc1000: remove unused variable g_num_total_switches

On Tue, Sep 15, 2015 at 06:46:25AM -0700, Greg KH wrote: > On Tue, Sep 15, 2015 at 05:26:35PM +0900, Tony Cho wrote: > > > > > > On 2015년 09월 15일 16:13, Sudip Mukherjee wrote: > > >On Tue, Sep 15, 2015 at 02:33:54PM +0900, Tony Cho wrote: > > >>From: Glen Lee > > >> > >

[PATCH] staging: dgap: Remove myself from the MAINTAINERS file

Removes myself from the MAINTAINERS file for the dgap driver. There appears to be no way to get the firmware files required by the dgap driver into the linux-firmware tree. The dgap driver is useless wihtout this firmware. This product is considered an obsolete product by Digi. They will not

Re: [PATCH] staging: dgap: Remove myself from the MAINTAINERS file

On Tue, Sep 15, 2015 at 08:56:10AM -0400, Mark Hounschell wrote: > Removes myself from the MAINTAINERS file for the dgap driver. > There appears to be no way to get the firmware files required > by the dgap driver into the linux-firmware tree. The dgap > driver is useless wihtout this firmware.

Re: [PATCH 06/19] staging/lustre/lmv: fix potential null pointer dereference

On 09/14/15 18:41, gr...@linuxhacker.ru wrote: > Reviewed-on: http://review.whamcloud.com/14605 I'm confused why the patch found in this email doesn't match the patch I find when I click on the above link? Some of the patches in this series match what I find on your jenkins URLs, and some do not.

Re: [PATCH 00/13] staging: wilc1000: remove WILC_CATCH and friends

On Mon, Sep 14, 2015 at 10:00:42PM +0300, Mike Rapoport wrote: > Hi, > > These patches replace usage of WILC_ERRORREPORT, WILC_ERRORCHECK, > WILC_NULLCHECK and WILC_CATCH by plain code that either returns the error > value or sets the error code and uses goto to jump to error handling code. As

Re: [PATCH 2/2] staging: wilc1000: remove RX_BH_TYPE

On Tue, Sep 15, 2015 at 10:17:41AM +0900, Tony Cho wrote: > Hi Greg, > > I am sorry but please ignore this patch in this time. It's already in my tree, right? I can revert it if you want me to, but I can't ignore it anymore, sorry. greg k-h ___ devel

Re: [PATCH] staging: dgap: Remove myself from the MAINTAINERS file

On 09/15/2015 09:05 AM, Greg Kroah-Hartman wrote: On Tue, Sep 15, 2015 at 08:56:10AM -0400, Mark Hounschell wrote: Removes myself from the MAINTAINERS file for the dgap driver. There appears to be no way to get the firmware files required by the dgap driver into the linux-firmware tree. The

Re: [PATCH 00/13] staging: wilc1000: remove WILC_CATCH and friends

On Tue, Sep 15, 2015 at 4:32 PM, Greg Kroah-Hartman wrote: > On Mon, Sep 14, 2015 at 10:00:42PM +0300, Mike Rapoport wrote: >> Hi, >> >> These patches replace usage of WILC_ERRORREPORT, WILC_ERRORCHECK, >> WILC_NULLCHECK and WILC_CATCH by plain code that either returns

[PATCH v2] drivers: staging: wilc1000: Add check for SPI availability

NULL pointer deference is observed in the wilc1000.ko module with bus type SPI and when SPI is not ready. Signed-off-by: Chandra S Gorentla --- v2 - Subject corrected 'stating:' -> 'staging:' Following are the steps to reproduce. $ sudo insmod

  1   2   >