Re: [PATCH 1/4] Drivers: hv: utils: fix memory leak on on_msg() failure

On Thu, Nov 12, 2015 at 12:32:13PM +0100, Vitaly Kuznetsov wrote: > @@ -85,10 +86,10 @@ static ssize_t hvt_op_write(struct file *file, const char > __user *buf, > return PTR_ERR(inmsg); > > if (hvt->on_msg(inmsg, count)) > - return -EFAULT; > + ret =

Re: Panic in drm_calc_timestamping_constants in staging-next

On Mon, Nov 16, 2015 at 07:29:46PM +0300, Dan Carpenter wrote: > Ville Syrjälä already posted the answer but his email had no text just a > link inside 300+ lines of quoted output so you may have missed it. AFAICS I have not received anything from Ville. Thanks for the heads up, Ira

[PATCH 09/27] mtd: nand: make use of mtd_to_nand() in NAND core code

mtd_to_nand() was recently introduced to avoid direct access to the mtd->priv field. Update core code to use mtd_to_nand(). Signed-off-by: Boris Brezillon --- drivers/mtd/nand/nand_base.c | 84 ++--

[PATCH 13/27] mtd: nand: add nand_to_mtd() helper

Add a new helper to retrieve the MTD device attached to a NAND chip. Signed-off-by: Boris Brezillon --- include/linux/mtd/nand.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h index

[PATCH 08/27] sh: nand: make use of mtd_to_nand() where appropriate

mtd_to_nand() was recently introduced to avoid direct accesses to the mtd->priv field. Update all SH specific implementations to use this helper. Signed-off-by: Boris Brezillon --- arch/sh/boards/mach-migor/setup.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 07/27] mips: nand: make use of mtd_to_nand() where appropriate

mtd_to_nand() was recently introduced to avoid direct accesses to the mtd->priv field. Update all MIPS specific implementations to use this helper. Signed-off-by: Boris Brezillon --- arch/mips/alchemy/devboards/db1200.c | 2 +-

[PATCH 02/27] mtd: nand: add an mtd_to_nand() helper

Some drivers are retrieving the nand_chip pointer using the container_of macro on a struct wrapping both the nand_chip and the mtd_info struct while the standard way of retrieving this pointer is through mtd->priv. Provide an helper to do that. Signed-off-by: Boris Brezillon

[PATCH 03/27] mtd: nand: update examples in the documentation to use mtd_to_nand()

mtd_to_nand() has been introduced to hide accesses to mtd->priv. All NAND controller drivers should use it instead of directly accessing the ->priv field. Signed-off-by: Boris Brezillon --- Documentation/DocBook/mtdnand.tmpl | 4 ++-- 1 file changed, 2

[PATCH 06/27] cris: nand: make use of mtd_to_nand() where appropriate

mtd_to_nand() was recently introduced to avoid direct accesses to the mtd->priv field. Update all CRIS specific implementations to use this helper. Signed-off-by: Boris Brezillon --- arch/cris/arch-v32/drivers/mach-a3/nandflash.c | 2 +-

[PATCH 04/27] ARM: nand: make use of mtd_to_nand() where appropriate

mtd_to_nand() was recently introduced to avoid direct accesses to the mtd->priv field. Update all ARM specific implementations to use this helper. Signed-off-by: Boris Brezillon --- arch/arm/mach-ep93xx/snappercl15.c | 4 ++-- arch/arm/mach-ep93xx/ts72xx.c

[PATCH 00/27] mtd: nand: refactor the NAND subsystem (part 1)

Hello, This huge series aims at clarifying the relationship between the mtd and nand_chip structures and hiding NAND framework internals to NAND controller drivers. The first part of the series provide an mtd_to_nand() helper to hide the way mtd and nand_chip are linked together. The second

[PATCH 11/27] staging: mt29f_spinand: make use of mtd_to_nand()

mtd_to_nand() was recently introduced to avoid direct accesses to the mtd->priv field. Use it where appropriate. Signed-off-by: Boris Brezillon --- drivers/staging/mt29f_spinand/mt29f_spinand.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 19/19] staging/wilc1000: pass struct wilc to most linux_wlan.c functions

We want to get rid of all global variables in this driver, and instead pass device structures from one function to another. This changes the linux_wlan.c and wilc_wlan.c to do this for the most part. There are a few exceptions where these functions are themselves called from another part of the

[PATCH 13/19] staging/wilc1000: get rid of WILC_SDIO_IRQ_GPIO

Whether the SDIO function uses an internal or external interrupt should not be a compiletime decision but be determined at runtime. This changes the code to pass a GPIO number from the init code as early as possible, and leaves just one #ifdef WILC_SDIO_IRQ_GPIO to preserve the previous behavior.

Re: [PATCH] comedi: ni_6527: Fix coding style - use BIT macro

On Sat, Nov 14, 2015 at 06:43:23PM +0530, Ranjith Thangavel wrote: > @@ -221,11 +223,11 @@ static int ni6527_intr_cmdtest(struct comedi_device > *dev, > > /* Step 1 : check if triggers are trivially valid */ > > - err |= comedi_check_trigger_src(>start_src, TRIG_NOW); > - err |=

Re: Panic in drm_calc_timestamping_constants in staging-next

On Mon, Nov 16, 2015 at 10:00:04AM -0500, ira. weiny wrote: > On Sun, Nov 15, 2015 at 08:09:18PM -0800, Greg KH wrote: > > On Sun, Nov 15, 2015 at 01:17:00PM -0500, ira.weiny wrote: > > > With the latest staging-testing and staging-next[*] I am getting the > > > following panic. > > > > > > [*]

[PATCH] comedi: dmm32at: Fix coding style - use BIT macro

BIT macro is used for defining BIT location instead of shifting operator, usleep_range is preferred over udelay - coding style issue Signed-off-by: Ranjith Thangavel --- drivers/staging/comedi/drivers/dmm32at.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH] comedi: ni_6527: Fix coding style - use BIT macro

BIT macro is used for defining BIT location instead of shifting operator - coding style issue Signed-off-by: Ranjith Thangavel --- drivers/staging/comedi/drivers/ni_6527.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

Re: Panic in drm_calc_timestamping_constants in staging-next

Ville Syrjälä already posted the answer but his email had no text just a link inside 300+ lines of quoted output so you may have missed it. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: Panic in drm_calc_timestamping_constants in staging-next

On Mon, Nov 16, 2015 at 11:12:24AM -0500, ira.weiny wrote: > On Mon, Nov 16, 2015 at 10:00:04AM -0500, ira. weiny wrote: > > On Sun, Nov 15, 2015 at 08:09:18PM -0800, Greg KH wrote: > > > On Sun, Nov 15, 2015 at 01:17:00PM -0500, ira.weiny wrote: > > > > With the latest staging-testing and

[PATCH 11/19] staging/wilc1000: pass io_type to wilc_netdev_init

In order to avoid some of the #ifdefs, this passes the io_type and device pointer as an argument to wilc_netdev_init. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/linux_wlan.c | 18 -- drivers/staging/wilc1000/linux_wlan_sdio.c| 4 ++--

[PATCH 00/19 v5] staging/wilc1000 cleanups

As suggested by Glen Lee, I'm sending the patches once more with the two one-line fixes in "staging/wilc1000: pass hif operations through initialization". I have rebased on top of today's staging-testing, but no other changes were necessary, so this is otherwise identical to the version that Glen

[PATCH 09/19] staging/wilc1000: move init/exit functions to driver files

The driver interfaces are in linux_wlan_sdio.c and linux_wlan_spi.c, so this is where the init and exit functions should be. Splitting this up enables further cleanups, including eventually allowing both modules to be built together. Signed-off-by: Arnd Bergmann ---

[PATCH 14/19] staging/wilc1000: pass hif operations through initialization

The wilc_hif_spi and wilc_hif_sdio structures are part of the bus specific code, and the generic code should have no knowledge of their addresses. This changes the code to reference them only from the bus specific initialization code, which we can then use to split up the driver into separate

[PATCH 16/19] staging/wilc1000: remove WILC_SDIO/WILC_SPI macros

The last remaining user of WILC_SDIO macro checks for the correct time to wait in an interrupt for the PLL to settle. We can replace this with a runtime check and remove both WILC_SDIO and WILC_SPI, as we no longer need conditional compilation based on the hardware type. Signed-off-by: Arnd

Re: [PATCH v2 3/3] [media] include/media: move platform_data to linux/platform_data/media

On Mon, 16 Nov 2015, Mauro Carvalho Chehab wrote: > Let's not mix platform_data headers with the core headers. Instead, let's > create a subdir at linux/platform_data and move the headers to that > common place, adding it to MAINTAINERS. > > The headers were moved with: > mkdir

[PATCH 14/27] mtd: nand: use the mtd instance embedded in struct nand_chip

struct nand_chip now embeds an mtd device. Patch all drivers to make use of this mtd instance instead of using the instance embedded in their private struct or dynamically allocated. Signed-off-by: Boris Brezillon Cc: Julia Lawall ---

[PATCH 26/27] mtd: nand: make use of nand_set/get_controller_data() helpers

New helpers have been added to avoid directly accessing chip->field. Use them where appropriate. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/ams-delta.c | 6 +-- drivers/mtd/nand/atmel_nand.c| 54 ++---

[PATCH 24/27] mtd: nand: add helpers to access ->priv

Add two helpers to access the field reserved for private controller data. This makes it clearer what this field is reserved for and ease future refactoring. Signed-off-by: Boris Brezillon --- include/linux/mtd/nand.h | 10 ++ 1 file changed, 10

[PATCH 21/27] staging: mt29f_spinand: remove useless mtd->priv = chip assignment

mtd_to_nand_chip() now uses the container_of() approach to transform an mtd_info pointer into a nand_chip one. Drop useless mtd->priv assignments from NAND controller drivers. Signed-off-by: Boris Brezillon --- Patch generated with the following coccinelle

[PATCH 10/27] mtd: nand: make use of mtd_to_nand() in NAND drivers

mtd_to_nand() was recently introduced to avoid direct accesses to the mtd->priv field. Update all NAND drivers to use it. Signed-off-by: Boris Brezillon --- drivers/mtd/nand/ams-delta.c | 4 +- drivers/mtd/nand/atmel_nand.c|

[PATCH 15/27] mtd: nand: update the documentation to reflect framework changes

The MTD device is now directly embedded in the nand_chip struct. Update the mtdnand documentation to mention this aspect and fix the different examples. Signed-off-by: Boris Brezillon --- Documentation/DocBook/mtdnand.tmpl | 31 +++

[PATCH 20/27] cris: nand: remove useless mtd->priv = chip assignments

mtd_to_nand_chip() now uses the container_of() approach to transform an mtd_info pointer into a nand_chip one. Drop useless mtd->priv assignments from NAND controller drivers. Signed-off-by: Boris Brezillon --- Patch generated with the following coccinelle

[PATCH 19/27] mtd: nand: remove useless mtd->priv = chip assignments

mtd_to_nand_chip() now uses the container_of() approach to transform an mtd_info pointer into a nand_chip one. Drop useless mtd->priv assignments from NAND controller drivers. Signed-off-by: Boris Brezillon --- Patch generated with the following coccinelle

[PATCH 12/27] mtd: nand: embed an mtd_info structure into nand_chip

Currently all NAND controller drivers are providing both the mtd_info and nand_chip struct and then let the NAND subsystem to initialize a few things before registering the mtd instance to the MTD layer. Embed an mtd_info field into nand_chip to add some consistency to all NAND controller drivers.

[PATCH 17/27] cris: nand: use the mtd instance embedded in struct nand_chip

struct nand_chip now embeds an mtd device. Patch all drivers to make use of this mtd instance instead of using the instance embedded in their private struct or dynamically allocated. Signed-off-by: Boris Brezillon --- Most of those changes were generate with

[PATCH 22/27] mtd: nand: simplify nand_dt_init() usage

nand_dt_init() function requires 3 arguments where it actually needs one (dn and mtd can both be retrieved from chip). Drop these parameters. Testing for dn != NULL inside nand_dt_init() also helps simplifying the caller code. Signed-off-by: Boris Brezillon

[PATCH 16/27] staging: mt29f_spinand: use the mtd instance embedded in struct nand_chip

struct nand_chip now embeds an mtd device, use it instead of allocating a new one. Signed-off-by: Boris Brezillon --- drivers/staging/mt29f_spinand/mt29f_spinand.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH 23/27] mtd: nand: kill the chip->flash_node field

Now that the nand_chip struct directly embeds an mtd_info struct we can get rid of the ->flash_node field and forward set/get_flash_node requests to the MTD layer. As a side effect, we no longer need the mtd_set_of_node() call done in nand_dt_init(). Signed-off-by: Boris Brezillon

[PATCH 18/27] mtd: nand: update mtd_to_nand()

Now that all drivers are using the mtd instance embedded in the nand_chip struct we can safely update the mtd_to_nand_chip() implementation to use the container_of macro instead of returning the content of mtd->priv. This will allow us to remove mtd->priv = chip assignments done in all NAND

Re: [PATCH v2 3/3] [media] include/media: move platform_data to linux/platform_data/media

On Monday 16 November 2015 09:00:45 Mauro Carvalho Chehab wrote: > Let's not mix platform_data headers with the core headers. Instead, let's > create a subdir at linux/platform_data and move the headers to that > common place, adding it to MAINTAINERS. > Acked-by: Arnd Bergmann

Re: [PATCH] comedi: dmm32at: Fix coding style - use BIT macro

This one is buggy. For example: > -#define DMM32AT_FIFO_STATUS_PAGE_MASK(3 << 0) > +#define DMM32AT_FIFO_STATUS_PAGE_MASK0 There are other bugs as well. Please, be more careful. regards, dan carpenter ___ devel mailing list

[PATCH 25/27] ARM: make use of nand_set/get_controller_data() helpers

New helpers have been added to avoid directly accessing chip->field. Use them where appropriate. Signed-off-by: Boris Brezillon --- arch/arm/mach-ixp4xx/ixdp425-setup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 18/19] staging/wilc1000: use more regular probing

So far, my patches tried to do equivalent conversions of the existing code. This one goes beyond that by restructuring how the devices get probed. In particular, the spi driver no longer creates the netdev until the device is probed, and I've removed the global wilc_sdio_func and wilc_spi_dev

[PATCH 15/19] staging/wilc1000: turn enable_irq/disable_irq into callbacks

As a preparation for turning the SDIO side of wilc1000 into a separate module, this removes the last direct caller from the core module into the sdio specific portion. All calls to wilc_sdio_enable_interrupt() and wilc_sdio_disable_interrupt() now go through a function pointer in wilc_hif_func. We

Re: Panic in drm_calc_timestamping_constants in staging-next

On Sun, Nov 15, 2015 at 01:17:00PM -0500, ira.weiny wrote: > With the latest staging-testing and staging-next[*] I am getting the > following panic. > > [*] git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > > [ 11.232549] BUG: unable to handle kernel NULL pointer

Re: [PATCH v2 3/3] [media] include/media: move platform_data to linux/platform_data/media

W dniu 16.11.2015 o 20:00, Mauro Carvalho Chehab pisze: > Let's not mix platform_data headers with the core headers. Instead, let's > create a subdir at linux/platform_data and move the headers to that > common place, adding it to MAINTAINERS. > > The headers were moved with: > mkdir

[PATCH 05/27] blackfin: nand: make use of mtd_to_nand() where appropriate

mtd_to_nand() was recently introduced to avoid direct accesses to the mtd->priv field. Update all blackfin specific implementations to use this helper. Signed-off-by: Boris Brezillon --- arch/blackfin/mach-bf537/boards/stamp.c | 2 +-

[PATCH 01/27] mtd: nand: fix drivers abusing mtd->priv

The ->priv field of the mtd_info object attached to a nand_chip device should point to the nand_chip device. The pxa and cafe drivers are assigning this field their own private structure, which works fine as long as the nand_chip field is the first one in the driver private struct but seems a bit

[PATCH] staging: emxx_udc: use list_first_entry_or_null()

Simplify the code with list_first_entry_or_null(). Signed-off-by: Geliang Tang --- drivers/staging/emxx_udc/emxx_udc.c | 30 +- 1 file changed, 5 insertions(+), 25 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c

[PATCH 10/19] staging/wilc1000: unify device pointer

struct wilc has two pointers to store the device, one for sdio_func and one for spi_device. By changing the pointer to a 'struct device', we can simplify the logic and avoid a few #ifdefs. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/linux_wlan.c | 25

[PATCH 1/2] staging: unisys: remove unused variable

The variables op, sd and zmotion were never being used. Signed-off-by: Sudip Mukherjee --- drivers/staging/unisys/visorhba/visorhba_main.c | 4 drivers/staging/unisys/visorinput/visorinput.c | 4 +--- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git

[PATCH 2/2] staging: unisys: return error value directly

In case of error we are jumping to err_del_scsipending_ent and always returning SCSI_MLQUEUE_DEVICE_BUSY from error path. We donot need a variable to return a fixed error value, it can be returned directly. Signed-off-by: Sudip Mukherjee ---

Re: Panic in drm_calc_timestamping_constants in staging-next

On Sun, Nov 15, 2015 at 08:09:18PM -0800, Greg KH wrote: > On Sun, Nov 15, 2015 at 01:17:00PM -0500, ira.weiny wrote: > > With the latest staging-testing and staging-next[*] I am getting the > > following panic. > > > > [*] git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > So

[PATCH 02/19] staging/wilc1000: make symbols static if possible

All symbols that are only referenced in the file that defines them can be declared 'static' to avoid namespace pollution, to produce better object code, and to make the source more readable. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/Makefile | 3

[PATCH 05/19] staging/wilc1000: use NO_SECURITY instead of NO_ENCRYPT

The linux_wlan.c file uses a set of enums from wilc_wlan_if.h, with the exception of the NO_ENCRYPT that comes from wilc_wfi_cfgoperations.h. The two sets of enums clearly have the same intention but are defined a bit different. To prepare to clean up the ones in wilc_wfi_cfgoperations.h, this

[PATCH 04/19] staging/wilc1000: move extern declarations to headers

'extern' declarations belong into a header file rather than a .c file, to ensure that the definition matches the declaration. This moves all declarations into a header file that seems most appropriate for it. Signed-off-by: Arnd Bergmann ---

[PATCH 17/19] staging/wilc1000: split out bus specific modules

The SPI and SDIO specific code is now separate enough that we just need to restructure the Makefile and Kconfig logic a bit and export a couple of symbols from the common module to have separate bus glue drivers. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/Kconfig

[PATCH 08/19] staging/wilc1000: move wilc_wlan_inp_t into struct wilc

wilc_wlan_inp_t is an unnecessary indirection and requires linux_wlan.c to have knowledge of the specific sdio and spi front-ends. This removes the structure and places io_type directly inside the struct wilc. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/linux_wlan.c

[PATCH 06/19] staging/wilc1000: avoid static definitions in header

The wilc_wfi_cfgoperations.h header defines the ieee80211_txrx_stypes and cipher_suites variables that are only used in wilc_wfi_cfgoperations.c and should not be shared in a header file. This moves over all that data into the .c file, and also moves all the macro definitions from the file that

[PATCH 03/19] staging/wilc1000: use proper naming for global symbols

There are many global symbols in the wilc1000 driver, some of them with names like "DEBUG_LEVEL" or "probe" that are not acceptable for globals in the linux kernel as they may easily conflict with other (equally broken) drivers. This renames all the globals that do not already start with wilc or

[PATCH 01/19] staging/wilc1000: remove unused functions

A number of symbols in the wilc1000 driver are completely unused and can be removed. This includes two variables that are only written but not read. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/host_interface.c | 295 --

Re: [PATCH 15/20] staging/wilc1000: pass hif operations through initialization

On Monday 16 November 2015 10:36:47 glen lee wrote: > On 2015년 11월 13일 18:17, Arnd Bergmann wrote: > > On Friday 13 November 2015 16:49:22 glen lee wrote: > >> Hi arnd, > >> > >> I found this. These should be like this. It works fine. > >> + .hif_block_tx_ext = sdio_write, > >> +

[PATCH 07/19] staging/wilc1000: remove linux_wlan_{device_power, device_detection}

The driver provides an interface for custom power management and detection that is meant to be filled by people customizing the driver. The default implementation of this is empty, and we don't actually want people to have to modify the source code. If anybody needs this, they need to describe

[PATCH 12/19] staging/wilc1000: use device pointer for phy creation

wilc_create_wiphy tries to get a pointer to a device from the global wilc_sdio_func variable. This is a layering violation and we can use the wilc_dev->dev pointer instead. Signed-off-by: Arnd Bergmann --- drivers/staging/wilc1000/linux_wlan.c | 2 +-

[staging:staging-testing 203/404] wilc_wfi_cfgoperations.c:undefined reference to `cfg80211_ready_on_channel'

Hi Glen, It's probably a bug fix that unveils the link errors. tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 4811789503d16510a8a6610fb6c4097e1efa6312 commit: b22fa80cdbf4ff1056ecddb4efdcc0ede5f5f422 [203/404] staging: wilc1000: fix kbuild

Re: [PATCH 1/4] Drivers: hv: utils: fix memory leak on on_msg() failure

Dan Carpenter writes: > On Thu, Nov 12, 2015 at 12:32:13PM +0100, Vitaly Kuznetsov wrote: >> @@ -85,10 +86,10 @@ static ssize_t hvt_op_write(struct file *file, const >> char __user *buf, >> return PTR_ERR(inmsg); >> >> if (hvt->on_msg(inmsg, count))

Re: Panic in drm_calc_timestamping_constants in staging-next

On Mon, Nov 16, 2015 at 12:02:51PM -0500, ira.weiny wrote: > On Mon, Nov 16, 2015 at 07:29:46PM +0300, Dan Carpenter wrote: > > Ville Syrjälä already posted the answer but his email had no text just a > > link inside 300+ lines of quoted output so you may have missed it. > > AFAICS I have not

[PATCH] staging: rdma: ehca: Added a blank line

Added a blank line after declarations to remove the coding style error detected by the checkpatch.pl. WARNING: Missing a blank line after declarations Signed-off-by: Anjali Menon --- drivers/staging/rdma/ehca/ehca_av.c | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH 1/2] comedi: dmm32at: Fix coding style - use BIT macro

BIT macro is used for defining BIT location instead of shifting operator, usleep_range is preferred over udelay - coding style issue Signed-off-by: Ranjith Thangavel --- drivers/staging/comedi/drivers/dmm32at.c | 100 +++--- 1 file changed, 50

RE: [PATCH] comedi: dmm32at: Fix coding style - use BIT macro

On Monday, November 16, 2015 10:09 AM, Ranjith Thangavel wrote: > BIT macro is used for defining BIT location instead of > shifting operator, usleep_range is preferred over > udelay - coding style issue > > Signed-off-by: Ranjith Thangavel > --- >

[PATCH v2 7/7] staging/rdma/hfi1: Return immediately on error

From: Dennis Dalessandro Now that the spinlock is not taken throughout hfi1_ioctl it is safe to return early rather than setting a variable and falling through the switch. Reviewed-by: Mike Marciniszyn Signed-off-by: Dennis Dalessandro

[PATCH v2 3/7] staging/rdma/hfi1: Return early from hfi1_ioctl parameter errors

From: Ira Weiny Rather than have a switch in a large else clause make the parameter checks return immediately. Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 348

[PATCH v2 6/7] staging/rdma/hfi1: Reduce snoop locking scope in IOCTL handler.

From: Dennis Dalessandro This patch avoids issues while calling into copy from/to user while holding the lock by only taking the lock when it is absolutely required. The only commands which require the snoop lock are: *Set Filter *Clear Filter *Clear Queue

[PATCH v3] staging/rdma/hfi1: set Gen3 half-swing for integrated devices

From: Dean Luick Correctly set half-swing for integrated devices. A0 needs all fields set for CcePcieCtrl. B0 and later only need a few fields set. Reviewed-by: Stuart Summers Signed-off-by: Dean Luick Signed-off-by: Ira

[PATCH v2 2/7] staging/rdma/hfi1: Fix camel case variables

From: Ira Weiny physState, linkState, and devState should be phys_state, link_state, and dev_state Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 24

[PATCH v2 0/7] Fix hfi1_ioctl locking

From: Ira Weiny It was identified that hfi1_ioctl may sleep with a spin lock held. This was identified publicly here: http://www.spinics.net/lists/linux-rdma/msg29926.html As well as by our internal development. This series cleans up the code and parameter checks, as

[PATCH v2 1/7] staging/rdma/hfi1: diag.c Correct code style issues

From: Jubin John Correct the checks on diag.c with the latest checkpatch Reviewed-by: Dennis Dalessandro Reviewed-by: Mike Marciniszyn Signed-off-by: Jubin John Signed-off-by: Ira Weiny

[PATCH v2 4/7] staging/rdma/hfi1: hfi1_ioctl remove setlink state

From: Ira Weiny Set link state is not supported remove from the switch statement and allow the default to return -ENOTTY Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- Changes from v1: Just remove

[PATCH v2 5/7] staging/rdma/hfi1: Further clean up hfi1_ioctl parameter checks

From: Ira Weiny Final clean up of the if/then/else clause for the parameter checks of hfi1_ioctl Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- Changes from v1: SETLINKSTATE is removed

Re: [PATCH 10/13] staging/rdma/hfi1: adding per SDMA engine stats to hfistats

On Wed, Nov 11, 2015 at 11:22:15AM +0300, Dan Carpenter wrote: > On Wed, Nov 11, 2015 at 02:33:30AM -0500, Jubin John wrote: > > @@ -8288,6 +8367,21 @@ static int init_cntrs(struct hfi1_devdata *dd) > > dd->ndevcntrs++; > > index++; > >

[PATCH] staging: vt6656: remove address from GPL text

Cleanup errors from checkpatch.pl. Signed-off-by: Othmar Pasteka --- drivers/staging/vt6656/baseband.c | 4 drivers/staging/vt6656/baseband.h | 4 drivers/staging/vt6656/card.c | 3 --- drivers/staging/vt6656/card.h | 3 --- drivers/staging/vt6656/channel.c

[PATCH v2 0/7] staging: unisys: visorinput fixes and enhancements

This patch series fixes visorinput to remove the dependency on FB and add dependency to INPUT, cleans up some formatting issues found with checkpatch.pl, and adds the capability to change screen resolutions without breaking mouse functionality. This is a resubmission of the series. Tim Sell (7):

[PATCH v2 7/7] staging: unisys: visorinput: add INPUT to dependent driver list

From: Tim Sell This was an obvious omission, as visorinput is an input-class driver. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- v2: the patch was resubmitted. ---

[PATCH v2 3/7] staging: unisys: visorinput: ensure proper locking wrt creation & ints

From: Tim Sell Ensure we properly lock between visorinput_channel_interrupt() and devdata_create(). We now guarantee that interrupts will be disabled and we will be holding lock_visor_dev at the time input_register_device() is called (from register_client_keyboard() or

[PATCH v2 2/7] staging: unisys: visorinput: remove need for 'depends on FB'

From: Tim Sell Previously, we used a hack to determine the max x,y resolution of the visor virtual mouse: we just looked at the resolution of the first-registered framebuffer device, using the currently-valid assumption that in a Unisys s-Par guest environment the video

[PATCH v2 4/7] staging: unisys: visorinput: respond to resolution changes on-the-fly

From: Tim Sell Whenever the absolute x,y resolution of the video (and mouse) changes, the back-end sends an inputaction_set_max_xy message indicating the new resolution. This commit adds the infrastructure to detect and correctly respond to that message. There were

Re: [PATCH 01/13] staging/rdma/hfi1: Use BIT macro

On Sat, Nov 14, 2015 at 12:41:02PM +0530, Sudip Mukherjee wrote: > On Fri, Nov 13, 2015 at 11:09:22AM -0500, Jubin John wrote: > > On Fri, Nov 13, 2015 at 06:45:58PM +0530, Sudip Mukherjee wrote: > > > On Wed, Nov 11, 2015 at 02:33:21AM -0500, Jubin John wrote: > > > > This patch fixes the

[PATCH v2 6/7] staging: unisys: visorinput: add useful dev_dbg() and dev_info() messages

From: Tim Sell The dev_info() messages at init time are particularly useful for mapping visor devices to input devices. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- v2: the patch was resubmitted. ---

[PATCH v2 1/7] staging: unisys: visorinput: use kref ref-counting for device data struct

From: Tim Sell This is NOT technically required for the code as it stands now, but will be needed for subsequent patches. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer --- v2: resources are released in the

[PATCH v2 5/7] staging: unisys: visorinput: sanity check resolution changes

From: Tim Sell This commit sanity checks so that if a change resolution request is ever received for a non-mouse device, that an error message will be logged and the message will be ignored. Signed-off-by: Tim Sell Signed-off-by: Benjamin Romer

Dead or Alive

FROM THE DESK OF MR. WALI IBRAHIM INTERNATIONAL MONETARY FUND AGENCY INTERNATIONAL OPERATION DEPT VICTORIA ISLAND LAGOS-NIGERIA. RE-OUTSTANDING PAYMENT This is to inform you of your long overdue Payment outstanding our Banking records. I saw your name in the Central Computer among list of

[PATCHv2 2/3] staging: ion: Add files for parsing the devicetree

Devicetree is the preferred mechanism for platform definition these days. Add a set of files for supporting Ion with devicetree. This is a set of functions for drivers to call to parse the Ion devicetree along with definitons for defining heaps. Signed-off-by: Laura Abbott

[PATCHv2 3/3] NOMERGE: Sample driver

Small sample driver to show what setup would look like with the dt bindings Signed-off-by: Laura Abbott --- drivers/staging/android/ion/Kconfig | 6 ++ drivers/staging/android/ion/Makefile| 1 + drivers/staging/android/ion/ion_of_sample.c | 96

[PATCHv2 0/3] Devicetree bindings for Ion

Hi, This is another attempt at devicetree bindings for Ion. The big complaint from v1 was that too much unnecessary data was being pushed into devicetree. v2 takes a different approach of using just compatbile strings for the heaps. This gets closer to the devicetree philosophy of describing

[PATCHv2 1/3] ion: Devicetree bindings for Ion

This adds a base set of devicetree bindings for the Ion memory manager. This supports setting up the generic set of heaps and their properties. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/devicetree.txt | 50 ++ 1 file changed, 50

[PATCH v2 01/13] staging/rdma/hfi1: Use BIT macro

This patch fixes the checkpatch issue: CHECK: Prefer using the BIT macro Use of BIT macro for HDRQ_INCREMENT in chip.h causes a change in format specifier for error message in init.c in order to avoid a build warning. Reviewed-by: Dean Luick Reviewed-by: Ira Weiny

[PATCH v2 02/13] staging/rdma/hfi1: Fix downgrade race

From: Dean Luick A link downgrade can race with link up. Avoid the race in two ways. First, by having the downgrade application logic take the link state mutex for all of its checking. Second, by waiting for the link to move out of the going up state. Reviewed-by: Dennis

[PATCH v2 08/13] staging/rdma/hfi1: change krcvqs module parameter type from byte to uint

From: Mark F. Brown The krcvqs parameter is displayed incorrectly in sysfs. The workaround is to set the param type as uint. Reviewed-by: Mike Marciniszyn Reviewed-by: Mitko Haralanov Signed-off-by: Mark F. Brown

[PATCH v2 05/13] staging/rdma/hfi1: Add space between concatenated string elements

Space between concantenated string elements is more human readable and fixes the checkpatch issue: CHECK: Concatenated strings should use spaces between elements Reviewed-by: Mike Marciniszyn Signed-off-by: Jubin John ---

  1   2   >