Re: [PATCH 3/4] scsi: storvsc: Refactor the code in storvsc_channel_init()

2015-12-11 Thread Dan Carpenter
On Thu, Dec 10, 2015 at 04:14:19PM -0800, K. Y. Srinivasan wrote: > @@ -753,27 +740,62 @@ static int storvsc_channel_init(struct hv_device > *device, bool is_fc) > VM_PKT_DATA_INBAND, > VMBUS_DATA_PACKET_FLAG_COMPLETION_REQUESTED); >

[PATCH] staging: gdm72xx: Code cleanups

2015-12-11 Thread Sanidhya Solanki
>From c07c57f3e045865b0acae498c631189f24aeda0b Mon Sep 17 00:00:00 2001 From: Sanidhya Solanki Date: Thu, 10 Dec 2015 21:13:10 -0500 Subject: [PATCH] staging: gdm72xx: Code cleanups Code cleanups as per the TODO file. Signed-off-by: Sanidhya Solanki

Re: [PATCH 2/4] scsi: storvsc: Properly support Fibre Channel devices

2015-12-11 Thread Dan Carpenter
On Thu, Dec 10, 2015 at 04:14:18PM -0800, K. Y. Srinivasan wrote: > + ret = vmbus_sendpacket(device->channel, vstor_packet, > +(sizeof(struct vstor_packet) - > +vmscsi_size_delta), > +(unsigned long)request, >

Re: [PATCH] staging: gdm72xx: fix address space parse warnings

2015-12-11 Thread Okash Khawaja
> On 11 Dec 2015, at 10:52, Dan Carpenter wrote: > >> On Fri, Dec 11, 2015 at 10:33:13AM +, Okash Khawaja wrote: >> Thanks, that's a cleaner approach. Apologies for delayed reply as I'm in >> middle of a house move. I'll send an updated patch soon. > > Someone

[PATCH 02/13] staging/android/sync: add sync_fence_create_dma

2015-12-11 Thread John . C . Harrison
From: Maarten Lankhorst This allows users of dma fences to create a android fence. v2: Added kerneldoc. (Tvrtko Ursulin). v4: Updated comments from review feedback my Maarten. Signed-off-by: Maarten Lankhorst Signed-off-by:

[PATCH 01/13] staging/android/sync: Support sync points created from dma-fences

2015-12-11 Thread John . C . Harrison
From: Maarten Lankhorst Debug output assumes all sync points are built on top of Android sync points and when we start creating them from dma-fences will NULL ptr deref unless taught about this. v4: Corrected patch ownership. Signed-off-by: Maarten Lankhorst

Re: [PATCH 0/2] staging: COMEDI: checkpatch.pl cleanups in comedi.h

2015-12-11 Thread Ian Abbott
On 10/12/15 14:57, Moritz König wrote: This patchset fixes all the warnings and legitimate checks of checkpatch.pl in comedi.h. The following warnings were fixed: * WARNING: Block comments use * on subsequent lines * WARNING: Block comments use a trailing */ on a separate line The following

[PATCH] staging: dgnc: Patch includes the checkpatch fixes

2015-12-11 Thread Sanidhya Solanki
>From 1dbe78ce98037da5467d817a9db838d678b338ae Mon Sep 17 00:00:00 2001 From: Sanidhya Solanki Date: Fri, 11 Dec 2015 03:08:53 -0500 Subject: [PATCH] staging: dgnc: Patch includes the checkpatch fixes Patch contains the checkpatch fixes as asked by the TODO. TODO file is

Re: [PATCH] staging: gdm72xx: fix address space parse warnings

2015-12-11 Thread Okash Khawaja
Thanks, that's a cleaner approach. Apologies for delayed reply as I'm in middle of a house move. I'll send an updated patch soon. Okash > On 2 Dec 2015, at 13:17, Dan Carpenter wrote: > > Probably it's better to create a different struct: > > struct udata_s { >

Re: [PATCH] staging: gdm72xx: fix address space parse warnings

2015-12-11 Thread Dan Carpenter
On Fri, Dec 11, 2015 at 10:33:13AM +, Okash Khawaja wrote: > Thanks, that's a cleaner approach. Apologies for delayed reply as I'm in > middle of a house move. I'll send an updated patch soon. > Someone already fixed it. Thanks. regards, dan carpenter

[PATCH 03/10] media framework: rename pads init function to media_entity_pads_init()

2015-12-11 Thread Mauro Carvalho Chehab
With the MC next gen rework, what's left for media_entity_init() is to just initialize the PADs. However, certain devices, like a FLASH led/light doesn't have any input or output PAD. So, there's no reason why calling media_entity_init() would be mandatory. Also, despite its name, what this

Re: [PATCH 03/10] media framework: rename pads init function to media_entity_pads_init()

2015-12-11 Thread Jacek Anaszewski
On 12/11/2015 02:34 PM, Mauro Carvalho Chehab wrote: With the MC next gen rework, what's left for media_entity_init() is to just initialize the PADs. However, certain devices, like a FLASH led/light doesn't have any input or output PAD. So, there's no reason why calling media_entity_init()

[PATCH v5 41/58] mtd: nand: socrates: use the mtd instance embedded in struct nand_chip

2015-12-11 Thread Boris Brezillon
struct nand_chip now embeds an mtd device. Make use of this mtd instance. Signed-off-by: Boris Brezillon --- Changes since v4: - fix build error --- Changes generated with the following coccinelle script --->8--- virtual patch @fix1@ identifier __chipfield,

[PATCH] media: use unsigned for pad index

2015-12-11 Thread Mauro Carvalho Chehab
The pad index is unsigned. Replace the occurences of it where pertinent. Suggested-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/omap3isp/ispccdc.c | 2 +-

Re: [PATCH v4 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove()

2015-12-11 Thread Dan Carpenter
On Fri, Dec 11, 2015 at 02:53:20PM +0100, Boris Brezillon wrote: > Hi Brian, > > On Thu, 10 Dec 2015 16:40:08 -0800 > Brian Norris wrote: > > > On Thu, Dec 10, 2015 at 08:59:45AM +0100, Boris Brezillon wrote: > > > Unregister the NAND device from the NAND subsystem

Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

2015-12-11 Thread Sanidhya Solanki
On Fri, 11 Dec 2015 16:02:33 +0300 Dan Carpenter wrote: > > Signed-off-by: Sanidhya Solanki > > @@ -110,7 +98,16 @@ static ssize_t dgnc_vpd_show(struct device *p, struct > > device_attribute *attr, > > int count = 0; > > int i = 0; > >

[PATCH] Staging: rtl8192u: Fix block comment formatting

2015-12-11 Thread Gavin Thomas Claugus
Change block comments to comply with checkpatch style guidelines. Signed-off-by: Gavin Thomas Claugus --- drivers/staging/rtl8192u/r8190_rtl8256.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git

Re: [PATCH net-next] hv_netvsc: Fix race condition on Multi-Send Data field

2015-12-11 Thread Vitaly Kuznetsov
Haiyang Zhang writes: > In commit 2a04ae8acb14 ("hv_netvsc: remove locking in netvsc_send()"), the > locking for MSD (Multi-Send Data) field was removed. This could cause a > race condition between RNDIS control messages and data packets processing, > because these two

[PATCH 01/13] staging/android/sync: Support sync points created from dma-fences

2015-12-11 Thread John . C . Harrison
From: Maarten Lankhorst Debug output assumes all sync points are built on top of Android sync points and when we start creating them from dma-fences will NULL ptr deref unless taught about this. v4: Corrected patch ownership. Signed-off-by: Maarten Lankhorst

[PATCH 02/13] staging/android/sync: add sync_fence_create_dma

2015-12-11 Thread John . C . Harrison
From: Maarten Lankhorst This allows users of dma fences to create a android fence. v2: Added kerneldoc. (Tvrtko Ursulin). v4: Updated comments from review feedback my Maarten. Signed-off-by: Maarten Lankhorst Signed-off-by:

[PATCH v5 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove()

2015-12-11 Thread Boris Brezillon
Unregister the NAND device from the NAND subsystem when removing a denali NAND controller, otherwise the MTD attached to the NAND device is still exposed by the MTD layer, and accesses to this device will likely crash the system. Signed-off-by: Boris Brezillon

[PATCH v5 15/58] mtd: nand: denali: use the mtd instance embedded in struct nand_chip

2015-12-11 Thread Boris Brezillon
struct nand_chip now embeds an mtd device. Make use of this mtd instance. Signed-off-by: Boris Brezillon --- Changes since v4: - fix conflict after changes brought in v5 of patch 1 --- Changes generated with the following coccinelle script --->8--- virtual

Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

2015-12-11 Thread Dan Carpenter
On Fri, Dec 11, 2015 at 03:21:49AM -0500, Sanidhya Solanki wrote: > >From 1dbe78ce98037da5467d817a9db838d678b338ae Mon Sep 17 00:00:00 2001 > From: Sanidhya Solanki > Date: Fri, 11 Dec 2015 03:08:53 -0500 > Subject: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

Re: [PATCH net-next] hv_netvsc: Fix race condition on Multi-Send Data field

2015-12-11 Thread Vitaly Kuznetsov
Vitaly Kuznetsov writes: > Haiyang Zhang writes: > >> In commit 2a04ae8acb14 ("hv_netvsc: remove locking in netvsc_send()"), the >> locking for MSD (Multi-Send Data) field was removed. This could cause a >> race condition between RNDIS control

Re: [PATCH] staging: dgnc: Patch includes the checkpatch fixes

2015-12-11 Thread Dan Carpenter
On Fri, Dec 11, 2015 at 05:10:43AM -0500, Sanidhya Solanki wrote: > On Fri, 11 Dec 2015 16:02:33 +0300 > Dan Carpenter wrote: > > > > Signed-off-by: Sanidhya Solanki > > > @@ -110,7 +98,16 @@ static ssize_t dgnc_vpd_show(struct device *p, struct

Re: [PATCH v5 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove()

2015-12-11 Thread Dinh Nguyen
Hi Boris, On Fri, Dec 11, 2015 at 9:10 AM, Boris Brezillon wrote: > + Dinh (who made commit 2a0a288ec258) > > Also added back the Fixes tag. > > On Fri, 11 Dec 2015 15:02:34 +0100 > Boris Brezillon wrote: > >> Unregister

Re: [PATCH v5 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove()

2015-12-11 Thread Boris Brezillon
+ Dinh (who made commit 2a0a288ec258) Also added back the Fixes tag. On Fri, 11 Dec 2015 15:02:34 +0100 Boris Brezillon wrote: > Unregister the NAND device from the NAND subsystem when removing a denali > NAND controller, otherwise the MTD attached to the

Re: [PATCH v5 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove()

2015-12-11 Thread Boris Brezillon
Hi Dinh, On Fri, 11 Dec 2015 10:50:21 -0600 Dinh Nguyen wrote: > Hi Boris, > > On Fri, Dec 11, 2015 at 9:10 AM, Boris Brezillon > wrote: > > + Dinh (who made commit 2a0a288ec258) > > > > Also added back the Fixes tag. > > > > On Fri,

RE: [PATCH net-next] hv_netvsc: Fix race condition on Multi-Send Data field

2015-12-11 Thread Haiyang Zhang
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Friday, December 11, 2015 8:53 AM > To: Haiyang Zhang > Cc: da...@davemloft.net; net...@vger.kernel.org; o...@aepfle.de; > jasow...@redhat.com;

RE: [PATCH net-next] hv_netvsc: Fix race condition on Multi-Send Data field

2015-12-11 Thread KY Srinivasan
> -Original Message- > From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > Behalf Of Vitaly Kuznetsov > Sent: Friday, December 11, 2015 5:53 AM > To: Haiyang Zhang > Cc: o...@aepfle.de; net...@vger.kernel.org; jasow...@redhat.com; >

Re: [PATCH v4 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove()

2015-12-11 Thread Boris Brezillon
Hi Dan, On Fri, 11 Dec 2015 17:39:47 +0300 Dan Carpenter wrote: > On Fri, Dec 11, 2015 at 02:53:20PM +0100, Boris Brezillon wrote: > > Hi Brian, > > > > On Thu, 10 Dec 2015 16:40:08 -0800 > > Brian Norris wrote: > > > > > On Thu, Dec 10,

very urgent business proposal

2015-12-11 Thread Mr. Akinwumi Godson Fanimokun
Mr. Akinwumi Godson Fanimokun Group Executive, Technology & Services First Bank of Nigerian Plc Dearest, My name is Mr. Akinwumi Godson Fanimokun,Group Executive, Technology & Services First Bank of Nigerian Plc. based in Nigeria. I am writing in respect

[PATCH] staging: goldfish: Coding Style Fix Comparison to NULL could be written "!r"

2015-12-11 Thread Benjamin Young
Fixed coding style for null comparisons in goldfish_audio.c to be more consistant with the rest of the kernel coding style Signed-off-by: Benjamin Young --- drivers/staging/goldfish/goldfish_audio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH] staging: goldfish: Coding Style Fix - spaces preferred around that '+'

2015-12-11 Thread Benjamin Young
Helped improve coding style to make arithemethic easier to read Signed-off-by: Benjamin Young --- drivers/staging/goldfish/goldfish_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/goldfish/goldfish_audio.c

Re: [PATCH v4 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove()

2015-12-11 Thread Brian Norris
Hi Boris, On Fri, Dec 11, 2015 at 11:03:05PM +0100, Boris Brezillon wrote: > On Thu, 10 Dec 2015 16:40:08 -0800 > Brian Norris wrote: > > On Thu, Dec 10, 2015 at 08:59:45AM +0100, Boris Brezillon wrote: > > > Unregister the NAND device from the NAND subsystem when

Re: [PATCH v4 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove()

2015-12-11 Thread Boris Brezillon
Hi Brian, On Thu, 10 Dec 2015 16:40:08 -0800 Brian Norris wrote: > On Thu, Dec 10, 2015 at 08:59:45AM +0100, Boris Brezillon wrote: > > Unregister the NAND device from the NAND subsystem when removing a denali > > NAND controller, otherwise the MTD attached to the

[PATCH v2 4/6] Fix another C compiler whine: set but not used

2015-12-11 Thread Valdis Kletnieks
CC [M] drivers/staging/lustre/lustre/libcfs/module.o drivers/staging/lustre/lustre/libcfs/module.c: In function 'lustre_insert_debugfs': drivers/staging/lustre/lustre/libcfs/module.c:670:17: warning: variable 'entry' set but not used [-Wunused-but-set-variable] struct dentry *entry;

[PATCH v2 2/6] Fix set-but-unused whinge.

2015-12-11 Thread Valdis Kletnieks
drivers/staging/lustre/lustre/fid/lproc_fid.c: In function 'ldebugfs_fid_write_common': drivers/staging/lustre/lustre/fid/lproc_fid.c:67:6: warning: variable 'rc' set but not used [-Wunused-but-set-variable] int rc; We fix it by *using* the return code to help bulletproof it. It says it's

[PATCH v2 5/6] Nuke an unsigned >= 0 assert

2015-12-11 Thread Valdis Kletnieks
Writing asserts for almost-never-can-happen things can be valuable. Writing an assert that tests that an "unsigned int" hasn't gone negative isn't. And it generates an *ugly* message: drivers/staging/lustre/lustre/llite/rw.c:763:20: warning: comparison of unsigned expression >= 0 is always true

Re: [PATCH] staging: dgnc: Update the TODO file

2015-12-11 Thread Sanidhya Solanki
>From ae99848ed2c054e3ec031b3014f4727f6ff94ea3 Mon Sep 17 00:00:00 2001 From: Sanidhya Solanki Date: Fri, 11 Dec 2015 21:12:35 -0500 Subject: [PATCH 2/2] staging: dgnc: Update the TODO file Patch updates the TODO file. Line regarding checkpatch changes removed.

[PATCH v2 1/6] staging/lustre: Silence warning about 'inline'

2015-12-11 Thread Valdis Kletnieks
Low-hanging fruit first: CC [M] drivers/staging/lustre/lustre/fid/fid_request.o In file included from drivers/staging/lustre/lustre/fid/../include/lustre_net.h:66:0, from drivers/staging/lustre/lustre/fid/../include/lustre_lib.h:64, from

[PATCH 26/27] Drivers: hv: utils: Invoke the poll function after handshake

2015-12-11 Thread K. Y. Srinivasan
When the handshake with daemon is complete, we should poll the channel since during the handshake, we will not be processing any messages. This is a potential bug if the host is waiting for a response from the guest. I would like to thank Dexuan for pointing this out. Signed-off-by: K. Y.

[PATCH RESEND 21/27] drivers:hv: Allow for MMIO claims that span ACPI _CRS records

2015-12-11 Thread K. Y. Srinivasan
From: Jake Oshins This patch makes 16GB GPUs work in Hyper-V VMs, since, for compatibility reasons, the Hyper-V BIOS lists MMIO ranges in 2GB chunks in its root bus's _CRS object. Signed-off-by: Jake Oshins Signed-off-by: K. Y. Srinivasan

[PATCH RESEND 18/27] Drivers: hv: vmbus: fix rescind-offer handling for device without a driver

2015-12-11 Thread K. Y. Srinivasan
From: Dexuan Cui In the path vmbus_onoffer_rescind() -> vmbus_device_unregister() -> device_unregister() -> ... -> __device_release_driver(), we can see for a device without a driver loaded: dev->driver is NULL, so dev->bus->remove(dev), namely vmbus_remove(), isn't

[PATCH RESEND 24/27] drivers/hv: correct tsc page sequence invalid value

2015-12-11 Thread K. Y. Srinivasan
From: Andrey Smetanin Hypervisor Top Level Functional Specification v3/4 says that TSC page sequence value = -1(0x) is used to indicate that TSC page no longer reliable source of reference timer. Unfortunately, we found that Windows Hyper-V guest side

[PATCH RESEND 11/27] Drivers: hv: vss: run only on supported host versions

2015-12-11 Thread K. Y. Srinivasan
From: Olaf Hering The Backup integration service on WS2012 has appearently trouble to negotiate with a guest which does not support the provided util version. Currently the VSS driver supports only version 5/0. A WS2012 offers only version 1/x and 3/x, and

[PATCH RESEND 12/27] Drivers: hv: vmbus: Use uuid_le type consistently

2015-12-11 Thread K. Y. Srinivasan
Consistently use uuid_le type in the Hyper-V driver code. Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c |2 +- drivers/hv/vmbus_drv.c | 10 ++-- include/linux/hyperv.h | 92 +-

[PATCH RESEND 23/27] Drivers: hv: vmbus: Fix a Host signaling bug

2015-12-11 Thread K. Y. Srinivasan
Currently we have two policies for deciding when to signal the host: One based on the ring buffer state and the other based on what the VMBUS client driver wants to do. Consider the case when the client wants to explicitly control when to signal the host. In this case, if the client were to defer

[PATCH RESEND 10/27] drivers:hv: Define the channel type for Hyper-V PCI Express pass-through

2015-12-11 Thread K. Y. Srinivasan
From: Jake Oshins This defines the channel type for PCI front-ends in Hyper-V VMs. Signed-off-by: Jake Oshins Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c |3 +++ include/linux/hyperv.h| 11 +++

[PATCH 25/27] Drivers: hv: vmbus: Force all channel messages to be delivered on CPU 0

2015-12-11 Thread K. Y. Srinivasan
Force all channel messages to be delivered on CPU0. These messages are not performance critical and are used during the setup and teardown of the channel. Signed-off-by: K. Y. Srinivasan --- drivers/hv/connection.c | 11 +++ 1 files changed, 7 insertions(+), 4

[PATCH RESEND 22/27] tools/hv: Use include/uapi with __EXPORTED_HEADERS__

2015-12-11 Thread K. Y. Srinivasan
From: Kamal Mostafa Use the local uapi headers to keep in sync with "recently" added #define's (e.g. VSS_OP_REGISTER1). Fixes: 3eb2094c59e89db2bedd401e23c7a870081c9edb Signed-off-by: Kamal Mostafa Signed-off-by: K. Y. Srinivasan

[PATCH RESEND 20/27] Drivers: hv: vmbus: channge vmbus_connection.channel_lock to mutex

2015-12-11 Thread K. Y. Srinivasan
From: Dexuan Cui spinlock is unnecessary here. mutex is enough. Signed-off-by: Dexuan Cui Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c | 12 ++-- drivers/hv/connection.c |7 +++

[PATCH RESEND 09/27] drivers:hv: Export the API to invoke a hypercall on Hyper-V

2015-12-11 Thread K. Y. Srinivasan
From: Jake Oshins This patch exposes the function that hv_vmbus.ko uses to make hypercalls. This is necessary for retargeting an interrupt when it is given a new affinity. Since we are exporting this API, rename the API as it will be visible outside the hv.c file.

[PATCH RESEND 07/27] drivers/hv: cleanup synic msrs if vmbus connect failed

2015-12-11 Thread K. Y. Srinivasan
From: Andrey Smetanin Before vmbus_connect() synic is setup per vcpu - this means hypervisor receives writes at synic msr's and probably allocate hypervisor resources per synic setup. If vmbus_connect() failed for some reason it's neccessary to cleanup synic setup by

[PATCH RESEND 16/27] Drivers: hv: vmbus: serialize process_chn_event() and vmbus_close_internal()

2015-12-11 Thread K. Y. Srinivasan
From: Dexuan Cui process_chn_event(), running in the tasklet, can race with vmbus_close_internal() in the case of SMP guest, e.g., when the former is accessing channel->inbound.ring_buffer, the latter could be freeing the ring_buffer pages. To resolve the race, we can

[PATCH RESEND 13/27] Drivers: hv: vmbus: Use uuid_le_cmp() for comparing GUIDs

2015-12-11 Thread K. Y. Srinivasan
Use uuid_le_cmp() for comparing GUIDs. Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel_mgmt.c |3 +-- drivers/hv/vmbus_drv.c|4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c index

[PATCH RESEND 08/27] drivers:hv: Export a function that maps Linux CPU num onto Hyper-V proc num

2015-12-11 Thread K. Y. Srinivasan
From: Jake Oshins This patch exposes the mapping between Linux CPU number and Hyper-V virtual processor number. This is necessary because the hypervisor needs to know which virtual processors to target when making a mapping in the Interrupt Redirection Table in the I/O MMU.

Re: [PATCH: FIXED} staging: dgnc: Patch includes the checkpatch fixes

2015-12-11 Thread Sanidhya Solanki
>From fa54ad27ad5ba8c90e0b42901af09423b1b3d0c7 Mon Sep 17 00:00:00 2001 From: Sanidhya Solanki Date: Fri, 11 Dec 2015 21:08:06 -0500 Subject: [PATCH] staging: dgnc: Patch includes the checkpatch fixes Patch contains the checkpatch fixes as asked by the TODO. Unnecessary

RE: [PATCH 1/4] scsi: storvsc: Fix a bug in the layout of the hv_fc_wwn_packet

2015-12-11 Thread KY Srinivasan
> -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Friday, December 11, 2015 12:48 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; >

RE: [PATCH 2/4] scsi: storvsc: Properly support Fibre Channel devices

2015-12-11 Thread KY Srinivasan
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Friday, December 11, 2015 2:25 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; >

RE: [PATCH V2 02/10] Drivers: hv: utils: run polling callback always in interrupt context

2015-12-11 Thread KY Srinivasan
> -Original Message- > From: Dexuan Cui > Sent: Thursday, December 10, 2015 11:33 PM > To: KY Srinivasan ; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; vkuzn...@redhat.com;

RE: [PATCH 3/4] scsi: storvsc: Refactor the code in storvsc_channel_init()

2015-12-11 Thread KY Srinivasan
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Friday, December 11, 2015 2:41 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; >

[PATCH v2 3/6] Clean up another C warnining: set but not used

2015-12-11 Thread Valdis Kletnieks
drivers/staging/lustre/lustre/fid/../include/lustre_cfg.h: In function 'lustre_cfg_free': drivers/staging/lustre/lustre/fid/../include/lustre_cfg.h:253:6: warning: variable 'len' set but not used [-Wunused-but-set-variable] int len; Yep, we're just gonna call kfree, no need to calculate len.

[PATCH v2 0/6] Patch series to make lustre safe(r) for W=1 compiles

2015-12-11 Thread Valdis Kletnieks
Start of a batch series to clean up the Lustre tree. Other people have done some sparse and checkpatch cleanups, but I found a bunch of stuff building with W=1. There's probably more, but this was the really low-hanging obvious fruit. Valdis Kletnieks (6): staging/lustre: Silence warning about

[PATCH v2 6/6] Nuke another unsigned >= 0 assert

2015-12-11 Thread Valdis Kletnieks
Clean up another case of the compiler remininding the programmer they are an idiot: drivers/staging/lustre/lustre/ptlrpc/sec_bulk.c:308:34: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] LASSERT(page_pools.epp_waitqlen >= 0); Just lose the assert, and save a

Re: [PATCH 1/4] scsi: storvsc: Fix a bug in the layout of the hv_fc_wwn_packet

2015-12-11 Thread Johannes Thumshirn
On Thu, Dec 10, 2015 at 04:14:17PM -0800, K. Y. Srinivasan wrote: > The hv_fc_wwn_packet is exchanged over vmbus. Make the definition in Linux > match > the Window's definition. > > Signed-off-by: K. Y. Srinivasan > Reviewed-by: Long Li > Tested-by:

[PATCH] Drivers: hv: vmbus: fix build warning

2015-12-11 Thread Sudip Mukherjee
We were getting build warning about unused variable "tsc_msr" and "va_tsc" while building for i386 allmodconfig. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- build warning with next-20151211 and build log is at: https://travis-ci.org/sudipm-mukhe

Re: [PATCH 3/4] scsi: storvsc: Refactor the code in storvsc_channel_init()

2015-12-11 Thread Johannes Thumshirn
On Thu, Dec 10, 2015 at 04:14:19PM -0800, K. Y. Srinivasan wrote: > The function storvsc_channel_init() repeatedly interacts with the host to > extract various channel properties. Refactor this code to eliminate code > repetition. > > Signed-off-by: K. Y. Srinivasan >

Re: [PATCH 4/4] scsi: storvsc: Tighten up the interrupt path

2015-12-11 Thread Johannes Thumshirn
On Thu, Dec 10, 2015 at 04:14:20PM -0800, K. Y. Srinivasan wrote: > On the interrupt path, we repeatedly establish the pointer to the > storvsc_device. Fix this. > > Signed-off-by: K. Y. Srinivasan > Reviewed-by: Long Li > Tested-by: Alex Ng

[PATCH v3] staging: gdm72xx: add userspace data struct

2015-12-11 Thread Wim de With
This fixes the sparse warnings about dereferencing a userspace pointer. Once I updated the sparse annotations, I noticed a bug in gdm_wimax_ioctl() where we pass a user space pointer to gdm_update_fsm() which dereferences it. I fixed this. Signed-off-by: Wim de With ---

[PATCH RESEND v3 3/8] staging: fsl-mc: dprc device's sysfs rescan documentation

2015-12-11 Thread Lijun Pan
Add the sysfs documentation for the rescan attribute of dprc devices. Signed-off-by: Lijun Pan --- Documentation/ABI/testing/sysfs-devices-dprc | 13 + 1 file changed, 13 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-devices-dprc diff

[PATCH RESEND v2 7/8] staging: fsl-mc: update TODO and README for restool driver

2015-12-11 Thread Lijun Pan
Add more introduction of restool driver and state why restool driver is needed in helping moving fsl-mc bus out of staging tree. Signed-off-by: Lijun Pan --- drivers/staging/fsl-mc/README.txt | 11 ++- drivers/staging/fsl-mc/TODO | 18 -- 2

[PATCH RESEND v2 4/8] staging: fsl-mc: root dprc rescan attribute to sync kernel with MC

2015-12-11 Thread Lijun Pan
Introduce the rescan attribute as a device attribute to synchronize the fsl-mc bus objects and the MC firmware. To rescan the root dprc only, e.g. echo 1 > /sys/bus/fsl-mc/devices/dprc.1/rescan Signed-off-by: Lijun Pan --- drivers/staging/fsl-mc/bus/mc-bus.c | 43

[PATCH RESEND v2 1/8] staging: fsl-mc: static inline function to differentiate root dprc

2015-12-11 Thread Lijun Pan
Define a static inline function is_root_dprc(dev) to tell whether a device is root dprc or not via platform_bus_type. Remove fsl_mc_is_root_dprc() because is_root_dprc() is simpler and easier to understand. Signed-off-by: Lijun Pan --- v2: use static inline function

[PATCH RESEND v2 5/8] staging: fsl-mc: fsl-mc bus's sysfs rescan documentation

2015-12-11 Thread Lijun Pan
Add the sysfs documentation for the rescan attribute of fsl-mc bus. Signed-off-by: Lijun Pan --- Documentation/ABI/testing/sysfs-bus-fsl-mc | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-bus-fsl-mc diff --git

[PATCH RESEND v2 8/8] staging: fsl-mc: Management Complex restool driver

2015-12-11 Thread Lijun Pan
The kernel support for the restool (a user space resource management tool) is a driver for the /dev/dprc.N device file. Its purpose is to provide an ioctl interface, which the restool uses to interact with the MC bus driver and with the MC firmware. We allocate a dpmcp at driver initialization,

[PATCH RESEND v2 0/8] Management Complex restool driver

2015-12-11 Thread Lijun Pan
*** This is a resend of the last iteration of this patch series *** This series of patches are based on http://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/commit/?h=staging-next=63f2be5c3b358db031f86eafa9cd450f6558a55b patch v1 1/5 "staging: fsl-mc: section mismatch bug fix" is

[PATCH RESEND v2 2/8] staging: fsl-mc: add sysfs rescan attribute in TODO

2015-12-11 Thread Lijun Pan
Demonstrate why sysfs rescan attribute is helpful for moving fsl-mc bus out of staging. Signed-off-by: Lijun Pan --- drivers/staging/fsl-mc/TODO | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/fsl-mc/TODO b/drivers/staging/fsl-mc/TODO index

[PATCH RESEND v2 6/8] staging: fsl-mc: bus rescan attribute to sync kernel with MC

2015-12-11 Thread Lijun Pan
Introduce the rescan attribute as a bus attribute to synchronize the fsl-mc bus objects and the MC firmware. To rescan the fsl-mc bus, e.g., echo 1 > /sys/bus/fsl-mc/rescan Signed-off-by: Lijun Pan --- drivers/staging/fsl-mc/bus/mc-bus.c | 46

Re: [PATCH v5 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove()

2015-12-11 Thread Dinh Nguyen
On Fri, Dec 11, 2015 at 11:08 AM, Boris Brezillon wrote: > Hi Dinh, > > On Fri, 11 Dec 2015 10:50:21 -0600 > Dinh Nguyen wrote: > >> Hi Boris, >> >> On Fri, Dec 11, 2015 at 9:10 AM, Boris Brezillon >>

[PATCH v2] staging: gdm72xx: fix address space warnings

2015-12-11 Thread Okash Khawaja
copy_to_user() and copy_from_user() functions expect the user space pointers to be marked with __user. Sparse throws following warnings. For copy_to_user(): warning: incorrect type in argument 1 (different address spaces) expected void [noderef] *to got void *buf For copy_from_user(): warning:

[PATCH] staging: lustre: This patch fixes the following sparse warning:

2015-12-11 Thread Jandy Gou
drivers/staging/lustre/lustre/osc/osc_cache.c:622:19: warning: symbol 'osc_extent_find' was not declared. Should it be static? drivers/staging/lustre/lustre/osc/osc_cache.c:1423:6: warning: symbol 'osc_unreserve_grant' was not declared. Should it be static? Signed-off-by: Jandy Gou

Re: [PATCH v4 01/58] mtd: nand: denali: add missing nand_release() call in denali_remove()

2015-12-11 Thread Boris Brezillon
Hi Brian, On Thu, 10 Dec 2015 16:40:08 -0800 Brian Norris wrote: > On Thu, Dec 10, 2015 at 08:59:45AM +0100, Boris Brezillon wrote: > > Unregister the NAND device from the NAND subsystem when removing a denali > > NAND controller, otherwise the MTD attached to the

Re: [PATCH] staging: goldfish: Coding Style Fix Comparison to NULL could

2015-12-11 Thread Benjamin Young
On Fri, Dec 11, 2015 at 12:14:17PM +0530, Sudip Mukherjee wrote: > On Thu, Dec 10, 2015 at 06:31:09PM -0500, Benjamin Young wrote: > > From 4b8ce6b3bd7effdfff2c95fbeb4a20cb93d5e9e5 Mon Sep 17 00:00:00 2001 > > From: Benjamin Young > > Date: Thu, 10 Dec 2015 17:31:00 -0500 > >

[PATCH v4 03/11] staging: fsl-mc: Added generic MSI support for FSL-MC devices

2015-12-11 Thread J. German Rivera
Created an MSI domain for the fsl-mc bus-- including functions to create a domain, find a domain, alloc/free domain irqs, and bus specific overrides for domain and irq_chip ops. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v4: - Addressed comments

[PATCH v4 10/11] staging: fsl-mc: Added DPRC interrupt handler

2015-12-11 Thread J. German Rivera
The interrupt handler for DPRC IRQs is added. DPRC IRQs are generated for hot plug events related to DPAA2 objects in a given DPRC. These events include, creating/destroying DPAA2 objects in the DPRC, changing the "plugged" state of DPAA2 objects and moving objects between DPRCs. Signed-off-by:

[PATCH v4 05/11] staging: fsl-mc: Extended MC bus allocator to include IRQs

2015-12-11 Thread J. German Rivera
All the IRQs for DPAA2 objects in the same DPRC must use the ICID of that DPRC, as their device Id in the GIC-ITS. Thus, all these IRQs must share the same ITT table in the GIC. As a result, a pool of IRQs with the same device Id must be preallocated per DPRC (fsl-mc bus instance). So, the fsl-mc

[PATCH v4 01/11] irqdomain: Added domain bus token DOMAIN_BUS_FSL_MC_MSI

2015-12-11 Thread J. German Rivera
Since an FSL-MC bus is a new bus type that is neither PCI nor PLATFORM, we need a new domain bus token to disambiguate the IRQ domain for FSL-MC MSIs. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v4: none Changes in v3: none Changes in v2: none

[PATCH v4 00/11] staging: fsl-mc: MC bus MSI support

2015-12-11 Thread J. German Rivera
This patch series addresses the following item from the TODO list for the MC bus driver to exit staging: * Interrupt support. For meaningful driver support we need interrupts, and thus need message interrupt support by the bus driver. MC Bus MSI Support Architecture

[PATCH v4 08/11] staging: fsl-mc: set MSI domain for DPRC objects

2015-12-11 Thread J. German Rivera
THE MSI domain associated with a root DPRC object is obtained form the device tree. Child DPRCs inherit the parent DPRC MSI domain. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v4: - Addressed comments from Marc Zyngier: * Changed call to

[PATCH v4 11/11] staging: fsl-mc: Added MSI support to the MC bus driver

2015-12-11 Thread J. German Rivera
Initialize/Cleanup ITS-MSI support for the MC bus driver at driver init/exit time. Associate an MSI domain with each DPAA2 child device. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v4: none Changes in v3: none Changes in v2: none

[PATCH v4 07/11] staging: fsl-mc: Populate the IRQ pool for an MC bus instance

2015-12-11 Thread J. German Rivera
Scan the corresponding DPRC container to get total count of IRQs needed by all its child DPAA2 objects. Then, preallocate a set of MSI IRQs with the DPRC's ICID (GIT-ITS device Id) to populate the the DPRC's IRQ pool. Each child DPAA2 object in the DPRC and the DPRC object itself will allocate

[PATCH v4 04/11] staging: fsl-mc: Added GICv3-ITS support for FSL-MC MSIs

2015-12-11 Thread J. German Rivera
Added platform-specific MSI support layer for FSL-MC devices. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v4: - Addressed comments from Marc Zyngier: * Moved bus type check earlier in its_fsl_mc_msi_prepare() * Removed its_dev_id variable *

[PATCH v4 02/11] fsl-mc: msi: Added FSL-MC-specific member to the msi_desc's union

2015-12-11 Thread J. German Rivera
FSL-MC is a bus type different from PCI and platform, so it needs its own member in the msi_desc's union. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v4: none Changes in v3: none Changes in v2: - Addressed comment from Jiang Liu * Added a

[PATCH v4 06/11] staging: fsl-mc: Changed DPRC built-in portal's mc_io to be atomic

2015-12-11 Thread J. German Rivera
The DPRC built-in portal's mc_io is used to send commands to the MC to program MSIs for MC objects. This is done by the fsl_mc_msi_write_msg() callback, which is invoked by the generic MSI layer with interrupts disabled. As a result, the mc_io used in fsl_mc_msi_write_msg needs to be an atomic

[PATCH v4 09/11] staging: fsl-mc: Fixed bug in dprc_probe() error path

2015-12-11 Thread J. German Rivera
Destroy mc_io in error path in dprc_probe() only if the mc_io was created in this function. Signed-off-by: J. German Rivera --- CHANGE HISTORY Changes in v4: none Changes in v3: none Changes in v2: - Addressed comment from Dan Carpenter: * Renamed goto error

Re: [PATCH 2/4] scsi: storvsc: Properly support Fibre Channel devices

2015-12-11 Thread Johannes Thumshirn
On Thu, Dec 10, 2015 at 04:14:18PM -0800, K. Y. Srinivasan wrote: > For FC devices managed by this driver, atttach the appropriate transport > template. This will allow us to create the appropriate sysfs files for > these devices. With this we can publish the wwn for both the port and the > node.

[PATCH RESEND 04/27] tools: hv: remove repeated HV_FCOPY string

2015-12-11 Thread K. Y. Srinivasan
From: Olaf Hering HV_FCOPY is already used as identifier in syslog. Signed-off-by: Olaf Hering Signed-off-by: K. Y. Srinivasan --- tools/hv/hv_fcopy_daemon.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH RESEND 05/27] Drivers: hv: util: catch allocation errors

2015-12-11 Thread K. Y. Srinivasan
From: Olaf Hering Catch allocation errors in hvutil_transport_send. Fixes: 14b50f80c32d ('Drivers: hv: util: introduce hv_utils_transport abstraction') Signed-off-by: Olaf Hering Signed-off-by: K. Y. Srinivasan ---

[PATCH RESEND 17/27] Drivers: hv: vmbus: do sanity check of channel state in vmbus_close_internal()

2015-12-11 Thread K. Y. Srinivasan
From: Dexuan Cui This fixes an incorrect assumption of channel state in the function. Signed-off-by: Dexuan Cui Signed-off-by: K. Y. Srinivasan --- drivers/hv/channel.c | 12 1 files changed, 12 insertions(+), 0

  1   2   >