re: staging: unisys: fix else statement in visornic_main.c

[ checkpatch.pl told someone to introduce a bug and they did... ] Hello Erik Arfvidson, The patch 05f1b17ec7aa: "staging: unisys: fix else statement in visornic_main.c" from Feb 8, 2016, leads to the following static checker warning: drivers/staging/unisys/visornic/visornic_main.c:381

Re: whitespace error in some of commits

Hi Janani, Please refer to the commit numbers again in the wilc1000 driver: c611d48e65e25af2dc0176e9ac135116095ed03d 24c6c29d85af3748b2d79b46f72188b335566340 Thanks, Tony. On 2016년 02월 16일 15:47, Tony Cho wrote: Hi Janani, I can find the whitespace errors in your commits which is already acce

whitespace error in some of commits

Hi Janani, I can find the whitespace errors in your commits which is already accepted in staging-testing branch. The commit number is c611d48e65e25af2dc0176e9ac135116095ed03d and c611d48e65e25af2dc0176e9ac135116095ed03d. I don't know why I couldn't find your patch emails from the community. P

Re: Time for a code audit?

On Mon, Feb 15, 2016 at 05:35:01PM +, Sell, Timothy C wrote: > Re spaghetti: > > I certainly agree that most uses of 'goto' are evil. > But I've found that when 'goto' is used to provide a single common > exit-point for a function (e.g., "goto away"), it can lead to code > that is much more re

Re: [PATCH] rtlwifi: Change long delays to sleeps

On Tue, Feb 16, 2016 at 3:42 AM, Larry Finger wrote: > Routine rtl_addr_delay() uses delay statements in code that can > sleep. To improve system responsiveness, the various delay statements > are changed. > > In addition, routines rtl_rfreg_delay() and rtl_bb_delay() are > rewritten to use the co

Re: [PATCH 43/45] staging/lustre/libcfs: Replace use of printk with pr_

On Tue, 2016-02-16 at 00:47 -0500, gr...@linuxhacker.ru wrote: > From: Oleg Drokin > > This pacifies checkpatch amongst other things, also is shorter to write > and avoiding calls to printk_ratelimit() is also good. [] > diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c >

[PATCH 00/45] Lustre cleanups

From: Oleg Drokin Majority of this patch is Lustre code style cleanups. NULL comparison style is adjusted for the whole lustre tree (but not lnet not to interfere with James patches in flight). Some server-only code was removed in the process. lustre/libcfs in addition was processed to remove a

[PATCH 33/45] staging/lustre/libcfs: Shortened too long lines

From: Oleg Drokin Lines that were too long for not good reason were shortened in this patch. Found with checkpatch. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c | 6 -- drivers/staging/lustre/lustre/libcfs/tracefile.c | 6 +++--- drivers/s

[PATCH 40/45] staging/lustre: Get rid of cfs_trace_buf_type_t typedef

From: Oleg Drokin Replace it with enum cfs_trace_buf_type Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c | 2 +- drivers/staging/lustre/lustre/libcfs/tracefile.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/

[PATCH 36/45] staging/lustre/libcfs: Update comments style to match kernel

From: Oleg Drokin checkpatch complains that the trailing */ on the multiline comments should be on it's own line. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/debug.c | 18 +- drivers/staging/lustre/lustre/libcfs/fail.c| 3 ++- driv

[PATCH 38/45] staging/lustre/libcfs: Remove empty lines after/before braces

From: Oleg Drokin No need for an empty line after opening curvy brace and no need for an empty line before the closing one too. Remove them. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/linux/linux-crypto.c| 2 -- drivers/staging/lustre/lustre/libcfs/linux/linux-trac

[PATCH 45/45] staging/lustre: Convert cfs_str2num_check to use kstrtoul

From: Oleg Drokin simple_strtoul is obsolete Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c b/drivers/staging/lustre/lustre

[PATCH 32/45] staging/lustre/libcfs: Remove stray spaces after function name

From: Oleg Drokin Problem highlighted by checkpatch. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c | 2 +- drivers/staging/lustre/lustre/libcfs/tracefile.c | 2 +- drivers/staging/lustre/lustre/libcfs/tracefile.h | 3 +-- drivers/stagin

[PATCH 35/45] staging/lustre/libcfs: Move private tracefile structs out of header

From: Oleg Drokin the struct page_collection, struct cfs_trace_page and struct tracefiled_ctl are only used by tracefile.c, so move them there. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/tracefile.c | 45 + drivers/staging/lustre/lustre/libcfs/trace

[PATCH 34/45] staging/lustre/libcfs: Remove unused cfs_tcd_owns_tage() function

From: Oleg Drokin Does not appear to be used anywhere. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c | 10 -- drivers/staging/lustre/lustre/libcfs/tracefile.h | 3 --- 2 files changed, 13 deletions(-) diff --git a/drivers/stag

[PATCH 30/45] staging/lustre/libcfs: style change to add missing spaces for operations

From: Oleg Drokin This fixes checkpatch messages about "spaces preferred around that '-' (ctx:VxV)" Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/debug.c | 2 +- drivers/staging/lustre/lustre/libcfs/linux/linux-mem.c | 2 +- drivers/staging/lustre/lu

[PATCH 31/45] staging/lustre/libcfs: reformat cfs_tcd_for_each_type_lock define

From: Oleg Drokin Avoid using leading spaces that make checkpatch unhappy. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/tracefile.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/libcfs/tracefile.h b/drivers/stagi

[PATCH 29/45] staging/lustre/libcfs: Move EXPORT_SYMBOLs under function/variable

From: Oleg Drokin Found with checkpatch Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/debug.c | 4 ++-- drivers/staging/lustre/lustre/libcfs/hash.c| 1 - drivers/staging/lustre/lustre/libcfs/linux/linux-curproc.c | 7 +++ drivers/staging/

[PATCH 26/45] staging/lustre/ptlrpc: Adjust NULL comparison codestyle

From: Oleg Drokin All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ptlrpc/client.c | 75 +-- drivers/staging/lustre/lustre/ptlrpc/connection.c | 2

[PATCH 27/45] staging/lustre: Remove the "write to FSF to get a copy of GPL" wording

From: Oleg Drokin Checkpatch highlighted that some of our Lustre files carry this extra paragraph and indeed it does seem somewhat redundant, so remove it. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/include/linux/lnet/lnetctl.h | 4 drivers/staging/lustre/lnet/klnds/s

[PATCH 11/45] staging/lustre/osc: Remove commented out osc_page_protected()

From: Oleg Drokin The complicated version of osc_page_protected and osc_page_is_dlocked are unsafe and were commented out for ages, so probably no point in carrying them on. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/osc/osc_page.c | 99 1 file ch

[PATCH 28/45] staging/lustre/libcfs: Cleanup: parenthesis alignment adjustments

From: Oleg Drokin Adjust alignment of argments that were pushed to next lines to conform to kernel code style. Found with checkpatch. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/debug.c| 3 +-- drivers/staging/lustre/lustre/libcfs/hash.c | 18 +-

[PATCH 17/45] staging/lustre/fid: Adjust NULL comparison codestyle

From: Oleg Drokin All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/fid/fid_request.c | 14 +++--- drivers/staging/lustre/lustre/fid/lproc_fid.c | 14 ++ 2 files changed, 9 insertions(+), 1

[PATCH 23/45] staging/lustre/obdclass: Adjust NULL comparison codestyle

From: Oleg Drokin All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/obdclass/acl.c | 10 +-- drivers/staging/lustre/lustre/obdclass/cl_io.c | 83 +---

[PATCH 10/45] staging/lustre: Remove commented out lock_lock_multi_match

From: Oleg Drokin lock_lock_multi_match stayed commented out unused for ages now, so let's just remove it. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/lov/lov_lock.c | 39 1 file changed, 39 deletions(-) diff --git a/drivers/staging/lustre/lustre/

[PATCH 25/45] staging/lustre/osc: Adjust NULL comparison codestyle

From: Oleg Drokin All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/osc/lproc_osc.c | 4 +- drivers/staging/lustre/lustre/osc/osc_cache.c | 120 ++-

[PATCH 09/45] staging/lustre: Remove server code from class_get_type()

From: Oleg Drokin class_get_type has some references to various server modules that could not exist on the server, so get rid of them. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/obdclass/genops.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/lust

[PATCH 24/45] staging/lustre/obdecho: Adjust NULL comparison codestyle

From: Oleg Drokin All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/obdecho/echo_client.c| 61 ++ 1 file changed, 29 insertions(+), 32 deletions(-) di

[PATCH 44/45] staging/lustre: Convert cfs_trace_daemon_command to use kstrtoul

From: Oleg Drokin simple_strtoul is obsolete Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/tracefile.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/staging/lustre/lustre/libcfs/tracefile.c b/drivers/staging/lustre/lustre/lib

[PATCH 41/45] staging/lustre/libcfs: Get rid of multiple assignments

From: Oleg Drokin They make checkpatch unhappy, and I guess overall might confuse people too. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/libcfs_mem.c| 7 --- drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 6 -- 2 files changed, 8 insertions(+), 5 de

[PATCH 16/45] staging/lustre/lmv: Adjust NULL comparison codestyle

From: Oleg Drokin All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/lmv/lmv_intent.c | 11 +-- drivers/staging/lustre/lustre/lmv/lmv_internal.h | 6 +- drivers/stagin

[PATCH 21/45] staging/lustre/mdc: Adjust NULL comparison codestyle

From: Oleg Drokin All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/mdc/mdc_lib.c | 12 +-- drivers/staging/lustre/lustre/mdc/mdc_locks.c | 47 +- drivers/

[PATCH 22/45] staging/lustre/mgc: Adjust NULL comparison codestyle

From: Oleg Drokin All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 41 - 1 file changed, 20 insertions(+), 21 deletions(-) di

[PATCH 20/45] staging/lustre/include: Adjust NULL comparison codestyle

From: Oleg Drokin All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/cl_object.h | 6 +-- drivers/staging/lustre/lustre/include/lclient.h| 4 +- drivers/stag

[PATCH 43/45] staging/lustre/libcfs: Replace use of printk with pr_

From: Oleg Drokin This pacifies checkpatch amongst other things, also is shorter to write and avoiding calls to printk_ratelimit() is also good. Signed-off-by: Oleg Drokin --- .../lustre/lustre/libcfs/linux/linux-tracefile.c | 10 ++-- drivers/staging/lustre/lustre/libcfs/tracefile.c | 53

[PATCH 19/45] staging/lustre/lclient: Adjust NULL comparison codestyle

From: Oleg Drokin All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 32 +++--- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/lustre/lustre

[PATCH 18/45] staging/lustre/fld: Adjust NULL comparison codestyle

From: Oleg Drokin All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/fld/fld_cache.c| 10 +++- drivers/staging/lustre/lustre/fld/fld_internal.h | 2 +- drivers/staging/lustre/lustre/fld/fld_request.c |

[PATCH 14/45] staging/lustre/llite: Adjust NULL comparison codestyle

From: Oleg Drokin All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" The only exception is ll_update_inode where dropping != NULL in the construction below would break the logic. I guess we could change lsm != NULL to !!lsm, but that's uglier. (lsm != NULL) == ((body->valid

[PATCH 12/45] staging/lustre/libcfs: Adjust NULL comparison codestyle

From: Oleg Drokin All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also removed some redundant assertions. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/debug.c | 4 +- drivers/staging/lustre/lustre/libcfs/hash.c| 104 ++-

[PATCH 13/45] staging/lustre/lov: Adjust NULL comparison codestyle

From: Oleg Drokin All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also removed some redundant assertions. Signed-off-by: Oleg Drokin --- .../staging/lustre/lustre/lov/lov_cl_internal.h| 6 +-- drivers/staging/lustre/lustre/lov/lov_dev.c| 40

[PATCH 42/45] staging/lustre: Remove space after cast in cfs_crypto_hash_final()

From: Oleg Drokin This is against kernel-code style. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/linux/linux-crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-crypto.c b/drivers/staging/lustre/

[PATCH 39/45] staging/lustre: Update cfs_cpu_notify switch statement with a comment

From: Oleg Drokin We do really mean to fall through to that default case statement from all previous ones, so add a comment to unconfuse verious tools Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/linux/linux-cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drive

[PATCH 37/45] staging/lustre/libcfs: Remove useless returns in void functions

From: Oleg Drokin Return at the end of a void function does not serve any particular purpose and makes checkpatch unhappy, so eliminate them. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/linux/linux-cpu.c | 2 -- drivers/staging/lustre/lustre/libcfs/linux/linux-cry

[PATCH 15/45] staging/lustre/ldlm: Adjust NULL comparison codestyle

From: Oleg Drokin All instances of "x == NULL" are changed to "!x" and "x != NULL" to "x" Also remove some redundant assertions. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ldlm/interval_tree.c | 2 - drivers/staging/lustre/lustre/ldlm/ldlm_extent.c | 9 ++- drivers/stagi

[PATCH 03/45] staging/lustre/libcfs: Get rid of /proc references in comments

From: Oleg Drokin Now that the sysfs conversion is complete, also convert all the remaining comments Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c | 4 ++-- drivers/staging/lustre/lustre/libcfs/module.c| 4 drivers/staging/lustre/lustr

[PATCH 08/45] staging/lustre: Remove server code from client_obd_setup()

From: Oleg Drokin In client_obd_setup references to LUSTRE_OSP_NAME could only happen on metadata servers, so remove them as never true Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/ldlm/ldlm_lib.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/stag

[PATCH 01/45] staging/lustre/ptlrpc: Get rid of /proc references in comments

From: Oleg Drokin Now that the sysfs conversion is complete, also convert all the remaining comments Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/lustre_dlm.h | 2 +- drivers/staging/lustre/lustre/include/lustre_net.h | 2 +- drivers/staging/lustre/lustre/ptlrpc/recover

[PATCH 06/45] staging/lustre: Remove unused function oti_init

From: Oleg Drokin All the users seems to have disappeared. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/obd.h | 28 1 file changed, 28 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/obd.h b/drivers/staging/lustre/lustre/in

[PATCH 04/45] staging/lustre/llite: Get rid of /proc references in comments

From: Oleg Drokin Now that the sysfs conversion is complete, also convert all the remaining comments Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/lproc_llite.c | 2 +- drivers/staging/lustre/lustre/llite/vvp_io.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(

[PATCH 07/45] staging/lustre: Remove unused osc_on_mdt function

From: Oleg Drokin This only makes sense on metadata server, so get rid of it. Also remove now unused MDS_OSC_MAX_RIF_DEFAULT define Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/obd.h | 1 - drivers/staging/lustre/lustre/ldlm/ldlm_lib.c | 28 +

[PATCH 05/45] staging/lustre/lov: Get rid of /proc references in comments

From: Oleg Drokin Now that the sysfs conversion is complete, also convert all the remaining comments Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/lov/lov_pool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/lov/lov_pool.c

[PATCH 02/45] staging/lustre/obdclass: Get rid of /proc references in comments.

From: Oleg Drokin Now that the sysfs conversion is complete, also convert all the remaining comments Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/include/cl_object.h | 2 +- drivers/staging/lustre/lustre/include/lprocfs_status.h | 2 +- drivers/staging/lustre/lustre/incl

Re: [lustre-devel] [PATCH] staging: lustre: Fixed the parenthesis

On Feb 14, 2016, at 10:37 PM, Shalin Mehta wrote: > The parentehsis are fixed in the macro for the ldlm lock to set and > clear the flags. > > Signed-off-by: Shalin Mehta > --- > drivers/staging/lustre/lustre/include/lustre_dlm_flags.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH] staging: lustre: Fixed the parenthesis

On Feb 15, 2016, at 9:28 PM, Greg KH wrote: > On Sun, Feb 14, 2016 at 07:37:02PM -0800, Shalin Mehta wrote: >> The parentehsis are fixed in the macro for the ldlm lock to set and >> clear the flags. > > "fixed" in what way? Did you test-build this patch? Also, you > mispelled a word here… The

Re: [PATCH] staging: lustre: Fixed the parenthesis

On Sun, Feb 14, 2016 at 07:37:02PM -0800, Shalin Mehta wrote: > The parentehsis are fixed in the macro for the ldlm lock to set and > clear the flags. "fixed" in what way? Did you test-build this patch? Also, you mispelled a word here... thanks, greg k-h ___

Re: [PATCH] staging: wilc1000: remove wilc1000_spi_ops as it is not used

On Mon, Feb 15, 2016 at 03:18:27PM +, Colin King wrote: > From: Colin Ian King > > building with gcc 6 I hit a build failure: > > CC drivers/staging/wilc1000/wilc_spi.o > drivers/staging/wilc1000/wilc_spi.c:123:34: error: storage size of > ‘wilc1000_spi_ops’ isn’t known > static con

Re: [PATCH 1/2] staging: wilc1000: codestyle fix removes unnecessary spaces

On Sun, Feb 14, 2016 at 09:47:14PM -0330, Roger H. Newell wrote: > This patch corrects spacing errors generated by checkpatch.pl > > Signed-off-by: Roger H. Newell > --- > drivers/staging/wilc1000/wilc_spi.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) You sent two patches with

[PATCH] rtlwifi: Change long delays to sleeps

Routine rtl_addr_delay() uses delay statements in code that can sleep. To improve system responsiveness, the various delay statements are changed. In addition, routines rtl_rfreg_delay() and rtl_bb_delay() are rewritten to use the code in rtl_addr_delay() for most of their input values. Suggested

Re: [PATCH 4/4] Drivers: hv: vmbus: avoid unneeded compiler optimizations in vmbus_wait_for_unload()

2016-02-12 16:42+0100, Vitaly Kuznetsov: > Message header is modified by the hypervisor and we read it in a loop, > we need to prevent compilers from optimizing accesses. There are no such > optimizations at this moment, this is just a future proof. > > Suggested-by: Radim Krcmar Reviewed-by: Ra

Re: [PATCH 3/4] Drivers: hv: vmbus: remove code duplication in message handling

2016-02-12 16:42+0100, Vitaly Kuznetsov: > We have 3 functions dealing with messages and they all implement > the same logic to finalize reads, move it to vmbus_signal_eom(). > > Suggested-by: Radim Krcmar Reviewed-by: Radim Krčmář ___ devel mailing l

Re: [PATCH 2/4] Drivers: hv: vmbus: avoid wait_for_completion() on crash

2016-02-12 16:42+0100, Vitaly Kuznetsov: > wait_for_completion() may sleep, it enables interrupts and this > is something we really want to avoid on crashes because interrupt > handlers can cause other crashes. Switch to the recently introduced > vmbus_wait_for_unload() doing busy wait instead. (T

Re: [PATCH 1/4] Drivers: hv: vmbus: don't loose HVMSG_TIMER_EXPIRED messages

2016-02-12 16:42+0100, Vitaly Kuznetsov: > We must handle HVMSG_TIMER_EXPIRED messages in the interrupt context > and we offload all the rest to vmbus_on_msg_dpc() tasklet. This functions > loops to see if there are new messages pending. In case we'll ever see > HVMSG_TIMER_EXPIRED message there we

[PATCH v5 RESEND 4/8] Staging: rts5208: rtsx_transport.c: Add spaces around -

This patch fixes the following styling issue in rtsx_transport.c as reported by checkpatch.pl: CHECK: spaces preferred around that '-' (ctx:VxV) Signed-off-by: Shaun Ren --- drivers/staging/rts5208/rtsx_transport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/

[PATCH v5 RESEND 7/8] Staging: rts5208: rtsx_transport.c: Remove unnecessary parentheses

This patch removes all unnecessary parentheses found by checkpatch.pl. Signed-off-by: Shaun Ren --- Changes since v3 * Fixed patch conflicts due to commit 9a66d05d82db ("Staging: rts5208: fix check for dma mapping error"), and commit b3232842dbef ("Staging: rts5208: remove unnecessary p

[PATCH v5 RESEND 6/8] Staging: rts5208: rtsx_transport.c: Fix label naming convention

This patch fixes the following naming convention issue in rtsx_transport.c, as reported by checkpatch.pl: CHECK: Avoid CamelCase: Signed-off-by: Shaun Ren --- drivers/staging/rts5208/rtsx_transport.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rts5

[PATCH v5 RESEND 1/8] Staging: rts5208: rtsx_transport.c: Cleanup comments

This patch fixes all multiline comments to conform to the coding style, which states that multiline comments should start with "/*" and end with "*/" on a separate line. Also cleans up some comments to make them more clear and/or reflect what the code is doing. Signed-off-by: Shaun Ren --- Chang

[PATCH v5 RESEND 0/8] Staging: rts5208: Fix coding style

This set of patches fixes the coding style issues in rtsx_transport.c. Changes since v4 * Moved a declaration to the beginning of an if branch Changes since v3 * Removed the extraneous SCSI comment in the first patch * Removed the last patch (Staging: rts5208: Add missing dma_mapping_error)

[PATCH v5 RESEND 8/8] Staging: rts5208: rtsx_transport.c: Fix comparisons to NULL

This patch changes all comparsions to NULL with !..., as reported by checkpatch.pl. Signed-off-by: Shaun Ren --- drivers/staging/rts5208/rtsx_transport.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/

[PATCH v5 RESEND 2/8] Staging: rts5208: rtsx_transport.c: Align to open parenthesis

This patch fixes the alignment issue reported by checkpatch.pl: CHECK: Alignment should match open parenthesis Add a unsigned char *sgbuffer in rtsx_stor_access_xfer_buffer to make the following memcpy logic easier to read. Add a struct scatterlist *sg in the use_sg branch of rtsx_transfer_data_

[PATCH v5 RESEND 3/8] Staging: rts5208: rtsx_transport.c: Remove spaces after casts

This patch removes all spaces after casts in rtsx_transport.c, as reported by checkpatch.pl: CHECK: No space is necessary after a cast Signed-off-by: Shaun Ren --- drivers/staging/rts5208/rtsx_transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rts520

[PATCH v5 RESEND 5/8] Staging: rts5208: rtsx_transport.c: Remove extra newlines

This patch fixes the following issues in rtsx_transport.c as reported by checkpatch.pl: CHECK: Blank lines aren't necessary after an open brace '{' CHECK: Please don't use multiple blank lines Signed-off-by: Shaun Ren --- drivers/staging/rts5208/rtsx_transport.c | 3 --- 1 file changed, 3 delet

[PATCH 21/21] staging: sm750fb: change definition of CRT_FB_ADDRESS fields

Use stratight-forward definition of CRT_FB_ADDRESS register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_reg.h | 10 +++--- drivers/staging/sm750fb/sm750_hw.c | 4 ++-- 2 files changed, 5 insertions(+),

[PATCH 18/21] staging: sm750fb: change definition of DE_STRETCH_FORMAT fields

Use stratight-forward definition of DE_STRETCH_FORMAT register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_accel.c | 24 +++- drivers/staging/sm750fb/sm750_accel.h | 31 -

[PATCH 19/21] staging: sm750fb: change definition of DE_WINDOW_WIDTH fields

Use stratight-forward definition of DE_WINDOW_WIDTH register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_accel.c | 15 +-- drivers/staging/sm750fb/sm750_accel.h | 5 +++-- 2 files changed, 12 inser

[PATCH 13/21] staging: sm750fb: change definition of DE_SOURCE fields

Use stratight-forward definition of DE_SOURCE register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_accel.c | 9 - drivers/staging/sm750fb/sm750_accel.h | 11 +-- 2 files changed, 9 insertions(+

[PATCH 15/21] staging: sm750fb: change definition of DE_DIMENSION fields

Use stratight-forward definition of DE_DIMENSION register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_accel.c | 12 ++-- drivers/staging/sm750fb/sm750_accel.h | 5 +++-- 2 files changed, 9 insertions(+

[PATCH 20/21] staging: sm750fb: change definition of CRT_FB_WIDTH fields

Use stratight-forward definition of CRT_FB_WIDTH register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- drivers/staging/sm750fb/sm750_hw.c | 9 - 2 files changed, 7 insertions(+), 7 de

[PATCH 17/21] staging: sm750fb: change definition of DE_PITCH fields

Use stratight-forward definition of DE_PITCH register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_accel.c | 23 +++ drivers/staging/sm750fb/sm750_accel.h | 5 +++-- 2 files changed, 14 inse

[PATCH 16/21] staging: sm750fb: change definition of DE_CONTROL fields

Use stratight-forward definition of DE_CONTROL register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_accel.c | 45 +- drivers/staging/sm750fb/sm750_accel.h | 112 --

[PATCH 14/21] staging: sm750fb: change definition of DE_DESTINATION fields

Use stratight-forward definition of DE_DESTINATION register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_accel.c | 15 ++- drivers/staging/sm750fb/sm750_accel.h | 9 - 2 files changed, 10 in

[PATCH 06/21] staging: sm750fb: change definition of CRT_VERTICAL_SYNC fields

Use stratight-forward definition of CRT_VERTICAL_SYNC register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_mode.c | 7 +-- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- 2 files changed, 8 insertions(+),

[PATCH 07/21] staging: sm750fb: change definition of PANEL_HORIZONTAL_SYNC fields

Use stratight-forward definition of PANEL_HORIZONTAL_SYNC register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_mode.c | 7 +-- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- 2 files changed, 8 insertions

[PATCH 12/21] staging: sm750fb: change definition of HWC_COLOR_{12, 3} fields

Use straight-forward definition of HWC_COLOR_{12,3} register fields instead of magic numbers Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_cursor.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/

[PATCH 01/21] staging: sm750fb: change definition of CRT_AUTO_CENTERING_TL fields

Use stratight-forward definition of CRT_AUTO_CENTERING_TL register fields Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_mode.c | 4 +--- drivers/staging/sm750fb/ddk750_reg.h | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750

[PATCH 11/21] staging: sm750fb: change definition of HWC_LOCATION fields

Use BIT() macro for single-bit fields of HWC_LOCATION register and define HWC_LOCATION_{X,Y}_MASK for masking the address bits. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_cursor.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/s

[PATCH 10/21] staging: sm750fb: change definition of HWC_ADDRESS fields

Use BIT() macro for single-bit fields of HWC_ADDRESS register and define HWC_ADDRESS_ADDRESS_MASK for masking the address bits. Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/sm750_cursor.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/

[PATCH 02/21] staging: sm750fb: change definition of CRT_AUTO_CENTERING_BR fields

Use stratight-forward definition of CRT_AUTO_CENTERING_BR register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_mode.c | 5 +++-- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- 2 files changed, 6 insertions(+

[PATCH 05/21] staging: sm750fb: change definition of CRT_VERTICAL_TOTAL fields

Use stratight-forward definition of CRT_VERTICAL_TOTAL register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_mode.c | 7 +-- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- 2 files changed, 8 insertions(+)

[PATCH 03/21] staging: sm750fb: change definition of CRT_HORIZONTAL_TOTAL fields

Use stratight-forward definition of CRT_HORIZONTAL_TOTAL register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_mode.c | 7 +-- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- 2 files changed, 8 insertions(

[PATCH 04/21] staging: sm750fb: change definition of CRT_HORIZONTAL_SYNC fields

Use stratight-forward definition of CRT_HORIZONTAL_SYNC register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_mode.c | 7 +-- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- 2 files changed, 8 insertions(+

[PATCH 08/21] staging: sm750fb: change definition of PANEL_VERTICAL_TOTAL fields

Use stratight-forward definition of PANEL_VERTICAL_TOTAL register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_mode.c | 7 +-- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- 2 files changed, 8 insertions(

[PATCH 09/21] staging: sm750fb: change definition of PANEL_VERTICAL_SYNC fields

Use stratight-forward definition of PANEL_VERTICAL_SYNC register fields and use open-coded implementation for register manipulation Signed-off-by: Mike Rapoport --- drivers/staging/sm750fb/ddk750_mode.c | 7 +-- drivers/staging/sm750fb/ddk750_reg.h | 5 +++-- 2 files changed, 8 insertions(+

[PATCH 00/21] staging: sm750fb: change some register fields defines

Hi, This is the third set of patches that aim to replace custom defines for register fields. The ultimate goal is to have MSB:LSB notation for register fields and FIELD_* macros removed. Mike Rapoport (21): staging: sm750fb: change definition of CRT_AUTO_CENTERING_TL fields staging: sm750fb:

RE: Time for a code audit?

Re spaghetti: I certainly agree that most uses of 'goto' are evil. But I've found that when 'goto' is used to provide a single common exit-point for a function (e.g., "goto away"), it can lead to code that is much more readable and much less fragile than the alternative of sprinkling 'return's at

Re: Can I Trust You?

Hello, I hope this letter meets you in good time. It will be surprising to you to receive this proposal from me since you do not know me personally. However, I am sincerely seeking your confidence in this volunteer offer, which I propose with my free mind and as a person of integrity from God.

Re: [PATCH v3 5/5] Staging: rtl8188eu/core: make core more readable

On Sun, 2016-02-14 at 16:39 -0800, Greg Kroah-Hartman wrote: > On Fri, Feb 12, 2016 at 07:05:53PM +0100, Colin Vidal wrote: > > Signed-off-by: Colin Vidal > > --- > >  drivers/staging/rtl8188eu/core/rtw_iol.c | 10 +++--- > >  1 file changed, 3 insertions(+), 7 deletions(-) > > > > diff --git

Re: [PATCH v3 3/3] staging: rtl8723au: whitespace and blank line cleaning

Julian Calaby writes: > Hi Geliang, > > On Sun, Feb 7, 2016 at 2:30 PM, Geliang Tang wrote: >> This patch cleans whitespaces and blank lines surrounding >> list_for_each_entry*(). > > It does a lot more than this, including: > - Removing some unnecessary brackets > - Whitespace changes well awa

Re: [PATCH v3 2/3] staging: rtl8723au: core: rtw_recv: remove useless codes

Geliang Tang writes: > There are some useless codes in rtw_free_recvframe23a_queue() and > recvframe_defrag(), so remove them. > > Signed-off-by: Geliang Tang > --- > Changes in v3: > - split it into three patches. > Changes in v2: > - drop the coding style fixing in v1. > --- > drivers/stagin

Re: [PATCH v3 1/3] staging: rtl8723au: use list_for_each_entry*()

Geliang Tang writes: > Use list_for_each_entry*() instead of list_for_each*() to simplify > the code. > > Signed-off-by: Geliang Tang > --- > Changes in v3: > - split it into three patches. > Changes in v2: > - drop the coding style fixing in v1. > --- > drivers/staging/rtl8723au/core/rtw_ap.c

[PATCH 10/10] staging: lustre: DLC Feature dynamic net config

From: Amir Shehata This is the third patch of a set of patches that enables DLC. This patch adds the following features to LNET. Currently these features are not driven by user space. - Adding/Deleting Networks dynamically Two new functions were added: - lnet_dyn_add_ni() add an NI. if the

  1   2   >