[PATCH 4/5] staging: wilc1000: remove unused define

2016-03-02 Thread Chaehyun Lim
This patch removes INFINITE_SLEEP_TIME that is not used in the driver, so just remove it. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wlan_if.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan_if.h

[PATCH 3/5] staging: wilc1000: remove typedef from sdio_cmd53_t

2016-03-02 Thread Chaehyun Lim
This patch removes typedef from struct sdio_cmd53_t and renames it to sdio_cmd53. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_sdio.c| 10 +- drivers/staging/wilc1000/wilc_wlan_if.h | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-)

[PATCH 5/5] staging: wilc1000: remove typedef from enum tenuConnectSts

2016-03-02 Thread Chaehyun Lim
This patch removes typedef from enum tenuConnectSts and renames it to connect_status to avoid camelcase. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/coreconfigurator.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 2/5] staging: wilc1000: remove unnecessary comment codes

2016-03-02 Thread Chaehyun Lim
This patch removes unnecessary comment code in struct sdio_cmd53_t. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_wlan_if.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan_if.h

[PATCH 1/5] staging: wilc1000: remove typedef from struct sdio_cmd52_t

2016-03-02 Thread Chaehyun Lim
This patch removes typedef from struct sdio_cmd52_t and renames it to sdio_cmd52. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_sdio.c| 26 +- drivers/staging/wilc1000/wilc_wlan_if.h | 4 ++-- 2 files changed, 15

[PATCH 5/7] staging: lustre: check wr_id returned by ib_poll_cq

2016-03-02 Thread James Simmons
From: Liang Zhen If ib_poll_cq returned +ve without initialising ib_wc::wr_id (bug in driver), then o2iblnd will run into unpredictable situation because ib_wc::wr_id may refer to stale tx/rx pointer in stack. It indicates bug in HCA driver if this happened, ko2iblnd

[PATCH 1/7] staging: lustre: Support different ko2iblnd configs between systems

2016-03-02 Thread James Simmons
From: Jeremy Filizetti This patch adds suppoort for ko2iblnd to have different values for peer_credits and map_on_demand between systems. Signed-off-by: Jeremy Filizetti Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3322

[PATCH 6/7] staging: lustre: avoid intensive reconnecting for ko2iblnd

2016-03-02 Thread James Simmons
From: Liang Zhen When there is a connection race between two nodes and one side of the connection is rejected by the other side. o2iblnd will reconnect immediately, this is going to generate a lot of trashes if: - race winner is slow and can't send out connecting request

[PATCH 3/7] staging: lustre: take extra refcount in kiblnd_connreq_done

2016-03-02 Thread James Simmons
From: Liang Zhen refcount taken by cmid is not reliable after kiblnd_connreq_done released the glock because this connection is visible to other threads, another thread can find and close this connection right after kiblnd_connreq_done released the glock, if

[PATCH 7/7] staging: lustre: do less intense allocating retry for ko2iblnd

2016-03-02 Thread James Simmons
From: Liang Zhen ko2iblnd may retry too frequent for growing pools, all schedulers are spinning if another thread is in progress of allocating a new pool and can't finish right away because of high system load. Signed-off-by: Liang Zhen Intel-bug-id:

[PATCH 2/7] staging: lustre: make ko2iblnd connect parameters persistent

2016-03-02 Thread James Simmons
From: Amir Shehata Store map-on-demand and peertx credits in the peer, since the peer is persistent. Also made sure that when assigning the parameters received on the connection to the peer structure through create, that if another peer is added before grabbing the lock

[PATCH 4/7] staging: lustre: Change connect peer failed cleanup order

2016-03-02 Thread James Simmons
From: Doug Oucharek A race condition has been found where connd is cleaning up failed connections, the peer ref counter goes to zero, but we stil have a connecting counter > 0. One possible race is when we are retrying a connection by calling kiblnd_connect_peer()

[PATCH 0/7] All remaining outstanding bug fixes for ko2iblnd

2016-03-02 Thread James Simmons
Final missing bug fixes to bring the infiniband LND driver up to date with the latest code used in production system. Amir Shehata (1): staging: lustre: make ko2iblnd connect parameters persistent Doug Oucharek (1): staging: lustre: Change connect peer failed cleanup order Jeremy Filizetti

RE: [lustre-devel] [PATCH 00/27] Third batch of LNet fixes

2016-03-02 Thread Simmons, James A.
>On Wed, Mar 02, 2016 at 05:01:43PM -0500, James Simmons wrote: >> This patch set merges all the fixes for the klnd drivers, socklnd and >> o2iblnd, to what is currently used in production environments. Several >> more fixes for the LNet core are also included with this patch set. > >I've applied

RE: [lustre-devel] [PATCH] staging: lustre: Support different ko2iblnd configs between systems

2016-03-02 Thread Simmons, James A.
>On Wed, Mar 02, 2016 at 05:02:04PM -0500, James Simmons wrote: >> From: Jeremy Filizetti >> >> This patch adds suppoort for ko2iblnd to have different values for >> peer_credits and map_on_demand between systems. > >Your subject has no number for this patch, is it

Re: [PATCH 00/27] Third batch of LNet fixes

2016-03-02 Thread Greg Kroah-Hartman
On Wed, Mar 02, 2016 at 05:01:43PM -0500, James Simmons wrote: > This patch set merges all the fixes for the klnd drivers, socklnd and > o2iblnd, to what is currently used in production environments. Several > more fixes for the LNet core are also included with this patch set. I've applied the

Re: [PATCH] staging: lustre: Support different ko2iblnd configs between systems

2016-03-02 Thread Greg Kroah-Hartman
On Wed, Mar 02, 2016 at 05:02:04PM -0500, James Simmons wrote: > From: Jeremy Filizetti > > This patch adds suppoort for ko2iblnd to have different values for > peer_credits and map_on_demand between systems. Your subject has no number for this patch, is it really

Re: [PATCH] staging/lustre: Unbreak ll_prep_inode iget result check

2016-03-02 Thread Greg KH
On Wed, Mar 02, 2016 at 08:25:39AM -0500, gr...@linuxhacker.ru wrote: > From: Oleg Drokin > > commit 020ecc6f3229 ("staging: lustre: llite: Remove IS_ERR tests") > managed to break one of the converted checks by losing a dereference > causing the condition to be wrong and

[PATCH 24/27] staging: lustre: Change connect peer failed cleanup order

2016-03-02 Thread James Simmons
From: Doug Oucharek A race condition has been found where connd is cleaning up failed connections, the peer ref counter goes to zero, but we stil have a connecting counter > 0. One possible race is when we are retrying a connection by calling kiblnd_connect_peer()

[PATCH 08/27] staging: lustre: fix 'copy into fixed size buffer' errors

2016-03-02 Thread James Simmons
From: Sebastien Buisson Fix 'copy into fixed size buffer' defects found by Coverity version 6.0.3: Copy into fixed size buffer (STRING_OVERFLOW) The fixed-size string might be overrun by copying without checking the length. Signed-off-by: Sebastien Buisson

[PATCH 16/27] staging: lustre: reverse LNet and infinband header order

2016-03-02 Thread James Simmons
LNet is an abstraction built on top of network APIs such as infiniband or TCP/IP layer. Since LNet is dependent on these other layers we should ensure LNet headers should always come after the infiniband header since the infiniband headers can influence the LNet header definitions. Signed-off-by:

[PATCH 27/27] staging: lustre: do less intense allocating retry for ko2iblnd

2016-03-02 Thread James Simmons
From: Liang Zhen ko2iblnd may retry too frequent for growing pools, all schedulers are spinning if another thread is in progress of allocating a new pool and can't finish right away because of high system load. Signed-off-by: Liang Zhen Intel-bug-id:

[PATCH 22/27] staging: lustre: make ko2iblnd connect parameters persistent

2016-03-02 Thread James Simmons
From: Amir Shehata Store map-on-demand and peertx credits in the peer, since the peer is persistent. Also made sure that when assigning the parameters received on the connection to the peer structure through create, that if another peer is added before grabbing the lock

[PATCH 11/27] staging: lustre: bind socklnd peers to a specific CPT

2016-03-02 Thread James Simmons
Currently the socklnd driver doesn't support CPT affinity for its peers. Binding peers to a specific CPT and memory allocated to the NUMA node belonging to the CPT should give a performance boost. Signed-off-by: James Simmons Intel-bug-id:

[PATCH 02/27] staging: lustre: recv could access freed message

2016-03-02 Thread James Simmons
From: Liang Zhen When lnet_parse_put calls lnet_ptl_match_md, this function can attach current message on the delayed list if there is no match. It means this message can be taken over and freed by another thread who is posting new MD, then it is not safe for caller of

[PATCH 26/27] staging: lustre: avoid intensive reconnecting for ko2iblnd

2016-03-02 Thread James Simmons
From: Liang Zhen When there is a connection race between two nodes and one side of the connection is rejected by the other side. o2iblnd will reconnect immediately, this is going to generate a lot of trashes if: - race winner is slow and can't send out connecting request

[PATCH 25/27] staging: lustre: check wr_id returned by ib_poll_cq

2016-03-02 Thread James Simmons
From: Liang Zhen If ib_poll_cq returned +ve without initialising ib_wc::wr_id (bug in driver), then o2iblnd will run into unpredictable situation because ib_wc::wr_id may refer to stale tx/rx pointer in stack. It indicates bug in HCA driver if this happened, ko2iblnd

[PATCH 23/27] staging: lustre: take extra refcount in kiblnd_connreq_done

2016-03-02 Thread James Simmons
From: Liang Zhen refcount taken by cmid is not reliable after kiblnd_connreq_done released the glock because this connection is visible to other threads, another thread can find and close this connection right after kiblnd_connreq_done released the glock, if

[PATCH] staging: lustre: Support different ko2iblnd configs between systems

2016-03-02 Thread James Simmons
From: Jeremy Filizetti This patch adds suppoort for ko2iblnd to have different values for peer_credits and map_on_demand between systems. Signed-off-by: Jeremy Filizetti Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3322

[PATCH 19/27] staging: lustre: corrected some typos and grammar errors

2016-03-02 Thread James Simmons
From: Frank Zago Cleanup various typos and grammar errors. Signed-off-by: Frank Zago Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5710 Reviewed-on: http://review.whamcloud.com/12201 Reviewed-by: James Simmons Reviewed-by: Bob Glossman

[PATCH 18/27] staging: lustre: make o2iblnd_cb.c local functions static

2016-03-02 Thread James Simmons
From: Frank Zago This reduces the code size by about 1KiB. Signed-off-by: Frank Zago Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5396 Reviewed-on: http://review.whamcloud.com/11256 Reviewed-by: Patrick Farrell Reviewed-by: John L. Hammond

[PATCH 10/27] staging: lustre: replace direct LNet HZ access with kernel APIs

2016-03-02 Thread James Simmons
From: Jian Yu On some customers' systems, the kernel was compiled with HZ defined to 100, instead of 1000. This improves performance for HPC applications. However, to use these systems with Lustre, customers have to re-build Lustre for the kernel because Lustre directly uses

[PATCH 04/27] staging: lustre: return proper error code for LNet core

2016-03-02 Thread James Simmons
It is consider bad style in the linux kernel to return -1 or a positive number for an error. Instead return the appropriate error codes. Signed-off-by: James Simmons Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6142 Reviewed-on: http://review.whamcloud.com/17626

[PATCH 07/27] staging: lustre: issue in the offset in lnet match hash table

2016-03-02 Thread James Simmons
From: Alyona Romanenko the offset in hash table is overflowed for no wildcard portal. The offset for no wildcard has been corrected as for wildcard in the LU-1622 Signed-off-by: Alyona Romanenko Intel-bug-id:

[PATCH 14/27] staging: lustre: fix conctl.c issues found by Klocwork Insight tool

2016-03-02 Thread James Simmons
From: Dmitry Eremin The function lst_test_add_ioctl is always copying lstio_tes_param from userland even if the user doesn't send this data to LNet selftest. Only consider lstio_tes_param data if lstio_tes_param_len is not zero. Signed-off-by: Dmitry Eremin

[PATCH 12/27] staging: lustre: fix socklnd issues found by Klocwork Insight tool

2016-03-02 Thread James Simmons
From: Dmitry Eremin Null pointer 'best_iface' that comes from line 802 may be dereferenced at line 832. Signed-off-by: Dmitry Eremin Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4629 Reviewed-on: http://review.whamcloud.com/9386

[PATCH 15/27] staging: lustre: fix framework.c issues found by Klocwork Insight tool

2016-03-02 Thread James Simmons
From: Dmitry Eremin The functions sfw_test_buffers() and sfw_unload_test() from LNet selftest both assume sfw_test_instance_t being passed in is never null. This is corrected here. Signed-off-by: Dmitry Eremin Intel-bug-id:

[PATCH 06/27] staging: lustre: Use after free in lnet_ptl_match_delay()

2016-03-02 Thread James Simmons
From: Olaf Weber In lnet_ptl_match_delay() we check msg->msg_rx_delayed to see whether the message has been added to the delay queue. But this check is done after lnet_ptl_unlock() and lnet_res_unlock(), and the message can be processed and freed before the check. Replace the

[PATCH 13/27] staging: lustre: fix api-ni.c issues found by Klocwork Insight tool

2016-03-02 Thread James Simmons
From: Dmitry Eremin Pointer 'ni' checked for NULL at line 1569 may be passed to function and may be dereferenced there by passing argument 1 to function 'lnet_ni_notify_locked' at line 1621. Signed-off-by: Dmitry Eremin Intel-bug-id:

[PATCH 05/27] staging: lustre: remove annoying message in parse_nidrange

2016-03-02 Thread James Simmons
From: Li Xi When setting TBF rules of jobid, parse_nidrange() prints warning messages. However, this is unnecessary and annoying since paring a TBF rule will always try to parse the jobid like a nid. Signed-off-by: Li Xi Intel-bug-id:

[PATCH 09/27] staging: lustre: set task state before scheduling in lnet_sock_accept

2016-03-02 Thread James Simmons
From: John L. Hammond In the original code change when libcfs_sock_accept() was made into lnet_sock_accept() a call to set_current_state(TASK_INTERRUPTIBLE) got dropped which was restored. For upstream this is an optimization of calling init_waitqueue_entry() only if

[PATCH 17/27] staging: lustre: make o2iblnd local functions static

2016-03-02 Thread James Simmons
From: Frank Zago This fixes sparse warnings such as: .../o2iblnd.c:424:1: warning: symbol 'kiblnd_get_peer_info' was not declared. Should it be static? This reduces the code size by 400 bytes. The body of "the_o2iblnd" was moved at the end of the file, to

[PATCH 20/27] staging: lustre: change ibh_mrs from array to pointer

2016-03-02 Thread James Simmons
From: Amir Shehata With the removal of PMR we no longer require ibh_mrs field to be a array so change it to a simple pointer. Signed-off-by: Amir Shehata Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6850 Reviewed-on:

[PATCH 03/27] staging: lustre: Ignore hops if not explicitly set

2016-03-02 Thread James Simmons
From: Amir Shehata Since the # of hops is not a mandatory parameter the LU-6060 patch will cause problems to already existing systems since it changes the behavior by which a route is determined down. To fix this case the # of hops now defaults to LNET_UNDEFINED_HOPS if

[PATCH 01/27] staging: lustre: set downis to 1 if there's no NI for remote net

2016-03-02 Thread James Simmons
From: Liang Zhen lnet_route_t::lr_downis is marked as zero even if there is no NI to target network, this is wrong and breaks logic of ARF. This patch fixes this problem. Signed-off-by: Liang Zhen Intel-bug-id:

[PATCH 00/27] Third batch of LNet fixes

2016-03-02 Thread James Simmons
This patch set merges all the fixes for the klnd drivers, socklnd and o2iblnd, to what is currently used in production environments. Several more fixes for the LNet core are also included with this patch set. Alyona Romanenko (1): staging: lustre: issue in the offset in lnet match hash table

[PATCH] staging/android: add flags member to sync ioctl structs

2016-03-02 Thread Gustavo Padovan
From: Gustavo Padovan Play safe and add flags member to all structs. So we don't need to break API or create new IOCTL in the future if new features that requires flags arises. v2: check if flags are valid (zero, in this case) v3: return -EINVAL if flags are

Re: [PATCH v6 4/6] staging/android: align struct sync_merge_data to a multiple of 64-bits

2016-03-02 Thread Gustavo Padovan
2016-03-02 Gustavo Padovan : > From: Gustavo Padovan > > Change order of the field to avoid alignment issues with 64 bits > platforms. > > Signed-off-by: Gustavo Padovan > --- >

Re: [staging:staging-next 1186/1234] drivers/staging/lustre/lustre/llite/file.c:2749:7: error: 'F_SETLKW64' undeclared

2016-03-02 Thread Greg Kroah-Hartman
On Wed, Mar 02, 2016 at 03:29:24AM -0500, Oleg Drokin wrote: > > On Mar 2, 2016, at 2:31 AM, kbuild test robot wrote: > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > staging-next > > head: 5a9ff74d8e681f9ac6af6cc1444a812b74e7c2de > > commit:

[PATCH v6 4/6] staging/android: align struct sync_merge_data to a multiple of 64-bits

2016-03-02 Thread Gustavo Padovan
From: Gustavo Padovan Change order of the field to avoid alignment issues with 64 bits platforms. Signed-off-by: Gustavo Padovan --- drivers/staging/android/uapi/sync.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v6 5/6] staging/android: refactor SYNC_IOC_FILE_INFO

2016-03-02 Thread Gustavo Padovan
From: Gustavo Padovan Change SYNC_IOC_FILE_INFO behaviour to avoid future API breaks and optimize buffer Now num_fences can be filled by the caller to inform how many fences it wants to retrieve from the kernel. If the num_fences passed is greater than zero

[PATCH v6 3/6] staging/android: remove redundant comments on sync_merge_data

2016-03-02 Thread Gustavo Padovan
From: Gustavo Padovan struct sync_merge_data already have documentation on top of the struct definition. No need to duplicate it. Signed-off-by: Gustavo Padovan Reviewed-by: Maarten Lankhorst

[PATCH v6 1/6] staging/android: add num_fences field to struct sync_file_info

2016-03-02 Thread Gustavo Padovan
From: Gustavo Padovan Inform userspace how many fences are in the sync_fence_info field. Signed-off-by: Gustavo Padovan Reviewed-by: Maarten Lankhorst --- drivers/staging/android/sync.c

[PATCH v6 6/6] staging/android: add flags member to sync ioctl structs

2016-03-02 Thread Gustavo Padovan
From: Gustavo Padovan Play safe and add flags member to all structs. So we don't need to break API or create new IOCTL in the future if new features that requires flags arises. v2: check if flags are valid (zero, in this case) v3: return -EINVAL if flags are

[PATCH v6 2/6] staging/android: rename SYNC_IOC_FENCE_INFO

2016-03-02 Thread Gustavo Padovan
From: Gustavo Padovan We don't use the 'fence' name to refer to sync_file anymore. So rename it to SYNC_IOC_FILE_INFO. Signed-off-by: Gustavo Padovan Reviewed-by: Maarten Lankhorst ---

Re: [PATCH v5 5/5] staging/android: add flags member to sync ioctl structs

2016-03-02 Thread Gustavo Padovan
Hi Emil, 2016-03-02 Emil Velikov : > On 1 March 2016 at 13:13, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Play safe and add flags member to all structs. So we don't need to > > break API or create new

[PATCH 2/2] isdn: i4l: move active-isdn drivers to staging

2016-03-02 Thread Arnd Bergmann
The icn, act2000 and pcbit drivers are all for very old hardware, and it is highly unlikely that anyone is actually still using them on modern kernels, if at all. All three drivers apparently are for hardware that predates PCI being the common connector, as they are ISA-only and active PCI ISDN

RE: [PATCH 0/2] staging: comedi: comedi.h: Avoid BIT macro

2016-03-02 Thread Hartley Sweeten
On Wednesday, March 02, 2016 7:28 AM, Ian Abbott wrote: > Patch 1 effectively reverts commit 72315cdaba9d on linux-next "Staging: > comedi: Prefer using the BIT macro"), but I replaced the use of the BIT > macro with hexadecimal constants instead of the original left bit-shift > expressions. We

[PATCH 1/2] staging: comedi: comedi.h: Do not use BIT macro

2016-03-02 Thread Ian Abbott
The "comedi.h" file is part of the user API for COMEDI devices, and is intended to be migrated to "include/uapi/linux". The `BIT` macro from "include/linux/bitops.h" should not be used there. Replace the use of the `BIT` macro with hexadecimal constants of the same value. The `BIT` macro

[PATCH 0/2] staging: comedi: comedi.h: Avoid BIT macro

2016-03-02 Thread Ian Abbott
Patch 1 effectively reverts commit 72315cdaba9d on linux-next "Staging: comedi: Prefer using the BIT macro"), but I replaced the use of the BIT macro with hexadecimal constants instead of the original left bit-shift expressions. We shouldn't use the BIT macro in "comedi.h" as it is intended to be

[PATCH 2/2] staging: comedi: comedi.h: Fix comment for struct comedi_krange

2016-03-02 Thread Ian Abbott
The kernel-doc comment for `struct comedi_krange` refers to the macro constant `RF_external`. It should be `RF_EXTERNAL`, so fix it. It also documents the value of the constant as `(1 << 8)`, but the macro now expands to the hexadecimal constant `0x100`, so use that as the documented value.

Re: [PATCH] staging: rtl8723au: fix static checker warning

2016-03-02 Thread Dan Carpenter
On Tue, Mar 01, 2016 at 11:22:23PM +0800, Geliang Tang wrote: > Fix the following static checker warning: > > drivers/staging/rtl8723au/core/rtw_sta_mgt.c:365 rtw_get_stainfo23a() > error: potential NULL dereference 'psta'. > > Fixes: e280d71("staging: rtl8723au: use list_for_each_entry*()") >

Re: [RFC PATCH 1/2] iio: core: implement iio_{claim|release}_direct_mode()

2016-03-02 Thread Lars-Peter Clausen
On 03/01/2016 08:02 PM, Alison Schofield wrote: > It is often the case that the driver wants to be sure a device stays > in direct mode while it is executing a task or series of tasks. To > accomplish this today, the driver performs this sequence: 1) take the > device state lock, 2)verify it is

[PATCH] staging/lustre: Unbreak ll_prep_inode iget result check

2016-03-02 Thread green
From: Oleg Drokin commit 020ecc6f3229 ("staging: lustre: llite: Remove IS_ERR tests") managed to break one of the converted checks by losing a dereference causing the condition to be wrong and hence leading to a crash later on in case of actual error. IS_ERR_OR_NULL(*inode)

[PATCH] Drivers: hv: kvp: fix IP Failover

2016-03-02 Thread Vitaly Kuznetsov
Hyper-V VMs can be replicated to another hosts and there is a feature to set different IP for replicas, it is called 'Failover TCP/IP'. When such guest starts Hyper-V host sends it KVP_OP_SET_IP_INFO message as soon as we finish negotiation procedure. The problem is that it can happen (and it

Re: [PATCH v5 5/5] staging/android: add flags member to sync ioctl structs

2016-03-02 Thread Emil Velikov
On 1 March 2016 at 13:13, Gustavo Padovan wrote: > From: Gustavo Padovan > > Play safe and add flags member to all structs. So we don't need to > break API or create new IOCTL in the future if new features that requires > flags arises. > >

Re: [staging:staging-next 1186/1234] drivers/staging/lustre/lustre/llite/file.c:2749:7: error: 'F_SETLKW64' undeclared

2016-03-02 Thread Oleg Drokin
On Mar 2, 2016, at 2:31 AM, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-next > head: 5a9ff74d8e681f9ac6af6cc1444a812b74e7c2de > commit: caa88c26575c9be856e5a801abd121d7ff0808f8 [1186/1234] staging/lustre: > F_SETLKW64

[PATCH 04/10] staging: rtl8188eu: remove unnecessary debug output from os_dep/usb_intf.c

2016-03-02 Thread Ivan Safonov
Debug output in rtw_drw_init is excess Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c index

[PATCH 08/10] staging: rtl8188eu: remove PWR_FAB_*_MSK macro definitions and fab_msk of wl_pwr_cfg structure

2016-03-02 Thread Ivan Safonov
fab_msk used for marking commands for devices of a certain manufacturer. However, always used only PWR_FAB_ALL_MSK value of fab_msk. Most likely, such mark is useless. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/pwrseqcmd.c | 10 +-

[PATCH 03/10] staging: rtl8188eu: remove unused macros from include/basic_types.h

2016-03-02 Thread Ivan Safonov
FIELD_OFFSET, READEF1BYTE, READEF2BYTE, READEF4BYTE WRITEEF1BYTE, WRITEEF2BYTE, WRITEEF4BYTE are removed. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/basic_types.h | 29 - 1 file changed, 29 deletions(-) diff --git

[PATCH 01/10] staging: rtl8188eu: FIELD_OFFSET macro replaced by offsetof macro

2016-03-02 Thread Ivan Safonov
FIELD_OFFSET and offsetof macro are equal Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 4 ++-- drivers/staging/rtl8188eu/include/drv_types.h | 4 ++-- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 6 +++--- 3 files changed, 7

[PATCH 07/10] staging: rtl8188eu: remove FabVersion member of odm_dm_struct struct

2016-03-02 Thread Ivan Safonov
Value of this variable is hardcoded and used only to produce debug output. Probably, FabVersion is useless. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/odm.c | 4 drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 4 +---

[PATCH 02/10] staging: rtl8188eu: remove unused include/ieee80211_ext.h

2016-03-02 Thread Ivan Safonov
This file is not used for the driver compiling Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/ieee80211_ext.h | 290 -- 1 file changed, 290 deletions(-) delete mode 100644 drivers/staging/rtl8188eu/include/ieee80211_ext.h diff --git

[PATCH 06/10] staging: rtl8188eu: remove chip_type of the adapter structure

2016-03-02 Thread Ivan Safonov
chip_type variable is unnecessary here, because this driver is only for one chip and it is not used after initialization. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/include/drv_types.h | 2 -- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 - 2 files

[PATCH 05/10] staging: rtl8188eu: replace (a == NULL) to (!a) in rtw_drv_init

2016-03-02 Thread Ivan Safonov
It is a checkpatch cleanups: CHECK: Comparasion to NULL could be written ... Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/os_dep/usb_intf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c

[PATCH 10/10] staging: rtl8188eu: remove PWR_BASEADDR_* macro definitions and "base" member of wl_pwr_cfg structure

2016-03-02 Thread Ivan Safonov
These macros and "base" member of wl_pwr_cfg structure are used only to produce debug output. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/pwrseqcmd.c | 3 +- drivers/staging/rtl8188eu/include/pwrseq.h| 165 ++

[PATCH 09/10] staging: rtl8188eu: remove PWR_INTF_*_MSK macro definitions and interface_mask of wl_pwr_cfg structure

2016-03-02 Thread Ivan Safonov
This driver is intended only for usb devices. Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/hal/pwrseqcmd.c | 10 +- drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 +- drivers/staging/rtl8188eu/include/pwrseq.h| 139 +-