[PATCH 1/1] Staging: comedi: fix CHECK: Prefer using the BIT macro issues in pcmmio.c

2016-05-17 Thread Ravishankar Karkala Mallikarjunayya
This patch Replace all occurences of (1< --- drivers/staging/comedi/drivers/pcmmio.c | 40

[PATCH v2] Drivers: hv: vmbus: fix the race when querying & updating the percpu list

2016-05-17 Thread Dexuan Cui
There is a rare race when we remove an entry from the global list hv_context.percpu_list[cpu] in hv_process_channel_removal() -> percpu_channel_deq() -> list_del(): at this time, if vmbus_on_event() -> process_chn_event() -> pcpu_relid2channel() is trying to query the list, we can get the general

Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue

2016-05-17 Thread Amit Ghadge
On Tue, May 17, 2016 at 06:47:56AM -0700, Greg KH wrote: > A: http://en.wikipedia.org/wiki/Top_post > Q: Were do I find info about this thing called top-posting? > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q:

Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86

2016-05-17 Thread Greg KH
On Tue, May 17, 2016 at 07:49:53PM -0400, Jes Sorensen wrote: > Greg KH writes: > > On Tue, May 17, 2016 at 10:01:55AM -0400, Jes Sorensen wrote: > >> Greg KH writes: > >> > On Tue, May 17, 2016 at 03:27:56AM -0400, David Kershner wrote: >

Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86

2016-05-17 Thread Jes Sorensen
Greg KH writes: > On Tue, May 17, 2016 at 10:01:55AM -0400, Jes Sorensen wrote: >> Greg KH writes: >> > On Tue, May 17, 2016 at 03:27:56AM -0400, David Kershner wrote: >> >> This patchset moves the visorbus driver >> >>

RE: [PATCH 14/14] staging: comedi: daqboard2000: prefer usleep_range()

2016-05-17 Thread Hartley Sweeten
On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: > The checkpatch.pl warns about two `udelay(x)` calls, one of 100 > microseconds, and one of 10 microseconds. The 100 microseconds one is > used when waiting for FPGA to become ready to accept firmware, and is > not that critical, so replace it

RE: [PATCH 06/14] staging: comedi: daqboard2000: rename register offset macros

2016-05-17 Thread Hartley Sweeten
On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: > Rename the macros defining register offsets to avoid CamelCase, and to > use namespace associated with the driver. > > Signed-off-by: Ian Abbott > --- > Other CamelCase issues in this patch will be dealt with by later >

RE: [PATCH 05/14] staging: comedi: daqboard2000: rename serial EEPROM register macros

2016-05-17 Thread Hartley Sweeten
On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: > Rename the macros defining values for the Serial EEPROM Control Register > to avoid CamelCase. > > Signed-off-by: Ian Abbott > --- > drivers/staging/comedi/drivers/daqboard2000.c | 26 +- > 1 file

RE: [PATCH 01/14] staging: comedi: daqboard2000: remove commented out code

2016-05-17 Thread Hartley Sweeten
On Tuesday, May 17, 2016 2:53 AM, Ian Abbott wrote: > Remove some commented out code. Some of it uses constructs that don't > exist in the driver, and probably come from the source code for the MS > Windows driver. > > Signed-off-by: Ian Abbott > --- >

[PATCH] Staging: comedi: quatech_daqp_cs.c: Fix a unsigned warning issue

2016-05-17 Thread Amit Ghadge
This is a patch to the quatech_daqp_cs.c file that fixes by using unsigned int instead of unsigned, following warning found by checkpatch. * WARNING: Prefer 'unsigned int' to bare use of 'unsigned' Signed-off-by: Amit Ghadge ---

Re: [lustre-devel] [PATCH v2] staging/lustre/ptlrpc: Removes potential null dereference

2016-05-17 Thread Dan Carpenter
On Tue, May 17, 2016 at 10:22:20AM -0400, Lidza Louina wrote: > if (rc < 0) and if (rc) pretty much translates to the same thing. I wasn't talking about this patch in particular; it's just something I have thinking about recently. For example, there are a lot of functions that don't initialize

''My Proposal'' Pls Reply

2016-05-17 Thread Mrs. Desort Sali
Hi, I'AM Mrs. Desort Sali. I sent you a copy here... Pardon me for contacting through this medium; I am compelled to do so for some reason. I am a cashier at a Bank. There's one of my client who had certain sum deposited with us but had died some years ago, this made me to contact you for

Re: [PATCH 0/7] fix typo

2016-05-17 Thread Kalle Valo
Julia Lawall writes: > On Tue, 17 May 2016, Kalle Valo wrote: > >> Julia Lawall writes: >> >> > firmare -> firmware >> > >> > --- >> > >> > drivers/media/dvb-frontends/mn88473.c |2 +- >> > drivers/net/wireless/ath/ath6kl/core.h |2

Re: [PATCH 0/7] fix typo

2016-05-17 Thread Julia Lawall
On Tue, 17 May 2016, Kalle Valo wrote: > Julia Lawall writes: > > > firmare -> firmware > > > > --- > > > > drivers/media/dvb-frontends/mn88473.c |2 +- > > drivers/net/wireless/ath/ath6kl/core.h |2 +- > > drivers/net/wireless/marvell/mwifiex/pcie.c |

Re: [PATCH 0/7] fix typo

2016-05-17 Thread Kalle Valo
Julia Lawall writes: > firmare -> firmware > > --- > > drivers/media/dvb-frontends/mn88473.c |2 +- > drivers/net/wireless/ath/ath6kl/core.h |2 +- > drivers/net/wireless/marvell/mwifiex/pcie.c |2 +- It would be good to know in advance what tree you

[PATCH 0/7] fix typo

2016-05-17 Thread Julia Lawall
firmare -> firmware --- drivers/media/dvb-frontends/mn88473.c |2 +- drivers/net/wireless/ath/ath6kl/core.h |2 +- drivers/net/wireless/marvell/mwifiex/pcie.c |2 +- drivers/scsi/pm8001/pm8001_init.c |2 +- drivers/scsi/snic/snic_fwint.h |2

[PATCH 4/7] staging: wilc1000: fix typo

2016-05-17 Thread Julia Lawall
firmare -> firmware Signed-off-by: Julia Lawall --- drivers/staging/wilc1000/linux_wlan.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index 4f93c11..274c390 100644

[PATCH 3/7] [media] mn88472: fix typo

2016-05-17 Thread Julia Lawall
firmare -> firmware Signed-off-by: Julia Lawall --- drivers/staging/media/mn88472/mn88472.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c index 7ea749c..5cfa22a

Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86

2016-05-17 Thread Greg KH
On Tue, May 17, 2016 at 10:01:55AM -0400, Jes Sorensen wrote: > Greg KH writes: > > On Tue, May 17, 2016 at 03:27:56AM -0400, David Kershner wrote: > >> This patchset moves the visorbus driver > >> (fromdrivers/staging/unisys/visorbus) > >> and its dependent headers

Re: [lustre-devel] [PATCH v2] staging/lustre/ptlrpc: Removes potential null dereference

2016-05-17 Thread Lidza Louina
On 05/17/2016 02:53 AM, Dan Carpenter wrote: When I read the code, I just assumed desc was a pointer and it should have been: if (!desc) return NULL; For me, "if (rc) " is way more readable than "if (rc != 0) ". So readability could go either way depending on what

Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86

2016-05-17 Thread Jes Sorensen
Greg KH writes: > On Tue, May 17, 2016 at 03:27:56AM -0400, David Kershner wrote: >> This patchset moves the visorbus driver (fromdrivers/staging/unisys/visorbus) >> and its dependent headers files (from drivers/staging/unisys/include) >> out of staging into the main

Re: [PATCH 4/5] staging: unisys: visorbus: Have visorbus use include/linux/visorbus

2016-05-17 Thread Greg KH
On Tue, May 17, 2016 at 03:28:00AM -0400, David Kershner wrote: > Since we have now moved the include directories over to > include/linux/visorbus this patch makes all of visorbus > use the new include folders. > > Signed-off-by: David Kershner > --- >

Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86

2016-05-17 Thread Greg KH
On Tue, May 17, 2016 at 03:27:56AM -0400, David Kershner wrote: > This patchset moves the visorbus driver (fromdrivers/staging/unisys/visorbus) > and its dependent headers files (from drivers/staging/unisys/include) > out of staging into the main kernel tree. > > The visorbus driver is a bus

Re: [PATCH 3/5] Documentation: Move visorbus documentation from staging to Documentation/

2016-05-17 Thread Greg KH
On Tue, May 17, 2016 at 03:27:59AM -0400, David Kershner wrote: > This patch simple does a git mv of the > drivers/staging/unisys/Documentation directory to Documentation. Renames > overview.txt to visorbus.txt and renames sysfs-platform-visorchipset to > the correct name sysfs-bus-visorbus. > >

Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue

2016-05-17 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I

[PATCH] tools: hv: update buffer handling in hv_fcopy_daemon

2016-05-17 Thread Olaf Hering
Currently this warning is triggered when compiling hv_fcopy_daemon: hv_fcopy_daemon.c:216:4: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] kernel_modver = *(__u32 *)buffer; Convert the send/receive buffer to a union and pass individual

[PATCH 1/2] Staging: comedi: Fix WARNING issue in s626.c

2016-05-17 Thread Ravishankar Karkala Mallikarjunayya
This is a patch to the s626.c file that fixes up a Block comments issues found by the checkpatch.pl tool. i.e. Block comments use a trailing */ on a separate line Signed-off-by: Ravishankar Karkala Mallikarjunayya --- drivers/staging/comedi/drivers/s626.c | 60

[PATCH 2/2] Staging: comedi: fix type issue in s626.c

2016-05-17 Thread Ravishankar Karkala Mallikarjunayya
This is a patch to the s626.c file that fixes up a type issues found by the checkpatch.pl tool. i.e Prefer kernel type 'u8' over 'uint8_t' Prefer kernel type 'u16' over 'uint16_t' Prefer kernel type 'u32' over 'uint32_t' Prefer kernel type 's16' over 'int16_t' Prefer kernel type

[PATCH 1/1] Staging: comedi: Fix WARNING issue in dt2801.c

2016-05-17 Thread Ravishankar Karkala Mallikarjunayya
This is a patch to the dt2801.c file that fixes up a Block comments issues found by the checkpatch.pl tool. i.e. Block comments use a trailing */ on a separate line Signed-off-by: Ravishankar Karkala Mallikarjunayya --- drivers/staging/comedi/drivers/dt2801.c | 95

[PATCH 12/14] staging: comedi: daqboard2000: rename reference DACs register macros

2016-05-17 Thread Ian Abbott
Rename the macros that define values for the reference DACs register to avoid CamelCase, and to make it clearer which register they are associated with. Add a macro `DAQBOARD2000_REF_DACS_SET` for the value `0x80` that triggers setting one of the references. Signed-off-by: Ian Abbott

[PATCH 11/14] staging: comedi: daqboard2000: rename trigger control register macros

2016-05-17 Thread Ian Abbott
Rename the macros that define values for the trigger control register to avoid CamelCase, and to make it clearer which register they are associated with. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/daqboard2000.c | 26 ++ 1 file

[PATCH 08/14] staging: comedi: daqboard2000: rename acq status register macros

2016-05-17 Thread Ian Abbott
Rename the macros associated with the acquisition status register to avoid CamelCase and to make it clear which register they are associated with. Add a macro to define the offset of the read-only acquisition status register. It's the same offset as the acquisition control register, which is

[PATCH 13/14] staging: comedi: daqboard2000: rename CamelCase functions

2016-05-17 Thread Ian Abbott
Rename functions to avoid CamelCase warnings from checkpatch, and to use namespace associated with the driver. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/daqboard2000.c | 80 ++- 1 file changed, 41 insertions(+), 39 deletions(-) diff

[PATCH 09/14] staging: comedi: daqboard2000: redo DAC control register macros

2016-05-17 Thread Ian Abbott
Rename the macros used to define values for the DAC control register to avoid CamelCase and to make it clearer which register they are associated with. Refactor the macros used to define values to enable or disable DAC channels to use the channel number as a parameter. None of these macros are

[PATCH 10/14] staging: comedi: daqboard2000: redo DAC status macros and fix busy

2016-05-17 Thread Ian Abbott
Rename the macros defining values for the DAC status register to avoid CamelCase, and to make it clear which register they are associated with. Refactor the macros defining the regular DAC channel "busy" bits into a single macro that takes the DAC channel number as a parameter. Add a macro to

[PATCH 14/14] staging: comedi: daqboard2000: prefer usleep_range()

2016-05-17 Thread Ian Abbott
The checkpatch.pl warns about two `udelay(x)` calls, one of 100 microseconds, and one of 10 microseconds. The 100 microseconds one is used when waiting for FPGA to become ready to accept firmware, and is not that critical, so replace it with a call to `usleep_range(100, 1000)`. The 10

[PATCH 03/14] staging: comedi: daqboard2000: CHECK: spaces preferred around that '*'

2016-05-17 Thread Ian Abbott
Fix checkpatch issues of the form "CHECK: spaces preferred around that '*' (ctx:VxV)". Signed-off-by: Ian Abbott --- CamelCase issues in this patch will be dealt with by later patches. --- drivers/staging/comedi/drivers/daqboard2000.c | 8 1 file changed, 4

[PATCH 06/14] staging: comedi: daqboard2000: rename register offset macros

2016-05-17 Thread Ian Abbott
Rename the macros defining register offsets to avoid CamelCase, and to use namespace associated with the driver. Signed-off-by: Ian Abbott --- Other CamelCase issues in this patch will be dealt with by later patches in the series. ---

[PATCH 01/14] staging: comedi: daqboard2000: remove commented out code

2016-05-17 Thread Ian Abbott
Remove some commented out code. Some of it uses constructs that don't exist in the driver, and probably come from the source code for the MS Windows driver. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/daqboard2000.c | 6 -- 1 file changed, 6 deletions(-)

[PATCH 07/14] staging: comedi: daqboard2000: rename acquisition control register macros

2016-05-17 Thread Ian Abbott
Rename the macros defining values for the acquisition control register to avoid CamelCase, and to make it clearer which register they are associated with. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/daqboard2000.c | 50 --- 1 file

[PATCH 05/14] staging: comedi: daqboard2000: rename serial EEPROM register macros

2016-05-17 Thread Ian Abbott
Rename the macros defining values for the Serial EEPROM Control Register to avoid CamelCase. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/daqboard2000.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git

[PATCH 02/14] staging: comedi: daqboard2000: use usual block comment style

2016-05-17 Thread Ian Abbott
Reformat one of the block comments to conform to the usual style (it's the only one that doesn't). Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/daqboard2000.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 04/14] staging: comedi: daqboard2000: add blank line after struct declaration

2016-05-17 Thread Ian Abbott
Fix checkpatch issue: "CHECK: Please use a black line after function/struct/union/enum declarations". Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/daqboard2000.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/comedi/drivers/daqboard2000.c

[PATCH 00/14] staging: comedi: daqboard2000: checkpatch clean-ups

2016-05-17 Thread Ian Abbott
This series of patches to the daqboard2000 driver is mostly to fix the checkpatch.pl warnings. There is one warning remaining about one of the `udelay` calls with a parameter of 10 microseconds, but I decided to leave it alone, as converting it to `usleep_range` could increase firmware loading

Re: [PATCH 6/6] intel_sgx: TODO file for the staging area

2016-05-17 Thread Jarkko Sakkinen
On Tue, Apr 26, 2016 at 11:38:22PM -0700, Jethro Beekman wrote: > On 26-04-16 04:23, Jarkko Sakkinen wrote: > > In order to write test code I would need to use the SDK at minimum to > > generate EINITTOKEN for the test enclave. > > You could do this right now with the Rust tools for SGX [1]

如何进行新流程设计(To-Be)和推行

2016-05-17 Thread 管���I
卓越流程体系.xls Description: Binary data ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

RE: [PATCH] Drivers: hv: vmbus: fix the race when querying & updating the percpu list

2016-05-17 Thread Dexuan Cui
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf > Of Dexuan Cui > > > > Do we need to do tasklet_schedule() to make sure there are no events > > pending? This is probably not a big issue as some other event will > > trigger scheduling but in some corner cases it may

RE: [PATCH] Drivers: hv: vmbus: fix the race when querying & updating the percpu list

2016-05-17 Thread Dexuan Cui
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Tuesday, May 17, 2016 16:15 > To: Dexuan Cui > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.com; KY

Re: [PATCH] Drivers: hv: vmbus: fix the race when querying & updating the percpu list

2016-05-17 Thread Vitaly Kuznetsov
Dexuan Cui writes: > There is a rare race when we remove an entry from the global list > hv_context.percpu_list[cpu] in hv_process_channel_removal() -> > percpu_channel_deq() -> list_del(): at this time, if vmbus_on_event() -> > process_chn_event() -> pcpu_relid2channel() is

[PATCH 2/5] include: linux: visorbus: Add visorbus to include/linux directory

2016-05-17 Thread David Kershner
Update include/linux to include the s-Par associated common include header files needed for the s-Par visorbus. Signed-off-by: David Kershner --- include/linux/visorbus/channel.h | 572 +++ include/linux/visorbus/channel_guid.h|

[PATCH 4/5] staging: unisys: visorbus: Have visorbus use include/linux/visorbus

2016-05-17 Thread David Kershner
Since we have now moved the include directories over to include/linux/visorbus this patch makes all of visorbus use the new include folders. Signed-off-by: David Kershner --- drivers/staging/unisys/visorbus/controlvmchannel.h | 2 +-

[PATCH 1/5] staging: unisys: Move vbushelper.h to visorbus directory

2016-05-17 Thread David Kershner
Only visorbus needs this header file so move it to visorbus directory. Signed-off-by: David Kershner --- drivers/staging/unisys/include/vbushelper.h | 46 drivers/staging/unisys/visorbus/vbushelper.h | 46 2

[PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86

2016-05-17 Thread David Kershner
This patchset moves the visorbus driver (fromdrivers/staging/unisys/visorbus) and its dependent headers files (from drivers/staging/unisys/include) out of staging into the main kernel tree. The visorbus driver is a bus driver for various paravirtualized devices presented within a Unisys s-Par

[PATCH 3/5] Documentation: Move visorbus documentation from staging to Documentation/

2016-05-17 Thread David Kershner
This patch simple does a git mv of the drivers/staging/unisys/Documentation directory to Documentation. Renames overview.txt to visorbus.txt and renames sysfs-platform-visorchipset to the correct name sysfs-bus-visorbus. Signed-off-by: David Kershner ---

Re: [lustre-devel] [PATCH v2] staging/lustre/ptlrpc: Removes potential null dereference

2016-05-17 Thread Dan Carpenter
When I read the code, I just assumed desc was a pointer and it should have been: if (!desc) return NULL; For me, "if (rc) " is way more readable than "if (rc != 0) ". So readability could go either way depending on what you're used to, I suppose. It should definitely ==