Re: [PATCH] speakup: Add spinlock in synth_direct_store

2016-09-05 Thread Vaishali Thakkar
On Monday 05 September 2016 06:47 PM, Pavel Andrianov wrote: > All operations with synth buffer should be protected, > as there are global pointers, which should be modified atomically. > > Found by Linux Driver Verification project (linuxtesting.org) > > Signed-off-by: Pavel Andrianov

Re: [PATCH] android: binder: use VM_ALLOC to get vm area.

2016-09-05 Thread Ganesh Mahendran
2016-09-02 3:59 GMT+08:00 Arve Hjønnevåg : > On Thu, Sep 1, 2016 at 12:02 PM, Greg KH wrote: >> On Thu, Sep 01, 2016 at 02:41:04PM +0800, Ganesh Mahendran wrote: >>> VM_IOREMAP is used to access hardware through a mechanism called >>> I/O mapped

Re: [PATCH] android: binder: use VM_ALLOC to get vm area.

2016-09-05 Thread Ganesh Mahendran
Hi, Greg: 2016-09-02 3:02 GMT+08:00 Greg KH : > On Thu, Sep 01, 2016 at 02:41:04PM +0800, Ganesh Mahendran wrote: >> VM_IOREMAP is used to access hardware through a mechanism called >> I/O mapped memory. Android binder is a IPC machanism which will >> not access I/O

hello devel

2016-09-05 Thread Nguyn u00c1nh ngc
hiya devel http://www.izmirservisi.biz/particularly.php?deal=rd1pupds924vnct4e Take care ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] speakup: Add spinlock in synth_direct_store

2016-09-05 Thread Samuel Thibault
Pavel Andrianov, on Mon 05 Sep 2016 16:17:47 +0300, wrote: > All operations with synth buffer should be protected, > as there are global pointers, which should be modified atomically. > > Found by Linux Driver Verification project (linuxtesting.org) > > Signed-off-by: Pavel Andrianov

Re: [PATCH] staging: dgnc: Fix multi line comment alignment

2016-09-05 Thread Andrey Utkin
On Mon, Sep 05, 2016 at 08:28:32PM +0200, Fernando Apesteguia wrote: > Fix alignment in multi line comment block. > > Remove extra '*' to use the preferred comment style as in > Documentation/CodingStyle > > Signed-off-by: Fernando Apesteguia > > --- >

[PATCH] staging: dgnc: Fix multi line comment alignment

2016-09-05 Thread Fernando Apesteguia
Fix alignment in multi line comment block. Remove extra '*' to use the preferred comment style as in Documentation/CodingStyle Signed-off-by: Fernando Apesteguia --- drivers/staging/dgnc/dgnc_driver.c | 50 +++--- 1 file changed,

[PATCH v2] Staging: comedi: das08_cs: Fix block comments use * on subsequent lines.

2016-09-05 Thread Amit Ghadge
Fixes checkpatch warning in das08_cs.c file: WARNING: Block comments use * on subsequent lines Added * in blank line in comment block. Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/das08_cs.c | 76 +++ 1 file changed, 38

Re: [PATCH v2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

2016-09-05 Thread Amit Ghadge
On Mon, Sep 5, 2016 at 9:42 PM, Ian Abbott wrote: > On 05/09/16 17:05, Amit Ghadge wrote: >> >> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: >> WARNING: Block comments use * on subsequent lines >> >> Added * in blank line in comment block. >> >>

[PATCH v3] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

2016-09-05 Thread Amit Ghadge
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Added * in blank line in comment block. Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 60 +-- 1

Re: [PATCH v2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

2016-09-05 Thread Ian Abbott
On 05/09/16 17:05, Amit Ghadge wrote: This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Added * in blank line in comment block. Signed-off-by: Amit Ghadge ---

Re: DIRECTOR IN CHARGE: DR.PATRICE TEME

2016-09-05 Thread U N-Headquarters
United Nations Compensation Unit, In Affiliation with World Bank Our Ref: U.N.O/W.B.O/20/06/2016/05/09/1982. Congratulations Beneficiary, We have been working closely with the INTERPOL, CIA, FBI and other foreign international organizations as well as Western Union and Money Gram regarding

[PATCH v2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

2016-09-05 Thread Amit Ghadge
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Added * in blank line in comment block. Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 60 +-- 1

[PATCH v2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

2016-09-05 Thread Amit Ghadge
This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Added * in blank line in comment block. Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 1

Re: [PATCH 1/2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

2016-09-05 Thread Amit Ghadge
On Mon, Sep 5, 2016 at 6:45 PM, Ian Abbott wrote: > On 03/09/16 21:11, Amit Ghadge wrote: >> >> This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: >> >> WARNING: Block comments use * on subsequent lines >> >> Signed-off-by: Amit Ghadge >>

Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check.

2016-09-05 Thread Amit Ghadge
On Mon, Sep 5, 2016 at 7:02 PM, Ian Abbott wrote: > On 03/09/16 21:11, Amit Ghadge wrote: >> >> Fixes checkpatch warning: >> WARNING: Block comments use * on subsequent lines >> >> Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid >> of checkpatch.pl "CHECK" output

Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check.

2016-09-05 Thread Ian Abbott
On 03/09/16 21:11, Amit Ghadge wrote: Fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Replace (1<<7) by BIT(7) in the file ni_670x.c to get rid of checkpatch.pl "CHECK" output "Prefer using the BIT macro". Replace Avoid CamelCase range_0_20mA to range_0_20ma.

[PATCH] speakup: Add spinlock in synth_direct_store

2016-09-05 Thread Pavel Andrianov
All operations with synth buffer should be protected, as there are global pointers, which should be modified atomically. Found by Linux Driver Verification project (linuxtesting.org) Signed-off-by: Pavel Andrianov --- drivers/staging/speakup/kobjects.c | 3 +++ 1 file

Re: [PATCH 1/2] Staging: comedi: ni_daq_dio24.c: Fix block comments use * on subsequent lines.

2016-09-05 Thread Ian Abbott
On 03/09/16 21:11, Amit Ghadge wrote: This is a patch to the ni_daq_dio24.c that fixes checkpatch warning: WARNING: Block comments use * on subsequent lines Signed-off-by: Amit Ghadge --- drivers/staging/comedi/drivers/ni_daq_dio24.c | 52 +-- 1

Re: [PATCH 2/2] Staging: comedi: ni_670x.c: Fix warnings and check.

2016-09-05 Thread Ian Abbott
On 04/09/16 11:15, Amit Ghadge wrote: I will be send individual patches. I was try, make M=drivers/staging/comedi/ No issue generated, Is there have any other option to test these changes? You need to configure the kernel to build the drivers you are changing. Also, please don't top-post!

[PATCH] staging: ks7010: fix warning on return for void functions

2016-09-05 Thread Hariharan R
This patch fixes the checkpatch warning in ks7010_sdio.c 'void function return statements are not generally useful' Signed-off-by: Hariharan R --- drivers/staging/ks7010/ks7010_sdio.c | 11 --- 1 file changed, 11 deletions(-) diff --git

Re: [PATCH] staging: media: omap4iss: mark omap4iss_flush() static

2016-09-05 Thread Laurent Pinchart
Hi Baoyou, Thank you for the patch. On Sunday 04 Sep 2016 14:41:41 Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/staging/media/omap4iss/iss.c:64:6: warning: no previous prototype > for 'omap4iss_flush' [-Wmissing-prototypes] > > In fact, this function is only

Re: [PATCH] staging: media: omap4iss: mark omap4iss_flush() static

2016-09-05 Thread Arnd Bergmann
On Sunday, September 4, 2016 2:41:41 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/staging/media/omap4iss/iss.c:64:6: warning: no previous prototype for > 'omap4iss_flush' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which

Re: [PATCH] staging: ks7010: mark symbols static where possible

2016-09-05 Thread Arnd Bergmann
On Sunday, September 4, 2016 2:38:39 PM CEST Baoyou Xie wrote: > We get 2 warnings when building kernel with W=1: > drivers/staging/ks7010/ks_hostif.c:72:6: warning: no previous prototype for > 'ks_wlan_hw_wakeup_task' [-Wmissing-prototypes] > drivers/staging/ks7010/ks_hostif.c:1508:6: warning:

Re: [PATCHv2 1/4] staging: android: ion: Drop heap type masks

2016-09-05 Thread Brian Starkey
Hi, On Fri, Sep 02, 2016 at 12:36:25PM -0700, Laura Abbott wrote: On 09/02/2016 06:41 AM, Brian Starkey wrote: Hi Laura, On Thu, Sep 01, 2016 at 03:40:41PM -0700, Laura Abbott wrote: There is no advantage to having heap types be a mask. The ion client has long since dropped the mask. Drop

Re: A potential race in drivers/staging/speakup/speakup.ko

2016-09-05 Thread Samuel Thibault
Pavel Andrianov, on Mon 05 Sep 2016 13:33:33 +0300, wrote: > synth_direct_store may be called via device_attributes interface. Ah, right. > In which function the lock should be added? That'd be synth_direct_store then, around the while loop. Samuel

Re: A potential race in drivers/staging/speakup/speakup.ko

2016-09-05 Thread Pavel Andrianov
05.09.2016 12:56, Samuel Thibault пишет: Pavel Andrianov, on Mon 05 Sep 2016 12:54:10 +0300, wrote: 05.09.2016 12:43, Samuel Thibault пишет: Pavel Andrianov, on Mon 05 Sep 2016 11:51:50 +0300, wrote: There is a potential race in drivers/staging/speakup/speakup.ko. All operations with global

Re: A potential race in drivers/staging/speakup/speakup.ko

2016-09-05 Thread Samuel Thibault
Pavel Andrianov, on Mon 05 Sep 2016 12:54:10 +0300, wrote: > 05.09.2016 12:43, Samuel Thibault пишет: > >Pavel Andrianov, on Mon 05 Sep 2016 11:51:50 +0300, wrote: > >>There is a potential race in drivers/staging/speakup/speakup.ko. > >>All operations with global pointers buff_in and buff_out are

Re: A potential race in drivers/staging/speakup/speakup.ko

2016-09-05 Thread Pavel Andrianov
05.09.2016 12:43, Samuel Thibault пишет: Hello, Pavel Andrianov, on Mon 05 Sep 2016 11:51:50 +0300, wrote: There is a potential race in drivers/staging/speakup/speakup.ko. All operations with global pointers buff_in and buff_out are performed without any locks. Thus, a simultaneous write (via

Re: A potential race in drivers/staging/speakup/speakup.ko

2016-09-05 Thread Samuel Thibault
Hello, Pavel Andrianov, on Mon 05 Sep 2016 11:51:50 +0300, wrote: > There is a potential race in drivers/staging/speakup/speakup.ko. > All operations with global pointers buff_in and buff_out are performed > without any locks. Thus, a simultaneous write (via synth_buffer_clear or >

A potential race in drivers/staging/speakup/speakup.ko

2016-09-05 Thread Pavel Andrianov
Hi! There is a potential race in drivers/staging/speakup/speakup.ko. All operations with global pointers buff_in and buff_out are performed without any locks. Thus, a simultaneous write (via synth_buffer_clear or synth_buffer_add) to the pointers may lead to inconsistent data. Should a local

Letter of reference related to you

2016-09-05 Thread E E Frank
I sent you an email few days ago; I was wondering if you received it. Could you please recheck and get back to me ASAP.? I'm contacting you in regard to a deceased client of mine that bear the same surname with yours .Please i will appreciate you get in touch to me for more details, Best Regards,