> -Original Message-
> From: Kershner, David A
> Sent: Wednesday, October 19, 2016 8:04 PM
> To: Cathal Mullaney
> Subject: RE: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor
> locking code to be statically deterministic.
>
> > -Original
Added spaces around a '*' in ks7010_sdio.c. Issue found by checkpatch.
Signed-off-by: Nick Rosbrook
---
drivers/staging/ks7010/ks7010_sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
> -Original Message-
> From: Cathal Mullaney [mailto:chuckleberryf...@gmail.com]
> Subject: [PATCH v2] staging: unisys: visorbus: visorchannel: Refactor locking
> code to be statically deterministic.
>
> This patch makes locking in visorchannel_signalempty statically
> deterministic.
> As
On Wed, Oct 19, 2016 at 05:00:53PM +, Sell, Timothy C wrote:
> On Wednesday, October 19, 2016 7:31 AM, Cathal Mullaney wrote:
> > This patch makes locking in visorchannel_signalempty statically
> > deterministic.
> > As a result this patch fixes the sparse warning:
> > Context imbalance in
This patch makes locking in visorchannel_signalempty statically
deterministic.
As a result this patch fixes the sparse warning:
Context imbalance in 'visorchannel_signalempty' - different lock
contexts for basic block.
The logic of the locking code doesn't change but the layout of the
original
Remove unnecessary empty lines (issue found by checkpatch)
Signed-off-by: Pierre-Yves Kerbrat
---
drivers/staging/rtl8188eu/os_dep/osdep_service.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/osdep_service.c
Remove redundant alloc fail message
This patch fixes the warning found by checkpatch
Signed-off-by: Pierre-Yves Kerbrat
---
drivers/staging/rtl8188eu/os_dep/osdep_service.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git
Fix coding style issue in block comment in osdep_service.c found by
checkpatch tool
Signed-off-by: Pierre-Yves Kerbrat
---
drivers/staging/rtl8188eu/os_dep/osdep_service.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
Fix missing space around operators in rtw_alloc2d function in
osdep_service.c
Signed-off-by: Pierre-Yves Kerbrat
---
drivers/staging/rtl8188eu/os_dep/osdep_service.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Remove parentheses in _rtw_init_queue to fix checkpatch warning
Signed-off-by: Pierre-Yves Kerbrat
---
drivers/staging/rtl8188eu/os_dep/osdep_service.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/osdep_service.c
On Wednesday, October 19, 2016 7:31 AM, Cathal Mullaney wrote:
> This patch makes locking in visorchannel_signalempty statically deterministic.
> As a result this patch fixes the sparse warning:
> Context imbalance in 'visorchannel_signalempty' - different lock contexts for
> basic block.
>
> The
On Wed, 2016-10-19 at 19:53 +0300, Andy Shevchenko wrote:
> On Wed, 2016-10-19 at 22:07 +0700, Ivan Safonov wrote:
> >
> > netdev_alloc_skb function
> > already set dev member of pkt_copy.
>
> It might be one line.
>
> Some special references:
> functions: function()
> structs: struct my_struct
On Wed, 2016-10-19 at 22:07 +0700, Ivan Safonov wrote:
> netdev_alloc_skb function
> already set dev member of pkt_copy.
It might be one line.
Some special references:
functions: function()
structs: struct my_struct
P.S. Entire series lacks of cover letter.
>
> Signed-off-by: Ivan Safonov
On 19 October 2016 11:32:06 BST, Brian Masney wrote:
>Use the DEVICE_ATTR_RO, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO
>macros to create the device attributes.
>
>Signed-off-by: Brian Masney
Hi Brian,
One very quick comment. Driver should be
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h| 4 ++--
drivers/staging/wlan-ng/prism2mgmt.c | 2 +-
2 files changed, 3 insertions(+), 3
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Replace CamelCase fields of struct with underscores to comply
with the standard kernel coding style
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 2 +-
drivers/staging/wlan-ng/prism2mib.c | 2 +-
2 files changed, 2 insertions(+), 2
Replace CamelCase define to comply with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h| 2 +-
drivers/staging/wlan-ng/prism2mgmt.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
sizeof(*var) instead of sizeof(struct XXX) is preferred.
Fix them in prism2sta.c file.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/prism2sta.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h| 4 ++--
drivers/staging/wlan-ng/prism2mgmt.c | 2 +-
2 files changed, 3 insertions(+), 3
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
sizeof(var) instead of sizeof(struct XXX) is preferred.
Fix them in p80211netdev.c
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211netdev.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git
Replace CamelCase fields of struct with underscores to comply
with the standard kernel coding style
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
sizeof(*var) instead of sizeof(struct XXX) is preferred.
Fix it in p80211conv.c file.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/p80211conv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Replace CamelCase struct name and fields with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h| 6 +++---
drivers/staging/wlan-ng/prism2mgmt.c | 8
2 files changed, 7
This patchset fix CamelCases in hfa384x.h header file.
This file is free of CamelCases now.
Sergio Paracuellos (12):
staging: wlan-ng: avoid CamelCase: HFA384x_RID_CNFAPBCNint
staging: wlan-ng: avoid CamelCase: hfa384x_HostScanRequest_data
staging: wlan-ng: avoid CamelCase: hfa384x_WPAData
This patchset fix CamelCases in hfa384x.h header file.
This file is free of CamelCases now.
This patch series are resent because an mix error in the previous sent.
Sergio Paracuellos (12):
staging: wlan-ng: avoid CamelCase: HFA384x_RID_CNFAPBCNint
staging: wlan-ng: avoid CamelCase:
sizeof(var) instead of sizeof(struct XXX) is preferred.
It also fix the following checkpatch.pl script warning:
WARNING: line over 80 characters
Fix this two in prism2mgmt.c file.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/prism2mgmt.c | 2 +-
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Replace CamelCase struct name with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
Replace CamelCase define to comply with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h| 2 +-
drivers/staging/wlan-ng/prism2mgmt.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
sizeof(var) instead of sizeof(struct XXX) is preferred.
Fix it in hfa384x_usb.c file.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
sizeof(var) instead of sizeof(struct XXX) is preferred.
Fix it in cfg80211.c file.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/cfg80211.c
Replace CamelCase struct name and fields with underscores to comply
with the standard kernel coding style.
Signed-off-by: Sergio Paracuellos
---
drivers/staging/wlan-ng/hfa384x.h| 6 +++---
drivers/staging/wlan-ng/prism2mgmt.c | 8
2 files changed, 7
is_multicast_ether_addr used instead.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 3 +--
drivers/staging/rtl8188eu/include/ieee80211.h | 11 ---
2 files changed, 1 insertion(+), 13 deletions(-)
diff --git
This member used only as local variable.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 2 --
drivers/staging/rtl8188eu/core/rtw_mlme.c | 11 +--
drivers/staging/rtl8188eu/include/rtw_mlme.h | 1 -
Prepare to replacing wlanhdr_to_ethhdr by ieee80211_data_to_8023.
Calculate it locally.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 26 --
drivers/staging/rtl8188eu/include/rtw_recv.h | 2 --
2 files changed, 20
skb_put used instead.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 2 +-
drivers/staging/rtl8188eu/include/rtw_recv.h | 17 -
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 2 +-
3 files changed, 2
uint instead of int used.
This function always called with positive sz argument.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
Driver does not use this definitions.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/wifi.h | 73
1 file changed, 73 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/wifi.h
is2t local variable always is false.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/phy.c | 57 +
1 file changed, 1 insertion(+), 56 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/phy.c
netdev_alloc_skb function
already set dev member of pkt_copy.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
This function does not used.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 27 --
drivers/staging/rtl8188eu/include/ieee80211.h | 1 -
2 files changed, 28 deletions(-)
diff --git
Prepare to replacing wlanhdr_to_ethhdr by ieee80211_data_to_8023.
This stripping procedure placed into new strip_iv_icv function.
Also strip_iv_icv used inside unprotect_frame.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 27
rx_end replaced with pkt->end.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 3 +--
drivers/staging/rtl8188eu/os_dep/recv_linux.c| 4 ++--
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 -
3 files changed, 3 insertions(+), 5
is2t is constant.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/phy.c | 21 +++--
1 file changed, 3 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/phy.c
b/drivers/staging/rtl8188eu/hal/phy.c
index
Remove is_path_a_on and is2t arguments.
These argument always are constant.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/phy.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/phy.c
Value of this member does not used.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 7 ---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 1 -
drivers/staging/rtl8188eu/include/rtw_mlme.h | 1 -
3 files changed, 9 deletions(-)
diff
is2t argument of this function is constant.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/hal/phy.c | 101 +++-
1 file changed, 6 insertions(+), 95 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/phy.c
Value of rx_head used only to produce debug output.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 1 -
drivers/staging/rtl8188eu/os_dep/recv_linux.c| 4 ++--
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 1 -
3 files changed, 2
skb_trim used instead.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 8 +---
drivers/staging/rtl8188eu/include/rtw_recv.h | 16
2 files changed, 5 insertions(+), 19 deletions(-)
diff --git
These functions are unused.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_mlme.h | 19 ---
1 file changed, 19 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_mlme.h
b/drivers/staging/rtl8188eu/include/rtw_mlme.h
uint instead of int used.
This function always called with positive sz argument.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
To replace rx_data with pkt->data.
Now pkt->data is equal to rx_data.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
rx_data replaced with pkt->data.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c| 38 -
drivers/staging/rtl8188eu/core/rtw_recv.c| 54
drivers/staging/rtl8188eu/core/rtw_security.c| 6
len replaced with pkt->len.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c| 14 +++---
drivers/staging/rtl8188eu/core/rtw_recv.c| 23 +--
drivers/staging/rtl8188eu/core/rtw_security.c| 6 +++---
fw_state member of mlme_priv
never obtain WIFI_MP_STATE value.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_cmd.c | 4 ---
drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 5 ---
drivers/staging/rtl8188eu/core/rtw_recv.c | 42
Also SCAN_RESULT_TYPE enum removed.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_mlme.h | 188 ---
1 file changed, 188 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_mlme.h
Return value of this function does not used.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
Value of this variable always is 0.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 8 +---
drivers/staging/rtl8188eu/hal/odm.c| 3 +--
drivers/staging/rtl8188eu/hal/odm_RTL8188E.c | 19 ---
uint instead of int used.
This function always called with positive sz argument.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
This function is unused.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 17 -
drivers/staging/rtl8188eu/include/ieee80211.h | 3 ---
2 files changed, 20 deletions(-)
diff --git
These messages are redundant.
Also break rtw_usb_if1_init function if HalData allocation failed.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_efuse.c | 4 +---
drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c | 4 +---
In accordance with the KISS principle.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c | 19 +++
1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_ops_linux.c
This function does not used.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_xmit.c| 18 --
drivers/staging/rtl8188eu/include/rtw_xmit.h | 1 -
2 files changed, 19 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c
To replace rx_tail with pkt->tail.
Now pkt->tail is equal to rx_tail and pkt->len is equal to len.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git
rx_end replaced with pkt->tail.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 2 +-
drivers/staging/rtl8188eu/include/rtw_recv.h | 3 ---
drivers/staging/rtl8188eu/os_dep/recv_linux.c| 2 +-
Typecasting here is unnecessary.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_ap.c| 2 +-
drivers/staging/rtl8188eu/core/rtw_efuse.c | 2 +-
drivers/staging/rtl8188eu/core/rtw_mlme.c | 10 +-
skb_pull used instead.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 8
drivers/staging/rtl8188eu/include/rtw_recv.h | 17 -
2 files changed, 4 insertions(+), 21 deletions(-)
diff --git
These definitions does not used.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
This simple one-line function used only once, and precvframe always not NULL.
Signed-off-by: Ivan Safonov
---
drivers/staging/rtl8188eu/core/rtw_recv.c| 2 +-
drivers/staging/rtl8188eu/include/rtw_recv.h | 8
2 files changed, 1 insertion(+), 9 deletions(-)
> -Original Message-
> From: Weibing Zhang [mailto:atheism.zh...@gmail.com]
> Sent: Tuesday, October 18, 2016 8:43 PM
> To: KY Srinivasan ; Haiyang Zhang
>
> Cc: de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; Weibing
> Zhang
On Wed, Oct 19, 2016 at 6:47 PM, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Fix to return a negative error code from the es2_arpc_in_enable() error
> handling case instead of 0, as done elsewhere in this function.
>
> Fixes: 9d9d3777a9db ("greybus:
Fix in commit 880988348270 ("hv_netvsc: set nvdev link after populating
chn_table") turns out to be incomplete. A crash in
netvsc_get_next_send_section() is observed on mtu change when the device
is under load. The race I identified is: if we get to netvsc_send() after
we set net_device_ctx->nvdev
On Wed, Oct 19, 2016 at 01:17:53PM +, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Fix to return a negative error code from the es2_arpc_in_enable() error
> handling case instead of 0, as done elsewhere in this function.
>
> Fixes: 9d9d3777a9db ("greybus: es2: Add a
From: Wei Yongjun
Fix to return a negative error code from the es2_arpc_in_enable() error
handling case instead of 0, as done elsewhere in this function.
Fixes: 9d9d3777a9db ("greybus: es2: Add a new bulk in endpoint for
APBridgeA RPC")
Signed-off-by: Wei Yongjun
On Wed, Oct 19, 2016 at 09:08:30AM -0400, Brian Masney wrote:
> On Wed, Oct 19, 2016 at 02:26:27PM +0300, Dan Carpenter wrote:
> > What does illuminance0_ mean? Can we remove that?
>
> I left the names of the existing sysfs attributes intact to not break
> any existing users of the driver. I'm
On Wed, Oct 19, 2016 at 02:26:27PM +0300, Dan Carpenter wrote:
> What does illuminance0_ mean? Can we remove that?
I left the names of the existing sysfs attributes intact to not break
any existing users of the driver. I'm not sure why the original author
named it that way.
Brian
On Wed, Oct 19, 2016 at 12:47:13PM +0200, Peter Meerwald-Stadler wrote:
>
> > Use the DEVICE_ATTR_RO, IIO_DEVICE_ATTR_RW, and IIO_DEVICE_ATTR_WO
> > macros to create the device attributes.
>
> great that you work on cleaning this up!
>
> the patch does a bit more than is claimed, it also
This test is based on the libsync test suite from Android.
This commit includes a test to stress merge operations.
Signed-off-by: Emilio López
---
tools/testing/selftests/sync/Makefile| 1 +
tools/testing/selftests/sync/sync_stress_merge.c | 115
This test is based on the libsync test suite from Android.
This commit includes a stress test that replicates a
consumer/producer pattern.
Signed-off-by: Emilio López
---
tools/testing/selftests/sync/Makefile | 1 +
These tests are based on the libsync test suite from Android.
This commit includes tests for waiting on fences.
Signed-off-by: Emilio López
---
tools/testing/selftests/sync/Makefile| 1 +
tools/testing/selftests/sync/sync_test.c | 1 +
On Wed, Oct 19, 2016 at 08:48:32AM -0400, Brian Masney wrote:
> Ok, I'll rework my patch series to stick with the direct returns. I
> personally prefer that approach. I was using the gotos since I thought
> that was standard convention in the kernel.
>
It *should* but "goto unlock;" When you
This test is based on the libsync test suite from Android.
This commit includes a stress test that invokes operations
in parallel.
Signed-off-by: Emilio López
---
tools/testing/selftests/sync/Makefile | 1 +
These tests are based on the libsync test suite from Android.
This commit includes tests for basic merge operations.
Signed-off-by: Emilio López
---
tools/testing/selftests/sync/Makefile | 1 +
tools/testing/selftests/sync/sync_merge.c | 60
These tests are based on the libsync test suite from Android.
This commit lays the ground for future tests, as well as includes
tests for a variety of basic allocation commands.
Signed-off-by: Emilio López
---
tools/testing/selftests/Makefile | 1 +
These tests are based on the libsync test suite from Android.
This commit includes tests for basic fence creation.
Signed-off-by: Emilio López
---
tools/testing/selftests/sync/Makefile | 1 +
tools/testing/selftests/sync/sync_fence.c | 132
Hello everyone,
This is a series of tests to exercise the sync kernel infrastructure. It is
meant to be a test suite for the work Gustavo has been doing to destage it.
These tests were originally part of a battery of tests shipping with
Android's libsync that were rewritten to use the new
On Wed, Oct 19, 2016 at 08:38:16AM -0400, Brian Masney wrote:
> On Wed, Oct 19, 2016 at 02:08:59PM +0300, Dan Carpenter wrote:
> > On Wed, Oct 19, 2016 at 06:32:05AM -0400, Brian Masney wrote:
> > > Change the following functions to only have a single exit point:
> > > taos_i2c_read(),
1 - 100 of 126 matches
Mail list logo