Re: [PATCH] staging: iio: ad9832: allocate data before using

On Tue, Nov 08, 2016 at 03:00:49PM +0100, Arnd Bergmann wrote: > The regulator changes assigned data to an uninitialized pointer: > > drivers/staging/iio/frequency/ad9832.c: In function 'ad9832_probe': > drivers/staging/iio/frequency/ad9832.c:214:11: error: 'st' may be used > uninitialized in

Re: [PATCH 2/2] staging: greybus: use get_icount tty operation

On Tue, Nov 8, 2016 at 6:01 PM, Johan Hovold wrote: > Use the tty get_icount operation instead of implementing TIOCGICOUNT > directly. > > Signed-off-by: Johan Hovold > --- > drivers/staging/greybus/uart.c | 31 --- > 1 file

Re: [PATCH 1/2] staging: greybus: uart: fix invalid user-pointer check

On Tue, Nov 8, 2016 at 6:01 PM, Johan Hovold wrote: > Drop invalid user-pointer check from TIOCGSERIAL handler. > > A NULL-pointer can be valid in user space and copy_to_user() takes care > of sanity checking. > > Signed-off-by: Johan Hovold > --- >

Re: [lustre-devel] [PATCH] staging: lustre: ldlm: pl_recalc time handling is wrong

On Nov 7, 2016, at 19:47, James Simmons wrote: > > The ldlm_pool field pl_recalc_time is set to the current > monotonic clock value but the interval period is calculated > with the wall clock. This means the interval period will > always be far larger than the

RE: [PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'

> -Original Message- > From: Shiva Kerdel [mailto:sh...@exdev.nl] > Sent: Tuesday, November 08, 2016 9:42 AM > To: Stuart Yoder > Cc: gre...@linuxfoundation.org; german.riv...@freescale.com; German Rivera > ; > tred...@nvidia.com;

RE: [PATCH v2 1/2] Staging: fsl-mc: include: mc-bus: Kernel type 's16' preferred over 'int16_t'

> -Original Message- > From: Shiva Kerdel [mailto:sh...@exdev.nl] > Sent: Tuesday, November 08, 2016 9:42 AM > To: Stuart Yoder > Cc: gre...@linuxfoundation.org; german.riv...@freescale.com; German Rivera > ; > tred...@nvidia.com;

Re: [PATCH v2 23/23] staging: iio: tsl2583: move out of staging

On 08/11/16 10:16, Brian Masney wrote: > Move tsl2580, tsl2581, tsl2583 driver out of staging into mainline. > > Signed-off-by: Brian Masney A few minor bits and bobs inline - might need to push one or two into relevant earlier patches, but was easier to just review the

RE: [Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

> -Original Message- > From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > Behalf Of Long Li > Sent: Tuesday, November 8, 2016 8:57 AM > To: Greg KH > Cc: linux-...@vger.kernel.org; Haiyang Zhang ; >

Re: [PATCH v2 22/23] staging: iio: tsl2583: updated copyright and MODULE_AUTHOR

On 08/11/16 10:16, Brian Masney wrote: > Added Brian Masney's copyright to the header and to the MODULE_AUTHOR > for all of the staging cleanups that has been done to this driver. > > Signed-off-by: Brian Masney > --- > drivers/staging/iio/light/tsl2583.c | 3 ++- > 1

Re: [PATCH] staging: iio: tsl2583: fix unused function warning

On 08/11/16 14:01, Arnd Bergmann wrote: > Removing a call to the taos_chip_off() makes it unused when CONFIG_PM > is disabled: > > drivers/staging/iio/light/tsl2583.c:438:12: error: ‘taos_chip_off’ defined > but not used [-Werror=unused-function] > > This removes all the #ifdef in this file,

Re: [PATCH] staging: iio: ad9832: allocate data before using

On 08/11/16 14:00, Arnd Bergmann wrote: > The regulator changes assigned data to an uninitialized pointer: > > drivers/staging/iio/frequency/ad9832.c: In function 'ad9832_probe': > drivers/staging/iio/frequency/ad9832.c:214:11: error: 'st' may be used > uninitialized in this function

[PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

From: Long Li hv_do_hypercall assumes that we pass a segment from a physically continuous buffer. Buffer allocated on the stack may not work if CONFIG_VMAP_STACK=y is set. Change to use kmalloc to allocate this buffer. The v2 patch adds locking to access the pre-allocated

RE: [PATCH V3 13/14] Drivers: hv: vmbus: On write cleanup the logic to interrupt the host

Please don't add name/date information into comments. This kind of meta data belongs in the commit message only. My philosophy is that comments should be reserved for explain the semantics of the code, not the history. + * + * KYS: Oct. 30, 2016: + * It looks like Windows hosts have logic to

RE: [PATCH V3 07/14] Drivers: hv: vss: Operation timeouts should match host expectation

This looks messy, weird line wrap?? +/* + * Timeout values are based on expecations from host */ #define +VSS_FREEZE_TIMEOUT (15 * 60) ___ devel mailing list de...@linuxdriverproject.org

My Friend,

My Friend, Compliments of the season, thank you for your help I am very happy to inform you about my success in getting those funds transfer.Now, I want you to contact Mr Richard Frank with below contact Email ID: (w...@grpcco.org ) Ask him to send you the sum of eight hundred and seventy five

RE: [Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

> -Original Message- > From: Long Li > Sent: Tuesday, November 8, 2016 8:57 AM > To: Greg KH > Cc: KY Srinivasan ; Haiyang Zhang > ; Bjorn Helgaas ; > de...@linuxdriverproject.org;

RE: [Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Monday, November 7, 2016 11:00 PM > To: Long Li > Cc: KY Srinivasan ; Haiyang Zhang > ; Bjorn Helgaas ; >

[PATCH] Staging: xgifb: vgatypes: Replace decimal permissions with 4 digit octal

Replaced decimal permissions with 4 digit octal to solve checkpatch errors. Signed-off-by: Shiva Kerdel --- drivers/staging/xgifb/XGI_main_26.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c

Re: [PATCH v2 09/23] staging: iio: tsl2583: cleaned up logging

On Tue, Nov 08, 2016 at 02:29:20AM -0800, Joe Perches wrote: > On Tue, 2016-11-08 at 05:16 -0500, Brian Masney wrote: > > There are several places in the code where the function name is > > hardcoded in the log message. Use the __func__ constant string to build > > the log message. This also

[PATCH v2 2/2] Staging: fsl-mc: include: mc: Kernel type 's32' preferred over 'int32_t'

Follow the kernel type preferrences of using 's32' over 'int32_t'. Signed-off-by: Shiva Kerdel --- drivers/staging/fsl-mc/include/mc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fsl-mc/include/mc.h b/drivers/staging/fsl-mc/include/mc.h

[PATCH v2 1/2] Staging: fsl-mc: include: mc-bus: Kernel type 's16' preferred over 'int16_t'

Follow the kernel type preferrences of using 's16' over 'int16_t'. Signed-off-by: Shiva Kerdel --- drivers/staging/fsl-mc/include/mc-bus.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/fsl-mc/include/mc-bus.h

[PATCH] staging: iio: tsl2583: fix unused function warning

Removing a call to the taos_chip_off() makes it unused when CONFIG_PM is disabled: drivers/staging/iio/light/tsl2583.c:438:12: error: ‘taos_chip_off’ defined but not used [-Werror=unused-function] This removes all the #ifdef in this file, and marks the PM functions as __maybe_unused instead,

[PATCH 1/2] staging: greybus: uart: fix invalid user-pointer check

Drop invalid user-pointer check from TIOCGSERIAL handler. A NULL-pointer can be valid in user space and copy_to_user() takes care of sanity checking. Signed-off-by: Johan Hovold --- drivers/staging/greybus/uart.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH 2/2] staging: greybus: use get_icount tty operation

Use the tty get_icount operation instead of implementing TIOCGICOUNT directly. Signed-off-by: Johan Hovold --- drivers/staging/greybus/uart.c | 31 --- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/drivers/staging/greybus/uart.c

[PATCH 2/2] staging: lustre: llite: refactor lov_object_fiemap()

Add fiemap_for_stripe() to get file map extent from each stripe device. Signed-off-by: Bobi Jam --- drivers/staging/lustre/lustre/lov/lov_object.c | 441 + 1 file changed, 225 insertions(+), 216 deletions(-) diff --git

[PATCH 1/2] staging: lustre: llite: use u64 instead of loff_t in lov_object_fiemap()

Change loff_t to u64 in lov_object_fiemap() since loff_t is a signed value type. Otherwise there could be an overflow in drivers/staging/lustre/lustre/lov/lov_object.c:1241 lov_object_fiemap() warn: signed overflow undefined. 'fm_start + fm_length < fm_start' Reported-by: Dan Carpenter

Re: [PATCH] staging: vc04_services: Add 32-bit compatibility ioctls

On Monday, November 7, 2016 4:48:35 PM CET Michael Zoran wrote: > .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 269 > + > .../vc04_services/interface/vchiq_arm/vchiq_if.h | 25 ++ > .../interface/vchiq_arm/vchiq_ioctl.h | 102 > 3 files

Re: [PATCH v2 09/23] staging: iio: tsl2583: cleaned up logging

On Tue, 2016-11-08 at 05:16 -0500, Brian Masney wrote: > There are several places in the code where the function name is > hardcoded in the log message. Use the __func__ constant string to build > the log message. This also clarifies some of the error messages to match > the code and ensures that

[PATCH v2 19/23] staging: iio: tsl2583: remove unnecessary parentheses

in_illuminance_lux_table_store() contains some unnecessary parentheses. This patch removes them since they provide no value. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 23/23] staging: iio: tsl2583: move out of staging

Move tsl2580, tsl2581, tsl2583 driver out of staging into mainline. Signed-off-by: Brian Masney --- .../ABI/testing/sysfs-bus-iio-light-tsl2583| 20 + drivers/iio/light/Kconfig | 7 + drivers/iio/light/Makefile |

[PATCH v2 17/23] staging: iio: tsl2583: moved code block inside else statement

The check for ch1lux > ch0lux inside tsl2583_get_lux is only valid if the ratio is not equal to zero. Move the code block inside the else statement. This does away with the need to initialize the variables to zero. Signed-off-by: Brian Masney ---

[PATCH v2 06/23] staging: iio: tsl2583: change current chip state from a tristate to a bool

The current chip state is represented as a tristate (working, suspended, and unknown). The unknown state was not used. This patch changes the chip state so that it is now represented as a single boolean value (suspended). Signed-off-by: Brian Masney ---

[PATCH v2 16/23] staging: iio: tsl2583: updated code comment to match what the code does

If channel 0 does not have any data, then the code sets the lux to zero. The corresponding comment says that the last value is returned. This updates the comment to correctly reflect what the code does. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c |

[PATCH v2 21/23] staging: iio: tsl2583: move from a global to a per device lux table

The driver contains a global lux table that can be updated via sysfs. Change this to a per device lux table so that multiple devices can be hooked up to the same system with different lux tables. There are 10 entries, plus 1 for the termination segment, set aside for the entries in the lux table.

[PATCH v2 15/23] staging: iio: tsl2583: fix multiline comment syntax

The definition of the tsl2583_device_lux struct has a series of single line comments. There are two other cases where the multiline comments did not have an initial blank line. Change these comments to use the proper multiline syntax. Signed-off-by: Brian Masney ---

[PATCH v2 18/23] staging: iio: tsl2583: change tsl2583_als_calibrate() to return 0 on success

tsl2583_als_calibrate() returns the newly computed gain_trim if the calibration was successful. This function is only called by in_illuminance_calibrate_store() and the return value inside that sysfs attribute is only checked to see if an error was returned. This patch changes

[PATCH v2 22/23] staging: iio: tsl2583: updated copyright and MODULE_AUTHOR

Added Brian Masney's copyright to the header and to the MODULE_AUTHOR for all of the staging cleanups that has been done to this driver. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v2 20/23] staging: iio: tsl2583: don't assume an unsigned int is 32 bits

in_illuminance_lux_table_store assumes that an unsigned int is 32 bits. Replace this with sizeof(unsigned int). Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 14/23] staging: iio: tsl2583: combine sysfs documentation

There are two separate files describing the tsl2583 sysfs attributes. Combine the two files into one. Updated the name of the sysfs attributes to match the current ABI. Signed-off-by: Brian Masney Suggested-by: Peter Meerwald-Stadler ---

[PATCH v2 10/23] staging: iio: tsl2583: unify function and variable prefix to tsl2583_

Some functions and variables were prefixed with either taos, tsl258x or tsl2583. Change everything to use the tsl2583 prefix since that is the name of the .c file. The taos_settings member inside the taos_settings struct was renamed to als_settings. Signed-off-by: Brian Masney

[PATCH v2 05/23] staging: iio: tsl2583: remove unnecessary chip status checks in suspend/resume

The device probing and the suspend/resume code checks a flag internal to the driver that determines whether or not the chip is in a working state. These checks are not needed. This patch removes the unnecessary checks. It will do no harm to the hardware if the chip is reinitialized if it is

[PATCH v2 12/23] staging: iio: tsl2583: fix comparison between signed and unsigned integers

Fixed warning found by make W=2: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH v2 01/23] staging: iio: tsl2583: split out functionality of taos_chip_on()

taos_chip_on() reads an eight member array called taos_config that contains the desired state of the chip's registers. Only four of the registers actually need to be written to. The four that do not need to be written to are for the {low,high} byte of the lower interrupt threshold and the

[PATCH v2 03/23] staging: iio: tsl2583: check if chip is suspended in in_illuminance_calibrate_store

in_illuminance_calibrate_store() did not check to see if the chip is suspended. This patch adds the proper check. The return value from taos_als_calibrate() was also not checked in this function, so the proper check was also added while changes are being made here. Signed-off-by: Brian Masney

[PATCH v2 09/23] staging: iio: tsl2583: cleaned up logging

There are several places in the code where the function name is hardcoded in the log message. Use the __func__ constant string to build the log message. This also clarifies some of the error messages to match the code and ensures that the correct priority is used since the message is already being

[PATCH v2 08/23] staging: iio: tsl2583: remove the FSF's mailing address

Address warning from checkpatch: CHECK: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. Signed-off-by: Brian Masney

[PATCH v2 04/23] staging: iio: tsl2583: remove unnecessary chip status check in taos_get_lux

taos_get_lux checks to see if the chip is in a working state. This check is not necessary since it is only called from tsl2583_read_raw and in_illuminance_calibrate_store (via taos_als_calibrate). The chip state is already checked by these functions. Signed-off-by: Brian Masney

[PATCH v2 13/23] staging: iio: tsl2583: change newlines to improve readability

Add and remove newlines to improve code readability in preparation for moving the driver out of staging. Signed-off-by: Brian Masney --- drivers/staging/iio/light/tsl2583.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

[PATCH v2 11/23] staging: iio: tsl2583: fix alignment of #define values

Most of the values in the #defines have their values aligned on a single column, but some do not. This changes the remaining defines to use consistent alignment with the majority to improve code readability. Signed-off-by: Brian Masney ---

[PATCH v2 02/23] staging: iio: tsl2583: fix issue with changes to calibscale and int_time not being set on the chip

When updating the in_illuminance_calibscale and in_illuminance_integration_time sysfs attributes, these values were not actually written to the chip. The chip would continue to use the old parameters. Extracted out tsl2583_set_als_gain() and tsl2583_set_als_time() functions that are now called

[PATCH v2 00/23] staging: iio: tsl2583: move out of staging

The first 7 patches in this series contains version 2 of the patches 7-9 that I sent out on 2016-11-03. The only change is that the patches are split up further to make the code review easier. Patches 8-23 in this series are new and some of the highlights include: - Moved from a global lux table

[PATCH v2 07/23] staging: iio: tsl2583: remove redundant write to the control register in taos_probe()

taos_probe() calls i2c_smbus_write_byte() to select the control register, however there are no subsequent calls to i2c_smbus_read_byte(). The write call is unnecessary and is removed by this patch. Verified that the driver still functions correctly using a TSL2581 hooked up to a Raspberry Pi 2.