RE: [PATCH v2] [hv] storvsc: Payload buffer incorrectly sized for 32 bit kernels.

> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Tuesday, November 29, 2016 8:58 AM > To: Cathy Avery > Cc: KY Srinivasan ; Haiyang Zhang > ; j...@linux.vnet.ibm.com; >

RE: [PATCH v2] [hv] storvsc: Payload buffer incorrectly sized for 32 bit kernels.

> -Original Message- > From: Cathy Avery [mailto:cav...@redhat.com] > Sent: Wednesday, November 23, 2016 5:47 AM > To: KY Srinivasan ; Haiyang Zhang > ; j...@linux.vnet.ibm.com; > martin.peter...@oracle.com > Cc: de...@linuxdriverproject.org;

[PATCH] Staging: wlan-ng: hfa384x_usb.c Fixed too long code line warnings.

Fixed checkpatch warning "line over 80 characters" in wlan-ng/hfa384x_usb.c file. Signed-off-by: Yan Laijun --- drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c

[PATCH] staging: lustre: libcfs: repair improper unlikely test

The scripts to replace NULL test got confused with the macro parenthesis so the unlikely test in libcfs_private.h ended up incorrect. This fixes this error. Reported-by: Dan Carpenter Signed-off-by: James Simmons ---

Re: [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer

On Tue, Nov 08, 2016 at 02:04:38PM -0800, Long Li wrote: > From: Long Li > > hv_do_hypercall assumes that we pass a segment from a physically > continuous buffer. Buffer allocated on the stack may not work if > CONFIG_VMAP_STACK=y is set. > > Change to use kmalloc to

Re: [PATCH] staging: greybuis: fix permission style warnings

On Tue, Nov 29, 2016 at 03:59:46PM -0600, Alex Elder wrote: > On 11/26/2016 03:50 PM, Andrea Ghittino wrote: > > Fixes greybus user/groups permission style warnings > > found by checkpatch.pl tool > > > > Signed-off-by: Andrea Ghittino > > I don't understand why using 0444 would be preferred >

RE: [PATCH 6/9] bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2

> -Original Message- > From: Ruxandra Ioana Radulescu > Sent: Monday, November 28, 2016 12:10 PM > To: Stuart Yoder ; gre...@linuxfoundation.org > Cc: German Rivera ; de...@driverdev.osuosl.org; > linux-ker...@vger.kernel.org; >

Re: [PATCH] staging: greybuis: fix permission style warnings

On 11/26/2016 03:50 PM, Andrea Ghittino wrote: > Fixes greybus user/groups permission style warnings > found by checkpatch.pl tool > > Signed-off-by: Andrea Ghittino I don't understand why using 0444 would be preferred over S_IRUGO (for example). Do you know? Maybe the checkpatch.pl output

[PATCH v3] staging: sm750fb: fix tabstop style warning

Fixes sm750fb tabstop style warning found by checkpatch.pl tool Signed-off-by: Andrea Ghittino --- changelog: v2) Fixed email subject v3) Fixed email format drivers/staging/sm750fb/sm750_accel.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2] staging: greybus: arche-platform: fix line over 80 characters style warnings

On 11/29/2016 03:11 PM, Andrea Ghittino wrote: > Fixes greybus "line over 80 characters" style warnings > found by checkpatch.pl tool I have a few comments. Please update your patch and send a new version. > Signed-off-by: Andrea Ghittino You state that this is v2; how

[PATCH v3] staging: greybus: arche-platform: fix line over 80 characters style warnings

Fixes greybus "line over 80 characters" style warnings found by checkpatch.pl tool Signed-off-by: Andrea Ghittino --- changelog: v2) Review patch based on Vaibhav Hiremath review v3) Fixed email text drivers/staging/greybus/arche-apb-ctrl.c |5 +++

Re: [PATCH v2] staging: greybus: arche-platform: fix line over 80 characters style warnings

On Tue, Nov 29, 2016 at 10:11:45PM +0100, Andrea Ghittino wrote: > Fixes greybus "line over 80 characters" style warnings > found by checkpatch.pl tool > > Signed-off-by: Andrea Ghittino > --- Same v2 question here, please fix up and resend. greg k-h

Re: [PATCH v2] staging: sm750fb: fix tabstop style warning

On Tue, Nov 29, 2016 at 10:19:42PM +0100, Andrea Ghittino wrote: > Fixes sm750fb tabstop style warning > found by checkpatch.pl tool > > Signed-off-by: Andrea Ghittino > --- What changed in v2? That always has to be below the --- line. And what happened to the diffstat?

[PATCH v2] staging: sm750fb: fix tabstop style warning

Fixes sm750fb tabstop style warning found by checkpatch.pl tool Signed-off-by: Andrea Ghittino --- diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c index 6fd18d2..af0db57 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++

Re: [PATCH] staging: unisys: ix spelling mistake of "outstanding"

On 29/11/16 21:02, Greg Kroah-Hartman wrote: > On Tue, Nov 29, 2016 at 08:37:35PM +, Kershner, David A wrote: >> >> >>> -Original Message- >>> From: Colin King [mailto:colin.k...@canonical.com] >>> Sent: Tuesday, November 29, 2016 2:07 PM >>> To: Kershner, David A

[PATCH v2] staging: greybus: arche-platform: fix line over 80 characters style warnings

Fixes greybus "line over 80 characters" style warnings found by checkpatch.pl tool Signed-off-by: Andrea Ghittino --- diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/greybus/arche-apb-ctrl.c index 3fda0cd..755120a 100644 ---

Re: [PATCH] staging: unisys: ix spelling mistake of "outstanding"

On Tue, Nov 29, 2016 at 08:37:35PM +, Kershner, David A wrote: > > > > -Original Message- > > From: Colin King [mailto:colin.k...@canonical.com] > > Sent: Tuesday, November 29, 2016 2:07 PM > > To: Kershner, David A ; Greg Kroah-Hartman > >

Re: [PATCH 1/3] staging: comedi: s626: use preferred kernel type u8

On Fri, Nov 25, 2016 at 12:01:21AM +0330, Saber Rezvani wrote: > >From c3dd43f3d43e7bec8f7f1140519ffc1f3b727b01 Mon Sep 17 00:00:00 2001 > From: Saber This doesn't match up with your signed-off-by: or your email from: line. Please fix this up by using git send-email to send

Re: [PATCH] Staging: gs_fpgaboot: fix indentation sytle in io.c

On Tue, Nov 29, 2016 at 11:46:56AM -0500, Thomas Casey wrote: > This patch properly aligns a statement with arguments on multiple lines > found by the checkpatch.pl script > > Signed-off-by: Thomas Casey > --- > drivers/staging/gs_fpgaboot/io.c | 2 +- > 1 file changed, 1

Re: [PATCH]: Staging: rtl8192e: Block comments use a trailing */ on a separate line

On Sat, Nov 26, 2016 at 11:06:40PM +0530, Rahul Krishnan wrote: > This patch fixes the following checkpath.pl warning > WARNING: Block comments use a trailing */ on a separate line Why is this indented? And why does your Subject have an extra ':' right after "[PATCH]"? Please fix. thanks,

Re: [PATCH v2 1/1] staging: ks7010: fixed 'space prohibited after that *' erros.

On Fri, Nov 25, 2016 at 03:20:41PM +0530, Yamanappagouda Patil wrote: > Fixed checkpatch.pl errors related to "space prohibited after that '*' > or '&'" in ks_wlan_net.c file. > > Signed-off-by: Yamanappagouda Patil > --- > drivers/staging/ks7010/ks_wlan_net.c | 12

Re: [PATCH v2] staging: most: Eliminate usage of symbolic permissions

On Fri, Nov 25, 2016 at 03:31:09PM -0700, Jason Litzinger wrote: > Fix checkpatch warnings regarding the use of symbolic permissions. > > Where the MOST_CHANNEL_ATTR macro is used, convert to octal > permissions over symbolic. > > Where _ATTR is used directly, replace with _ATTR_RW/_ATTR_WO and

RE: [PATCH] staging: unisys: ix spelling mistake of "outstanding"

> -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Tuesday, November 29, 2016 2:07 PM > To: Kershner, David A ; Greg Kroah-Hartman > ; Sell, Timothy C ; > Binder, David Anthony

Re: [PATCH 1/2] vmbus: add support for dynamic device id's

On Mon, Nov 28, 2016 at 08:51:32AM -0800, Stephen Hemminger wrote: > This patch adds sysfs interface to dynamically bind new UUID values > to existing VMBus device. This is useful for generic UIO driver to > act similar to uio_pci_generic. > > Signed-off-by: Stephen Hemminger

[PATCH] staging: unisys: ix spelling mistake of "outstanding"

From: Colin Ian King Trivial fix to spelling mistake "oustanding" to "outstanding". Signed-off-by: Colin Ian King --- drivers/staging/unisys/visornic/visornic_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Linaro-mm-sig] Follow up on Ion from LPC

On 11/25/2016 04:30 AM, Benjamin Gaignard wrote: > Hi Laura, > > Thanks for what you are doing on ION. > As soon that will be ok I will submit again the driver for sti platform. > > After reading your mail I have the feeling that solves cache, > devicetree and legacy support problems will be

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

On 11/28/2016 01:41 PM, Lino Sanfilippo wrote: > The problem is that the HW does not provide a tx completion index. Instead we > have to > iterate the status descriptors until we get an invalid idx which indicates > that there > are no further tx descriptors done for now. I am afraid that if

Re: [PATCH v2] [hv] storvsc: Payload buffer incorrectly sized for 32 bit kernels.

> "Cathy" == Cathy Avery writes: Cathy> On a 32 bit kernel sizeof(void *) is not 64 bits as hv_mpb_array Cathy> requires. Also the buffer needs to be cleared or the upper bytes Cathy> will contain junk. K.Y.: Please review! -- Martin K. Petersen Oracle Linux

[PATCH] Staging: gs_fpgaboot: fix indentation sytle in io.c

This patch properly aligns a statement with arguments on multiple lines found by the checkpatch.pl script Signed-off-by: Thomas Casey --- drivers/staging/gs_fpgaboot/io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gs_fpgaboot/io.c

Re: rtlwifi: Fix enter/exit power_save

Larry Finger wrote: > In commit a5ffbe0a1993 ("rtlwifi: Fix scheduling while atomic bug") and > commit a269913c52ad ("rtlwifi: Rework rtl_lps_leave() and rtl_lps_enter() > to use work queue"), an error was introduced in the power-save routines > due to the fact that

Re: [PATCH] staging: octeon-usb: fix code style warnings

On Wed, Nov 23, 2016 at 09:18:09PM +0100, Andrea Ghittino wrote: > This patch fix two code style warnings related to "line over 80 characters" > in drivers/staging/octeon-usb/octeon-hcd.c file. But you forgot to wrap this at 72 columns :( Please fix up... greg k-h

Re: [PATCH] staging: sm750fb: fix function definition argument style warning

On Sun, Nov 27, 2016 at 10:11:18PM +0100, Andrea Ghittino wrote: > Fixes sm750fb function definition argument style warning > found by checkpatch.pl tool > > Signed-off-by: Andrea Ghittino You need to version your patches when you send multiple copies out. Again, please read

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

On 11/28/2016 09:46 PM, Lino Sanfilippo wrote: > Hi Markus, > > On 27.11.2016 18:59, Markus Böhme wrote: >> Hello Lino, >> >> just some things barely worth mentioning: >> > >> >> I found a bunch of unused #defines in slic.h. I cannot judge if they are >> worth keeping: >> >>

Re: [PATCH] hv: utils: properly pick TS protocol version for future hosts

"Alex Ng (LIS)" writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Monday, November 28, 2016 8:30 AM >> To: de...@linuxdriverproject.org >> Cc: linux-ker...@vger.kernel.org; KY Srinivasan ; >> Haiyang

Re: [PATCH] staging: greybus: fix line over 80 characters style warnings

On Tue, Nov 29, 2016 at 12:12 AM, Andrea Ghittino wrote: > Fixes greybus "line over 80 characters" style warnings > found by checkpatch.pl tool > Since you would be resubmitting your patche after Greg's comment, can you also fix the subject line to staging: greybus: