[PATCH] Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

Commit a389fcfd2cb5 ("Drivers: hv: vmbus: Fix signaling logic in hv_need_to_signal_on_read()") added the proper mb(), but removed the test "prev_write_sz < pending_sz" when making the signal decision. As a result, the guest can signal the host unnecessarily, and then the host can throttle the

lening bieden

Goede dag, Dit is Norton Finance aanbod. Bij Norton maken we arrangingment van een lening of remortgage eenvoudig, zelfs als je met pensioen, zelfstandige of als je slechte krediet geschiedenis of CCJs. Omdat we een makelaar en niet een bank, we zijn niet beperkt tot onze eigen producten.

Re: [greybus-dev] [PATCH v2] staging: greybus: timesync: validate platform state callback

On 23-01-17, 16:32, Rui Miguel Silva wrote: > When tearingdown timesync, and not in arche platform, the state platform > callback is not initialized. That will trigger the following NULL > dereferencing. > CallTrace: > > ? gb_timesync_platform_unlock_bus+0x11/0x20 [greybus] >

Re: [PATCH 0/8] staging: lustre: lnet: change wire protocol typedefs to proper structure

On Sat, 2017-01-21 at 19:40 -0500, James Simmons wrote: > The upstream kernel requires proper structures so > convert nearly all the LNet wire protocols typedefs in > the LNet core. Thanks. Perhaps s/\bWIRE_ATTR\b/__packed/g one day too ___ devel

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

On 01/20/2017 06:38 AM, Hans Verkuil wrote: On 01/07/2017 03:11 AM, Steve Longerbeam wrote: +static int vidioc_querycap(struct file *file, void *fh, + struct v4l2_capability *cap) +{ + strncpy(cap->driver, "imx-media-camif", sizeof(cap->driver) - 1); +

[PATCH 03/14] vmbus: use kernel bitops for traversing interrupt mask

Use standard kernel operations for find first set bit to traverse the channel bit array. This has added benefit of speeding up lookup on 64 bit and because it uses find first set instruction. Signed-off-by: Stephen Hemminger --- drivers/hv/channel.c | 8 ++-

[PATCH 00/14] hv: vmbus cleanup patches

No new functionality in this set. It just involves removing unused argments, no longer used code, and style fixes Stephen Hemminger (14): vmbus: remove useless return's vmbus: constify parameters where possible vmbus: use kernel bitops for traversing interrupt mask vmbus: eliminate

Re: [PATCH v3 16/24] media: Add i.MX media core driver

On 01/23/2017 05:38 PM, Steve Longerbeam wrote: Second, ignoring the above locking issue for a moment, v4l2_pipeline_pm_use() will call s_power on the sensor _first_, then the mipi csi-2 s_power, when executing media-ctl -l '"ov5640 1-003c":0 -> "imx6-mipi-csi2":0[1]'. Which is the wrong

[PATCH 05/14] vmbus: drop no longer used kick_q argument

The flag to cause notification of host is unused after commit a01a291a282f7c2e ("Drivers: hv: vmbus: Base host signaling strictly on the ring state"). Therefore remove it from the ring buffer internal API. Signed-off-by: Stephen Hemminger --- drivers/hv/channel.c |

Re: [PATCH v3 16/24] media: Add i.MX media core driver

On 01/23/2017 03:13 AM, Philipp Zabel wrote: Hi Steve, On Sun, 2017-01-22 at 18:31 -0800, Steve Longerbeam wrote: On 01/16/2017 05:47 AM, Philipp Zabel wrote: On Sat, 2017-01-14 at 14:46 -0800, Steve Longerbeam wrote: [...] +Unprocessed Video Capture: +-- + +Send

[PATCH 10/14] vmbus: fix spelling errors

Several spelling errors in comments Signed-off-by: Stephen Hemminger --- drivers/hv/channel.c | 10 +- drivers/hv/hv_kvp.c | 10 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c index

[PATCH 06/14] vmbus: remove no longer used signal_policy

The explicit signal policy is no longer used. A different mechanism will be added later when xmit_more is supported. Signed-off-by: Stephen Hemminger --- include/linux/hyperv.h | 18 -- 1 file changed, 18 deletions(-) diff --git a/include/linux/hyperv.h

[PATCH 08/14] vmbus: remove unused kickq argument to sendpacket

Since sendpacket no longer uses kickq arguement remove it. Remove it no longer used xmit_more in sendpacket in netvsc as well. Signed-off-by: Stephen Hemminger --- drivers/hv/channel.c| 17 +++-- drivers/net/hyperv/netvsc.c | 21 +++--

[PATCH 07/14] vmbus: remove conditional locking of vmbus_write

All current usage of vmbus write uses the acquire_lock flag, therefore having it be optional is unnecessary. This also fixes a sparse warning since sparse doesn't like when a function has conditional locking. Signed-off-by: Stephen Hemminger --- drivers/hv/channel.c

[PATCH 01/14] vmbus: remove useless return's

No need for empty return at end of void function Signed-off-by: Stephen Hemminger --- drivers/hv/hv_balloon.c | 2 -- drivers/hv/hv_fcopy.c| 2 -- drivers/hv/hv_kvp.c | 2 -- drivers/hv/hv_snapshot.c | 2 -- drivers/hv/ring_buffer.c | 2 --

[PATCH 09/14] vmbus: remove unnecessary initialization

Don't initialize variables that are then set a few lines later. Signed-off-by: Stephen Hemminger --- drivers/hv/ring_buffer.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c index

[PATCH 04/14] vmbus: eliminate unnecessary wrapper functions

The accessor functions for ring buffer are only used once and only in one file, the code is clearer without them. Signed-off-by: Stephen Hemminger --- drivers/hv/ring_buffer.c | 45 + 1 file changed, 9 insertions(+), 36

[PATCH 02/14] vmbus: constify parameters where possible

Functions that just query state of ring buffer can have parameters marked const. Signed-off-by: Stephen Hemminger --- drivers/hv/hyperv_vmbus.h | 4 ++-- drivers/hv/ring_buffer.c | 20 +--- include/linux/hyperv.h| 12 ++-- 3 files changed,

Re: [PATCH v3 00/24] i.MX Media Driver

On 01/23/2017 03:00 AM, Philipp Zabel wrote: On Fri, 2017-01-20 at 21:39 +0100, Hans Verkuil wrote: [...] There is a VDIC entity in the i.MX IPU that performs de-interlacing with hardware filters for motion compensation. Some of the motion compensation modes ("low" and "medium" motion)

Re: [PATCH 2/2] scsi: storvsc: Add support for FC lightweight host.

Hi, There is no way to issue a lip directly as the current client for this feature ( storvsc ) does not handle that request as a physical fc hba can. Storvsc only has two fc attributes exposed - port_name and node_name. You can rescan the bus with the standard echo "- - -" >

[PATCH] staging: fbtft: fix checkpatch decimal permissions error

Fix the following errors: Use 4 digit octal (0777) not decimal permissions Signed-off-by: Abdul Rauf --- 32 instances of this error has been fixed --- drivers/staging/fbtft/fb_hx8340bn.c | 2 +- drivers/staging/fbtft/fb_pcd8544.c | 4 ++--

Re: [PATCH] staging: greybus: operation: add generic timeout support

On Mon, Jan 23, 2017 at 03:39:43PM +, Bryan O'Donoghue wrote: > On 23/01/17 15:13, Johan Hovold wrote: > > On Mon, Jan 23, 2017 at 02:32:48PM +, Bryan O'Donoghue wrote: > >> On 23/01/17 12:04, Johan Hovold wrote: > >> > >>> +static void gb_operation_timeout(unsigned long arg) > >>> +{ >

Re: [PATCH v4 2/2] hv_utils: implement Hyper-V PTP source

Radim Krcmar writes: > 2017-01-19 15:16+0100, Vitaly Kuznetsov: >> With TimeSync version 4 protocol support we started updating system time >> continuously through the whole lifetime of Hyper-V guests. Every 5 seconds >> there is a time sample from the host which triggers

Re: [PATCH v2] staging: greybus: timesync: validate platform state callback

On Mon, Jan 23, 2017 at 04:32:57PM +, Rui Miguel Silva wrote: > When tearingdown timesync, and not in arche platform, the state platform > callback is not initialized. That will trigger the following NULL > dereferencing. > CallTrace: > > ? gb_timesync_platform_unlock_bus+0x11/0x20 [greybus]

[PATCH v2] staging: greybus: timesync: validate platform state callback

When tearingdown timesync, and not in arche platform, the state platform callback is not initialized. That will trigger the following NULL dereferencing. CallTrace: ? gb_timesync_platform_unlock_bus+0x11/0x20 [greybus] gb_timesync_teardown+0x85/0xc0 [greybus] gb_timesync_svc_remove+0xab/0x190

Re: [PATCH] staging: greybus: timesync: validate platform state callback

On Mon, Jan 23, 2017 at 02:22:44PM +, Rui Miguel Silva wrote: > When tearingdown timesync, and not in arche platform, the state platform > callback is not initialized. That will trigger the following NULL > dereferencing. > CallTrace: > > ? gb_timesync_platform_unlock_bus+0x11/0x20 [greybus]

Re: [PATCH] staging: greybus: timesync: validate platform state callback

Hi Johan, On Mon, Jan 23, 2017 at 04:28:08PM +0100, Johan Hovold wrote: On Mon, Jan 23, 2017 at 02:22:44PM +, Rui Miguel Silva wrote: When tearingdown timesync, and not in arche platform, the state platform callback is not initialized. That will trigger the following NULL dereferencing.

Re: [PATCH V2 1/7] staging: vchiq_arm: Add compat ioctl for create service

On Mon, 2017-01-23 at 14:38 +0300, Dan Carpenter wrote: > I'm attaching how I would basically like to see patch 1/7 done.  It's > not perfect, I did it as quickly as possible and haven't tested > anything.  I would normally be more careful if I were sending this > for > inclusion so there are no

Re: [PATCH] staging: greybus: operation: add generic timeout support

On 23/01/17 15:13, Johan Hovold wrote: > On Mon, Jan 23, 2017 at 02:32:48PM +, Bryan O'Donoghue wrote: >> On 23/01/17 12:04, Johan Hovold wrote: >> >>> +static void gb_operation_timeout(unsigned long arg) >>> +{ >>> + struct gb_operation *operation = (void *)arg; >>> + >>> + if

Re: [PATCH] staging: greybus: operation: add generic timeout support

On Mon, Jan 23, 2017 at 02:32:48PM +, Bryan O'Donoghue wrote: > On 23/01/17 12:04, Johan Hovold wrote: > > > +static void gb_operation_timeout(unsigned long arg) > > +{ > > + struct gb_operation *operation = (void *)arg; > > + > > + if (gb_operation_result_set(operation, -ETIMEDOUT)) { >

Re: [PATCH] staging: greybus: operation: add generic timeout support

On 23/01/17 12:04, Johan Hovold wrote: > +static void gb_operation_timeout(unsigned long arg) > +{ > + struct gb_operation *operation = (void *)arg; > + > + if (gb_operation_result_set(operation, -ETIMEDOUT)) { > + /* > + * A stuck request message will be

[PATCH] staging: greybus: timesync: validate platform state callback

When tearingdown timesync, and not in arche platform, the state platform callback is not initialized. That will trigger the following NULL dereferencing. CallTrace: ? gb_timesync_platform_unlock_bus+0x11/0x20 [greybus] gb_timesync_teardown+0x85/0xc0 [greybus] gb_timesync_svc_remove+0xab/0x190

Re: [PATCH v3 2/4] staging: greybus: operation: add private data with get/set accessors

On Wed, Jan 04, 2017 at 12:11:19AM +, Bryan O'Donoghue wrote: > Asynchronous operation completion handler's lives are made easier if there > is a generic pointer that can store private data associated with the > operation. This patch adds a pointer field to operation.h and get/set

[PATCH] staging: greybus: operation: add generic timeout support

Add a struct timer_list to struct gb_operation and use that to implement generic operation timeouts. This simplifies the synchronous operation handling somewhat while also providing a generic timeout mechanism that drivers can use for asynchronous operations. Signed-off-by: Johan Hovold

Re: [PATCH v3 4/4] staging: greybus: loopback: convert to use msecs internally

On Wed, Jan 04, 2017 at 12:11:21AM +, Bryan O'Donoghue wrote: > The API presented by operation.h expects milliseconds to be passed in. > This patch drops the conversion from user-input microseconds-to-jiffies and > from jiffies-to-milliseconds and instead converts directly from >

Re: [PATCH v3 3/4] staging: greybus: loopback: convert loopback to use generic async operations

On Wed, Jan 04, 2017 at 12:11:20AM +, Bryan O'Donoghue wrote: > Loopback has its own internal method for tracking and timing out > asynchronous operations however previous patches make it possible to use > functionality provided by operation.c to do this instead. Using the code in >

Re: [PATCH v3 1/4] staging: greybus: operation: add generic asynchronous timeout operation support

On Wed, Jan 04, 2017 at 12:11:18AM +, Bryan O'Donoghue wrote: > This patch adds a generic mechanism for handling timeouts of asynchronous > operations to operation.c. After doing a gb_operation_request_send() it > schedules a delayed worker. When the delayed worker's timer expires the > worker

[5] staging: vchiq_arm: add compat create_service ioctl

This implements the compat IOCTL for VCHIQ_IOC_CREATE_SERVICE32 diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 0ffe4bf8d826..6ea33cdf3976 100644 ---

[4] staging: vchiq_arm: make do_ioctl_create_service() a separate function

We want to implement a COMPAT version of this function so let's abstract away all the copy_to/from_user bits. diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 5caf53942604..0ffe4bf8d826 100644 ---

[2] staging: vchiq_arm: cleanup vchiq_ioctl_create_service()

In my last patch, I moved code to vchiq_ioctl_create_service() but without cleaning it up or fixing any checkpatch warnings. In this patch I have cleaned the function up extensively. There are no functional changes: 1) We don't need the "ret" variable and can return directly. 2) Remove some

[3] staging: vchiq_arm: remove some ugly casting

Let's start treating "arg" as a user pointer instead of an unsigned long earlier so we can remove some ugly casts. diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c index 2cc43a724554..5caf53942604 100644

[1] staging: vchiq_arm: pull create_service() into it's own function

Pull vchiq_ioctl_create_service() into its own function. I did this as simply as I could and left checkpatch.pl warnings in if they were in the original code. There is a slight functional change in that we skip some debugging but we should be using ftrace for that and get rid of the debug code

Re: [PATCH V2 1/7] staging: vchiq_arm: Add compat ioctl for create service

I'm attaching how I would basically like to see patch 1/7 done. It's not perfect, I did it as quickly as possible and haven't tested anything. I would normally be more careful if I were sending this for inclusion so there are no sign offs etc. regards, dan carpenter

Re: [PATCH v3 16/24] media: Add i.MX media core driver

Hi Steve, On Sun, 2017-01-22 at 18:31 -0800, Steve Longerbeam wrote: > > On 01/16/2017 05:47 AM, Philipp Zabel wrote: > > On Sat, 2017-01-14 at 14:46 -0800, Steve Longerbeam wrote: > > [...] > +Unprocessed Video Capture: > +-- > + > +Send frames

Re: [PATCH v3 00/24] i.MX Media Driver

On 01/23/2017 12:00 PM, Philipp Zabel wrote: > On Fri, 2017-01-20 at 21:39 +0100, Hans Verkuil wrote: > [...] >>> There is a VDIC entity in the i.MX IPU that performs de-interlacing with >>> hardware filters for motion compensation. Some of the motion compensation >>> modes ("low" and "medium"

Re: [PATCH v3 00/24] i.MX Media Driver

On Fri, 2017-01-20 at 21:39 +0100, Hans Verkuil wrote: [...] > > There is a VDIC entity in the i.MX IPU that performs de-interlacing with > > hardware filters for motion compensation. Some of the motion compensation > > modes ("low" and "medium" motion) require that the VDIC receive video > >

Re: [PATCH V2 1/7] staging: vchiq_arm: Add compat ioctl for create service

I'm sorry but I really hate this again... :/ On Sat, Jan 21, 2017 at 09:48:10AM -0800, Michael Zoran wrote: > This change is the first in a set of changes to add compat ioctls for > vc04_services. > In the change set, each ioctl modifed is pulled into a compat and native > specific > wrapper

Re: [PATCH] Staging: greybus: gpio.c - style fix

On Sun, Jan 22, 2017 at 05:35:17PM +1300, Derek Robson wrote: > Fixed bare use of 'unsigned', Found using checkpatch > > Signed-off-by: Derek Robson > --- > drivers/staging/greybus/gpio.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) This