Re: [PATCH] Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

2017-01-25 Thread gre...@linuxfoundation.org
On Thu, Jan 26, 2017 at 07:44:46AM +, Dexuan Cui wrote: > > From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > > Dexuan Cui wrote: > > > As I checked against the kernels listed on the homapage, > > > the below versions are impacted: > > > v3.16.39 > > > v3.18.47 > > > v4.

RE: [PATCH] Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

2017-01-25 Thread Dexuan Cui
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org] > > Dexuan Cui wrote: > > As I checked against the kernels listed on the homapage, > > the below versions are impacted: > > v3.16.39 > > v3.18.47 > > v4.1.38 > > v4.8.17 > > v4.9.5 > > v4.10-rc5 > > > > It's interesting v4.4.44

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Greg KH
On Thu, Jan 26, 2017 at 09:16:06AM +0300, Dan Carpenter wrote: > Please don't ever mention any legal issues on the list. We are not > lawyers and cannot help you. If you have legal concerns talk with your > lawyer or talk to Greg on the phone and he might be able to redirect you > to someone who

Re: [PATCH] Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

2017-01-25 Thread gre...@linuxfoundation.org
On Thu, Jan 26, 2017 at 06:10:19AM +, Dexuan Cui wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Wednesday, January 25, 2017 00:08 > > To: Dexuan Cui > > Cc: gre...@linuxfoundation.org; driverdev-devel@linuxdriverproject.org; KY > > Srinivasan ; Haiyang Zhang ;

Re: [PATCH] staging: bcm2835-audio: initial staging submission

2017-01-25 Thread Dan Carpenter
Thanks! regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Dan Carpenter
Please don't ever mention any legal issues on the list. We are not lawyers and cannot help you. If you have legal concerns talk with your lawyer or talk to Greg on the phone and he might be able to redirect you to someone who can help. regards, dan carpenter

RE: [PATCH] Drivers: hv: vmbus: finally fix hv_need_to_signal_on_read()

2017-01-25 Thread Dexuan Cui
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, January 25, 2017 00:08 > To: Dexuan Cui > Cc: gre...@linuxfoundation.org; driverdev-devel@linuxdriverproject.org; KY > Srinivasan ; Haiyang Zhang ; > Stephen Hemminger ; o...@aepfle.de; Rolf > Neugebauer ; jasow...@re

Re: [greybus-dev] [PATCH] staging: greybus: sdio: Prefer u32 over uint32_t

2017-01-25 Thread Viresh Kumar
On 25-01-17, 18:38, Franck Demathieu wrote: > It fixes the following issue reported by checkpatch.pl: > Prefer kernel type 'u32' over 'uint32_t' > > Signed-off-by: Franck Demathieu > --- > drivers/staging/greybus/sdio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Viresh Ku

Re: [greybus-dev] [PATCH] staging: greybus: uart: fix TIOCGSERIAL flags

2017-01-25 Thread Viresh Kumar
On 25-01-17, 18:07, Johan Hovold wrote: > This driver does not have a low-latency mode and should not report > anything else. > > Also drop the skip-test flag which isn't used either. > > Signed-off-by: Johan Hovold > --- > drivers/staging/greybus/uart.c | 1 - > 1 file changed, 1 deletion(-) >

Re: [PATCH v3 13/24] platform: add video-multiplexer subdevice driver

2017-01-25 Thread Steve Longerbeam
On 01/24/2017 04:44 AM, Javier Martinez Canillas wrote: Hello Steve, On Fri, Jan 6, 2017 at 11:11 PM, Steve Longerbeam wrote: From: Philipp Zabel [snip] +config VIDEO_MULTIPLEXER + tristate "Video Multiplexer" + depends on VIDEO_V4L2_SUBDEV_API && MEDIA_CONTROLLER The driver

[PATCH] staging: bcm2835-audio: initial staging submission

2017-01-25 Thread Michael Zoran
Initial cleanup of bcm2835-audio driver for the bcm2535(Raspberry PI) Driver provides HDMI audio through ALSA and is built on top of the vc04_services driver. Original version of the driver is available at: http://www.github.com/raspberry/linux Driver compiles without any build errors or warning

[PATCH] staging: most: hdm-usb: fix symbolic permissions warning

2017-01-25 Thread Sebastian Haas
Replace symbolic permissions with their octect representation to fix checkpatch warnings. Signed-off-by: Sebastian Haas --- drivers/staging/most/hdm-usb/hdm_usb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/m

[PATCH] staging: lustre: ptlrpc: avoid warning on missing return

2017-01-25 Thread Arnd Bergmann
The newly added function triggers a harmless warning: drivers/staging/lustre/lustre/ptlrpc/pack_generic.c: In function 'lustre_shrink_msg': drivers/staging/lustre/lustre/ptlrpc/pack_generic.c:472:1: error: control reaches end of non-void function [-Werror=return-type] This probably happens beca

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Michael Zoran
On Wed, 2017-01-25 at 12:27 -0800, Eric Anholt wrote: > Greg KH writes: > > > On Wed, Jan 25, 2017 at 05:27:14AM -0800, Michael Zoran wrote: > > > On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote: > > > > On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote: > > > > > Just for clar

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Michael Zoran
On Wed, 2017-01-25 at 10:09 -0800, Michael Zoran wrote: > On Wed, 2017-01-25 at 18:39 +0100, Stefan Wahren wrote: > > > Michael Zoran hat am 25. Januar 2017 um > > > 17:53 > > > geschrieben: > > Looking at the TODO shows 3 candidates: vc_mem, bcm2835-camera, > > VCSM > > > > I suggest to pick one

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Eric Anholt
Greg KH writes: > On Wed, Jan 25, 2017 at 05:27:14AM -0800, Michael Zoran wrote: >> On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote: >> > On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote: >> > > Just for clarity, when you mean staging code? Are you talking about >> > > the >>

Re: [PATCH v3 22/24] media: imx: Add MIPI CSI-2 OV5640 sensor subdev driver

2017-01-25 Thread Steve Longerbeam
On 01/20/2017 06:48 AM, Hans Verkuil wrote: On 01/07/2017 03:11 AM, Steve Longerbeam wrote: + + /* cached control settings */ + int ctrl_cache[OV5640_MAX_CONTROLS]; This is just duplicating the cached value in the control framework. I think this can be dropped. done, see below.

RE: [PATCH] Drivers: hv: balloon: add a comment explaining fall through in hv_memory_notifier()

2017-01-25 Thread Stephen Hemminger
Simpe /* fallthrough */ is enough -Original Message- From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] Sent: Wednesday, January 25, 2017 8:27 AM To: de...@linuxdriverproject.org Cc: linux-ker...@vger.kernel.org; KY Srinivasan ; Haiyang Zhang ; Stephen Hemminger Subject: [PATCH] Driver

Re: [PATCH] staging: greybus: sdio: Prefer u32 over uint32_t

2017-01-25 Thread Rui Miguel Silva
Hi, On Wed, Jan 25, 2017 at 06:38:01PM +0100, Franck Demathieu wrote: It fixes the following issue reported by checkpatch.pl: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Franck Demathieu Acked-by: Rui Miguel Silva Cheers, Rui --- drivers/staging/greybus/sdio.c | 2 +- 1

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Michael Zoran
On Wed, 2017-01-25 at 18:39 +0100, Stefan Wahren wrote: > > Michael Zoran hat am 25. Januar 2017 um 17:53 > > geschrieben: > > > > > > On Wed, 2017-01-25 at 06:23 -0800, Michael Zoran wrote: > > > On Wed, 2017-01-25 at 17:12 +0300, Dan Carpenter wrote: > > > > > Again, that's not my decision.  I

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Stefan Wahren
> Michael Zoran hat am 25. Januar 2017 um 17:53 > geschrieben: > > > On Wed, 2017-01-25 at 06:23 -0800, Michael Zoran wrote: > > On Wed, 2017-01-25 at 17:12 +0300, Dan Carpenter wrote: > > > > Again, that's not my decision. I can go either way. But if the > > > > decision was made to delete i

[PATCH] staging: greybus: sdio: Prefer u32 over uint32_t

2017-01-25 Thread Franck Demathieu
It fixes the following issue reported by checkpatch.pl: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Franck Demathieu --- drivers/staging/greybus/sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c

[PATCH] Staging: comedi: drivers: comedi_test: Add auto-configuration capability

2017-01-25 Thread Cheah Kok Cheong
Currently this module needs to be manually configured by COMEDI userspace tool before the test waveform can be read by a COMEDI compatible application. This patch adds auto-configuration capability and makes it the default loading option. This is achieved by creating a device during init to stand

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Michael Zoran
On Wed, 2017-01-25 at 08:53 -0800, Michael Zoran wrote: > On Wed, 2017-01-25 at 06:23 -0800, Michael Zoran wrote: > > On Wed, 2017-01-25 at 17:12 +0300, Dan Carpenter wrote: > > > > Again, that's not my decision.  I can go either way.  But if > > > > the > > > > decision was made to delete it, I th

[PATCH] staging: greybus: uart: fix TIOCGSERIAL flags

2017-01-25 Thread Johan Hovold
This driver does not have a low-latency mode and should not report anything else. Also drop the skip-test flag which isn't used either. Signed-off-by: Johan Hovold --- drivers/staging/greybus/uart.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/stag

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Michael Zoran
On Wed, 2017-01-25 at 06:23 -0800, Michael Zoran wrote: > On Wed, 2017-01-25 at 17:12 +0300, Dan Carpenter wrote: > > > Again, that's not my decision.  I can go either way.  But if the > > > decision was made to delete it, I think the 4.10 version should > > > also be > > > deleted because the same

[PATCH] Drivers: hv: balloon: add a comment explaining fall through in hv_memory_notifier()

2017-01-25 Thread Vitaly Kuznetsov
Coverity scan gives a warning when there is fall through in a switch without a comment. Reported-by: Stephen Hemminger Signed-off-by: Vitaly Kuznetsov --- drivers/hv/hv_balloon.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c index 14

Re: [PATCH] staging: fbtft: fixed coding style issues in fb_pcd8544.c

2017-01-25 Thread Dragos Tarcatu
On 25.01.2017 14:39, Greg Kroah-Hartman wrote: On Wed, Jan 25, 2017 at 02:24:22PM +0200, Dragos Tarcatu wrote: Fixed the following checkpatch.pl errors in fb_pcd8544.c: ERROR: Use 4 digit octal (0777) not decimal permissions +module_param(tc, uint, 0); ERROR: Use 4 digit octal (0777) not decim

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Michael Zoran
On Wed, 2017-01-25 at 17:12 +0300, Dan Carpenter wrote: > > Again, that's not my decision.  I can go either way.  But if the > > decision was made to delete it, I think the 4.10 version should > > also be > > deleted because the same logic applies.  Nothing uses it 4.10 > > either > > and 4.10 is s

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Dan Carpenter
On Wed, Jan 25, 2017 at 05:41:50AM -0800, Michael Zoran wrote: > > > I'm just saying that IF the decision was made to continue > > > upstreaming > > > these drivers, then I'm willing to continue helping by submitting > > > improvements. > > > > Either they should be merged, or these apis and struc

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Michael Zoran
On Wed, 2017-01-25 at 14:33 +0100, Greg KH wrote: > On Wed, Jan 25, 2017 at 05:27:14AM -0800, Michael Zoran wrote: > > On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote: > > > On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote: > > > > Just for clarity, when you mean staging code? A

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Greg KH
On Wed, Jan 25, 2017 at 05:27:14AM -0800, Michael Zoran wrote: > On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote: > > On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote: > > > Just for clarity, when you mean staging code? Are you talking about > > > the > > > entire vc04_services

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Michael Zoran
On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote: > On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote: > > Just for clarity, when you mean staging code? Are you talking about > > the > > entire vc04_services driver or are we talking about the > > vchi_msg_queue > > function?   > >

[PATCH 1/2] Drivers: hv: restore hypervcall page cleanup before kexec

2017-01-25 Thread Vitaly Kuznetsov
We need to cleanup the hypercall page before doing kexec/kdump or the new kernel may crash if it tries to use it. Reuse the now-empty hv_cleanup function renaming it to hyperv_cleanup and moving to the arch specific code. Fixes: 8730046c1498 ("Drivers: hv vmbus: Move Hypercall page setup out of c

[PATCH 2/2] Drivers: hv: restore TSC page cleanup before kexec

2017-01-25 Thread Vitaly Kuznetsov
We need to cleanup the TSC page before doing kexec/kdump or the new kernel may crash if it tries to use it. Fixes: 63ed4e0c67df ("Drivers: hv: vmbus: Consolidate all Hyper-V specific clocksource code") Signed-off-by: Vitaly Kuznetsov --- arch/x86/hyperv/hv_init.c | 4 1 file changed, 4 ins

[PATCH 0/2] Drivers: hv: fix kexec/kdump after the recent changes

2017-01-25 Thread Vitaly Kuznetsov
'Restructure architecture specific code' series (now merged in char-misc) introduced a regression wrt kexec/kdump. Hypercall and TSC pages setup was moved out to the architecture specific code and the cleanup was dropped. We, however, still need this cleanup: in kexec case the new kernel may try us

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Dan Carpenter
On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote: > Just for clarity, when you mean staging code? Are you talking about the > entire vc04_services driver or are we talking about the vchi_msg_queue > function? > > At this point, vc04_services isn't used by anything in the tree at all

Re: [PATCH] staging: fbtft: fixed coding style issues in fb_pcd8544.c

2017-01-25 Thread Greg Kroah-Hartman
On Wed, Jan 25, 2017 at 02:24:22PM +0200, Dragos Tarcatu wrote: > Fixed the following checkpatch.pl errors in fb_pcd8544.c: > > ERROR: Use 4 digit octal (0777) not decimal permissions > +module_param(tc, uint, 0); > ERROR: Use 4 digit octal (0777) not decimal permissions > +module_param(bs, uint,

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Michael Zoran
On Wed, 2017-01-25 at 15:10 +0300, Dan Carpenter wrote: > On Tue, Jan 24, 2017 at 12:34:04PM -0800, Michael Zoran wrote: > > The vchi_msg_queue function which is used by other drivers > > to queue a message is difficult to understand and overly > > generic. Remove it and replace it with two more sp

[PATCH] staging: fbtft: fixed coding style issues in fb_pcd8544.c

2017-01-25 Thread Dragos Tarcatu
Fixed the following checkpatch.pl errors in fb_pcd8544.c: ERROR: Use 4 digit octal (0777) not decimal permissions +module_param(tc, uint, 0); ERROR: Use 4 digit octal (0777) not decimal permissions +module_param(bs, uint, 0); Also made the two module parameters readable from sysfs. Signed-off-by

Re: [PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

2017-01-25 Thread Dan Carpenter
On Tue, Jan 24, 2017 at 12:34:04PM -0800, Michael Zoran wrote: > The vchi_msg_queue function which is used by other drivers > to queue a message is difficult to understand and overly > generic. Remove it and replace it with two more specific functions. The vc04_services is missing several drivers.