[PATCH] staging: vchi: Remove ARM64 from TODO list

ARM64 for core vchiq which is the core of vc04_services should now be work complete. The driver compiles without any errors or warnings, and works just as well as 32 bit mode. The necessary compatibility wrappers for the 32 bit ioctls have been written and merged. Since no more ARM64 specific

Re: outreachy

On Thu, Mar 09, 2017 at 02:15:21PM -0800, Florian Fainelli wrote: > On 03/09/2017 01:20 PM, Greg KH wrote: > > On Thu, Mar 09, 2017 at 01:56:49PM -0700, Stephen Warren wrote: > >> On 03/09/2017 01:51 PM, Scott Branden wrote: > >>> Hi Julia, > >>> > >>> On 17-03-09 12:36 PM, Julia Lawall wrote: >

Re: [PATCH] Minor coding guideline Fix in lusture module

On Mar 9, 2017, at 05:22, Pushkar Jambhlekar wrote: > Subject: Minor coding guideline Fix in lusture module I suspect the patchbot is unhappy with the subject line not containing anything useful, and not containing the subsystem name. Something like: staging/lustre/llite:

[PATCH 1/3] staging: atomisp_fops: Clean up tests if NULL returned on failure

Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal

[PATCH 3/3] staging: lirc_zilog: Clean up tests if NULL returned on failure

Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal

[PATCH 0/3] staging: media: Clean up tests if NULL returned on failure

This patch series tests if functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. simran singhal (3): staging: atomisp_fops: Clean up tests if NULL returned on failure staging: vpfe_mc_capture: Clean up tests if NULL returned on failure

[PATCH 2/3] staging: vpfe_mc_capture: Clean up tests if NULL returned on failure

Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal

[PATCH 08/10] staging: bcm2835-camera: Fix buffer overflow calculation on query of camera properties

The code that queries properties on the camera has a check for buffer overruns if the firmware sends too much data. This check is incorrect, and during testing I was seeing stack corruption. I believe this error can actually happen in normal use, just for some reason it doesn't appear on 32 bit

[PATCH 10/10] staging: bcm2835-camera: remove depends on ARM

Since all the arm64 specific issues have been fixed now and the camera is working fine with a arm64 kernel, the depends on ARM can be removed from Kconfig. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-camera/Kconfig | 1 - 1 file changed, 1

[PATCH 07/10] staging: bcm2835-camera: Convert spinlock to mutex in handle mapping code

The handle mapping code that converts context pointers to handles uses a spinlock. Since the btree implementation can sleep while allocating memory, turning on several kernel debugging options will result in errors in the log. Since this code path is never called in atomic context, perhaps it's

[PATCH 09/10] staging: bcm2835-camera: Fix bogus compiler warnings regarding constants

In debug logging code, the compiler is warning about imposible situations and size of constants not matching the format specifier. This change fixes all three instances of this. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.h

[PATCH 04/10] staging: bcm2835-camera: Convert client_context field to a 32 bit handle

The client_context field is passed around which is really just a pointer to a msg_context. A lookup table mechanism for msg_context was added previously, so convert this field to a handle as well. The firmware never interperates the client_context, just passed it back. Signed-off-by: Michael

[PATCH 02/10] staging: bcm2835-camera: Convert client_component field to u32

In the messages passed back and forth between the camera and the firmware, a client_component field is passed. This is a pointer to a structure that represents part of the camera. Luckly, it's only used for debug logging, so simply convert it to a u32. Signed-off-by: Michael Zoran

[PATCH 00/10] staging: bcm2835-camera: Finish ARM64 port

This finishes the ARM64 port for the camera driver. I have tested everything on a ARM64 built kernel for the Raspberry PI 3 and everything seems to be working fine now. Most of the changes are very small, but I have broken them into small sized sets of changes for easier review. I tested the

[PATCH 01/10] staging: bcm2835-camera: Create struct mmal_es_format_local to mirror struct mmal_es_format

The struct struct mmal_es_format is passed between the firmware which has pointers. A local version of mmal_es_format is also used. Luckly, the two versions are always memberwise copied from each other so simply have different structures for the local and msg versions. Signed-off-by: Michael

[PATCH 03/10] staging: bcm2835-camera: Convert delayed_buffer to u32

A delayed buffer field is passed between the firmware and the kernel. This field is never used either so it's safe to change it to a u32. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 06/10] staging: bcm2835-camera: Convert struct mmal_buffer_header info fields to u32

The struct mmal_buffer_header has multiple fields used for informational and debugging purposes. These are safe to convert to u32. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h | 10 +-

[PATCH 05/10] staging: bcm2835-camera: Convert struct mmal_port info fields to u32

The struct mmal_port has a few informational fields. Convert these to u32. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-camera/mmal-msg-port.h | 10 +- drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c| 2 +- 2 files changed, 6

[PATCH 5/5] staging: rtllib_wx: Clean up tests if NULL returned on failure

Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal

[PATCH 4/5] staging: rtllib_softmac: Clean up tests if NULL returned on failure

Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal

[PATCH 3/5] staging: rtllib_crypt_wep: Clean up tests if NULL returned on failure

Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal

[PATCH 2/5] staging: rtllib_crypt_tkip: Clean up tests if NULL returned on failure

Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal

[PATCH 1/5] staging: rtllib_crypt_ccmp: Clean up tests if NULL returned on failure

Some functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. This was done using Coccinelle: @@ expression *e; identifier l1; @@ e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...); ... - e == NULL + !e Signed-off-by: simran singhal

[PATCH 0/5] staging: rtl8192e: Clean up tests if NULL returned on failure

This patch series tests if functions like kmalloc/kzalloc return NULL on failure. When NULL represents failure, !x is commonly used. simran singhal (5): staging: rtllib_crypt_ccmp: Clean up tests if NULL returned on failure staging: rtllib_crypt_tkip: Clean up tests if NULL returned on

[PATCH v5 29/39] ARM: imx_v6_v7_defconfig: Enable staging video4linux drivers

Enable i.MX v4l2 media staging driver. For video capture on i.MX, the video multiplexer subdev is required. On the SabreAuto, the ADV7180 video decoder is required along with i2c-mux-gpio. The Sabrelite and SabreSD require the OV5640 and the SabreLite requires PWM clocks for the OV5640. Increase

[PATCH v5 38/39] media: imx: csi: fix crop rectangle reset in sink set_fmt

From: Philipp Zabel The csi_try_crop call in set_fmt should compare the cropping rectangle to the currently set input format, not to the previous input format. Signed-off-by: Philipp Zabel Signed-off-by: Steve Longerbeam

[PATCH v5 37/39] media: imx: csi: add frame skipping support

From: Philipp Zabel The CSI can skip any out of up to 6 input frames, allowing to reduce the frame rate at the output pads by small fractions. Signed-off-by: Philipp Zabel Signed-off-by: Steve Longerbeam ---

[PATCH v5 28/39] media: imx: Add MIPI CSI-2 Receiver subdev driver

Adds MIPI CSI-2 Receiver subdev driver. This subdev is required for sensors with a MIPI CSI2 interface. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Makefile | 1 + drivers/staging/media/imx/imx6-mipi-csi2.c | 689

[PATCH v5 39/39] media: imx: propagate sink pad formats to source pads

As part of this, separate format try code from *_set_fmt() into *_try_fmt(), so that the latter function can be used to propagate a legal format from sink to source. This also reduces subsequent bloat in *_set_fmt(). imx-ic-prp never needed separate formats for sink and source pads, so

[PATCH v5 26/39] media: imx: Add VDIC subdev driver

This is a media entity subdevice driver for the i.MX Video De-Interlacing or Combining Block. So far this entity does not implement the Combining function but only motion compensated deinterlacing. Video frames are received from the CSI and are routed to the IC PRPVF entity. Signed-off-by: Steve

[PATCH v5 22/39] media: Add userspace header file for i.MX

This adds a header file for use by userspace programs wanting to interact with the i.MX media driver. It defines custom v4l2 controls for the i.MX v4l2 subdevices. Signed-off-by: Steve Longerbeam --- include/uapi/media/Kbuild | 1 + include/uapi/media/imx.h | 21

[PATCH v5 31/39] media: imx: csi: add support for bayer formats

From: Russell King Bayer formats must be treated as generic data and passthrough mode must be used. Add the correct setup for these formats. Signed-off-by: Russell King - added check to csi_link_validate() to verify that destination is

[PATCH v5 35/39] media: imx: csi/fim: add support for frame intervals

From: Russell King Add support to CSI for negotiation of frame intervals, and use this information to configure the frame interval monitor. Signed-off-by: Russell King Signed-off-by: Steve Longerbeam ---

[PATCH v5 36/39] media: imx: redo pixel format enumeration and negotiation

The previous API and negotiation of mbus codes and pixel formats was broken, and has been completely redone. The negotiation of media bus codes should be as follows: CSI: sink pad direct src pad IDMAC src pad - RGB (any)IPU RGB

[PATCH v5 33/39] media: imx: mipi-csi2: enable setting and getting of frame rates

From: Russell King Setting and getting frame rates is part of the negotiation mechanism between subdevs. The lack of support means that a frame rate at the sensor can't be negotiated through the subdev path. Add support at MIPI CSI2 level for handling this part of

[PATCH v5 34/39] media: imx: csi: add __csi_get_fmt

Add __csi_get_fmt() and use it to return the correct mbus format (active or try) in get_fmt. Use it in other places as well. Signed-off-by: Steve Longerbeam Suggested-by: Russell King --- drivers/staging/media/imx/imx-media-csi.c | 61

[PATCH v5 32/39] media: imx: csi: fix crop rectangle changes in set_fmt

From: Philipp Zabel The cropping rectangle was being modified by the output pad's set_fmt, which is the wrong pad to do this. The crop rectangle should not be modified by the output pad set_fmt. It instead should be reset to the full input frame when the input pad format

[PATCH v5 30/39] media: imx: add support for bayer formats

From: Russell King Add the bayer formats to imx-media's list of supported pixel and bus formats. Signed-off-by: Russell King - added a bayer boolean to struct imx_media_pixfmt. Signed-off-by: Steve Longerbeam

[PATCH v5 27/39] media: imx: Add IC subdev drivers

This is a set of three media entity subdevice drivers for the i.MX Image Converter: - Pre-process Router: Takes input frames from CSI0, CSI1, or VDIC. Two output pads enable either or both of the preprocess tasks below. If the input is from one of the CSIs, both proprocess task links can be

[PATCH v5 23/39] media: Add i.MX media core driver

Add the core media driver for i.MX SOC. Signed-off-by: Steve Longerbeam --- Documentation/media/v4l-drivers/imx.rst | 560 drivers/staging/media/Kconfig | 2 + drivers/staging/media/Makefile| 1 +

[PATCH v5 24/39] media: imx: Add Capture Device Interface

This is the capture device interface driver that provides the v4l2 user interface. Frames can be received from various sources: - directly from CSI for capturing unconverted images directly from camera sensors. - from the IC pre-process encode task. - from the IC pre-process viewfinder task.

[PATCH v5 25/39] media: imx: Add CSI subdev driver

This is a media entity subdevice for the i.MX Camera Sensor Interface module. Signed-off-by: Steve Longerbeam --- drivers/staging/media/imx/Kconfig | 14 + drivers/staging/media/imx/Makefile|2 + drivers/staging/media/imx/imx-media-csi.c | 1311

[PATCH v5 13/39] ARM: dts: imx6-sabreauto: add the ADV7180 video decoder

Enables the ADV7180 decoder sensor. The ADV7180 connects to the parallel-bus mux input on ipu1_csi0_mux. The ADV7180 power pin is via max7310_b port expander. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 58

[PATCH v5 19/39] [media] add Omnivision OV5640 sensor driver

This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta branch, modified heavily to bring forward to latest interfaces and code cleanup. Signed-off-by: Steve Longerbeam --- drivers/media/i2c/Kconfig |7 + drivers/media/i2c/Makefile |1 +

[PATCH v5 20/39] platform: add video-multiplexer subdevice driver

From: Philipp Zabel This driver can handle SoC internal and external video bus multiplexers, controlled either by register bit fields or by a GPIO. The subdevice passes through frame interval and mbus configuration of the active input to the output side. Signed-off-by:

[PATCH v5 21/39] UAPI: Add media UAPI Kbuild file

Add an empty UAPI Kbuild file for media UAPI headers. Signed-off-by: Steve Longerbeam --- include/uapi/Kbuild | 1 + include/uapi/media/Kbuild | 1 + 2 files changed, 2 insertions(+) create mode 100644 include/uapi/media/Kbuild diff --git

[PATCH v5 16/39] [media] v4l2: add a new-frame before end-of-frame event

Add a NEW_FRAME_BEFORE_EOF event to signal that a video capture or output device has signaled a new frame is ready before a previous frame has completed reception or transmission. This usually indicates a DMA read/write channel is having trouble gaining bus access. Signed-off-by: Steve Longerbeam

[PATCH v5 18/39] [media] v4l: subdev: Add function to validate frame interval

If the pads on both sides of a link specify a frame interval, then those frame intervals should match. Create the exported function v4l2_subdev_link_validate_frame_interval() to verify this. This function can be called in a subdevice's media_entity_operations or v4l2_subdev_pad_ops link_validate

[PATCH v5 15/39] [media] v4l2: add a frame interval error event

Add a new FRAME_INTERVAL_ERROR event to signal that a video capture or output device has measured an interval between the reception or transmit completion of two consecutive frames of video that is outside the nominal frame interval by some tolerance value. Signed-off-by: Steve Longerbeam

[PATCH v5 11/39] ARM: dts: imx6-sabreauto: add reset-gpios property for max7310_b

The reset pin to the port expander chip (MAX7310) is controlled by a gpio, so define a reset-gpios property to control it. There are three MAX7310's on the SabreAuto CPU card (max7310_[abc]), but all use the same pin for their reset. Since all can't acquire the same pin, assign it to max7310_b,

[PATCH v5 14/39] add mux and video interface bridge entity functions

From: Philipp Zabel Signed-off-by: Philipp Zabel - renamed MEDIA_ENT_F_MUX to MEDIA_ENT_F_VID_MUX Signed-off-by: Steve Longerbeam --- Documentation/media/uapi/mediactl/media-types.rst | 22 ++

[PATCH v5 17/39] [media] v4l2-mc: add a function to inherit controls from a pipeline

v4l2_pipeline_inherit_controls() will add the v4l2 controls from all subdev entities in a pipeline to a given video device. Signed-off-by: Steve Longerbeam --- drivers/media/v4l2-core/v4l2-mc.c | 48 +++ include/media/v4l2-mc.h

[PATCH v5 12/39] ARM: dts: imx6-sabreauto: add pinctrl for gpt input capture

Add pinctrl groups for both GPT input capture channels. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi

[PATCH v5 09/39] ARM: dts: imx6-sabresd: add OV5642 and OV5640 camera sensors

Enables the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux. The OV5640 connects to the input port on the MIPI CSI-2 receiver on mipi_csi. Until the OV5652 sensor module compatible with the SabreSD becomes

[PATCH v5 08/39] ARM: dts: imx6-sabrelite: add OV5642 and OV5640 camera sensors

Adds the OV5642 parallel-bus sensor, and the OV5640 MIPI CSI-2 sensor. Both hang off the same i2c2 bus, so they require different (and non- default) i2c slave addresses. The OV5642 connects to the parallel-bus mux input port on ipu1_csi0_mux. The OV5640 connects to the input port on the MIPI

[PATCH v5 10/39] ARM: dts: imx6-sabreauto: create i2cmux for i2c3

The sabreauto uses a steering pin to select between the SDA signal on i2c3 bus, and a data-in pin for an SPI NOR chip. Use i2cmux to control this steering pin. Idle state of the i2cmux selects SPI NOR. This is not a classic way to use i2cmux, since one side of the mux selects something other than

[PATCH v5 06/39] ARM: dts: imx6qdl: add capture-subsystem device

Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6dl.dtsi | 5 + arch/arm/boot/dts/imx6q.dtsi | 5 + 2 files changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/imx6dl.dtsi b/arch/arm/boot/dts/imx6dl.dtsi index 8958c4a..a959c76 100644 ---

[PATCH v5 07/39] ARM: dts: imx6qdl-sabrelite: remove erratum ERR006687 workaround

There is a pin conflict with GPIO_6. This pin functions as a power input pin to the OV5642 camera sensor, but ENET uses it as the h/w workaround for erratum ERR006687, to wake-up the ARM cores on normal RX and TX packet done events. So we need to remove the h/w workaround to support the OV5642.

[PATCH v5 05/39] ARM: dts: imx6qdl: Add mipi_ipu1/2 multiplexers, mipi_csi, and their connections

From: Philipp Zabel This patch adds the device tree graph connecting the input multiplexers to the IPU CSIs and the MIPI-CSI2 gasket on i.MX6. The MIPI_IPU multiplexers are added as children of the iomuxc-gpr syscon device node. On i.MX6Q/D two two-input multiplexers in

[PATCH v5 04/39] ARM: dts: imx6qdl: Add compatible, clocks, irqs to MIPI CSI-2 node

Add to the MIPI CSI2 receiver node: compatible strings, interrupt sources, and clocks. Signed-off-by: Steve Longerbeam --- arch/arm/boot/dts/imx6qdl.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi

[PATCH v5 00/39] i.MX Media Driver

In version 5: - ov5640: renamed "pwdn-gpios" to "powerdown-gpios" - ov5640: add mutex lock around the subdev op entry points. - ov5640: don't attempt to program the new mode in ov5640_set_fmt(). Instead set a new flag, pending_mode_change, and program the new mode at s_stream() if flag is

[PATCH v5 03/39] [media] dt/bindings: Add bindings for OV5640

Add device tree binding documentation for the OV5640 camera sensor. Signed-off-by: Steve Longerbeam --- .../devicetree/bindings/media/i2c/ov5640.txt | 45 ++ 1 file changed, 45 insertions(+) create mode 100644

[PATCH v5 01/39] [media] dt-bindings: Add bindings for video-multiplexer device

From: Philipp Zabel Add bindings documentation for the video multiplexer device. Signed-off-by: Sascha Hauer Signed-off-by: Philipp Zabel Signed-off-by: Steve Longerbeam ---

[PATCH v5 02/39] [media] dt-bindings: Add bindings for i.MX media driver

Add bindings documentation for the i.MX media driver. Signed-off-by: Steve Longerbeam --- Documentation/devicetree/bindings/media/imx.txt | 74 + 1 file changed, 74 insertions(+) create mode 100644

[PATCH] Staging: iio: return expression instead of return ret

The following Coccinelle script was used to detect this: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Bo YU --- drivers/staging/iio/meter/ade7754.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [PATCH v4 13/36] [media] v4l2: add a frame timeout event

On 03/05/2017 02:41 PM, Russell King - ARM Linux wrote: On Sat, Mar 04, 2017 at 04:37:43PM -0800, Steve Longerbeam wrote: On 03/04/2017 02:56 AM, Sakari Ailus wrote: That's a bit of a special situation --- still there are alike conditions on existing hardware. You should return the buffers

Re: [PATCH] net: hyperv: use new api ethtool_{get|set}_link_ksettings

On Wed, 8 Mar 2017 23:41:04 +0100 Philippe Reynes wrote: > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > > Signed-off-by:

[PATCH v1 7/7] staging: gc2235: Do not use multiple blank lines

Remove multiple blank lines. Problem found using checkpatch.pl "CHECK: Please don't use multiple blank lines". Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH v1 6/7] staging: gc2235: Use x instead of x != NULL

Use x instead of x != NULL . This patch removes the explicit NULL comparisons.This issue is found by checkpatch.pl script. Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v1 3/7] staging: gc2235: Replace NULL with "!"

Use ! in comparison tests using "==NULL" rather than moving the "==NULL" to the right side of the test. Addesses multiple instances of the checkpatch.pl warning: WARNING: Comparisons should place the constant on the right side of the test Signed-off-by: simran singhal

[PATCH v1 1/7] staging: gc2235: Remove unnecessary typecast of c90 int constant

This patch removes unnecessary typecast of c90 int constant. WARNING: Unnecessary typecast of c90 int constant Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v1 2/7] staging: gc2235: Add blank line after a declaration

Add blank line after a declaration. Problem found using checkpatch. This patch fixes these warning messages found by checkpatch.pl: WARNING : Missing a blank line after declarations. Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 7

[PATCH v1 5/7] staging: gc2235: Remove multiple assignments

Remove multiple assignments by factorizing them. Problem found using checkpatch.pl CHECK: multiple assignments should be avoided Signed-off-by: simran singhal --- drivers/staging/media/atomisp/i2c/gc2235.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH v1 4/7] staging: gc2235: Remove blank line before '}' and after '{' braces

Remove unneeded blank lines preceding/following '}' and '{' braces, as pointed out by checkpatch. This patch addresses the following checkpatch checks: CHECK: Blank lines aren't necessary before a close brace '}' CHECK: Blank lines aren't necessary after an open brace '{' Signed-off-by: simran

[PATCH v1 0/7] staging: gc2235: Multiple checkpatch issues

v1: -change the subject of all the patches of the patch-series simran singhal (7): staging: gc2235: Remove unnecessary typecast of c90 int constant staging: gc2235: Add blank line after a declaration staging: gc2235: Replace NULL with "!" staging: gc2235: Remove blank line before '}'

Re: outreachy

On 03/09/2017 01:20 PM, Greg KH wrote: > On Thu, Mar 09, 2017 at 01:56:49PM -0700, Stephen Warren wrote: >> On 03/09/2017 01:51 PM, Scott Branden wrote: >>> Hi Julia, >>> >>> On 17-03-09 12:36 PM, Julia Lawall wrote: Hello, I discussed the issue of outreachy patches for bcm with

Re: [Outreachy kernel] [PATCH 5/6] staging: speakup: Alignment should match open parenthesis

On Fri, 10 Mar 2017, Arushi Singhal wrote: > Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". > > Signed-off-by: Arushi Singhal > --- > if (synth_request_region(speakup_info.port_tts - 1, > -

Re: outreachy

On Thu, Mar 09, 2017 at 01:56:49PM -0700, Stephen Warren wrote: > On 03/09/2017 01:51 PM, Scott Branden wrote: > > Hi Julia, > > > > On 17-03-09 12:36 PM, Julia Lawall wrote: > > > Hello, > > > > > > I discussed the issue of outreachy patches for bcm with Greg, and we are > > > not convinced

Re: [PATCH v2 05/12] staging: ks7010: remove unnecessary parenthesis

On Thu, Mar 09, 2017 at 09:30:40PM +0100, Greg Kroah-Hartman wrote: > On Fri, Mar 10, 2017 at 07:08:28AM +1100, Tobin C. Harding wrote: > > On Thu, Mar 09, 2017 at 02:04:20PM +0100, Greg Kroah-Hartman wrote: > > > On Thu, Mar 09, 2017 at 03:47:05PM +1100, Tobin C. Harding wrote: > > > > Checkpatch

Re: outreachy

On 03/09/2017 01:51 PM, Scott Branden wrote: Hi Julia, On 17-03-09 12:36 PM, Julia Lawall wrote: Hello, I discussed the issue of outreachy patches for bcm with Greg, and we are not convinced that not having the patches CCd to you is such a good idea. While we don't want to spam you with

Re: outreachy

Hi Julia, On 17-03-09 12:36 PM, Julia Lawall wrote: Hello, I discussed the issue of outreachy patches for bcm with Greg, and we are not convinced that not having the patches CCd to you is such a good idea. While we don't want to spam you with noise, some of the applicants are starting to make

outreachy

Hello, I discussed the issue of outreachy patches for bcm with Greg, and we are not convinced that not having the patches CCd to you is such a good idea. While we don't want to spam you with noise, some of the applicants are starting to make more significant changes that it could be useful for

Re: [PATCH v2 05/12] staging: ks7010: remove unnecessary parenthesis

On Fri, Mar 10, 2017 at 07:08:28AM +1100, Tobin C. Harding wrote: > On Thu, Mar 09, 2017 at 02:04:20PM +0100, Greg Kroah-Hartman wrote: > > On Thu, Mar 09, 2017 at 03:47:05PM +1100, Tobin C. Harding wrote: > > > Checkpatch emits CHECK: Unnecessary parentheses. > > > > > > Remove unnecessary

[PATCH 2/2] Staging: wlan-ng: Fix endian error

sparse report fixed: drivers/staging//wlan-ng//hfa384x_usb.c:3517:35: warning: restricted __be64 degrades to integer drivers/staging//wlan-ng//hfa384x_usb.c:3517:33: warning: incorrect type in assignment (different base types) drivers/staging//wlan-ng//hfa384x_usb.c:3517:33:expected

[PATCH 1/2] Staging: wlan-ng: Fix sparse warnings by using appropriate endian types

Fix some sparse warning by using correct endian types in structs and local variables. This patch only fix sparse warnings and do not change the logic. Signed-off-by: Adrien Descamps --- Compile tested only drivers/staging/wlan-ng/hfa384x.h | 54

Re: [PATCH v2 03/12] staging: ks7010: replace C types with kernel types

On Thu, Mar 09, 2017 at 02:04:45PM +0100, Greg Kroah-Hartman wrote: > On Thu, Mar 09, 2017 at 03:47:03PM +1100, Tobin C. Harding wrote: > > Checkpatch emits CHECK prefer kernel type. Source and header file use > > C standard types uintN_t. > > > > Replace C standard types with kernel types.

Re: [PATCH v2 05/12] staging: ks7010: remove unnecessary parenthesis

On Thu, Mar 09, 2017 at 02:04:20PM +0100, Greg Kroah-Hartman wrote: > On Thu, Mar 09, 2017 at 03:47:05PM +1100, Tobin C. Harding wrote: > > Checkpatch emits CHECK: Unnecessary parentheses. > > > > Remove unnecessary parentheses. > > > > Signed-off-by: Tobin C. Harding > > --- > >

[PATCH] staging: speakup: Simplify "NULL" comparisons

Fixed coding style for null comparisons in speakup driver to be more consistant with the rest of the kernel coding style. Replaced 'x != NULL' with 'x' and 'x = NULL' with '!x'. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/fakekey.c | 2 +-

[PATCH] staging: speakup: Unnecessary parentheses are removed.

Unnecessary parentheses are removed to improve readability. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/kobjects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/kobjects.c

Re: [RFC PATCH v2 13/32] KVM: SVM: Enable SEV by setting the SEV_ENABLE CPU feature

On Thu, Mar 02, 2017 at 10:15:01AM -0500, Brijesh Singh wrote: > From: Tom Lendacky > > Modify the SVM cpuid update function to indicate if Secure Encrypted > Virtualization (SEV) is active in the guest by setting the SEV KVM CPU > features bit. SEV is active if Secure

[PATCH 5/6] staging: speakup: Alignment should match open parenthesis

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/speakup/kobjects.c | 16 drivers/staging/speakup/main.c | 2 +- drivers/staging/speakup/selection.c

[PATCH 6/6] staging: speakup: Add blank line after function/struct/union/enum declarations

This patch fixes the warnings reported by checkpatch.pl for please use a blank line after function/struct/union/enum declarations. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 1 + drivers/staging/speakup/serialio.c | 1 +

[PATCH] Staging: xgifb: XGI_main_26.c: non-standard C

Fixes following checkpatch warning: "WARNING: %Lx is non-standard C, use %llx" Signed-off-by: Manoj Sawai --- drivers/staging/xgifb/XGI_main_26.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/xgifb/XGI_main_26.c

[PATCH 4/6] staging: speakup: identation should use tabs

Indentation should always use tabs and never spaces. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/speakup_dtlk.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/speakup/speakup_dtlk.h

[PATCH 3/6] staging: speakup: spaces preferred around operator

Fixed the checkpatch.pl issues like: CHECK: spaces preferred around that '&' (ctx:VxV) CHECK: spaces preferred around that '|' (ctx:VxV) CHECK: spaces preferred around that '-' (ctx:VxV) CHECK: spaces preferred around that '+' (ctx:VxV) etc. Signed-off-by: Arushi Singhal

[PATCH 1/6] staging: speakup: fix "Alignment match open parenthesis"

Fix checkpatch issues: "CHECK: Alignment should match open parenthesis". Signed-off-by: Arushi Singhal --- drivers/staging/speakup/i18n.c | 2 +- drivers/staging/speakup/kobjects.c | 40 +++--- 2 files changed, 21

[PATCH 2/6] staging: speakup: Placed Logical on the previous line

Placed Logical continuations on the previous line as reported by checkpatch.pl. Signed-off-by: Arushi Singhal --- drivers/staging/speakup/main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/speakup/main.c

[PATCH 0/6] staging: speakup: multiple checkpatch issues

Improve readability by fixing multiple checkpatch.pl issues in speakup driver. Arushi Singhal (6): staging: speakup: fix "Alignment match open parenthesis" staging: speakup: Placed Logical on the previous line staging: speakup: spaces preferred around operator staging: speakup:

[PATCH v2 2/5] staging: rtl8192e: Improve error handling

From: Suniel Mahesh Return -ENOMEM, if it is out of memory Signed-off-by: Suniel Mahesh --- Changes for v2: - Improve error handling reported by checkpatch.pl in rtl_core.c - new patch addition to the series - Rebased on top of next-20170306 ---

[PATCH v2 3/5] staging: rtl8192e: Rectify pointer comparisions

From: Suniel Mahesh Pointer comparison with NULL replaced by logical NOT Signed-off-by: Suniel Mahesh --- Changes for v2: - Rectify pointer comparisions reported by checkpatch.pl in rtl_core.c - new patch addition to the series - Rebased on top of

  1   2   >