[RFC PATCHv2 20/21] staging: android: ion: Remove ion_handle and ion_client

2017-03-17 Thread Laura Abbott
ion_handle was introduced as an abstraction to represent a reference to a buffer via an ion_client. As frameworks outside of Ion evolved, the dmabuf emerged as the preferred standard for use in the kernel. This has made the ion_handle an unnecessary abstraction and prone to race conditions.

[RFC PATCHv2 21/21] staging: android: ion: Set query return value

2017-03-17 Thread Laura Abbott
This never got set in the ioctl. Properly set a return value of 0 on success. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index

[RFC PATCHv2 11/21] staging: android: ion: Remove duplicate ION_IOC_MAP

2017-03-17 Thread Laura Abbott
ION_IOC_MAP is the same as ION_IOC_SHARE. We really don't need two identical interfaces. Remove it. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/compat_ion.c | 1 - drivers/staging/android/ion/ion-ioctl.c | 1 - drivers/staging/android/uapi/ion.h |

[RFC PATCHv2 17/21] staging: android: ion: Collapse internal header files

2017-03-17 Thread Laura Abbott
Ion current has ion_priv.h and ion.h as header files. ion.h was intended to be used for public APIs but Ion never ended up really having anything public. Combine the two headers so there is only one internal header. Signed-off-by: Laura Abbott ---

[RFC PATCHv2 19/21] staging: android: ion: Drop ion_map_kernel interface

2017-03-17 Thread Laura Abbott
Nobody uses this interface externally. Drop it. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion.c | 59 --- 1 file changed, 59 deletions(-) diff --git a/drivers/staging/android/ion/ion.c

[RFC PATCHv2 10/21] staging: android: ion: Remove import interface

2017-03-17 Thread Laura Abbott
With the expansion of dma-buf and the move for Ion to be come just an allocator, the import mechanism is mostly useless. There isn't a kernel component to Ion anymore and handles are private to Ion. Remove this interface. Signed-off-by: Laura Abbott ---

[RFC PATCHv2 18/21] staging: android: ion: Rework heap registration/enumeration

2017-03-17 Thread Laura Abbott
The current model of Ion heap registration is based on the outdated model of board files. The replacement for board files (devicetree) isn't a good replacement for what Ion wants to do. In actuality, Ion wants to show what memory is available in the system for something else to figure out what

[RFC PATCHv2 08/21] staging: android: ion: Remove crufty cache support

2017-03-17 Thread Laura Abbott
Now that we call dma_map in the dma_buf API callbacks there is no need to use the existing cache APIs. Remove the sync ioctl and the existing bad dma_sync calls. Explicit caching can be handled with the dma_buf sync API. Signed-off-by: Laura Abbott ---

[RFC PATCHv2 16/21] staging: android: ion: Get rid of ion_phys_addr_t

2017-03-17 Thread Laura Abbott
Once upon a time, phys_addr_t was not everywhere in the kernel. These days it is used enough places that having a separate Ion type doesn't make sense. Remove the extra type and just use phys_addr_t directly. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion.h

[RFC PATCHv2 15/21] staging: android: ion: Break the ABI in the name of forward progress

2017-03-17 Thread Laura Abbott
To: Sumit Semwal To: Riley Andrews Cc: rom...@google.com To: a...@android.com To: Riley Andrews Cc: de...@driverdev.osuosl.org Cc: linux-ker...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org Cc: Greg Kroah-Hartman

[RFC PATCHv2 07/21] staging: android: ion: Remove page faulting support

2017-03-17 Thread Laura Abbott
The new method of syncing with dma_map means that the page faulting sync implementation is no longer applicable. Remove it. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion.c | 117 -- 1 file changed, 117 deletions(-) diff

[RFC PATCHv2 12/21] staging: android: ion: Remove old platform support

2017-03-17 Thread Laura Abbott
Device specific platform support has been haphazard for Ion. There have been several independent attempts and there are still objections to what bindings exist right now. Just remove everything for a fresh start. Signed-off-by: Laura Abbott ---

[RFC PATCHv2 14/21] staging: android: ion: Stop butchering the DMA address

2017-03-17 Thread Laura Abbott
Now that we have proper caching, stop setting the DMA address manually. It should be set after properly calling dma_map. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git

[RFC PATCHv2 13/21] staging: android: ion: Use CMA APIs directly

2017-03-17 Thread Laura Abbott
When CMA was first introduced, its primary use was for DMA allocation and the only way to get CMA memory was to call dma_alloc_coherent. This put Ion in an awkward position since there was no device structure readily available and setting one up messed up the coherency model. These days, CMA can

[RFC PATCHv2 09/21] staging: android: ion: Remove custom ioctl interface

2017-03-17 Thread Laura Abbott
Ion is now moving towards a unified interfact. This makes the custom ioctl interface unneeded. Remove it. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/compat_ion.c | 40 drivers/staging/android/ion/ion-ioctl.c | 11 -

[RFC PATCHv2 06/21] staging: android: ion: Call dma_map_sg for syncing and mapping

2017-03-17 Thread Laura Abbott
Technically, calling dma_buf_map_attachment should return a buffer properly dma_mapped. Add calls to dma_map_sg to begin_cpu_access to ensure this happens. As a side effect, this lets Ion buffers take advantage of the dma_buf sync ioctls. Signed-off-by: Laura Abbott ---

[RFC PATCHv2 05/21] staging: android: ion: Duplicate sg_table

2017-03-17 Thread Laura Abbott
Ion currently returns a single sg_table on each dma_map call. This is incorrect for later usage. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git

[RFC PATCHv2 03/21] staging: android: ion: Remove dmap_cnt

2017-03-17 Thread Laura Abbott
The reference counting of dma_map calls was removed. Remove the associated counter field as well. Signed-off-by: Laura Abbott --- drivers/staging/android/ion/ion_priv.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_priv.h

[RFC PATCHv2 01/21] cma: Store a name in the cma structure

2017-03-17 Thread Laura Abbott
Frameworks that may want to enumerate CMA heaps (e.g. Ion) will find it useful to have an explicit name attached to each region. Store the name in each CMA structure. Signed-off-by: Laura Abbott --- drivers/base/dma-contiguous.c | 5 +++-- include/linux/cma.h |

[RFC PATCHv2 04/21] staging: android: ion: Remove alignment from allocation field

2017-03-17 Thread Laura Abbott
The align field was supposed to be used to specify the alignment of the allocation. Nobody actually does anything with it except to check if the alignment specified is out of bounds. Since this has no effect on the actual allocation, just remove it. Signed-off-by: Laura Abbott

[RFC PATCHv2 02/21] cma: Introduce cma_for_each_area

2017-03-17 Thread Laura Abbott
Frameworks (e.g. Ion) may want to iterate over each possible CMA area to allow for enumeration. Introduce a function to allow a callback. Signed-off-by: Laura Abbott --- include/linux/cma.h | 2 ++ mm/cma.c| 14 ++ 2 files changed, 16 insertions(+)

[RFC PATCHv2 00/21] Ion clean in preparation for moving out of staging

2017-03-17 Thread Laura Abbott
Hi, This is v2 of the series to do some serious Ion clean up in preparation for moving out of staging. I got good feedback last time so this series mostly attempts to address that feedback and do more still more cleanup. Highlights: - All calls to DMA APIs should now be with a real actual

Re: [PATCH 0/6] staging: BCM2835 MMAL V4L2 camera driver

2017-03-17 Thread Eric Anholt
Mauro Carvalho Chehab writes: > Em Wed, 15 Mar 2017 18:46:24 -0700 > Michael Zoran escreveu: > >> On Wed, 2017-03-15 at 22:08 -0300, Mauro Carvalho Chehab wrote: >> >> > No, I didn't. Thanks! Applied it but, unfortunately, didn't work. >> >

[PATCH] vmbus: fix missed ring events on boot

2017-03-17 Thread Stephen Hemminger
During initialization, the channel initialization code schedules the tasklet to scan the VMBUS receive event page (i.e. simulates an interrupt). The problem was that it invokes the tasklet on a different CPU from where it normally runs and therefore if an event is present, it will clear the bit

Re: [PATCH] vmbus: remove hv_event_tasklet_disable/enable

2017-03-17 Thread Stephen Hemminger
On Thu, 2 Mar 2017 12:32:55 + Dexuan Cui wrote: > With the recent introduction of per-channel tasklet, we need to update > the way we handle the 3 concurrency issues: > > 1. hv_process_channel_removal -> percpu_channel_deq vs. >vmbus_chan_sched ->

[PATCH 5/5] staging: bcm2835-camera: Remove 2 completed issues from TODO list

2017-03-17 Thread Michael Zoran
The TODO list has port the camera to ARM64. That's done. The list also mentions the error where the camera module won't load if the camera isn't connected yet. vchiq already has a mechanism to deal with calling back into consumer when vchiq connects, so instead of adding more code hook into

[PATCH 1/5] bcm2835-camera: Correct port_parameter_get return value

2017-03-17 Thread Michael Zoran
From: Dave Stevenson The API for port_parameter_get() requires that the filled length is returned, or if insufficient space that the required space is returned. Signed-off-by: Dave Stevenson Changed path: From:

[PATCH 4/5] staging: bcm2835-camera: Fix TODO issue #4 where camera doesn't start if vchiq isn't connected.

2017-03-17 Thread Michael Zoran
The camera currently doesn't start if vchiq hasn't connected yet. Vchiq does have a mechanism to receive a callback when vchiq is connected. So instead of connecting to the camera immedialy, wait for the callback. This fixed TODO issue #4 Signed-off-by: Michael Zoran ---

[PATCH 2/5] staging: bcm2835-camera: Fix integer underrun in port_parameter_get

2017-03-17 Thread Michael Zoran
Fix port_paremeter_get function blindly subtracts 8 from a reply size without checking that the size is at lest 8 bytes. This can casue a large buffer to be copied since the size is unsigned. Add a WARN_ON, and also add min and max conditions to the size of the data that is copied.

[PATCH 3/5] staging: vchiq_arm: Add vchiq_remove_connected_callback

2017-03-17 Thread Michael Zoran
The connected callback mechanism of vchiq is missing the ability to remove a connected callback, such as when a module unloads. So add the vchiq_remove_connected_callback to support unloading modules that hook into vchiq. Signed-off-by: Michael Zoran ---

[PATCH 0/5] staging: vc04_services: camera driver maintance

2017-03-17 Thread Michael Zoran
This series imports a improved version of the port_paramter_get function for the camera from the github tree. The patch does not pass checkpatch.pl but I thought it's better the change gets in. I improved upon that patch by fixing a possible integer underrun. I finished the TODO item of the

[PATCH] Staging: atomisp: fix an uninitialized variable bug

2017-03-17 Thread Dan Carpenter
There are some error paths in atomisp_css_frame_allocate() which don't initialize "res" so it could lead us to try release random memory. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Dan Carpenter diff --git

[PATCH] Staging: atomisp: fix locking in alloc_user_pages()

2017-03-17 Thread Dan Carpenter
We call this function with the lock held and should also return with the lock held as well. This one error path is not-consistent because we should return without the lock held. Signed-off-by: Dan Carpenter diff --git

[PATCH v3] Staging: most: use __func__ instead of the function name

2017-03-17 Thread Chandra Annamaneni
Change video.c to use %s, __func__ instead of function names. Warnings flagged by checkpatch.pl Signed-off-by: Chandra Annamaneni diff --git a/drivers/staging/most/aim-v4l2/video.c b/drivers/staging/most/aim-v4l2/video.c index e074841..59e861e 100644 ---

Re: [RFC PATCH 08/12] cma: Store a name in the cma structure

2017-03-17 Thread Laura Abbott
On 03/10/2017 12:53 AM, Sumit Semwal wrote: > Hi Laura, > > Thanks for the patch. > > On 3 March 2017 at 03:14, Laura Abbott wrote: >> >> Frameworks that may want to enumerate CMA heaps (e.g. Ion) will find it >> useful to have an explicit name attached to each region. Store

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-17 Thread Mauro Carvalho Chehab
Em Fri, 17 Mar 2017 12:16:08 + Russell King - ARM Linux escreveu: > On Fri, Mar 17, 2017 at 01:02:07PM +0100, Philipp Zabel wrote: > > I think most of the simple, fixed pipeline use cases could be handled by > > libv4l2, by allowing to pass a v4l2 subdevice path to

Re: [PATCH 0/6] staging: bcm2835-firmware-gpio: Initial staging commit

2017-03-17 Thread Michael Zoran
On Fri, 2017-03-17 at 18:24 +0100, Stefan Wahren wrote: > Hi Michael, > > > Michael Zoran hat am 17. März 2017 um 17:48 > > geschrieben: > > > > > > On Fri, 2017-03-17 at 17:31 +0100, Stefan Wahren wrote: > > > Hi Michael, > > > > > > > > > Am 17.03.2017 um 16:22 schrieb

Re: [PATCH 0/6] staging: bcm2835-firmware-gpio: Initial staging commit

2017-03-17 Thread Stefan Wahren
Hi Michael, > Michael Zoran hat am 17. März 2017 um 17:48 geschrieben: > > > On Fri, 2017-03-17 at 17:31 +0100, Stefan Wahren wrote: > > Hi Michael, > > > > > > Am 17.03.2017 um 16:22 schrieb Michael Zoran: > > > The firmware now has a mailbox API for performing

Re: outreachy

2017-03-17 Thread Julia Lawall
On Fri, 17 Mar 2017, Pavel Machek wrote: > Hi! > > > > > Hah! That's the joy of being a maintainer of a driver in staging. Even > > if you filter out outreachy, you are going to get a lot of "basic > > mistakes" and other type patches cc:ed to you. > > > > I strongly suggest, that if you all

Re: [PATCH 0/6] staging: bcm2835-firmware-gpio: Initial staging commit

2017-03-17 Thread Michael Zoran
On Fri, 2017-03-17 at 17:31 +0100, Stefan Wahren wrote: > Hi Michael, > > > Am 17.03.2017 um 16:22 schrieb Michael Zoran: > > The firmware now has a mailbox API for performing generalized gpio > > through > > the firmware.  This driver builds upon a driver written by Dave > > Stevenson > > that

Re: [PATCH 0/6] staging: bcm2835-firmware-gpio: Initial staging commit

2017-03-17 Thread Stefan Wahren
Hi Michael, Am 17.03.2017 um 16:22 schrieb Michael Zoran: The firmware now has a mailbox API for performing generalized gpio through the firmware. This driver builds upon a driver written by Dave Stevenson that was written specifically for the expander on the RPI 3, but I have generalized for

Re: [PATCH] HV: properly delay KVP packets when negotiation is in progress

2017-03-17 Thread Vitaly Kuznetsov
Long Li writes: > The host may send multiple KVP packets before the negotiation with daemon > is finished. We need to keep those packets in ring buffer until the daemon > is negotiated and connected. The patch looks OK but previously we always presumed that this can't

[PATCH 23/36] staging: unisys: include: remove irrelevant comments

2017-03-17 Thread David Kershner
From: Jon Frisch This patch removes comments that are no longer relevant in channel.h. Signed-off-by: Jon Frisch Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH 03/36] staging: unisys: visorbus: removed unused structure pci_id

2017-03-17 Thread David Kershner
From: Sameer Wadgaonkar Removed unused structure pci_id from controlvmchannel.h Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH 11/36] staging: unisys: include: Remove unused visorchannel #defines

2017-03-17 Thread David Kershner
From: David Binder Removes unused #defines pertaining to visorchannel UUIDs. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH 14/36] staging: unisys: include: Change out-of-date references

2017-03-17 Thread David Kershner
From: David Binder Replace references to virtpci to visornic in iochannel.h. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH 30/36] staging: unisys: visorbus: vbuschannel.h: Fix #define formatting

2017-03-17 Thread David Kershner
From: David Binder In an effort to create a more uniform coding style within the Unisys s-Par driver set, this patch adjusts the formatting of all #define directives within this source file to match the following template, and thereby eliminate irregular usage of

[PATCH 15/36] staging: unisys: visornic: Move function to appropriate location

2017-03-17 Thread David Kershner
From: David Binder Move function add_physinfo_entries() to visornic_main.c, which is the only function where it is used. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH 35/36] staging: unisys: include: visorbus.h: Fix #define formatting

2017-03-17 Thread David Kershner
From: David Binder In an effort to create a more uniform coding style within the Unisys s-Par driver set, this patch adjusts the formatting of all #define directives within this source file to match the following template, and thereby eliminate irregular usage of

[PATCH 32/36] staging: unisys: visorinput: visorinput.c: Fix #define formatting

2017-03-17 Thread David Kershner
From: David Binder In an effort to create a more uniform coding style within the Unisys s-Par driver set, this patch adjusts the formatting of all #define directives within this source file to match the following template, and thereby eliminate irregular usage of

[PATCH 36/36] staging: unisys: include: channel.h: Fix #define formatting

2017-03-17 Thread David Kershner
From: David Binder In an effort to create a more uniform coding style within the Unisys s-Par driver set, this patch adjusts the formatting of all #define directives within this source file to match the following template, and thereby eliminate irregular usage of

[PATCH 34/36] staging: unisys: include: iochannel.h: Fix #define formatting

2017-03-17 Thread David Kershner
From: David Binder In an effort to create a more uniform coding style within the Unisys s-Par driver set, this patch adjusts the formatting of all #define directives within this source file to match the following template, and thereby eliminate irregular usage of

[PATCH 31/36] staging: unisys: visorbus: vmcallinterface.h: Fix #define formatting

2017-03-17 Thread David Kershner
From: David Binder In an effort to create a more uniform coding style within the Unisys s-Par driver set, this patch adjusts the formatting of all #define directives within this source file to match the following template, and thereby eliminate irregular usage of

[PATCH 21/36] staging: unisys: include: remove macro lengthof

2017-03-17 Thread David Kershner
From: Jon Frisch This patch removes the unused macro lengthof. Signed-off-by: Jon Frisch Signed-off-by: David Kershner Reviewed-by: Tim Sell --- drivers/staging/unisys/include/channel.h | 3 ---

[PATCH 24/36] staging: unisys: visornic: remove inline functions

2017-03-17 Thread David Kershner
From: Jon Frisch This patch removes inline functions in visornic_main.c. Signed-off-by: Jon Frisch Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH 33/36] staging: unisys: visorhba: visorhba_main.c: Fix #define formatting

2017-03-17 Thread David Kershner
From: David Binder In an effort to create a more uniform coding style within the Unisys s-Par driver set, this patch adjusts the formatting of all #define directives within this source file to match the following template, and thereby eliminate irregular usage of

[PATCH 25/36] staging: unisys: visorbus: remove #pragma directive

2017-03-17 Thread David Kershner
From: Jon Frisch This patch removes the #pragma directive from visorchannel.h and adds the __packed keyword to all structs to suppress structure padding. Signed-off-by: Jon Frisch Signed-off-by: David Kershner

[PATCH 19/36] staging: unisys: include: simplify spar_check_channel_client

2017-03-17 Thread David Kershner
The function spar_check_channel_client shouldn't need to do readq's, it is referencing a local copy of the channel header. Simplify it to just access the fields directly. Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH 13/36] staging: unisys: visorbus: Rename #define VMCALL_IO_CONTROLVM_ADDR

2017-03-17 Thread David Kershner
From: David Binder Rename #define VMCALL_IO_CONTROLVM_ADDR to VMCALL_CONTROLVM_ADDR, as this vmcall can be used by any partition, not just the IO partition. Signed-off-by: David Binder Signed-off-by: David Kershner

[PATCH 29/36] staging: unisys: visorbus: visorchipset.c: Fix #define formatting

2017-03-17 Thread David Kershner
From: David Binder In an effort to create a more uniform coding style within the Unisys s-Par driver set, this patch adjusts the formatting of all #define directives within this source file to match the following template, and thereby eliminate irregular usage of

[PATCH 27/36] staging: unisys: visorbus: visorbus_main.c: Fix #define formatting

2017-03-17 Thread David Kershner
From: David Binder In an effort to create a more uniform coding style within the Unisys s-Par driver set, this patch adjusts the formatting of all #define directives within this source file to match the following template, and thereby eliminate irregular usage of

[PATCH 12/36] staging: unisys: visorbus: Remove useless checks in visorbus_main.c

2017-03-17 Thread David Kershner
From: David Binder Removes checks that all visor_device instances have an associated visorchannel. Due to the design of the s-Par drivers these checks are unnecessary. Signed-off-by: David Binder Signed-off-by: David Kershner

[PATCH 28/36] staging: unisys: visorbus: controlvmchannel.h: Fix #define formatting

2017-03-17 Thread David Kershner
From: David Binder In an effort to create a more uniform coding style within the Unisys s-Par driver set, this patch adjusts the formatting of all #define directives within this source file to match the following template, and thereby eliminate irregular usage of

[PATCH 22/36] staging: unisys: include: removed unused function declarations

2017-03-17 Thread David Kershner
From: Jon Frisch This patch removes the unused function declarations in channel.h. Signed-off-by: Jon Frisch Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH 26/36] staging: unisys: visorbus: visorchannel.c: Fix #define formatting

2017-03-17 Thread David Kershner
From: David Binder In an effort to create a more uniform coding style within the Unisys s-Par driver set, this patch adjusts the formatting of all #define directives within this source file to match the following template, and thereby eliminate irregular usage of

[PATCH 16/36] staging: unisys: visorbus: Rename what vmcallinterface.h #define

2017-03-17 Thread David Kershner
From: David Binder Renames __IOMONINTF_H__ to __VMCALLINTERFACE_H__, which more closely reflects the naming conventions of the code. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH 10/36] staging: unisys: include: Wrap macro argument in parenthesis

2017-03-17 Thread David Kershner
From: David Binder Addresses checkpatch check by wrapping macro argument in parenthesis. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH 20/36] staging: unisys: visorbus: Remove pointer cast that causes sparse warning

2017-03-17 Thread David Kershner
From: David Binder Removes unnecessary cast of to __iomem of a non-io-mapped pointer, thereby eliminating the following sparse warning: visorchannel.c:159:17: warning: cast adds address space to expression () Signed-off-by: David Binder

[PATCH 18/36] staging: unisys: include: Add function definition argument identifier

2017-03-17 Thread David Kershner
From: David Binder Adds identifier to function definition arguments to satisfy checkpatch warnings: WARNING: function definition argument 'struct visor_driver *' should also have an identifier name WARNING: function definition argument 'struct visor_driver *'

[PATCH 09/36] staging: unisys: visorbus: remove inline keyword in visorchannel.c

2017-03-17 Thread David Kershner
From: Sameer Wadgaonkar Removed inline keyword from functions sig_read_data and sig_write_data in visorchannel.c Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH 07/36] staging: unisys: visorhba: remove inline keyword

2017-03-17 Thread David Kershner
From: Sameer Wadgaonkar Removed inline keyword from the function complete_taskmgmt_command in visorhba_main.c Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH 05/36] staging: unisys: include: remove unused macro spar_signal_init

2017-03-17 Thread David Kershner
From: Sameer Wadgaonkar Removed unused macro spar_signal_init from channel.h Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH 02/36] staging: unisys: visorbus_main: removed revference to virtpci

2017-03-17 Thread David Kershner
From: Alexander Curtin The comment referencing virtpci was irrelevant. Signed-off-by: Alexander Curtin Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH 17/36] staging: unisys: visorinput: Remove unnecessary usage of local variable

2017-03-17 Thread David Kershner
From: David Binder Remove local variable on stack by directly returning the value in the array. Signed-off-by: David Binder Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH 04/36] staging: unisys: include: remove unused function spar_check_channel_server

2017-03-17 Thread David Kershner
From: Sameer Wadgaonkar Removed unused function spar_check_channel_server from channel.h Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell ---

[PATCH 08/36] staging: unisys: visorbus: remove inline keyword from visorchipset

2017-03-17 Thread David Kershner
From: Sameer Wadgaonkar Removed inline keyword from the functions in visorchipset: * issue_vmcall_io_controlvm_addr() Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH 00/36] staging: unisys: additional code cleanups

2017-03-17 Thread David Kershner
This series cleans up several different checkpatch, sparse and other miscellaneous code issues found throughout the Unisys s-Par driver stack. It also cleans up the comments surrounding #defines. Note: Acceptence of this patch series determines whether or not the team will partake in a soft,

[PATCH 01/36] staging: unisys: include: replaced COVERQ with DIV_ROUND_UP

2017-03-17 Thread David Kershner
From: Alexander Curtin COVERQ is functionally equivalent to DIV_ROUND_UP and was only used to define the COVER macro. Signed-off-by: Alexander Curtin Signed-off-by: David Kershner Reviewed-by: Tim Sell

[PATCH 06/36] staging: unisys: visorbus: remove unused functions in visorchipset

2017-03-17 Thread David Kershner
From: Sameer Wadgaonkar Removed unused functions issue_vmcall_update_physical_time() and issue_vmcall_query_guest_virtual_time_offset() from visorchipset.c Signed-off-by: Sameer Wadgaonkar Signed-off-by: David Kershner

Re: outreachy

2017-03-17 Thread Pavel Machek
Hi! > > Hah! That's the joy of being a maintainer of a driver in staging. Even > if you filter out outreachy, you are going to get a lot of "basic > mistakes" and other type patches cc:ed to you. > > I strongly suggest, that if you all don't like this type of stuff, > either: > - work

[PATCH 3/6] staging: bcm2835-firmware-gpio: Expand DT options for driver

2017-03-17 Thread Michael Zoran
This change adds the following optional DT properties: number-gpios: Number of GPIOs the device should expose gpio-base: GPIO base that is registered with the kernel firmware-gpio-base: GPIO bases as viewed by the firmware The purpose of these DT nodes is to make the driver more general.

[PATCH 5/6] staging: bcm2835-firmware-gpio: Add a build system for the driver

2017-03-17 Thread Michael Zoran
This change adds the driver to the standard kernel build system. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/Kconfig| 2 ++ drivers/staging/vc04_services/Makefile | 1 +

[PATCH 6/6] staging: vc04_services: Update makefile to use CONFIG_BCM_VIDEOCORE

2017-03-17 Thread Michael Zoran
The toplevel config for vc04_services is CONFIG_BCM2835_VCHIQ. Since other drivers are being added that don't use vchiq, change the toplevel Makefile to use CONFIG_BCM_VIDEOCORE. Signed-off-by: Michael Zoran --- drivers/staging/Makefile | 2 +- 1 file changed, 1

[PATCH 4/6] staging: bcm2835-firmware-gpio: Add brcm, bcm2835-firmware-gpio to compatible list

2017-03-17 Thread Michael Zoran
Since this driver is really a generalized mechanism for doing GPIO through the firmware, add a new compatible id for brcm,bcm2835-firmware-gpio. Signed-off-by: Michael Zoran --- drivers/staging/vc04_services/bcm2835-firmware-gpio/gpio-bcm-exp.c | 1 + 1 file changed, 1

[PATCH 2/6] staging: bcm2835-firmware-gpio: Add needed mailbox defines to driver

2017-03-17 Thread Michael Zoran
The original change this driver is based on adds the needed mailbox defines to include/soc/bcm2835/raspberrypi-firmware.h. That is not appropriate at this time, so add the defines directly into the driver source. This change is based on: https://github.com/raspberrypi/linux Branch:

[PATCH 1/6] bcm2835-gpio-exp: Driver for GPIO expander via mailbox service

2017-03-17 Thread Michael Zoran
From: Dave Stevenson Pi3 and Compute Module 3 have a GPIO expander that the VPU communicates with. There is a mailbox service that now allows control of this expander, so add a kernel driver that can make use of it. Pwr_led node added to device-tree for Pi3.

[PATCH 0/6] staging: bcm2835-firmware-gpio: Initial staging commit

2017-03-17 Thread Michael Zoran
The firmware now has a mailbox API for performing generalized gpio through the firmware. This driver builds upon a driver written by Dave Stevenson that was written specifically for the expander on the RPI 3, but I have generalized for generic GPIO through the firmware. With this change I was

[PATCH v2] scsi: storvsc: Add support for FC rport.

2017-03-17 Thread Cathy Avery
Included in the current storvsc driver for Hyper-V is the ability to access luns on an FC fabric via a virtualized fiber channel adapter exposed by the Hyper-V host. The driver also attaches to the FC transport to allow host and port names to be published under /sys/class/fc_host/hostX. Current

Re: [RFC PATCH v2 08/32] x86: Use PAGE_KERNEL protection for ioremap of memory page

2017-03-17 Thread Tom Lendacky
On 3/17/2017 9:32 AM, Tom Lendacky wrote: On 3/16/2017 3:04 PM, Tom Lendacky wrote: On 3/7/2017 8:59 AM, Borislav Petkov wrote: On Thu, Mar 02, 2017 at 10:13:32AM -0500, Brijesh Singh wrote: From: Tom Lendacky In order for memory pages to be properly mapped when SEV

Re: [RFC PATCH v2 14/32] x86: mm: Provide support to use memblock when spliting large pages

2017-03-17 Thread Paolo Bonzini
On 17/03/2017 12:33, Borislav Petkov wrote: > On Fri, Mar 17, 2017 at 12:03:31PM +0100, Paolo Bonzini wrote: > >> If it is possible to do it in a fairly hypervisor-independent manner, >> I'm all for it. That is, only by looking at AMD-specified CPUID leaves >> and at kernel ELF sections. > >

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-17 Thread Russell King - ARM Linux
On Fri, Mar 17, 2017 at 02:51:10PM +0100, Philipp Zabel wrote: > On Fri, 2017-03-17 at 10:24 -0300, Mauro Carvalho Chehab wrote: > [...] > > The big question, waiting for an answer on the last 8 years is > > who would do that? Such person would need to have several different > > hardware from

Re: [RFC PATCH v2 08/32] x86: Use PAGE_KERNEL protection for ioremap of memory page

2017-03-17 Thread Tom Lendacky
On 3/16/2017 3:04 PM, Tom Lendacky wrote: On 3/7/2017 8:59 AM, Borislav Petkov wrote: On Thu, Mar 02, 2017 at 10:13:32AM -0500, Brijesh Singh wrote: From: Tom Lendacky In order for memory pages to be properly mapped when SEV is active, we need to use the PAGE_KERNEL

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-17 Thread Philipp Zabel
On Fri, 2017-03-17 at 10:24 -0300, Mauro Carvalho Chehab wrote: [...] > The big question, waiting for an answer on the last 8 years is > who would do that? Such person would need to have several different > hardware from different vendors, in order to ensure that it has > a generic solution. > >

Re: [PATCH] Fix style warnings in drivers/staging/most/aim-v4l2

2017-03-17 Thread Dan Carpenter
Fix the patch prefix. It should be: [PATCH v2] Staging: most: use __func__ instead of the function name On Fri, Mar 17, 2017 at 06:36:18AM -0700, Chandra Annamaneni wrote: > > > Enclosed is a patch to the file video.c. It only fixes style warning > flagged by checkpatch.pl. > > Please let me

[PATCH] Fix style warnings in drivers/staging/most/aim-v4l2

2017-03-17 Thread Chandra Annamaneni
Enclosed is a patch to the file video.c. It only fixes style warning flagged by checkpatch.pl. Please let me know if anything else needs to be done. Signed-off-by: Chandra Annamaneni Thanks. Chandra diff --git a/drivers/staging/most/aim-v4l2/video.c

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-17 Thread Mauro Carvalho Chehab
Em Fri, 17 Mar 2017 13:55:33 +0200 Sakari Ailus escreveu: > Hi Russell, > > On 03/17/17 13:42, Russell King - ARM Linux wrote: > > On Tue, Mar 14, 2017 at 08:55:36AM +0100, Hans Verkuil wrote: > >> We're all very driver-development-driven, and userspace gets very

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-17 Thread Russell King - ARM Linux
On Fri, Mar 17, 2017 at 01:02:07PM +0100, Philipp Zabel wrote: > I think most of the simple, fixed pipeline use cases could be handled by > libv4l2, by allowing to pass a v4l2 subdevice path to v4l2_open. If that > function internally would set up the media links to the > nearest /dev/video

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-17 Thread Philipp Zabel
On Fri, 2017-03-17 at 11:42 +, Russell King - ARM Linux wrote: > On Tue, Mar 14, 2017 at 08:55:36AM +0100, Hans Verkuil wrote: > > We're all very driver-development-driven, and userspace gets very little > > attention in general. So before just throwing in the towel we should take > > a good

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-17 Thread Sakari Ailus
Hi Russell, On 03/17/17 13:42, Russell King - ARM Linux wrote: > On Tue, Mar 14, 2017 at 08:55:36AM +0100, Hans Verkuil wrote: >> We're all very driver-development-driven, and userspace gets very little >> attention in general. So before just throwing in the towel we should take >> a good look at

Re: [PATCH v4 14/36] [media] v4l2-mc: add a function to inherit controls from a pipeline

2017-03-17 Thread Russell King - ARM Linux
On Tue, Mar 14, 2017 at 08:55:36AM +0100, Hans Verkuil wrote: > We're all very driver-development-driven, and userspace gets very little > attention in general. So before just throwing in the towel we should take > a good look at the reasons why there has been little or no development: is > it

  1   2   >