>From c840c64e0e662eee04b7d0403040be81eaa34c25 Mon Sep 17 00:00:00 2001
From: Haim Daniel
Date: Wed, 29 Mar 2017 08:43:46 +0300
Subject: [PATCH] staging: vc04_services: add parenthesis to macros
vchi_cfg.h:
fix checkpatch ERROR: Macros with complex values should be
>From 41d35b455f8eb139912909639e914469ef5e06fb Mon Sep 17 00:00:00 2001
From: Haim Daniel
Date: Tue, 28 Mar 2017 19:27:57 +0300
Subject: [PATCH] [media] staging: css2400: fix checkpatch error
isp_capture_defs.h:
enclose macro with complex values in parentheses.
Use managed resource functions devm_request_irq instead of request_irq.
Remove corresponding calls to free_irq in the probe.
Signed-off-by: Arushi Singhal
---
drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 7 +++
1 file changed, 3 insertions(+), 4
On Mar 27, 2017, at 23:40, Skanda Guruanand wrote:
>
> I have tried to fix the endian issues in the mdc_request.c in the
> lustre file system drivers in the staging area. Your feedback is
> welcome.
Sorry, but this patch is totally wrong. This would break the handling
On 03/28/2017 11:56 PM, Alfonso Lima Astor wrote:
Fix coding style issue
Signed-off-by: Alfonso Lima Astor
---
drivers/staging/rtl8188eu/include/rtw_ioctl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Corrected all comments.
Thanks,
Vaibhav
On Tuesday 28 March 2017 10:53 AM, Greg KH wrote:
On Tue, Mar 28, 2017 at 10:44:44AM +0530, vaibhavd...@gmail.com wrote:
gc2235.c
Why is this file name here?
Removed extra space before comma in memset() as a part of
checkpatch.pl fix-up.
Why
From: Vaibhav Kothari
Removed extra space before comma in memset() as a part of
checkpatch.pl fix-up.
Signed-off-by: Vaibhav Kothari
---
drivers/staging/media/atomisp/i2c/gc2235.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Dan Cashman
Remove two ' , ' issues and change spaces to tabs found by poking around in
drivers/staging/. Warnings left untouched.
Test: Run checkpatch script in drivers/staging/media/atomisp/i2c before and
after change. Errors go from 3 to 0.
Signed-off-by: Dan
On Mar 28, 2017, at 6:10 AM,
wrote:
> From: Vaibhav Kothari
>
> Shifted open brace { to previous line for 8 functions as indicated by
> checkpatch.pl
>
> Signed-off-by: Vaibhav Kothari
> ---
>
head_up parameter is marked with __user attribute, tmp is filled
by a copy_from_user from next, that is also marked as __user, so
tmp.next needs to be "casted" as __user to make sparse happy.
Signed-off-by: Marcos Paulo de Souza
---
this is mt first patch addressing
On 03/28/2017 05:21 PM, Rob Herring wrote:
On Mon, Mar 27, 2017 at 7:40 PM, Steve Longerbeam wrote:
Add bindings documentation for the i.MX media driver.
+
+mipi_csi2 node
+--
+
+This is the device node for the MIPI CSI-2 Receiver, required for MIPI
On Mon, Mar 27, 2017 at 7:40 PM, Steve Longerbeam wrote:
> Add bindings documentation for the i.MX media driver.
>
> Signed-off-by: Steve Longerbeam
> ---
> Documentation/devicetree/bindings/media/imx.txt | 74
> +
> 1
From: K. Y. Srinivasan
When auto EOI is not enabled; issue an explicit EOI for hyper-v
interrupts.
Fixes: 6c248aad81c8 ("Drivers: hv: Base autoeoi enablement based on hypervisor
hints")
Signed-off-by: K. Y. Srinivasan
---
On Tue, Mar 28, 2017 at 09:56:19PM +0100, Alfonso Lima Astor wrote:
> Fix coding style issue
>
> Signed-off-by: Alfonso Lima Astor
> ---
Hi Alfonso,
You don't need to put 1/1 in the subject of a single patch. You may
like to limit your git log summary to 50
Fix coding style issue
Signed-off-by: Alfonso Lima Astor
---
drivers/staging/rtl8188eu/include/rtw_ioctl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_ioctl.h
On Tue, Mar 28, 2017 at 10:10 PM, kbuild test robot <l...@intel.com> wrote:
> Hi Arnd,
>
> [auto build test ERROR on staging/staging-testing]
> [also build test ERROR on next-20170328]
> [cannot apply to linuxtv-media/master v4.11-rc4]
> [if your patch is applied to the wro
Hi Arnd,
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on next-20170328]
[cannot apply to linuxtv-media/master v4.11-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux
On Thu, Mar 02, 2017 at 10:15:36AM -0500, Brijesh Singh wrote:
> Some KVM specific MSR's (steal-time, asyncpf, avic_eio) allocates per-CPU
> variable at compile time and share its physical address with hypervisor.
> It presents a challege when SEV is active in guest OS. When SEV is active,
> guest
On Tue, Mar 28, 2017 at 10:55:17PM +0530, SIMRAN SINGHAL wrote:
> On Fri, Mar 24, 2017 at 12:51 AM, Alison Schofield
> wrote:
> > On Fri, Mar 24, 2017 at 12:05:20AM +0530, simran singhal wrote:
> >> The IIO subsystem is redefining iio_dev->mlock to be used by
> >> the IIO
The IIO subsystem is redefining iio_dev->mlock to be used by
the IIO core only for protecting device operating mode changes.
ie. Changes between INDIO_DIRECT_MODE, INDIO_BUFFER_* modes.
In this driver, mlock was being used to protect hardware state
changes. Replace it with a buf_lock in the
On Fri, Mar 24, 2017 at 12:51 AM, Alison Schofield wrote:
> On Fri, Mar 24, 2017 at 12:05:20AM +0530, simran singhal wrote:
>> The IIO subsystem is redefining iio_dev->mlock to be used by
>> the IIO core only for protecting device operating mode changes.
>> ie. Changes
Simplify function returns by merging assignment and return.
Signed-off-by: Arushi Singhal
---
changes in v2
*correct the error.
drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c | 8 ++--
I decided not to send it to stable since problem was only observed on 4.11 but
it is probably endemic to all GEN2 VM's
-Original Message-
From: Joseph Salisbury [mailto:joseph.salisb...@canonical.com]
Sent: Tuesday, March 28, 2017 7:29 AM
To: Stephen Hemminger ;
On 03/27/2017 06:14 PM, Stephen Hemminger wrote:
> Are you sure the real problem is not the one fixed by this commit?
>
> commit f1c635b439a5c01776fe3a25b1e2dc546ea82e6f
> Author: Stephen Hemminger
> Date: Tue Mar 7 09:15:53 2017 -0800
>
> scsi: storvsc:
Hi Steve,
On 03/28/2017 03:40 AM, Steve Longerbeam wrote:
> From: Philipp Zabel
>
> This driver can handle SoC internal and external video bus multiplexers,
> controlled either by register bit fields or by a GPIO. The subdevice
> passes through frame interval and mbus
Clean up the function to remove some if statments that should be done
in the calling function.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 74 +++---
1
Remove braces around single line if statements, they are not needed.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 4 ++--
1 file changed, 2 insertions(+), 2
Don't just drop the error from visorchannel_read on the floor, report it.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 14 +-
1 file changed, 9
Add error handling to visorbus_enable_channel_interrupt.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/visorbus.h | 2 +-
drivers/staging/unisys/visorbus/visorbus_main.c | 6 +++---
The function controlvm_periodic_work should handle errors appropriately.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 67 +--
1 file changed, 32
The macro ISSUE_IO_VMCALL was a wrapper around the function unisys_vmcall.
It doesn't need to exist and was just being noisy, so get rid of it.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
The ret variable was only returning an error, so changing it to err to
be more consistent across the file.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 8
1
The function unisys_vmcall was returning VMCALL specific errors and the
calling code was ignoring which error was actually returned. Instead we
should be mapping the VMCALL error into a proper Linux error and then
returning that, since we now have an error we know what to do with, we
don't have to
The comment at the beginning of the vmcallinterface.h file references IO
Virtualization. It should be more specific that it is referencing s-Par
Virtualization.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
Don't override the visorchannel_read_error, just return the
error that it generates.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 11 +++
1 file changed, 7
The function dev_set_name can return an error, don't just ignore it.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 6 --
1 file changed, 4 insertions(+), 2
If we fail to register the visordriver, don't call unregister, just
return with the error.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 7 +--
1 file changed, 1
We had several if statements inside of if statements that should be
consolidated into an if statement with an && to clean up the code some
more.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
The only one using unisys_vmcall was visorchipset.c, it can be moved into
the visorchipset file directly instead of being in a header file.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
We shouldn't be checking if VMCALL_CONTROLVM_ADDR is defined, remove it.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/vmcallinterface.h | 4
1 file changed, 4 deletions(-)
diff
If there is an error in chipset_device_pause/resume don't try to respond,
error out and let the calling functions respond to this error just like
any other error they encounter.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
The add_uevent_var returns an error. Don't overwrite the error with
-ENOMEM, just pass the error code back up.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 4 +---
1
The forcenomatch parameter was not being used, so get rid of it.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 9 -
1 file changed, 9 deletions(-)
diff --git
Create bus_type was just calling register_bustype. Since we control how
many times we call create_bus_type it was extraneous keeping a counter if
the bus was already registered, so the functions were no longer needed.
Signed-off-by: David Kershner
Reviewed-by:
The function get_vbus_header_info returns errors that were being handled
incorrectly. Fix the error handling in create_bus_instance.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
From: Sameer Wadgaonkar
Added the __packed keyword to all structures in controlvmchannel.h
to ensure alignment and size in memory.
Signed-off-by: Sameer Wadgaonkar
Signed-off-by: David Kershner
Reviewed-by:
We only have one version of spar_check_channel, get rid of the client
at the end and help save space.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/include/channel.h | 12 +--
Report errors if we have a problem in dev_start_periodic_work.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorbus_main.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Move vbuschannel_print_devinfo from vbuchannel.h to visorbus_main.c since
it is only referenced in visorbus_main.c. Since it is in a .c file, get
rid of the inline for it.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
Adds error handling to the chipset_device_create message. If it returns
a failure, it is assumed it has not signaled the s-Par firmware of the
failure and the caller must do that.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
The macro SPAR_VBUS_CHANNEL_CLIENT_OK was noisy and only used in one place
so get rid of it.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/vbuschannel.h | 8
The ret variable was only returning an error, so changing it to err to
be more consistent across the file.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 8
1
The function chipset_bus_create should return an error. If an error
is returned, it is assumed the response has not been sent by bus_create.
Correctly handle when the error has been returned in visorchipset.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim
The ret variable was only returning an error, so changing it to err to
be more consistent across the file.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 8
1
With all the code churn, bus_responder and device_responder have become
identical, consolidate them to the same function.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 50
The ret variable was only returning an error, so changing it to err to
be more consistent across the file.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 8
1
Since signalinsert/remove now return valid error codes, we need to check
them when we call them in visornic. The error codes need to propagate out
to the calling functions.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
Don't just drop the error from visorchannel_read on the floor, report it.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 11 +++
1 file changed, 7 insertions(+), 4
Don't just drop the error from visorchannel_read on the floor, report it.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 12
1 file changed, 8 insertions(+),
The ret variable was only returning an error, so changing it to err to
be more consistent across the file.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 8
1
The function bus_device_info_init was defined in visorbus_private.h. The
only file that uses it is visorbus_main.c so move the function into the .c
file instead.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
Removed a comment that was describing the relationship between the
visorchipset driver and the visorbus driver. Since they are now one
driver the comment no longer makes sense.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
Add error handling to the parahotplug_process_message function so that it
returns the proper error.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 5 +++--
1 file changed,
The function kobject_uevent_env returns an error we shouldn't just drop it
on the floor but we should report it back to the caller. Since it now
returns an error, need to add proper error handling to
parahotplug_process_message.
Signed-off-by: David Kershner
The function kobject_uevent_env can return an error, pass that error
to the caller so it can be handled correctly.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 26
Don't just drop the error from visorchannel_read on the floor, report it.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 11 ---
1 file changed, 8 insertions(+), 3
Add error handling to the function handle_command.
Since handle_command now returns errors, we need to process them correctly
in process_controlvm_event.
Note: It is invalid to have a controlvm test message in the event queue, so
return -EINVAL if one is discovered.
Signed-off-by: David
Don't just drop the error from visorchannel_read on the floor, report it.
Signed-off-by: David Kershner
Reviewed-by: Reviewed-by: Tim Sell
---
drivers/staging/unisys/visorbus/visorchipset.c | 13 +
1 file changed, 9 insertions(+),
This series primarily concentrates on adding additional error handling
so that the s-Par drivers can correctly handle the errors at a
centralized location instead of doing it inconsistently scattered
throughout the source tree.
David Kershner (43):
staging: unisys: visorbus:
Andrea della Porta writes:
> Coding style issues fixed
>
> Signed-off-by: Andrea della Porta
> ---
> .../vc04_services/bcm2835-audio/bcm2835-pcm.c | 47
> ++
> 1 file changed, 22 insertions(+), 25 deletions(-)
>
> diff --git
4.4-stable review patch. If anyone has any objections, please let me know.
--
From: Sumit Semwal
From: Vitaly Kuznetsov
[ Upstream commit 59107e2f48831daedc46973ce4988605ab066de3 ]
There is a feature in Hyper-V ('Debug-VM
Coding style issues fixed
Signed-off-by: Andrea della Porta
---
.../vc04_services/bcm2835-audio/bcm2835-pcm.c | 47 ++
1 file changed, 22 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
Coding style issue resolved.
Signed-off-by: Andrea della Porta
---
drivers/staging/iio/accel/adis16209.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/accel/adis16209.c
b/drivers/staging/iio/accel/adis16209.c
index
From: Vaibhav Kothari
Shifted open brace { to previous line for 8 functions as indicated by
checkpatch.pl
Signed-off-by: Vaibhav Kothari
---
drivers/staging/lustre/lnet/libcfs/hash.c | 43 +++
1 file changed, 15
Function contains a block of code combined as a compound
statement. This would be better factored out into a separate function.
Factor compound statement out into a separate function.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks7010_sdio.c | 46
Function is a candidate for refactoring. None of the kernel static
analysis tools warn about this function but the function has a number
of code smells. There is a block of code separated into a anonymous
compound statement, this is not usual kernel code style and can easily
be factored into a
Pick up your Western Union Funds $850,000 USD
Name...Country.. Phone Number
Mr Mike Morris
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Function ks7010_upload_firmware() has two struct pointer parameters,
one of which is a member of the other. This is unnecessary.
Remove unnecessary function parameter.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks7010_sdio.c | 7 +++
1 file changed, 3
Driver file ks7010_sdio.c contains a few function definition
anomalies. One function is defined with two parameters, one of which
is a struct member of the other. This is unnecessary.
A couple of functions with internal linkage take as input parameters
of type void *. All call sites then cast
Constant is used to allocate memory for a buffer, then buffer is
filled upto 'size' which is passed as a parameter. If 'size' is bigger
than the constant then the buffer will overflow. We could check the
'size' parameter and fail but better not to fail.
Use 'size' as the parameter to kmalloc()
80 matches
Mail list logo