Re: [PATCH] staging: most: core: add autoconf ability

2017-04-21 Thread Greg KH
On Fri, Apr 21, 2017 at 09:37:38PM +0200, Christian Gromm wrote: > On Fri, 21 Apr 2017 18:15:43 +0200 > Greg KH wrote: > > > On Fri, Apr 21, 2017 at 05:36:43PM +0200, Christian Gromm wrote: > > > > > > > > > On 04/20/2017 05:26 PM, Greg KH wrote: > > > > On Thu, Apr

[PATCH] staging: android: ion: Replace spaces with tabs for indentation

2017-04-21 Thread Melko
From: Paolo Cretaro Fix checkpatch ERRORs: code indent should use tabs where possible. Signed-off-by: Paolo Cretaro --- drivers/staging/android/ion/ion_cma_heap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH v1 8/8] ACPI: Use recently introduced uuid_le_cmp_p{p}() helpers

2017-04-21 Thread Rafael J. Wysocki
On Friday, April 21, 2017 05:46:45 PM Andy Shevchenko wrote: > Recently introduced helpers take pointers to uuid_{be|le} instead of > reference. > > Using them makes code less ugly. > > Cc: "Rafael J. Wysocki" > Signed-off-by: Andy Shevchenko

[PATCH] staging: rtl8723bs: rework debug configuration handling

2017-04-21 Thread Arnd Bergmann
I ran into this warning during randconfig testing: drivers/staging/rtl8723bs/os_dep/rtw_proc.c: In function 'rtw_adapter_proc_deinit': drivers/staging/rtl8723bs/os_dep/rtw_proc.c:738:25: error: unused variable 'drv_proc' [-Werror=unused-variable] drivers/staging/rtl8723bs/os_dep/rtw_proc.c: In

Re: [PATCH v3] Staging: most: use __func__ instead of the function name

2017-04-21 Thread Joe Perches
On Fri, 2017-04-21 at 00:40 -0700, Chandra Annamaneni wrote: > Third Reminder. Please review. Patience. > On Sun, 9 Apr 2017, chandrasekhar annamaneni wrote: > > Second reminder, please review. [] > > On Fri, Mar 17, 2017 at 12:49 PM, Chandra Annamaneni > > wrote: > > > >

Re: [PATCH] staging: most: core: add autoconf ability

2017-04-21 Thread Christian Gromm
On Fri, 21 Apr 2017 18:15:43 +0200 Greg KH wrote: > On Fri, Apr 21, 2017 at 05:36:43PM +0200, Christian Gromm wrote: > > > > > > On 04/20/2017 05:26 PM, Greg KH wrote: > > > On Thu, Apr 20, 2017 at 05:01:49PM +0200, Christian Gromm wrote: > > > > This patch extends

Re: [PATCH v3] Staging: most: use __func__ instead of the function name

2017-04-21 Thread Greg KH
On Fri, Apr 21, 2017 at 11:06:54AM -0700, Chandra Annamaneni wrote: > > Sorry about the top posting. > > I did ask about it on the 9th of April and the reply was that the email > was 'acked'. Since I did not get a further email, I assumed it was lost. > Perhaps I misunderstood. I really do not

Re: [PATCH v3] Staging: most: use __func__ instead of the function name

2017-04-21 Thread Chandra Annamaneni
Sorry about the top posting. I did ask about it on the 9th of April and the reply was that the email was 'acked'. Since I did not get a further email, I assumed it was lost. Perhaps I misunderstood. Thanks! Chandra On Fri, 21 Apr 2017, Greg KH wrote: > > Q: Why is top-posting such a bad

Re: [PATCH net-next 1/1] netvsc: Deal with rescinded channels correctly

2017-04-21 Thread David Miller
From: k...@exchange.microsoft.com Date: Wed, 19 Apr 2017 13:53:49 -0700 > From: K. Y. Srinivasan > > We will not be able to send packets over a channel that has been > rescinded. Make necessary adjustments so we can properly cleanup > even when the channel is rescinded. This

[PATCH] staging: rtl8192u: fix spelling mistake in variable name *attentuation

2017-04-21 Thread Colin King
From: Colin Ian King Fix the spelling of a bunch of variables, from *attentuation to *attenuation. No functional change. Signed-off-by: Colin Ian King --- drivers/staging/rtl8192u/r8192U.h | 8 ++---

Re: [PATCH] staging: most: core: add autoconf ability

2017-04-21 Thread Greg KH
On Fri, Apr 21, 2017 at 05:36:43PM +0200, Christian Gromm wrote: > > > On 04/20/2017 05:26 PM, Greg KH wrote: > > On Thu, Apr 20, 2017 at 05:01:49PM +0200, Christian Gromm wrote: > > > This patch extends the driver with the possibility of automatic > > > configuration. This covers channel

[PATCH 1/1] staging: fbtft: Fix Sparse warning in fb_watterott.c

2017-04-21 Thread Cezary Gapinski
Sparse reports the following in fb_watterott.c: warning: incorrect type in assignment (different base types) expected unsigned short [unsigned] [short] [usertype] got restricted __be16 [usertype] Use __be16 types for endian correctness Signed-off-by: Cezary Gapinski ---

Re: [PATCH] staging: most: core: add autoconf ability

2017-04-21 Thread Christian Gromm
On 04/20/2017 05:26 PM, Greg KH wrote: On Thu, Apr 20, 2017 at 05:01:49PM +0200, Christian Gromm wrote: This patch extends the driver with the possibility of automatic configuration. This covers channel settings and connection establishing of a MOST device interface while it is registered

Re: [PATCHv4 00/12] Ion cleanup in preparation for moving out of staging

2017-04-21 Thread Sumit Semwal
Hi Laura, Thanks much for this series! On 18 April 2017 at 23:57, Laura Abbott wrote: > Hi, > > This is v4 of the series to cleanup to Ion. Greg took some of the patches > that weren't CMA related already. There was a minor bisectability problem > with the CMA APIs so this

[PATCH v1 8/8] ACPI: Use recently introduced uuid_le_cmp_p{p}() helpers

2017-04-21 Thread Andy Shevchenko
Recently introduced helpers take pointers to uuid_{be|le} instead of reference. Using them makes code less ugly. Cc: "Rafael J. Wysocki" Signed-off-by: Andy Shevchenko --- drivers/acpi/acpi_extlog.c | 2 +- drivers/acpi/apei/ghes.c | 8

[PATCH v1 6/8] mei: Use recently introduced uuid_le_cmp_p{p}() helpers

2017-04-21 Thread Andy Shevchenko
Recently introduced helpers take pointers to uuid_{be|le} instead of reference. Using them makes code less ugly. Cc: Tomas Winkler Signed-off-by: Andy Shevchenko --- drivers/misc/mei/bus-fixup.c | 2 +- drivers/misc/mei/bus.c |

Re: [PATCH] bus: fsl-mc: dpio: fix alter FQ state command

2017-04-21 Thread Dan Carpenter
On Fri, Apr 21, 2017 at 01:50:24PM +, Horia Geantă wrote: > Let me know whether keeping code similar would be preferred or not. > Keeping the code similar to the surrounding is never a valid argument but especially not in staging/. If only 1 line is nice in the whole file, at least that's

[PATCH v1 4/8] vfio-mdev: Use recently introduced uuid_le_cmp_p{p}()

2017-04-21 Thread Andy Shevchenko
Recently introduced helpers take pointers to uuid_{be|le} instead of reference. Using them makes code less ugly. Cc: Kirti Wankhede Cc: Alex Williamson Signed-off-by: Andy Shevchenko ---

[PATCH v1 3/8] HID: intel_ish-hid: Use recently introduced uuid_le_cmp_p{p}()

2017-04-21 Thread Andy Shevchenko
Recently introduced helpers take pointers to uuid_{be|le} instead of reference. Using them makes code less ugly. Cc: Srinivas Pandruvada Cc: Benjamin Tissoires Signed-off-by: Andy Shevchenko

[PATCH v1 7/8] efi: Use recently introduced uuid_le_cmp_p{p}() helpers

2017-04-21 Thread Andy Shevchenko
Recently introduced helpers take pointers to uuid_{be|le} instead of reference. Using them makes code less ugly. Cc: Matt Fleming Cc: Ard Biesheuvel Signed-off-by: Andy Shevchenko ---

[PATCH v1 2/8] ASoC: Intel: Skylake: Use recently introduced uuid_le_cmp_p{p}()

2017-04-21 Thread Andy Shevchenko
Recently introduced helpers take pointers to uuid_{be|le} instead of reference. Using them makes code less ugly. Cc: Liam Girdwood Cc: Mark Brown Cc: Vinod Koul Signed-off-by: Andy Shevchenko

[PATCH v1 1/8] lib/uuid: Introduce uuid_{be|le}_cmp_p{p}() helpers

2017-04-21 Thread Andy Shevchenko
New helpers take pointers to uuid_{be|le} as parameters. When using them on a raw data we don't need to do an ugly dereference and, in some cases, a type casting. Cc: Andrew Morton Cc: Arnd Bergmann Cc: Liam Girdwood Cc: Mark

[PATCH v1 5/8] vmbus: Use recently introduced uuid_le_cmp_p{p}() helpers

2017-04-21 Thread Andy Shevchenko
Recently introduced helpers take pointers to uuid_{be|le} instead of reference. Using them makes code less ugly. Cc: "K. Y. Srinivasan" Cc: Haiyang Zhang Cc: Stephen Hemminger Signed-off-by: Andy Shevchenko

Re: [PATCH] bus: fsl-mc: dpio: fix alter FQ state command

2017-04-21 Thread Horia Geantă
On 4/21/2017 4:31 PM, Stuart Yoder wrote: > On Fri, Apr 21, 2017 at 7:00 AM, Horia Geantă wrote: >> >> When checking the response verb, the valid bit should be masked out, >> since its value flips depending on what Response Register >> (RR0 /RR1) it's been read from. >> >>

Re: [PATCH] bus: fsl-mc: dpio: fix alter FQ state command

2017-04-21 Thread Stuart Yoder
On Fri, Apr 21, 2017 at 7:00 AM, Horia Geantă wrote: > > When checking the response verb, the valid bit should be masked out, > since its value flips depending on what Response Register > (RR0 /RR1) it's been read from. > > Fixes: 321eecb06bfb ("bus: fsl-mc: dpio: add QBMan

[PATCH] bus: fsl-mc: dpio: fix alter FQ state command

2017-04-21 Thread Horia Geantă
When checking the response verb, the valid bit should be masked out, since its value flips depending on what Response Register (RR0 /RR1) it's been read from. Fixes: 321eecb06bfb ("bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2") Signed-off-by: Horia Geantă ---

[PATCH 2/2] staging: atomisp: remove #ifdef for runtime PM functions

2017-04-21 Thread Arnd Bergmann
The runtime power management functions are called from the reset handler even if CONFIG_PM is disabled, leading to a link error: drivers/staging/built-in.o: In function `atomisp_reset': (.text+0x4cd1c): undefined reference to `atomisp_runtime_suspend' drivers/staging/built-in.o: In function

[PATCH 1/2] staging: atomisp: satm include directory is gone

2017-04-21 Thread Arnd Bergmann
After the satm kernel was removed, we should no longer add the directory to the search path. This was found with a 'make W=1' warning: cc1: error: drivers/staging/media/atomisp/pci/atomisp2/css2400/isp/kernels/satm/: No such file or directory [-Werror=missing-include-dirs] Fixes: 184f8e0981ef

Re: [PATCH v3] Staging: most: use __func__ instead of the function name

2017-04-21 Thread Greg KH
Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Fri, Apr 21, 2017 at 12:40:25AM -0700, Chandra Annamaneni wrote: > > Third Reminder. Please

Re: [PATCH v3] Staging: most: use __func__ instead of the function name

2017-04-21 Thread Chandra Annamaneni
Third Reminder. Please review. -- Chandra On Sun, 9 Apr 2017, chandrasekhar annamaneni wrote: > > Second reminder, please review. > > Thanks. > Chandra > > > On Fri, Mar 17, 2017 at 12:49 PM, Chandra Annamaneni > wrote: > > Change video.c to use %s, __func__