Re: [greybus-dev] [PATCH v2] Staging: greybus: light: Prefer kcalloc over kzalloc

On 08-05-17, 18:05, kart...@techveda.org wrote: > From: Karthik Tummala > > Fixed following checkpatch.pl warning: > * WARNING: Prefer kcalloc over kzalloc with multiply > > Instead of specifying no.of bytes * size as argument > in kzalloc, prefer kcalloc. > >

Re: [PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

On 05/08/2017 02:41 AM, Philipp Zabel wrote: Hi Steve, On Wed, 2017-04-12 at 17:45 -0700, Steve Longerbeam wrote: This patch adds a call to imx_media_fill_empty_mbus_fields() in the *_try_fmt() functions at the sink pads, to set empty field order and colorimetry parameters. If the field

[PATCH 2/3] staging: iio: meter: Fix the identations for proper alignments

This patch fixes below checkpatch.pl kind of warnings: CHECK: Alignment should match open parenthesis Signed-off-by: Harinath Nampally --- drivers/staging/iio/meter/ade7753.c | 55 ++--- 1 file changed, 27 insertions(+), 28 deletions(-)

[PATCH 3/3] staging: iio: meter: Replace symbolic permissions with octal permissions

This patch fixes below kind of warnings: WARNING: Symbolic permissions 'S_IXXX | S_IXXX' are not preferred. Below errors are false positives: ade7753.c:382: ERROR: Use 4 digit octal (0777) not decimal permissions ade7753.c:386: ERROR: Use 4 digit octal (0777) not decimal permissions

[PATCH 0/3] coding style warnings fixes

This patchset is for fixes reported by checkpatch.pl Please find the following related patches: [PATCH 1/3] staging: iio: meter: Add the comment for mutex definition [PATCH 2/3] staging: iio: meter: Fix the identations for proper alignments [PATCH 3/3] staging: iio: meter: Replace symbolic

[PATCH 1/3] staging: iio: meter: Add the comment for mutex definition

This patch fixes below checkpatch.pl warning: CHECK: struct mutex definition without comment Signed-off-by: Harinath Nampally --- drivers/staging/iio/meter/ade7753.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/meter/ade7753.c

[PATCH] staging: octeon-usb: use correct function for hcd cleanup

Use usb_put_hdc to release hdc allocated by usb_create_hcd. This is needed to handle sub-allocations and HCD sharing correctly. Signed-off-by: Anton Bondarenko --- drivers/staging/octeon-usb/octeon-hcd.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH] ATOMISP: Tidies up code warnings and errors in file

Cleared up some errors and warnings in drivers/staging/media/atomisp/i2c/ap1302.c Signed-off-by: Mark Railton --- drivers/staging/media/atomisp/i2c/ap1302.c | 83 ++ 1 file changed, 50 insertions(+), 33 deletions(-) diff --git

Re: [PATCH] staging : rtl8188eu : remove unnecessary else

On Mon, 2017-05-08 at 14:13 +0530, Surender Polsani wrote: > according to coding style else is not generally > useful after a break or return > > Signed-off-by: Surender Polsani > --- > drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 3 +-- > 1 file changed, 1

Re: [PATCH] android: binder: check result of binder_get_thread() in binder_poll()

Dmitry, On Mon, May 8, 2017 at 1:46 PM, John Stultz wrote: > On Mon, May 8, 2017 at 1:43 PM, Dmitry Torokhov > wrote: >> If binder_get_thread() fails to give us a thread data, we should avoid >> dereferencing a NULL pointer and return POLLERR

Re: [PATCH] android: binder: check result of binder_get_thread() in binder_poll()

On Mon, May 8, 2017 at 1:43 PM, Dmitry Torokhov wrote: > If binder_get_thread() fails to give us a thread data, we should avoid > dereferencing a NULL pointer and return POLLERR instead. > > Signed-off-by: Dmitry Torokhov Pulling Todd Kjos

[PATCH] staging: iio: meter: ade7854: Fix symbolic permissions to octal permissions

From: Christoph Fanelsa Fixed the checkpatch warnings (task #10 of eudyptula challenge) of prefered octal permissions over symbolic ones Signed-off-by: Christoph Fanelsa Cc: Michael Hennerich Cc: Jonathan Cameron

[PATCH 3/4] Staging: rtl8712: ieee80211: fixed camelcase coding style

Fixed coding style issue The following are the renames done to avoid camecase #Configuration-> configuration #BeaconPeriod -> beacon_period #ATIMWindow -> atim_window #DSConfig -> ds_config #FHConfig -> fh_config #

[PATCH 4/4] Staging: rtl8712: ieee80211:fixed warning line over 80 characters coding style issue

fixed warning line over 80 characters coding style issue Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/ieee80211.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c index

[PATCH] staging: media: fix one code style problem

this patch will fix one code style problem (ctx:WxE), space prohibited before that Signed-off-by: Remco Verhoef --- .../staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v3] staging: media: atomisp: Fix indentation to tabs

Fixing following checkpatch warnnings/errors: ERROR: code indent should use tabs where possible WARNING: please, no spaces at the start of a line Signed-off-by: Gideon Sheril --- Changed from previuos version: - Fixed alignment issues - Verified no new warning or errors

Re: [PATCH v5] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

On 9 May 2017 at 00:42, Andy Shevchenko wrote: > On Sun, May 7, 2017 at 1:04 PM, Ian W MORRISON wrote: > > What are you trying to achieve by posting this patch over and over so often? > > Version 5 look pretty good to me. Just stop posting it

Re: [PATCH v5] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

On Sun, May 7, 2017 at 1:04 PM, Ian W MORRISON wrote: > A kernel cloned from > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git and > built with the latest RTL8723BS driver included (CONFIG_RTL8723BS=m) > fails when booting on an Intel Atom device with the

Re: [PATCH -next] staging/android/ion: remove useless document file

On 05/06/2017 02:49 AM, Yisheng Xie wrote: > From: Yisheng Xie > > After commit 9828282e33a0 ("staging: android: ion: Remove old platform > support"), the document about devicetree of ion is no need anymore, so > just remove it. > Acked-by: Laura Abbott

[PATCH v6] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

A re-positioned call to kfree() in drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c causes a segmentation error. This patch removed the kfree() call. Fixes 6557ddfec348 ("staging: rtl8723bs: Fix various errors in os_dep/ioctl_cfg80211.c") Signed-off-by: Ian W Morrison

Re: [PATCH] added pca9570 driver

This should just go to the gpio people and not staging. The address is linux-g...@vger.kernel.org CC the Device Tree people for answers the device tree questions: devicet...@vger.kernel.org The subject should be: [PATCH] gpio: pca9570: add pca9570 driver The patch has a line wrapping problem

[PATCH v2] Staging: greybus: light: Prefer kcalloc over kzalloc

From: Karthik Tummala Fixed following checkpatch.pl warning: * WARNING: Prefer kcalloc over kzalloc with multiply Instead of specifying no.of bytes * size as argument in kzalloc, prefer kcalloc. Signed-off-by: Karthik Tummala Reviewed-by: Rui

Re: [PATCH] added pca9570 driver

On Mon, May 08, 2017 at 12:31:52PM +0100, Chris Dew wrote: > First, apologies, this is my first Linux kernel patch in at least 15 years. > While I have spent a few hours reading various pieces of documentation about > the Linux kernel development processes, I have probably missed some critical >

[PATCH] added pca9570 driver

First, apologies, this is my first Linux kernel patch in at least 15 years. While I have spent a few hours reading various pieces of documentation about the Linux kernel development processes, I have probably missed some critical files entirely. Also, there are probably a few coding issues

Re: [PATCH] Staging: greybus: Prefer kcalloc over kzalloc

Hi Karthik, Thanks for the patch. On Sat, May 06, 2017 at 07:44:10PM +0530, kart...@techveda.org wrote: From: Karthik Tummala Fixed following checkpatch.pl warning: * WARNING: Prefer kcalloc over kzalloc with multiply Instead of specifying no.of bytes * size as arugment

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

On 05/08/2017 11:36 AM, Philipp Zabel wrote: > Hi Hans, > > On Mon, 2017-05-08 at 10:27 +0200, Hans Verkuil wrote: >> Hi Philipp, >> >> Sorry for the very long delay, but I finally had some time to think about >> this. > > Thank you for your thoughts. > >> On 04/06/2017 03:55 PM, Philipp Zabel

Re: [PATCH 40/40] media: imx: set and propagate empty field, colorimetry params

Hi Steve, On Wed, 2017-04-12 at 17:45 -0700, Steve Longerbeam wrote: > This patch adds a call to imx_media_fill_empty_mbus_fields() in the > *_try_fmt() functions at the sink pads, to set empty field order and > colorimetry parameters. > > If the field order is set to ANY, choose the currently

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

Hi Hans, On Mon, 2017-05-08 at 10:27 +0200, Hans Verkuil wrote: > Hi Philipp, > > Sorry for the very long delay, but I finally had some time to think about > this. Thank you for your thoughts. > On 04/06/2017 03:55 PM, Philipp Zabel wrote: > > If the the field order is set to ANY in set_fmt,

[PATCH] staging : rtl8188eu : remove unnecessary else

according to coding style else is not generally useful after a break or return Signed-off-by: Surender Polsani --- drivers/staging/rtl8188eu/hal/rtl8188e_dm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [PATCH] [media] imx: csi: retain current field order and colorimetry setting as default

Hi Philipp, Sorry for the very long delay, but I finally had some time to think about this. On 04/06/2017 03:55 PM, Philipp Zabel wrote: > If the the field order is set to ANY in set_fmt, choose the currently > set field order. If the colorspace is set to DEFAULT, choose the current >

Re: [PATCH 2/2] staging: ccree: Fix initialization of anonymous unions

On Sun, May 7, 2017 at 9:53 PM, Geert Uytterhoeven wrote: > With gcc 4.1.2: > > drivers/staging/ccree/ssi_hash.c:1990: error: unknown field > ‘template_ahash’ specified in initializer > drivers/staging/ccree/ssi_hash.c:1991: error: unknown field ‘init’ > specified

Re: [V4] staging : rtl8188eu : remove void function return

On Mon, 2017-05-08 at 07:59 +0200, Greg KH wrote: > On Mon, May 08, 2017 at 11:22:35AM +0530, Surender Polsani wrote: > > kernel coding style doesn't allow the return statement > > in void function. > > > > Signed-off-by: Surender Polsani > > --- > > Changes for v2: >

Re: [V4] staging : rtl8188eu : remove void function return

On Mon, May 08, 2017 at 11:22:35AM +0530, Surender Polsani wrote: > kernel coding style doesn't allow the return statement > in void function. > > Signed-off-by: Surender Polsani > --- > Changes for v2: > corrected subject line as suggested > Changes for v3: > modified