[PATCH] staging: typec: Fix sparse warnings about incorrect types

Fix the following sparse warnings about incorrect type usage: fusb302.c:1028:32: warning: incorrect type in argument 1 (different base types) fusb302.c:1028:32:expected unsigned short [unsigned] [usertype] header fusb302.c:1028:32:got restricted __le16 const [usertype] header

[PATCH] staging: lustre: ptlrpc: remove unnecessary code

offset is an unsigned variable and, greater-than-or-equal-to-zero comparison of an unsigned variable is always true. Addresses-Coverity-ID: 1373919 Signed-off-by: Gustavo A. R. Silva --- drivers/staging/lustre/lustre/ptlrpc/layout.c | 2 +- 1 file changed, 1

[PATCH] staging: wlan-ng: convert endianness in situ

Fix several sparse warnings about casts to restricted little-endian. Signed-off-by: Thibaut SAUTEREAU --- drivers/staging/wlan-ng/prism2fw.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

Re: [patch 1/1] staging: speakup: flush tty buffers and ensure hardware flow control

> + if (!(tmp_termios.c_cflag & CRTSCTS)) { > + tmp_termios.c_cflag |= CRTSCTS; > + ret = tty_set_termios(tty, _termios); > + if (ret) > + pr_warn("speakup: Failed to set hardware flow > control\n"); You should check the tty c_cflag

[PATCH v2 4/7] staging: emxx_udc: Update local variable names

Ensure that any any local variable use snake_case (many mixed upper/lower case) Signed-off-by: Alexis Lothoré --- drivers/staging/emxx_udc/emxx_udc.c | 248 ++-- 1 file changed, 124 insertions(+), 124 deletions(-) diff --git

[PATCH v2 3/7] staging: emxx_udc: Update function names

Ensure that function names does not mix upper/lower case Signed-off-by: Alexis Lothoré --- drivers/staging/emxx_udc/emxx_udc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c

[PATCH v2 6/7] staging: emxx_udc: Break long lines

Make sure to break long lines to 80 Signed-off-by: Alexis Lothoré --- drivers/staging/emxx_udc/emxx_udc.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c index

[PATCH v2 1/7] staging: emxx_udc: Update EPn variables name

Update EPn* variables names to EPN* to prevent CamelCase usage Signed-off-by: Alexis Lothoré --- drivers/staging/emxx_udc/emxx_udc.c | 136 +++ drivers/staging/emxx_udc/emxx_udc.h | 216 ++-- 2 files changed, 176

[PATCH v2 7/7] staging: emxx_udc: Update "reserved" registers name

Ensure that "Reserved" members of registers mapping structure do not mix upper/lower case Signed-off-by: Alexis Lothoré --- drivers/staging/emxx_udc/emxx_udc.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v2 5/7] staging: emxx_udc: Update function parameters name

Ensure that function parameters use snake_case (some mixed upper/lower case) Signed-off-by: Alexis Lothoré --- drivers/staging/emxx_udc/emxx_udc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c

[PATCH v2 2/7] staging: emxx_udc: Balance "else" parenthesis

Add missing parenthesis for else statement Signed-off-by: Alexis Lothoré --- drivers/staging/emxx_udc/emxx_udc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c index

Re: [PATCH] staging: typec: Fix sparse warnings about incorrect types

On 10 May 2017 at 08:23, Guenter Roeck wrote: > Please the patch into two parts, one per file; the required changes > for endianness support in tcpci.c are much more complex. I will send out a patch for the two simple fixes - the use of pd_header_cnt_le(). > Excellent catch,

staging: most: net: use dormant state

From: Andrey Shvetsov This replaces the call of wait_for_completion in case of an invalid MAC address in the function most_nd_open() with the dormant state of the network device. As a side effect, opening the network device cannot fail anymore. Signed-off-by: Andrey

staging: most: dim2: enable flow control for isoc channels

From: Andrey Shvetsov This patch enables the flow control feature for the isochronous channels of the DIM2 macro. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm ---

staging: most: allocate private net_dev_context with the alloc_netdev

From: Andrey Shvetsov This moves the allocation of the net_dev to the aim_probe_channel() and uses the parameter sizeof_priv of the function alloc_netdev to reserve the space for the struct net_dev_context. As a side effect, the nd->dev always points to the existing

staging: most: remove dependency on networking-aim

From: Andrey Shvetsov The modules hdm-usb and hdm-dim2 depend on the module aim-network, because they use the function most_deliver_netinfo that it exports. To remove this dependency, this patch replaces the call of the function most_deliver_netinfo with the call of the

staging: most: net: remove redundant cleanup code

From: Andrey Shvetsov This removes redundant cleanup code that is executed anyway when the most_deregister_aim() is called. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm ---

staging: most: check availability of the callback request_netinfo

From: Andrey Shvetsov Since not all HDMs implement the callback request_netinfo, this patch adds checking of its availability. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm ---

staging: most: net: add carrier information

From: Andrey Shvetsov This adds the carrier information for the network devices based on the INIC controllers. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm ---

staging: most: net: prefer __func__ over the function name

From: Andrey Shvetsov This replaces the function names in the print messages with the __func__ macro. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm --- drivers/staging/most/aim-network/networking.c

staging: most: net: remove useless variable channels_opened

From: Andrey Shvetsov The function most_nd_stop is only called by successful return from the function most_nd_open, so the channels_opened is always true in the function most_nd_stop. The functions aim_resume_tx_channel and aim_rx_data are only called after successful

staging: most: dim2: replace function parameter with the expression

From: Andrey Shvetsov This replaces the function parameter sync_mfe with the expression (ch_type == CAT_CT_VAL_SYNC) what is the same. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm ---

staging: most: use unsafe version of list traversing

From: Andrey Shvetsov The function get_net_dev_context does not remove elements of the list. Hence, list traversing does not need to be secured. This patch replaces list_for_each_entry_safe with the list_for_each_entry. Signed-off-by: Andrey Shvetsov

staging: most: net: fix race between create/destroy device

From: Andrey Shvetsov This introduces the kref for the net_dev_context to prevent the destruction of the network devices that are in use. Each get_net_dev_context is completed with the put_net_dev_context, except the function aim_probe_channel that calls one more

staging: most: i2c: remove empty callback request_netinfo

From: Andrey Shvetsov Since the networking-aim checks the availability of the callback request_netinfo, this patch removes the empty callback request_netinfo from the i2c-hdm. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm

Re: [PATCH] staging: ccree: remove extraneous spin_unlock_bh() in error handler

On Wed, May 10, 2017 at 12:20 PM, Ian Chard wrote: > An early error handler in send_request() tries to release a spinlock, > but the lock isn't acquired until the loop below it is entered. > > Signed-off-by: Ian Chard > --- >

[PATCH] staging: ccree: remove extraneous spin_unlock_bh() in error handler

An early error handler in send_request() tries to release a spinlock, but the lock isn't acquired until the loop below it is entered. Signed-off-by: Ian Chard --- drivers/staging/ccree/ssi_request_mgr.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH] staging: vc04_services: Fix bulk cache maintenance

On 10/05/2017 10:06, Greg Kroah-Hartman wrote: > On Wed, May 10, 2017 at 09:42:43AM +0100, Phil Elwell wrote: >> On 04/05/2017 18:51, Stefan Wahren wrote: >>> Phil Elwell hat am 4. Mai 2017 um 11:58 geschrieben: vchiq_arm supports transfers less than one

Re: [PATCH] staging: vc04_services: Fix bulk cache maintenance

On Wed, May 10, 2017 at 09:42:43AM +0100, Phil Elwell wrote: > On 04/05/2017 18:51, Stefan Wahren wrote: > > > >> Phil Elwell hat am 4. Mai 2017 um 11:58 geschrieben: > >> > >> > >> vchiq_arm supports transfers less than one page and at arbitrary > >> alignment, using the

From Sgt. Ralph Laura

Nice to meet you , It's me Sgt. Ralph Laura from the South Eastern State of the United State (Kentucky) based in Kabul Afghanistan, I hope all is well with you? I am working with the United States Air Force peace keeping troop in Afghanistan, on war against terrorism. I have in my possession

Re: [PATCH] staging: vc04_services: Fix bulk cache maintenance

On 04/05/2017 18:51, Stefan Wahren wrote: > >> Phil Elwell hat am 4. Mai 2017 um 11:58 geschrieben: >> >> >> vchiq_arm supports transfers less than one page and at arbitrary >> alignment, using the dma-mapping API to perform its cache maintenance >> (even though the VPU

Re: [PATCH 0/3] staging: ccree: resolve checkpatch issues.

On Sun, May 7, 2017 at 1:56 AM, Matthew Giassa wrote: > * Matthew Giassa [2017-05-06 15:46:53 -0700]: > > >> Included is a set of small fixes to resolve all outstanding checkpatch >> warnings issues for drivers/staging/ccree/cc_hal.h. Two are cosmetic >>