[PATCH v2 1/7] staging: sm750fb: fix length of lines, function calls and declaration

This patch breaks lines that are longer than 80 characters and joins together those, that are too short and can be placed at one. Function calls and declarations are updated to fit kernel code style. Signed-off-by: Matej Dujava --- drivers/staging/sm750fb/ddk750_chip.c

[PATCH v2 0/7] staging: sm750fb: cleaning code

Folowing patch set cleans some warnings and checkups from checkpatch.pl and also fix code to better fot linux code style. Changes since v1 [1]: * staging: sm750fb: fix length of lines, function calls and declaration * created better description * squashed: staging: sm750fb:

[PATCH v2 2/7] staging: sm750fb: unifying macro usage and definitions

This patch adds tabs into macro definitions so all rhs are on same column. Removing MHz macro from ddk_chip.c file and reuse MHZ from sm750.h. Signed-off-by: Matej Dujava --- drivers/staging/sm750fb/ddk750_chip.c| 18 drivers/staging/sm750fb/ddk750_display.h |

[PATCH v2 5/7] staging: sm750fb: Remove typedef from "typedef enum _disp_output_t"

This patch removes typedefs from enum and renames it from "typedef enum _disp_output_t" to "enum disp_output" as per kernel coding standards. Signed-off-by: Matej Dujava --- drivers/staging/sm750fb/ddk750_display.c | 2 +- drivers/staging/sm750fb/ddk750_display.h | 8

[PATCH v2 7/7] staging: sm750fb: Remove typedef from "typedef enum _sii164_hot_plug_mode_t"

This patch removes typedefs from enum and renames it from "typedef enum _sii164_hot_plug_mode_t" to "enum sii164_hot_plug_mode" as per kernel coding standards. Signed-off-by: Matej Dujava --- drivers/staging/sm750fb/ddk750_sii164.c | 2 +-

[PATCH v2 6/7] staging: sm750fb: Remove typedef from "typedef enum _DPMS_t"

This patch removes typedefs from enum and renames it from "typedef enum _DPMS_t" to "enum DPMS" as per kernel coding standards. Signed-off-by: Matej Dujava --- drivers/staging/sm750fb/ddk750_power.c | 2 +- drivers/staging/sm750fb/ddk750_power.h | 7 +++ 2 files

[PATCH v2 3/7] staging: sm750fb: Remove typedef from "typedef enum _logical_chip_type_t"

This patch removes typedefs from enum and renames it from "typedef enum _logical_chip_type_t" to "enum logical_chip_type" as per kernel coding standards. Signed-off-by: Matej Dujava --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- drivers/staging/sm750fb/ddk750_chip.h | 8

[PATCH v2 4/7] staging: sm750fb: Remove typedef from "typedef enum _clock_type_t"

This patch removes typedefs from enum and renames it from "typedef enum _clock_type_t" to "enum clock_type" as per kernel coding standards. Signed-off-by: Matej Dujava --- drivers/staging/sm750fb/ddk750_chip.h | 8 drivers/staging/sm750fb/ddk750_mode.c | 2 +-

Re: [PATCH 1/2] staging: greybus: arche: remove timesync remains

On 15/05/17 17:10, Johan Hovold wrote: On Mon, May 15, 2017 at 04:17:55PM +0100, Bryan O'Donoghue wrote: On 15/05/17 15:26, Johan Hovold wrote: Remove the remaining timesync bits that were left in the arche platform driver and which prevented the driver from being compiled. Fixes:

[PATCH v3] staging: rtl8188eu: fix indentation error

Fixes a 'code indent should use tabs where possible' checkpatch code style error by changing whitespace into tabs. Signed-off-by: Remco Verhoef --- Changes in v2: - More expressive commit message and subject Changes in v3: - Align with struct, to line things up better

[PATCH 3/5] staging: media: lirc: Use __func__ for logging function name

Fix all checkpatch reported issues for "CHECK: Prefer using '"%s...", __func__' to using '', ..." Use recommended style. Additionally, __func__ was already used in similar cases throughout the code, so make it all consistent. Signed-off-by: Ricardo Silva ---

[PATCH 5/5] staging: media: lirc: Fix unbalanced braces around if/else

Fix all checkpatch reported issues for: * CHECK: "braces {} should be used on all arms of this statement". * CHECK: "Unbalanced braces around else statement". Make sure all if/else statements are balanced in terms of braces. Most cases in code are, but a few were left unbalanced, so put them

[PATCH 1/5] staging: media: lirc: Fix whitespace style checks

Fix style issues reported by checkpatch, affecting whitespace only: * CHECK: "Please don't use multiple blank lines". Two of these still triggering and left untouched because used for separating logical blocks (vars from functions, etc.). * CHECK: "spaces preferred around that ''".

[PATCH 2/5] staging: media: lirc: Fix NULL comparisons style

Fix all checkpatch reported issues for "CHECK: Comparison to NULL could be written...". Do these comparisons using the recommended coding style and consistent with other similar cases in the file, which already used the recommended way. Signed-off-by: Ricardo Silva ---

[PATCH 4/5] staging: media: lirc: Use sizeof(*p) instead of sizeof(struct P)

Fix all checkpatch reported issues for "CHECK: Prefer kzalloc(sizeof(*)...) over kzalloc(sizeof(struct )...)". Other similar case in the code already using recommended style, so make it all consistent with the recommended practice. Signed-off-by: Ricardo Silva ---

[PATCH 0/5] staging: media: lirc: Fix several checkpatch issues

This patch series is intended to fix several checkpatch issues (from CHECK level) found on lirc_zilog.c: The 1st patch focus on whitespace related fixes. The 2nd patch fixes NULL comparisons style. The 3rd patch is for using __func__ in logging functions that are to trace the function's name,

[PATCH v3 0/2] Avoid CamelCases in ks7010 driver

This patchset fix CamelCases in ks7010 driver except michael_mic which will be replaced by kernel implementation in the future. --- v2: - Rebased all patches to next-20170512. 2 and 8 should apply cleanly now v3: - Rebased all not yet applied patched to staging-testing branch of

[PATCH v3 1/2] staging: ks7010: avoid CamelCase: receiveDTIMs

Replace CamelCase variable name with underscores to comply with the standard kernel coding style. Signed-off-by: Janusz Lisiecki --- drivers/staging/ks7010/ks_hostif.c | 26 +- drivers/staging/ks7010/ks_hostif.h | 2 +- 2 files changed, 14

[PATCH v3 2/2] staging: ks7010: avoid CamelCase: local variables in ks_hostif.c

Replace CamelCase local variables' name with underscores to comply with the standard kernel coding style. Changed: - LinkSpeed - TransmittedFrameCount - ReceivedFragmentCount - FailedCount - FCSErrorCount Signed-off-by: Janusz Lisiecki ---

[patch v2 4/6] staging: speakup: add send_xchar, tiocmset and input functionality for tty

This patch adds further TTY-based functionality, specifically implementation of send_xchar and tiocmset methods, and input. send_xchar and tiocmset methods simply delegate to corresponding TTY operations. For input, it implements the receive_buf2 callback in tty_ldisc_ops of speakup's ldisc. If a

[patch v2 3/6] staging: speakup: migrate acntsa, bns, dummy and txprt to ttyio

This changes the above five synths to TTY-based comms. They were chosen as a first pass because their serial comms are straightforward, i.e. they don't use serial input and don't do internal port knocking. Signed-off-by: Okash Khawaja Reviewed-by: Samuel Thibault

[patch v2 6/6] staging: speakup: flush tty buffers and ensure hardware flow control

This patch fixes the issue where TTY-migrated synths would take a while to shut up after hitting numpad enter key. When calling synth_flush, even though XOFF character is sent as high priority, data buffered in TTY layer is still sent to the synth. This patch flushes that buffered data when

[patch v2 5/6] staging: speakup: migrate apollo, ltlk, audptr, decext, dectlk and spkout

This patch simply uses the changes introduced in previous patches and migrates apollo, ltlk, audptr, decext, spkout and dectlk. Migrations are straightforward function pointer updates. Signed-off by: Okash Khawaja Reviewed-by: Samuel Thibault

[patch v2 2/6] staging: speakup: add tty-based comms functions

This adds spk_ttyio.c file. It contains a set of functions which implement those methods in spk_synth struct which relate to sending bytes out using serial comms. Implementations in this file perform the same function but using TTY subsystem instead. Currently synths access serial ports, directly

[patch v2 0/6] staging: speakup: migrate synths to use TTY-based comms

This patchset migrates all external synths from using raw serial i/o to using tty-based comms. The synths not migrated are internal ones - plugged directly into motherboard, communicating over ISA etc. It's important to note that these patches access TTY from inside kernel. Here is the summary of

[patch v2 1/6] tty: export tty_open_by_driver

This exports tty_open_by_driver so that it can be called from other places inside the kernel. The checks for null file pointer are based on Alan Cox's patch here: http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1215095.html. Description below is quoted from it: "[RFC] tty_port:

Re: [PATCH 2/2] staging: greybus: enable compile testing of arche driver

On 05/15/17 07:26, Johan Hovold wrote: > Add Arche platform-driver config option and allow the driver to be > compile tested also without the usb3613 driver. > > Signed-off-by: Johan Hovold > --- > drivers/staging/greybus/Kconfig | 10 ++ >

Re: [PATCH 1/2] staging: greybus: arche: remove timesync remains

On Mon, May 15, 2017 at 04:17:55PM +0100, Bryan O'Donoghue wrote: > On 15/05/17 15:26, Johan Hovold wrote: > > Remove the remaining timesync bits that were left in the arche platform > > driver and which prevented the driver from being compiled. > > > > Fixes: bdfb95c4baab ("staging: greybus:

Re: [PATCH 1/2] staging: greybus: arche: remove timesync remains

On 15/05/17 15:26, Johan Hovold wrote: Remove the remaining timesync bits that were left in the arche platform driver and which prevented the driver from being compiled. Fixes: bdfb95c4baab ("staging: greybus: remove timesync protocol support") Signed-off-by: Johan Hovold I

Re: [Bug] VCHIQ functional test broken

On 15/05/2017 15:54, Stefan Wahren wrote: > Am 15.05.2017 um 16:29 schrieb Phil Elwell: >> On 13/05/2017 10:30, Russell King - ARM Linux wrote: >>> On Sat, May 13, 2017 at 11:07:28AM +0200, Stefan Wahren wrote: In the meantime this issue has been fixed by Phil [1]. >>> Right - definitely a

Re: [Bug] VCHIQ functional test broken

Am 15.05.2017 um 16:29 schrieb Phil Elwell: > On 13/05/2017 10:30, Russell King - ARM Linux wrote: >> On Sat, May 13, 2017 at 11:07:28AM +0200, Stefan Wahren wrote: >>> In the meantime this issue has been fixed by Phil [1]. >> Right - definitely a driver bug. Mapping more memory for DMA than is

Re: [Bug] VCHIQ functional test broken

On 13/05/2017 10:30, Russell King - ARM Linux wrote: > On Sat, May 13, 2017 at 11:07:28AM +0200, Stefan Wahren wrote: >> In the meantime this issue has been fixed by Phil [1]. > > Right - definitely a driver bug. Mapping more memory for DMA than is > actually going to be DMA'd to and expecting

[PATCH 2/2] staging: greybus: enable compile testing of arche driver

Add Arche platform-driver config option and allow the driver to be compile tested also without the usb3613 driver. Signed-off-by: Johan Hovold --- drivers/staging/greybus/Kconfig | 10 ++ drivers/staging/greybus/Makefile | 2 +-

[PATCH 1/2] staging: greybus: arche: remove timesync remains

Remove the remaining timesync bits that were left in the arche platform driver and which prevented the driver from being compiled. Fixes: bdfb95c4baab ("staging: greybus: remove timesync protocol support") Signed-off-by: Johan Hovold ---

[PATCH 0/2] staging: greybus: fix arche driver compilation

The arche driver currently depends on the out-of-tree usb3613 driver and this prevented a recent compile breakage after removing the timesync code from being detected. These patches remove the remaining timesync bits, and enable compile testing of the arche driver to avoid further unintended

[PATCH] staging: vt6656: fix style

Fix coding style, including breaking too long lines, multiple assignments in same line and empty lines. Signed-off-by: Juan Manuel Torres Palma --- drivers/staging/vt6656/rxtx.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-)

[PATCH v4] drivers/staging: refactor dgnc tty registration.

-remove duplicate tty allocation code for serial and printer drivers. -add missing tty c_ispeed and c_ospeed initialization to 9600. -fix sparse warning: too long initializer-string for array of char. This patch was only unit tested due to lack of the actual hardware. Signed-off-by: Haim Daniel

Re: [PATCH v3] drivers/staging: refactor dgnc tty registration.

me@haim-toshiba1 ~ $ dpkg -l sparse Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) ||/ Name Version Architecture Description

Re: [PATCH v3 3/3] staging: typec: fusb302: refactor resume retry mechanism

On 05/12/2017 01:16 PM, Rui Miguel Silva wrote: The i2c functions need to test the pm_suspend state and do, if needed, some retry before i2c operations. This code was repeated 4x. To isolate this, create a new function to check suspend state and call it in every need place. As at it, move the

Re: [PATCH v3 2/3] staging: typec: fusb302: reset i2c_busy state in error

On 05/12/2017 01:16 PM, Rui Miguel Silva wrote: Fix reset of i2c_busy flag if an error occurs during the i2c block read. Signed-off-by: Rui Miguel Silva Reviewed-by: Guenter Roeck --- drivers/staging/typec/fusb302/fusb302.c | 6 -- 1 file

Re: [PATCH v3] drivers/staging: refactor dgnc tty registration.

On Mon, May 15, 2017 at 03:30:50PM +0300, Haim Daniel wrote: > -remove duplicate tty allocation code for serial and printer drivers. > -fix sparse warning: too long initializer-string for array of char. I think my version of Sparse is too old. I don't get a warning. Please cut and paste the

[PATCH v3] drivers/staging: refactor dgnc tty registration.

-remove duplicate tty allocation code for serial and printer drivers. -fix sparse warning: too long initializer-string for array of char. Signed-off-by: Haim Daniel --- drivers/staging/dgnc/dgnc_driver.h | 13 drivers/staging/dgnc/dgnc_tty.c| 150

[PATCH] staging: wlan-ng: p80211conv: change args types of p80211_caphdr structure to be network compatible.

Change p80211_caphdr structure args types to __be.. to be compatible with byte ordering of the network. and in hfa384x_usb.c make calculations with respect to machine. Signed-off-by: Karim Eshapa --- drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-

Re: [PATCH v2] drivers/staging: refactor dgnc tty registration.

On Mon, May 15, 2017 at 02:48:52PM +0300, Haim Daniel wrote: > +static struct tty_driver *_dgnc_tty_register(char *serial_name, uint > maxports, Ahh... I see why you are adding underscores. Please, just get a better name instead of taking an existing name and adding underscores. regards, dan

[PATCH v2] drivers/staging: refactor dgnc tty registration.

-remove duplicate tty allocation code for serial and printer drivers. -fix sparse warning: too long initializer-string for array of char. Signed-off-by: Haim Daniel --- drivers/staging/dgnc/dgnc_driver.h | 13 drivers/staging/dgnc/dgnc_tty.c| 150

RE: [PATCH 9/9] staging: wlan-ng: p80211conv: change args types of p80211_caphdr structure to be network compatible.

it's only one patch sorry, there is something going wrong with my 'git' creating patch. Thanks, Kaim ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 9/9] staging: wlan-ng: p80211conv: change args types of p80211_caphdr structure to be network compatible.

On Mon, May 15, 2017 at 01:22:02PM +0200, Karim Eshapa wrote: > Change p80211_caphdr structure args types to __be.. to be > compatible with byte ordering of the network. > and in hfa384x_usb.c make calculations with respect to machine. > > Signed-off-by: Karim Eshapa >

Re: [patch 2/6] tty: export tty_open_by_driver

On Mon, May 15, 2017 at 12:10:06PM +0100, Okash Khawaja wrote: > Hi, > > On Mon, May 15, 2017 at 11:31 AM, Greg Kroah-Hartman > wrote: > > On Sat, Apr 29, 2017 at 08:52:59PM +0100, Okash Khawaja wrote: > >> This applies on top of the changes already in staging-next

[PATCH] staging: wlan-ng: p80211conv: change args types of p80211_caphdr structure to be network compatible.

Change p80211_caphdr structure args types to __be.. to be compatible with byte ordering of the network. and in hfa384x_usb.c make calculations with respect to machine. Signed-off-by: Karim Eshapa --- drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-

[PATCH 9/9] staging: wlan-ng: p80211conv: change args types of p80211_caphdr structure to be network compatible.

Change p80211_caphdr structure args types to __be.. to be compatible with byte ordering of the network. and in hfa384x_usb.c make calculations with respect to machine. Signed-off-by: Karim Eshapa --- drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-

Re: [patch 2/6] tty: export tty_open_by_driver

Hi, On Mon, May 15, 2017 at 11:31 AM, Greg Kroah-Hartman wrote: > On Sat, Apr 29, 2017 at 08:52:59PM +0100, Okash Khawaja wrote: >> This applies on top of the changes already in staging-next branch which allow >> kernel access to TTY dev. >> >> Signe-doff-by: Okash

Re: [PATCH v2] staging: rtl8188eu: fix indentation error

On Fri, May 12, 2017 at 06:39:44PM -0700, Remco Verhoef wrote: > Fixes a 'code indent should use tabs where possible' checkpatch code > style error by changing whitespace into tabs. > > Signed-off-by: Remco Verhoef > --- > Changes in v2: > - More expressive commit message

Re: [PATCH] staging: vt6656: Break too long lines

On Sat, May 13, 2017 at 07:45:28AM +0900, Juan Manuel Torres Palma wrote: > Fix style in rxtx.c splitting lines into 80 characters or less. > > Signed-off-by: Juan Manuel Torres Palma > --- > drivers/staging/vt6656/rxtx.c | 20 > 1 file changed,

Re: [patch v2 1/1] staging: speakup: flush tty buffers and ensure hardware flow control

On Fri, May 12, 2017 at 08:43:58PM +0100, Okash Khawaja wrote: > This patch fixes the issue where TTY-migrated synths would take a while > to shut up after hitting numpad enter key. When calling synth_flush, > even though XOFF character is sent as high priority, data buffered in > TTY layer is

Re: [patch 2/6] tty: export tty_open_by_driver

On Sat, Apr 29, 2017 at 08:52:59PM +0100, Okash Khawaja wrote: > This applies on top of the changes already in staging-next branch which allow > kernel access to TTY dev. > > Signe-doff-by: Okash Khawaja > Reviewed-by: Samuel Thibault > >

Re: [PATCH 2/2] staging/atomisp: putting NULs in the wrong place

On Mon, May 15, 2017 at 12:21:45PM +0200, walter harms wrote: > can this strcpy_s() replaced with strlcpy ? > These functions obviously should be removed, yes. Please send a patch for that and we can drop my patches. Give David reported-by credit. regards, dan carpenter

Re: [PATCH 0/9] staging: sm750fb: cleaning code

On Sun, May 14, 2017 at 12:42:33AM +0200, Matej Dujava wrote: > Folowing patches are cleaning some warnings and checkups from checkpatch.pl I've only reviewed a few of these, please fix them up based on the comments you have received so far and resend. thanks, greg k-h

Re: [PATCH 4/9] staging: sm750fb: removing unnecessary binary operations

On Sun, May 14, 2017 at 12:42:37AM +0200, Matej Dujava wrote: > This patch remove unnecessary operation (eg. ``X | (0x0 << Y)`` to ``X``). > > Signed-off-by: Matej Dujava > --- > drivers/staging/sm750fb/ddk750_display.h | 32 > > 1 file

Re: [PATCH 2/2] staging/atomisp: putting NULs in the wrong place

Am 15.05.2017 12:01, schrieb Dan Carpenter: > We're putting the NUL terminators one space beyond where they belong. > This doesn't show up in testing because all but the callers put a NUL in > the correct place themselves. LOL. It causes a static checker warning > about buffer overflows. > >

Re: [PATCH 3/9] staging: sm750fb: reordering of macro definitions

On Sun, May 14, 2017 at 12:42:36AM +0200, Matej Dujava wrote: > This patch reorder definition of macros so all macros are in same order. > > Signed-off-by: Matej Dujava > --- > drivers/staging/sm750fb/ddk750_display.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] drivers/staging/ccree: Removing trailing whitespaces

On Mon, May 15, 2017 at 11:03:40AM +0530, Pushkar Jambhlekar wrote: > Fixing 'checkpatch.pl' warnings: Trailing whitespaces > > Signed-off-by: Pushkar Jambhlekar > --- > drivers/staging/ccree/ssi_cipher.c | 110 > ++--- > 1 file changed,

Re: [PATCH v2 1/8] staging: ks7010: avoid CamelCase in fields of struct local_gain_t

On Fri, May 12, 2017 at 03:42:36PM +0200, Janusz Lisiecki wrote: > Replace CamelCase fields of struct with underscores to comply > with the standard kernel coding style > > Signed-off-by: Janusz Lisiecki This patch, and your others in this series, do not apply at all

[PATCH 2/2] staging/atomisp: putting NULs in the wrong place

We're putting the NUL terminators one space beyond where they belong. This doesn't show up in testing because all but the callers put a NUL in the correct place themselves. LOL. It causes a static checker warning about buffer overflows. Fixes: a49d25364dfb ("staging/atomisp: Add support for the

[PATCH 1/2] staging/atomisp: one char read beyond end of string

We should verify that "ix < max_len" before we test whether we have reached the NUL terminator. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Reported-by: David Binderman Signed-off-by: Dan Carpenter diff --git

Re: [PATCH 1/2] staging/atomisp: one char read beyond end of string

Oops. Please ignore this one. I meant to send it to David Binderman's thread. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 11/13] staging: most: net: fix race between create/destroy device

On Fri, May 12, 2017 at 12:59:59PM +0200, Christian Gromm wrote: > From: Andrey Shvetsov > > This introduces the kref for the net_dev_context to prevent the > destruction of the network devices that are in use. > > Each get_net_dev_context is completed with the

[PATCH 1/2] staging/atomisp: one char read beyond end of string

We should verify that "ix < max_len" before we test whether we have reached the NUL terminator. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Reported-by: David Binderman Signed-off-by: Dan Carpenter diff --git

Re: [PATCH 09/13] staging: most: net: prefer __func__ over the function name

On Fri, May 12, 2017 at 12:59:57PM +0200, Christian Gromm wrote: > From: Andrey Shvetsov > > This replaces the function names in the print messages with the __func__ > macro. > > Signed-off-by: Andrey Shvetsov > Signed-off-by: Christian Gromm

Re: [PATCH] staging: vt6656: Break too long lines

On Sat, May 13, 2017 at 12:30:07AM +0900, Juan Manuel Torres Palma wrote: > Fix style in rxtx.c splitting lines into 80 characters or less. > > Signed-off-by: Juan Manuel Torres Palma _ALWAYS_ test build your patches, so you don't get a grumpy maintainer telling you

[PATCH] Staging: rtl8723bs: core: rtw_mlme: Fix spelling issues

Fixed spelling warnings produced by scripts/checkpatch.pl Signed-off-by: Ammly Fredrick --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c

[PATCH] staging: vme: Use BIT macro for bit definitions

Use the BIT(n) macro instead of '(1 << n)' in definitions where the bit semantics clearly applies. Fixes true positive "Prefer using the BIT macro" checks reported by checkpatch. Some of these checks are still triggering on definitions using '(1 << n)', namely for PIO2_CNTR_SC_DEV1,

Re: linux-4.12-rc1/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:2966: cart before the horse ?

On Sun, May 14, 2017 at 07:19:50PM +, David Binderman wrote: > Hello there, > > linux-4.12-rc1/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c:2966]: (style) > Array index 'i' is used before limits check. > > Source code is > > while (szLine[i] != '{' && i < strlen(szLine))

Re: [PATCH] drivers/staging: refactor dgnc tty registration.

On Sun, May 14, 2017 at 06:50:24PM +0300, Haim Daniel wrote: > @@ -129,6 +113,41 @@ static void dgnc_tty_set_termios(struct tty_struct *tty, > > /* TTY Initialization/Cleanup Functions */ > > +static struct tty_driver *__dgnc_tty_register(char *serial_name, uint > maxports, No need for

Re: [PATCH 1/9] staging: sm750fb: fix length of lines

On Sun, May 14, 2017 at 12:42:34AM +0200, Matej Dujava wrote: > This patch breaks lines that are longer than 80 characters and joins > together those, that are too short and can be placed at one. > The patch basically doesn't match the changelog. regards, dan carpenter