[PATCH] staging: sm750fb: always take the lock

2017-06-25 Thread AbdAllah-MEZITI
This patch - will always take the lock - fix the sparse warning: drivers/staging/sm750fb/sm750.c:159:13: warning: context imbalance in 'lynxfb_ops_fillrect' - different lock contexts for basic block drivers/staging/sm750fb/sm750.c:231:9: warning: context imbalance in 'lynxfb_ops_copyarea' -

Re: [PATCH 0/4] staging: ks7010: cfg80211 conversion

2017-06-25 Thread Greg Kroah-Hartman
On Mon, Jun 26, 2017 at 11:27:22AM +1000, Tobin C. Harding wrote: > On Wed, Jun 14, 2017 at 04:30:34PM +1000, Tobin C. Harding wrote: > [snip] > > Please drop this series. Oh it's long dropped :) ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] staging: sm750fb: always take the lock

2017-06-25 Thread Greg Kroah-Hartman
On Sun, Jun 25, 2017 at 11:39:20PM +0200, AbdAllah-MEZITI wrote: > Signed-off-by: AbdAllah MEZITI I can't take patches without any changelog text, sorry. greg k-h ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 0/4] staging: ks7010: cfg80211 conversion

2017-06-25 Thread Tobin C. Harding
On Wed, Jun 14, 2017 at 04:30:34PM +1000, Tobin C. Harding wrote: [snip] Please drop this series. thanks, Tobin. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging: sm750fb: always take the lock

2017-06-25 Thread AbdAllah-MEZITI
Signed-off-by: AbdAllah MEZITI --- drivers/staging/sm750fb/sm750.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 386d4ad..4a22190 100644 ---

Re: [PATCH] staging: sm750fb: fix sparce warning.

2017-06-25 Thread Frans Klaver
On 25 June 2017 21:10:36 CEST, AbdAllah-MEZITI wrote: >This patch fixes the following sparce warnings: different lock contexts >for basic block. > >drivers/staging/sm750fb//sm750.c:159:13: warning: context imbalance in >'lynxfb_ops_fillrect' - different lock

[PATCH 2/2] vmbus: re-enable channel tasklet

2017-06-25 Thread kys
From: Stephen Hemminger This problem shows up in 4.11 when netvsc driver is removed and reloaded. The problem is that the channel is closed during module removal and the tasklet for processing responses is disabled. When module is reloaded the channel is reopened but

[PATCH 1/2] Tools: hv: vss: Skip freezing filesystems backed by loop

2017-06-25 Thread kys
From: Alex Ng Skip loop devices from the freeze/thaw operation. Signed-off-by: Alex Ng Signed-off-by: Vyronas Tsingaras Signed-off-by: K. Y. Srinivasan --- tools/hv/hv_vss_daemon.c |

[PATCH 0/2] Drivers: hv: Miscellaneous fixes

2017-06-25 Thread kys
From: K. Y. Srinivasan Miscellaneous fixes. Alex Ng (1): Tools: hv: vss: Skip freezing filesystems backed by loop Stephen Hemminger (1): vmbus: re-enable channel tasklet drivers/hv/channel.c |2 ++ tools/hv/hv_vss_daemon.c |7 +++ 2 files changed, 9

[PATCH 1/6] vmbus: simplify hv_ringbuffer_read

2017-06-25 Thread kys
From: Stephen Hemminger With new iterator functions (and the double mapping) the ring buffer read function can be greatly simplified. Signed-off-by: Stephen Hemminger Signed-off-by: K. Y. Srinivasan ---

[PATCH 6/6] vmbus: add prefetch to ring buffer iterator

2017-06-25 Thread kys
From: Stephen Hemminger When iterating over incoming ring elements from the host, prefetch the next descriptor so that it is cache hot. Signed-off-by: Stephen Hemminger Signed-off-by: K. Y. Srinivasan ---

[PATCH 2/6] vmbus: drop unused ring_buffer_info elements

2017-06-25 Thread kys
From: Stephen Hemminger The elements ring_data_start_offset and priv_write_index are not used. Signed-off-by: Stephen Hemminger Signed-off-by: K. Y. Srinivasan --- include/linux/hyperv.h |2 -- 1 files changed, 0

[PATCH 4/6] vmbus: eliminate duplicate cached index

2017-06-25 Thread kys
From: Stephen Hemminger Don't need cached read index anymore now that packet iterator is used. The iterator has the original read index until the visible read_index is updated. Signed-off-by: Stephen Hemminger Signed-off-by: K. Y. Srinivasan

[PATCH 5/6] vmbus: more host signalling avoidance

2017-06-25 Thread kys
From: Stephen Hemminger Don't signal host if it has disabled interrupts for that ring buffer. Check the feature bit to see if host supports pending send size flag. Signed-off-by: Stephen Hemminger Signed-off-by: K. Y. Srinivasan

[PATCH 0/6] Drivers: hv: vmbus: Ringbuffer cleanup and optimizations

2017-06-25 Thread kys
From: K. Y. Srinivasan This patch set removes unused bits from vmbus internals, and also does some optimization to the host signalling part of ring buffer logic. Stephen Hemminger (6): vmbus: simplify hv_ringbuffer_read vmbus: drop unused ring_buffer_info elements

[PATCH 3/6] vmbus: refactor hv_signal_on_read

2017-06-25 Thread kys
From: Stephen Hemminger The function hv_signal_on_read was defined in hyperv.h and only used in one place in ring_buffer code. Clearer to just move it inline there. Signed-off-by: Stephen Hemminger Signed-off-by: K. Y. Srinivasan

RE: [PATCH 0/6] Drivers: hv: vmbus: Ringbuffer cleanup and optimizations

2017-06-25 Thread KY Srinivasan
> -Original Message- > From: k...@exchange.microsoft.com [mailto:k...@exchange.microsoft.com] > Sent: Sunday, June 25, 2017 11:28 AM > To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > vkuzn...@redhat.com;

[PATCH] staging: sm750fb: fix sparce warning.

2017-06-25 Thread AbdAllah-MEZITI
This patch fixes the following sparce warnings: different lock contexts for basic block. drivers/staging/sm750fb//sm750.c:159:13: warning: context imbalance in 'lynxfb_ops_fillrect' - different lock contexts for basic block drivers/staging/sm750fb//sm750.c:231:9: warning: context imbalance in

[patch v4 1/3] tty: add function to convert device name to number

2017-06-25 Thread Okash Khawaja
The function converts strings like ttyS0 and ttyUSB0 to dev_t like (4, 64) and (188, 0). It does this by scanning tty_drivers list for corresponding device name and index. If the driver is not registered, this function returns -ENODEV. It also acquires tty_mutex. Signed-off-by: Okash Khawaja

[patch v4 2/3] staging: speakup: check and convert dev name or ser to dev_t

2017-06-25 Thread Okash Khawaja
This patch adds functionality to validate and convert either a device name or 'ser' memmber of synth into dev_t. Subsequent patch in this set will call it to convert user-specified device into device number. For device name, this patch does some basic sanity checks on the string passed in. It

[patch v4 3/3] staging: speakup: make ttyio synths use device name

2017-06-25 Thread Okash Khawaja
This patch introduces new module parameter, dev, which takes a string representing the device that the external synth is connected to, e.g. ttyS0, ttyUSB0 etc. This is then used to communicate with the synth. That way, speakup can support more than ttyS*. As of this patch, it only supports ttyS*,

[patch v4 0/3] staging: speakup: support more than ttyS*

2017-06-25 Thread Okash Khawaja
Hi, v3 of this patch set introduced the compiler warning: drivers//tty/tty_io.c:348:11: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] This version fixes that warning in patch 1/3. Thanks, Okash ___

[PATCH 0/6] Drivers: hv: vmbus: Ringbuffer cleanup and optimizations

2017-06-25 Thread kys
From: K. Y. Srinivasan This removes unused bits from vmbus internals, and also does some optimization to the host signalling part of ring buffer logic. Stephen Hemminger (6): vmbus: simplify hv_ringbuffer_read vmbus: drop unused ring_buffer_info elements vmbus:

Re: [staging:staging-testing 383/386] drivers//tty/tty_io.c:348:11: warning: assignment discards 'const' qualifier from pointer target type

2017-06-25 Thread Greg Kroah-Hartman
On Sun, Jun 25, 2017 at 06:39:08PM +0100, Okash Khawaja wrote: > Hi, > > On Mon, Jun 26, 2017 at 01:24:43AM +0800, kbuild test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > > staging-testing > > head: 2a38eb6552c934a13e1f1b8c579147fac9c94efb > >

Re: [staging:staging-testing 383/386] drivers//tty/tty_io.c:348:11: warning: assignment discards 'const' qualifier from pointer target type

2017-06-25 Thread Okash Khawaja
Hi, On Mon, Jun 26, 2017 at 01:24:43AM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git > staging-testing > head: 2a38eb6552c934a13e1f1b8c579147fac9c94efb > commit: 9a71d0257f1f63d64015f7d2c25485272df4d535 [383/386] tty: add function

[staging:staging-testing 383/386] drivers//tty/tty_io.c:348:11: warning: assignment discards 'const' qualifier from pointer target type

2017-06-25 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 2a38eb6552c934a13e1f1b8c579147fac9c94efb commit: 9a71d0257f1f63d64015f7d2c25485272df4d535 [383/386] tty: add function to convert device name to number config: blackfin-allyesconfig (attached as

[PATCH 07/10] hyper-v: globalize vp_index

2017-06-25 Thread kys
From: Vitaly Kuznetsov To support implementing remote TLB flushing on Hyper-V with a hypercall we need to make vp_index available outside of vmbus module. Rename and globalize. Signed-off-by: Vitaly Kuznetsov Reviewed-by: Andy Shevchenko

[PATCH 08/10] x86/hyper-v: use hypercall for remote TLB flush

2017-06-25 Thread kys
From: Vitaly Kuznetsov Hyper-V host can suggest us to use hypercall for doing remote TLB flush, this is supposed to work faster than IPIs. Implementation details: to do HvFlushVirtualAddress{Space,List} hypercalls we need to put the input somewhere in memory and we don't

[PATCH 10/10] tracing/hyper-v: trace hyperv_mmu_flush_tlb_others()

2017-06-25 Thread kys
From: Vitaly Kuznetsov Add Hyper-V tracing subsystem and trace hyperv_mmu_flush_tlb_others(). Tracing is done the same way we do xen_mmu_flush_tlb_others(). Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan ---

[PATCH 09/10] x86/hyper-v: support extended CPU ranges for TLB flush hypercalls

2017-06-25 Thread kys
From: Vitaly Kuznetsov Hyper-V hosts may support more than 64 vCPUs, we need to use HVCALL_FLUSH_VIRTUAL_ADDRESS_SPACE_EX/LIST_EX hypercalls in this case. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan ---

[PATCH 02/10] x86/hyper-v: stash the max number of virtual/logical processor

2017-06-25 Thread kys
From: Vitaly Kuznetsov Max virtual processor will be needed for 'extended' hypercalls supporting more than 64 vCPUs. While on it, unify on 'Hyper-V' in mshyperv.c as we currently have a mix, report acquired misc features as well. Signed-off-by: Vitaly Kuznetsov

[PATCH 05/10] hyper-v: use fast hypercall for HVCALL_SIGNAL_EVENT

2017-06-25 Thread kys
From: Vitaly Kuznetsov We need to pass only 8 bytes of input for HvSignalEvent which makes it a perfect fit for fast hypercall. hv_input_signal_event_buffer is not needed any more and hv_input_signal_event is converted to union for convenience. Signed-off-by: Vitaly

[PATCH 06/10] x86/hyper-v: implement rep hypercalls

2017-06-25 Thread kys
From: Vitaly Kuznetsov Rep hypercalls are normal hypercalls which perform multiple actions at once. Hyper-V guarantees to return exectution to the caller in not more than 50us and the caller needs to use hypercall continuation. Touch NMI watchdog between hypercall

[PATCH 03/10] x86/hyper-v: make hv_do_hypercall() inline

2017-06-25 Thread kys
From: Vitaly Kuznetsov We have only three call sites for hv_do_hypercall() and we're going to change HVCALL_SIGNAL_EVENT to doing fast hypercall so we can inline this function for optimization. Hyper-V top level functional specification states that r9-r11 registers and

[PATCH 01/10] x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set

2017-06-25 Thread kys
From: Vitaly Kuznetsov Code is arch/x86/hyperv/ is only needed when CONFIG_HYPERV is set, the 'basic' support and detection lives in arch/x86/kernel/cpu/mshyperv.c which is included when CONFIG_HYPERVISOR_GUEST is set. Signed-off-by: Vitaly Kuznetsov

[PATCH 04/10] x86/hyper-v: fast hypercall implementation

2017-06-25 Thread kys
From: Vitaly Kuznetsov Hyper-V supports 'fast' hypercalls when all parameters are passed through registers. Implement an inline version of a simpliest of these calls: hypercall with one 8-byte input and no output. Signed-off-by: Vitaly Kuznetsov

[PATCH 00/10] Hyper-V: paravirtualized remote TLB flushing and hypercall improvements

2017-06-25 Thread kys
From: K. Y. Srinivasan Hyper-V supports hypercalls for doing local and remote TLB flushing and gives its guests hints when using hypercall is preferred. While doing hypercalls for local TLB flushes is probably not practical (and is not being suggested by modern Hyper-V

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-25 Thread Sudip Mukherjee
On Sun, Jun 25, 2017 at 04:27:23PM +0200, Greg Kroah-Hartman wrote: > On Sun, Jun 25, 2017 at 02:54:29PM +0100, Sudip Mukherjee wrote: > > On Sun, Jun 25, 2017 at 02:54:51PM +0200, Greg Kroah-Hartman wrote: > > > On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote: > > > > On Mon, Jun

Re: [PATCH v2] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

2017-06-25 Thread Srishti Sharma
On Sun, Jun 25, 2017 at 8:01 PM, Greg KH wrote: > On Sat, Jun 24, 2017 at 08:58:10AM +0530, srishti sharma wrote: >> Fixed alignment so that it matched open parenthesis. >> >> Signed-off-by: srishti sharma > > Does your legal name not have

[PATCH v2] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

2017-06-25 Thread Srishti Sharma
Fixed alignment so that it matched open parenthesis. Signed-off-by: Srishti Sharma --- Changes in v2: -Fix all checks of the type "alignment should match open parenthesis" for a file in the same patch. .../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 18

Re: [PATCH] staging: wlan-ng: Fix sparse warning: incorrect type in assignment This patch fixes the following sparse warning

2017-06-25 Thread Greg KH
On Fri, Jun 23, 2017 at 04:21:54AM +0200, AbdAllah-MEZITI wrote: > drivers/staging/wlan-ng/prism2mgmt.c:188:25: warning: incorrect type in > assignment (different base types) > drivers/staging/wlan-ng/prism2mgmt.c:188:25:expected unsigned short > [unsigned] [addressable] [usertype] tx_rate >

Re: [PATCH v2] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

2017-06-25 Thread Greg KH
On Sat, Jun 24, 2017 at 08:58:10AM +0530, srishti sharma wrote: > Fixed alignment so that it matched open parenthesis. > > Signed-off-by: srishti sharma Does your legal name not have capital letters? Please fix and resend. thanks, greg k-h

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-25 Thread Greg Kroah-Hartman
On Sun, Jun 25, 2017 at 02:54:29PM +0100, Sudip Mukherjee wrote: > On Sun, Jun 25, 2017 at 02:54:51PM +0200, Greg Kroah-Hartman wrote: > > On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote: > > > On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote: > > > > From: Teddy

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-25 Thread Sudip Mukherjee
On Sun, Jun 25, 2017 at 02:54:51PM +0200, Greg Kroah-Hartman wrote: > On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote: > > On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote: > > > From: Teddy Wang > > > > > > If vesafb is enabled in the

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-25 Thread Greg Kroah-Hartman
On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote: > On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote: > > From: Teddy Wang > > > > If vesafb is enabled in the config then /dev/fb0 is created by vesa > > and this sm750 driver gets fb1,

[PATCH] staging: lustre: replace kmalloc with kmalloc_array

2017-06-25 Thread Denis Petrovic
This patch fixes the following checkpatch.pl warning: WARNING: Prefer kmalloc_array over kmalloc with multiply Signed-off-by: Denis Petrovic --- drivers/staging/lustre/lnet/libcfs/linux/linux-tracefile.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-25 Thread Sudip Mukherjee
On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote: > From: Teddy Wang > > If vesafb is enabled in the config then /dev/fb0 is created by vesa > and this sm750 driver gets fb1, fb2. But we need to be fb0 and fb1 to > effectively work with xorg. > So if

[PATCH v3 3/6] staging: ccree: remove unused function

2017-06-25 Thread Gilad Ben-Yossef
The function set_ack_last was not used anywhere. Remove it. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/cc_hw_queue_defs.h | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h

[PATCH v3 5/6] staging: ccree: add DT bus coherency detection

2017-06-25 Thread Gilad Ben-Yossef
The ccree driver has build time configurable support to work on top of coherent (e.g. ACP) vs. none coherent bus connections. Turn it to run-time configurable option based on device tree. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/Kconfig | 9

[PATCH v3 2/6] staging: ccree: register setkey for none hash macs

2017-06-25 Thread Gilad Ben-Yossef
The original ccree driver was registering a useless setkey method even for non-MAC hash transformations. Somewhere around v4.9 a check was added that failed hash operations if a setkey method was registered but was not called, so during the initial upstream port code was added to only register the

[PATCH v3 6/6] staging: ccree: use signal safe completion wait

2017-06-25 Thread Gilad Ben-Yossef
We were waiting for a completion notification of HW DMA operation using an interruptible wait which can result in data corruption if a signal interrupted us while DMA was not yet completed. Fix this by moving to uninterrupted wait. Fixes: abefd6741d ("staging: ccree: introduce CryptoCell HW

[PATCH v3 4/6] staging: ccree: add clock management support

2017-06-25 Thread Gilad Ben-Yossef
Some SoC which implement CryptoCell have a dedicated clock tied to it, some do not. Implement clock support if exists based on device tree data and tie power management to it. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/Makefile | 2 +-

[PATCH v3 1/6] staging: ccree: fix hash import/export

2017-06-25 Thread Gilad Ben-Yossef
Hash import and export was saving and restoring the wrong context and therefore disabled. Fix it by restoring intermediate digest and additional state needed. The hash and mac transform now pass testmgr partial hash tests. Signed-off-by: Gilad Ben-Yossef ---

[PATCH v3 0/6] staging: ccree: bug fixes and TODO items for 4.13

2017-06-25 Thread Gilad Ben-Yossef
An assortment of bug fixes and staging TODO items. Highlights includes the driver passing crypto testmgr boot tests and relying on device tree for various HW config options as opposed to build time configuration. CC: Dan Carpenter Gilad Ben-Yossef (6): staging:

Re: [PATCH v2 2/7] staging: ccree: register setkey for none hash macs

2017-06-25 Thread Gilad Ben-Yossef
On Fri, Jun 23, 2017 at 7:29 PM, Greg Kroah-Hartman wrote: > On Thu, Jun 22, 2017 at 04:36:56PM +0300, Gilad Ben-Yossef wrote: >> Fix a bug where the transformation init code did >> not register a setkey method for none hash based MACs. > > "none hash based MACs"? Is

Re: [PATCH v2 1/7] staging: ccree: fix hash import/export

2017-06-25 Thread Gilad Ben-Yossef
On Thu, Jun 22, 2017 at 4:58 PM, Dan Carpenter wrote: > On Thu, Jun 22, 2017 at 04:36:55PM +0300, Gilad Ben-Yossef wrote: >> static int ssi_ahash_export(struct ahash_request *req, void *out) >> { >> struct crypto_ahash *ahash = crypto_ahash_reqtfm(req); >>