[PATCH] Staging: unisys: visorbus: Fix coding style warning from checkpatch.pl.

Replace the literal function name "visorbus_create_instance" with the format specifier "%s" so it can be dynamically filled by the __func__ macro. Signed-off-by: Quytelda Kahja --- drivers/staging/unisys/visorbus/visorbus_main.c | 2 +- 1 file changed, 1 insertion(+), 1

RE: [PATCH] Replace the literal function name "visorbus_create_instance" with the format specifier "%s" so it can be dynamically filled by the __func__ macro.

> -Original Message- > From: Quytelda Kahja [mailto:quyte...@tamalin.org] > Sent: Tuesday, June 27, 2017 5:18 PM > To: Kershner, David A ; > gre...@linuxfoundation.org > Cc: de...@driverdev.osuosl.org; linux-ker...@vger.kernel.org; Quytelda > Kahja

[PATCH] Staging: ion: fix code style warning from NULL comparisons

This patch replaces several instances where a pointer is compared to NULL (i.e., `ptr == NULL`) with `!ptr`, which is preferred. Signed-off-by: Quytelda Kahja --- drivers/staging/android/ion/ion.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH] Replace the literal function name "visorbus_create_instance" with the format specifier "%s" so it can be dynamically filled by the __func__ macro.

Signed-off-by: Quytelda Kahja --- drivers/staging/unisys/visorbus/visorbus_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c index

RE: [PATCH] Staging: visorbus: Fix coding style warning from checkpatch.pl.

> -Original Message- > From: Quytelda Kahja [mailto:quyte...@tamalin.org] > Sent: Monday, June 26, 2017 7:32 PM > To: Kershner, David A ; > gre...@linuxfoundation.org; Sell, Timothy C ; > Binder, David Anthony >

Re: [PATCH v2 00/15] staging: fsl-mc: clean up header files

On Tue, Jun 27, 2017 at 6:00 PM, gregkh wrote: > On Tue, Jun 27, 2017 at 05:33:21PM +0200, Arnd Bergmann wrote: >> On Tue, Jun 27, 2017 at 4:41 PM, wrote: >> > From: Laurentiu Tudor >> > >> > This patch series

Re: [PATCH 3/3] staging/lustre, 9p, ceph, cifs, dlm: negate remote pids for F_GETLK

On Tue, 2017-06-27 at 11:18 -0400, Benjamin Coddington wrote: > In the previous patch, the locks API will expect that if a filesystem > returns a remote pid as opposed to a local pid for F_GETLK, that remote pid > will be <= 0. This signifies that the pid is remote, and the locks API > will

RE: [PATCH] staging: unisys: visorbus: constify visorchipset_parahotplug_group

> -Original Message- > From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On > Behalf Of Arvind Yadav > Sent: Friday, June 23, 2017 2:31 AM > To: gre...@linuxfoundation.org; Sell, Timothy C > ; Wadgaonkar, Sameer Laxmikant >

RE: [PATCH] staging: unisys: visorbus: constify channel_attr_grp and dev_attr_grp

> -Original Message- > From: Arvind Yadav [mailto:arvind.yadav...@gmail.com] > Sent: Friday, June 23, 2017 3:37 AM > To: Kershner, David A ; > gre...@linuxfoundation.org; Thompson, Bryan E. > ; Wadgaonkar, Sameer Laxmikant >

Re: [PATCH v2 00/15] staging: fsl-mc: clean up header files

On Tue, Jun 27, 2017 at 05:33:21PM +0200, Arnd Bergmann wrote: > On Tue, Jun 27, 2017 at 4:41 PM, wrote: > > From: Laurentiu Tudor > > > > This patch series contain mainly clean-ups of the mc-bus header files > > with the final goal of

Re: [PATCH v2 00/15] staging: fsl-mc: clean up header files

On Tue, Jun 27, 2017 at 4:41 PM, wrote: > From: Laurentiu Tudor > > This patch series contain mainly clean-ups of the mc-bus header files > with the final goal of reorganizing them in just 2 files: a public > and a private one, as per GregKH

[PATCH] staging: fsl-mc: remove stale Makefile entry for dpmng.o

Removing the file causes a build failure: make[5]: *** No rule to make target 'drivers/staging/fsl-mc/bus/dpmng.o', needed by 'drivers/staging/fsl-mc/bus/mc-bus-driver.o'. This adapts the Makefile as needed. Fixes: b065307fe0ad ("staging: fsl-mc: remove dpmng API files") Signed-off-by: Arnd

[PATCH 1/3] fs/locks: Use allocation rather than the stack in fcntl_getlk()

Struct file_lock is fairly large, so let's save some space on the stack by using an allocation for struct file_lock in fcntl_getlk(), just as we do for fcntl_setlk(). Signed-off-by: Benjamin Coddington --- fs/locks.c | 46 ++ 1

[PATCH 0/3 v6] Fixups for l_pid

LTP fcntl tests (fcntl11 fcntl14 fcntl17 fcntl19 fcntl20 fcntl21) have been failing for NFSv4 mounts due to an unexpected l_pid. What follows are some fixups: v2: - Rebase onto linux-next - Revert back to using the stack in locks_mandatory_area(), and fixup patch description for 1/3

[PATCH 3/3] staging/lustre, 9p, ceph, cifs, dlm: negate remote pids for F_GETLK

In the previous patch, the locks API will expect that if a filesystem returns a remote pid as opposed to a local pid for F_GETLK, that remote pid will be <= 0. This signifies that the pid is remote, and the locks API will forego translating that pid into the pid namespace of the local calling

[PATCH 2/3] fs/locks: Remove fl_nspid and use fs-specific l_pid for remote locks

Since commit c69899a17ca4 "NFSv4: Update of VFS byte range lock must be atomic with the stateid update", NFSv4 has been inserting locks in rpciod worker context. The result is that the file_lock's fl_nspid is the kworker's pid instead of the original userspace pid. The fl_nspid is only used to

[PATCH v2 12/15] staging: fsl-mc: fix a few implicit includes

From: Laurentiu Tudor Few files using byte order macros but did not explicitly included the required kernel header, so add it. Signed-off-by: Laurentiu Tudor --- v2: - no changes drivers/staging/fsl-mc/bus/dpbp.c | 1 +

[PATCH v2 10/15] staging: fsl-mc: move rest of mc-bus.h to private header

From: Laurentiu Tudor All the mc-bus.h contents is only used privately in the bus driver so move everything to the private header and get rid of the mc-bus.h header file. Signed-off-by: Laurentiu Tudor --- v2: - no changes

[PATCH v2 15/15] staging: fsl-mc: make dprc.h header private

From: Laurentiu Tudor dprc.h is only used in the mc bus driver so move it together with the sources thus making it private. Signed-off-by: Laurentiu Tudor --- v2: - no changes drivers/staging/fsl-mc/bus/dprc.c | 2 +-

[PATCH v2 14/15] staging: fsl-mc: move mc-cmd.h contents in the public header

From: Laurentiu Tudor mc-cmd.h contains some low level functions used to encode and decode commands to the MC. They are used by the drivers so move them to the public headers and get rid of the mc-cmd.h header. Signed-off-by: Laurentiu Tudor

[PATCH v2 11/15] staging: fsl-mc: remove dpmng API files

From: Laurentiu Tudor dpmng.h & dpmng.c files expose an API of just one function which is only used by the bus driver. Move that single API in the bus source as static and remove the two files. Signed-off-by: Laurentiu Tudor --- v2: - fix

[PATCH v2 09/15] staging: fsl-mc: move couple of definitions to public header

From: Laurentiu Tudor Define dev_is_fsl_mc() and the bus type definition (fsl_mc_bus_type) are used externally so move them to the public header. Signed-off-by: Laurentiu Tudor --- v2: - no changes drivers/staging/fsl-mc/include/mc-bus.h | 9

[PATCH v2 13/15] staging: fsl-mc: move mc-sys.h contents in the public header

From: Laurentiu Tudor mc-sys.h contains the API to send commands to the MC and is used by drivers. Move it to the public headers and get rid of the mc-sys.h header. Signed-off-by: Laurentiu Tudor --- v2: - no changes

[PATCH v2 07/15] staging: fsl-mc: turn several exported functions static

From: Laurentiu Tudor They are never used outside the source they are implemented in and very likely never will, so it's safe to make them static. Signed-off-by: Laurentiu Tudor --- v2: - no changes drivers/staging/fsl-mc/bus/dprc-driver.c |

[PATCH v2 06/15] staging: fsl-mc: delete prototype of unimplemented function

From: Laurentiu Tudor The function fsl_mc_bus_exists() has a prototype but is never implemented so delete it from the header file. Signed-off-by: Laurentiu Tudor --- v2: - no changes drivers/staging/fsl-mc/include/mc-bus.h | 2 -- 1 file

[PATCH v2 08/15] staging: fsl-mc: move irq domain creation prototype to public header

From: Laurentiu Tudor fsl_mc_msi_create_irq_domain() will is used from the irqchip glue code so it needs to be in the public headers. Signed-off-by: Laurentiu Tudor --- v2: - no changes drivers/staging/fsl-mc/include/mc-bus.h | 7 ---

[PATCH v2 05/15] staging: fsl-mc: delete duplicated function prototypes

From: Laurentiu Tudor These functions already have their prototypes in fsl-mc-private.h header file so delete them from mc-bus.h. Signed-off-by: Laurentiu Tudor --- v2: - no changes drivers/staging/fsl-mc/include/mc-bus.h | 8 1

[PATCH v2 04/15] staging: fsl-mc: decouple the mc-bus public headers from dprc.h

From: Laurentiu Tudor In its current form, the public headers of the mc-bus depend only on a structure "dprc_obj_desc" defined in dprc.h. Move it to the bus public header together with its associated defines and, in order to keep the naming prefixes consistent rename it

[PATCH v2 03/15] staging: fsl-mc: drop useless #includes

From: Laurentiu Tudor These couple of header files are not needed in the source so remove them. Signed-off-by: Laurentiu Tudor --- v2: - no changes drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 2 -- 1 file changed, 2 deletions(-) diff

[PATCH v2 02/15] staging: fsl-mc: be consistent when checking strcmp() return

From: Laurentiu Tudor Stick to one way of checking the return code of strcmp(): use '!'. This was suggested in a review comment. Signed-off-by: Laurentiu Tudor --- v2: - new patch drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 6 +++--- 1

[PATCH v2 00/15] staging: fsl-mc: clean up header files

From: Laurentiu Tudor This patch series contain mainly clean-ups of the mc-bus header files with the final goal of reorganizing them in just 2 files: a public and a private one, as per GregKH suggestion [1]. Here's a summary of the header reorganizing: - existing mc.h

[PATCH v2 01/15] staging: fsl-mc: move comparison before strcmp() call

From: Laurentiu Tudor Move comparison before the strcmp() in this if statement, and slightly increase efficiency by not making the strcmp() each time the if gets evaluated but only when the comparison is true. This was suggested in a review comment. Signed-off-by:

[PATCH] staging: rtl8192e: fix spelling mistake: "respose" -> "response"

From: Colin Ian King Trivial fix to spelling mistake in netdev_info message and split line to clean up an checkpatch line too wide warning. Signed-off-by: Colin Ian King --- drivers/staging/rtl8192e/rtllib_softmac.c | 3 ++- 1 file changed,

Re: [PATCH v3] staging: vboxvideo: Add vboxvideo to drivers/staging

Hello Hans, 26.06.2017 18:06, Hans de Goede wrote: > Hi, > > On 23-06-17 11:31, Daniel Vetter wrote: >> On Thu, Jun 22, 2017 at 11:11:37AM +0200, Hans de Goede wrote: [vboxvideo driver submission information to staging.] >> >> In the end it's up to you, but our experience in drm with -staging

[PATCH 4/4] Staging: rtl8712 : ieee80211.c: fixed camelcase coding

The following variables and struct name are renamed to avoid camelcase issue Configuration to configuration BeaconPeriod to beacon_period DSConfig to ds_config ATIMWindowto atim_window pnic_Config to pnic_config FHConfig to fh_config HopPatternto hop_pattern HopSetto

Re: [PATCH 4/4] Staging: rtl8712 : osdep_intf.h: fix macro coding style issue

On Tue, Jun 27, 2017 at 9:48 AM, Jaya Durga wrote: > Fix checkpatch.pl warning of the form "CHECK" Macro argument 'x' > may be better as '(x)' to avoid precedence issues. > > Signed-off-by: Jaya Durga > --- > drivers/staging/rtl8712/osdep_intf.h | 5 - > 1

[PATCH] staging: wilc1000: fix spelling mistake: "dissconect" -> "disconnect"

From: Colin Ian King Trivial fix to spelling mistake in netdev_err error message Signed-off-by: Colin Ian King --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 4/4] Staging: rtl8712 : osdep_intf.h: fix macro coding style issue

Fix checkpatch.pl warning of the form "CHECK" Macro argument 'x' may be better as '(x)' to avoid precedence issues. Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/osdep_intf.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v2 1/2] Staging: rtl8712 : os_intfs.c: use octal permission representation

Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. Signed-off-by: Jaya Durga --- drivers/staging/rtl8712/os_intfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 14/14] staging: ccree: fix block comment style

Align block comments according to coding style. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/cc_hw_queue_defs.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h

[PATCH 13/14] staging: ccree: remove/add (un)needed blank lines

Remove or add blank lines as needed to match coding style. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c| 20 +-- drivers/staging/ccree/ssi_aead.h| 4 drivers/staging/ccree/ssi_buffer_mgr.c | 7 ---

[PATCH 08/14] staging: ccree: fix pointer location

Fix location of pointer in variables definitions and dereference. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.h| 4 ++-- drivers/staging/ccree/ssi_buffer_mgr.c | 12 ++-- drivers/staging/ccree/ssi_cipher.c | 8

[PATCH 12/14] staging: ccree: remove unused type CCFipsSyncStatus_t

The CCFipsSyncStatus_t type was not being used in the code. Remove it. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_fips_local.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/ccree/ssi_fips_local.h

[PATCH 10/14] staging: ccree: remove custom type ssi_fips_error_t

Replace custom type ssi_fips_error_t with underlying enum. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_fips.c | 4 ++-- drivers/staging/ccree/ssi_fips.h | 6 +++--- drivers/staging/ccree/ssi_fips_ext.c | 6 +++---

[PATCH 09/14] staging: ccree: remove custom type tdes_keys_t

Replace references to type tdes_keys_t with struct tdes_keys. _ Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_cipher.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ccree/ssi_cipher.c

[PATCH 05/14] staging: ccree: no need for braces for single statements

Fix several cases of needless braces around single statement blocks. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c| 38 +++--- drivers/staging/ccree/ssi_buffer_mgr.c | 70 ++---

[PATCH 11/14] staging: ccree: remove custom type ssi_fips_state_t

Replace custom type ssi_fips_state_t with underlying enum. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_fips.c | 4 ++-- drivers/staging/ccree/ssi_fips.h | 6 +++--- drivers/staging/ccree/ssi_fips_ext.c | 6 +++---

[PATCH 06/14] staging: ccree: fix unmatched if/else braces

Fix mismatched braces between if and else. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_buffer_mgr.c | 3 ++- drivers/staging/ccree/ssi_cipher.c | 7 +++ 2 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH 07/14] staging: ccree: remove comparisons to NULL

Remove explicit comparisons to NULL in ccree driver. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c| 34 - drivers/staging/ccree/ssi_buffer_mgr.c | 44 -

[PATCH 04/14] staging: ccree: remove redundant blank lines

Remove redundant blank lines in brace blocks Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c| 2 -- drivers/staging/ccree/ssi_buffer_mgr.c | 8 drivers/staging/ccree/ssi_cipher.c | 5 - drivers/staging/ccree/ssi_driver.c

[PATCH 01/14] staging: ccree: fix missing or redundant spaces

Add and/or remove redundant and/or missing spaces in ccree source Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/Kconfig | 2 +- drivers/staging/ccree/ssi_aead.c| 38 drivers/staging/ccree/ssi_aead.h| 12 +--

[PATCH 03/14] staging: ccree: fix else placement

Fix cases where the else clause was not located correctly after the if brace. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_buffer_mgr.c | 3 +-- drivers/staging/ccree/ssi_pm.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH 02/14] staging: ccree: drop comparsion to true/false

Fix cases in ccree where explicit comparsion to true/false was made. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c | 18 +- drivers/staging/ccree/ssi_buffer_mgr.c | 20 ++-- drivers/staging/ccree/ssi_cipher.c

[PATCH 00/14] staging: ccree: coding style fixes

Fix a bunch of coding style across the whole ccree driver Gilad Ben-Yossef (14): staging: ccree: fix missing or redundant spaces staging: ccree: drop comparsion to true/false staging: ccree: fix else placement staging: ccree: remove redundant blank lines staging: ccree: no need for

[PATCH] Stagingdriver cctree: Fix for checkpatch warning

From: Bincy K Philip Trivial fix for Line over 80 characters Moved the comment to top of the definition --- drivers/staging/ccree/cc_hw_queue_defs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h