[PATCH] staging: fsl-mc: fix resource_size.cocci warnings

2017-07-19 Thread Julia Lawall
Use resource_size function on resource object instead of explicit computation. Generated by: scripts/coccinelle/api/resource_size.cocci Fixes: a037b7ec2eb7 ("staging: fsl-mc: allow the driver compile multi-arch") CC: Laurentiu Tudor Signed-off-by: Julia Lawall

Re: [PATCH net-next 0/8] netvsc: lockdep and related fixes

2017-07-19 Thread David Miller
From: Stephen Hemminger Date: Wed, 19 Jul 2017 11:53:11 -0700 > These fix sparse and lockdep warnings from netvsc driver. > Targeting these at net-next since no actual related failures > have been observed in non-debug kernels. Series applied, thanks Stephen.

[PATCH] staging: rtl8188eu: Move { after function to new line

2017-07-19 Thread Munir Contractor
Fix an error detected by checkpatch.pl on line 75 and move the opening brace after the function signature to a new line. Signed-off-by: Munir Contractor --- drivers/staging/rtl8188eu/include/rtw_ioctl.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH -next] staging: pi433: depends on SPI

2017-07-19 Thread Randy Dunlap
From: Randy Dunlap The pi433 driver uses SPI interfaces so it should depend on SPI. Also, the "default n" can be removed since that is already the default. Fixes these build errors when SPI is not enabled: drivers/staging/pi433/pi433_if.o: In function `pi433_probe':

Re: [PATCH v1 4/6] vmbus: Switch to use new generic UUID API

2017-07-19 Thread Andy Shevchenko
On Wed, Jul 19, 2017 at 11:18 PM, Haiyang Zhang wrote: >> struct hv_fcopy_hdr { >> __u32 operation; >> - uuid_le service_id0; /* currently unused */ >> - uuid_le service_id1; /* currently unused */ >> + __u8 service_id0[16]; /* currently unused */ >> +

Re: [PATCH] drivers: staging: comedi: Add ftrace support

2017-07-19 Thread Piotr Gregor
On Wed, Jul 19, 2017 at 2:25 PM, Dan Carpenter wrote: > Everyone please delete this confidential email. Piotr is leakier than > the Trump administration! > Sanity level of Dan's assessments is less than half the average level of Hillary's supporter!

RE: [PATCH] staging: lustre: ko2iblnd: check copy_from_iter/copy_to_iter return code

2017-07-19 Thread Shehata, Amir
The changes look good to me. -Original Message- From: James Simmons [mailto:jsimm...@infradead.org] Sent: Saturday, July 15, 2017 8:32 AM To: Greg Kroah-Hartman ; de...@driverdev.osuosl.org; Dilger, Andreas ; Drokin, Oleg

RE: [PATCH v1 4/6] vmbus: Switch to use new generic UUID API

2017-07-19 Thread Haiyang Zhang
> -Original Message- > From: Andy Shevchenko [mailto:andriy.shevche...@linux.intel.com] > Sent: Wednesday, July 19, 2017 2:29 PM > To: linux-a...@vger.kernel.org; de...@linuxdriverproject.org; > sparmaintai...@unisys.com; de...@driverdev.osuosl.org; linux- > wirel...@vger.kernel.org;

CONGRATULATIONS

2017-07-19 Thread FROM SAMSUNG
CONGRATULATIONS YOUR MOBILE NUMBER WON 500,000 CASH FROM SAMSUNG PROMO CLAIMS SEND YOUR. NAME MOBILE NO AGE SEX ADDS REPLY TO: deptsamsung06@hotmail.com ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH 2/3][staging-next] staging: pi433: Make functions rf69_set_bandwidth_intern static

2017-07-19 Thread Marcus Wolf
Hi Colin, thanks for your patches. #1 is fine. Same fix was provided by Joseph Wright. I tested it and it works fine. #2 looks fine, too. Conerning #3, I would suggest to declare rf69_set_dc_cut_off_frequency static, as well. Would you prefer to remove rf69_set_dc_cut_off_frequency from the

Re: [PATCH 2/2] Staging: pi433: check error after kthread_run()

2017-07-19 Thread Marcus Wolf
Hi Joseph, tested your patch and didn't observe a problem. Thanks for your help :-) Marcus > Joseph Wright hat am 16. Juli 2017 um 16:48 > geschrieben: > > > Error should be checked with IS_ERR after calling kthread_run() > instead of comparing the returned pointer to

Re: [PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-07-19 Thread Rafael J. Wysocki
On Wed, Jul 19, 2017 at 8:28 PM, Andy Shevchenko wrote: > There are new types and helpers that are supposed to be used in new code. > > As a preparation to get rid of legacy types and API functions do > the conversion here. Please talk to Mika about this one.

Re: [PATCH] netvsc: Remove redundant use of ipv6_hdr()

2017-07-19 Thread Dan Carpenter
On Wed, Jul 19, 2017 at 01:48:03PM -0400, Mohammed Gamal wrote: > It's worth pointing out that MAINTAINERS points that files under > drivers/net/hyperv are to be sent to de...@linuxdriverproject.org. > Perhaps that should be updated. get_maintainer.pl gives you both because drivers/net/ is

RE: [PATCH net-next 3/8] netvsc: change order of steps in setting queues

2017-07-19 Thread Haiyang Zhang
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, July 19, 2017 2:53 PM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > Cc: de...@linuxdriverproject.org;

[bug report] binder: guarantee txn complete / errors delivered in-order

2017-07-19 Thread Dan Carpenter
Hello Todd Kjos, The patch 26549d177410: "binder: guarantee txn complete / errors delivered in-order" from Jun 29, 2017, leads to the following static checker warning: drivers/android/binder.c:3622 binder_thread_read() error: uninitialized symbol 'cmd'. drivers/android/binder.c

[PATCH net-next 5/8] netvsc: use ERR_PTR to avoid dereference issues

2017-07-19 Thread Stephen Hemminger
The rndis_filter_device_add function is called both in probe context and RTNL context,and creates the netvsc_device inner structure. It is easier to get the RTNL lock annotation correct if it returns the object directly, rather than implicitly by updating network device private data.

[PATCH net-next 7/8] netvsc: save pointer to parent netvsc_device in channel table

2017-07-19 Thread Stephen Hemminger
Keep back pointer in the per-channel data structure to avoid any possible RCU related issues when napi poll is called but netvsc_device is in RCU limbo. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 1 + drivers/net/hyperv/netvsc.c | 3 ++- 2

[PATCH net-next 2/8] netvsc: add some rtnl_dereference annotations

2017-07-19 Thread Stephen Hemminger
In a couple places RTNL is held, and the netvsc_device pointer is acquired without annotation. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 5 +++-- drivers/net/hyperv/netvsc_drv.c | 7 --- 2 files changed, 7 insertions(+), 5 deletions(-)

[PATCH net-next 8/8] netvsc: add rtnl annotations in rndis

2017-07-19 Thread Stephen Hemminger
The rndis functions are used when changing device state. Therefore the references from network device to internal state are protected by RTNL mutex. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 6 -- drivers/net/hyperv/netvsc.c | 6

[PATCH net-next 1/8] netvsc: force link update after MTU change

2017-07-19 Thread Stephen Hemminger
If two MTU changes are in less than update interval (2 seconds), then the netvsc network device may get stuck with no carrier. The netvsc driver debounces link status events which is fine for unsolicited updates, but blocks getting the update after down/up from MTU reinitialization.

[PATCH net-next 0/8] netvsc: lockdep and related fixes

2017-07-19 Thread Stephen Hemminger
These fix sparse and lockdep warnings from netvsc driver. Targeting these at net-next since no actual related failures have been observed in non-debug kernels. Stephen Hemminger (8): netvsc: force link update after MTU change netvsc: add some rtnl_dereference annotations netvsc: change

[PATCH net-next 6/8] netvsc: need rcu_derefence when accessing internal device info

2017-07-19 Thread Stephen Hemminger
The netvsc_device structure should be accessed by rcu_dereference in the send path. Change arguments to netvsc_send() to make this easier to do correctly. Remove no longer needed hv_device_to_netvsc_device. Signed-off-by: Stephen Hemminger ---

[PATCH net-next 4/8] netvsc: change logic for change mtu and set_queues

2017-07-19 Thread Stephen Hemminger
Use device detach/attach to ensure that no packets are handed to device during state changes. Call rndis_filter_open/close directly as part of later VF related changes. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 1 +

[PATCH net-next 3/8] netvsc: change order of steps in setting queues

2017-07-19 Thread Stephen Hemminger
This fixes the error unwind logic for incorrect number of queues. If netif_set_real_num_XX_queues failed then rndis_filter_device_add would have been called twice. Since input arguments are already ranged checked this is a hypothetical only problem, not possible in actual code. Signed-off-by:

RE: [PATCH] netvsc: Remove redundant use of ipv6_hdr()

2017-07-19 Thread Haiyang Zhang
> -Original Message- > From: Mohammed Gamal [mailto:mga...@redhat.com] > Sent: Wednesday, July 19, 2017 1:48 PM > To: Stephen Hemminger > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger

[PATCH v1 4/6] vmbus: Switch to use new generic UUID API

2017-07-19 Thread Andy Shevchenko
There are new types and helpers that are supposed to be used in new code. As a preparation to get rid of legacy types and API functions do the conversion here. Cc: "K. Y. Srinivasan" Cc: Haiyang Zhang Cc: Stephen Hemminger

[PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-07-19 Thread Andy Shevchenko
There are new types and helpers that are supposed to be used in new code. As a preparation to get rid of legacy types and API functions do the conversion here. Cc: "Rafael J. Wysocki" Cc: Mika Westerberg Cc: linux-a...@vger.kernel.org

[PATCH v1 3/6] staging: unisys: Switch to use new generic UUID API

2017-07-19 Thread Andy Shevchenko
There are new types and helpers that are supposed to be used in new code. As a preparation to get rid of legacy types and API functions do the conversion here. While here, re-indent couple of lines to increase readability. Cc: David Kershner Cc: Greg Kroah-Hartman

[PATCH v1 0/6] uuid: Convert rest users to new API

2017-07-19 Thread Andy Shevchenko
This series is converting the rest of the users of old UUID API to a new one and dropping UUID UAPI header away. Note, ABI is kept the same. User space should have not used those headers. We have libuuid and it likely would be extended to cover GUID operations. All patches have been compiled

[PATCH v1 1/6] efi: Switch to use new generic UUID API

2017-07-19 Thread Andy Shevchenko
There are new types and helpers that are supposed to be used in new code. As a preparation to get rid of legacy types and API functions do the conversion here. Cc: Matt Fleming Cc: Ard Biesheuvel Signed-off-by: Andy Shevchenko

[PATCH v1 2/6] mei: Switch to use new generic UUID API

2017-07-19 Thread Andy Shevchenko
There are new types and helpers that are supposed to be used in new code. As a preparation to get rid of legacy types and API functions do the conversion here. Cc: Tomas Winkler Cc: Guenter Roeck Cc: Samuel Ortiz

[PATCH v1 5/6] uuid: Kill uapi/uuid.h

2017-07-19 Thread Andy Shevchenko
There is no more users for uapi/uuid.h. Remove it for good. Anyone needs it in user space better to use libuuid. Signed-off-by: Andy Shevchenko --- include/linux/uuid.h | 20 +++- include/uapi/linux/uuid.h | 42

[PATCH] staging: pi433: fix bugs in register abstraction of rf69 chip

2017-07-19 Thread Wolf Entwicklungen
Bugfixes for rf69_set_modulation, rf69_set_deviation, rf69_set_lna_gain and rf69_get_lna_gain The fixes are cross-checked with the datasheet of the rfm69cw Fixes: 874bcba65f9a ("staging: pi433: New driver") Signed-off-by: Marcus Wolf diff --git

Re: [PATCH] netvsc: Remove redundant use of ipv6_hdr()

2017-07-19 Thread Stephen Hemminger
On Wed, 19 Jul 2017 13:48:03 -0400 (EDT) Mohammed Gamal wrote: > - Original Message - > > On Wed, 19 Jul 2017 15:19:28 +0200 > > Mohammed Gamal wrote: > > > > > This condition already uses an object of type ipv6hdr in the line above. > > > Use

Re: [PATCH] netvsc: Remove redundant use of ipv6_hdr()

2017-07-19 Thread Mohammed Gamal
- Original Message - > On Wed, 19 Jul 2017 15:19:28 +0200 > Mohammed Gamal wrote: > > > This condition already uses an object of type ipv6hdr in the line above. > > Use the object directly instead of calling ipv6_hdr > > > > Signed-off-by: Mohammed Gamal

Re: [PATCH] staging: pi433: fix a precedence bug

2017-07-19 Thread Marcus Wolf
Once again in plain text, only - sorry for frogetting to set the switch in my mailtool Hi Dan, Hi Walter, thank you for your investigation. rf69_get_modulation, rf69_get_lna_gain, rf69_set_lna_gain: Seems like I messed up a few things :-/ In the beginning, the defines were left-bound

Re: [PATCH 7/7] staging: fsl-mc: allow the driver compile multi-arch

2017-07-19 Thread kbuild test robot
Hi Laurentiu, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.13-rc1 next-20170718] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v3 1/3] Staging: speakup: speakup_keypc.c: usleep_range is preferred over udelay

2017-07-19 Thread Joe Perches
On Wed, 2017-07-19 at 17:55 +0530, Jaya Durga wrote: > Fix checkpatch issue: CHECK: usleep_range is preferred over udelay; [] > diff --git a/drivers/staging/speakup/speakup_keypc.c > b/drivers/staging/speakup/speakup_keypc.c [] > @@ -28,7 +28,7 @@ > > #define DRV_VERSION "2.10" > #define

Re: [PATCH] netvsc: Remove redundant use of ipv6_hdr()

2017-07-19 Thread Stephen Hemminger
On Wed, 19 Jul 2017 15:19:28 +0200 Mohammed Gamal wrote: > This condition already uses an object of type ipv6hdr in the line above. > Use the object directly instead of calling ipv6_hdr > > Signed-off-by: Mohammed Gamal > --- >

[PATCH] staging: lustre: lnet: fix incorrect arguments order calling lstcon_session_new

2017-07-19 Thread Colin King
From: Colin Ian King The arguments args->lstio_ses_force and args->lstio_ses_timeout are in the incorrect order. Fix this by swapping them around. Detected by CoverityScan, CID#1226833 ("Arguments in wrong order") Signed-off-by: Colin Ian King

Re: [PATCH 7/7] staging: fsl-mc: allow the driver compile multi-arch

2017-07-19 Thread kbuild test robot
Hi Laurentiu, [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.13-rc1 next-20170718] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] drivers: staging: comedi: Add ftrace support

2017-07-19 Thread Piotr Gregor
On Wed, Jul 19, 2017 at 04:21:06PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 19, 2017 at 02:57:28PM +0100, Piotr Gregor wrote: > > + * Id : Description > > + * 0 Enter the interrupt of amplc_dio200_common > > + * 1 Called from same ISR of amplc_dio200_common if IRQ is handled > >

[PATCH 081/102] staging: nvec: explicitly request exclusive reset control

2017-07-19 Thread Philipp Zabel
Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting reset lines") started to transition the reset control request API calls to explicitly state whether the driver needs exclusive or shared reset control behavior. Convert all drivers requesting exclusive resets to the explicit

RE: [PATCH] netvsc: Remove redundant use of ipv6_hdr()

2017-07-19 Thread Haiyang Zhang
> -Original Message- > From: Mohammed Gamal [mailto:mga...@redhat.com] > Sent: Wednesday, July 19, 2017 9:19 AM > To: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > Cc: de...@linuxdriverproject.org;

Re: [PATCH] drivers: staging: comedi: Add ftrace support

2017-07-19 Thread Greg Kroah-Hartman
On Wed, Jul 19, 2017 at 02:57:28PM +0100, Piotr Gregor wrote: > + * Id : Description > + * 0 Enter the interrupt of amplc_dio200_common > + * 1 Called from same ISR of amplc_dio200_common if IRQ is handled That is a very device-specific tracepoint, do we really want each driver to be able to set

[PATCH] drivers: staging: comedi: Add ftrace support

2017-07-19 Thread Piotr Gregor
This patch originates from the need to measure latency introduced by driver for Amplicon's PCIE215 during interrupt handling. Added is a single ftrace event: /* * Tracepoint for calling from various places inside Comedi. * Takes simple id and prints it to the trace log if trace * events from

Re: [PATCH] drivers: staging: comedi: Add ftrace support

2017-07-19 Thread Dan Carpenter
Everyone please delete this confidential email. Piotr is leakier than the Trump administration! ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] netvsc: Remove redundant use of ipv6_hdr()

2017-07-19 Thread Mohammed Gamal
This condition already uses an object of type ipv6hdr in the line above. Use the object directly instead of calling ipv6_hdr Signed-off-by: Mohammed Gamal --- drivers/net/hyperv/netvsc_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] drivers: staging: comedi: Add ftrace support

2017-07-19 Thread Piotr Gregor
This patch originates from the need to measure latency introduced by driver for Amplicon's PCIE215 during interrupt handling. Added is a single ftrace event: /* * Tracepoint for calling from various places inside Comedi. * Takes simple id and prints it to the trace log if trace * events from

Re: [PATCH v3 1/3] Staging: speakup: speakup_keypc.c: usleep_range is preferred over udelay

2017-07-19 Thread Greg KH
On Wed, Jul 19, 2017 at 05:36:28AM -0700, Joe Perches wrote: > On Wed, 2017-07-19 at 17:55 +0530, Jaya Durga wrote: > > Fix checkpatch issue: CHECK: usleep_range is preferred over udelay; > [] > > diff --git a/drivers/staging/speakup/speakup_keypc.c > > b/drivers/staging/speakup/speakup_keypc.c >

[PATCH v3 1/3] Staging: speakup: speakup_keypc.c: usleep_range is preferred over udelay

2017-07-19 Thread Jaya Durga
Fix checkpatch issue: CHECK: usleep_range is preferred over udelay; Signed-off-by: Jaya Durga --- drivers/staging/speakup/speakup_keypc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/speakup_keypc.c

[PATCH v3 3/3] Staging: iio: adc: ad7280a.c: Fixed Macro argument reuse

2017-07-19 Thread Jaya Durga
CHECK: Macro argument reuse 'addr' - possible side-effects? convert AD7280A_DEVADDR to ad7280a_devaddr static function to fix checkpath check v3: small style changes Signed-off-by: Jaya Durga --- drivers/staging/iio/adc/ad7280a.c | 21 + 1 file changed,

[PATCH v3 2/3] Staging: iio: light: tsl2x7x_core.c: Replace symbolic permission with octal permission

2017-07-19 Thread Jaya Durga
Replace symbolic permissions with their octect representation to fix checkpatch warnings. Signed-off-by: Jaya Durga --- drivers/staging/iio/light/tsl2x7x_core.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

Re: [PATCH 2/2] Staging: iio: light: tsl2x7x_core.c: Replace symbolic permission with octal permission

2017-07-19 Thread Greg KH
On Tue, Jul 18, 2017 at 12:53:23PM +0530, Jaya Durga wrote: > Replace symbolic permissions with their > octect representation to fix checkpatch warnings. > > Signed-off-by: Jaya Durga > --- > drivers/staging/iio/light/tsl2x7x_core.c | 20 ++-- > 1 file

Re: [PATCH v3 3/3] Staging: iio: adc: ad7280a.c: Fixed Macro argument reuse

2017-07-19 Thread Greg KH
On Tue, Jul 18, 2017 at 05:53:04PM +0530, Jaya Durga wrote: > CHECK: Macro argument reuse 'addr' - possible side-effects? > > convert AD7280A_DEVADDR to ad7280a_devaddr static function > to fix checkpath check > > v3: small style changes > > Signed-off-by: Jaya Durga > --- >

[PATCH v3 8/8] staging: fsl-mc: allow the driver compile multi-arch

2017-07-19 Thread laurentiu.tudor
From: Laurentiu Tudor Add an alternate dependency on COMPILE_TEST, thus leaving this driver compile on other architectures. Also, other drivers depending on the bus are updated to depend on ARCH_LAYERSCAPE until they'll also be made multi-arch. This was compiled tested

[PATCH v3 6/8] staging: fsl-mc: don't use raw device io functions

2017-07-19 Thread laurentiu.tudor
From: Laurentiu Tudor As raw device io functions are not portable and don't handle byte-order (triggering suspicion that endianness isn't handled well) switch to using the standard api. Since MC expects LE byte-order and the upper layers already take care of that, we

[PATCH v3 4/8] staging: fsl-mc: fix compilation with non-generic msi domain ops

2017-07-19 Thread laurentiu.tudor
From: Laurentiu Tudor The bus driver relies on generic msi domain ops. Fix compilation for architectures that don't provide it (e.g. x86_64). Signed-off-by: Laurentiu Tudor Acked-by: Arnd Bergmann --- Notes: -v3 -no

[PATCH v3 7/8] staging: fsl-mc: make the driver compile on 32-bit

2017-07-19 Thread laurentiu.tudor
From: Laurentiu Tudor Since there's no real constrain in MC to do only atomic 64-bit we can enable this driver on 32-bit platforms too. Include linux/io-64-nonatomic-hi-lo.h to make quad device io apis used in the driver available on 32-bit platforms. Signed-off-by:

[PATCH v3 5/8] staging: fsl-mc: fix formating of phys_addr_t on 32 bits

2017-07-19 Thread laurentiu.tudor
From: Laurentiu Tudor Use correct format specifier for phys_addr_t variables (%pa) instead of %llx. This fixes these warnings on 32 bit targets: "format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'phys_addr_t' [-Wformat=]"

[PATCH v3 1/8] staging: fsl-mc: add missing fsl_mc comment in struct msi_desc

2017-07-19 Thread laurentiu.tudor
From: Laurentiu Tudor The mc-bus specific field, fsl_mc in struct msi_desc is missing its comment so add it. Signed-off-by: Laurentiu Tudor Acked-by: Arnd Bergmann --- Notes: -v3 -no changes -v2 -no changes

[PATCH v3 0/8] staging: fsl-mc: make the driver compile on other architectures

2017-07-19 Thread laurentiu.tudor
From: Laurentiu Tudor Apart from a small change (first patch) which adds a missing comment, this series make the bus driver compile on other architectures, as per GregKH comment [1]. Compiled tested on: - booke powerpc (corenet{32,64}_smp_defconfig) with this ppc patch

[PATCH v3 3/8] staging: fsl-mc: drop useless gic v3 related #include

2017-07-19 Thread laurentiu.tudor
From: Laurentiu Tudor Nothing from linux/irqchip/arm-gic-v3.h is used, so the #include can be safely dropped. Signed-off-by: Laurentiu Tudor Acked-by: Arnd Bergmann --- Notes: -v3 -no changes -v2 -no changes

[PATCH v3 2/8] staging: fsl-mc: use generic memory barriers

2017-07-19 Thread laurentiu.tudor
From: Laurentiu Tudor No need to use arch-specific memory barriers; switch to using generic ones. The rmb()s were useless so drop them. Signed-off-by: Laurentiu Tudor Acked-by: Arnd Bergmann --- Notes: -v3 -no changes

Re: [PATCH] drivers: staging: comedi: Add ftrace support

2017-07-19 Thread Greg Kroah-Hartman
On Wed, Jul 19, 2017 at 12:30:28PM +0100, Piotr Gregor wrote: > > The information contained in this e-mail is confidential. It may also be > legally privileged. It is only intended for the stated addressee(s) and > access to it by any other person is unauthorised. > > If you are not an

Re: [PATCH] staging: pi433: fix a precedence bug

2017-07-19 Thread Dan Carpenter
Actually, please drop this patch. I looked at this one the same as I did the other one, but I didn't look closely enough. It's the same situation where we have two bugs that probably cancel each other out somewhat. It maybe needs to be fixed by someone who can test the code. In

Re: [PATCH] staging: pi433: fix a precedence bug

2017-07-19 Thread walter harms
Am 19.07.2017 11:51, schrieb Dan Carpenter: > We had intended to do the mask first and then the shift. Shift has > higher precedence so we need to add parenthesis. > > Fixes: 874bcba65f9a ("staging: pi433: New driver") > Signed-off-by: Dan Carpenter > > diff --git

[PATCH] [media] atomisp2: array underflow in imx_enum_frame_size()

2017-07-19 Thread Dan Carpenter
The code looks in imx_enum_frame_size() looks like this: 2066 int index = fse->index; 2067 struct imx_device *dev = to_imx_sensor(sd); 2068 2069 mutex_lock(>input_lock); 2070 if (index >= dev->entries_curr_table) { 2071

[PATCH] [media] atomisp2: array underflow in ap1302_enum_frame_size()

2017-07-19 Thread Dan Carpenter
The problem is this code from ap1302_enum_frame_size(): 738 int index = fse->index; 739 740 mutex_lock(>input_lock); 741 context = ap1302_get_context(sd); 742 if (index >= dev->cntx_res[context].res_num) { 743

[PATCH] [media] atomisp2: Array underflow in atomisp_enum_input()

2017-07-19 Thread Dan Carpenter
The problem here is this code from atomisp_enum_input(): 581 int index = input->index; 582 583 if (index >= isp->input_cnt) 584 return -EINVAL; 585 586 if (!isp->inputs[index].camera) 587 return -EINVAL;

[bug report] staging: pi433: New driver

2017-07-19 Thread Dan Carpenter
Hello Marcus Wolf, The patch 874bcba65f9a: "staging: pi433: New driver" from Jul 16, 2017, leads to the following static checker warning: drivers/staging/pi433/rf69.c:104 rf69_get_modulation() warn: shift has higher precedence than mask drivers/staging/pi433/rf69.c:206

[PATCH] staging: pi433: fix a precedence bug

2017-07-19 Thread Dan Carpenter
We had intended to do the mask first and then the shift. Shift has higher precedence so we need to add parenthesis. Fixes: 874bcba65f9a ("staging: pi433: New driver") Signed-off-by: Dan Carpenter diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c

[PATCH] staging: pi433: return -EFAULT if copy_to_user() fails

2017-07-19 Thread Dan Carpenter
copy_to_user() to user returns the number of bytes that weren't copied, but we should be returning -EFAULT to the user. Fixes: 874bcba65f9a ("staging: pi433: New driver") Signed-off-by: Dan Carpenter diff --git a/drivers/staging/pi433/pi433_if.c

[PATCH] staging: vboxvideo: make a couple of symbols static

2017-07-19 Thread Colin King
From: Colin Ian King Module parameter vbox_modeset and structure vbox_bo_driver do not need to be in global scope and hence can be made static. Cleans up a couple of sparse warnings: symbol 'vbox_modeset' was not declared. Should it be static? symbol 'vbox_bo_driver'

[PATCH] staging: rtl8723bs: fix build when DEBUG_RTL871X is defined

2017-07-19 Thread Stefan Assmann
From: Stefan Assmann Defining DEBUG_RTL871X in rtw_debug.h causes the following compile error: CC [M] drivers/staging/rtl8723bs/core/rtw_mlme.o In file included from drivers/staging/rtl8723bs/core/rtw_mlme.c:18:0: drivers/staging/rtl8723bs/core/rtw_mlme.c: In function

Re: [PATCH] staging: greybus: loopback: Enclose multiple macro statements in do-while loop

2017-07-19 Thread karthik
On Tuesday 18 July 2017 04:41 PM, Bryan O'Donoghue wrote: On 18/07/17 11:56, kart...@techveda.org wrote: From: Karthik Tummala Enclosed multiple macro statements in a do - while loop as per kernel coding standard, pointed by checkpatch. Signed-off-by: Karthik Tummala