Re: [PATCH] Staging: bcm2048: fix bare use of 'unsigned' in radio-bcm2048.c

2017-08-03 Thread kbuild test robot
Hi Branislav, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.13-rc3 next-20170803] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Branislav-Radocaj/Staging-bcm2048

Re: [PATCH 1/2] wireless: move prism54 out to staging

2017-08-03 Thread Greg KH
On Thu, Aug 03, 2017 at 04:59:36PM -0700, Luis R. Rodriguez wrote: > prism54 is deprecated in favor of the p54pci device driver. Although > only *one soul* had reported issues with it long ago Linux most Linux > distributions these days just disable the device driver given the > conflicts with the

[PATCH net 1/1] netvsc: fix race on sub channel creation

2017-08-03 Thread Stephen Hemminger
The existing sub channel code did not wait for all the sub-channels to completely initialize. This could lead to race causing crash in napi_netif_del() from bad list. The existing code would send an init message, then wait only for the initial response that the init message was received. It

[PATCH net 0/1] netvsc: race on sub channel open

2017-08-03 Thread Stephen Hemminger
Found this while testing mtu, queue and buffer size changes in 4.13, but the problem goes back much further. The addition of NAPI makes the race into a crash. Before that there was just a risk of sending on an uninitialized channel. Stephen Hemminger (1): netvsc: fix race on sub channel

[PATCH 1/2] wireless: move prism54 out to staging

2017-08-03 Thread Luis R. Rodriguez
prism54 is deprecated in favor of the p54pci device driver. Although only *one soul* had reported issues with it long ago Linux most Linux distributions these days just disable the device driver given the conflicts with the PCI IDs of p54pci and the *very* unlikely situation of folks really need

[PATCH 0/2] wireless: move prism54 to staging

2017-08-03 Thread Luis R. Rodriguez
Kalle, Greg, This moves the prism54 diver to staging. The reason for this are stated on the driver's own commit log. Let me know what tree you'd prefer this to go through. Luis R. Rodriguez (2): wireless: move prism54 out to staging MAINTAINERS: update email address for mcgrof for few

[PATCH 2/2] MAINTAINERS: update email address for mcgrof for few straggling drivers

2017-08-03 Thread Luis R. Rodriguez
This will ensure I get emails on my work and personal email address. Signed-off-by: Luis R. Rodriguez --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 97cf436e6750..49ae596584e7 100644 --- a/MAINTAINERS

[PATCH] staging: olpc_dcon: Fix coding style issue caught by checkpatch.pl related to function name in debug print

2017-08-03 Thread vergilzhang
Replace hard-coded function names in strings with "%s", __func__ in the olpc_dcon.c file. Issue found by checkpatch.pl. Signed-off-by: vergilzhang --- drivers/staging/olpc_dcon/olpc_dcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] staging: lustre: grab the cld->cld_lock mutex unconditionally

2017-08-03 Thread Cihangir Akturk
On Thu, Aug 03, 2017 at 05:52:44PM +0100, James Simmons wrote: > > > Instead of using the locked variable as a helper to determine the state > > of the mutex cld->cld_lock, expand the scope of the recover_cld variable > > and assign to the cld->cld_recover variable depending on whether the > >

Re: [PATCH] staging: lustre: declare fiemap_for_stripe static

2017-08-03 Thread James Simmons
> Declare fiemap_for_stripe as static to fix sparse warnings: > > > warning: symbol 'fiemap_for_stripe' was not declared. Should it be > > static? Acked-by: James Simmons > Signed-off-by: David Wittman > --- >

Re: [PATCH] staging: lustre: obd: make echo_lock_ops const

2017-08-03 Thread James Simmons
> Declare echo_lock_ops object of type cl_lock_operations as const as it > is only passed to the function cl_lock_slice_add. The corresponding > argument is of type const, so make the object const. > Acked-by: James Simmons > Signed-off-by: Bhumika Goyal

Re: [PATCH] staging: lustre: grab the cld->cld_lock mutex unconditionally

2017-08-03 Thread James Simmons
> > Instead of using the locked variable as a helper to determine the state > > of the mutex cld->cld_lock, expand the scope of the recover_cld variable > > and assign to the cld->cld_recover variable depending on whether the > > value of the recover_cld variable is valid or not. > > > > As a

Re: [PATCH] staging: lustre: grab the cld->cld_lock mutex unconditionally

2017-08-03 Thread James Simmons
> Instead of using the locked variable as a helper to determine the state > of the mutex cld->cld_lock, expand the scope of the recover_cld variable > and assign to the cld->cld_recover variable depending on whether the > value of the recover_cld variable is valid or not. > > As a bonus, code

Re: [PATCH] Staging: bcm2048: fix bare use of 'unsigned' in radio-bcm2048.c

2017-08-03 Thread Dan Carpenter
This breaks the build. Always try to compile your patches. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] Staging: bcm2048: fix bare use of 'unsigned' in radio-bcm2048.c

2017-08-03 Thread Branislav Radocaj
This is a patch to the radio-bcm2048.c file that fixes up a warning found by the checkpatch.pl tool. Signed-off-by: Branislav Radocaj --- drivers/staging/media/bcm2048/radio-bcm2048.c | 44 +-- 1 file changed, 22 insertions(+), 22 deletions(-)

Re: [PATCH V2] staging: ccree: Fix format/argument mismatches

2017-08-03 Thread Joe Perches
On Thu, 2017-08-03 at 17:09 +0800, kbuild test robot wrote: > Hi Joe, > > [auto build test WARNING on staging/staging-testing] > [also build test WARNING on next-20170803] > [cannot apply to v4.13-rc3] > [if your patch is applied to the wrong git tree, please drop us a note

Re: [PATCH] Remove explicit return type cast

2017-08-03 Thread Dan Carpenter
cannot apply to v4.13-rc3] > > [if your patch is applied to the wrong git tree, please drop us a note to > > help improve the system] > > > > url: > > https://github.com/0day-ci/linux/commits/Hari-Prasath/Remove-explicit-return-type-cast/20170803-080312 >

Re: [PATCH] Remove explicit return type cast

2017-08-03 Thread hari prasath
rop us a note to > help improve the system] > > url: > https://github.com/0day-ci/linux/commits/Hari-Prasath/Remove-explicit-return-type-cast/20170803-080312 > config: blackfin-allyesconfig (attached as .config) > compiler: bfin-uclinux-gcc (GCC) 6.2.0 > reproduce: >

[PATCH] staging: media: use relevant lock

2017-08-03 Thread Julia Lawall
The data protected is video_out2 and the lock that is released is _out2->dma_queue_lock, so it seems that that lock should be taken as well. Signed-off-by: Julia Lawall --- drivers/staging/media/davinci_vpfe/dm365_resizer.c |2 +- 1 file changed, 1 insertion(+), 1

[PATCH 29/29] staging: vboxvideo: switch to drm_*{get,put} helpers

2017-08-03 Thread Cihangir Akturk
drm_*_reference() and drm_*_unreference() functions are just compatibility alias for drm_*_get() and drm_*_put() adn should not be used by new code. So convert all users of compatibility functions to use the new APIs. Signed-off-by: Cihangir Akturk ---

[PATCH v2 2/4] staging: pi433: Change Comments

2017-08-03 Thread Rishabh Hardas
Signed-off-by: Rishabh Hardas --- drivers/staging/pi433/pi433_if.h | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h index 91e4a01..84032f3 100644 ---

[PATCH v2 3/4] staging: pi433: Renaming Enums

2017-08-03 Thread Rishabh Hardas
Signed-off-by: Rishabh Hardas --- drivers/staging/pi433/pi433_if.h | 36 drivers/staging/pi433/rf69.c | 26 +- drivers/staging/pi433/rf69.h | 26 +-

[PATCH v2 4/4] staging: pi433: Remove camel case variable names

2017-08-03 Thread Rishabh Hardas
Signed-off-by: Rishabh Hardas --- drivers/staging/pi433/pi433_if.c | 4 ++-- drivers/staging/pi433/pi433_if.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index

[PATCH v2 1/4] staging: pi433: Style fix - Correct long lines

2017-08-03 Thread Rishabh Hardas
Signed-off-by: Rishabh Hardas --- drivers/staging/pi433/pi433_if.h | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h index e6ed3cd..91e4a01 100644 ---

[PATCH v2 0/4] staging: pi433: Rename camel case and other style issues

2017-08-03 Thread Rishabh Hardas
Hi, This series pf patches solves some of the coding style issues. I have corrected long lines, changed comment style, renamed enums and variables that were in camel case. Tried to get zero erros and warnings on the pi433_if.h file. Regards, Rishabh Hardas Rishabh Hardas (4): staging: pi433:

Re: [PATCH] staging: vboxvideo: select DRM_TTM

2017-08-03 Thread Hans de Goede
Hi, On 01-08-17 20:05, Cihangir Akturk wrote: vboxvideo code uses various ttm_* functions, so it needs "drivers/gpu/drm/ttm/*" to be built. In order to build these objects select DRM_TTM. This commit fixes "ttm_*" undefined build errors. Signed-off-by: Cihangir Akturk

[PATCH] staging: lustre: obd: make echo_lock_ops const

2017-08-03 Thread Bhumika Goyal
Declare echo_lock_ops object of type cl_lock_operations as const as it is only passed to the function cl_lock_slice_add. The corresponding argument is of type const, so make the object const. Signed-off-by: Bhumika Goyal ---

Re: [PATCH V2] staging: ccree: Fix format/argument mismatches

2017-08-03 Thread kbuild test robot
Hi Joe, [auto build test WARNING on staging/staging-testing] [also build test WARNING on next-20170803] [cannot apply to v4.13-rc3] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Joe-Perches

Re: [PATCH] Remove explicit return type cast

2017-08-03 Thread kbuild test robot
/Remove-explicit-return-type-cast/20170803-080312 config: blackfin-allyesconfig (attached as .config) compiler: bfin-uclinux-gcc (GCC) 6.2.0 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross