On Sat, 16 Sep 2017 15:22:23 -0700
Jonathan Cameron wrote:
> On Thu, 14 Sep 2017 16:31:06 +0200
> Michael Hennerich wrote:
>
> > On 14.09.2017 15:50, Stefan Popa wrote:
> > > SPI host drivers can use DMA to transfer data, so the buffer should be
> > > properly allocated.
> > > Keeping it on
On Thu, 14 Sep 2017 16:31:06 +0200
Michael Hennerich wrote:
> On 14.09.2017 15:50, Stefan Popa wrote:
> > SPI host drivers can use DMA to transfer data, so the buffer should be
> > properly allocated.
> > Keeping it on the stack could cause an undefined behavior.
> >
> > The dedicated reset fun
On Sat, 16 Sep 2017 14:18:52 +0200
Paolo Cretaro wrote:
> On 16/09/2017 13:37, Dan Carpenter wrote:
> > On Sat, Sep 16, 2017 at 01:11:29PM +0200, Paolo Cretaro wrote:
> >> Hi Dan,
> >> just minor nitpicking on the commit message:
> >>
> >> On 08/09/2017 12:53, Dan Carpenter wrote:
> >>> The b
On Sat, 16 Sep 2017, Srishti Sharma wrote:
> Eliminate the fields that are not used and the comments
> associated with them.
>
> Signed-off-by: Srishti Sharma
Acked-by: Julia Lawall
> ---
> Changes in v2:
> - Use the word field instead of variable.
>
> drivers/staging/dgnc/dgnc_driver.h |
On Sat, 16 Sep 2017, Srishti Sharma wrote:
> Remove unused fields and comments associated with them in
> the structure definition.
>
> Signed-off-by: Srishti Sharma
Acked-by: Julia Lawall
> ---
> Changes in v2:
> - Use the word field instead of variable.
>
> drivers/staging/dgnc/dgnc_drive
From: Colin Ian King
txbuf16 is being initialized at declaration time and then later
set to another value without it being read inbetween, hence making
the initialization redundant. Fix this by setting txbuf16 just
the once. Also clean up some incorrect indentations. Cleans up
clang build warnin
Remove unused fields and comments associated with them in
the structure definition.
Signed-off-by: Srishti Sharma
---
Changes in v2:
- Use the word field instead of variable.
drivers/staging/dgnc/dgnc_driver.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/dgnc/dgn
Eliminate the fields that are not used and the comments
associated with them.
Signed-off-by: Srishti Sharma
---
Changes in v2:
- Use the word field instead of variable.
drivers/staging/dgnc/dgnc_driver.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.
Remove fields that are not used, from structure definitions , and
eliminate the comments associated with them.
Srishti Sharma (2):
Staging: dgnc: Remove unused variables in structure definition
Staging: dgnc: Remove unused variable in structure
drivers/staging/dgnc/dgnc_driver.h | 15 --
From: Colin Ian King
Variable idx is being set but never read and thus it can be
removed because it is redundant. Cleans up clang build warnings:
warning: Value stored to 'idx' during its initialization is never read
warning: Value stored to 'idx' is never read
warning: Value stored to 'idx' is
On Sat, 16 Sep 2017, Srishti Sharma wrote:
> This patch series attempts to remove unused variables in structure
> variables and the comments associated with them.
Actually, I would say that a structure has fields, not variables.
julia
>
> Srishti Sharma (2):
> Staging: dgnc: Remove unused v
Eliminate the variables that are not used and the comments
associated with them.
Signed-off-by: Srishti Sharma
---
drivers/staging/dgnc/dgnc_driver.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
b/drivers/staging/dgnc/dgnc_driver.h
index 5d2566e..0
Remove unused variables and comments associated with them in
the structure definition.
Signed-off-by: Srishti Sharma
---
drivers/staging/dgnc/dgnc_driver.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
b/drivers/staging/dgnc/dgnc_driver.h
index 7
This patch series attempts to remove unused variables in structure
variables and the comments associated with them.
Srishti Sharma (2):
Staging: dgnc: Remove unused variables in structure definition
Staging: dgnc: Remove unused variable in structure
drivers/staging/dgnc/dgnc_driver.h | 15 --
On Sat, Sep 16, 2017 at 5:45 PM, Julia Lawall wrote:
>
>
> On Sat, 16 Sep 2017, Srishti Sharma wrote:
>
>> On Sat, Sep 16, 2017 at 5:20 PM, Julia Lawall wrote:
>> >
>> >
>> > On Sat, 16 Sep 2017, Srishti Sharma wrote:
>> >
>> >> Some variables in the structure were unused and hence them and
>> >>
On 16/09/2017 13:37, Dan Carpenter wrote:
> On Sat, Sep 16, 2017 at 01:11:29PM +0200, Paolo Cretaro wrote:
>> Hi Dan,
>> just minor nitpicking on the commit message:
>>
>> On 08/09/2017 12:53, Dan Carpenter wrote:
>>> The background of this code is that we can either use the default
>>> tables or l
On Sat, 16 Sep 2017, Srishti Sharma wrote:
> On Sat, Sep 16, 2017 at 5:20 PM, Julia Lawall wrote:
> >
> >
> > On Sat, 16 Sep 2017, Srishti Sharma wrote:
> >
> >> Some variables in the structure were unused and hence them and
> >> the comments associated with them can be removed.
> >
> > How did
On Sat, Sep 16, 2017 at 5:20 PM, Julia Lawall wrote:
>
>
> On Sat, 16 Sep 2017, Srishti Sharma wrote:
>
>> Some variables in the structure were unused and hence them and
>> the comments associated with them can be removed.
>
> How did you find these? The last two can easily be checked with grep,
Hi Dan,
just minor nitpicking on the commit message:
On 08/09/2017 12:53, Dan Carpenter wrote:
> The background of this code is that we can either use the default
> tables or load our own table with sysfs. The default tables are three
> element arrays of struct tsl2x7x_lux. If we load the table
On Sat, 16 Sep 2017, Srishti Sharma wrote:
> Some variables in the structure were unused and hence them and
> the comments associated with them can be removed.
How did you find these? The last two can easily be checked with grep, but
that is ont the case for type.
Actually there are two struc
Some variables in the structure were unused and hence them and
the comments associated with them can be removed.
Signed-off-by: Srishti Sharma
---
drivers/staging/dgnc/dgnc_driver.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
b/drivers/stagi
On Sat, Sep 16, 2017 at 01:11:29PM +0200, Paolo Cretaro wrote:
> Hi Dan,
> just minor nitpicking on the commit message:
>
> On 08/09/2017 12:53, Dan Carpenter wrote:
> > The background of this code is that we can either use the default
> > tables or load our own table with sysfs. The default tabl
On Fri, 15 Sep 2017, Haneen Mohammed wrote:
> Replace use of the combination of list_for_each and list_entry
> with list_for_each_entry to simplify the code and remove variables
> that are used only in list_for_each.
> Issue found and corrected using Coccinelle script:
>
> @r@
> expression head,
On Sat, 16 Sep 2017, Srishti Sharma wrote:
> Test for NULL as !x where functions that return NULL on failure
> are used. Done using the following semantic patch by coccinelle.
>
> @ is_null @
> expression E;
> statement S;
> @@
>
> E = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\|
> us
24 matches
Mail list logo
