Re: [PATCH] staging: ccree: Fix lines longer than 80 characters

On Mon, Oct 23, 2017 at 07:53:18AM -0700, Stephen Brennan wrote: > Simply break down some long lines and tab-indent them. Hi Stephen, Welcome to the Linux kernel. Great that you have put in a patch, you are, however, unlikely to see success fixing 'line over 80' warnings. There are a bunch of

[staging:staging-testing 240/312] drivers/staging/rtlwifi/base.c:2167: warning: unused variable 'hw'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing head: 7706abf5a0eb4c082897fd2a17a0ac0898e39666 commit: f8af6a323368dd28fcea9742d582593c9adb2261 [240/312] staging: rtlwifi: Convert timers to use timer_setup() config: x86_64-randconfig-v0-10240403

Re: [PATCH 00/20] mark expected switch fall-throughs

Quoting "Gustavo A. R. Silva" : In preparation to enabling -Wimplicit-fallthrough, this patchset aims to mark switch cases where we are expecting to fall through. In Kees Cook words: "This is an unfortunate omission in the C language, and thankfully both gcc and clang

Re: [PATCH v2 1/4] android: binder: Don't get mm from task

On Sat, Oct 21, 2017 at 1:15 AM, Greg Kroah-Hartman wrote: > On Fri, Oct 20, 2017 at 08:58:58PM -0400, Sherry Yang wrote: >> Use binder_alloc struct's mm_struct rather than getting >> a reference to the mm struct through get_task_mm to >> avoid a potential deadlock

drivers/staging/wilc1000/host_interface.c:: 6 * pointless test ?

Hello there, drivers/staging/wilc1000/host_interface.c:512:36: warning: comparison is always true due to limited range of data type [-Wtype-limits] Source code is cfg_param_attr->auth_timeout < 65536) { Suggest remove pointless test. Some duplicates:

Re: [PATCH] staging: rtl8822be: fix wrong dma unmap len

On 10/23/2017 04:35 AM, Stanislaw Gruszka wrote: Patch fixes splat: r8822be :04:00.0: DMA-API: device driver frees DMA memory with different size [device address=0x78477000] [map size=4096 bytes] [unmap size=424 bytes] Call Trace: debug_dma_unmap_page+0xa5/0xb0 ?

[PATCH v6 2/2] staging: ion: create one device entry per heap

Instead a getting only one common device "/dev/ion" for all the heaps this patch allow to create one device entry ("/dev/ionX") per heap. Getting an entry per heap could allow to set security rules per heap and global ones for all heaps. Allocation requests will be only allowed if the mask_id

[PATCH v6 1/2] staging: ion: simplify ioctl args checking function

Make arguments checking more easy to read. Signed-off-by: Benjamin Gaignard Acked-by: Laura Abbott --- drivers/staging/android/ion/ion-ioctl.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

[PATCH v6 0/2] staging: ion: get one device per heap

version 6: - add platform_bus and platform_bus_type when register Ion devices to make them appear in /sys/devices/platform. - re-order include files in aphabetic order. version 5: - create a configuration flag to keep legacy Ion misc device version 4: - add a configuration flag to switch

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

2017-10-18 22:07 GMT+02:00 Laura Abbott : > On 09/27/2017 06:20 AM, Benjamin Gaignard wrote: >> diff --git a/drivers/staging/android/ion/ion.c >> b/drivers/staging/android/ion/ion.c >> index 93e2c90..092b24c 100644 >> --- a/drivers/staging/android/ion/ion.c >> +++

[PATCH] staging: ccree: Fix lines longer than 80 characters

Simply break down some long lines and tab-indent them. Signed-off-by: Stephen Brennan --- I'm learning the patch submission process, and this is my first patch. I know it's trivial but I'm just trying to get my feet wet. Thanks in advance for taking the time to review this!

Re: [PATCH] staging: wilc1000: replace redundant computations with 0

On Tue, Oct 10, 2017 at 03:05:48PM +0100, Colin King wrote: > From: Colin Ian King > > Shifting and masking strHostIfSetMulti->enabled is redundant since > enabled is a bool and so all the shifted and masked values will be > zero. Replace them with zero to simplify the

[PATCH] staging: rtl8822be: fix wrong dma unmap len

Patch fixes splat: r8822be :04:00.0: DMA-API: device driver frees DMA memory with different size [device address=0x78477000] [map size=4096 bytes] [unmap size=424 bytes] Call Trace: debug_dma_unmap_page+0xa5/0xb0 ? unmap_single+0x2f/0x40

Re: staging: rtsx: Add support for RTS5260

On Mon, 16 Oct 2017, mario.limoncie...@dell.com wrote: > > -Original Message- > > From: Lee Jones [mailto:lee.jo...@linaro.org] > > Sent: Friday, October 13, 2017 4:15 PM > > To: Limonciello, Mario > > Cc: rui_f...@realsil.com.cn; gre...@linuxfoundation.org;

Re: [PATCH 13/13] staging: iio: tsl2x7x: add goto for TSL2X7X_LUX_CALC_OVER_FLOW

On Thu, Oct 19, 2017 at 04:06:32PM -0400, Brian Masney wrote: > This patch adds a return_max label for the two cases that need to set > the lux to TSL2X7X_LUX_CALC_OVER_FLOW and return. > > Signed-off-by: Brian Masney > --- > drivers/staging/iio/light/tsl2x7x.c | 9

[PATCH] Staging: rtlwifi: pci: fixed a coding style issue

Fixed a coding style issue. There was a prohibited space. Removed. Signed-off-by: Woohyung-Jeon --- drivers/staging/rtlwifi/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtlwifi/pci.c b/drivers/staging/rtlwifi/pci.c index

Re: [PATCH] Staging: rtlwifi: pci: fixed coding style issues

On Mon, Oct 23, 2017 at 04:44:24PM +0900, Woohyung Jeon wrote: > Fixed 2 coding style issues. > > There was two coding style issues and they were fixed. > c:2233 - unnecessary parenthesis was there, so removed. > c:652 - prohibited space was there, so removed. That's two different things, please

[PATCH] Staging: rtlwifi: pci: fixed coding style issues

Fixed 2 coding style issues. There was two coding style issues and they were fixed. c:2233 - unnecessary parenthesis was there, so removed. c:652 - prohibited space was there, so removed. Signed-off-by: Woohyung-Jeon --- drivers/staging/rtlwifi/pci.c | 4 ++-- 1 file

[GIT PULL] Staging/IIO driver fixes for 4.14-rc6

The following changes since commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f: Linux 4.14-rc4 (2017-10-08 20:53:29 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.14-rc6 for you to fetch changes up to