Re: [PATCH v2] staging: comedi: add missing MODULE_DESCRIPTION/LICENSE

* Ian Abbott [2017-11-20 10:46:36 +]: On 20/11/17 10:29, Ian Abbott wrote: On 20/11/17 07:50, Jesse Chan wrote: This change resolves a new compile-time warning when built as a loadable module: WARNING: modpost: missing MODULE_LICENSE() in

[PATCH 23/30] [media] atomisp: deprecate pci_get_bus_and_slot()

pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Use pci_get_domain_bus_and_slot() with a domain number of 0 where we can't extract the domain number. Other places, use

[PATCH 24/30] staging: rts5208: deprecate pci_get_bus_and_slot()

pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Use pci_get_domain_bus_and_slot() with a domain number of 0 where we can't extract the domain number. Other places, use

Re: [PATCH] Fix style issues in olpc_dcon

Missing subsystem in subject line. Please use the same git brief description format that has been used previously for files you want to patch. You can view previous commits for a file using git log --pretty=oneline --abbrev --reverse On Mon, Nov 20, 2017 at 03:14:21PM -0600,

Re: [PATCH] Staging: comedi: adl_pci9118: fixed some parentheses coding style issue

You may like to limit the git log brief description to 50 characters (this is going to be hard with such a long pre-fix though :) Brief description should be in imperative mood i.e 'Fix foo' instead of 'fixed foo'. On Tue, Nov 21, 2017 at 05:17:53PM -0200, Guilherme Tadashi Maeoka wrote: > Fixed

Re: [PATCH v2] staging: fsl-mc: fix mc-portal to use u32 type

On Tue, Nov 21, 2017 at 10:35:23AM +0530, Bharat Bhushan wrote: > According to MC APIs, size of mc-portal in 32bit. > Also fsl_create_mc_io() storing 32 bit mc-portal size. >" mc_io->portal_size = mc_portal_size;" >While "mc_io->portal_size" is u16 type and >"mc_portal_size" is u32

[PATCH v2 2/2] olpc_dcon: Line up parentheses in func calls and defs

From: Zebulon McCorkle Line up arguments to opening parentheses and ensure lines stay under 80 columns, since checkpatch.pl was complaining about incorrect indentation in function calls and definitions. Signed-off-by: Zebulon McCorkle ---

[PATCH v2 0/2] olpc_dcon: Fix style issues

From: Zebulon McCorkle checkpatch.pl was complaining about style issues in the olpc_dcon driver. I've split this into two patches at the request of Greg Kroah-Hartman's patch-bot. Zebulon McCorkle (2): olpc_dcon: Change bitshifts to BIT macro olpc_dcon: Line up

[PATCH v2 1/2] olpc_dcon: Change bitshifts to BIT macro

From: Zebulon McCorkle checkpatch.pl reported the bitshifts (1< --- drivers/staging/olpc_dcon/olpc_dcon.h | 30 +++--- 1 file

[PATCH] tools/hv: Fix IP reporting by KVP daemon with SRIOV

From: Haiyang Zhang On Hyper-V the VF NIC has the same MAC as the related synthetic NIC. VF NIC can work under the synthetic NIC transparently, without its own IP address. The existing KVP daemon only gets IP from the first NIC matching a MAC address, and may not be able

[PATCH] Staging: comedi: adl_pci9118: fixed some parentheses coding style issue

Fixed some code style issues. Signed-off-by: Guilherme Tadashi Maeoka --- drivers/staging/comedi/drivers/adl_pci9118.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c

[PATCH 33/50] staging: most: video: remove aim designators

This patch takes the 'aim' prefixes and variable names off the module and uses component instead. It is needed because userspace interfacing modules are referred to as components. Signed-off-by: Christian Gromm --- drivers/staging/most/video/video.c | 152

[PATCH 38/50] staging: most: fix comment sections

This patch updates and corrects the comment sections of the code. Signed-off-by: Christian Gromm --- drivers/staging/most/cdev/cdev.c | 4 +- drivers/staging/most/core.c| 108 - drivers/staging/most/core.h|

[PATCH 44/50] staging: most: update driver usage file

From: Andrey Shvetsov This patch keeps the usage file up to date. Signed-off-by: Christian Gromm --- .../staging/most/Documentation/driver_usage.txt| 192 +++-- 1 file changed, 105 insertions(+), 87 deletions(-) diff

[PATCH 40/50] staging: most: core: fix formatting

This patch fixes coding style violations. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c| 7 +-- drivers/staging/most/video/video.c | 2 +- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/most/core.c

[PATCH 49/50] staging: most: add ABI documentation

This patchg adds the sysfs-bus-most.txt file to the source tree. It is needed to have an ABI description of the driver's sysfs interface. Signed-off-by: Christian Gromm --- .../most/Documentation/ABI/sysfs-bus-most.txt | 313 + 1 file

[PATCH 42/50] staging: most: core: fix data type

This patch fixes the type used to manage the channels of an registered MOST interface. Signed-off-by: Christian Gromm --- drivers/staging/most/core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/most/core.h

[PATCH 50/50] staging: most: usb: fix show/store function names

This patch renames the show/store functions of the USB module. It is needed to make the module meet the established naming convention. Signed-off-by: Christian Gromm --- drivers/staging/most/usb/usb.c | 34 +- 1 file changed, 17

[PATCH 46/50] staging: most: cdev: bundle module variables in structure

This patch creates the structure comp to put the module variables for encapsulation purposes. For an improved readability some variables are renamed. Signed-off-by: Christian Gromm --- drivers/staging/most/cdev/cdev.c | 88

[PATCH 43/50] staging: most: core: check value returned by match function

This patch adds a check for the pointer returned by the function match_component. It is needed to prevent a NULL pointer dereference in case the provided component name does not match any list entry. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c |

[PATCH 48/50] staging: most: core: fix list traversing

From: Andrey Shvetsov This patch fixes the offset and data handling when traversing the list of devices that are attached to the bus. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c | 17 + 1 file changed,

[PATCH 47/50] staging: most: core: remove class generation

This patch stops the core from generating a module owned class and registering it with the kernel. It is needed, because there is no need for a default MOST class to be present in the kernel. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c | 13

[PATCH 41/50] staging: most: usb: clear functional stall on OUT endpoint

For the MOST packet channel there are two dedicated USB endpoints. But internally the hardware has actually one channel for data forwarding from and to MOST. To have the hardware clean up its state machine correctly in case of an error, both USB pipes need to be reset. This patch triggers the

[PATCH 26/50] staging: most: rename struct most_aim

The designator of a module that proivdes means to interface userspace is called an AIM. Since this name seems to be unappropiate, this kind of moduels are going to be referred to as componetns. This is done because such modules function as components to enhance the core with new features. This

[PATCH 28/50] staging: most: core: rename mod_list

This patch renames the variable mod_list to comp_list. It is needed because modules that interface userspace are referred to as components. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH 29/50] staging: most: core: rename aim variables

This patch replaces the 'aim' substrings of variable names with 'comp'. It is needed because of the renaming of AIM modules to components. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c | 172 ++-- 1 file

[PATCH 21/50] staging: most: core: rename function

The core module used to have two functions to find a certain channel. One by name and one by interface. Since no channel is searched by its interface name anymore the by_name suffix is rendered redundant. This patch renames the function accordingly. Signed-off-by: Christian Gromm

[PATCH 45/50] staging: most: cdev: replace function prefix

This patch replaces the function prefixes aim_* with comp_*. It is needed to complete the process of changing the module designator from AIM to Component. Signed-off-by: Christian Gromm --- drivers/staging/most/cdev/cdev.c | 58

[PATCH 32/50] staging: most: sound: remove aim designator

This patch removes all 'aim' designators and replaces them with 'comp'. It is needd because userspace interfacing modules are referred to as components. Signed-off-by: Christian Gromm --- drivers/staging/most/sound/sound.c | 16 1 file changed, 8

[PATCH 39/50] staging: most: core: denote modules as components

Substrings containing 'module' are replaced with 'component' by this patch. It is needed to complete the process of changing the module designator from AIM to Component. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c | 24

[PATCH 36/50] staging: most: cdev: rename class instance aim_class

This patch renames the instance aim_class of struct class to comp_class. It is needed to complete the process of changing the module designator from AIM to Component. Signed-off-by: Christian Gromm --- drivers/staging/most/cdev/cdev.c | 16 1

[PATCH 37/50] staging: most: cdev: rename variable cdev_aim

This patch renames the variable cdev_aim to cdev_comp. It is needed to complete the process of changing the module designator from AIM to Component. Signed-off-by: Christian Gromm --- drivers/staging/most/cdev/cdev.c | 18 +- 1 file changed, 9

[PATCH 35/50] staging: most: cdev: rename variable aim_devno

This patch renames the variable aim_devno to comp_devno. It is needed to complete the process of changing the module designator from AIM to Component. Signed-off-by: Christian Gromm --- drivers/staging/most/cdev/cdev.c | 10 +- 1 file changed, 5

[PATCH 34/50] staging: most: cdev: rename struct aim_channel

This patch renames the structure aim_channel to comp_channel. It is needed to complete the process of changing the module designator from AIM to Component. Signed-off-by: Christian Gromm --- drivers/staging/most/cdev/cdev.c | 38

[PATCH 18/50] staging: most: core: track aim modules with linked list

The core needs to know what modules are registered. This patch makes the core keep track of the registered modules. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c | 6 -- drivers/staging/most/core.h | 1 + 2 files changed, 5 insertions(+), 2

[PATCH 19/50] staging: most: core: fix sysfs attribute management

This patch creates a new attribute group to manage the attributes of a registered aim module in sysfs and changes the show and store functions accordingly. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c | 109

[PATCH 23/50] staging: most: core: put channel name in struct most_channel

This patch stores a channel's name inside the most_channel structure. It is needed to have the channel attributes tied together. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-)

[PATCH 27/50] staging: most: rename functions to register a driver with most_core

This patch renames the functions to register and deregister a component module with the core. It is needed because the modules that interface the userspace are referred to as components. Signed-off-by: Christian Gromm --- drivers/staging/most/cdev/cdev.c | 4

[PATCH 31/50] staging: most: net: remove aim designators

This patch renames the all aim designators with comp. It is needed because userspace interfacing modules are referred to as components. Signed-off-by: Christian Gromm --- drivers/staging/most/net/net.c | 44 +- 1 file

[PATCH 17/50] staging: most: core: use structure to pack driver specific data

This patch introduces the structure "mostcore" to bundle core specific data structures. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c | 73 + 1 file changed, 34 insertions(+), 39 deletions(-) diff --git

[PATCH 30/50] staging: most: core: rename function link_channel_to_aim

This patch renames the function link_channel_to_aim to link_channel_to_component. It is needed because userspace interfacing modules are referred to as components. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c | 8 1 file changed, 4

[PATCH 22/50] staging: most: core: replace struct most_inst_obj

This patch introduces struct interface_private as a replacement for the struct most_inst_obj. This structure holds private data that is only needed by the core module and will be accessed by a pointer from within the most_interface structure. As a result of this replacement the bus helper

[PATCH 25/50] staging: most: usb: remove pointer initialization

This patch removes the initialization of the priv pointer of the most_interface structure. Signed-off-by: Christian Gromm --- drivers/staging/most/usb/usb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/most/usb/usb.c

[PATCH 24/50] staging: most: core: remove context pointer

This patch removes the unused context pointer that was meant to provide the opportunity to store context information. Signed-off-by: Christian Gromm --- drivers/staging/most/core.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/most/core.h

[PATCH 07/50] staging: most: usb: rename module

This patch renames the folder of the usb module. It is needed to clean up the directory layout of the driver. Signed-off-by: Christian Gromm --- drivers/staging/most/Kconfig | 2 +- drivers/staging/most/{hdm-usb => usb}/Kconfig |

[PATCH 16/50] staging: most: core: rename members aim* of struct most_channel

This patch renames the struct members "aim0" and "aim0" to "pipe0" and "pipe1". It is needed to have a conclusive nomenclature of the struct and its instances. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c | 104

[PATCH 20/50] staging: most: core: remove struct device

This patch takes out the struct device of struct most_aim, because it is not needed. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c | 17 - drivers/staging/most/core.h | 1 - 2 files changed, 18 deletions(-) diff --git

[PATCH 15/50] staging: most: core: rename struct memeber

This patch renames the member "ptr" of struct pipe to "aim". This is needed to increase the readability of the code. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c | 78 ++--- 1 file changed, 39

[PATCH 04/50] staging: most: dim2: rename module

This patch renames the folder and source files of the dim2 module. It is needed to clear the directory layout of the driver. Signed-off-by: Christian Gromm --- drivers/staging/most/Kconfig | 2 +- drivers/staging/most/{hdm-dim2

[PATCH 11/50] staging: most: core: add a match function for the bus

This patch adds the function most_match. It is needed to accociate registered devices and drivers with the bus. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/most/core.c

[PATCH 14/50] staging: most: core: rename struct most_c_aim_obj to pipe

This patch replaces the confusing name of struct "most_c_aim_obj" with "pipe" to better express the function that is behind the structure. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH 13/50] staging: most: core: rename structure

This patch renames the structure most_c_obj to most_channel. This is needed to enhance readability. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c | 104 ++-- 1 file changed, 52 insertions(+), 52 deletions(-)

[PATCH 05/50] staging: most: net: rename module

This patch renames the folder and the source file of the networking module. It is needed to clean up the directory layout of the driver. Signed-off-by: Christian Gromm --- drivers/staging/most/Kconfig | 2 +-

[PATCH 10/50] staging: most: core: remove function get_channel_by_iface

This patch removes the function get_channel_by_iface that walks a list of all registered interfaces and returns a pointer to a channel when matched. Instead the private field of the interface structure is used to directly access the channel via the id. The patch is needed to remove unnecessary

[PATCH 08/50] staging: most: video: rename module

This patch renames the folder of the video module. It is needed to clean up the directory layout of the driver. Signed-off-by: Christian Gromm --- drivers/staging/most/Kconfig | 2 +- drivers/staging/most/{aim-v4l2 => video}/Kconfig | 6 +++---

[PATCH 12/50] staging: most: core: encapsulate code in function

This patch adds the function link_channel_to_aim to increase readability of the function add_link_store. Signed-off-by: Christian Gromm --- drivers/staging/most/core.c | 39 ++- 1 file changed, 26 insertions(+), 13 deletions(-)

[PATCH 01/50] staging: most: move core files

This patch moves the core files to the root dir of the driver. This is needed to clean up the directory layout. Signed-off-by: Christian Gromm --- drivers/staging/most/Kconfig | 13 - drivers/staging/most/Makefile

[PATCH 03/50] staging: most: i2c: rename module

This patch renames the folder of the i2c module. It is needed to clear the directory layout. Signed-off-by: Christian Gromm --- drivers/staging/most/Kconfig | 2 +- drivers/staging/most/{hdm-i2c => i2c}/Kconfig | 6 +++---

[PATCH 09/50] staging: most: remove proprietary kobjects

This patch removes the proprietary kobjects used by the driver modules and replaces them with device structs. The patch is needed to have the driver being integrated into the kernel's device model. Signed-off-by: Christian Gromm ---

[PATCH 02/50] staging: most: cdev: rename module

This patch renames the folder of the cdev module. This is needed to clear the directory layout. Signed-off-by: Christian Gromm --- drivers/staging/most/Kconfig| 2 +- drivers/staging/most/{aim-cdev => cdev}/Kconfig | 6 +++---

[PATCH 06/50] staging: most: sound: rename module

This patch renames the folder of the sound module. It is needed to clean up the directory layout of the driver. Signed-off-by: Christian Gromm --- drivers/staging/most/Kconfig | 2 +- drivers/staging/most/{aim-sound => sound}/Kconfig | 6

[PATCH 00/50] staging: most: rework driver architecture and fix defects

This patch set fixes bugs and integrates the driver to the kernel's device model by revising its architecture. Part of this change is rearranging the directory layout, renaming of files and folders and thereby creating a clean driver structure. Andrey Shvetsov (2): staging: most: update driver