Re: [PATCH 0/9] media: imx: Add better OF graph support

2017-12-07 Thread Steve Longerbeam
On 12/07/2017 03:23 PM, Steve Longerbeam wrote: Hi Hans, On 12/04/2017 05:44 AM, Hans Verkuil wrote: Of course, any such simplification can also be done after this series has been applied, but I don't know what your thoughts are on this. I do prefer the sub-notifier approach to

[PATCH net 1/3] hv_netvsc: Correct the max receive buffer size

2017-12-07 Thread Stephen Hemminger
From: Haiyang Zhang It should be 31 MB on recent host versions. Signed-off-by: Haiyang Zhang Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 6 -- 1 file changed, 4 insertions(+), 2

[PATCH net 0/3] netvsc fix buffer size issues

2017-12-07 Thread Stephen Hemminger
The changes to allow setting buffer size can cause issues on older versions of Windows Server which have smaller limits. And the actual maximum value for WS2016 is 31M not 16M. This is a resend of patchset that didn't make it to netdev correctly. Haiyang Zhang (3): hv_netvsc: Correct the max

[PATCH net 3/3] hv_netvsc: Fix the default receive buffer size

2017-12-07 Thread Stephen Hemminger
From: Haiyang Zhang The intended size is 16 MB, and the default slot size is 1728. So, NETVSC_DEFAULT_RX should be 16*1024*1024 / 1728 = 9709. Fixes: 5023a6db73196 ("netvsc: increase default receive buffer size") Signed-off-by: Haiyang Zhang

[PATCH net 2/3] hv_netvsc: Limit the receive buffer size for legacy hosts

2017-12-07 Thread Stephen Hemminger
From: Haiyang Zhang Legacy hosts only allow 15 MB receive buffer, and we know the NVSP version only after negotiation. So, we put the limit in netvsc_init_buf(). Fixes: 5023a6db73196 ("netvsc: increase default receive buffer size") Signed-off-by: Haiyang Zhang

Re: [PATCH 0/9] media: imx: Add better OF graph support

2017-12-07 Thread Steve Longerbeam
Hi Hans, On 12/04/2017 05:44 AM, Hans Verkuil wrote: Hi Steve, On 10/28/2017 10:36 PM, Steve Longerbeam wrote: This is a set of patches that improve support for more complex OF graphs. Currently the imx-media driver only supports a single device with a single port connected directly to

[PATCH] staging: pi433: Add spaces around & and + operator

2017-12-07 Thread Simon Sandström
Fixes checkpatch warning: "spaces preferred around that '&'". Signed-off-by: Simon Sandström --- drivers/staging/pi433/rf69.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/staging/pi433/rf69.c

Re: [PATCH] staging: lustre: Fix sparse, using plain integer as NULL pointer in lov_object_fiemap()

2017-12-07 Thread Joe Perches
On Wed, 2017-12-06 at 09:53 +0100, gre...@linuxfoundation.org wrote: > On Mon, Dec 04, 2017 at 12:44:32PM +0200, Andrii Vladyka wrote: > > Change 0 to NULL in lov_object_fiemap() in order to fix warning produced by > > sparse > > > > Signed-off-by: Andrii Vladyka > >

[PATCH] staging: pi433: Fix ISO-8859 encoded non-english comments

2017-12-07 Thread Simon Sandström
Some comments, like "without memcpy would be nice", are removed. Other comments are just translated to english. rf69.c is now plain ASCII. Signed-off-by: Simon Sandström --- drivers/staging/pi433/rf69.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff

[PATCH v2] drivers: visorbus: move driver out of staging

2017-12-07 Thread David Kershner
Move the visorbus driver out of staging (drivers/staging/unisys/visorbus) and to drivers/visorbus. Modify the configuration and makefiles so they now reference the new location. The s-Par header file visorbus.h that is referenced by all s-Par drivers, is being moved into include/linux.

Re: [PATCH 1/6] staging: pi433: Split rf69_set_crc_enabled into two functions

2017-12-07 Thread Greg KH
On Thu, Dec 07, 2017 at 03:58:01PM +0100, Simon Sandström wrote: > On Thu, Dec 07, 2017 at 03:38:57PM +0100, Greg KH wrote: > > On Wed, Dec 06, 2017 at 09:42:19PM +0100, Simon Sandström wrote: > > > Splits rf69_set_crc_enabled(dev, enabled) into > > > rf69_enable_crc(dev) and

Re: [PATCH 1/6] staging: pi433: Split rf69_set_crc_enabled into two functions

2017-12-07 Thread Simon Sandström
On Thu, Dec 07, 2017 at 03:38:57PM +0100, Greg KH wrote: > On Wed, Dec 06, 2017 at 09:42:19PM +0100, Simon Sandström wrote: > > Splits rf69_set_crc_enabled(dev, enabled) into > > rf69_enable_crc(dev) and rf69_disable_crc(dev). > > > > Signed-off-by: Simon Sandström > > --- > >

Re: [PATCHv3] staging: pi433: pi433_if.c remove SET_CHECKED macro

2017-12-07 Thread Greg Kroah-Hartman
On Wed, Dec 06, 2017 at 09:53:37PM +0100, Nguyen Phan Quang Minh wrote: > The macro calls its argument -a function- twice, makes the calling > function return prematurely -skipping resource cleanup code- and hurts > understandability. > > Signed-off-by: Nguyen Phan Quang Minh

Re: [PATCH 1/6] staging: pi433: Split rf69_set_crc_enabled into two functions

2017-12-07 Thread Greg KH
On Wed, Dec 06, 2017 at 09:42:19PM +0100, Simon Sandström wrote: > Splits rf69_set_crc_enabled(dev, enabled) into > rf69_enable_crc(dev) and rf69_disable_crc(dev). > > Signed-off-by: Simon Sandström > --- > drivers/staging/pi433/pi433_if.c | 22 -- >

Re: [PATCH] Staging: rtl8192u: Fix no spaces around '+'

2017-12-07 Thread Greg KH
On Wed, Dec 06, 2017 at 09:32:01PM +0530, Akash Kumar wrote: > Added spaces around '+'. Warning found using checkpatch.pl > Signed-off-by: Akash Kumar Please put a blank line before your signed-off-by line. I'll fix it up this time, but be more careful next time. thanks,

Re: [PATCH v4 6/8] staging: octeon: Remove USE_ASYNC_IOBDMA macro.

2017-12-07 Thread Greg Kroah-Hartman
On Tue, Nov 28, 2017 at 04:55:38PM -0800, David Daney wrote: > Previous patch sets USE_ASYNC_IOBDMA to 1 unconditionally. Remove > USE_ASYNC_IOBDMA from all if statements. Remove dead code caused by > the change. > > Signed-off-by: David Daney Acked-by: Greg

Re: [PATCH 1/2] staging: fsl-mc: Allocate IRQ's before scanning DPRC objects

2017-12-07 Thread Laurentiu Tudor
On 12/07/2017 03:18 PM, Nipun Gupta wrote: > > >> -Original Message- >> From: Laurentiu Tudor >> Sent: Wednesday, December 06, 2017 19:00 >> To: Nipun Gupta ; stuyo...@gmail.com; Bharat >> Bhushan ; gre...@linuxfoundation.org; >>

RE: [PATCH 1/2] staging: fsl-mc: Allocate IRQ's before scanning DPRC objects

2017-12-07 Thread Nipun Gupta
> -Original Message- > From: Laurentiu Tudor > Sent: Wednesday, December 06, 2017 19:00 > To: Nipun Gupta ; stuyo...@gmail.com; Bharat > Bhushan ; gre...@linuxfoundation.org; > cakt...@gmail.com; bretth...@gmail.com; a...@arndb.de > Cc:

[PATCH 4.14 21/75] staging: greybus: loopback: Fix iteration count on async path

2017-12-07 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Bryan O'Donoghue [ Upstream commit 44b02da39210e6dd67e39ff1f48d30c56d384240 ] Commit 12927835d211 ("greybus: loopback: Add asynchronous bi-directional support")

[PATCH 4.9 015/109] staging: greybus: loopback: Fix iteration count on async path

2017-12-07 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Bryan O'Donoghue [ Upstream commit 44b02da39210e6dd67e39ff1f48d30c56d384240 ] Commit 12927835d211 ("greybus: loopback: Add asynchronous bi-directional support")

staging: pi433: Plans from Smarthome-Wolf

2017-12-07 Thread Marcus Wolf
Am 06.12.2017 um 14:47 schrieb Dan Carpenter: > On Wed, Dec 06, 2017 at 11:11:27AM +0200, Marcus Wolf wrote: >> >> Since the rule for kernel development seems to be, not to care about future, >> most probably you patch is fine, anyway. >> > > Yeah. Deleting code if there is no user is required

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

2017-12-07 Thread Dan Carpenter
On Thu, Dec 07, 2017 at 12:17:32AM +0200, Marcus Wolf wrote: > To be honest, I am a little bit astonished about that question. Don't you do > a regression test after such a redesign? I would be a little bit afraid to > offer such redesign without testing. He probably doesn't have the hardware...

Re: [PATCH 01/10] staging: ccree: remove inline qualifiers

2017-12-07 Thread Dan Carpenter
On Thu, Dec 07, 2017 at 09:00:11AM +0200, Gilad Ben-Yossef wrote: > On Mon, Dec 4, 2017 at 11:36 AM, Dan Carpenter > wrote: > > On Sun, Dec 03, 2017 at 01:58:12PM +, Gilad Ben-Yossef wrote: > >> The ccree drivers was marking a lot of big functions in C file as > >>

Re: [PATCH 1/1] codestyle issue fixed drivers/staging/vc04_services

2017-12-07 Thread Stefan Wahren
Hello Mikhail, Am 07.12.2017 um 08:47 schrieb Mikhail Shvetsov: > From: Mike please provide your full name and a changelog. Also the subject should start with something like "staging: vchiq_arm:". > > Signed-off-by: Mike > --- >